RE: [EXT] Re: [PATCH v2 01/13] security: add direction in SA/SC configuration

2023-06-07 Thread Akhil Goyal
> On Wed, Jun 7, 2023 at 5:20 PM Akhil Goyal wrote: > > > > MACsec SC/SA ids are created based on direction of the flow. > > Hence, added the missing field for configuration and cleanup > > of the SCs and SAs. > > > > Signed-off-by: Akhil Goyal > > --- > > devtools/libabigail.abignore | 7

[PATCH v3 13/13] test/security: remove no MACsec support case

2023-06-07 Thread Akhil Goyal
Removed the test_capability_get_no_support_for_macsec case as MACsec is now supported and capability can have valid MACsec support. Signed-off-by: Akhil Goyal --- app/test/test_security.c | 37 - 1 file changed, 37 deletions(-) diff --git a/app/test/test_secu

[PATCH v3 12/13] test/security: verify MACsec anti replay

2023-06-07 Thread Akhil Goyal
From: Ankur Dwivedi This patch enables anti replay test case for MACsec. Signed-off-by: Ankur Dwivedi Signed-off-by: Akhil Goyal --- app/test/test_security_inline_macsec.c| 82 +++ .../test_security_inline_macsec_vectors.h | 467 ++ 2 files changed, 549 insertions

[PATCH v3 09/13] test/security: verify MACsec interrupts

2023-06-07 Thread Akhil Goyal
From: Ankur Dwivedi This patch enables the test_inline_macsec_interrupts_all test case for MACSEC. Signed-off-by: Ankur Dwivedi Signed-off-by: Akhil Goyal --- app/test/test_security_inline_macsec.c| 124 +++ .../test_security_inline_macsec_vectors.h | 306 +- 2

[PATCH v3 11/13] test/security: verify MACsec Rx rekey

2023-06-07 Thread Akhil Goyal
From: Ankur Dwivedi This patch enables the Rx rekey test case for MACSEC. Signed-off-by: Ankur Dwivedi --- app/test/test_security_inline_macsec.c | 50 +- 1 file changed, 49 insertions(+), 1 deletion(-) diff --git a/app/test/test_security_inline_macsec.c b/app/test/te

[PATCH v3 10/13] test/security: verify MACsec Tx HW rekey

2023-06-07 Thread Akhil Goyal
This patch enables the Tx HW rekey test case for MACSEC. Signed-off-by: Ankur Dwivedi Signed-off-by: Akhil Goyal --- app/test/test_security_inline_macsec.c| 137 +- .../test_security_inline_macsec_vectors.h | 243 ++ 2 files changed, 378 insertions(+), 2 dele

[PATCH v3 07/13] test/security: add MACsec negative cases

2023-06-07 Thread Akhil Goyal
Added MACsec negative test cases to verify pkt drop, untagged rx, bad tag rx, sa not in use, out packets untagged, pkts too long. Signed-off-by: Akhil Goyal --- app/test/test_security_inline_macsec.c| 346 + .../test_security_inline_macsec_vectors.h | 475

[PATCH v3 08/13] test/security: verify MACsec stats

2023-06-07 Thread Akhil Goyal
Added cases to verify various stats of MACsec. Signed-off-by: Akhil Goyal --- app/test/test_security_inline_macsec.c | 222 + 1 file changed, 222 insertions(+) diff --git a/app/test/test_security_inline_macsec.c b/app/test/test_security_inline_macsec.c index 2a06f31f37.

[PATCH v3 03/13] test/security: add inline MACsec cases

2023-06-07 Thread Akhil Goyal
Updated test app to verify Inline MACsec offload using rte_security APIs. A couple of test cases are added to verify encap only and decap only of some known test vectors from MACsec specification. Signed-off-by: Akhil Goyal --- app/test/meson.build |1 + app/test/tes

[PATCH v3 06/13] test/security: add MACsec VLAN cases

2023-06-07 Thread Akhil Goyal
Added cases to verify MACsec processing with VLAN tags inserted. Vectors are added to verify 1/2/3 VLAN tags in clear or encrypted data. Signed-off-by: Akhil Goyal --- app/test/test_security_inline_macsec.c| 67 ++ .../test_security_inline_macsec_vectors.h | 217

[PATCH v3 04/13] test/security: add MACsec integrity cases

2023-06-07 Thread Akhil Goyal
Added test vectors and test cases to verify auth_only/verify_only and encap-decap/auth-verify to verify the complete TX-RX path using the loopback mode of ethdev. Signed-off-by: Akhil Goyal --- app/test/test_security_inline_macsec.c| 153 +++ .../test_security_inline_macsec_vectors.h

[PATCH v3 01/13] security: add direction in SA/SC configuration

2023-06-07 Thread Akhil Goyal
MACsec SC/SA ids are created based on direction of the flow. Hence, added the missing field for configuration and cleanup of the SCs and SAs. Signed-off-by: Akhil Goyal --- devtools/libabigail.abignore | 4 lib/security/rte_security.c| 16 ++-- lib/security/rte_se

[PATCH v3 02/13] security: add MACsec packet number threshold

2023-06-07 Thread Akhil Goyal
Added Packet number threshold parameter in MACsec SC configuration to identify the maximum allowed threshold for packet number field in the packet. A field is_xpn is also added to identify if the SAs are configured for extended packet number or not so that packet number threshold can be configured

[PATCH v3 00/13] Add MACsec unit test cases

2023-06-07 Thread Akhil Goyal
Inline MACsec offload was supported in DPDK 22.11 using rte_security APIs. This patchset adds few minor changes in the rte_security APIs to specify the direction of SA/SC and update the SC configuration to set packet number threshold. The patchset also add functional test cases in dpdk-test app to

[PATCH v3 05/13] test/security: verify multi flow MACsec

2023-06-07 Thread Akhil Goyal
Added test case and test vectors to verify multiple flows of MACsec. Signed-off-by: Akhil Goyal --- app/test/test_security_inline_macsec.c| 49 .../test_security_inline_macsec_vectors.h | 110 +- 2 files changed, 158 insertions(+), 1 deletion(-) diff --git

RE: [PATCH v4 0/4] Support VFIO sparse mmap in PCI bus

2023-06-07 Thread Xia, Chenbo
> -Original Message- > From: Ali Alnubani > Sent: Thursday, June 8, 2023 2:43 PM > To: Li, Miao ; dev@dpdk.org; NBU-Contact-Thomas > Monjalon (EXTERNAL) > Cc: sk...@marvell.com; david.march...@redhat.com; ferruh.yi...@amd.com; > Xia, Chenbo ; Cao, Yahui ; > Patrick Robb > Subject: RE: [P

RE: [PATCH v4 0/4] Support VFIO sparse mmap in PCI bus

2023-06-07 Thread Ali Alnubani
> -Original Message- > From: Miao Li > Sent: Wednesday, May 31, 2023 8:38 AM > To: dev@dpdk.org > Cc: sk...@marvell.com; NBU-Contact-Thomas Monjalon (EXTERNAL) > ; david.march...@redhat.com; > ferruh.yi...@amd.com; chenbo@intel.com; yahui@intel.com > Subject: [PATCH v4 0/4] Support

[Bug 1245] Windows build failure with clang (unresolved external symbol)

2023-06-07 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1245 Bug ID: 1245 Summary: Windows build failure with clang (unresolved external symbol) Product: DPDK Version: 23.07 Hardware: All OS: All Status: UNCONFIRM

[PATCH] net/iavf: fix abnormal disable HW interrupt

2023-06-07 Thread Mingjin Ye
For command VIRTCHNL_OP_REQUEST_QUEUES, polling access to the admin queue has the issue of access overruns after disabling interrupt. That results in FW disabling HW interrupt for protection purposes. The updates/changes in this patch: 1. Remove the polling admin queue processing and use the gener

[PATCH v4] app/dma-perf: introduce dma-perf application

2023-06-07 Thread Cheng Jiang
There are many high-performance DMA devices supported in DPDK now, and these DMA devices can also be integrated into other modules of DPDK as accelerators, such as Vhost. Before integrating DMA into applications, developers need to know the performance of these DMA devices in various scenarios and

Re: [PATCH v1] event/dlb2: add support for disabling PASID

2023-06-07 Thread Jerin Jacob
On Thu, Jun 8, 2023 at 2:31 AM Abdullah Sevincer wrote: > > vfio-pci driver in Linux kernel 6.2 enables PASID by default. > In DLB hardware, enabling PASID puts DLB in SIOV mode. This > breaks DLB PF-PMD mode. For DLB PF-PMD mode to function properly > PASID needs to be disabled for kernel 6.2. >

Re: [PATCH v9 13/17] graph: enable graph multicore dispatch scheduler model

2023-06-07 Thread Jerin Jacob
On Thu, Jun 8, 2023 at 8:39 AM Yan, Zhirun wrote: > > > > > -Original Message- > > From: Jerin Jacob > > Sent: Wednesday, June 7, 2023 9:26 PM > > To: Yan, Zhirun > > Cc: dev@dpdk.org; jer...@marvell.com; kirankum...@marvell.com; > > ndabilpu...@marvell.com; step...@networkplumber.org; >

RE: [EXT] [PATCH 1/2] config/arm: update config for Neoverse N2

2023-06-07 Thread Ruifeng Wang
> -Original Message- > From: Pavan Nikhilesh Bhagavatula > Sent: Thursday, June 8, 2023 12:35 PM > To: Ruifeng Wang ; bruce.richard...@intel.com > Cc: dev@dpdk.org; jer...@marvell.com; Honnappa Nagarahalli > ; > Feifei Wang ; nd ; nd > Subject: RE: [EXT] [PATCH 1/2] config/arm: update co

RE: [EXT] [PATCH 1/2] config/arm: update config for Neoverse N2

2023-06-07 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Ruifeng Wang > Sent: Thursday, June 8, 2023 9:59 AM > To: Pavan Nikhilesh Bhagavatula ; > bruce.richard...@intel.com > Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran ; > Honnappa Nagarahalli ; Feifei Wang > ; nd ; nd > Subject: RE: [EXT] [PATCH 1/2] config/arm

RE: [EXT] [PATCH 1/2] config/arm: update config for Neoverse N2

2023-06-07 Thread Ruifeng Wang
> -Original Message- > From: Pavan Nikhilesh Bhagavatula > Sent: Wednesday, June 7, 2023 11:12 PM > To: Ruifeng Wang ; bruce.richard...@intel.com > Cc: dev@dpdk.org; jer...@marvell.com; Honnappa Nagarahalli > ; > Feifei Wang ; nd > Subject: RE: [EXT] [PATCH 1/2] config/arm: update config

RE: [RFC v3 0/3] add frequency adjustment support for PTP timesync

2023-06-07 Thread Su, Simei
Hi Ferruh, > -Original Message- > From: Ferruh Yigit > Sent: Thursday, June 8, 2023 2:29 AM > To: Su, Simei ; tho...@monjalon.net; > andrew.rybche...@oktetlabs.ru; Rybalchenko, Kirill > ; Zhang, Qi Z > Cc: dev@dpdk.org; Wu, Wenjun1 > Subject: Re: [RFC v3 0/3] add frequency adjustment su

RE: [PATCH v4] gro : ipv6 changes to support GRO for TCP/ipv6

2023-06-07 Thread Hu, Jiayu
Hi Kumara, Please see replies inline. In addition, you need to update the programmer guide in generic_receive_offload_lib.rst, and release note release_23_07.rst. Thanks, Jiayu > -Original Message- > From: Kumara Parameshwaran > Sent: Tuesday, June 6, 2023 10:58 PM > To: Hu, Jiayu >

RE: [PATCH v9 17/17] doc: update multicore dispatch model in graph guides

2023-06-07 Thread Yan, Zhirun
> -Original Message- > From: Jerin Jacob > Sent: Wednesday, June 7, 2023 8:46 PM > To: Yan, Zhirun > Cc: dev@dpdk.org; jer...@marvell.com; kirankum...@marvell.com; > ndabilpu...@marvell.com; step...@networkplumber.org; > pbhagavat...@marvell.com; Liang, Cunming ; Wang, > Haiyue ; mattia

[PATCH 4/4] net/nfp: fix TOS of IPv6 NVGRE encap flow action

2023-06-07 Thread Chaoyong He
The former logic directly do shift operation on big endian data, fix it by convert the big endian data into CPU endian firstly. Fixes: fff680eef7f9 ("net/nfp: support IPv6 NVGRE encap flow action") Cc: sta...@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- drivers/net/nfp

[PATCH 3/4] net/nfp: fix TOS of IPv6 GENEVE encap flow action

2023-06-07 Thread Chaoyong He
The former logic directly do shift operation on big endian data, fix it by convert the big endian data into CPU endian firstly. Fixes: 98fa36eccc4c ("net/nfp: support IPv6 GENEVE encap flow action") Cc: sta...@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- drivers/net/nf

[PATCH 2/4] net/nfp: fix TOS of IPv6 VXLAN encap flow action

2023-06-07 Thread Chaoyong He
The former logic directly do shift operation on big endian data, fix it by convert the big endian data into CPU endian firstly. Fixes: c3b7254093c2 ("net/nfp: support IPv6 VXLAN encap flow action") Cc: sta...@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- drivers/net/nfp

[PATCH 1/4] net/nfp: fix the IPv6 flow item

2023-06-07 Thread Chaoyong He
When process the IPv6 flow item, the former logic perform the mask operation between one big endian value and one CPU endian valude, which cause the match of DSCP filed not work as expect. Fix it by convert the big endian data into CPU endian and remove the unneeded mask operation. Fixes: d965074

[PATCH 0/4] fix the data endian problem in IPv6 logic

2023-06-07 Thread Chaoyong He
This patch series fix the data endian problem in the logics related with rte_flow of IPv6. Chaoyong He (4): net/nfp: fix the IPv6 flow item net/nfp: fix TOS of IPv6 VXLAN encap flow action net/nfp: fix TOS of IPv6 GENEVE encap flow action net/nfp: fix TOS of IPv6 NVGRE encap flow action

RE: [PATCH v9 13/17] graph: enable graph multicore dispatch scheduler model

2023-06-07 Thread Yan, Zhirun
> -Original Message- > From: Jerin Jacob > Sent: Wednesday, June 7, 2023 9:26 PM > To: Yan, Zhirun > Cc: dev@dpdk.org; jer...@marvell.com; kirankum...@marvell.com; > ndabilpu...@marvell.com; step...@networkplumber.org; > pbhagavat...@marvell.com; Liang, Cunming ; Wang, > Haiyue ; mattia

RE: [PATCH v9 04/17] graph: add get/set graph worker model APIs

2023-06-07 Thread Yan, Zhirun
> -Original Message- > From: Jerin Jacob > Sent: Wednesday, June 7, 2023 9:29 PM > To: Yan, Zhirun > Cc: dev@dpdk.org; jer...@marvell.com; kirankum...@marvell.com; > ndabilpu...@marvell.com; step...@networkplumber.org; > pbhagavat...@marvell.com; Liang, Cunming ; Wang, > Haiyue ; mattia

[PATCH] net/nfp: fix callback function pointer of disabling promisc

2023-06-07 Thread Chaoyong He
From: Qin Ke The callback function of promiscuous_disable in nfp_flower_pf_repr_dev_ops and nfp_flower_repr_dev_ops should be nfp_net_promisc_disable, not nfp_net_promisc_enable, fix it. Fixes: 39d82d2 ("net/nfp: fix promiscuous mode for representor port") Cc: Chaoyong He Cc: sta...@dpdk.org S

RE: [PATCH] doc: announce inclusive naming macro name changes

2023-06-07 Thread Xia, Chenbo
> -Original Message- > From: Chaoyong He > Sent: Wednesday, June 7, 2023 10:44 AM > To: dev@dpdk.org > Cc: oss-driv...@corigine.com; niklas.soderl...@corigine.com; Long Wu > ; Chaoyong He > Subject: [PATCH] doc: announce inclusive naming macro name changes > > From: Long Wu > > In orde

RE: [PATCH] doc: announce inclusive naming function name changes

2023-06-07 Thread Xia, Chenbo
> -Original Message- > From: Chaoyong He > Sent: Friday, May 19, 2023 2:34 PM > To: dev@dpdk.org > Cc: oss-driv...@corigine.com; niklas.soderl...@corigine.com; Chaoyong He > > Subject: [PATCH] doc: announce inclusive naming function name changes > > In order to support inclusive naming,

[PATCH] net/bonding: fix destroy dedicated queues flow

2023-06-07 Thread Chaoyong He
From: Long Wu Bonding port in mode 4 enables dedicated queues, we will create a flow for this feature. So we need to destroy this flow when we remove the member port. Furthermore if we don't destroy the flow that created for dedicated queues when we remove the member port, maybe we couldn't add

RE: [PATCH v9 15/17] examples/l3fwd-graph: introduce multicore dispatch worker model

2023-06-07 Thread Yan, Zhirun
> -Original Message- > From: Jerin Jacob > Sent: Wednesday, June 7, 2023 9:58 PM > To: Yan, Zhirun > Cc: dev@dpdk.org; jer...@marvell.com; kirankum...@marvell.com; > ndabilpu...@marvell.com; step...@networkplumber.org; > pbhagavat...@marvell.com; Liang, Cunming ; Wang, > Haiyue ; mattia

[PATCH v2] net/ice:fix tunnel packet TX descriptor error

2023-06-07 Thread Shiyang He
The TX descriptor of tunnel packet filled incorrectly due to the MACLEN is not set. This patch fixes this issue by setting MACLEN to correctly fill the TX descriptor. Fixes: bd70c451532c ("net/ice: support Tx checksum offload for tunnel") Cc: sta...@dpdk.org Signed-off-by: Shiyang He --- drive

RE: [PATCH v5 26/26] vhost: add VDUSE device stop

2023-06-07 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Tuesday, June 6, 2023 4:19 PM > To: dev@dpdk.org; Xia, Chenbo ; > david.march...@redhat.com; m...@redhat.com; f...@redhat.com; > jasow...@redhat.com; Liang, Cunming ; Xie, Yongji > ; echau...@redhat.com; epere...@redhat.com; > amore...@r

RE: [PATCH v5 24/26] vhost: add VDUSE device startup

2023-06-07 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Tuesday, June 6, 2023 4:19 PM > To: dev@dpdk.org; Xia, Chenbo ; > david.march...@redhat.com; m...@redhat.com; f...@redhat.com; > jasow...@redhat.com; Liang, Cunming ; Xie, Yongji > ; echau...@redhat.com; epere...@redhat.com; > amore...@r

Re: [PATCH v2] net/tap: resolve stringop-overflow with gcc 12 on ppc64le

2023-06-07 Thread Stephen Hemminger
On Wed, 7 Jun 2023 19:47:04 +0100 Ferruh Yigit wrote: > On 5/16/2023 10:55 AM, Ferruh Yigit wrote: > > On 5/16/2023 2:28 AM, Stephen Hemminger wrote: > >> On Tue, 16 May 2023 00:35:56 +0100 > >> Ferruh Yigit wrote: > >> > >>> Yes only some scripts and possible applications that hotplug tap >

Re: [PATCH v2 00/13] support telemetry query ethdev info

2023-06-07 Thread Jie Hai
On 2023/6/7 19:40, Ferruh Yigit wrote: On 6/7/2023 8:41 AM, Jie Hai wrote: This patchset supports querying information about ethdev. The information includes MAC addresses, RxTx offload, flow ctrl, Rx|Tx queue, firmware version, DCB, RSS, FEC, VLAN, etc. v1->v2: 1. Fix incorrect argument of cal

RE: [PATCH v5 00/26] Add VDUSE support to Vhost library

2023-06-07 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Wednesday, June 7, 2023 10:59 PM > To: Xia, Chenbo ; dev@dpdk.org; > david.march...@redhat.com; m...@redhat.com; f...@redhat.com; > jasow...@redhat.com; Liang, Cunming ; Xie, Yongji > ; echau...@redhat.com; epere...@redhat.com; > amore..

RE: [PATCH v4 0/4] Support VFIO sparse mmap in PCI bus

2023-06-07 Thread Xia, Chenbo
Hi Patrick, Oops.. Seems weird as patchwork does not report anything. Please reach out to me when you get some information about why it’s failing. I could fix it ASAP. Thanks, Chenbo From: Patrick Robb Sent: Thursday, June 8, 2023 8:29 AM To: Thomas Monjalon Cc: Li, Miao ; dev@dpdk.org; sk...

RE: [PATCH v4 0/4] Support VFIO sparse mmap in PCI bus

2023-06-07 Thread Xia, Chenbo
Hi Thomas, > -Original Message- > From: Thomas Monjalon > Sent: Thursday, June 8, 2023 12:31 AM > To: Li, Miao > Cc: dev@dpdk.org; sk...@marvell.com; david.march...@redhat.com; > ferruh.yi...@amd.com; Xia, Chenbo ; Cao, Yahui > > Subject: Re: [PATCH v4 0/4] Support VFIO sparse mmap in P

Re: [PATCH v4 0/4] Support VFIO sparse mmap in PCI bus

2023-06-07 Thread Patrick Robb
Hello, This patchseries might have introduced a bug for building DPDK on windows. It failed on windows build when it went through our CI last week, and I am seeing other patch series fail on the windows build now that it is merged into main. Tomorrow morning, I will check our windows system used

[PATCH v1] event/dlb2: add support for disabling PASID

2023-06-07 Thread Abdullah Sevincer
vfio-pci driver in Linux kernel 6.2 enables PASID by default. In DLB hardware, enabling PASID puts DLB in SIOV mode. This breaks DLB PF-PMD mode. For DLB PF-PMD mode to function properly PASID needs to be disabled for kernel 6.2. In this commit this issue is addressed and PASID is disabled by writ

[PATCH v3] net/vmxnet3: fix return code in initializing

2023-06-07 Thread Kaijun Zeng
Improve error handling Bugzilla ID: 1239 Fixes: dfaff37fc46d ("vmxnet3: import new vmxnet3 poll mode driver implementation") Cc: sta...@dpdk.org Signed-off-by: Kaijun Zeng --- v3: * Improve coding style v2: * Improve error handling --- drivers/net/vmxnet3/vmxnet3_rxtx.c | 15 +++

[PATCH] net/vmxnet3: fix return code in initializing

2023-06-07 Thread Kaijun Zeng
Improve error handling and code style Bugzilla ID: 1239 Fixes: dfaff37fc46d ("vmxnet3: import new vmxnet3 poll mode driver implementation") Cc: sta...@dpdk.org Signed-off-by: Kaijun Zeng --- drivers/net/vmxnet3/vmxnet3_rxtx.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletion

Re: [PATCH v8] mem: telemetry support for memseg and element information

2023-06-07 Thread David Marchand
On Wed, May 17, 2023 at 11:22 AM Amit Prakash Shukla wrote: > > Changes adds telemetry support to display memory occupancy > in memseg and the information of the elements allocated from > a memseg based on arguments provided by user. This patch > adds following endpoints: > > 1. /eal/memseg_lists

Re: [PATCH v4] eal: fix eal init may failed when too much continuous memsegs under legacy mode

2023-06-07 Thread David Marchand
On Mon, May 29, 2023 at 1:23 PM Fengnan Chang wrote: > > Under legacy mode, if the number of continuous memsegs greater > than RTE_MAX_MEMSEG_PER_LIST, eal init will failed even though > another memseg list is empty, because only one memseg list used > to check in remap_needed_hugepages. > Fix thi

Re: [PATCH] eal/linux: register mp hotplug callback after memory init

2023-06-07 Thread David Marchand
Hello Zhihong, On Wed, May 31, 2023 at 8:55 AM Zhihong Wang wrote: > > Secondary would crash if it tries to handle mp requests before memory > init, since globals such as eth_dev_shared_data_lock are not accessible > to it at this moment. Can you please resend this patch with a SoB ? Thanks. --

Re: [PATCH v2 01/13] security: add direction in SA/SC configuration

2023-06-07 Thread David Marchand
On Wed, Jun 7, 2023 at 5:20 PM Akhil Goyal wrote: > > MACsec SC/SA ids are created based on direction of the flow. > Hence, added the missing field for configuration and cleanup > of the SCs and SAs. > > Signed-off-by: Akhil Goyal > --- > devtools/libabigail.abignore | 7 +++ > lib/se

Re: [PATCH v2] net/tap: resolve stringop-overflow with gcc 12 on ppc64le

2023-06-07 Thread Ferruh Yigit
On 5/16/2023 10:55 AM, Ferruh Yigit wrote: > On 5/16/2023 2:28 AM, Stephen Hemminger wrote: >> On Tue, 16 May 2023 00:35:56 +0100 >> Ferruh Yigit wrote: >> >>> Yes only some scripts and possible applications that hotplug tap >>> interface with hardcoded parameters may impacted, don't know how big

Re: [RFC PATCH v2 0/3] improve FEC API usage

2023-06-07 Thread Ferruh Yigit
On 5/12/2023 12:57 PM, Ferruh Yigit wrote: > On 5/8/2023 12:47 PM, Denis Pryazhennikov wrote: >> The documentation for the FEC API is currently incomplete and contains >> inaccuracies in its descriptions of function parameters. >> Specifically, the semantics of the fec_capa parameter in rte_eth_fe

Re: [RFC v3 0/3] add frequency adjustment support for PTP timesync

2023-06-07 Thread Ferruh Yigit
On 6/7/2023 9:19 AM, Su, Simei wrote: > Hi Ferruh, > >> -Original Message- >> From: Ferruh Yigit >> Sent: Saturday, June 3, 2023 3:44 AM >> To: Su, Simei ; tho...@monjalon.net; >> andrew.rybche...@oktetlabs.ru; Rybalchenko, Kirill >> ; Zhang, Qi Z >> Cc: dev@dpdk.org; Wu, Wenjun1 >> Sub

Re: [PATCH v3] app/test-pmd: fix not polling all queues without deferred starting

2023-06-07 Thread Ferruh Yigit
On 5/29/2023 3:26 AM, Jie Hai wrote: > > Each stream has a read-only "disabled" field that control if this > stream should be used to forward. This field depends on states > of Rx/Tx queues, please see > commit 3c4426db54fc ("app/testpmd: do not poll stopped queues"). > > Currently, the testpmd

Re: [PATCH v3] app/test-pmd: fix not polling all queues without deferred starting

2023-06-07 Thread Ferruh Yigit
On 6/7/2023 8:04 AM, Jie Hai wrote: > On 2023/6/6 22:45, Ferruh Yigit wrote: >> On 5/29/2023 3:26 AM, Jie Hai wrote: >> >>> >>> Each stream has a read-only "disabled" field that control if this >>> stream should be used to forward. This field depends on states >>> of Rx/Tx queues, please see >>> co

RE: [EXT] Re: [PATCH v5] app/mldev: add internal function for file read

2023-06-07 Thread Srikanth Yalavarthi
> -Original Message- > From: Stephen Hemminger > Sent: 07 June 2023 22:19 > To: Srikanth Yalavarthi > Cc: Anup Prabhu ; dev@dpdk.org; Shivah Shankar > Shankar Narayan Rao ; Prince Takkar > > Subject: [EXT] Re: [PATCH v5] app/mldev: add internal function for file read > > External Email

[PATCH v6] app/mldev: add internal function for file read

2023-06-07 Thread Srikanth Yalavarthi
Added internal function to read model, input and reference files with required error checks. This change fixes the unchecked return value and improper use of negative value issues reported by coverity scan for file read operations. Coverity issue: 383742, 383743 Fixes: f6661e6d9a3a ("app/mldev: va

Re: [PATCH v5] app/mldev: add internal function for file read

2023-06-07 Thread Stephen Hemminger
On Wed, 7 Jun 2023 09:20:30 -0700 Srikanth Yalavarthi wrote: The normal case leaks the open file descriptor + + file_map = mmap(0, file_stat.st_size, PROT_READ, MAP_PRIVATE, fd, 0); + if (file_map == MAP_FAILED) { + ml_err("Failed to map file: %s\n", file); +

Re: [PATCH v2] eal: choose IOVA mode according to compilation flags

2023-06-07 Thread Thomas Monjalon
06/06/2023 17:23, Bruce Richardson: > On Tue, Jun 06, 2023 at 06:15:11PM +0300, Viacheslav Ovsiienko wrote: > > The DPDK can be compiled to be run in IOVA VA mode with > > 'enable_iova_as_pa=false' meson option. If there is no > > explicit EAL --iova-mode parameter specified in the command > > line

Re: [PATCH 0/3] use C11 memory model GCC builtin atomics

2023-06-07 Thread David Marchand
On Mon, Mar 27, 2023 at 4:30 PM Tyler Retzlaff wrote: > > Replace the use of __sync__and_fetch and __sync_fetch_and_ atomics > with GCC C11 memory model __atomic builtins. > > This series contributes to converging on standard atomics in 23.11 but is > kept separate as there may be sensitivity to c

Re: [PATCH] eal/x86: remove redundant round to improve performance

2023-06-07 Thread David Marchand
On Tue, Apr 4, 2023 at 3:15 PM David Marchand wrote: > On Wed, Mar 29, 2023 at 11:17 AM Leyi Rong wrote: > > > > In rte_memcpy_aligned(), one redundant round is taken in the 64 bytes > > block copy loops if the size is a multiple of 64. So, let the catch-up > > copy the last 64 bytes in this case

Re: [PATCH 0/3] use C11 memory model GCC builtin atomics

2023-06-07 Thread David Marchand
On Fri, Jun 2, 2023 at 6:18 AM Tyler Retzlaff wrote: > > On Wed, May 24, 2023 at 09:05:08AM -0700, Tyler Retzlaff wrote: > > On Wed, May 24, 2023 at 02:51:50PM +0200, David Marchand wrote: > > > On Mon, Mar 27, 2023 at 4:30 PM Tyler Retzlaff > > > wrote: > > > > > > > > Replace the use of __sync_

Re: [PATCH v4 0/4] Support VFIO sparse mmap in PCI bus

2023-06-07 Thread Thomas Monjalon
31/05/2023 07:37, Miao Li: > This series introduces a VFIO standard capability, called sparse > mmap to PCI bus. In linux kernel, it's defined as > VFIO_REGION_INFO_CAP_SPARSE_MMAP. Sparse mmap means instead of > mmap whole BAR region into DPDK process, only mmap part of the > BAR region after gett

RE: [EXT] Re: [PATCH v4] app/mldev: add internal function for file read

2023-06-07 Thread Srikanth Yalavarthi
> -Original Message- > From: Stephen Hemminger > Sent: 07 June 2023 20:32 > To: Srikanth Yalavarthi > Cc: Anup Prabhu ; dev@dpdk.org; Shivah Shankar > Shankar Narayan Rao ; Prince Takkar > > Subject: [EXT] Re: [PATCH v4] app/mldev: add internal function for file read > > External Email

[PATCH v5] app/mldev: add internal function for file read

2023-06-07 Thread Srikanth Yalavarthi
Added internal function to read model, input and reference files with required error checks. This change fixes the unchecked return value and improper use of negative value issues reported by coverity scan for file read operations. Coverity issue: 383742, 383743 Fixes: f6661e6d9a3a ("app/mldev: va

Re: [PATCH v2] net/vmxnet3: fix return code in initializing

2023-06-07 Thread Ferruh Yigit
On 6/6/2023 4:36 PM, Stephen Hemminger wrote: > On Fri, 2 Jun 2023 12:44:38 -0400 > Kaijun Zeng wrote: > >> +PMD_INIT_LOG(ERR, >> +"ERROR: Zero descriptor requirement in >> Rx queue: %d," >> +"bu

Re: [PATCH v5] app/testpmd: expand noisy neighbour forward mode support

2023-06-07 Thread Mike Pattrick
On Tue, Jun 6, 2023 at 6:23 PM Ferruh Yigit wrote: > > On 6/6/2023 10:12 PM, Mike Pattrick wrote: > > Previously the noisy neighbour vnf simulation would only operate in io > > mode, forwarding packets as is. However, this limited the usefulness of > > noisy neighbour simulation. > > > > This feat

[PATCH v2 15/15] net/cnxk: add MACsec stats

2023-06-07 Thread Akhil Goyal
Added support for MACsec SC/flow/session stats. Signed-off-by: Akhil Goyal --- drivers/net/cnxk/cn10k_ethdev_sec.c | 11 +++-- drivers/net/cnxk/cnxk_ethdev_mcs.c | 64 + drivers/net/cnxk/cnxk_ethdev_mcs.h | 9 3 files changed, 81 insertions(+), 3 deletions(-)

[PATCH v2 14/15] net/cnxk: add MACsec session and flow configuration

2023-06-07 Thread Akhil Goyal
Added support for MACsec session/flow create/destroy. Signed-off-by: Akhil Goyal --- drivers/net/cnxk/cn10k_ethdev_sec.c | 11 +- drivers/net/cnxk/cn10k_flow.c | 23 ++- drivers/net/cnxk/cnxk_ethdev.c | 2 + drivers/net/cnxk/cnxk_ethdev.h | 16 ++ drivers/net/cnxk/cnxk_ethde

[PATCH v2 13/15] net/cnxk: create/destroy MACsec SC/SA

2023-06-07 Thread Akhil Goyal
Added support to create/destroy MACsec SA and SC. Signed-off-by: Akhil Goyal --- drivers/net/cnxk/cn10k_ethdev_sec.c | 9 +- drivers/net/cnxk/cnxk_ethdev_mcs.c | 250 drivers/net/cnxk/cnxk_ethdev_mcs.h | 16 ++ 3 files changed, 271 insertions(+), 4 deletions(-)

[PATCH v2 12/15] net/cnxk: add MACsec initialization

2023-06-07 Thread Akhil Goyal
Added initialization routines for MACsec for cn10kb platform. Signed-off-by: Akhil Goyal --- drivers/net/cnxk/cn10k_ethdev_sec.c | 6 ++ drivers/net/cnxk/cnxk_ethdev.c | 13 +++ drivers/net/cnxk/cnxk_ethdev.h | 14 +++ drivers/net/cnxk/cnxk_ethdev_mcs.c | 151 +

[PATCH v2 11/15] common/cnxk: derive hash key for MACsec

2023-06-07 Thread Akhil Goyal
MACsec hardware configuration need hash key to be generated from the cipher key of AES-GCM-128/256. Added an ROC API to derive the hash key and extend the case for AES-256 as well. Signed-off-by: Akhil Goyal --- drivers/common/cnxk/roc_aes.c | 86 ++--- drivers/comm

[PATCH v2 10/15] common/cnxk: add MACsec FIPS mbox

2023-06-07 Thread Akhil Goyal
Added MACsec FIPS configuration mbox Signed-off-by: Ankur Dwivedi Signed-off-by: Vamsi Attunuru Signed-off-by: Akhil Goyal --- drivers/common/cnxk/roc_mbox.h | 74 ++ drivers/common/cnxk/roc_mcs.h | 69 +++ 2 files changed, 143 inser

[PATCH v2 09/15] common/cnxk: add MACsec control port configuration

2023-06-07 Thread Akhil Goyal
Added ROC APIs to configure MACsec control port. Signed-off-by: Ankur Dwivedi Signed-off-by: Vamsi Attunuru Signed-off-by: Akhil Goyal --- drivers/common/cnxk/roc_mbox.h | 72 drivers/common/cnxk/roc_mcs.c | 117 drivers/common/cnxk/roc

[PATCH v2 08/15] common/cnxk: add MACsec port configuration

2023-06-07 Thread Akhil Goyal
Added ROC APIs for MACsec port configurations Signed-off-by: Ankur Dwivedi Signed-off-by: Vamsi Attunuru Signed-off-by: Akhil Goyal --- drivers/common/cnxk/roc_mbox.h | 40 drivers/common/cnxk/roc_mcs.c | 346 drivers/common/cnxk/roc_mcs.h | 48

[PATCH v2 07/15] common/cnxk: add MACsec interrupt APIs

2023-06-07 Thread Akhil Goyal
Added ROC APIs to support various MACsec interrupts. Signed-off-by: Ankur Dwivedi Signed-off-by: Vamsi Attunuru Signed-off-by: Akhil Goyal --- drivers/common/cnxk/roc_dev.c | 86 + drivers/common/cnxk/roc_mbox.h | 37 +++- drivers/common/cnxk/roc_mcs.c | 117

[PATCH v2 06/15] common/cnxk: add MACsec stats

2023-06-07 Thread Akhil Goyal
Added ROC APIs for MACsec stats for SC/SECY/FLOW/PORT Signed-off-by: Ankur Dwivedi Signed-off-by: Vamsi Attunuru Signed-off-by: Akhil Goyal --- drivers/common/cnxk/meson.build | 1 + drivers/common/cnxk/roc_mbox.h | 93 ++ drivers/common/cnxk/roc_mcs.h | 85 +

[PATCH v2 05/15] common/cnxk: add MACsec PN and LMAC mode configuration

2023-06-07 Thread Akhil Goyal
Added ROC APIs for setting packet number and LMAC related configurations. Signed-off-by: Ankur Dwivedi Signed-off-by: Vamsi Attunuru Signed-off-by: Akhil Goyal --- drivers/common/cnxk/roc_mbox.h| 56 + drivers/common/cnxk/roc_mcs.c | 71 +

[PATCH v2 04/15] common/cnxk: add MACsec secy and flow configuration

2023-06-07 Thread Akhil Goyal
Added ROC APIs to configure MACsec secy policy and flow entries. Signed-off-by: Ankur Dwivedi Signed-off-by: Vamsi Attunuru Signed-off-by: Akhil Goyal --- drivers/common/cnxk/roc_mbox.h| 38 + drivers/common/cnxk/roc_mcs.h | 37 + drivers/common/cnxk/roc_mcs_s

[PATCH v2 03/15] common/cnxk: add MACsec SC configuration APIs

2023-06-07 Thread Akhil Goyal
Added ROC APIs to configure MACsec secure channel(SC) and its mapping with SAs for both Rx and Tx. Signed-off-by: Ankur Dwivedi Signed-off-by: Vamsi Attunuru Signed-off-by: Akhil Goyal --- drivers/common/cnxk/roc_mbox.h| 37 ++ drivers/common/cnxk/roc_mcs.h | 41 ++ d

[PATCH v2 02/15] common/cnxk: add MACsec SA configuration

2023-06-07 Thread Akhil Goyal
Added ROC APIs to allocate/free MACsec resources and APIs to write SA policy. Signed-off-by: Ankur Dwivedi Signed-off-by: Vamsi Attunuru Signed-off-by: Akhil Goyal --- drivers/common/cnxk/meson.build | 1 + drivers/common/cnxk/roc_mbox.h| 12 ++ drivers/common/cnxk/roc_mcs.h

[PATCH v2 01/15] common/cnxk: add ROC MACsec initialization

2023-06-07 Thread Akhil Goyal
Added ROC init and fini APIs for supporting MACsec. Signed-off-by: Ankur Dwivedi Signed-off-by: Vamsi Attunuru Signed-off-by: Akhil Goyal --- drivers/common/cnxk/meson.build | 1 + drivers/common/cnxk/roc_api.h | 3 + drivers/common/cnxk/roc_features.h | 12 ++ drivers/common/c

[PATCH v2 00/15] net/cnxk: add MACsec support

2023-06-07 Thread Akhil Goyal
Added MACsec support in Marvell cnxk PMD. The patchset is pending from last release [1] Sending as a new series as the functionality is now complete and tested on hardware. Depends-on: http://patches.dpdk.org/project/dpdk/list/?series=28391 [1] https://patches.dpdk.org/project/dpdk/cover/2022092

RE: [PATCH v2 01/13] security: add direction in SA/SC configuration

2023-06-07 Thread Akhil Goyal
> Subject: [PATCH v2 01/13] security: add direction in SA/SC configuration > > MACsec SC/SA ids are created based on direction of the flow. > Hence, added the missing field for configuration and cleanup > of the SCs and SAs. > > Signed-off-by: Akhil Goyal > --- > devtools/libabigail.abignore

[PATCH v2 13/13] test/security: remove no MACsec support case

2023-06-07 Thread Akhil Goyal
Removed the test_capability_get_no_support_for_macsec case as MACsec is now supported and capability can have valid MACsec support. Signed-off-by: Akhil Goyal --- app/test/test_security.c | 37 - 1 file changed, 37 deletions(-) diff --git a/app/test/test_secu

[PATCH v2 12/13] test/security: verify MACsec anti replay

2023-06-07 Thread Akhil Goyal
From: Ankur Dwivedi This patch enables anti replay test case for MACsec. Signed-off-by: Ankur Dwivedi Signed-off-by: Akhil Goyal --- app/test/test_security_inline_macsec.c| 82 +++ .../test_security_inline_macsec_vectors.h | 467 ++ 2 files changed, 549 insertions

[PATCH v2 11/13] test/security: verify MACsec Rx rekey

2023-06-07 Thread Akhil Goyal
From: Ankur Dwivedi This patch enables the Rx rekey test case for MACSEC. Signed-off-by: Ankur Dwivedi --- app/test/test_security_inline_macsec.c | 50 +- 1 file changed, 49 insertions(+), 1 deletion(-) diff --git a/app/test/test_security_inline_macsec.c b/app/test/te

[PATCH v2 10/13] test/security: verify MACsec Tx HW rekey

2023-06-07 Thread Akhil Goyal
This patch enables the Tx HW rekey test case for MACSEC. Signed-off-by: Ankur Dwivedi Signed-off-by: Akhil Goyal --- app/test/test_security_inline_macsec.c| 137 +- .../test_security_inline_macsec_vectors.h | 243 ++ 2 files changed, 378 insertions(+), 2 dele

[PATCH v2 09/13] test/security: verify MACsec interrupts

2023-06-07 Thread Akhil Goyal
From: Ankur Dwivedi This patch enables the test_inline_macsec_interrupts_all test case for MACSEC. Signed-off-by: Ankur Dwivedi Signed-off-by: Akhil Goyal --- app/test/test_security_inline_macsec.c| 124 +++ .../test_security_inline_macsec_vectors.h | 306 +- 2

[PATCH v2 08/13] test/security: verify MACsec stats

2023-06-07 Thread Akhil Goyal
Added cases to verify various stats of MACsec. Signed-off-by: Akhil Goyal --- app/test/test_security_inline_macsec.c | 222 + 1 file changed, 222 insertions(+) diff --git a/app/test/test_security_inline_macsec.c b/app/test/test_security_inline_macsec.c index 2a06f31f37.

[PATCH v2 07/13] test/security: add MACsec negative cases

2023-06-07 Thread Akhil Goyal
Added MACsec negative test cases to verify pkt drop, untagged rx, bad tag rx, sa not in use, out packets untagged, pkts too long. Signed-off-by: Akhil Goyal --- app/test/test_security_inline_macsec.c| 346 + .../test_security_inline_macsec_vectors.h | 475

[PATCH v2 06/13] test/security: add MACsec VLAN cases

2023-06-07 Thread Akhil Goyal
Added cases to verify MACsec processing with VLAN tags inserted. Vectors are added to verify 1/2/3 VLAN tags in clear or encrypted data. Signed-off-by: Akhil Goyal --- app/test/test_security_inline_macsec.c| 67 ++ .../test_security_inline_macsec_vectors.h | 217

[PATCH v2 04/13] test/security: add MACsec integrity cases

2023-06-07 Thread Akhil Goyal
Added test vectors and test cases to verify auth_only/verify_only and encap-decap/auth-verify to verify the complete TX-RX path using the loopback mode of ethdev. Signed-off-by: Akhil Goyal --- app/test/test_security_inline_macsec.c| 153 +++ .../test_security_inline_macsec_vectors.h

[PATCH v2 05/13] test/security: verify multi flow MACsec

2023-06-07 Thread Akhil Goyal
Added test case and test vectors to verify multiple flows of MACsec. Signed-off-by: Akhil Goyal --- app/test/test_security_inline_macsec.c| 49 .../test_security_inline_macsec_vectors.h | 110 +- 2 files changed, 158 insertions(+), 1 deletion(-) diff --git

  1   2   3   >