RE: [PATCH V3] lib: set/get max memzone segments

2023-05-24 Thread Ophir Munk
Hi Morten, > > I retracted my objection to the RFC, but should also have added: > > Acked-by: Morten Brørup Ack.

RE: [PATCH V3] lib: set/get max memzone segments

2023-05-24 Thread Ophir Munk
Hi Anatoly, Thank you for your review. I noticed a review by David Marchand that addresses similar points to yours. In V4 I supply a reply to you both. > > Commit message could use a little rewording and shortening. Suggested: > > --- > > Currently, RTE_MAX_MEMZONE constant is used to decide h

RE: [PATCH V3] lib: set/get max memzone segments

2023-05-24 Thread Ophir Munk
Hello David, Thank you for your review. I noticed a review by Anatoly Burakov that addresses similar points to yours. In V4 I supply a reply to you both. > -Original Message- > From: David Marchand > Sent: Thursday, 4 May 2023 10:27 > To: Ophir Munk > Cc: dev@dpdk.org; Bruce Richardson

[PATCH v15] app/procinfo: display eventdev xstats

2023-05-24 Thread Abdullah Sevincer
This commit extends proc-info application to display xstats for the eventdev devices. New command line arguments are introduced to display xstats for eventdev devices. The command example is like: For displaying a specific port stats (e.g. port 1): ./dpdk-proc-info -- --show-edev-port-xstats=1:0

[PATCH] net/qede: fix RSS indirection table initialization

2023-05-24 Thread Devendra Singh Rawat
RSS indirection table was not updated for VF ports during RSS hash update, this resulted in device start failure. This fix updates RSS indirection table during RSS hash update. Fixes: 7ab35bf6b97b (net/qede: fix RSS) Cc: sta...@dpdk.org Signed-off-by: Devendra Singh Rawat Signed-off-by: Alok Pra

RE: [PATCH v3 09/10] net/cpfl: support peer ports get

2023-05-24 Thread Wu, Jingjing
> -Original Message- > From: Xing, Beilei > Sent: Friday, May 19, 2023 3:31 PM > To: Wu, Jingjing > Cc: dev@dpdk.org; Liu, Mingxia ; Xing, Beilei > ; Wang, Xiao W > Subject: [PATCH v3 09/10] net/cpfl: support peer ports get > > From: Beilei Xing > > This patch supports get hairpin

RE: [PATCH v3 08/10] net/cpfl: enable write back based on ITR expire

2023-05-24 Thread Wu, Jingjing
> idpf_vport_irq_unmap_config(struct idpf_vport *vport, uint16_t nb_rx_queues) > { > diff --git a/drivers/common/idpf/idpf_common_device.h > b/drivers/common/idpf/idpf_common_device.h > index 112367dae8..f767ea7cec 100644 > --- a/drivers/common/idpf/idpf_common_device.h > +++ b/drivers/common/idp

RE: [PATCH v3 07/10] net/cpfl: support hairpin queue start/stop

2023-05-24 Thread Wu, Jingjing
> -Original Message- > From: Xing, Beilei > Sent: Friday, May 19, 2023 3:31 PM > To: Wu, Jingjing > Cc: dev@dpdk.org; Liu, Mingxia ; Xing, Beilei > ; Wang, Xiao W > Subject: [PATCH v3 07/10] net/cpfl: support hairpin queue start/stop > > From: Beilei Xing > > This patch supports Rx

RE: [PATCH v3 05/10] net/cpfl: support hairpin queue setup and release

2023-05-24 Thread Wu, Jingjing
> > +static int > +cpfl_rx_hairpin_bufq_setup(struct rte_eth_dev *dev, struct idpf_rx_queue > *bufq, > +uint16_t logic_qid, uint16_t nb_desc) > +{ > + struct cpfl_vport *cpfl_vport = > + (struct cpfl_vport *)dev->data->dev_private; > + struct idpf_vport *vp

[PATCH] pci: add O_CLOEXEC when open uio device

2023-05-24 Thread Weifeng Su
In this scenario, the DPDK process invokes a script which inherits an open file descriptor (FD) for a UIO device. After the script execution is complete, the UIO device's close operation is called. However, in a new kernel version (865a11f987ab5f03:uio/uio_pci_generic: Disable bus-mastering on rele

[PATCH] net/iavf: add VF reset check

2023-05-24 Thread Zhichao Zeng
This commit adds a VF reset check before the dev_reset, so that the application can check if the iavf device comes out of reset when calling the rte_eth_dev_reset. Signed-off-by: Zhichao Zeng --- drivers/net/iavf/iavf_ethdev.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/

Re: [PATCH v3 0/7] replace rte atomics with GCC builtin atomics

2023-05-24 Thread Tyler Retzlaff
Morten, David and Honnappa are discussing the /* NOTE: */ comments that were added. If the three of you could come to conclusion about keeping or removing them it would be appreciated. Thanks! On Wed, May 24, 2023 at 10:56:01PM +, Honnappa Nagarahalli wrote: > > > > -Original Message--

RE: [PATCH v3 0/7] replace rte atomics with GCC builtin atomics

2023-05-24 Thread Honnappa Nagarahalli
> -Original Message- > From: Tyler Retzlaff > Sent: Wednesday, May 24, 2023 5:51 PM > To: David Marchand > Cc: dev@dpdk.org; Honnappa Nagarahalli ; > Ruifeng Wang ; tho...@monjalon.net; > step...@networkplumber.org; m...@smartsharesystems.com; Ferruh Yigit > > Subject: Re: [PATCH v3 0/

Re: [PATCH v3 0/7] replace rte atomics with GCC builtin atomics

2023-05-24 Thread Tyler Retzlaff
On Wed, May 24, 2023 at 10:06:24PM +0200, David Marchand wrote: > On Wed, May 24, 2023 at 5:47 PM Tyler Retzlaff > wrote: > > On Wed, May 24, 2023 at 02:40:43PM +0200, David Marchand wrote: > > > Hello Tyler, > > > > > > On Thu, Mar 23, 2023 at 11:54 PM Tyler Retzlaff > > > wrote: > > > > > > > >

[PATCH v4] lib: set/get max memzone segments

2023-05-24 Thread Ophir Munk
Currently, the max memzones count constat (RTE_MAX_MEMZONE) is used to decide how many memzones a DPDK application can have. This value could technically be changed by manually editing `rte_config.h` before compilation, but if DPDK is already compiled, that option is not useful. There are certain u

RE: [PATCH v2] test/crypto: fix IPsec AES CCM test vector

2023-05-24 Thread Akhil Goyal
> Subject: [PATCH v2] test/crypto: fix IPsec AES CCM test vector > > Set IPsec AES-CCM test vector IV length to 11 > instead of 12 as it includes only 3B salt and > 8B per packet IV. > > Fixes: d314299950de ("test/crypto: add AES-CCM vectors") > Cc: sta...@dpdk.org > > Signed-off-by: Tejasree Ko

Re: [PATCH v3] pipeline: fix double free error for table stats

2023-05-24 Thread Thomas Monjalon
17/04/2023 13:22, Kamalakannan R: > The pointer to the table statistics data structure needs to be set > to NULL after free inside the table_build_free(), as this function is > called from multiple places, leading to double memory free error. > > Similar fix for the learner_build_free() function.

RE: [PATCH 1/2] crypto/cnxk: add AES CCM support

2023-05-24 Thread Akhil Goyal
> Subject: [PATCH 1/2] crypto/cnxk: add AES CCM support > > Adding AES CCM support to lookaside crypto PMD. > > Signed-off-by: Tejasree Kondoj Applied to dpdk-next-crypto Updated release notes.

Re: [PATCH v3] dmadev: add tracepoints

2023-05-24 Thread Thomas Monjalon
15/04/2023 02:33, Chengwen Feng: > Add tracepoints at important APIs for tracing support. > > Signed-off-by: Chengwen Feng > Acked-by: Morten Brørup This patch triggers a failure in Intel CI: asan_smoke | test_rxtx_with_ASan_enable| FAILED If you think it is a false positive, please could you

Re: [PATCH] ring: fix the variable name error

2023-05-24 Thread Thomas Monjalon
07/04/2023 12:32, Morten Brørup: > > From: Feifei Wang [mailto:feifei.wa...@arm.com] > > Sent: Friday, 7 April 2023 10.48 > > > > Ring dequeue operation's parameters name should be 'cons_xx', > > rather than 'prod_xxx'. > > > > Fixes: 1fc73390bcf5 ("ring: refactor exported headers") > > Cc: sta..

RE: [PATCH 0/7] fixes and improvements to CNXK crypto PMD

2023-05-24 Thread Akhil Goyal
> Subject: [PATCH 0/7] fixes and improvements to CNXK crypto PMD > > This series adds SM3, CN10K PDCP CHAIN support and > improvements to CNXK crypto PMD. > > Aakash Sasidharan (1): > crypto/cnxk: add cryptodev reconfiguration support > > Anoob Joseph (2): > crypto/cnxk: increase max segment

Re: [PATCH v5] telemetry: remove non-portable array initialization syntax

2023-05-24 Thread Thomas Monjalon
05/04/2023 20:52, Tyler Retzlaff: > Use of ranges in designated initialization are a non-standard gcc > extension. > > Only initialize '_' and '/' elements of the array and filter tests > of characters through name with standard C isalnum before checking > the array. > > Suggested-by: Konstantin

Re: [PATCH v3 0/5] telemetry: remove variable length arrays

2023-05-24 Thread Thomas Monjalon
05/04/2023 18:03, Bruce Richardson: > This patchset introduces a series of changes to remove variable-length > arrays from the telemetry code. The first patch replaces a VLA with > malloc memory for the serialization of the json objects contained within > the main response object, which fixes a cra

Re: [RFC v2 1/2] dts: add smoke tests

2023-05-24 Thread Jeremy Spewock
On Tue, May 23, 2023 at 4:05 AM Juraj Linkeš wrote: > Hi Jeremy, first, a few general points: > > 1. Send patches to maintainers (Thomas, me, Honnappa, Lijuan and > anyone else involved with DTS or who might be interested) and add the > devlist to cc. > Thank you for the tip! I'm still new to se

Re: [PATCH 23.07 0/2] Minor meson build improvements

2023-05-24 Thread Thomas Monjalon
10/03/2023 12:11, Bruce Richardson: > While experimenting with "muon" [1] as a replacement for meson, the > muon tool flagged a few issues that could do with being cleaned up > in our meson.build files. While currently muon is not in a position > to configure a DPDK build, it's not that far away fr

Re: [PATCH v3 6/7] net/null: replace rte atomics with GCC builtin atomics

2023-05-24 Thread David Marchand
Hello Tetsuya, Review please. On Thu, Mar 23, 2023 at 11:54 PM Tyler Retzlaff wrote: > > Replace the use of rte_atomic.h types and functions, instead use GCC > supplied C++11 memory model builtins. > > Signed-off-by: Tyler Retzlaff > --- > drivers/net/null/rte_eth_null.c | 28

Re: [PATCH v3 7/7] net/ring: replace rte atomics with GCC builtin atomics

2023-05-24 Thread David Marchand
Hello Bruce, For you again, review please. On Thu, Mar 23, 2023 at 11:54 PM Tyler Retzlaff wrote: > > Replace the use of rte_atomic.h types and functions, instead use GCC > supplied C++11 memory model builtins. > > Signed-off-by: Tyler Retzlaff > --- > drivers/net/ring/rte_eth_ring.c | 26 +++

Re: [PATCH v3 5/7] net/ixgbe: replace rte atomics with GCC builtin atomics

2023-05-24 Thread David Marchand
Hello Qiming, Wenjun, Review please. On Thu, Mar 23, 2023 at 11:54 PM Tyler Retzlaff wrote: > > Replace the use of rte_atomic.h types and functions, instead use GCC > supplied C++11 memory model builtins. > > Signed-off-by: Tyler Retzlaff > --- > drivers/net/ixgbe/ixgbe_bypass.c | 1 - > driv

Re: [PATCH v3 4/7] net/ice: replace rte atomics with GCC builtin atomics

2023-05-24 Thread David Marchand
Hello Qiming, Qi, Review please. On Thu, Mar 23, 2023 at 11:54 PM Tyler Retzlaff wrote: > > Replace the use of rte_atomic.h types and functions, instead use GCC > supplied C++11 memory model builtins. > > Signed-off-by: Tyler Retzlaff > --- > drivers/net/ice/ice_dcf.c| 1 - > drivers/

Re: [PATCH v3 3/7] dma/idxd: replace rte atomics with GCC builtin atomics

2023-05-24 Thread David Marchand
Hello Bruce, Kevin, Review please. On Thu, Mar 23, 2023 at 11:54 PM Tyler Retzlaff wrote: > > Replace the use of rte_atomic.h types and functions, instead use GCC > supplied C++11 memory model builtins. > > Signed-off-by: Tyler Retzlaff > --- > drivers/dma/idxd/idxd_internal.h | 3 +-- > driv

Re: [PATCH v3 2/7] stack: replace rte atomics with GCC builtin atomics

2023-05-24 Thread David Marchand
Hello Olivier, Review please. On Thu, Mar 23, 2023 at 11:54 PM Tyler Retzlaff wrote: > > Replace the use of rte_atomic.h types and functions, instead use GCC > supplied C++11 memory model builtins. > > Signed-off-by: Tyler Retzlaff > --- > lib/stack/rte_stack_lf_generic.h | 16 +---

Re: [PATCH v3 0/7] replace rte atomics with GCC builtin atomics

2023-05-24 Thread David Marchand
On Wed, May 24, 2023 at 5:47 PM Tyler Retzlaff wrote: > On Wed, May 24, 2023 at 02:40:43PM +0200, David Marchand wrote: > > Hello Tyler, > > > > On Thu, Mar 23, 2023 at 11:54 PM Tyler Retzlaff > > wrote: > > > > > > Replace the use of rte_atomic.h types and functions, instead use GCC > > > suppli

Re: [PATCH] dma/idxd: add support for multi-process when using VFIO

2023-05-24 Thread Thomas Monjalon
17/05/2023 12:17, Burakov, Anatoly: > On 5/15/2023 5:29 PM, Bruce Richardson wrote: > > When using vfio-pci/uio for hardware access, we need to avoid > > reinitializing the hardware when mapping from a secondary process. > > Instead, just configure the function pointers and reuse the data > > mappi

Re: [PATCH v1] power: support amd-pstate cpufreq driver

2023-05-24 Thread Thomas Monjalon
12/04/2023 11:52, Sivaprasad Tummala: > amd-pstate introduces a new CPU frequency control mechanism for AMD > processors using the ACPI Collaborative Performance Power Control > feature for a finer grained frequency management. > > Patch to add support for amd-pstate driver. > > Signed-off-by: Si

Re: [RFC PATCH] ethdev: advertise flow restore in mbuf

2023-05-24 Thread David Marchand
Hello Ori, On Wed, May 24, 2023 at 6:00 PM Ori Kam wrote: > > As reported by Ilya [1], unconditionally calling > > rte_flow_get_restore_info() impacts an application performance for drivers > > that do not provide this ops. > > It could also impact processing of packets that require no call to >

Re: [PATCH v3 21/22] pdcp: add thread safe processing

2023-05-24 Thread Stephen Hemminger
On Wed, 24 May 2023 21:31:15 +0530 Anoob Joseph wrote: > From: Volodymyr Fialko > > PDCP state has to be guarded for: > > - Uplink pre_process: > - tx_next atomic increment > > - Downlink pre_process: > - rx_deliv - read > > - Downlink post_process: > - rx_deliv, rx_reorder, rx_n

Re: AF_XDP performance

2023-05-24 Thread Stephen Hemminger
On Wed, 24 May 2023 17:36:32 +0100 Bruce Richardson wrote: > On Wed, May 24, 2023 at 01:32:17PM +0100, Alireza Sanaee wrote: > > Hi everyone, > > > > I was looking at this deck of slides > > https://www.dpdk.org/wp-content/uploads/sites/35/2020/11/XDP_ZC_PMD-1.pdf > > > > I tried to reproduce t

RE: [PATCH v4] ethdev: add indirect list flow action

2023-05-24 Thread Ori Kam
Hi Gregory > -Original Message- > From: Gregory Etelson > Sent: Friday, May 19, 2023 3:00 PM > > Indirect API creates a shared flow action with unique action handle. > Flow rules can access the shared flow action and resources related to > that action through the indirect action handle.

Re: [v4] net/gve: check driver compatibility

2023-05-24 Thread Rushil Gupta
As noted from spec: "Some commands require an additional dma memory region to be passed to the device" We are passing virtual addresses to devices (please look at link-speed and describe-device adminq commands): describe device: https://github.com/DPDK/dpdk/blob/main/drivers/net/gve/base/gve_adminq

[v5] net/gve: check driver compatibility

2023-05-24 Thread Rushil Gupta
Change gve_driver_info fields to report DPDK as OS type and DPDK RTE version as OS version, reserving driver_version fields for GVE driver version based on features. Signed-off-by: Rushil Gupta Signed-off-by: Joshua Washington Signed-off-by: Junfeng Guo Signed-off-by: Jeroen de Borst --- driv

RE: [PATCH v4 3/4] bus/cdx: add support for MSI

2023-05-24 Thread Gupta, Nipun
[AMD Official Use Only - General] > -Original Message- > From: Thomas Monjalon > Sent: Wednesday, May 24, 2023 4:37 PM > To: Gupta, Nipun > Cc: dev@dpdk.org; david.march...@redhat.com; Yigit, Ferruh > ; Anand, Harpreet ; > Agarwal, Nikhil > Subject: Re: [PATCH v4 3/4] bus/cdx: add suppo

RE: [PATCH v4 1/4] bus/cdx: introduce cdx bus

2023-05-24 Thread Gupta, Nipun
[AMD Official Use Only - General] > -Original Message- > From: Thomas Monjalon > Sent: Wednesday, May 24, 2023 4:45 PM > To: Gupta, Nipun > Cc: dev@dpdk.org; david.march...@redhat.com; Yigit, Ferruh > ; Anand, Harpreet ; > Agarwal, Nikhil > Subject: Re: [PATCH v4 1/4] bus/cdx: introduce

Re: AF_XDP performance

2023-05-24 Thread Bruce Richardson
On Wed, May 24, 2023 at 01:32:17PM +0100, Alireza Sanaee wrote: > Hi everyone, > > I was looking at this deck of slides > https://www.dpdk.org/wp-content/uploads/sites/35/2020/11/XDP_ZC_PMD-1.pdf > > I tried to reproduce the results with the testpmd application. I am > working with BlueField 2 NI

Re: [PATCH] net/mlx5: enhance error log for tunnel offloading

2023-05-24 Thread Thomas Monjalon
27/04/2023 14:23, David Marchand: > Hello guys, > > On Thu, Apr 27, 2023 at 1:56 PM David Marchand > wrote: > > > > Tunnel offloading is linked to running a port with the non-obvious > > dv_xmeta_en=3 devargs. Hint at it for "normal" users. > > > > Fixes: 4ec6360de37d ("net/mlx5: implement tunnel

RE: [PATCH] common/mlx5: adjust fork call with the new kernel API

2023-05-24 Thread Slava Ovsiienko
> -Original Message- > From: Erez Ferber > Sent: Wednesday, May 24, 2023 3:02 PM > To: dev@dpdk.org > Cc: Slava Ovsiienko ; Matan Azrad > ; Raslan Darawsheh ; Erez Ferber > ; sta...@dpdk.org > Subject: [PATCH] common/mlx5: adjust fork call with the new kernel API > > From: Erez Ferber >

Re: [PATCH 0/3] use C11 memory model GCC builtin atomics

2023-05-24 Thread Tyler Retzlaff
On Wed, May 24, 2023 at 02:51:50PM +0200, David Marchand wrote: > On Mon, Mar 27, 2023 at 4:30 PM Tyler Retzlaff > wrote: > > > > Replace the use of __sync__and_fetch and __sync_fetch_and_ atomics > > with GCC C11 memory model __atomic builtins. > > > > This series contributes to converging on sta

Re: [PATCH] freebsd/contigmem: fix function parameter list

2023-05-24 Thread Thomas Monjalon
22/05/2023 18:02, Tyler Retzlaff: > On Mon, May 22, 2023 at 10:22:41AM +0100, Bruce Richardson wrote: > > Functions which take no parameters should explicitly have "(void)" as > > the parameter list, rather than "()". > > > > Reported upstream on FreeBSD ports collection [1]. > > > > [1] https://

[PATCH v3 22/22] test/pdcp: add PDCP status report cases

2023-05-24 Thread Anoob Joseph
From: Volodymyr Fialko Test PDCP status report generation. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- app/test/test_pdcp.c | 312 +++ 1 file changed, 312 insertions(+) diff --git a/app/test/test_pdcp.c b/app/test/test_pdcp.c index

[PATCH v3 21/22] pdcp: add thread safe processing

2023-05-24 Thread Anoob Joseph
From: Volodymyr Fialko PDCP state has to be guarded for: - Uplink pre_process: - tx_next atomic increment - Downlink pre_process: - rx_deliv - read - Downlink post_process: - rx_deliv, rx_reorder, rx_next - read/write - bitmask/reorder buffer - read/write When application requ

[PATCH v3 20/22] pdcp: allocate reorder buffer alongside with entity

2023-05-24 Thread Anoob Joseph
From: Volodymyr Fialko Instead of allocating reorder buffer separately on heap, allocate memory for it together with rest of entity, and then only initialize buffer via `rte_reorder_init()`. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- lib/pdcp/pdcp_cnt.c | 9 +++

[PATCH v3 19/22] pdcp: add support for status report

2023-05-24 Thread Anoob Joseph
From: Volodymyr Fialko Implement status report generation for PDCP entity. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- lib/pdcp/pdcp_cnt.c | 158 --- lib/pdcp/pdcp_cnt.h | 11 ++- lib/pdcp/pdcp_ctrl_pdu.c | 34 - lib/

[PATCH v3 18/22] test/pdcp: add timer restart case

2023-05-24 Thread Anoob Joseph
From: Volodymyr Fialko Add test to cover the case when t-reordering timer should be restarted on the same packet. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- app/test/test_pdcp.c | 68 1 file changed, 68 insertions(+) diff --gi

[PATCH v3 17/22] test/pdcp: add timer expiry cases

2023-05-24 Thread Anoob Joseph
From: Volodymyr Fialko Add test cases for handling the expiry with rte_timer and rte_event_timer. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- app/test/test_pdcp.c | 350 +++ 1 file changed, 350 insertions(+) diff --git a/app/test/te

[PATCH v3 16/22] pdcp: add timer expiry handle

2023-05-24 Thread Anoob Joseph
From: Volodymyr Fialko The PDCP protocol requires usage of timers to keep track of how long an out-of-order packet should be buffered while waiting for missing packets. Applications can register a desired timer implementation with the PDCP library. Once the timer expires, the application will be

[PATCH v3 15/22] pdcp: add timer callback handlers

2023-05-24 Thread Anoob Joseph
From: Volodymyr Fialko PDCP has a windowing mechanism which allows only packets that fall in a reception window. The pivot point for this window is RX_REORD which happens to be the first missing or next expected packet. If the missing packet is not received after a specified time, then the RX_REO

[PATCH v3 14/22] test/pdcp: add in-order delivery cases

2023-05-24 Thread Anoob Joseph
From: Volodymyr Fialko Add test cases to verify behaviour when in-order delivery is enabled and packets arrive in out-of-order. PDCP library is expected to buffer the packets and return packets in-order when the missing packet arrives. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko

[PATCH v3 13/22] pdcp: implement t-Reordering and packet buffering

2023-05-24 Thread Anoob Joseph
From: Volodymyr Fialko Add in-order delivery of packets in PDCP. Delivery of packets in-order relies on t-Reordering timer. When 'out-of-order delivery' is disabled, PDCP will buffer all received packets that are out of order. The t-Reordering timer determines the time period these packets would

[PATCH v3 12/22] pdcp: add control PDU handling for status report

2023-05-24 Thread Anoob Joseph
Add control PDU handling and implement status report generation. Status report generation works only when RX_DELIV = RX_NEXT. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- doc/guides/prog_guide/pdcp_lib.rst | 9 ++ lib/pdcp/meson.build | 2 ++ lib/pdcp/pdcp

[PATCH v3 11/22] doc: add PDCP library guide

2023-05-24 Thread Anoob Joseph
Add guide for PDCP library. Signed-off-by: Anoob Joseph Signed-off-by: Kiran Kumar K Signed-off-by: Volodymyr Fialko --- .../img/pdcp_functional_overview.svg | 1 + doc/guides/prog_guide/index.rst | 1 + doc/guides/prog_guide/pdcp_lib.rst| 254 +++

[PATCH v3 10/22] test/pdcp: pdcp HFN tests in combined mode

2023-05-24 Thread Anoob Joseph
From: Volodymyr Fialko Add tests to verify HFN/SN behaviour. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- app/test/test_pdcp.c | 302 ++- 1 file changed, 299 insertions(+), 3 deletions(-) diff --git a/app/test/test_pdcp.c b/app/test/

[PATCH v3 09/22] app/test: add lib pdcp tests

2023-05-24 Thread Anoob Joseph
Add tests to verify lib PDCP operations. Tests leverage existing PDCP test vectors. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- app/test/meson.build | 1 + app/test/test_cryptodev.h | 3 + app/test/test_pdcp.c | 730 ++ 3 fil

[PATCH v3 08/22] pdcp: add IV generation routines

2023-05-24 Thread Anoob Joseph
For PDCP, IV generated has varying formats depending on the ciphering and authentication algorithm used. Add routines to populate IV accordingly. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- lib/pdcp/pdcp_entity.h | 87 lib/pdcp/pdcp_process.c | 284 +++

[PATCH v3 07/22] pdcp: add pre and post process for DL

2023-05-24 Thread Anoob Joseph
Add routines to perform pre & post processing for down link entities. Signed-off-by: Anoob Joseph Signed-off-by: Kiran Kumar K Signed-off-by: Volodymyr Fialko --- lib/pdcp/pdcp_entity.h | 2 + lib/pdcp/pdcp_process.c | 454 2 files changed, 456 inser

[PATCH v3 06/22] pdcp: add pre and post process for UL

2023-05-24 Thread Anoob Joseph
Add routines to perform pre & post processing based on the type of entity. To avoid checks in datapath, there are different function pointers registered based on the following, 1. Control plane v/s user plane 2. 12 bit v/s 18 bit SN For control plane only 12 bit SN need to be supported (as per PDC

[PATCH v3 05/22] pdcp: add crypto session create and destroy

2023-05-24 Thread Anoob Joseph
Add routines to create & destroy sessions. PDCP lib would take crypto transforms as input and creates the session on the corresponding device after verifying capabilities. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko Acked-by: Akhil Goyal --- lib/pdcp/pdcp_crypto.c | 223 +++

[PATCH v3 04/22] pdcp: add packet group

2023-05-24 Thread Anoob Joseph
Crypto processing in PDCP is performed asynchronously by rte_cryptodev_enqueue_burst() and rte_cryptodev_dequeue_burst(). Since cryptodev dequeue can return crypto operations belonging to multiple entities, rte_pdcp_pkt_crypto_group() is added to help grouping crypto operations belonging to same en

[PATCH v3 03/22] pdcp: add pre and post-process

2023-05-24 Thread Anoob Joseph
PDCP process is split into 2 parts. One before crypto processing (rte_pdcp_pkt_pre_process()) and one after crypto processing (rte_pdcp_pkt_post_process()). Functionality of pre-process & post-process varies based on the type of entity. Registration of entity specific function pointer allows skippi

[PATCH v3 02/22] lib: add pdcp protocol

2023-05-24 Thread Anoob Joseph
Add Packet Data Convergence Protocol (PDCP) processing library. The library is similar to lib_ipsec which provides IPsec processing capabilities in DPDK. PDCP would involve roughly the following options, 1. Transfer of user plane data 2. Transfer of control plane data 3. Header compression 4. Upl

[PATCH v3 01/22] net: add PDCP header

2023-05-24 Thread Anoob Joseph
From: Volodymyr Fialko Add PDCP protocol header to be used for supporting PDCP protocol processing. Signed-off-by: Anoob Joseph Signed-off-by: Kiran Kumar K Signed-off-by: Volodymyr Fialko Acked-by: Akhil Goyal --- doc/api/doxy-api-index.md | 3 +- lib/net/meson.build | 1 + lib/n

[PATCH v3 00/22] lib: add pdcp protocol

2023-05-24 Thread Anoob Joseph
Add Packet Data Convergence Protocol (PDCP) processing library. The library is similar to lib_ipsec which provides IPsec processing capabilities in DPDK. PDCP would involve roughly the following operations, 1. Transfer of user plane data 2. Transfer of control plane data 3. Header compression 4.

RE: [RFC PATCH] ethdev: advertise flow restore in mbuf

2023-05-24 Thread Ori Kam
Hi David > -Original Message- > From: David Marchand > Sent: Friday, May 5, 2023 1:31 PM > > As reported by Ilya [1], unconditionally calling > rte_flow_get_restore_info() impacts an application performance for drivers > that do not provide this ops. > It could also impact processing of

Re: [PATCH] maintainers: add maintainers to Nvidia net mlx5

2023-05-24 Thread Thomas Monjalon
> > > Add Ori Kam and Suanming Mou to the mainterners list of the Nvidia > > network > > > mlx5 PMD. > > > > > > Signed-off-by: Matan Azrad > > Acked-by: Suanming Mou > Acked-by: Ori Kam Applied, thanks.

Re: [PATCH v3 0/7] replace rte atomics with GCC builtin atomics

2023-05-24 Thread Tyler Retzlaff
On Wed, May 24, 2023 at 02:40:43PM +0200, David Marchand wrote: > Hello Tyler, > > On Thu, Mar 23, 2023 at 11:54 PM Tyler Retzlaff > wrote: > > > > Replace the use of rte_atomic.h types and functions, instead use GCC > > supplied C++11 memory model builtins. > > > > This series covers the librari

Re: seeking community input on adapting DPDK to P4Runtime backend

2023-05-24 Thread Thomas Monjalon
24/05/2023 17:00, Jerin Jacob: > We did some study to use rte_flow on table driven _HW_ (HW has similar > capability to p4 table) > Following are the observations that need improvement in rte_flow. > > > 1) HW engines require more resources for ACL (considering the > algorithmic HW implementation

RE: [PATCH v14] app/procinfo: display eventdev xstats

2023-05-24 Thread Pattan, Reshma
> -Original Message- > From: Sevincer, Abdullah The code looks better now, however if you can make below changes that would be great. > + > +struct eventdev_params { > + uint32_t show_eventdev; Can't we get rid of the "show_eventdev", and just rely below flags > + uint8_

Re: seeking community input on adapting DPDK to P4Runtime backend

2023-05-24 Thread Jerin Jacob
On Mon, May 22, 2023 at 10:42 AM Zhang, Qi Z wrote: > > > > > -Original Message- > > From: Ori Kam > > Sent: Thursday, May 18, 2023 10:34 PM > > To: Zhang, Qi Z ; dev@dpdk.org > > Cc: techbo...@dpdk.org; Richardson, Bruce ; > > Burakov, Anatoly ; Wiles, Keith > > ; Liang, Cunming ; Wu, >

AF_XDP performance

2023-05-24 Thread Alireza Sanaee
Hi everyone, I was looking at this deck of slides https://www.dpdk.org/wp-content/uploads/sites/35/2020/11/XDP_ZC_PMD-1.pdf I tried to reproduce the results with the testpmd application. I am working with BlueField 2 NIC and I could sustain ~10Mpps with testpmd with AF_XDP, and about 20Mpps

[PATCH v2] usertools/telemetry: fix unused parameter

2023-05-24 Thread Samina Arshad
This bug fix ensures that the runtime socket path is generated correctly, based on the user-specified file_prefix value, resolving the issue that occurred in the previous implementation. Fixes: a15fc792cfb6 ("usertools/telemetry: add file prefix argument") Cc: lihuis...@huawei.com Cc: sta...@dpdk.

Re: [PATCH] common/mlx5: adjust fork call with the new kernel API

2023-05-24 Thread Stephen Hemminger
On Wed, 24 May 2023 15:01:40 +0300 wrote: > From: Erez Ferber > > While doing process fork() the operating system remaps all the parent > process's memory to the address space of the child process and activates > the Copy-on-Write mechanics - it duplicates physical pages once memory > writing h

Re: [PATCH] doc: deprecation notice to add new hash function

2023-05-24 Thread Stephen Hemminger
On Wed, 24 May 2023 19:38:27 +0800 Xueming Li wrote: > + > +* ethdev: The enum ``rte_eth_hash_function`` will be extended to add > + new subtype value ``RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ_SORT`` in > + DPDK 23.11. Simple new additions like this don't need to clutter the deprecation part

RE: [PATCH v3 04/10] net/cpfl: add haipin queue group during vport init

2023-05-24 Thread Wu, Jingjing
> static int > cpfl_dev_vport_init(struct rte_eth_dev *dev, void *init_params) > { > @@ -1306,6 +1414,8 @@ cpfl_dev_vport_init(struct rte_eth_dev *dev, void > *init_params) > struct cpfl_adapter_ext *adapter = param->adapter; > /* for sending create vport virtchnl msg prepare */ >

RE: [PATCH v3 02/10] net/cpfl: support hairpin queue capbility get

2023-05-24 Thread Wu, Jingjing
> -Original Message- > From: Xing, Beilei > Sent: Friday, May 19, 2023 3:31 PM > To: Wu, Jingjing > Cc: dev@dpdk.org; Liu, Mingxia ; Xing, Beilei > ; Wang, Xiao W > Subject: [PATCH v3 02/10] net/cpfl: support hairpin queue capbility get > > From: Beilei Xing > > This patch adds hai

Re: [dpdk-dev] [PATCH v2 2/2] net/cnxk: support Tx queue flow pattern item

2023-05-24 Thread Jerin Jacob
On Wed, May 24, 2023 at 10:24 AM wrote: > > From: Satheesh Paul > > Added support for Tx queue flow pattern item. > > Signed-off-by: Satheesh Paul > Reviewed-by: Kiran Kumar K Series applied to dpdk-next-net-mrvl/for-next-net. Thanks > --- > doc/guides/nics/features/cnxk.ini | 1 + > do

RE: [PATCH 0/2] net/mlx5: add modify field actions number validation

2023-05-24 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Dariusz Sosnowski > Sent: Wednesday, May 17, 2023 11:25 PM > To: Ori Kam ; Suanming Mou ; > Matan Azrad ; Slava Ovsiienko > > Cc: dev@dpdk.org > Subject: [PATCH 0/2] net/mlx5: add modify field actions number validation > > This patchset adds validation f

RE: [PATCH v2 0/3] Windows performance enhancements

2023-05-24 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Tal Shnaiderman > Sent: Tuesday, May 16, 2023 2:26 PM > To: dev@dpdk.org > Cc: NBU-Contact-Thomas Monjalon (EXTERNAL) ; > Matan Azrad ; Slava Ovsiienko > ; Raslan Darawsheh ; Pier > Damouny ; Tamer Hleihel > Subject: [PATCH v2 0/3] Windows performance enh

RE: [PATCH v1 0/2] disallow duplicated tag index

2023-05-24 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Rongwei Liu > Sent: Tuesday, May 16, 2023 8:43 AM > To: dev@dpdk.org; Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; NBU-Contact- > Thomas Monjalon (EXTERNAL) > Subject: [PATCH v1 0/2] disallow duplicated tag index > > Doesn't allow duplicated tag index mat

RE: [PATCH v2] common/mlx5: enable operation in iova virtual address mode

2023-05-24 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Slava Ovsiienko > Sent: Wednesday, April 12, 2023 8:07 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Ori Kam > Subject: [PATCH v2] common/mlx5: enable operation in iova virtual address > mode > > The ConnectX NIC series hardware provides

Re: [RFC PATCH] ethdev: advertise flow restore in mbuf

2023-05-24 Thread David Marchand
Hello guys, On Fri, May 5, 2023 at 12:31 PM David Marchand wrote: > > As reported by Ilya [1], unconditionally calling > rte_flow_get_restore_info() impacts an application performance for drivers > that do not provide this ops. > It could also impact processing of packets that require no call to

RE: [PATCH v2 2/3] net/mlx5: add support for infiniband BTH match

2023-05-24 Thread Ori Kam
Hi Bill, > -Original Message- > From: Bill Zhou > Sent: Wednesday, May 24, 2023 1:08 PM > > This patch adds support to match opcode and dst_qp fields in > infiniband BTH. Currently, only the RoCEv2 packet is supported, > the input BTH match item is defaulted to match one RoCEv2 packet. >

Re: [PATCH 0/3] use C11 memory model GCC builtin atomics

2023-05-24 Thread David Marchand
On Mon, Mar 27, 2023 at 4:30 PM Tyler Retzlaff wrote: > > Replace the use of __sync__and_fetch and __sync_fetch_and_ atomics > with GCC C11 memory model __atomic builtins. > > This series contributes to converging on standard atomics in 23.11 but is > kept separate as there may be sensitivity to c

[PATCH v2] test/crypto: fix IPsec AES CCM test vector

2023-05-24 Thread Tejasree Kondoj
Set IPsec AES-CCM test vector IV length to 11 instead of 12 as it includes only 3B salt and 8B per packet IV. Fixes: d314299950de ("test/crypto: add AES-CCM vectors") Cc: sta...@dpdk.org Signed-off-by: Tejasree Kondoj --- app/test/test_cryptodev_security_ipsec_test_vectors.h | 3 ++- 1 file cha

RE: [PATCH] doc: deprecation notice to add new hash function

2023-05-24 Thread Ori Kam
Hi Xueming, > -Original Message- > From: Xueming(Steven) Li > Sent: Wednesday, May 24, 2023 2:38 PM > > Deprecation notice to annouce new RSS hash function type. > The new symmetric hash function sort L3 address and L4 ports > before Toeplitz calculation. > > Signed-off-by: Xueming Li

RE: [PATCH v2] test/crypto: free memory in error and skip paths

2023-05-24 Thread Akhil Goyal
> Subject: [PATCH v2] test/crypto: free memory in error and skip paths > > In multi session tests, multiple sessions get created. So the handling > in ut_teardown won't guard against any memory that is not freed by the > test case. Test case should free sessions as well as local memory that > was

Re: [PATCH v3 0/7] replace rte atomics with GCC builtin atomics

2023-05-24 Thread David Marchand
Hello Tyler, On Thu, Mar 23, 2023 at 11:54 PM Tyler Retzlaff wrote: > > Replace the use of rte_atomic.h types and functions, instead use GCC > supplied C++11 memory model builtins. > > This series covers the libraries and drivers that are built on Windows. > > The code has be converted to use the

RE: [RFC PATCH 4/5] power: add eventdev support for power management

2023-05-24 Thread Tummala, Sivaprasad
[AMD Official Use Only - General] Hi, > -Original Message- > From: Burakov, Anatoly > Sent: Wednesday, May 17, 2023 8:14 PM > To: Tummala, Sivaprasad ; > david.h...@intel.com; jer...@marvell.com; harry.van.haa...@intel.com > Cc: dev@dpdk.org > Subject: Re: [RFC PATCH 4/5] power: add even

RE: [PATCH] test/crypto: remove redundant code

2023-05-24 Thread Akhil Goyal
> > Subject: [PATCH] test/crypto: remove redundant code > > > > Code for registering raw API tests for various PMDs are repeated. > > Add common routine to avoid duplication of code. > > > > Signed-off-by: Anoob Joseph > > --- > > app/test/test_cryptodev.c | 40 ++-

RE: [PATCH 1/2] test/crypto: use separate keys for auth and cipher

2023-05-24 Thread Akhil Goyal
> > Subject: [PATCH 1/2] test/crypto: use separate keys for auth and cipher > > > > The mixed test cases can have keys with different key lengths. The routine > > which prepares the session parameters uses same key length for both cipher > > & auth keys. Instead allow the caller to use same keys as

RE: [EXT] [PATCH v2] crypto/ipsec_mb: enqueue counter fix

2023-05-24 Thread Akhil Goyal
> This patch removes enqueue op counter update from the process_op_bit > function where the process is now done in dequeue stage. The original > stats increment was incorrect as they shouldn't have been updated at all > in this function. > > Fixes: 4f1cfda59ad3 ("crypto/ipsec_mb: move snow3g PMD")

RE: [PATCH v2] app/crypto-perf: check crypto result

2023-05-24 Thread Akhil Goyal
> > Subject: [PATCH v2] app/crypto-perf: check crypto result > > > > Check crypto result in latency tests. Checking result won't affect the test > > results as latency is calculated using timestamps which are done before > > enqueue and after dequeue. Ignoring result means the data can be false > >

RE: [PATCH] test/crypto: fix return value from session

2023-05-24 Thread Akhil Goyal
> > Subject: [PATCH] test/crypto: fix return value from session > > > > Fixing return value if session failure occurs due to unsupported feature. > > > > Fixes: eec136f3c54f ("aesni_gcm: add driver for AES-GCM crypto > > operations") > > Cc: sta...@dpdk.org > > > > Signed-off-by: Tejasree Kondoj >

  1   2   >