> -Original Message-
> From: David Marchand
> Sent: Thursday, March 9, 2023 8:38 PM
> To: dev@dpdk.org
> Cc: sta...@dpdk.org; Maxime Coquelin ; Xia,
> Chenbo ; Jianfeng Tan ;
> Junjie Chen ; Hyong Youb Kim ;
> Harman Kalra
> Subject: [PATCH 3/3] net/vhost: fix Rx interrupt
>
> In the sit
Thanks & Regards,
Yogesh Jangra
-Original Message-
From: Dumitrescu, Cristian
Sent: Friday, March 10, 2023 1:40 AM
To: dev@dpdk.org
Cc: R, Kamalakannan ; Jangra, Yogesh
; Suresh Narayane, Harshad
Subject: [PATCH V3] doc: announce the pipeline legacy API deprecation
Announce the d
From: James Hershaw
Due to changes in the firmware for NFPs, firmware will no longer write
the link speed of a port to the control BAR. In line with the behaviour
of the kernel NFP driver, this is now handled by the PMD by reading the
value provided by the NSP in the nfp_eth_table struct within t
From: James Hershaw
Expand the selection of read/write helper functions to include values of
16 bits.
Signed-off-by: James Hershaw
Reviewed-by: Niklas Söderlund
Reviewed-by: Chaoyong He
---
drivers/net/nfp/nfp_common.h | 17 +
1 file changed, 17 insertions(+)
diff --git a/dr
Due to changes in the firmware for NFPs, firmware will no longer write
the link speed of a port to the control BAR. In line with the behaviour
of the kernel NFP driver, this is now handled by the PMD by reading the
value provided by the NSP in the nfp_eth_table struct within the pf_dev
of the port
Hi David,
The case is just want to enable ASAN to scan customer developed code.
> -Original Message-
> From: David Marchand
> Sent: Thursday, March 9, 2023 11:08 PM
> To: Maxime Coquelin
> Cc: dev@dpdk.org; Pei, Andy ; Xia, Chenbo
>
> Subject: Re: [PATCH] net/virtio: remove address w
HI
> -Original Message-
> From: David Marchand
> Sent: Thursday, March 9, 2023 10:36 PM
> To: dev@dpdk.org
> Cc: Pei, Andy ; Maxime Coquelin
> ; Xia, Chenbo
> Subject: [PATCH] net/virtio: remove address width limit for modern devices
>
> Modern devices don't have the same limitation as
> On 3/6/2023 7:06 AM, Chaoyong He wrote:
> >> On 2/21/2023 6:29 AM, Chaoyong He wrote:
> >>> From: James Hershaw
> >>>
> >>> Due to changes in the firmware for NFPs, firmware will no longer
> >>> write the link speed of a port to the control BAR. In line with the
> >>> behaviour of the kernel NFP
-Original Message-
From: Dumitrescu, Cristian
Sent: Friday, March 10, 2023 1:40 AM
To: dev@dpdk.org
Cc: R, Kamalakannan ; Jangra, Yogesh
; Suresh Narayane, Harshad
Subject: [PATCH V3] doc: announce the pipeline legacy API deprecation
Announce the deprecation of the legacy pipeline, ta
The bond port is failed to forward packets in Link Aggregation
802.3AD(4) mode. Because bond devices get LACP packets from
rx_ring instead of tx_ring.
This commit will get LACP packets from tx_ring instead.
Fixes: 112891cd27e5 ("net/bonding: add dedicated HW queues for LACP control")
Cc: sta...@
>
>
>
> >
> > Use lcore API to check if the lcore ID is valid. The runtime check
> > does not add much value.
>
> From my perspective it adds a perfect value:
> Only threads with valid lcore id have their own default mempool cache.
The threads would call 'rte_lcore_id()' to return their lcore_
> -Original Message-
> From: fengchengwen
> Sent: Thursday, March 9, 2023 5:31 AM
> To: Honnappa Nagarahalli ; Konstantin
> Ananyev ; dev@dpdk.org;
> tho...@monjalon.net; Ferruh Yigit ; Andrew
> Rybchenko ; Kalesh AP anakkur.pura...@broadcom.com>; Ajit Khaparde
> (ajit.khapa...@broadcom
> -Original Message-
> From: David Marchand
> Sent: Thursday, March 9, 2023 8:38 PM
> To: dev@dpdk.org
> Cc: sta...@dpdk.org; Maxime Coquelin ; Xia,
> Chenbo ; Hyong Youb Kim ; Harman
> Kalra
> Subject: [PATCH 2/3] net/vhost: fix leak in interrupt handle setup
>
> Do a systematic cleanup
> -Original Message-
> From: David Marchand
> Sent: Thursday, March 9, 2023 8:38 PM
> To: dev@dpdk.org
> Cc: sta...@dpdk.org; Maxime Coquelin ; Xia,
> Chenbo ; Junjie Chen ;
> Jianfeng Tan ; Jiang, Cheng1
>
> Subject: [PATCH 1/3] net/vhost: add missing newline in logs
>
> Fixes: 3f8ff128
> -Original Message-
> From: Thomas Monjalon
> Sent: 10 March 2023 00:13
> To: Srikanth Yalavarthi
> Cc: dev@dpdk.org; Shivah Shankar Shankar Narayan Rao
> ; Jerin Jacob Kollanukkaran
> ; Anup Prabhu ; Prince Takkar
> ; Parijat Shukla
> Subject: [EXT] Re: [PATCH v4 04/12] app/mldev: add
> -Original Message-
> From: Maxime Coquelin
> Sent: Thursday, March 9, 2023 7:37 PM
> To: dev@dpdk.org; m...@redhat.com; Xia, Chenbo ;
> david.march...@redhat.com
> Cc: Maxime Coquelin
> Subject: [PATCH] vhost: fix possible null pointer dereference
>
> When handling VHOST_USER_SET_MEM_T
https://bugs.dpdk.org/show_bug.cgi?id=1175
Bug ID: 1175
Summary: [dpdk-23.03][meson test][asan] rawdev_autotest show
AddressSanitizer: stack-buffer-overflow error
Product: DPDK
Version: 23.03
Hardware: All
O
Claim PMD supports pmd_supports_disable_iova_as_pa.
Signed-off-by: Chengwen Feng
---
drivers/dma/hisilicon/meson.build | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/dma/hisilicon/meson.build
b/drivers/dma/hisilicon/meson.build
index 0786772442..26eab443a9 100644
--- a/drivers/dma/
07/02/2023 17:06, Srikanth Yalavarthi:
> --- a/doc/guides/rel_notes/release_23_03.rst
> +++ b/doc/guides/rel_notes/release_23_03.rst
> +* **Implementation of Marvell CNXK machine learning driver for .**
It seems a word is missing.
It looks like you did a lot of work on the mldev series,
so some d
Tested-by: Patrick Robb
On Fri, Mar 3, 2023 at 5:25 AM Juraj Linkeš
wrote:
> Document how to configure and run DTS.
> Also add documentation related to new features: SUT setup and a brief
> test suite implementation cookbook.
>
> Signed-off-by: Juraj Linkeš
> ---
> doc/guides/tools/dts.rst |
07/02/2023 17:00, Srikanth Yalavarthi:
> Machine Learning common code
>
>
> This patch series implements the common ML code that can be used by
> ML drivers. Common code include functions to convert ML IO type to
> string, IO format type to string, function get size of
There doesn't seem to be anything keeping this from building on Windows.
Signed-off-by: Stephen Hemminger
---
lib/table/meson.build | 6 --
1 file changed, 6 deletions(-)
diff --git a/lib/table/meson.build b/lib/table/meson.build
index 4f826b4b27e8..f8cef24b5918 100644
--- a/lib/table/meson
Allow building on Windows, need to provide some comparability
wrappers for writev() and if_nametoindex.
Signed-off-by: Stephen Hemminger
Acked-by: Tyler Retzlaff
---
lib/pcapng/meson.build | 6 -
lib/pcapng/rte_pcapng.c | 59 +++--
2 files changed, 57 i
The RIB library builds on Windows as long as sys/queue.h is included
Signed-off-by: Stephen Hemminger
Acked-by: Tyler Retzlaff
---
app/test/test_rib.c | 19 ---
app/test/test_rib6.c | 24 ++--
lib/rib/meson.build | 6 --
lib/rib/rte_rib.c| 1 +
li
The FIB library builds on Windows as long as sys/queue.h is defined.
Signed-off-by: Stephen Hemminger
Acked-by: Tyler Retzlaff
---
app/test/test_fib.c | 22 +-
app/test/test_fib6.c | 24 ++--
app/test/test_fib6_perf.c | 15 +--
app/
This build works on Windows if sys/queue.h is included.
Signed-off-by: Stephen Hemminger
Acked-by: Tyler Retzlaff
---
app/test/test_ipfrag.c | 12
lib/ip_frag/ip_frag_common.h | 2 ++
lib/ip_frag/meson.build | 6 --
3 files changed, 2 insertions(+), 18 deletions(-)
This builds on Windows if sys/queue.h is included.
Signed-off-by: Stephen Hemminger
Acked-by: Tyler Retzlaff
---
app/test/test_reorder.c | 11 ---
lib/reorder/meson.build | 6 --
lib/reorder/rte_reorder.c | 1 +
3 files changed, 1 insertion(+), 17 deletions(-)
diff --git a/ap
The command line arguments are stored in node_action_pair
and the name[] was sized to PATH_MAX which does not exist on Windows.
Since the name is either "CREATE" or "ATTACH" it is not
related to PATH_MAX (4096).
With this fix driver builds ok on windows, but need to modify the
test meson build to
This builds on Windows without changes.
Signed-off-by: Stephen Hemminger
Acked-by: Tyler Retzlaff
---
app/test/test_lpm.c | 15 +--
app/test/test_lpm6.c | 12
app/test/test_lpm6_data.h | 3 ++-
app/test/test_lpm6_perf.c | 14 +-
app/test/test_lpm
Builds fine with current code, no changes needed.
Signed-off-by: Stephen Hemminger
Acked-by: Tyler Retzlaff
---
drivers/net/null/meson.build | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/net/null/meson.build b/drivers/net/null/meson.build
index 4a483955a7a9..a51f8f5211b0 1006
While diagnosing some Windows cross build errors;
noticed that lots of important DPDK libraries are not
being built on Windows.
Stephen Hemminger (8):
net/null: build null PMD on Windows
net/ring: build on Windows
lpm: enable on Windows
reorder: build on Windows
ip_frag: enable build on
On Thu, 9 Mar 2023 22:10:03 +0100
David Marchand wrote:
> > diff --git a/drivers/net/ring/rte_eth_ring.c
> > b/drivers/net/ring/rte_eth_ring.c
> > index bd5a47dd9017..e8bc9b627102 100644
> > --- a/drivers/net/ring/rte_eth_ring.c
> > +++ b/drivers/net/ring/rte_eth_ring.c
> > @@ -9,6 +9,7 @@
> >
On Mon, Feb 20, 2023 at 12:14 AM Stephen Hemminger
wrote:
>
> The command line arguments are stored in node_action_pair
> and the name[] was sized to PATH_MAX which does not exist on Windows.
> Since the name is either "CREATE" or "ATTACH" it is not
> related to PATH_MAX (4096).
>
> With this fix
On Thu, Mar 9, 2023 at 9:49 PM Tyler Retzlaff
wrote:
>
> On Thu, Mar 09, 2023 at 10:58:06AM +0100, Thomas Monjalon wrote:
> > 09/03/2023 10:17, David Marchand:
> > > On Tue, Mar 7, 2023 at 3:33 PM David Marchand
> > > wrote:
> > > > On Thu, Mar 2, 2023 at 7:44 PM Tyler Retzlaff
> > > > wrote:
>
On Thu, Mar 09, 2023 at 10:58:06AM +0100, Thomas Monjalon wrote:
> 09/03/2023 10:17, David Marchand:
> > On Tue, Mar 7, 2023 at 3:33 PM David Marchand
> > wrote:
> > > On Thu, Mar 2, 2023 at 7:44 PM Tyler Retzlaff
> > > wrote:
> > > >
> > > > In rte_thread_create setting affinity after pthread_c
07/02/2023 17:00, Srikanth Yalavarthi:
> Added header files for internal ML utility routines to convert
> IO type and format to string, IO type to size and routines to
> convert data types.
>
> Signed-off-by: Srikanth Yalavarthi
> ---
> Depends-on: series-26858 ("Implementation of mldev test appl
On Thu, 9 Mar 2023 12:27:58 -0600
Abdullah Sevincer wrote:
>
> +/* Note: Port_queue_id in xstats APIs is 8 bits, so we have a maximum of
> + * 256 ports and queues for event_Dev
> + */
> +#define MAX_PORTS_QUEUES 256
> +
There is a goal of removing the per-queue stats part in generic stats.
A
On Thu, 9 Mar 2023 17:19:59 +
"Dumitrescu, Cristian" wrote:
> > -Original Message-
> > From: Stephen Hemminger
> > Sent: Thursday, March 9, 2023 4:31 PM
> > To: Jangra, Yogesh
> > Cc: dev@dpdk.org; Dumitrescu, Cristian ; R,
> > Kamalakannan ; Suresh Narayane, Harshad
> >
> > Subjec
07/02/2023 16:49, Srikanth Yalavarthi:
> - ml_err("error_code = 0x%016lx, error_message = %s\n",
> error.errcode,
> + ml_err("error_code = 0x%" PRIx64 ", error_message =
> %s\n", error.errcode,
> error.message);
>
Announce the deprecation of the legacy pipeline, table and port
library API and gradual stabilization of the new API.
Signed-off-by: Cristian Dumitrescu
---
doc/guides/rel_notes/deprecation.rst | 18 ++
1 file changed, 18 insertions(+)
diff --git a/doc/guides/rel_notes/deprecati
07/02/2023 16:49, Srikanth Yalavarthi:
> static struct option lgopts[] = {
> - {ML_TEST, 1, 0, 0}, {ML_DEVICE_ID, 1, 0, 0}, {ML_SOCKET_ID, 1, 0, 0},
> {ML_MODELS, 1, 0, 0},
> - {ML_DEBUG, 0, 0, 0}, {ML_HELP, 0, 0, 0}, {NULL, 0, 0, 0}};
> + {ML_TEST, 1, 0, 0}, {ML_DEVICE_ID, 1,
> -Original Message-
> From: Dumitrescu, Cristian
> Sent: Thursday, March 9, 2023 5:20 PM
> To: Stephen Hemminger ; Jangra, Yogesh
>
> Cc: dev@dpdk.org; R, Kamalakannan ; Suresh
> Narayane, Harshad
> Subject: RE: [PATCH] app/testpmd: fix closing softnic port before ethdev ports
>
>
> -Original Message-
> From: Jangra, Yogesh
> Sent: Thursday, March 9, 2023 2:43 PM
> To: dev@dpdk.org
> Cc: Dumitrescu, Cristian ; Jangra, Yogesh
> ; R, Kamalakannan ;
> Suresh Narayane, Harshad
> Subject: [PATCH] app/testpmd: fix closing softnic port before ethdev ports
>
> SoftNIC r
This commit extends proc-info application to
display xstats for the eventdev devices.
New command line arguments are introduced to
display xstats for eventdev devices. The command
example is like:
For displaying a specific port stats (e.g. port 1):
./dpdk-proc-info -- --show-edev-port-xstats=1
I
07/02/2023 16:49, Srikanth Yalavarthi:
> --- a/app/test-mldev/ml_options.c
> +++ b/app/test-mldev/ml_options.c
> @@ -4,6 +4,7 @@
>
> #include
> #include
> +#include
It breaks on non-Linux OS of course.
include is enough and more portable.
I will fix while merging.
In general, I think you
Any updates?
On Sat, Feb 25, 2023 at 6:53 PM Tanzeel-inline
wrote:
> From: Tanzeel Ahmed
>
> This patch is new version of [PATCH] lib/net: added push MPLS header API.
> I have also added the MPLS strip functionality to address the question
> asked in last patch.
>
> > You should explain why yo
This commit extends proc-info application to
display xstats for the eventdev devices.
New command line arguments are introduced to
display xstats for eventdev devices. The command
example is like:
For displaying a specific port stats (e.g. port 1):
./dpdk-proc-info -- --show-edev-port-xstats=1
I
09/03/2023 18:35, Chautru, Nicolas:
>
> > From: Thomas Monjalon
> > 06/03/2023 18:41, Chautru, Nicolas:
> > > Hi Thomas,
> > >
> > > Any update with regards to that series? Unsure how much more you want it
> > to become generic. Ie. replacing most of "network port" by "PCIe device"
> >
> > Devic
> From: Thomas Monjalon
> 06/03/2023 18:41, Chautru, Nicolas:
> > Hi Thomas,
> >
> > Any update with regards to that series? Unsure how much more you want it
> to become generic. Ie. replacing most of "network port" by "PCIe device"
>
> Devices are not always PCI based.
> The doc should reviewe
07/02/2023 16:13, jer...@marvell.com:
> Jerin Jacob (1):
> mldev: introduce machine learning device library
>
> Srikanth Yalavarthi (11):
> mldev: support PMD functions for ML device
> mldev: support ML device handling functions
> mldev: support ML device queue-pair setup
> mldev: suppor
Release status meeting minutes 2023-03-09
=
Agenda:
* Release Dates
* Subtrees
* Roadmaps
* LTS
* Defects
* Opens
Participants:
* AMD
* Intel
* Marvell
* Nvidia
* Red Hat
Release Dates
-
The following are the proposed current dates for 23.03
> -Original Message-
> From: Stephen Hemminger
> Sent: Thursday, March 9, 2023 4:31 PM
> To: Jangra, Yogesh
> Cc: dev@dpdk.org; Dumitrescu, Cristian ; R,
> Kamalakannan ; Suresh Narayane, Harshad
>
> Subject: Re: [PATCH] app/testpmd: fix closing softnic port before ethdev ports
>
> O
On 3/9/23 06:16, Nobuhiro MIKI wrote:
Simply replace 'master' with 'frontend' and 'slave' with 'backend'.
Signed-off-by: Nobuhiro MIKI
Acked-by: Stephen Hemminger
---
drivers/vdpa/ifc/ifcvf_vdpa.c | 2 +-
lib/vhost/rte_vhost.h | 8 ++--
lib/vhost/version.map | 2 +-
On 3/9/23 06:16, Nobuhiro MIKI wrote:
DPDK apps (e.g. dpdk-skeleton) output this name
during negotiation. But, it is not consistent when
debugging using QEMU as a front-end, for example.
This is because QEMU already follows new naming convention [1].
Some type names and variable names, such a
On Thu, 9 Mar 2023 14:42:49 +
Yogesh Jangra wrote:
> + /*
> + * SoftNIC runs on the sevice core, it uses the resources from
> + * the testpmd application. When we run quit command, the
> testpmd
> + * application stops ethdev ports first, S
-Original Message-
From: Akhil Goyal
Sent: 09 March 2023 21:41
To: Thomas Monjalon ; David Marchand
; Jerin Jacob Kollanukkaran
Cc: Morten Brørup ; Rasesh Mody
; Shahed Shaikh ; dev@dpdk.org; Alok
Prasad
Subject: RE: [EXT] Re: [PATCH v7 1/4] net/bnx2x: fix warnings about rte_memcpy
++Alok Prasad
> 09/03/2023 11:25, David Marchand:
> > On Thu, Feb 9, 2023 at 5:49 PM Morten Brørup
> wrote:
> > >
> > > PING bnx2x maintainers. Care to review this bugfix, so it can be included
> > > in
> 23.03?
> > >
> >
> > Still no luck in getting attention from bnx2x maintainers.
> > One opt
SoftNIC runs on the service core, it uses the resources from
the testpmd application. When we run quit command, the testpmd
application stops ethdev ports first, SoftNIC will try to
access the port and sometimes that results in segmentation
error. This fix will first close the SoftNIC port.
Signed
> -Original Message-
> From: Honnappa Nagarahalli
> Sent: четверг, 9 марта 2023 г. 04:33
> To: Matan Azrad ; Shahaf Shuler ;
> Slava Ovsiienko
> Cc: dev@dpdk.org; honnappa.nagaraha...@arm.com; ruifeng.w...@arm.com;
> n...@arm.com; Matan Azrad ; sta...@dpdk.org
> Subject: [PATCH v3] net/ml
On 3/2/23 08:50, Chengwen Feng wrote:
The rte_kvargs_process() was used to parse KV pairs, it also supports
to parse 'only keys' (e.g. socket_id) type. And the callback function
parameter 'value' is NULL when parsed 'only keys'.
This patch fixes segment fault when parse input args with 'only
On 2023-03-05 18:25, Stephen Hemminger wrote:
On Tue, 28 Feb 2023 10:39:16 +0100
Mattias Rönnblom wrote:
The htimer library attempts at providing a timer facility with roughly
the same functionality, but less overhead and better scalability than
DPDK timer library.
The htimer library employs
On Thu, Mar 2, 2023 at 8:56 AM Chengwen Feng wrote:
>
> The rte_kvargs_process() was used to parse KV pairs, it also supports
> to parse 'only keys' (e.g. socket_id) type. And the callback function
> parameter 'value' is NULL when parsed 'only keys'.
>
> But where there is no detailed definition o
SoftNIC runs on the sevice core, it uses the resources from the testpmd
application. When we run quit command, the testpmd application stops
ethdev ports first, SoftNIC will try to access the port and sometimes
that result in segmentation error.This fix will first close the SoftNIC port.
Signed-of
On Thu, Mar 9, 2023 at 3:59 PM Maxime Coquelin
wrote:
>
> Hi David,
>
> On 3/9/23 15:36, David Marchand wrote:
> > Modern devices don't have the same limitation as legacy devices, because
> > vring addresses are not configured using a 32-bit register.
> >
>
> Do we want to backport it? This is a b
Hi David,
On 3/9/23 15:36, David Marchand wrote:
Modern devices don't have the same limitation as legacy devices, because
vring addresses are not configured using a 32-bit register.
Do we want to backport it? This is a bug in my opinion.
Reviewed-by: Maxime Coquelin
Thanks!
Maxime
Signe
Modern devices don't have the same limitation as legacy devices, because
vring addresses are not configured using a 32-bit register.
Signed-off-by: David Marchand
---
drivers/net/virtio/virtio_pci.c | 28
1 file changed, 8 insertions(+), 20 deletions(-)
diff --git a
This patch adds support to the QAT symmetric crypto PMD for combined
cipher-crc offload feature, primarily for DOCSIS, on gen2/gen3/gen4
QAT devices.
A new parameter called qat_sym_cipher_crc_enable has been
added to the PMD, which can be set on process start as follows:
-a ,qat_sym_cipher_crc_en
This patch adds support to the QAT firmware interface header files
for the combined cipher-crc offload feature for DOCSIS on gen2/gen3/
gen4 QAT devices. The main change is that new structures have been
added for the crc content descriptor for the various generations.
Signed-off-by: Kevin O'Sulliv
This patchset adds support to the QAT PMD for combined cipher-crc
processing for DOCSIS on the QAT device. The current QAT PMD
implementation of cipher-crc calculates CRC in software and uses QAT
for encryption/decryption offload.
Note: The previous code-path is still retained for QAT firmware
ver
The incorrect variable for the number of groups was used, so in the
case of values not power of 2 the incorrect result was produced.
Fixes: f7598a62d11 (table: support selector table)
Cc: sta...@dpdk.org
Signed-off-by: Yogesh Jangra
Acked-by: Cristian Dumitrescu
---
lib/table/rte_swx_table_sel
Add new maintainer and remove old one from list for qede PMD.
Signed-off-by: Devendra Singh Rawat
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 878204c93b..bdd5c311bc 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -936,8 +936,8
Announce the deprecation of the legacy pipeline, table and port
library API and gradual stabilization of the new API.
Signed-off-by: Cristian Dumitrescu
---
doc/guides/rel_notes/deprecation.rst | 18 ++
1 file changed, 18 insertions(+)
diff --git a/doc/guides/rel_notes/deprecati
Hi Chengwen,
The patch looks good to me.
Please find below few minor style comments.
On Thu, Mar 02, 2023 at 07:50:04AM +, Chengwen Feng wrote:
> [PATCH 1/9] kvargs: detailed definition of callback prototype
kvargs: add API documentation for process callback
>
> The rte_kvargs_process() was
On Thu, Mar 09, 2023 at 01:12:51PM +0100, Thomas Monjalon wrote:
> 09/03/2023 12:23, fengchengwen:
> > On 2023/3/9 15:29, Thomas Monjalon wrote:
> > > 09/03/2023 02:43, fengchengwen:
> > >> On 2023/3/7 0:13, Thomas Monjalon wrote:
> > >>> --- a/doc/guides/rel_notes/release_22_11.rst
> > >>> +++ b/d
Hi,
A gentle reminder, any other comments regarding this change?
>-Original Message-
>From: Tomasz Duszynski
>Sent: Wednesday, March 1, 2023 8:59 PM
>To: dev@dpdk.org; Thomas Monjalon ; Tomasz Duszynski
>
>Cc: chenbo@intel.com; Jerin Jacob Kollanukkaran ;
>step...@networkplumber.org
Fixes: 3f8ff12821e4 ("vhost: support interrupt mode")
Fixes: 8f1750f42e2d ("net/vhost: perform SW checksum in Rx path")
Fixes: 8ba1723783b2 ("net/vhost: perform SW checksum in Tx path")
Cc: sta...@dpdk.org
Signed-off-by: David Marchand
---
drivers/net/vhost/rte_eth_vhost.c | 10 +-
1 fil
In the situation when a port was started while no virtio driver was
connected, Rx interrupts were broken.
They were also broken after a virtio driver reconnects.
There were several issues mixed in:
- this driver was not exposing a fixed file descriptor per Rx queue,
If a virtio driver was not co
Do a systematic cleanup if any part of the interrupt handle setup fails.
Fixes: d61138d4f0e2 ("drivers: remove direct access to interrupt handle")
Cc: sta...@dpdk.org
Signed-off-by: David Marchand
---
drivers/net/vhost/rte_eth_vhost.c | 53 ---
1 file changed, 34 ins
This series fixes Rx interrupts for net/vhost when a virtio driver is
not connected at the time net/vhost starts.
These fixes are a bit late for 23.03, probably a bit scary (wrt the
amount of touched code) and I do not mind deferring them to the next
release.
The last patch may solve bugzilla 1135
09/03/2023 12:23, fengchengwen:
> On 2023/3/9 15:29, Thomas Monjalon wrote:
> > 09/03/2023 02:43, fengchengwen:
> >> On 2023/3/7 0:13, Thomas Monjalon wrote:
> >>> --- a/doc/guides/rel_notes/release_22_11.rst
> >>> +++ b/doc/guides/rel_notes/release_22_11.rst
> >>> @@ -504,7 +504,7 @@ ABI Changes
>
On 3/9/2023 10:38 AM, Mingxia Liu wrote:
> Comparing an enum virtchnl_ops variable with VIRTCHNL2_OP_EVENT
> will cause a compiler issue, as VIRTCHNL2_OP_EVENT is not included
> in enum virtchnl_ops. And the PMD uses virtual msg opcodes prefixed
> with virtchnl2 or VIRTCHNL2.
>
> Fixes: 20618563b8
On 3/9/2023 11:52 AM, Mingxia Liu wrote:
> Comparing an enum virtchnl_ops variable with VIRTCHNL2_OP_EVENT
> will cause a compiler issue, as VIRTCHNL2_OP_EVENT is not included
> in enum virtchnl_ops. And the PMD uses virtual msg opcodes prefixed
> with virtchnl2 or VIRTCHNL2.
>
> Fixes: 78049b3dc7
In inline IPsec path, when the ol_flags indicate error, pkt might
be incomplete. Hence don't trust the m->pkt_len to determine the
size of packet, rather consider even data length's per segment.
Signed-off-by: Nithin Dabilpuram
---
app/test/test_cryptodev_security_ipsec.c | 15 ++-
1
On 3/9/2023 7:07 AM, jer...@marvell.com wrote:
> From: Jerin Jacob
>
> The LiquidIO product line(drivers/net/liquidio) has been substituted with
> CN9K/CN10K OCTEON product line smart NICs located in drivers/net/octeon_ep/.
> DPDK v20.08 has categorized the LiquidIO driver as UNMAINTAINED
> becau
When handling VHOST_USER_SET_MEM_TABLE request ending
up in changing existing memory map, a device's memory
pointer may ends up being dereference while being NULL in
IOTLB cache flush function.
Coverity issue: 383646
Fixes: dea092d0addb ("vhost: fix madvise arguments alignment")
Signed-off-by: Ma
On 2023/3/9 11:03, Honnappa Nagarahalli wrote:
>
>
>> -Original Message-
>> From: fengchengwen
>> Sent: Wednesday, March 8, 2023 7:00 PM
>> To: Honnappa Nagarahalli ; Konstantin
>> Ananyev ; dev@dpdk.org;
>> tho...@monjalon.net; Ferruh Yigit ; Andrew
>> Rybchenko ; Kalesh AP > anakkur
On 2023/3/9 15:29, Thomas Monjalon wrote:
> 09/03/2023 02:43, fengchengwen:
>> On 2023/3/7 0:13, Thomas Monjalon wrote:
>>> --- a/doc/guides/rel_notes/release_22_11.rst
>>> +++ b/doc/guides/rel_notes/release_22_11.rst
>>> @@ -504,7 +504,7 @@ ABI Changes
>>>``rte-worker-`` so that DPDK can ac
09/03/2023 11:25, David Marchand:
> On Thu, Feb 9, 2023 at 5:49 PM Morten Brørup
> wrote:
> >
> > PING bnx2x maintainers. Care to review this bugfix, so it can be included
> > in 23.03?
> >
>
> Still no luck in getting attention from bnx2x maintainers.
> One option is to declare this driver as
Please wait. Jerin is chasing this internally.-MortenSent from smartphone.
Please excuse brevity and spelling.
Oprindelig besked Fra: David Marchand
Dato: 09.03.2023 11.26 (GMT+01:00) Til: Morten
Brørup , rm...@marvell.com, shsha...@marvell.com
Cc: dev@dpdk.org, Thomas Monja
On Thu, Feb 9, 2023 at 5:49 PM Morten Brørup wrote:
>
> PING bnx2x maintainers. Care to review this bugfix, so it can be included in
> 23.03?
>
Still no luck in getting attention from bnx2x maintainers.
One option is to declare this driver as UNMAINTAINED and disable its
compilation when the mem
09/03/2023 10:17, David Marchand:
> On Tue, Mar 7, 2023 at 3:33 PM David Marchand
> wrote:
> > On Thu, Mar 2, 2023 at 7:44 PM Tyler Retzlaff
> > wrote:
> > >
> > > In rte_thread_create setting affinity after pthread_create may fail.
> > > Such a failure should result in the entire rte_thread_cre
>
> Use lcore API to check if the lcore ID is valid. The runtime
> check does not add much value.
>From my perspective it adds a perfect value:
Only threads with valid lcore id have their own default mempool cache.
> Hence use assert to validate
> the lcore ID.
Wonder why?
What's wrong for t
On Tue, Mar 7, 2023 at 3:33 PM David Marchand wrote:
> On Thu, Mar 2, 2023 at 7:44 PM Tyler Retzlaff
> wrote:
> >
> > In rte_thread_create setting affinity after pthread_create may fail.
> > Such a failure should result in the entire rte_thread_create failing
> > but doesn't.
> >
> > Additionally
Building with gcc 12 and ASan raises this warning:
../drivers/net/mlx5/mlx5_txpp.c: In function ‘mlx5_txpp_xstats_get_names’:
../drivers/net/mlx5/mlx5_txpp.c:1066:25: error: ‘strncpy’ specified bound
64 equals destination size [-Werror=stringop-truncation]
1066 | s
On Wed, Mar 1, 2023 at 10:09 PM Tyler Retzlaff
wrote:
>
> When ctrl_thread_init transitions params->ctrl_thread_status from
> CTRL_THREAD_LAUNCHING the creating thread and new thread may run
> concurrently leading to unsynchronized access to params.
>
> This permits races for both the failure and
Add unittest for inline ingress out-of-place processing.
Signed-off-by: Nithin Dabilpuram
---
app/test/test_cryptodev_security_ipsec.c | 8 +++
app/test/test_cryptodev_security_ipsec.h | 1 +
app/test/test_security_inline_proto.c| 85
3 files changed, 94 insertions
Similar to out of place(OOP) processing support that exists for
Lookaside crypto/security sessions, Inline ingress security
sessions may also need out of place processing in usecases
where original encrypted packet needs to be retained for post
processing. So for NIC's which have such a kind of HW
Displaying a bitmask is terrible for users.
Prefer offload names when refusing some offloads in
rte_eth_dev_configure.
Before:
Ethdev port_id=0 requested Rx offloads 0x621 doesn't match Rx offloads
capabilities 0x0 in rte_eth_dev_configure()
After:
Ethdev port_id=0 requested Rx offloads '
98 matches
Mail list logo
