> -----Original Message-----
> From: David Marchand <david.march...@redhat.com>
> Sent: Thursday, March 9, 2023 8:38 PM
> To: dev@dpdk.org
> Cc: sta...@dpdk.org; Maxime Coquelin <maxime.coque...@redhat.com>; Xia,
> Chenbo <chenbo....@intel.com>; Junjie Chen <junjie.j.c...@intel.com>;
> Jianfeng Tan <jianfeng....@intel.com>; Jiang, Cheng1
> <cheng1.ji...@intel.com>
> Subject: [PATCH 1/3] net/vhost: add missing newline in logs
>
> Fixes: 3f8ff12821e4 ("vhost: support interrupt mode")
> Fixes: 8f1750f42e2d ("net/vhost: perform SW checksum in Rx path")
> Fixes: 8ba1723783b2 ("net/vhost: perform SW checksum in Tx path")
> Cc: sta...@dpdk.org
>
> Signed-off-by: David Marchand <david.march...@redhat.com>
> ---
> drivers/net/vhost/rte_eth_vhost.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/vhost/rte_eth_vhost.c
> b/drivers/net/vhost/rte_eth_vhost.c
> index 9c609b45a3..198bf4d1f4 100644
> --- a/drivers/net/vhost/rte_eth_vhost.c
> +++ b/drivers/net/vhost/rte_eth_vhost.c
> @@ -297,7 +297,7 @@ vhost_dev_csum_configure(struct rte_eth_dev *eth_dev)
> if (internal->features & (1ULL << VIRTIO_NET_F_CSUM)) {
> if (!(rxmode->offloads &
> (RTE_ETH_RX_OFFLOAD_UDP_CKSUM |
> RTE_ETH_RX_OFFLOAD_TCP_CKSUM))) {
> - VHOST_LOG(NOTICE, "Rx csum will be done in SW, may
> impact performance.");
> + VHOST_LOG(NOTICE, "Rx csum will be done in SW, may
> impact performance.\n");
> internal->rx_sw_csum = true;
> }
> }
> @@ -305,7 +305,7 @@ vhost_dev_csum_configure(struct rte_eth_dev *eth_dev)
> if (!(internal->features & (1ULL << VIRTIO_NET_F_GUEST_CSUM))) {
> if (txmode->offloads &
> (RTE_ETH_TX_OFFLOAD_UDP_CKSUM |
> RTE_ETH_TX_OFFLOAD_TCP_CKSUM)) {
> - VHOST_LOG(NOTICE, "Tx csum will be done in SW, may
> impact performance.");
> + VHOST_LOG(NOTICE, "Tx csum will be done in SW, may
> impact performance.\n");
> internal->tx_sw_csum = true;
> }
> }
> @@ -646,7 +646,7 @@ eth_rxq_intr_disable(struct rte_eth_dev *dev, uint16_t
> qid)
>
> ret = rte_vhost_get_vhost_vring(vq->vid, (qid << 1) + 1, &vring);
> if (ret < 0) {
> - VHOST_LOG(ERR, "Failed to get rxq%d's vring", qid);
> + VHOST_LOG(ERR, "Failed to get rxq%d's vring\n", qid);
> return ret;
> }
> VHOST_LOG(INFO, "Disable interrupt for rxq%d\n", qid);
> @@ -851,7 +851,7 @@ new_device(int vid)
> if (dev_conf->intr_conf.rxq) {
> if (eth_vhost_install_intr(eth_dev) < 0) {
> VHOST_LOG(INFO,
> - "Failed to install interrupt handler.");
> + "Failed to install interrupt
> handler.\n");
> return -1;
> }
> }
> @@ -1191,7 +1191,7 @@ eth_dev_start(struct rte_eth_dev *eth_dev)
> if (dev_conf->intr_conf.rxq) {
> if (eth_vhost_install_intr(eth_dev) < 0) {
> VHOST_LOG(INFO,
> - "Failed to install interrupt handler.");
> + "Failed to install interrupt
> handler.\n");
> return -1;
> }
> }
> --
> 2.39.2
Reviewed-by: Chenbo Xia <chenbo....@intel.com>
