Re: release candidate 23.03-rc1

2023-03-02 Thread David Marchand
On Wed, Mar 1, 2023 at 12:16 PM David Marchand wrote: > > On Wed, Mar 1, 2023 at 9:26 AM David Marchand > wrote: > > > > On Wed, Mar 1, 2023 at 8:38 AM Jiang, YuX wrote: > > > > -Original Message- > > > > From: Jiang, YuX > > > > Sent: Thursday, February 23, 2023 4:39 PM > > > > To: Tho

RE: [PATCH] net/ixgbe: fix IPv6 mask in fdir

2023-03-02 Thread Jiale, SongX
> -Original Message- > From: Kaiwen Deng > Sent: Friday, March 3, 2023 12:52 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Yang, Qiming ; Zhou, YidingX > ; Deng, KaiwenX ; Wu, > Wenjun1 ; Zhang, Qi Z ; Lu, > Wenzhuo > Subject: [PATCH] net/ixgbe: fix IPv6 mask in fdir > > Rules without add

RE: [PATCH 2/3] examples/l3fwd: removed hash entry number

2023-03-02 Thread Ruifeng Wang
> -Original Message- > From: Kamalakshitha Aligeri > Sent: Tuesday, November 15, 2022 5:26 AM > To: jer...@marvell.com; tho...@monjalon.net; david.march...@redhat.com > Cc: dev@dpdk.org; nd ; Kamalakshitha Aligeri > ; > Honnappa Nagarahalli > Subject: [PATCH 2/3] examples/l3fwd: removed

RE: [PATCH v4 12/12] app/mldev: add documentation for mldev test cases

2023-03-02 Thread Anup Prabhu
> -Original Message- > From: Srikanth Yalavarthi > Sent: Tuesday, February 7, 2023 9:20 PM > To: Thomas Monjalon ; Srikanth Yalavarthi > > Cc: dev@dpdk.org; Shivah Shankar Shankar Narayan Rao > ; Jerin Jacob Kollanukkaran > ; Anup Prabhu ; Prince Takkar > ; Parijat Shukla > Subject: [P

RE: [PATCH] vhost: fix vring enable with VDPA

2023-03-02 Thread Xia, Chenbo
> -Original Message- > From: David Marchand > Sent: Thursday, March 2, 2023 5:48 PM > To: dev@dpdk.org > Cc: ssi...@nvidia.com; yaj...@nvidia.com; Maxime Coquelin > ; Xia, Chenbo ; Morten > Brørup > Subject: [PATCH] vhost: fix vring enable with VDPA > > For VDPA devices, vq are not locke

[PATCH] net/ixgbe: fix IPv6 mask in fdir

2023-03-02 Thread Kaiwen Deng
Rules without addr mask cannot be created together in ixgbe when setting IPv6 addr mask to default value as 0. This commit is to change the default value of IPv6 addr mask as '0xFF'. Fixes: cba954b7beda ("net/ixgbe: enable IPv6 mask in flow rules") Fixes: 7d629cacedee ("net/ixgbe: enable IPv6 for

Re: [PATCH v2 00/17] use __atomic operations returning previous value

2023-03-02 Thread fengchengwen
On 2023/3/3 0:18, Tyler Retzlaff wrote: > This series replaces uses of __atomic_{add,and,or,sub,xor}_fetch with > __atomic_fetch_{add,and,or,sub,xor} intrinsics. The latter omits generation > of code that is only needed if the returned value is actually used. > > Additionally, this change simp

RE: [PATCH] net/mana: use RTE_LOG_DP for logs on datapath

2023-03-02 Thread Long Li
> Subject: Re: [PATCH] net/mana: use RTE_LOG_DP for logs on datapath > > On Thu, 23 Feb 2023 10:09:17 -0800 > Stephen Hemminger wrote: > > > On Thu, 23 Feb 2023 14:07:25 + > > Ferruh Yigit wrote: > > > > > Overall I am not sure if anyone is interested in driver datapath > > > logs other tha

[PATCH] net/mana: use trace points for data path logs

2023-03-02 Thread longli
From: Long Li Change all the logging statements on the data path to use trace points to reduce CPU overhead when fast path tracing is not enabled. Fixes: 517ed6e2d5 ("net/mana: add basic driver with build environment") Cc: sta...@dpdk.org Signed-off-by: Long Li --- drivers/net/mana/gdma.c

Re: [PATCH 4/5] net/bnxt: use fp ops setup function

2023-03-02 Thread fengchengwen
On 2023/3/3 8:01, Konstantin Ananyev wrote: > 02/03/2023 12:30, Konstantin Ananyev пишет: >> >>> Use rte_eth_fp_ops_setup() instead of directly manipulating >>> rte_eth_fp_ops variable. >>> >>> Cc: sta...@dpdk.org >>> >>> Signed-off-by: Chengwen Feng >>> --- >>>   drivers/net/bnxt/bnxt_cpr.c    |

RE: [PATCH v2 00/17] use __atomic operations returning previous value

2023-03-02 Thread Ruifeng Wang
> -Original Message- > From: Tyler Retzlaff > Sent: Friday, March 3, 2023 12:18 AM > To: dev@dpdk.org > Cc: Honnappa Nagarahalli ; tho...@monjalon.net; > bruce.richard...@intel.com; m...@smartsharesystems.com; Ruifeng Wang > ; > maxime.coque...@redhat.com; Tyler Retzlaff > Subject: [PATC

Re: [PATCH 5/5] app/testpmd: add error recovery usage demo

2023-03-02 Thread fengchengwen
On 2023/3/2 21:01, Konstantin Ananyev wrote: > > >> >> This patch adds error recovery usage demo which will: >> 1. stop packet forwarding when the RTE_ETH_EVENT_ERR_RECOVERING event >>is received. >> 2. restart packet forwarding when the RTE_ETH_EVENT_RECOVERY_SUCCESS >>event is received.

Re: [PATCH 4/5] net/bnxt: use fp ops setup function

2023-03-02 Thread fengchengwen
On 2023/3/2 20:30, Konstantin Ananyev wrote: > >> Use rte_eth_fp_ops_setup() instead of directly manipulating >> rte_eth_fp_ops variable. >> >> Cc: sta...@dpdk.org >> >> Signed-off-by: Chengwen Feng >> --- >> drivers/net/bnxt/bnxt_cpr.c| 5 + >> drivers/net/bnxt/bnxt_ethdev.c | 5 + >

Re: [PATCH 4/5] net/bnxt: use fp ops setup function

2023-03-02 Thread Ajit Khaparde
On Thu, Mar 2, 2023 at 4:01 PM Konstantin Ananyev wrote: > > 02/03/2023 12:30, Konstantin Ananyev пишет: > > > >> Use rte_eth_fp_ops_setup() instead of directly manipulating > >> rte_eth_fp_ops variable. > >> > >> Cc: sta...@dpdk.org > >> > >> Signed-off-by: Chengwen Feng > >> --- > >> drivers/

Re: [PATCH 1/5] ethdev: fix race-condition of proactive error handling mode

2023-03-02 Thread Konstantin Ananyev
-Original Message- From: Chengwen Feng Sent: Tuesday, February 28, 2023 9:06 PM To: tho...@monjalon.net; ferruh.yi...@amd.com; konstantin.anan...@huawei.com; Andrew Rybchenko ; Kalesh AP ; Ajit Khaparde (ajit.khapa...@broadcom.com) Cc: dev@dpdk.org Subject: [PATCH 1/5] ethdev: fix

Re: [PATCH 4/5] net/bnxt: use fp ops setup function

2023-03-02 Thread Konstantin Ananyev
02/03/2023 12:30, Konstantin Ananyev пишет: Use rte_eth_fp_ops_setup() instead of directly manipulating rte_eth_fp_ops variable. Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng --- drivers/net/bnxt/bnxt_cpr.c| 5 + drivers/net/bnxt/bnxt_ethdev.c | 5 + 2 files changed, 2 ins

RE: [PATCH 1/5] ethdev: fix race-condition of proactive error handling mode

2023-03-02 Thread Honnappa Nagarahalli
> -Original Message- > From: Chengwen Feng > Sent: Tuesday, February 28, 2023 9:06 PM > To: tho...@monjalon.net; ferruh.yi...@amd.com; > konstantin.anan...@huawei.com; Andrew Rybchenko > ; Kalesh AP anakkur.pura...@broadcom.com>; Ajit Khaparde > (ajit.khapa...@broadcom.com) > Cc: dev@

RE: [PATCH v10 2/2] net/i40e: replace put function

2023-03-02 Thread Kamalakshitha Aligeri
Hi all, This patch shows a couple of failures in patchwork. I checked it and it is not related to the patch. It shows as service_autotest failure. Anybody know how to fix this? > -Original Message- > From: Kamalakshitha Aligeri > Sent: Friday, February 24, 2023 10:11 AM > To: yuying.zh.

Re: [RFC 1/2] eal: add bitset type

2023-03-02 Thread Tyler Retzlaff
On Thu, Mar 02, 2023 at 06:31:40AM +, Mattias Rönnblom wrote: > On 2023-02-28 19:46, Tyler Retzlaff wrote: > > On Tue, Feb 28, 2023 at 10:39:15AM +0100, Mattias Rönnblom wrote: > >> Introduce a set of functions and macros that operate on sets of bits, > >> kept in arrays of 64-bit elements. > >

[PATCH v3 16/17] test/bbdev: remove max iteration from vectors

2023-03-02 Thread Hernan Vargas
Remove iter_max from test vectors as this value is passed as an argument to the test. No functional impact. Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- app/test-bbdev/test_bbdev_perf.c | 4 app/test-bbdev/test_bbdev_vector.c | 14 ---

[PATCH v3 17/17] test/bbdev: remove iter count from bler test

2023-03-02 Thread Hernan Vargas
iter_count doesn't need to be set equal to iter_max for bler tests. This is only needed in throughput and latency tests because early termination is disabled for those tests. Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- app/test-bbdev/test_bbdev_perf.c | 16 ++-- 1

[PATCH v3 15/17] test/bbdev: use mbuf reset function

2023-03-02 Thread Hernan Vargas
Use mbuf_reset function for code consistency. No functional impact. Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- app/test-bbdev/test_bbdev_perf.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev

[PATCH v3 14/17] test/bbdev: remove iteration count check

2023-03-02 Thread Hernan Vargas
To make the test compatible with devices that do not support early termination, the iteration count assert can be removed. Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- app/test-bbdev/test_bbdev_perf.c | 24 1 file changed, 8 insertions(+), 16 deletions(

[PATCH v3 13/17] test/bbdev: expose warning counters

2023-03-02 Thread Hernan Vargas
Print warnings reported on queues for offload test. No functional impact. Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- app/test-bbdev/test_bbdev_perf.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c ind

[PATCH v3 12/17] test/bbdev: adjustment for soft output

2023-03-02 Thread Hernan Vargas
Extend test-bbdev for soft output check, notably due to the logic in test-bbdev to enable termination changing. Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- app/test-bbdev/test_bbdev_perf.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff

[PATCH v3 10/17] test/bbdev: add support for BLER for 4G

2023-03-02 Thread Hernan Vargas
New feature to add BLER support for 4G in test-bbdev. Signed-off-by: Hernan Vargas --- app/test-bbdev/test_bbdev_perf.c | 195 ++- 1 file changed, 194 insertions(+), 1 deletion(-) diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c index

[PATCH v3 11/17] test/bbdev: extend support for large TB

2023-03-02 Thread Hernan Vargas
Add support for large TB when it cannot fit into a true mbuf. Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- app/test-bbdev/test_bbdev_perf.c | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbd

[PATCH v3 09/17] test/bbdev: add timeout for enq/deq loops

2023-03-02 Thread Hernan Vargas
Added timeout to prevent infinite loop condition if the device doesn't enqueue/dequeue. Signed-off-by: Hernan Vargas --- app/test-bbdev/test_bbdev_perf.c | 133 ++- 1 file changed, 113 insertions(+), 20 deletions(-) diff --git a/app/test-bbdev/test_bbdev_perf.c b/app

[PATCH v3 07/17] test/bbdev: report device status in test-bbdev

2023-03-02 Thread Hernan Vargas
No functional impact. Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- app/test-bbdev/test_bbdev_perf.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c index 396473961ad1..546fc195aac4 100644 --- a/app/test-b

[PATCH v3 08/17] test/bbdev: test start/stop bbdev API

2023-03-02 Thread Hernan Vargas
Add a call to queue start and queue stop specifically for testing the bbdev API. Signed-off-by: Hernan Vargas --- app/test-bbdev/test_bbdev_perf.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev

[PATCH v3 06/17] test/bbdev: enable early termination for validation

2023-03-02 Thread Hernan Vargas
Enhancement to enable early termination for validation tests if the device supports it. Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- app/test-bbdev/test_bbdev_perf.c | 30 +++--- 1 file changed, 19 insertions(+), 11 deletions(-) diff --git a/app/test-bb

[PATCH v3 05/17] test/bbdev: add timeout for latency tests

2023-03-02 Thread Hernan Vargas
Add a timeout to force exit the latency tests in case dequeue never happens. Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- app/test-bbdev/test_bbdev_perf.c | 24 +++- 1 file changed, 19 insertions(+), 5 deletions(-) diff --git a/app/test-bbdev/test_bbdev_per

[PATCH v3 03/17] test/bbdev: remove check for invalid opaque data

2023-03-02 Thread Hernan Vargas
Assert also if the opaque data is invalid. Fixes: 335c11fd276 ("app/bbdev: support HARQ validation") Cc: sta...@dpdk.org Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- app/test-bbdev/test_bbdev_perf.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/ap

[PATCH v3 04/17] test/bbdev: refactor TB throughput report

2023-03-02 Thread Hernan Vargas
Refactor calculation for tb_size. No functional impact. Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- app/test-bbdev/test_bbdev_perf.c | 38 ++-- 1 file changed, 16 insertions(+), 22 deletions(-) diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/te

[PATCH v3 02/17] test/bbdev: extend HARQ tolerance

2023-03-02 Thread Hernan Vargas
HARQ memory implementation could have different size assumptions. Extending HARQ tolerance to cover different implementations. Fixes: 335c11fd276 ("app/bbdev: support HARQ validation") Cc: sta...@dpdk.org Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- app/test-bbdev/test_bbdev_p

[PATCH v3 01/17] test/bbdev: fix seg fault for non supported HARQ len

2023-03-02 Thread Hernan Vargas
Fix segmentation fault happening in corner case in test-bbdev. This fault could happen when running some specific vectors which size are not supported by the PMD. Fixes: 335c11fd276 ("app/bbdev: support HARQ validation") Cc: sta...@dpdk.org Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquel

[PATCH v3 00/17] test/bbdev: changes for 23.03

2023-03-02 Thread Hernan Vargas
v3: Added new commit with enq/deq timeout implementaion. v2: Made changes requested during review. Added 3 commits. v1: Upstreaming bbdev-test changes for 23.03. Hernan Vargas (17): test/bbdev: fix seg fault for non supported HARQ len test/bbdev: extend HARQ tolerance test/bbdev: remove chec

[PATCH 1/2] eal: fix failure race and behavior of thread create

2023-03-02 Thread Tyler Retzlaff
In rte_thread_create setting affinity after pthread_create may fail. Such a failure should result in the entire rte_thread_create failing but doesn't. Additionally if there is a failure to set affinity a race exists where the creating thread will free ctx and depending on scheduling of the new thr

[PATCH 2/2] eal/windows: fix create thread failure behavior

2023-03-02 Thread Tyler Retzlaff
In rte_thread_create setting affinity after CreateThread may fail. Such a failure is reported but strands the newly created thread in a suspended state. Resolve the above issue by notifying the newly created thread that it should terminate as soon as it is resumed, while still continuing to free t

Re: [PATCH v3 3/3] net/mlx5: fix Windows build with MinGW GCC 12

2023-03-02 Thread Tyler Retzlaff
On Thu, Mar 02, 2023 at 02:21:50PM +0100, Thomas Monjalon wrote: > With recent changes in Meson and MinGW toolchain, > the driver mlx5 was not able to compile on Linux for Windows. > > There were errors due to system detection, non-typed constants, > constant going over int range forbidden in peda

Re: [PATCH v3 2/3] net/mlx5: remove weak stub functions

2023-03-02 Thread Tyler Retzlaff
On Thu, Mar 02, 2023 at 02:21:49PM +0100, Thomas Monjalon wrote: > The vector Rx functions are conditionally compiled. > Some stub functions were also always compiled with weak attribute. > If there is no vector support, the weak functions were linked. > > These weak functions are moved in a speci

Re: [PATCH v3 1/3] common/mlx5: get Windows dependency from standard variables

2023-03-02 Thread Tyler Retzlaff
On Thu, Mar 02, 2023 at 02:21:48PM +0100, Thomas Monjalon wrote: > The DevX library path had to be provided through the variables > DEVX_INC_PATH and DEVX_LIB_PATH. > It was non-standard and triggers some issues with recent Meson. is it possible for meson to search the default install location tha

Re: [PATCH v1 2/2] net/octeon_ep: support port kind

2023-03-02 Thread Jerin Jacob
On Tue, Feb 21, 2023 at 8:07 PM Sathesh Edara wrote: > > Added port kind functionality. > > Signed-off-by: Sathesh Edara Series applied to dpdk-next-net-mrvl/for-next-net. Thanks > --- > drivers/net/octeon_ep/otx_ep_common.h | 1 + > drivers/net/octeon_ep/otx_ep_ethdev.c | 2 +- > drivers/n

RE: [EXT] Re: [PATCH v1 1/2] ethdev: fix null pointer dereference

2023-03-02 Thread Ankur Dwivedi
>On 2/28/2023 4:27 PM, Ferruh Yigit wrote: >> On 2/28/2023 3:40 PM, Ankur Dwivedi wrote: -- On 2/23/2023 12:30 PM, Ankur Dwivedi wrote: > The speed_fec_capa pointer can be null. So dereferencing the > pointer is

[PATCH v2 15/17] drivers/common: use previous value atomic fetch operations

2023-03-02 Thread Tyler Retzlaff
Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch when we have no interest in the result of the operation. Reduces unnecessary codegen that provided the result of the atomic operation that was not used. Change brings closer alignment with atomics available in

[PATCH v2 16/17] app/test: use previous value atomic fetch operations

2023-03-02 Thread Tyler Retzlaff
Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch when we have no interest in the result of the operation. Reduces unnecessary codegen that provided the result of the atomic operation that was not used. Change brings closer alignment with atomics available in

[PATCH v2 13/17] drivers/event: use previous value atomic fetch operations

2023-03-02 Thread Tyler Retzlaff
Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch when we have no interest in the result of the operation. Reduces unnecessary codegen that provided the result of the atomic operation that was not used. Change brings closer alignment with atomics available in

[PATCH v2 17/17] test-eventdev: use previous value atomic fetch operations

2023-03-02 Thread Tyler Retzlaff
Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch when we have no interest in the result of the operation. Reduces unnecessary codegen that provided the result of the atomic operation that was not used. Change brings closer alignment with atomics available in

[PATCH v2 14/17] dma/skeleton: use previous value atomic fetch operations

2023-03-02 Thread Tyler Retzlaff
Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch when we have no interest in the result of the operation. Reduces unnecessary codegen that provided the result of the atomic operation that was not used. Change brings closer alignment with atomics available in

[PATCH v2 06/17] bbdev: use previous value atomic fetch operations

2023-03-02 Thread Tyler Retzlaff
Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch when we have no interest in the result of the operation. Reduces unnecessary codegen that provided the result of the atomic operation that was not used. Change brings closer alignment with atomics available in

[PATCH v2 08/17] net/virtio: use previous value atomic fetch operations

2023-03-02 Thread Tyler Retzlaff
Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch when we have no interest in the result of the operation. Reduces unnecessary codegen that provided the result of the atomic operation that was not used. Change brings closer alignment with atomics available in

[PATCH v2 10/17] net/mlx5: use previous value atomic fetch operations

2023-03-02 Thread Tyler Retzlaff
Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch when we have no interest in the result of the operation. Reduces unnecessary codegen that provided the result of the atomic operation that was not used. Change brings closer alignment with atomics available in

[PATCH v2 09/17] net/octeontx: use previous value atomic fetch operations

2023-03-02 Thread Tyler Retzlaff
Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch when we have no interest in the result of the operation. Reduces unnecessary codegen that provided the result of the atomic operation that was not used. Change brings closer alignment with atomics available in

[PATCH v2 12/17] net/cxgbe: use previous value atomic fetch operations

2023-03-02 Thread Tyler Retzlaff
Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch when we have no interest in the result of the operation. Reduces unnecessary codegen that provided the result of the atomic operation that was not used. Change brings closer alignment with atomics available in

[PATCH v2 11/17] net/iavf: use previous value atomic fetch operations

2023-03-02 Thread Tyler Retzlaff
Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch when we have no interest in the result of the operation. Reduces unnecessary codegen that provided the result of the atomic operation that was not used. Change brings closer alignment with atomics available in

[PATCH v2 07/17] examples/vhost: use previous value atomic fetch operations

2023-03-02 Thread Tyler Retzlaff
Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch when we have no interest in the result of the operation. Reduces unnecessary codegen that provided the result of the atomic operation that was not used. Change brings closer alignment with atomics available in

[PATCH v2 04/17] eal: use previous value atomic fetch operations

2023-03-02 Thread Tyler Retzlaff
Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch when we have no interest in the result of the operation. Reduces unnecessary codegen that provided the result of the atomic operation that was not used. Change brings closer alignment with atomics available in

[PATCH v2 05/17] distributor: use previous value atomic fetch operations

2023-03-02 Thread Tyler Retzlaff
Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch when we have no interest in the result of the operation. Reduces unnecessary codegen that provided the result of the atomic operation that was not used. Change brings closer alignment with atomics available in

[PATCH v2 03/17] stack: use previous value atomic fetch operations

2023-03-02 Thread Tyler Retzlaff
Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch when we have no interest in the result of the operation. Reduces unnecessary codegen that provided the result of the atomic operation that was not used. Change brings closer alignment with atomics available in

[PATCH v2 00/17] use __atomic operations returning previous value

2023-03-02 Thread Tyler Retzlaff
This series replaces uses of __atomic_{add,and,or,sub,xor}_fetch with __atomic_fetch_{add,and,or,sub,xor} intrinsics. The latter omits generation of code that is only needed if the returned value is actually used. Additionally, this change simplifies adapting dpdk to standard atomics planned for

[PATCH v2 02/17] telemetry: use previous value atomic fetch operations

2023-03-02 Thread Tyler Retzlaff
Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch when we have no interest in the result of the operation. Reduces unnecessary codegen that provided the result of the atomic operation that was not used. Change brings closer alignment with atomics available in

[PATCH v2 01/17] vhost: use previous value atomic fetch operations

2023-03-02 Thread Tyler Retzlaff
Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch when we have no interest in the result of the operation. Reduces unnecessary codegen that provided the result of the atomic operation that was not used. Change brings closer alignment with atomics available in

RE: [EXT] [PATCH] drivers: skip build of sub-libs not supporting IOVA mode

2023-03-02 Thread Shijith Thotton
>If IOVA as PA is disabled and the driver does not support IOVA as VA, >the build of the driver was disabled. >Unfortunately some drivers were building some sub-libraries >(with specific options for vector paths) which were not disabled. > >The build parsing of those drivers need to be skipped earl

Re: [PATCH 11/17] net/iavf: use previous value atomic fetch operations

2023-03-02 Thread Tyler Retzlaff
On Thu, Mar 02, 2023 at 09:28:09AM +, Ruifeng Wang wrote: > > -Original Message- > > From: Tyler Retzlaff > > Sent: Thursday, March 2, 2023 8:48 AM > > To: dev@dpdk.org > > Cc: Honnappa Nagarahalli ; > > tho...@monjalon.net; Tyler > > Retzlaff > > Subject: [PATCH 11/17] net/iavf: use

Re: [PATCH] ethdev: remove telemetry Rx mbuf alloc failed field

2023-03-02 Thread Ferruh Yigit
On 3/1/2023 2:08 PM, Andrew Rybchenko wrote: > On 3/1/23 14:37, Thomas Monjalon wrote: >> 28/02/2023 19:02, Ferruh Yigit: >>> 'eth_dev->data->rx_mbuf_alloc_failed' field is not directly exposed to >>> user via ethdev APIs but it is used internally to set "stats->rx_nombuf' >>> which is exposed via

Re: [PATCH v9 00/21] add support for cpfl PMD in DPDK

2023-03-02 Thread Ferruh Yigit
On 3/2/2023 9:20 PM, Mingxia Liu wrote: > The patchset introduced the cpfl (Control Plane Function Library) PMD > for Intel® IPU E2100’s Configure Physical Function (Device ID: 0x1453) > > The cpfl PMD inherits all the features from idpf PMD which will follow > an ongoing standard data plan functi

Re: [PATCH 08/17] net/virtio: use previous value atomic fetch operations

2023-03-02 Thread Maxime Coquelin
On 3/2/23 01:47, Tyler Retzlaff wrote: Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch when we have no interest in the result of the operation. Reduces unnecessary codegen that provided the result of the atomic operation that was not used. Change brings

Re: [PATCH 07/17] examples/vhost: use previous value atomic fetch operations

2023-03-02 Thread Maxime Coquelin
On 3/2/23 01:47, Tyler Retzlaff wrote: Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch when we have no interest in the result of the operation. Reduces unnecessary codegen that provided the result of the atomic operation that was not used. Change brings

Re: [PATCH 01/17] vhost: use previous value atomic fetch operations

2023-03-02 Thread Maxime Coquelin
On 3/2/23 01:47, Tyler Retzlaff wrote: Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch when we have no interest in the result of the operation. Reduces unnecessary codegen that provided the result of the atomic operation that was not used. Change brings

Re: [PATCH v3] net/idpf: refine Rx/Tx queue model info

2023-03-02 Thread Ferruh Yigit
On 3/2/2023 7:51 PM, Mingxia Liu wrote: > This patch updates queue mode info in struct idpf_adapter. > Using is_rx_singleq_model to diffentiate rx_singq and rx_splitq > explicitly, instead of deducing it from pointer values. > > Signed-off-by: Mingxia Liu Moving ack from previous version: Acked-

RE: [PATCH 00/17] use __atomic operations returning previous value

2023-03-02 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Thursday, 2 March 2023 01.48 > To: dev@dpdk.org > Cc: honnappa.nagaraha...@arm.com; tho...@monjalon.net; Tyler Retzlaff > Subject: [PATCH 00/17] use __atomic operations returning previous value > > This series replaces uses of __

RE: [PATCH] drivers: skip build of sub-libs not supporting IOVA mode

2023-03-02 Thread Zhang, Qi Z
> -Original Message- > From: Thomas Monjalon > Sent: Thursday, March 2, 2023 9:58 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org; David Marchand ; > Richardson, Bruce ; sta...@dpdk.org; Wu, > Jingjing ; Xing, Beilei ; > McDaniel, Timothy ; Ajit Khaparde > ; Somnath Kotur > ; Daley, John ; > H

RE: [PATCH] drivers: skip build of sub-libs not supporting IOVA mode

2023-03-02 Thread Morten Brørup
> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Sunday, 19 February 2023 12.55 > > If IOVA as PA is disabled and the driver does not support IOVA as VA, > the build of the driver was disabled. > Unfortunately some drivers were building some sub-libraries > (with specific options for v

Re: [PATCH v1 04/13] graph: add get/set graph worker model APIs

2023-03-02 Thread Jerin Jacob
On Thu, Mar 2, 2023 at 2:09 PM Yan, Zhirun wrote: > > > > > -Original Message- > > From: Jerin Jacob > > Sent: Monday, February 27, 2023 6:23 AM > > To: Yan, Zhirun > > Cc: dev@dpdk.org; jer...@marvell.com; kirankum...@marvell.com; > > ndabilpu...@marvell.com; Liang, Cunming ; > > Wang,

Re: [PATCH] drivers: skip build of sub-libs not supporting IOVA mode

2023-03-02 Thread Thomas Monjalon
02/03/2023 14:52, Zhang, Qi Z: > From: Thomas Monjalon > > If IOVA as PA is disabled and the driver does not support IOVA as VA, the > > build of the driver was disabled. > > Unfortunately some drivers were building some sub-libraries (with specific > > options for vector paths) which were not dis

RE: [PATCH] drivers: skip build of sub-libs not supporting IOVA mode

2023-03-02 Thread Zhang, Qi Z
> -Original Message- > From: Thomas Monjalon > Sent: Sunday, February 19, 2023 7:55 PM > To: dev@dpdk.org > Cc: David Marchand ; Richardson, Bruce > ; Zhang, Qi Z ; > sta...@dpdk.org; Wu, Jingjing ; Xing, Beilei > ; McDaniel, Timothy ; > Ajit Khaparde ; Somnath Kotur > ; Daley, John ; >

[PATCH] net/ice: fix incorrect Rx timestamp for E822

2023-03-02 Thread Simei Su
The Rx timestamp is 0 due to the missing PHY clock timer setup for E822. Also, the source clock index in use is based on device capabilities instead of always being zero. Fixes: 953e74e6b73a ("net/ice: enable Rx timestamp on flex descriptor") Fixes: 646dcbe6c701 ("net/ice: support IEEE 1588 PTP")

Re: [PATCH v2] net: not build PMD AVX library when no IOVA as PA

2023-03-02 Thread Thomas Monjalon
19/02/2023 13:01, Thomas Monjalon: > 19/02/2023 12:08, Thomas Monjalon: > > 19/02/2023 11:04, Thomas Monjalon: > > > 29/01/2023 13:35, Zhang, Qi Z: > > > > From: Zhang, Qi Z > > > > > > > > > > PMD not announce pmd_supports_disable_iova_as_pa will not be build > > > > > when RTE_IOVA_AS_PA is not

[PATCH v3 3/3] net/mlx5: fix Windows build with MinGW GCC 12

2023-03-02 Thread Thomas Monjalon
With recent changes in Meson and MinGW toolchain, the driver mlx5 was not able to compile on Linux for Windows. There were errors due to system detection, non-typed constants, constant going over int range forbidden in pedantic mode, and minimum-comparison of different types. Cc: sta...@dpdk.org

[PATCH v3 2/3] net/mlx5: remove weak stub functions

2023-03-02 Thread Thomas Monjalon
The vector Rx functions are conditionally compiled. Some stub functions were also always compiled with weak attribute. If there is no vector support, the weak functions were linked. These weak functions are moved in a specific file which is compiled only if there is no vector support. This way it

[PATCH v3 1/3] common/mlx5: get Windows dependency from standard variables

2023-03-02 Thread Thomas Monjalon
The DevX library path had to be provided through the variables DEVX_INC_PATH and DEVX_LIB_PATH. It was non-standard and triggers some issues with recent Meson. Using CFLAGS/LDFLAGS is standard and simpler. It is also possible to use the Meson options -Dc_args and -Dc_link_args. There are 2 options

[PATCH v3 0/3] mlx5: fix Windows build with Linux MinGW

2023-03-02 Thread Thomas Monjalon
The result is to make possible to compile mlx5 on Linux for Windows. v2: improve mlx5 doc and remove weak attribute from mlx5 v3: avoid MinGW on Windows - EAL patch already applied Thomas Monjalon (3): common/mlx5: get Windows dependency from standard variables net/mlx5: remove weak stub fun

RE: [PATCH v8 01/21] net/cpfl: support device initialization

2023-03-02 Thread Liu, Mingxia
> -Original Message- > From: Ferruh Yigit > Sent: Thursday, March 2, 2023 7:51 PM > To: Liu, Mingxia ; dev@dpdk.org; Xing, Beilei > ; Zhang, Yuying > Subject: Re: [PATCH v8 01/21] net/cpfl: support device initialization > > On 3/2/2023 11:24 AM, Liu, Mingxia wrote: > > > > > >> -Or

[PATCH v9 21/21] net/cpfl: add xstats ops

2023-03-02 Thread Mingxia Liu
Add support for these device ops: - dev_xstats_get - dev_xstats_get_names - dev_xstats_reset Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 79 ++ 1 file changed, 79 insertions(+) diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpf

[PATCH v9 20/21] net/cpfl: support scalar scatter Rx datapath for single queue model

2023-03-02 Thread Mingxia Liu
This patch add single q recv scatter Rx function. Signed-off-by: Wenjun Wu Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 3 ++- drivers/net/cpfl/cpfl_rxtx.c | 27 +++ drivers/net/cpfl/cpfl_rxtx.h | 2 ++ 3 files changed, 31 insertions(+), 1 deleti

[PATCH v9 15/21] net/cpfl: add AVX512 data path for single queue model

2023-03-02 Thread Mingxia Liu
Add support of AVX512 vector data path for single queue model. Signed-off-by: Wenjun Wu Signed-off-by: Mingxia Liu --- doc/guides/nics/cpfl.rst| 24 +- drivers/net/cpfl/cpfl_ethdev.c | 3 +- drivers/net/cpfl/cpfl_rxtx.c| 93 ++ dr

[PATCH v9 19/21] net/cpfl: add RSS set/get ops

2023-03-02 Thread Mingxia Liu
Add support for these device ops: - rss_reta_update - rss_reta_query - rss_hash_update - rss_hash_conf_get Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 271 - 1 file changed, 270 insertions(+), 1 deletion(-) diff --git a/drivers/net/cpfl/cpfl_e

[PATCH v9 18/21] net/cpfl: add HW statistics

2023-03-02 Thread Mingxia Liu
This patch add hardware packets/bytes statistics. Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 87 ++ 1 file changed, 87 insertions(+) diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl_ethdev.c index ae716d104c..4970020139 100

[PATCH v9 17/21] net/cpfl: add AVX512 data path for split queue model

2023-03-02 Thread Mingxia Liu
Add support of AVX512 data path for split queue model. Signed-off-by: Wenjun Wu Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_rxtx.c| 56 +++-- drivers/net/cpfl/cpfl_rxtx_vec_common.h | 20 - drivers/net/cpfl/meson.build| 6 ++- 3 file

[PATCH v9 16/21] net/cpfl: support timestamp offload

2023-03-02 Thread Mingxia Liu
Add support for timestamp offload. Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 3 ++- drivers/net/cpfl/cpfl_rxtx.c | 7 +++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl_ethdev.c index e64cadfd38..ae

[PATCH v9 14/21] net/cpfl: support Tx offloading

2023-03-02 Thread Mingxia Liu
Add Tx offloading support: - support TSO for single queue model and split queue model. Signed-off-by: Mingxia Liu --- doc/guides/nics/features/cpfl.ini | 1 + drivers/net/cpfl/cpfl_ethdev.c| 8 +++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/doc/guides/nics/features/c

[PATCH v9 13/21] net/cpfl: support Rx offloading

2023-03-02 Thread Mingxia Liu
Add Rx offloading support: - support CHKSUM and RSS offload for split queue model - support CHKSUM offload for single queue model Signed-off-by: Mingxia Liu --- doc/guides/nics/features/cpfl.ini | 2 ++ drivers/net/cpfl/cpfl_ethdev.c| 6 ++ 2 files changed, 8 insertions(+) diff --git

[PATCH v9 12/21] net/cpfl: support RSS

2023-03-02 Thread Mingxia Liu
Add RSS support. Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 60 ++ drivers/net/cpfl/cpfl_ethdev.h | 15 + 2 files changed, 75 insertions(+) diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl_ethdev.c index ef40ae08df.

[PATCH v9 11/21] net/cpfl: support write back based on ITR expire

2023-03-02 Thread Mingxia Liu
ITR is the interval between two interrupts, it can be understood as a timer here. WB_ON_ITR(write back on ITR expire) is used for receiving packets without interrupts or full cache line, then packets can be received one by one. To enable WB_ON_ITR, need to enable some interrupt with 'idpf_vport_ir

[PATCH v9 10/21] net/cpfl: support basic Tx data path

2023-03-02 Thread Mingxia Liu
Add basic Tx support in split queue mode and single queue mode. Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 3 +++ drivers/net/cpfl/cpfl_rxtx.c | 20 drivers/net/cpfl/cpfl_rxtx.h | 1 + 3 files changed, 24 insertions(+) diff --git a/drivers/net/cpf

[PATCH v9 09/21] net/cpfl: support basic Rx data path

2023-03-02 Thread Mingxia Liu
Add basic Rx support in split queue mode and single queue mode. Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 2 ++ drivers/net/cpfl/cpfl_rxtx.c | 18 ++ drivers/net/cpfl/cpfl_rxtx.h | 1 + 3 files changed, 21 insertions(+) diff --git a/drivers/net/cpfl/c

[PATCH v9 08/21] net/cpfl: support MTU configuration

2023-03-02 Thread Mingxia Liu
Add dev ops mtu_set. Signed-off-by: Mingxia Liu --- doc/guides/nics/features/cpfl.ini | 1 + drivers/net/cpfl/cpfl_ethdev.c| 27 +++ 2 files changed, 28 insertions(+) diff --git a/doc/guides/nics/features/cpfl.ini b/doc/guides/nics/features/cpfl.ini index a2d1ca9e1

[PATCH v9 07/21] net/cpfl: support queue release

2023-03-02 Thread Mingxia Liu
Add support for queue operations: - rx_queue_release - tx_queue_release Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 2 ++ drivers/net/cpfl/cpfl_rxtx.c | 24 drivers/net/cpfl/cpfl_rxtx.h | 2 ++ 3 files changed, 28 insertions(+) diff --git a/d

[PATCH v9 06/21] net/cpfl: support queue stop

2023-03-02 Thread Mingxia Liu
Add support for these device ops: - rx_queue_stop - tx_queue_stop Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 10 +++- drivers/net/cpfl/cpfl_rxtx.c | 98 ++ drivers/net/cpfl/cpfl_rxtx.h | 3 ++ 3 files changed, 110 insertions(+), 1 delet

[PATCH v9 05/21] net/cpfl: support queue start

2023-03-02 Thread Mingxia Liu
Add support for these device ops: - rx_queue_start - tx_queue_start Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 41 ++ drivers/net/cpfl/cpfl_rxtx.c | 138 + drivers/net/cpfl/cpfl_rxtx.h | 4 + 3 files changed, 183 insertions(+)

  1   2   >