On 3/1/2023 2:08 PM, Andrew Rybchenko wrote:
> On 3/1/23 14:37, Thomas Monjalon wrote:
>> 28/02/2023 19:02, Ferruh Yigit:
>>> 'eth_dev->data->rx_mbuf_alloc_failed' field is not directly exposed to
>>> user via ethdev APIs but it is used internally to set "stats->rx_nombuf'
>>> which is exposed via ehtdev stat APIs.
>>>
>>> But telemetry exposes this field to user via "/ethdev/info",
>>> instead user can get 'rx_nombuf' value from stats via "/ethdev/stats".
>>>
>>> Removing 'rx_mbuf_alloc_failed' from telemetry to align with ethdev APIs
>>>
>>> Fixes: 58b43c1ddfd1 ("ethdev: add telemetry endpoint for device info")
>>> Cc: sta...@dpdk.org
>>>
>>> Signed-off-by: Ferruh Yigit <ferruh.yi...@amd.com>
>>> ---
>>> - rte_tel_data_add_dict_uint(d, "rx_mbuf_alloc_fail",
>>> - eth_dev->data->rx_mbuf_alloc_failed);
>>
>> Good catch, thanks.
>>
>> Acked-by: Thomas Monjalon <tho...@monjalon.net>
>
> Acked-by: Andrew Rybchenko <andrew.rybche...@oktetlabs.ru>
>
>
Applied to dpdk-next-net/main, thanks.
