Hi all,
This patch shows a couple of failures in patchwork. I checked it and it is not
related to the patch.
It shows as service_autotest failure.
Anybody know how to fix this?
> -----Original Message-----
> From: Kamalakshitha Aligeri <kamalakshitha.alig...@arm.com>
> Sent: Friday, February 24, 2023 10:11 AM
> To: yuying.zh...@intel.com; beilei.x...@intel.com;
> olivier.m...@6wind.com; andrew.rybche...@oktetlabs.ru;
> bruce.richard...@intel.com; m...@smartsharesystems.com;
> konstantin.anan...@huawei.com; Honnappa Nagarahalli
> <honnappa.nagaraha...@arm.com>; Ruifeng Wang
> <ruifeng.w...@arm.com>; Feifei Wang <feifei.wa...@arm.com>
> Cc: dev@dpdk.org; nd <n...@arm.com>; Kamalakshitha Aligeri
> <kamalakshitha.alig...@arm.com>
> Subject: [PATCH v10 2/2] net/i40e: replace put function
>
> Integrated zero-copy put API in mempool cache in i40e PMD.
> On Ampere Altra server, l3fwd single core's performance improves by 5%
> with the new API
>
> Signed-off-by: Kamalakshitha Aligeri <kamalakshitha.alig...@arm.com>
> Reviewed-by: Ruifeng Wang <ruifeng.w...@arm.com>
> Reviewed-by: Feifei Wang <feifei.wa...@arm.com>
> Reviewed-by: Morten Brørup <m...@smartsharesystems.com>
> ---
> v3:
> Fixed the way mbufs are accessed from txep (Morten Brorup)
> v2:
> Fixed the code for n > RTE_MEMPOOL_CACHE_MAX_SIZE (Morten Brorup)
> v1:
> 1. Integrated the zc_put API in i40e PMD 2. Added mempool test cases with
> the zero-cpoy API's
>
> .mailmap | 1 +
> drivers/net/i40e/i40e_rxtx_vec_common.h | 27 ++++++++++++++++++++--
> ---
> 2 files changed, 23 insertions(+), 5 deletions(-)
>
> diff --git a/.mailmap b/.mailmap
> index a9f4f28fba..2581d0efe7 100644
> --- a/.mailmap
> +++ b/.mailmap
> @@ -677,6 +677,7 @@ Kai Ji <kai...@intel.com> Kaiwen Deng
> <kaiwenx.d...@intel.com> Kalesh AP <kalesh-
> anakkur.pura...@broadcom.com>
> Kamalakannan R <kamalakanna...@intel.com>
> +Kamalakshitha Aligeri <kamalakshitha.alig...@arm.com>
> Kamil Bednarczyk <kamil.bednarc...@intel.com> Kamil Chalupnik
> <kamilx.chalup...@intel.com> Kamil Rytarowski
> <kamil.rytarow...@caviumnetworks.com>
> diff --git a/drivers/net/i40e/i40e_rxtx_vec_common.h
> b/drivers/net/i40e/i40e_rxtx_vec_common.h
> index fe1a6ec75e..35cdb31b2e 100644
> --- a/drivers/net/i40e/i40e_rxtx_vec_common.h
> +++ b/drivers/net/i40e/i40e_rxtx_vec_common.h
> @@ -95,18 +95,35 @@ i40e_tx_free_bufs(struct i40e_tx_queue *txq)
>
> n = txq->tx_rs_thresh;
>
> - /* first buffer to free from S/W ring is at index
> - * tx_next_dd - (tx_rs_thresh-1)
> - */
> + /* first buffer to free from S/W ring is at index
> + * tx_next_dd - (tx_rs_thresh-1)
> + */
> txep = &txq->sw_ring[txq->tx_next_dd - (n - 1)];
>
> if (txq->offloads & RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE) {
> + struct rte_mempool *mp = txep[0].mbuf->pool;
> + struct rte_mempool_cache *cache =
> rte_mempool_default_cache(mp, rte_lcore_id());
> + void **cache_objs;
> +
> + if (unlikely(!cache))
> + goto fallback;
> +
> + cache_objs = rte_mempool_cache_zc_put_bulk(cache, mp,
> n);
> + if (unlikely(!cache_objs))
> + goto fallback;
> +
> for (i = 0; i < n; i++) {
> - free[i] = txep[i].mbuf;
> + cache_objs[i] = txep[i].mbuf;
> /* no need to reset txep[i].mbuf in vector path */
> }
> - rte_mempool_put_bulk(free[0]->pool, (void **)free, n);
> goto done;
> +
> +fallback:
> + for (i = 0; i < n; i++)
> + free[i] = txep[i].mbuf;
> + rte_mempool_generic_put(mp, (void **)free, n, cache);
> + goto done;
> +
> }
>
> m = rte_pktmbuf_prefree_seg(txep[0].mbuf);
> --
> 2.25.1
