Re: [PATCH v6 1/3] ethdev: skip congestion management configuration

2023-02-10 Thread Jerin Jacob
On Sat, Feb 11, 2023 at 6:05 AM Ferruh Yigit wrote: > > On 2/10/2023 8:26 AM, Rakesh Kudurumalla wrote: > > diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h > > index b60987db4b..f4eb4232d4 100644 > > --- a/lib/ethdev/rte_flow.h > > +++ b/lib/ethdev/rte_flow.h > > @@ -2203,6 +2203,17 @@

Re: [PATCH v3 2/2] doc: add Arkville FX2 PCIe device description

2023-02-10 Thread Shepard Siegel
Hi Ferruh, I don't think the submission system will allow your request of a single patch with both a code change and document change since they are in different directories. I must say I'm confused by your request. In the current v3 which is not your preference, we split up the new device into the

Re: [PATCH] mem: fix displaying heap ID failed for heap info command

2023-02-10 Thread lihuisong (C)
在 2023/2/9 11:23, fengchengwen 写道: Acked-by: Chengwen Feng And, how abort add error log in telemetry valid_name, so so that problems can be identified as early as possible. It might be better for adding an error log. What do you think, Bruce? On 2023/2/9 11:03, Huisong Li wrote: The telem

Re: [PATCH] mem: fix displaying heap ID failed for heap info command

2023-02-10 Thread lihuisong (C)
在 2023/2/9 16:48, David Marchand 写道: On Thu, Feb 9, 2023 at 4:24 AM fengchengwen wrote: Acked-by: Chengwen Feng And, how abort add error log in telemetry valid_name, so so that problems can be identified as early as possible. On 2023/2/9 11:03, Huisong Li wrote: The telemetry lib has adde

Re: [PATCH v3 2/2] doc: add Arkville FX2 PCIe device description

2023-02-10 Thread Ferruh Yigit
On 2/11/2023 1:26 AM, Shepard Siegel wrote: > Update net/ark guide for clarity. > Include list of FX0, FX1 and FX2 PCIe devices. > > Signed-off-by: Shepard Siegel > --- > doc/guides/nics/ark.rst | 20 > 1 file changed, 20 insertions(+) > > diff --git a/doc/guides/nics/ark.r

[RFC] eal: use same atomic intrinsics for gcc and clang

2023-02-10 Thread Honnappa Nagarahalli
The size generic atomic intrinsics generate the same code as the size specific intrinsics for gcc. Use size generic intrinsics for both gcc and clang. Fixes: 7bdccb93078e ("eal: fix ARM build with clang") Cc: sta...@dpdk.org Cc: pbhagavat...@marvell.com Signed-off-by: Honnappa Nagarahalli --- l

[PATCH v3 2/2] doc: add Arkville FX2 PCIe device description

2023-02-10 Thread Shepard Siegel
Update net/ark guide for clarity. Include list of FX0, FX1 and FX2 PCIe devices. Signed-off-by: Shepard Siegel --- doc/guides/nics/ark.rst | 20 1 file changed, 20 insertions(+) diff --git a/doc/guides/nics/ark.rst b/doc/guides/nics/ark.rst index ba00f14e80..39cd75064d 1006

[PATCH v3 1/2] net/ark: introduce Arkville FX2 PCIe device

2023-02-10 Thread Shepard Siegel
This commit introduces the Arkville FX2 PCIe device. Arkville FX2 provides support for PCIe Gen5x16 endpoints. FX2 is backwards-compatible with the net/ark PMD so that no changes other than the whitelist addition in this patch are needed for the basic operation of this device. Additional details ar

Re: [PATCH] net/nfp: fix length comparison for max DMA length

2023-02-10 Thread Ferruh Yigit
On 2/3/2023 2:23 AM, Chaoyong He wrote: > From: Richard Donkin > > The DMA transfer length is allowed to be as large as > NFDK_TX_MAX_DATA_PER_HEAD. The existing check would not allow a simple- > type descriptor to be created for a packet of size > NFDK_TX_MAX_DATA_PER_HEAD, but it would also not

Re: [PATCH v6 1/3] ethdev: skip congestion management configuration

2023-02-10 Thread Ferruh Yigit
On 2/10/2023 8:26 AM, Rakesh Kudurumalla wrote: > diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h > index b60987db4b..f4eb4232d4 100644 > --- a/lib/ethdev/rte_flow.h > +++ b/lib/ethdev/rte_flow.h > @@ -2203,6 +2203,17 @@ enum rte_flow_action_type { >*/ > RTE_FLOW_ACTION_TYP

Re: [PATCH v2] doc: update ark guide

2023-02-10 Thread Shepard Siegel
Thank you Ferruh, I understand now. We will abandon this patch and do exactly as you suggest with two separate patches. Thanks for your guidance. Look for the two patches ETA tomorrow. -Shep On Fri, Feb 10, 2023 at 5:56 PM Ferruh Yigit wrote: > On 2/10/2023 10:35 PM, Shepard Siegel wrote: > > Ad

Re: [RFC PATCH 0/1] Specify C-standard requirement for DPDK builds

2023-02-10 Thread Tyler Retzlaff
On Fri, Feb 10, 2023 at 09:52:06AM -0500, Ben Magistro wrote: > Adding Tyler > > Sort of following along on the RFC: introduce atomics [1] it seems like the > decision to use 99 vs 11 here could make an impact on the approach taken in > that thread. hey Ben thanks for keeping an eye across thread

Re: [PATCH v6 3/3] net/cnxk: skip red drop for ingress policer

2023-02-10 Thread Ferruh Yigit
On 2/10/2023 8:26 AM, Rakesh Kudurumalla wrote: > diff --git a/doc/guides/nics/features/cnxk.ini > b/doc/guides/nics/features/cnxk.ini > index f81628da77..afbb6dc8c9 100644 > --- a/doc/guides/nics/features/cnxk.ini > +++ b/doc/guides/nics/features/cnxk.ini > @@ -80,6 +80,7 @@ vxlan_gpe

Re: [PATCH v6 1/3] ethdev: skip congestion management configuration

2023-02-10 Thread Ferruh Yigit
On 2/10/2023 8:26 AM, Rakesh Kudurumalla wrote: > Introduce new flow action to skip congestion management configuration > This feature helps to skip the congestion management processing > based on per flow or the packet color identified by > rte_flow meter object. For example, If one Rx queue confi

Re: [PATCH v6 2/3] app/testpmd: add skip cman support for testpmd

2023-02-10 Thread Ferruh Yigit
On 2/10/2023 8:26 AM, Rakesh Kudurumalla wrote: > added support for testpmd application to accept > skip_cman action while configuring policy action > Can you please give some sample testpmd commands with new action in commit log, it helps. > Signed-off-by: Rakesh Kudurumalla > --- > app/test-

Re: [PATCH v3 0/3] *ethdev: sharing indirect actions between port*

2023-02-10 Thread Ferruh Yigit
On 2/10/2023 3:17 PM, Viacheslav Ovsiienko wrote: > The RTE Flow API implements the concept of shared objects, > known as indirect actions (RTE_FLOW_ACTION_TYPE_INDIRECT). > An application can create the indirect action of desired > type and configuration with rte_flow_action_handle_create > call a

Re: [PATCH v2] doc: update ark guide

2023-02-10 Thread Ferruh Yigit
On 2/10/2023 10:35 PM, Shepard Siegel wrote: > Add ark PCIe device 1d6c:1022 FX2 to pci_id_ark_map. > Include introduced FX2 PCIe ID and description. > Thanks for v2, but this is no more just a documentation patch, can you please split the patch into two, first one adds new device support and upd

[PATCH v2] doc: update ark guide

2023-02-10 Thread Shepard Siegel
Add ark PCIe device 1d6c:1022 FX2 to pci_id_ark_map. Include introduced FX2 PCIe ID and description. Signed-off-by: Shepard Siegel --- doc/guides/nics/ark.rst | 20 drivers/net/ark/ark_ethdev.c | 1 + 2 files changed, 21 insertions(+) diff --git a/doc/guides/nics/ark.

Re: [PATCH] doc: update ark guide

2023-02-10 Thread Shepard Siegel
I meant to say "supported in the 23.03 release." just now in my email. sorry for the typo! On Fri, Feb 10, 2023 at 4:43 PM Shepard Siegel < shepard.sie...@atomicrules.com> wrote: > Yes, exactly, the 1d6c:1022 device is the new FX2 device that will be > supported in the 22.03 release. > > -Shep >

Re: [PATCH] doc: update ark guide

2023-02-10 Thread Shepard Siegel
Yes, exactly, the 1d6c:1022 device is the new FX2 device that will be supported in the 22.03 release. -Shep On Fri, Feb 10, 2023 at 4:11 PM Ferruh Yigit wrote: > On 2/10/2023 9:03 PM, Shepard Siegel wrote: > > Hi Ferruh, > > The new FX2 device *is* supported by the ark driver as of DPDK 23.03

Re: [PATCH v3] vhost: exclude VM hugepages from coredumps

2023-02-10 Thread Mike Pattrick
On Fri, Feb 10, 2023 at 10:53 AM David Marchand wrote: > > Hello Mike, > > On Wed, Dec 7, 2022 at 5:54 PM Mike Pattrick wrote: > > > > Currently if an application wants to include shared hugepages in > > coredumps in conjunction with the vhost library, the coredump will be > > larger than expecte

Re: [PATCH] doc: update ark guide

2023-02-10 Thread Ferruh Yigit
On 2/10/2023 9:03 PM, Shepard Siegel wrote: > Hi Ferruh, > The new FX2 device *is* supported by the ark driver as of DPDK 23.03. > These changes bring the ark doc up to date for the upcoming release. I don't know what exactly 'FX2' device is, but I was referring to '1d6c:1022' device id. Following

Re: [PATCH] doc: update ark guide

2023-02-10 Thread Shepard Siegel
Hi Ferruh, The new FX2 device *is* supported by the ark driver as of DPDK 23.03. These changes bring the ark doc up to date for the upcoming release. -Shep On Fri, Feb 10, 2023 at 3:34 PM Ferruh Yigit wrote: > On 2/10/2023 7:38 PM, Shepard Siegel wrote: > > Include introduced FX2 PCIe ID and de

Re: [PATCH v4] net/af_xdp: AF_XDP PMD CNI Integration

2023-02-10 Thread Ferruh Yigit
On 2/10/2023 3:38 PM, Koikkara Reeny, Shibin wrote: > > >> -Original Message- >> From: Ferruh Yigit >> Sent: Friday, February 10, 2023 1:04 PM >> To: Koikkara Reeny, Shibin ; >> dev@dpdk.org; Zhang, Qi Z ; Burakov, Anatoly >> ; Richardson, Bruce >> ; Mcnamara, John >> >> Cc: Loftus, Cia

Re: [PATCH] doc: update ark guide

2023-02-10 Thread Ferruh Yigit
On 2/10/2023 7:38 PM, Shepard Siegel wrote: > Include introduced FX2 PCIe ID and description. > > Signed-off-by: Shepard Siegel > --- > doc/guides/nics/ark.rst | 20 > 1 file changed, 20 insertions(+) > > diff --git a/doc/guides/nics/ark.rst b/doc/guides/nics/ark.rst > inde

Re: [PATCH] eal: introduce atomics abstraction

2023-02-10 Thread Tyler Retzlaff
On Fri, Feb 10, 2023 at 05:30:00AM +, Honnappa Nagarahalli wrote: > > > > On Thu, Feb 09, 2023 at 12:16:38AM +, Honnappa Nagarahalli wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > For environments where stdatomics are not supported, we > > > > > > > > > could > >

Re: [PATCH v2] net/nfp: advertise no support for keeping flow rules

2023-02-10 Thread Ferruh Yigit
On 2/3/2023 1:59 AM, Chaoyong He wrote: > From: Peng Zhang > > Explicitly clear the RTE_ETH_DEV_CAPA_FLOW_RULE_KEEP capability > bit to match behavior of other PMDs. This was missed when first > adding flow support for the NFP PMD. > > Fixes: 30ecce522732 ("net/nfp: support flow API") > Cc: chao

Re: [PATCH 2/2] net/gve: add standard and extended statistics

2023-02-10 Thread Stephen Hemminger
On Fri, 10 Feb 2023 20:25:41 +0300 Levend Sayar wrote: > Accessing a stack variable is faster. > So copying to given stats pointer will be done at once. > But of course, given stats pointer can also be used. I doubt there is an observable difference. Access to a stack variable is offset from re

[PATCH] pipeline: support conversion between big and small fields

2023-02-10 Thread Cristian Dumitrescu
While the small fields (size <= 64 bits) can be in either network byte order (header fields) or host byte order (meta-data fields), the big fields (size > 64 bits) are always expected to be in network byte order (big endian), both header and metadata fields. Previously, a big field could be involv

[PATCH] doc: update ark guide

2023-02-10 Thread Shepard Siegel
Include introduced FX2 PCIe ID and description. Signed-off-by: Shepard Siegel --- doc/guides/nics/ark.rst | 20 1 file changed, 20 insertions(+) diff --git a/doc/guides/nics/ark.rst b/doc/guides/nics/ark.rst index ba00f14e80..39cd75064d 100644 --- a/doc/guides/nics/ark.rst

RE: [PATCH v1 13/13] test/bbdev: remove iteration count check

2023-02-10 Thread Chautru, Nicolas
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Friday, February 10, 2023 6:01 AM > To: Chautru, Nicolas ; Vargas, Hernan > ; dev@dpdk.org; gak...@marvell.com; Rix, Tom > > Cc: Zhang, Qi Z > Subject: Re: [PATCH v1 13/13] test/bbdev: remove iteration count check > > Hi

[PATCH v2 9/9] baseband/acc: remove printf from PMD function

2023-02-10 Thread Nicolas Chautru
Replacing usage of printf in companion function for bbdev-test by rte_log. Signed-off-by: Nicolas Chautru Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/rte_acc100_pmd.c | 18 +- drivers/baseband/acc/rte_vrb_pmd.c| 2 +- 2 files changed, 10 insertions(+), 10 deletion

[PATCH v2 8/9] baseband/acc: add support for 4GUL with SO and TB

2023-02-10 Thread Nicolas Chautru
Implementation to support the case when using LTE decoder with soft output and transport block mode. Signed-off-by: Nicolas Chautru Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/rte_vrb_pmd.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/dri

[PATCH v2 6/9] baseband/acc: fix potential arithmetic overflow

2023-02-10 Thread Nicolas Chautru
Fix potential issue of overflow causing coverity warning. Coverity issue: 383154 Fixes: 8e16839937 ("baseband/acc: extension of the device structure") Cc: sta...@dpdk.org Signed-off-by: Nicolas Chautru Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/rte_vrb_pmd.c | 2 +- drivers/baseband

[PATCH v2 7/9] baseband/acc: add support for 4GUL CRC drop in VRB PMD

2023-02-10 Thread Nicolas Chautru
Adding support for the capability to drop the CRC24B when using the turbo-decoder. Signed-off-by: Nicolas Chautru Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/rte_vrb_pmd.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/baseband/acc/rte_vrb_pmd.c

[PATCH v2 5/9] baseband/acc: fix iteration counter in TB mode

2023-02-10 Thread Nicolas Chautru
The iteration count was not using correct structure (4G vs 5G) in TB mode. Fixes: bec597b78a0 ("baseband/acc200: add LTE processing") Cc: sta...@dpdk.org Signed-off-by: Nicolas Chautru Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/rte_vrb_pmd.c | 10 +++--- 1 file changed, 7 insert

[PATCH v2 4/9] baseband/acc: prevent to dequeue more than requested

2023-02-10 Thread Nicolas Chautru
Add support for corner-case when more operations are requested than expected, in the case of encoder muxing operations. Fixes: e640f6cdfa84 ("baseband/acc200: add LDPC processing") Cc: sta...@dpdk.org Signed-off-by: Nicolas Chautru Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/rte_vrb_

[PATCH v2 3/9] baseband/acc: add explicit mbuf append for soft output

2023-02-10 Thread Nicolas Chautru
Adding an explicit mbuf append in the case of soft output mbuf being provided. Fixes: e640f6cdfa84 ("baseband/acc200: add LDPC processing") Cc: sta...@dpdk.org Signed-off-by: Nicolas Chautru Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/rte_vrb_pmd.c | 4 1 file changed, 4 inserti

[PATCH v2 2/9] baseband/acc: remove interrupt support on VRB1

2023-02-10 Thread Nicolas Chautru
Not enabling interrupt in VRB1 PMD variant to avoid potential corner case. Fixes: 3cabc8eaf524 ("baseband/acc200: support interrupt") Cc: sta...@dpdk.org Signed-off-by: Nicolas Chautru Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/rte_vrb_pmd.c | 8 1 file changed, 8 insertion

[PATCH v2 1/9] baseband/acc: protection for TB negative scenario

2023-02-10 Thread Nicolas Chautru
Adding handling of negative scenario for malformed Transport Block mode operations. Fixes: bec597b78a0 ("baseband/acc200: add LTE processing") Cc: sta...@dpdk.org Signed-off-by: Nicolas Chautru Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/rte_vrb_pmd.c | 20 1 fil

[PATCH v2 0/9] baseband/acc: VRB PMD fixes

2023-02-10 Thread Nicolas Chautru
Hi, v2: updated based on Maxime's review (commit messages and adding unlikely statement). Thanks. Let me know if further change is required. Series of mainly fixes for corner-cases and protection in the VRB PMD. The last 2 commits are not fixes but add support for missing minor capability, as w

RE: [PATCH v1 9/9] baseband/acc: remove printf from PMD function

2023-02-10 Thread Chautru, Nicolas
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Friday, February 10, 2023 1:45 AM > To: Chautru, Nicolas ; dev@dpdk.org > Cc: Vargas, Hernan > Subject: Re: [PATCH v1 9/9] baseband/acc: remove printf from PMD function > > > > On 2/9/23 23:19, Nicolas Chautru wrote: > >

RE: [PATCH v5 1/3] eventdev/eth_rx: add params set/get APIs

2023-02-10 Thread Naga Harish K, S V
> -Original Message- > From: Jerin Jacob > Sent: Friday, February 10, 2023 7:28 PM > To: Naga Harish K, S V > Cc: jer...@marvell.com; Carrillo, Erik G ; Gujjar, > Abhinandan S ; dev@dpdk.org; > Jayatheerthan, Jay > Subject: Re: [PATCH v5 1/3] eventdev/eth_rx: add params set/get APIs >

RE: [PATCH v5 2/3] eventdev/eth_tx: add params set/get APIs

2023-02-10 Thread Naga Harish K, S V
> -Original Message- > From: Jerin Jacob > Sent: Friday, February 10, 2023 8:55 PM > To: Naga Harish K, S V > Cc: jer...@marvell.com; Carrillo, Erik G ; Gujjar, > Abhinandan S ; dev@dpdk.org; > Jayatheerthan, Jay > Subject: Re: [PATCH v5 2/3] eventdev/eth_tx: add params set/get APIs >

Re: [PATCH v4 0/4] ethdev: add template table insertion and matching types

2023-02-10 Thread Ferruh Yigit
On 2/8/2023 3:06 AM, Alexander Kozyrev wrote: > Bring more flexibility and control over both flow rule insertion > and packet matching mechanisms. Introduce 2 new flow table types: > > 1. Allow a user to specify the insertion type used in template tables. > The insertion type is responsible for ch

[PATCH v6 3/3] eventdev/crypto: add params set/get APIs

2023-02-10 Thread Naga Harish K S V
The adapter runtime configuration parameters defined in the struct rte_event_crypto_adapter_runtime_params can be configured and retrieved using rte_event_crypto_adapter_runtime_params_set() and rte_event_eth_rx_adapter_runtime_params_get() respectively. Signed-off-by: Naga Harish K S V --- v6: *

[PATCH v6 2/3] eventdev/eth_tx: add params set/get APIs

2023-02-10 Thread Naga Harish K S V
The adapter runtime configuration parameters defined in the struct rte_event_eth_tx_adapter_runtime_params can be configured and retrieved using rte_event_eth_tx_adapter_runtime_params_set() and rte_event_eth_tx_adapter_runtime_params_get() respectively. Signed-off-by: Naga Harish K S V --- v6: *

[PATCH v6 1/3] eventdev/eth_rx: add params set/get APIs

2023-02-10 Thread Naga Harish K S V
The adapter runtime configuration parameters defined in the struct rte_event_eth_rx_adapter_runtime_params can be configured and retrieved using rte_event_eth_rx_adapter_runtime_params_set() and rte_event_eth_tx_adapter_runtime_params_get() respectively. Signed-off-by: Naga Harish K S V --- v6: *

RE: [PATCH v1 4/9] baseband/acc: add explicit mbuf apend for soft output

2023-02-10 Thread Chautru, Nicolas
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Friday, February 10, 2023 12:41 AM > To: Chautru, Nicolas ; dev@dpdk.org > Cc: Vargas, Hernan ; sta...@dpdk.org > Subject: Re: [PATCH v1 4/9] baseband/acc: add explicit mbuf apend for soft > output > > > > On 2/9/23 23:19

RE: [PATCH v1 2/9] baseband/acc: add support for 4GUL with SO and TB

2023-02-10 Thread Chautru, Nicolas
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Friday, February 10, 2023 12:31 AM > To: Chautru, Nicolas ; dev@dpdk.org > Cc: Vargas, Hernan ; sta...@dpdk.org > Subject: Re: [PATCH v1 2/9] baseband/acc: add support for 4GUL with SO and > TB > > > > On 2/9/23 23:19, Ni

RE: [PATCH v1 1/9] baseband/acc: protection for TB negative scenario

2023-02-10 Thread Chautru, Nicolas
Hi Maxime, Thanks, will do in v2. > -Original Message- > From: Maxime Coquelin > Sent: Friday, February 10, 2023 12:17 AM > To: Chautru, Nicolas ; dev@dpdk.org > Cc: Vargas, Hernan ; sta...@dpdk.org > Subject: Re: [PATCH v1 1/9] baseband/acc: protection for TB negative scenario > > >

Re: [PATCH 2/2] net/gve: add standard and extended statistics

2023-02-10 Thread Levend Sayar
Accessing a stack variable is faster. So copying to given stats pointer will be done at once. But of course, given stats pointer can also be used. > On 10 Feb 2023, at 19:34, Stephen Hemminger > wrote: > > On Fri, 10 Feb 2023 16:06:06 +0300 > Levend Sayar wrote: > >> +gve_stats_get(struct rt

RE: [PATCH v1 04/13] test/bbdev: early termination not explicit set

2023-02-10 Thread Vargas, Hernan
Hi Maxime, -Original Message- From: Maxime Coquelin Sent: Tuesday, January 31, 2023 4:04 AM To: Vargas, Hernan ; dev@dpdk.org; gak...@marvell.com; Rix, Tom Cc: Chautru, Nicolas ; Zhang, Qi Z Subject: Re: [PATCH v1 04/13] test/bbdev: early termination not explicit set On 1/17/23 17

[PATCH v4 5/5] ipsec: fix usage of RTE_LOGTYPE_USER1

2023-02-10 Thread Stephen Hemminger
There already is a logtype in this driver, use it! Fixes: b35848bc01f6 ("crypto/ipsec_mb: add multi-process IPC request handler") Cc: kai...@intel.com Signed-off-by: Stephen Hemminger --- drivers/crypto/ipsec_mb/ipsec_mb_ops.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a

[PATCH v4 4/5] vhost: use logtype instead of RTE_LOGTYPE_USER1

2023-02-10 Thread Stephen Hemminger
Fix instances of USER1 logtype in fdset and crypto sections. Acked-by: Chenbo Xia Reviewed-by: Maxime Coquelin Signed-off-by: Stephen Hemminger --- lib/vhost/fd_man.c | 16 +--- lib/vhost/vhost_crypto.c | 25 +++-- 2 files changed, 20 insertions(+), 21 del

[PATCH v4 3/5] latencystats: use dynamic logtype

2023-02-10 Thread Stephen Hemminger
Libraries should not reuse RTE_LOGTYPE_USER1 for their logging. Instead they should register their own type. Fixes: 5cd3cac9ed22 ("latency: added new library for latency stats") Cc: reshma.pat...@intel.com Signed-off-by: Stephen Hemminger --- lib/latencystats/rte_latencystats.c | 55

[PATCH v4 2/5] reorder: use a dynamic logtype

2023-02-10 Thread Stephen Hemminger
Libraries should not be reusing RTE_LOGTYPE_USER1 instead of doing proper logtype registration. Fixes: b70b56032bff ("reorder: new library") Cc: sergio.gonzalez.mon...@intel.com Signed-off-by: Stephen Hemminger --- lib/reorder/rte_reorder.c | 35 +++ 1 file change

[PATCH v4 1/5] ip_frag: use a dynamic logtype

2023-02-10 Thread Stephen Hemminger
DPDK libraries should not be reusing RTE_LOGTYPE_USER1 in lieu of doing proper logtype registration. Acked-by: Konstantin Ananyev Fixes: 416707812c03 ("ip_frag: refactor reassembly code into a proper library") Signed-off-by: Stephen Hemminger --- lib/ip_frag/ip_frag_common.h | 16 ++- lib

[PATCH v4 0/5] Replace use of RTE_LOGTYPE_USER1 in library

2023-02-10 Thread Stephen Hemminger
The DPDK libraries and drivers should not be using the USER1 logtype. v4 - fix build compile error with debug enabled v3 - fix typo in ip_frag v2 - fix some compiler warnings Stephen Hemminger (5): ip_frag: use a dynamic logtype reorder: use a dynamic logtype latencystats: use dynamic logty

DPDK Release Status Meeting 2023-02-09

2023-02-10 Thread Mcnamara, John
Release status meeting minutes 2023-02-09 = Agenda: * Release Dates * Subtrees * Roadmaps * LTS * Defects * Opens Participants: * AMD * Intel * Red Hat Release Dates - The following are the proposed current dates for 23.03: * V1: 25 D

Re: [PATCH 2/2] net/gve: add standard and extended statistics

2023-02-10 Thread Stephen Hemminger
On Fri, 10 Feb 2023 16:06:06 +0300 Levend Sayar wrote: > +gve_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) > +{ > + uint16_t i; > + struct rte_eth_stats tmp; > + > + memset(&tmp, 0, sizeof(tmp)) Why do you need tmp? The stats pointer passed in is already available

Re: [PATCH v3] vhost: exclude VM hugepages from coredumps

2023-02-10 Thread Maxime Coquelin
Thanks David for the report. On 2/10/23 16:53, David Marchand wrote: Hello Mike, On Wed, Dec 7, 2022 at 5:54 PM Mike Pattrick wrote: Currently if an application wants to include shared hugepages in coredumps in conjunction with the vhost library, the coredump will be larger than expected and

Re: [PATCH v3] vhost: exclude VM hugepages from coredumps

2023-02-10 Thread David Marchand
Hello Mike, On Wed, Dec 7, 2022 at 5:54 PM Mike Pattrick wrote: > > Currently if an application wants to include shared hugepages in > coredumps in conjunction with the vhost library, the coredump will be > larger than expected and include unneeded virtual machine memory. > > This patch will mark

[PATCH v5] net/af_xdp: support CNI Integration

2023-02-10 Thread Shibin Koikkara Reeny
Integrate support for the AF_XDP CNI and device plugin [1] so that the DPDK AF_XDP PMD can work in an unprivileged container environment. Part of the AF_XDP PMD initialization process involves loading an eBPF program onto the given netdev. This operation requires privileges, which prevents the PMD

RE: [PATCH v4] net/af_xdp: AF_XDP PMD CNI Integration

2023-02-10 Thread Koikkara Reeny, Shibin
> -Original Message- > From: Ferruh Yigit > Sent: Friday, February 10, 2023 1:04 PM > To: Koikkara Reeny, Shibin ; > dev@dpdk.org; Zhang, Qi Z ; Burakov, Anatoly > ; Richardson, Bruce > ; Mcnamara, John > > Cc: Loftus, Ciara > Subject: Re: [PATCH v4] net/af_xdp: AF_XDP PMD CNI Integrat

Re: [EXT] Re: [PATCH v1 1/5] mempool: remove internal tracepoints from version map

2023-02-10 Thread Jerin Jacob
On Fri, Feb 10, 2023 at 7:54 PM David Marchand wrote: > > On Fri, Feb 10, 2023 at 8:06 AM Jerin Jacob wrote: > > > > On Fri, Feb 10, 2023 at 12:30 PM Ankur Dwivedi wrote: > > > > > > >On Thu, Feb 9, 2023 at 7:00 PM Ankur Dwivedi > > > >wrote: > > > >> > > > >> The file rte_mempool_trace.h conta

Re: [PATCH] net/virtio-user: fix number of vrings calculation

2023-02-10 Thread Maxime Coquelin
On 2/10/23 16:10, Maxime Coquelin wrote: When moving to dynamic allocation of vrings metadata, the number of vrings to allocate was incremented if the backend supports control queue. The problem is that the control queue metadata have to be allocated even if the backend does not use it direct

Re: [PATCH v5 2/3] eventdev/eth_tx: add params set/get APIs

2023-02-10 Thread Jerin Jacob
On Fri, Feb 10, 2023 at 8:32 PM Naga Harish K, S V wrote: > > > > > -Original Message- > > From: Jerin Jacob > > Sent: Friday, February 10, 2023 7:36 PM > > To: Naga Harish K, S V > > Cc: jer...@marvell.com; Carrillo, Erik G ; > > Gujjar, > > Abhinandan S ; dev@dpdk.org; > > Jayatheerth

Re: [PATCH] net/virtio-user: fix number of vrings calculation

2023-02-10 Thread David Marchand
On Fri, Feb 10, 2023 at 4:10 PM Maxime Coquelin wrote: > > When moving to dynamic allocation of vrings metadata, the > number of vrings to allocate was incremented if the backend > supports control queue. > > The problem is that the control queue metadata have to be > allocated even if the backend

RE: [PATCH v2 1/2] net/i40e: replace put function

2023-02-10 Thread Honnappa Nagarahalli
[ > > > From: Kamalakshitha Aligeri [mailto:kamalakshitha.alig...@arm.com] > > Sent: Friday, 10 February 2023 07.54 > > > > Integrated zero-copy put API in mempool cache in i40e PMD. > > On Ampere Altra server, l3fwd single core's performance improves by 5% > > with the new API > > > > Signed-off

[PATCH v3 2/3] app/testpmd: add host port parameter into flow config

2023-02-10 Thread Viacheslav Ovsiienko
Host port id parameter is added to "flow configure" command. Signed-off-by: Viacheslav Ovsiienko Acked-by: Ori Kam --- app/test-pmd/cmdline_flow.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index 3b846ae73f..77788289

[PATCH v3 3/3] app/testpmd: add shared indirect action support

2023-02-10 Thread Viacheslav Ovsiienko
The shared indirect action can be shared between ports, action should be created on single port and the handle can be used in the templates and flows on multiple ports, example: flow configure 0 queues_number 1 queues_size 64 counters_number 64 flow configure 1 queues_number 1 queues_size 64 c

[PATCH v3 1/3] ethdev: sharing indirect actions between ports

2023-02-10 Thread Viacheslav Ovsiienko
The RTE Flow API implements the concept of shared objects, known as indirect actions (RTE_FLOW_ACTION_TYPE_INDIRECT). An application can create the indirect action of desired type and configuration with rte_flow_action_handle_create call and then specify the obtained action handle in multiple flows

[PATCH v3 0/3] *ethdev: sharing indirect actions between port*

2023-02-10 Thread Viacheslav Ovsiienko
The RTE Flow API implements the concept of shared objects, known as indirect actions (RTE_FLOW_ACTION_TYPE_INDIRECT). An application can create the indirect action of desired type and configuration with rte_flow_action_handle_create call and then specify the obtained action handle in multiple flows

[PATCH] net/virtio-user: fix number of vrings calculation

2023-02-10 Thread Maxime Coquelin
When moving to dynamic allocation of vrings metadata, the number of vrings to allocate was incremented if the backend supports control queue. The problem is that the control queue metadata have to be allocated even if the backend does not use it directly, since the control queue is managed by the

RE: [PATCH v5 2/3] eventdev/eth_tx: add params set/get APIs

2023-02-10 Thread Naga Harish K, S V
> -Original Message- > From: Jerin Jacob > Sent: Friday, February 10, 2023 7:36 PM > To: Naga Harish K, S V > Cc: jer...@marvell.com; Carrillo, Erik G ; Gujjar, > Abhinandan S ; dev@dpdk.org; > Jayatheerthan, Jay > Subject: Re: [PATCH v5 2/3] eventdev/eth_tx: add params set/get APIs >

Re: [RFC PATCH 0/1] Specify C-standard requirement for DPDK builds

2023-02-10 Thread Ben Magistro
Adding Tyler Sort of following along on the RFC: introduce atomics [1] it seems like the decision to use 99 vs 11 here could make an impact on the approach taken in that thread. 1) http://mails.dpdk.org/archives/dev/2023-February/262042.html On Fri, Feb 3, 2023 at 1:00 PM Bruce Richardson wrote

Re: [dpdk-dev] [RFC] ethdev: improve link speed to string

2023-02-10 Thread Ferruh Yigit
On 1/19/2023 4:45 PM, Stephen Hemminger wrote: > On Thu, 19 Jan 2023 11:41:12 + > Ferruh Yigit wrote: > >> Nothing good will happen if you try to use the function to >> print two different link speeds in one log message. > You are right. > And use malloc for "name" will resu

RE: [PATCH v2 1/9] ethdev: sharing indirect actions between ports

2023-02-10 Thread Slava Ovsiienko
Hi, Ferruh > -Original Message- > From: Ferruh Yigit > Sent: Friday, February 10, 2023 4:35 PM > To: Slava Ovsiienko ; dev@dpdk.org > Cc: Ori Kam ; Raslan Darawsheh ; > Matan Azrad ; arybche...@solarflare.com > Subject: Re: [PATCH v2 1/9] ethdev: sharing indirect actions between ports >

Re: [PATCH v2 9/9] doc: update cross-port indirect shared action

2023-02-10 Thread Ferruh Yigit
On 2/7/2023 2:02 PM, Viacheslav Ovsiienko wrote: > The patch updates the Release Notes and documentation > for the indirect RTE Flow actions as shared ones between > ports on the same physical NIC. > > Signed-off-by: Viacheslav Ovsiienko > --- > doc/guides/rel_notes/release_23_03.rst | 6 ++

Re: [PATCH v2 1/9] ethdev: sharing indirect actions between ports

2023-02-10 Thread Ferruh Yigit
On 2/7/2023 2:01 PM, Viacheslav Ovsiienko wrote: > The RTE Flow API implements the concept of shared objects, > known as indirect actions (RTE_FLOW_ACTION_TYPE_INDIRECT). > An application can create the indirect action of desired > type and configuration with rte_flow_action_handle_create > call an

Re: [EXT] Re: [PATCH v1 1/5] mempool: remove internal tracepoints from version map

2023-02-10 Thread David Marchand
On Fri, Feb 10, 2023 at 8:06 AM Jerin Jacob wrote: > > On Fri, Feb 10, 2023 at 12:30 PM Ankur Dwivedi wrote: > > > > >On Thu, Feb 9, 2023 at 7:00 PM Ankur Dwivedi > > >wrote: > > >> > > >> The file rte_mempool_trace.h contains tracepoints which are internal > > >> to the mempool library. This fi

Re: [PATCH v2 4/5] ethdev: remove internal tracepoints from version map

2023-02-10 Thread David Marchand
On Fri, Feb 10, 2023 at 11:35 AM Ankur Dwivedi wrote: > > The internal tracepoints are removed from the version.map file. > > Signed-off-by: Ankur Dwivedi > Acked-by: Ferruh Yigit rte_ethdev_trace.h does not need to be exported. I suggest the following addition: diff --git a/lib/ethdev/rte_et

RE: [PATCH v4 1/2] ethdev: introduce the PHY affinity field in Tx queue API

2023-02-10 Thread Jiawei(Jonny) Wang
Hi, > -Original Message- > From: Ferruh Yigit > Sent: Friday, February 10, 2023 3:45 AM > To: Jiawei(Jonny) Wang ; Slava Ovsiienko > ; Ori Kam ; NBU-Contact- > Thomas Monjalon (EXTERNAL) ; > andrew.rybche...@oktetlabs.ru; Aman Singh ; > Yuying Zhang > Cc: dev@dpdk.org; Raslan Darawsheh

Re: [PATCH v5 2/3] eventdev/eth_tx: add params set/get APIs

2023-02-10 Thread Jerin Jacob
On Fri, Feb 10, 2023 at 7:17 PM Naga Harish K S V wrote: > > The adapter runtime configuration parameters defined in the > struct rte_event_eth_tx_adapter_runtime_params can be > configured and retrieved using > rte_event_eth_tx_adapter_runtime_params_set and rte_event_eth_tx_adapter_runtime_param

Re: [PATCH v1 13/13] test/bbdev: remove iteration count check

2023-02-10 Thread Maxime Coquelin
Hi Nicolas, On 2/9/23 17:59, Chautru, Nicolas wrote: Hi Maxime, -Original Message- From: Maxime Coquelin Sent: Thursday, February 9, 2023 1:11 AM To: Vargas, Hernan ; dev@dpdk.org; gak...@marvell.com; Rix, Tom Cc: Chautru, Nicolas ; Zhang, Qi Z Subject: Re: [PATCH v1 13/13] test/bbd

Re: [PATCH v5 1/3] eventdev/eth_rx: add params set/get APIs

2023-02-10 Thread Jerin Jacob
On Fri, Feb 10, 2023 at 7:03 PM Naga Harish K S V wrote: > > The adapter configuration parameters defined in the > struct rte_event_eth_rx_adapter_runtime_params can be configured > and retrieved using rte_event_eth_rx_adapter_runtime_params_set and rte_event_eth_rx_adapter_runtime_params_set()

[PATCH v5 3/3] eventdev/crypto: add params set/get APIs

2023-02-10 Thread Naga Harish K S V
The adapter runtime configuration parameters defined in the struct rte_event_crypto_adapter_runtime_params can be configured and retrieved using rte_event_crypto_adapter_runtime_params_set and rte_event_eth_rx_adapter_runtime_params_get respectively. Signed-off-by: Naga Harish K S V --- app/test

[PATCH v5 2/3] eventdev/eth_tx: add params set/get APIs

2023-02-10 Thread Naga Harish K S V
The adapter runtime configuration parameters defined in the struct rte_event_eth_tx_adapter_runtime_params can be configured and retrieved using rte_event_eth_tx_adapter_runtime_params_set and rte_event_eth_tx_adapter_runtime_params_get respectively. Signed-off-by: Naga Harish K S V --- app/test

[PATCH v5 1/3] eventdev/eth_rx: add params set/get APIs

2023-02-10 Thread Naga Harish K S V
The adapter configuration parameters defined in the struct rte_event_eth_rx_adapter_runtime_params can be configured and retrieved using rte_event_eth_rx_adapter_runtime_params_set and rte_event_eth_tx_adapter_runtime_params_get respectively. Signed-off-by: Naga Harish K S V --- app/test/test_ev

Re: [PATCH v4] net/af_xdp: AF_XDP PMD CNI Integration

2023-02-10 Thread Ferruh Yigit
On 2/9/2023 12:05 PM, Shibin Koikkara Reeny wrote: > Integrate support for the AF_XDP CNI and device plugin [1] so that the > DPDK AF_XDP PMD can work in an unprivileged container environment. > Part of the AF_XDP PMD initialization process involves loading > an eBPF program onto the given netdev.

[PATCH v5 3/3] eventdev/crypto: add params set/get APIs

2023-02-10 Thread Naga Harish K S V
The adapter runtime configuration parameters defined in the struct rte_event_crypto_adapter_runtime_params can be configured and retrieved using rte_event_crypto_adapter_runtime_params_set and rte_event_eth_rx_adapter_runtime_params_get respectively. Signed-off-by: Naga Harish K S V --- app/test

[PATCH v5 2/3] eventdev/eth_tx: add params set/get APIs

2023-02-10 Thread Naga Harish K S V
The adapter runtime configuration parameters defined in the struct rte_event_eth_tx_adapter_runtime_params can be configured and retrieved using rte_event_eth_tx_adapter_runtime_params_set and rte_event_eth_tx_adapter_runtime_params_get respectively. Signed-off-by: Naga Harish K S V --- app/test

[PATCH v5 1/3] eventdev/eth_rx: add params set/get APIs

2023-02-10 Thread Naga Harish K S V
The adapter configuration parameters defined in the struct rte_event_eth_rx_adapter_runtime_params can be configured and retrieved using rte_event_eth_rx_adapter_runtime_params_set and rte_event_eth_tx_adapter_runtime_params_get respectively. Signed-off-by: Naga Harish K S V --- app/test/test_ev

Re: [PATCH v10 0/5] lcore telemetry improvements

2023-02-10 Thread David Marchand
Hello Robin, On Thu, Feb 9, 2023 at 10:45 AM Robin Jarry wrote: > > This is a follow up on previous work by Kevin Laatz: > > http://patches.dpdk.org/project/dpdk/list/?series=24658&state=* > > This series is aimed at allowing DPDK applications to expose their CPU > usage stats in the DPDK telemet

Re: [PATCH V8] ethdev: fix one address occupies two entries in MAC addrs

2023-02-10 Thread lihuisong (C)
在 2023/2/10 20:27, Ferruh Yigit 写道: On 2/10/2023 9:54 AM, lihuisong (C) wrote: 在 2023/2/9 20:45, Ferruh Yigit 写道: On 2/4/2023 2:57 AM, lihuisong (C) wrote: 在 2023/2/3 20:58, Ferruh Yigit 写道: On 2/3/2023 1:56 AM, lihuisong (C) wrote: 在 2023/2/3 5:10, Thomas Monjalon 写道: 02/02/2023 19:09, F

Re: [PATCH] lib/net: support UDP pseudo-header for UFO

2023-02-10 Thread Olivier Matz
Hello Zhichao, Sorry for the delayed response. On Thu, Jan 12, 2023 at 05:26:08PM +0800, Zhichao Zeng wrote: > Add UDP pseudo-header processing for UDP segmentation offload > by adding the UDP_SEG flag. > > Signed-off-by: Zhichao Zeng > --- > lib/net/rte_ip.h | 2 +- > 1 file changed, 1 insert

Re: [PATCH v2 5/5] eventdev: remove internal tracepoints from version map

2023-02-10 Thread Jerin Jacob
On Fri, Feb 10, 2023 at 4:05 PM Ankur Dwivedi wrote: > > The internal tracepoints are removed from the version.map file. > > Signed-off-by: Ankur Dwivedi >From Trace change PoV, Series-Acked-by: Jerin Jacob > --- > lib/eventdev/version.map | 30 -- > 1 file change

[PATCH 2/2] net/gve: add standard and extended statistics

2023-02-10 Thread Levend Sayar
Google Virtual NIC PMD is enriched with statistics info. Signed-off-by: Levend Sayar --- drivers/net/gve/gve_ethdev.c | 147 ++- drivers/net/gve/gve_ethdev.h | 11 +++ drivers/net/gve/gve_rx.c | 18 - drivers/net/gve/gve_tx.c | 6 ++ 4 files change

[PATCH 1/2] net/gve: change offloading capability

2023-02-10 Thread Levend Sayar
Google Virtual NIC is not doing IPv4 checksummimg. Removed that capability from PMD. Signed-off-by: Levend Sayar --- drivers/net/gve/gve_ethdev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/gve/gve_ethdev.c b/drivers/net/gve/gve_ethdev.c index 97781f0ed3..e357f16e16 100644 ---

  1   2   >