On Sat, Feb 11, 2023 at 6:05 AM Ferruh Yigit <ferruh.yi...@amd.com> wrote:
>
> On 2/10/2023 8:26 AM, Rakesh Kudurumalla wrote:
> > diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h
> > index b60987db4b..f4eb4232d4 100644
> > --- a/lib/ethdev/rte_flow.h
> > +++ b/lib/ethdev/rte_flow.h
> > @@ -2203,6 +2203,17 @@ enum rte_flow_action_type {
> > */
> > RTE_FLOW_ACTION_TYPE_DROP,
> >
> > + /**
> > + * Skip congestion management configuration
> > + *
> > + * Using rte_eth_cman_config_set() API the application
> > + * can configure ethdev Rx queue's congestion mechanism.
> > + * Introducing RTE_FLOW_ACTION_TYPE_SKIP_CMAN flow action to skip the
> > + * congestion configuration applied to the given ethdev Rx queue.
> > + *
> > + */
> > + RTE_FLOW_ACTION_TYPE_SKIP_CMAN,
> > +
>
> Inserting new enum item in to the middle of the enum upsets the ABI
> checks [1], can it go to the end?
Yes.
>
>
>
>
> [1]
> 1 function with some indirect sub-type change:
>
> [C] 'function size_t rte_flow_copy(rte_flow_desc*, size_t, const
> rte_flow_attr*, const rte_flow_item*, const rte_flow_action*)' at
> rte_flow.c:1092:1 has some indirect sub-type changes:
> parameter 1 of type 'rte_flow_desc*' has sub-type changes:
> in pointed to type 'struct rte_flow_desc' at rte_flow.h:4326:1:
> type size hasn't changed
> 1 data member changes (1 filtered):
> type of 'rte_flow_action* actions' changed:
> in pointed to type 'struct rte_flow_action' at
> rte_flow.h:3775:1:
> type size hasn't changed
> 1 data member change:
> type of 'rte_flow_action_type type' changed:
> type size hasn't changed
> 1 enumerator insertion:
>
> 'rte_flow_action_type::RTE_FLOW_ACTION_TYPE_SKIP_CMAN' value '8'
> 50 enumerator changes:
> 'rte_flow_action_type::RTE_FLOW_ACTION_TYPE_COUNT'
> from value '8' to '9' at rte_flow.h:2216:1
> ...
