> -----Original Message----- > From: Jerin Jacob <jerinjac...@gmail.com> > Sent: Friday, February 10, 2023 8:55 PM > To: Naga Harish K, S V <s.v.naga.haris...@intel.com> > Cc: jer...@marvell.com; Carrillo, Erik G <erik.g.carri...@intel.com>; Gujjar, > Abhinandan S <abhinandan.guj...@intel.com>; dev@dpdk.org; > Jayatheerthan, Jay <jay.jayatheert...@intel.com> > Subject: Re: [PATCH v5 2/3] eventdev/eth_tx: add params set/get APIs > > On Fri, Feb 10, 2023 at 8:32 PM Naga Harish K, S V > <s.v.naga.haris...@intel.com> wrote: > > > > > > > > > -----Original Message----- > > > From: Jerin Jacob <jerinjac...@gmail.com> > > > Sent: Friday, February 10, 2023 7:36 PM > > > To: Naga Harish K, S V <s.v.naga.haris...@intel.com> > > > Cc: jer...@marvell.com; Carrillo, Erik G > > > <erik.g.carri...@intel.com>; Gujjar, Abhinandan S > > > <abhinandan.guj...@intel.com>; dev@dpdk.org; Jayatheerthan, Jay > > > <jay.jayatheert...@intel.com> > > > Subject: Re: [PATCH v5 2/3] eventdev/eth_tx: add params set/get APIs > > > > > > On Fri, Feb 10, 2023 at 7:17 PM Naga Harish K S V > > > <s.v.naga.haris...@intel.com> wrote: > > > > > > > > The adapter runtime configuration parameters defined in the struct > > > > rte_event_eth_tx_adapter_runtime_params can be configured and > > > > retrieved using rte_event_eth_tx_adapter_runtime_params_set and > > > rte_event_eth_tx_adapter_runtime_params_set() > > > > > > > rte_event_eth_tx_adapter_runtime_params_get respectively. > > > > > > rte_event_eth_tx_adapter_runtime_params_get() > > > > > > > > > > > Signed-off-by: Naga Harish K S V <s.v.naga.haris...@intel.com> > > > > > > Not relevent any more. Use > > > rte_event_eth_tx_adapter_runtime_params_init(). > > > i.e This sentence can be removed. > > > > > > > > > > + * modify the required parameters and then call > > > > + * rte_event_eth_tx_adapter_runtime_params_set(). > > > > > > > > > > > > > + * > > > > + * This API is to be used after adding at least one queue to the > > > > + adapter > > > > + * and is supported only for service based adapter. > > > > > > This paragraph we can removed here as it is not generic API description. > > > > > > > This sequence is still needed as the "max_nb_tx" parameter of the > > adapter is configured > > A specific parameter specific constrain can go in the parameter Doxygen > comments. > i.e comment for "max_nb_tx" parameter. > >
Done. Updated max_nb_tx parameter doxygen in v6 patchset. > > during the addition of first queue to the adapter with the default > > value. If params_set() is called before adding the first queue, the > > params of the adapter will be overwritten to the default value later during > the first queue add.
