RE: [PATCH v6 0/9] Lock annotations

2023-02-08 Thread Xia, Chenbo
> -Original Message- > From: David Marchand > Sent: Tuesday, February 7, 2023 6:45 PM > To: dev@dpdk.org > Cc: maxime.coque...@redhat.com; step...@networkplumber.org; Xia, Chenbo > ; Hu, Jiayu ; Wang, YuanX > ; Ding, Xuan ; > m...@smartsharesystems.com > Subject: [PATCH v6 0/9] Lock annota

Re: [PATCH v2] net/sfc: export pick transfer proxy callback to representors

2023-02-08 Thread Ivan Malov
On Wed, 8 Feb 2023, Ferruh Yigit wrote: On 1/31/2023 11:13 AM, Andrew Rybchenko wrote: On 1/31/23 14:08, Ivan Malov wrote: Currently, the "pick transfer proxy ethdev" callback is only advertised for non-representor (in example, main PF) ethdevs. That does not sit well with the original idea of

Re: [PATCH] telemetry: rework code to avoid compiler warnings

2023-02-08 Thread David Marchand
On Wed, Feb 8, 2023 at 3:38 PM Bruce Richardson wrote: > > When printing values as hex strings, the telemetry code temporarily > disabled warnings about non-literal format strings. This was because the > actual format string was built-up programmatically to ensure the output > was of the desired b

Re: [PATCH] telemetry: fix repeat display when callback don't init dict

2023-02-08 Thread David Marchand
On Thu, Feb 9, 2023 at 2:31 AM Chengwen Feng wrote: > > When a telemetry callback doesn't initialize the telemetry data > structure and returns a non-negative number, the telemetry will repeat > to display the last result. This patch zero the data structure to avoid > the problem. > > Fixes: 6dd57

[PATCH v6] ethdev: add flow rule group description

2023-02-08 Thread Rongwei Liu
Add more sentences to describe the group concepts and define group 0 as root group for traffic to search a hit rule. Signed-off-by: Rongwei Liu --- lib/ethdev/rte_flow.h | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h

Re: [PATCH v3 1/3] lib: skip congestion management configuration

2023-02-08 Thread Jerin Jacob
On Thu, Feb 9, 2023 at 12:54 PM Rakesh Kudurumalla wrote: > > Skip the congestion management configuration applied using > rte_eth_cman_config_set() API on the given ethdev Rx queue. > > Signed-off-by: Rakesh Kudurumalla > --- > v3: Updated comments and programmers guide regrading > new action >

[PATCH v3 3/3] net/cnxk: skip red drop for ingress policer

2023-02-08 Thread Rakesh Kudurumalla
Dropping of packets is based on action configured to meter.If both skip_red and drop actions are configured then tail dropping in invoked else if only drop action is configured then RED drop is invoked.This action is supported only when RED is configured using rte_eth_cman_config_set() Signed-off-

[PATCH v3 2/3] app/testpmd: add skip cman support for testpmd

2023-02-08 Thread Rakesh Kudurumalla
added support for testpmd application to accept skip_cman action while configuring policy action Signed-off-by: Rakesh Kudurumalla --- app/test-pmd/cmdline_flow.c | 9 + 1 file changed, 9 insertions(+) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index 88108498

[PATCH v3 1/3] lib: skip congestion management configuration

2023-02-08 Thread Rakesh Kudurumalla
Skip the congestion management configuration applied using rte_eth_cman_config_set() API on the given ethdev Rx queue. Signed-off-by: Rakesh Kudurumalla --- v3: Updated comments and programmers guide regrading new action doc/guides/prog_guide/rte_flow.rst | 22 ++ lib/ethdev/

RE: [PATCH 4/5] vhost: use logtype instead of RTE_LOGTYPE_USER1

2023-02-08 Thread Xia, Chenbo
> -Original Message- > From: Stephen Hemminger > Sent: Wednesday, February 8, 2023 12:48 PM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Maxime Coquelin > ; Xia, Chenbo > Subject: [PATCH 4/5] vhost: use logtype instead of RTE_LOGTYPE_USER1 > > Fix instances of USER1 logtype in fdset and

Re: [PATCH v13 1/6] memarea: introduce memarea library

2023-02-08 Thread fengchengwen
On 2023/2/9 8:04, Stephen Hemminger wrote: > On Wed, 8 Feb 2023 08:24:47 + > Chengwen Feng wrote: > >> +RTE_LOG_REGISTER_DEFAULT(rte_memarea_logtype, INFO); >> +#define RTE_MEMAREA_LOG(level, ...) \ >> +rte_log(RTE_LOG_ ## level, rte_memarea_logtype, RTE_FMT("memarea: " \ >> +

[PATCH v14 4/6] test/memarea: support alloc and free API test

2023-02-08 Thread Chengwen Feng
This patch supports rte_memarea_alloc() and rte_memarea_free() API test. Signed-off-by: Chengwen Feng Reviewed-by: Dongdong Liu Acked-by: Morten Brørup --- app/test/test_memarea.c | 135 +++- 1 file changed, 134 insertions(+), 1 deletion(-) diff --git a/app

[PATCH v14 1/6] memarea: introduce memarea library

2023-02-08 Thread Chengwen Feng
The memarea library is an allocator of variable-size object which based on a memory region. This patch provides rte_memarea_create() and rte_memarea_destroy() API. Signed-off-by: Chengwen Feng Reviewed-by: Dongdong Liu Acked-by: Morten Brørup --- MAINTAINERS| 5 +

[PATCH v14 3/6] memarea: support alloc and free API

2023-02-08 Thread Chengwen Feng
This patch supports rte_memarea_alloc() and rte_memarea_free() API. Signed-off-by: Chengwen Feng Reviewed-by: Dongdong Liu Acked-by: Morten Brørup --- doc/guides/prog_guide/memarea_lib.rst | 6 + lib/memarea/rte_memarea.c | 180 ++ lib/memarea/rte_memarea.

[PATCH v14 2/6] test/memarea: support memarea test

2023-02-08 Thread Chengwen Feng
This patch supports memarea test of rte_memarea_create() and rte_memarea_destroy() API. Signed-off-by: Chengwen Feng Reviewed-by: Dongdong Liu Acked-by: Morten Brørup --- MAINTAINERS | 1 + app/test/meson.build| 2 + app/test/test_memarea.c | 130 +++

[PATCH v14 0/6] introduce memarea library

2023-02-08 Thread Chengwen Feng
The memarea library is an allocator of variable-size object which based on a memory region. The main features are as follows: - The memory region can be initialized from the following memory sources: 1. HEAP: e.g. invoke rte_malloc_socket. 2. LIBC: e.g. invoke posix_memalign. 3. Another me

[PATCH v14 5/6] memarea: support dump API

2023-02-08 Thread Chengwen Feng
This patch supports rte_memarea_dump() API which could be used for debug. Signed-off-by: Chengwen Feng Reviewed-by: Dongdong Liu Acked-by: Morten Brørup --- doc/guides/prog_guide/memarea_lib.rst | 3 + lib/memarea/rte_memarea.c | 98 +++ lib/memarea/rte_mem

[PATCH v14 6/6] test/memarea: support dump API test

2023-02-08 Thread Chengwen Feng
This patch supports rte_memarea_dump() API test. Signed-off-by: Chengwen Feng Reviewed-by: Dongdong Liu Acked-by: Morten Brørup --- app/test/test_memarea.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/app/test/test_memarea.c b/app/test/test_memarea.c

[PATCH 2/2] test/mempool: add zero-copy API's

2023-02-08 Thread Kamalakshitha Aligeri
Added mempool test cases with zero-copy get and put API's Signed-off-by: Kamalakshitha Aligeri Reviewed-by: Ruifeng Wang Reviewed-by: Feifei Wang --- Link: https://patchwork.dpdk.org/project/dpdk/patch/20221227151700.80887-1...@smartsharesystems.com/ app/test/test_mempool.c | 81

[PATCH 1/2] net/i40e: replace put function

2023-02-08 Thread Kamalakshitha Aligeri
Integrated zero-copy put API in mempool cache in i40e PMD. On Ampere Altra server, l3fwd single core's performance improves by 5% with the new API Signed-off-by: Kamalakshitha Aligeri Reviewed-by: Ruifeng Wang Reviewed-by: Feifei Wang --- Link: https://patchwork.dpdk.org/project/dpdk/patch/202

[PATCH v2] common/idpf: fix compilation for AVX512DQ

2023-02-08 Thread Wenjun Wu
Some intrinsics used in idpf split queue AVX512 datapath ask for CPUID flag AVX512DQ and compilation flag -mavx512dq. Fixes: 43e916179fa2 ("common/idpf: add AVX512 data path for split queue model") Signed-off-by: Wenjun Wu --- drivers/common/idpf/meson.build | 8 +--- drivers/net/idpf/meson

Re: [PATCH] mem: fix displaying heap ID failed for heap info command

2023-02-08 Thread fengchengwen
Acked-by: Chengwen Feng And, how abort add error log in telemetry valid_name, so so that problems can be identified as early as possible. On 2023/2/9 11:03, Huisong Li wrote: > The telemetry lib has added a allowed characters set for dictionary names, > See commit > 2537fb0c5f34 ("telemetry: lim

[PATCH] ethdev: telemetry xstats support hide zero

2023-02-08 Thread Chengwen Feng
The number of xstats may be large, after the hide zero option is added, only non-zero values can be displayed. Signed-off-by: Chengwen Feng --- lib/ethdev/rte_ethdev.c | 23 +-- 1 file changed, 17 insertions(+), 6 deletions(-) diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethde

[PATCH] mem: fix displaying heap ID failed for heap info command

2023-02-08 Thread Huisong Li
The telemetry lib has added a allowed characters set for dictionary names, See commit 2537fb0c5f34 ("telemetry: limit characters allowed in dictionary names") The space is not in this set, which cause the heap ID in /eal/heap_info cannot be displayed. Additionally, 'heap' is also misspelling. So u

[PATCH v5 1/2] dmadev: support stats reset telemetry command

2023-02-08 Thread Chengwen Feng
The stats reset is useful for debugging, so add it to the dmadev telemetry command lists. Signed-off-by: Chengwen Feng Reviewed-by: Bruce Richardson --- lib/dmadev/rte_dmadev.c | 47 + 1 file changed, 47 insertions(+) diff --git a/lib/dmadev/rte_dmadev.c

[PATCH v5 2/2] ethdev: support xstats reset telemetry command

2023-02-08 Thread Chengwen Feng
The xstats reset is useful for debugging, so add it to the ethdev telemetry command lists. Signed-off-by: Chengwen Feng --- lib/ethdev/rte_ethdev.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c index d25db35

[PATCH v5 0/2] support dmadev/ethdev stats reset

2023-02-08 Thread Chengwen Feng
This patchset contains dmadev/ethdev stats reset. Chengwen Feng (2): dmadev: support stats reset telemetry command ethdev: support xstats reset telemetry command --- v5: * address Bruce's comments: support LOG with stats reset result. reassemble the patchset. v4: * solve the internal don'

[PATCH v1] common/idpf: fix compilation for AVX512DQ

2023-02-08 Thread Wenjun Wu
Some intrinsics used in idpf split queue AVX512 datapath ask for CPUID flag AVX512DQ and compilation flag -mavx512dq. Fixes: 43e916179fa2 ("common/idpf: add AVX512 data path for split queue model") Signed-off-by: Wenjun Wu --- drivers/common/idpf/meson.build | 8 +--- drivers/net/idpf/meson

Re: [PATCH v9 1/5] eal: add lcore info in telemetry

2023-02-08 Thread lihuisong (C)
在 2023/2/9 1:04, Robin Jarry 写道: Hi lihuisong, lihuisong (C), Feb 08, 2023 at 03:24: static int lcore_dump_cb(unsigned int lcore_id, void *arg) { struct rte_config *cfg = rte_eal_get_configuration(); char cpuset[RTE_CPU_AFFINITY_STR_LEN]; - const char *role;

RE: [PATCH v5] ethdev: add flow rule group description

2023-02-08 Thread Rongwei Liu
HI Ferruh: BR Rongwei > -Original Message- > From: Ferruh Yigit > Sent: Thursday, February 9, 2023 04:28 > To: Rongwei Liu ; dev@dpdk.org; Matan Azrad > ; Slava Ovsiienko ; Ori Kam > ; NBU-Contact-Thomas Monjalon (EXTERNAL) > > Cc: Raslan Darawsheh ; Andrew Rybchenko > > Subject: Re: [

Re: [PATCH] telemetry: rework code to avoid compiler warnings

2023-02-08 Thread lihuisong (C)
在 2023/2/9 9:07, fengchengwen 写道: Beatutiful +1 Acked-by: Chengwen Feng Perfect Tested-by: Huisong Li On 2023/2/8 22:37, Bruce Richardson wrote: When printing values as hex strings, the telemetry code temporarily disabled warnings about non-literal format strings. This was because the

Re: [PATCH v4 0/5] support dmadev/ethdev stats reset

2023-02-08 Thread fengchengwen
On 2023/2/8 22:17, Bruce Richardson wrote: > On Fri, Jan 20, 2023 at 03:34:51AM +, Chengwen Feng wrote: >> This patchset contains dmadev/ethdev stats reset, and also support >> hide zero for ethdev xstats and two telemetry related bugs. >> >> Chengwen Feng (5): >> dmadev: support stats reset

Re: [PATCH v4 2/5] telemetry: fix repeat display when callback don't init dict

2023-02-08 Thread fengchengwen
On 2023/2/8 22:15, Bruce Richardson wrote: > On Fri, Jan 20, 2023 at 03:34:53AM +, Chengwen Feng wrote: >> When a telemetry callback doesn't initialize the telemetry data >> structure and returns a non-negative number, the telemetry will repeat >> to display the last result. This patch zero the

[PATCH] telemetry: fix repeat display when callback don't init dict

2023-02-08 Thread Chengwen Feng
When a telemetry callback doesn't initialize the telemetry data structure and returns a non-negative number, the telemetry will repeat to display the last result. This patch zero the data structure to avoid the problem. Fixes: 6dd571fd07c3 ("telemetry: introduce new functionality") Cc: sta...@dpdk

Re: [PATCH] telemetry: rework code to avoid compiler warnings

2023-02-08 Thread fengchengwen
Beatutiful +1 Acked-by: Chengwen Feng On 2023/2/8 22:37, Bruce Richardson wrote: > When printing values as hex strings, the telemetry code temporarily > disabled warnings about non-literal format strings. This was because the > actual format string was built-up programmatically to ensure the out

RE: [PATCH] eal: introduce atomics abstraction

2023-02-08 Thread Honnappa Nagarahalli
> > > > > > > > > > > > > > > > > For environments where stdatomics are not supported, we could > > > have a > > > > > stdatomic.h in DPDK implementing the same APIs (we have to > > > > > support > > > only > > > > > _explicit APIs). This allows the code to use stdatomics APIs and > > > when we m

Re: Outlook for DPDK multi-process support

2023-02-08 Thread Stephen Hemminger
On Wed, 8 Feb 2023 15:03:43 +0100 Lukáš Šišmiš wrote: > Hello all, > > > I'd like to ask you about future outlook of multi-process support in > DPDK (https://doc.dpdk.org/guides/prog_guide/multi_proc_support.html). > > On DPDK Userspace 2022, I have presented a solution that uses > multi-pro

Re: [PATCH] net/ice: fix ice dcf contrl thread crash

2023-02-08 Thread Stephen Hemminger
On Wed, 8 Feb 2023 16:30:05 +0800 Ke Zhang wrote: > + if (hw->vc_event_msg_cb == NULL) > + pthread_exit(NULL); Do we need rte_thread_exit() wrapper to be compatiable with Windows?

Re: [PATCH v13 1/6] memarea: introduce memarea library

2023-02-08 Thread Stephen Hemminger
On Wed, 8 Feb 2023 08:24:47 + Chengwen Feng wrote: > +RTE_LOG_REGISTER_DEFAULT(rte_memarea_logtype, INFO); > +#define RTE_MEMAREA_LOG(level, ...) \ > + rte_log(RTE_LOG_ ## level, rte_memarea_logtype, RTE_FMT("memarea: " \ > + RTE_FMT_HEAD(__VA_ARGS__,) "\n", RTE_FMT_TAIL(__VA_

Re: [PATCH 1/5] ip_frag: use a dynamic logtype

2023-02-08 Thread Konstantin Ananyev
08/02/2023 04:48, Stephen Hemminger пишет: DPDK libraries should not be reusing RTE_LOGTYPE_USER1 in lieu of doing proper logtype registration. Fixes: 416707812c03 ("ip_frag: refactor reassembly code into a proper library") Signed-off-by: Stephen Hemminger --- lib/ip_frag/ip_frag_common.h

Re: [PATCH v8] ethdev: add optimization hints in flow template table

2023-02-08 Thread Ferruh Yigit
On 2/2/2023 11:33 AM, Thomas Monjalon wrote: > 02/02/2023 12:19, Rongwei Liu: >> In case flow rules match only one kind of traffic in a flow table, >> then optimization can be done via allocation of this table. >> Such optimization is possible only if the application gives a hint >> about its usage

Re: [PATCH] app/testpmd: fix link check condition on port start

2023-02-08 Thread Ferruh Yigit
On 2/3/2023 9:56 AM, Singh, Aman Deep wrote: > > On 1/28/2023 4:15 AM, Ferruh Yigit wrote: >> In testpmd port start function, 'need_check_link_status' variable is >> used to detect if a link check is required after port is started. >> >> Intention is if at least one port is started, link check sho

Re: [PATCH v2] net/sfc: export pick transfer proxy callback to representors

2023-02-08 Thread Ferruh Yigit
On 1/31/2023 11:13 AM, Andrew Rybchenko wrote: > On 1/31/23 14:08, Ivan Malov wrote: >> Currently, the "pick transfer proxy ethdev" callback is only >> advertised for non-representor (in example, main PF) ethdevs. >> That does not sit well with the original idea of this method, >> which is to let a

[PATCH v2] mailmap: update mailmap entry for second address

2023-02-08 Thread Tyler Retzlaff
Signed-off-by: Tyler Retzlaff --- .mailmap | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.mailmap b/.mailmap index 5015494..9b5c507 100644 --- a/.mailmap +++ b/.mailmap @@ -1358,7 +1358,7 @@ Tsotne Chakhvadze Tudor Brindus Tudor Cornea Tummala Sivaprasad -Tyler Retzl

[PATCH v2] eal: introduce atomics abstraction

2023-02-08 Thread Tyler Retzlaff
Introduce atomics abstraction that permits optional use of standard C11 atomics when meson is provided the new enable_stdatomics=true option. Signed-off-by: Tyler Retzlaff --- config/meson.build | 11 lib/eal/arm/include/rte_atomic_32.h| 6 ++- lib/eal/arm/include/r

[PATCH v2] eal: abstract compiler atomics

2023-02-08 Thread Tyler Retzlaff
Introduce an abstraction for compiler specific atomics and a meson option to allow standard C11 atomics use. Note, this series does not attempt to convert to the use of the abstraction it only introduces it as per the plan discussed here. http://mails.dpdk.org/archives/dev/2023-January/258693.html

[PATCH v6 2/3] doc: add missing index entry for thread

2023-02-08 Thread Tyler Retzlaff
Add missing thread index referencing rte_thread.h under the basic topic. Signed-off-by: Tyler Retzlaff Reviewed-by: David Marchand --- doc/api/doxy-api-index.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/doc/api/doxy-api-index.md b/doc/api/doxy-api-index.md index de48

[PATCH v6 0/3] eal: deprecate last use of pthread_t in public API

2023-02-08 Thread Tyler Retzlaff
Announce deprecation of rte_ctrl_thread_create API which is the final remaining stable API exposing pthread_t. Provide an equivalent replacement API rte_thread_create_control that uses the new rte_thread_t type. Provide a unit test for the new rte_thread_create_control API (test code provided by

[PATCH v6 1/3] eal: add rte thread create control API

2023-02-08 Thread Tyler Retzlaff
Add rte_thread_create_control API as a replacement for rte_ctrl_thread_create to allow deprecation of the use of platform specific types in DPDK public API. Add test from David Marchand to exercise the new API. Signed-off-by: Tyler Retzlaff Acked-by: Morten Brørup Reviewed-by: Mattias Rönnblom

[PATCH v6 3/3] doc: announce deprecation of thread ctrl create function

2023-02-08 Thread Tyler Retzlaff
Notify deprecation of rte_ctrl_thread_create API, it will be removed as it exposes platform-specific thread details. Signed-off-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: David Marchand Reviewed-by: Mattias Rönnblom --- doc/guides/rel_notes/deprecation.rst | 8 1 file chang

RE: [PATCH v1 13/13] test/bbdev: remove iteration count check

2023-02-08 Thread Vargas, Hernan
Hi Maxime, We would like to keep the same signature for validate_dec_op because there are functions such as latency_test_dec that have vector_mask on their signatures and they pass it to validate_dec_op. Let me know if you'd like to discuss more. Thanks, Hernan -Original Message- From:

Re: [PATCH v5] ethdev: add flow rule group description

2023-02-08 Thread Ferruh Yigit
On 2/7/2023 2:57 AM, Rongwei Liu wrote: > Add more sentences to describe the group concepts > and define group 0 as root group for traffic to search a > hit rule. > > Signed-off-by: Rongwei Liu > Acked-by: Ori Kam > --- > lib/ethdev/rte_flow.h | 13 - > 1 file changed, 12 insertions

Re: [PATCH v11 0/6] add trace points in ethdev library

2023-02-08 Thread Ferruh Yigit
On 2/8/2023 5:12 PM, Ankur Dwivedi wrote: > This series adds trace points for functions in the ethdev library. > The trace points are added in ethdev, flow, mtr and tm files. > > v11: > - Added rte_trace_point_emit_blob to capture mac address list in >rte_ethdev_trace_set_mc_addr_list tracepo

Re: [PATCH v11 3/6] ethdev: add trace points for ethdev (part two)

2023-02-08 Thread Ferruh Yigit
On 2/8/2023 5:12 PM, Ankur Dwivedi wrote: > Adds trace points for remaining ethdev functions. > > Signed-off-by: Ankur Dwivedi > Acked-by: Sunil Kumar Kori Reviewed-by: Ferruh Yigit

Re: [PATCH v3] net/af_xdp: AF_XDP PMD CNI Integration

2023-02-08 Thread Ferruh Yigit
On 2/2/2023 4:55 PM, Shibin Koikkara Reeny wrote: > Integrate support for the AF_XDP CNI and device plugin [1] so that the > DPDK AF_XDP PMD can work in an unprivileged container environment. > Part of the AF_XDP PMD initialization process involves loading > an eBPF program onto the given netdev. T

Re: [PATCH] bnxt: fix unwanted interrupt config on link state change

2023-02-08 Thread Ajit Khaparde
On Mon, Feb 6, 2023 at 9:44 PM Somnath Kotur wrote: > > On Mon, Feb 6, 2023 at 10:44 PM wrote: > > > > From: Edwin Brossette > > > > When getting the device's info via bnxt_dev_info_get_op(), the device > > enables interrupts on link state changes because of the following line: > > > > > eth_d

Re: [PATCH] build: fix invalid characters in toolchain definitions

2023-02-08 Thread Tyler Retzlaff
On Tue, Feb 07, 2023 at 03:22:00PM +, Bruce Richardson wrote: > When using "icx" (Intel(R) oneAPI DPC++/C++ Compiler) to build DPDK, > meson reports the toolchain as "intel-llvm"[1]. This value is used > directly to define the RTE_TOOLCHAIN macros, which means that we end up > with the invalid

Re: [PATCH V3 00/10] net/hns3: some bugfixes for rss

2023-02-08 Thread Ferruh Yigit
On 1/31/2023 1:02 PM, Dongdong Liu wrote: > This patchset is to do some bugfixes for hns3 rss. > > v2->v3: > - Fix segmentation fault when key_len is 40 and key is NULL for > [PATCH V2 09/10]. > > v1->v2: > - Fix missing comparison of types and level when verifying duplicate > rules for [PATC

RE: [PATCH 1/3] examples/l3fwd: validate ptype only for type of traffic sent

2023-02-08 Thread Kamalakshitha Aligeri
Hi all, Can you please check the patch and provide comments? Thanks, Kamalakshitha > -Original Message- > From: Kamalakshitha Aligeri > Sent: Monday, November 14, 2022 1:26 PM > To: jer...@marvell.com; tho...@monjalon.net; > david.march...@redhat.com > Cc: dev@dpdk.org; nd ; Kamalakshith

[PATCH v11 6/6] ethdev: add trace points for tm

2023-02-08 Thread Ankur Dwivedi
Adds trace points for rte_tm specific functions in ethdev lib. Signed-off-by: Ankur Dwivedi --- lib/ethdev/ethdev_trace.h| 304 +++ lib/ethdev/ethdev_trace_points.c | 90 + lib/ethdev/rte_tm.c | 225 --- 3 files change

[PATCH v11 5/6] ethdev: add trace points for mtr

2023-02-08 Thread Ankur Dwivedi
Adds trace points for rte_mtr specific functions in ethdev lib. Signed-off-by: Ankur Dwivedi Acked-by: Sunil Kumar Kori --- lib/ethdev/ethdev_trace.h| 206 +++ lib/ethdev/ethdev_trace_points.c | 63 ++ lib/ethdev/rte_mtr.c | 150 +

[PATCH v11 4/6] ethdev: add trace points for flow

2023-02-08 Thread Ankur Dwivedi
Adds trace points for rte_flow specific functions in ethdev lib. Signed-off-by: Ankur Dwivedi Acked-by: Ori Kam --- lib/ethdev/ethdev_trace.h| 503 +++ lib/ethdev/ethdev_trace_points.c | 117 +++ lib/ethdev/rte_flow.c| 356 +---

[PATCH v11 3/6] ethdev: add trace points for ethdev (part two)

2023-02-08 Thread Ankur Dwivedi
Adds trace points for remaining ethdev functions. Signed-off-by: Ankur Dwivedi Acked-by: Sunil Kumar Kori --- lib/ethdev/ethdev_trace.h| 877 +++ lib/ethdev/ethdev_trace_points.c | 252 + lib/ethdev/rte_ethdev.c | 485 ++--- lib/e

[PATCH v11 2/6] ethdev: add trace points for ethdev (part one)

2023-02-08 Thread Ankur Dwivedi
Adds trace points for ethdev functions. The rte_ethdev_trace.h is removed. The file ethdev_trace.h is added as an internal header. ethdev_trace.h contains internal slow path and fast path tracepoints. The public fast path tracepoints are present in rte_ethdev_trace_fp.h header. Signed-off-by: Ank

[PATCH v11 1/6] eal: trace: add trace point emit for blob

2023-02-08 Thread Ankur Dwivedi
Adds a trace point emit function for capturing a blob. The blob captures the length passed by the application followed by the array. The maximum blob bytes which can be captured is bounded by RTE_TRACE_BLOB_LEN_MAX macro. The value for max blob length macro is 64 bytes. If the length is less than

[PATCH v11 0/6] add trace points in ethdev library

2023-02-08 Thread Ankur Dwivedi
This series adds trace points for functions in the ethdev library. The trace points are added in ethdev, flow, mtr and tm files. v11: - Added rte_trace_point_emit_blob to capture mac address list in rte_ethdev_trace_set_mc_addr_list tracepoint. - Added ack by Ori in patch (4/6) ethdev: add

Re: [PATCH] build: fix invalid characters in toolchain definitions

2023-02-08 Thread Bruce Richardson
On Tue, Feb 07, 2023 at 03:22:00PM +, Bruce Richardson wrote: > When using "icx" (Intel(R) oneAPI DPC++/C++ Compiler) to build DPDK, > meson reports the toolchain as "intel-llvm"[1]. This value is used > directly to define the RTE_TOOLCHAIN macros, which means that we end up > with the invalid

Re: [PATCH] doc: add supported APIs section to nfp guide

2023-02-08 Thread Niklas Soderlund
Hello Ajit, On 2023-01-24 09:13:20 +, Ferruh Yigit wrote: > On 1/24/2023 2:44 AM, Chaoyong He wrote: > >> On 12/1/2022 1:38 AM, Chaoyong He wrote: > >>> Add a new section 'Supported APIs', inculding the supported > >>> APIs/items/actions of rte_flow. > >>> > >> > >> Isn't this information alre

Re: [PATCH v9 1/5] eal: add lcore info in telemetry

2023-02-08 Thread Robin Jarry
Hi lihuisong, lihuisong (C), Feb 08, 2023 at 03:24: > > static int > > lcore_dump_cb(unsigned int lcore_id, void *arg) > > { > > struct rte_config *cfg = rte_eal_get_configuration(); > > char cpuset[RTE_CPU_AFFINITY_STR_LEN]; > > - const char *role; > > FILE *f = arg; > > i

Re: [PATCH v2] app/testpmd: expand noisy neighbour forward mode support

2023-02-08 Thread Singh, Aman Deep
On 2/2/2023 12:33 AM, Mike Pattrick wrote: On Wed, Feb 1, 2023 at 10:19 AM Singh, Aman Deep wrote: Hi Mike, Thanks a lot for the patch. On 1/26/2023 10:25 AM, Mike Pattrick wrote: Previously the noisy neighbour vnf simulation would only operate in io mode, forwarding packets as is. However

Re: [PATCH] eal: introduce atomics abstraction

2023-02-08 Thread Tyler Retzlaff
On Wed, Feb 08, 2023 at 09:31:32AM +0100, Morten Brørup wrote: > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > > Sent: Wednesday, 8 February 2023 02.21 > > > > On Tue, Feb 07, 2023 at 11:34:14PM +, Honnappa Nagarahalli wrote: > > > > > > > > > > > > > > > > > > Honnappa, plea

RE: [PATCH v10 4/6] ethdev: add trace points for flow

2023-02-08 Thread Ori Kam
Hi Ankur, > -Original Message- > From: Ankur Dwivedi > Sent: Wednesday, 8 February 2023 15:28 > > Adds trace points for rte_flow specific functions in ethdev lib. > > Signed-off-by: Ankur Dwivedi > --- Acked-by: Ori Kam Best, Ori

Re: [PATCH] build: fix invalid characters in toolchain definitions

2023-02-08 Thread Wiles, Keith
From: Richardson, Bruce Sent: Tuesday, February 7, 2023 9:22 AM To: dev@dpdk.org Cc: Richardson, Bruce; sta...@dpdk.org; Wiles, Keith Subject: [PATCH] build: fix invalid characters in toolchain definitions When using "icx" (Intel(R) oneAPI DPC++/C++ Compil

RE: [EXT] Re: [PATCH v9 3/6] ethdev: add trace points for ethdev (part two)

2023-02-08 Thread Ankur Dwivedi
>Subject: Re: [EXT] Re: [PATCH v9 3/6] ethdev: add trace points for ethdev (part >two) > >On 2/8/2023 2:15 PM, Ankur Dwivedi wrote: >>> Subject: Re: [EXT] Re: [PATCH v9 3/6] ethdev: add trace points for >>> ethdev (part >>> two) >>> >>> On 2/8/2023 11:00 AM, Ferruh Yigit wrote: On 2/8/2023 10:

Re: [EXT] Re: [PATCH v9 3/6] ethdev: add trace points for ethdev (part two)

2023-02-08 Thread Ferruh Yigit
On 2/8/2023 2:15 PM, Ankur Dwivedi wrote: >> Subject: Re: [EXT] Re: [PATCH v9 3/6] ethdev: add trace points for ethdev >> (part >> two) >> >> On 2/8/2023 11:00 AM, Ferruh Yigit wrote: >>> On 2/8/2023 10:42 AM, Ankur Dwivedi wrote: >> +RTE_TRACE_POINT( >> +rte_ethdev_trace_set_mc_ad

Re: [PATCH] telemetry: rework code to avoid compiler warnings

2023-02-08 Thread Wiles, Keith
From: Bruce Richardson Sent: Wednesday, February 8, 2023 8:37 AM To: dev@dpdk.org Cc: Huisong Li; Chengwen Feng; Morten Brørup; Richardson, Bruce Subject: [PATCH] telemetry: rework code to avoid compiler warnings When printing values as hex strings, the telemetry code temporarily disabled warning

RE: [PATCH] telemetry: rework code to avoid compiler warnings

2023-02-08 Thread Morten Brørup
> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Wednesday, 8 February 2023 15.38 > To: dev@dpdk.org > Cc: Huisong Li; Chengwen Feng; Morten Brørup; Bruce Richardson > Subject: [PATCH] telemetry: rework code to avoid compiler warnings > > When printing values as hex strings, th

[PATCH] telemetry: rework code to avoid compiler warnings

2023-02-08 Thread Bruce Richardson
When printing values as hex strings, the telemetry code temporarily disabled warnings about non-literal format strings. This was because the actual format string was built-up programmatically to ensure the output was of the desired bitwidth. However, this code can be reworked and shortened by taki

RE: [EXT] Re: [PATCH v9 3/6] ethdev: add trace points for ethdev (part two)

2023-02-08 Thread Ankur Dwivedi
>Subject: Re: [EXT] Re: [PATCH v9 3/6] ethdev: add trace points for ethdev (part >two) > >On 2/8/2023 11:00 AM, Ferruh Yigit wrote: >> On 2/8/2023 10:42 AM, Ankur Dwivedi wrote: > +RTE_TRACE_POINT( > + rte_ethdev_trace_set_mc_addr_list, > + RTE_TRACE_POINT_ARGS(uint16_t port_id, > +

Re: [PATCH v4 0/5] support dmadev/ethdev stats reset

2023-02-08 Thread Bruce Richardson
On Fri, Jan 20, 2023 at 03:34:51AM +, Chengwen Feng wrote: > This patchset contains dmadev/ethdev stats reset, and also support > hide zero for ethdev xstats and two telemetry related bugs. > > Chengwen Feng (5): > dmadev: support stats reset telemetry command > telemetry: fix repeat displ

Re: [PATCH v4 2/5] telemetry: fix repeat display when callback don't init dict

2023-02-08 Thread Bruce Richardson
On Fri, Jan 20, 2023 at 03:34:53AM +, Chengwen Feng wrote: > When a telemetry callback doesn't initialize the telemetry data > structure and returns a non-negative number, the telemetry will repeat > to display the last result. This patch zero the data structure to avoid > the problem. > > Fix

Outlook for DPDK multi-process support

2023-02-08 Thread Lukáš Šišmiš
Hello all, I'd like to ask you about future outlook of multi-process support in DPDK (https://doc.dpdk.org/guides/prog_guide/multi_proc_support.html). On DPDK Userspace 2022, I have presented a solution that uses multi-process support (https://youtu.be/TtiR74w3Yv4) in Suricata IDS. But aft

[PATCH v10 6/6] ethdev: add trace points for tm

2023-02-08 Thread Ankur Dwivedi
Adds trace points for rte_tm specific functions in ethdev lib. Signed-off-by: Ankur Dwivedi --- lib/ethdev/ethdev_trace.h| 304 +++ lib/ethdev/ethdev_trace_points.c | 90 + lib/ethdev/rte_tm.c | 225 --- 3 files change

[PATCH v10 5/6] ethdev: add trace points for mtr

2023-02-08 Thread Ankur Dwivedi
Adds trace points for rte_mtr specific functions in ethdev lib. Signed-off-by: Ankur Dwivedi Acked-by: Sunil Kumar Kori --- lib/ethdev/ethdev_trace.h| 206 +++ lib/ethdev/ethdev_trace_points.c | 63 ++ lib/ethdev/rte_mtr.c | 150 +

[PATCH v10 4/6] ethdev: add trace points for flow

2023-02-08 Thread Ankur Dwivedi
Adds trace points for rte_flow specific functions in ethdev lib. Signed-off-by: Ankur Dwivedi --- lib/ethdev/ethdev_trace.h| 503 +++ lib/ethdev/ethdev_trace_points.c | 117 +++ lib/ethdev/rte_flow.c| 356 +- 3 files changed

[PATCH v10 3/6] ethdev: add trace points for ethdev (part two)

2023-02-08 Thread Ankur Dwivedi
Adds trace points for remaining ethdev functions. Signed-off-by: Ankur Dwivedi Acked-by: Sunil Kumar Kori --- lib/ethdev/ethdev_trace.h| 875 +++ lib/ethdev/ethdev_trace_points.c | 252 + lib/ethdev/rte_ethdev.c | 485 ++--- lib/e

[PATCH v10 2/6] ethdev: add trace points for ethdev (part one)

2023-02-08 Thread Ankur Dwivedi
Adds trace points for ethdev functions. The rte_ethdev_trace.h is removed. The file ethdev_trace.h is added as an internal header. ethdev_trace.h contains internal slow path and fast path tracepoints. The public fast path tracepoints are present in rte_ethdev_trace_fp.h header. Signed-off-by: Ank

[PATCH v10 1/6] eal: trace: add trace point emit for blob

2023-02-08 Thread Ankur Dwivedi
Adds a trace point emit function for capturing a blob. The blob captures the length passed by the application followed by the array. The maximum blob bytes which can be captured is bounded by RTE_TRACE_BLOB_LEN_MAX macro. The value for max blob length macro is 64 bytes. If the length is less than

[PATCH v10 0/6] add trace points in ethdev library

2023-02-08 Thread Ankur Dwivedi
This series adds trace points for functions in the ethdev library. The trace points are added in ethdev, flow, mtr and tm files. v10: - Removed const in basic types in tracepoint. - Removed capture of pointer value where some fields in structure are captured. - Resolved RHEL 7 failure: ..

Re: [PATCH v2] net/memif: default to physical socket

2023-02-08 Thread Nathan Skrzypczak
Hi Ferruh, Sorry for the late reply, You can probably drop this patch. Kind regards, -Nathan Le ven. 9 déc. 2022 à 16:13, Ferruh Yigit a écrit : > On 12/8/2022 11:24 AM, Nathan Skrzypczak wrote: > > Hi Stephen, Hi Ferruh, > > > > I don't have a strong opinion on usage of regular sockets vs abs

Re: [PATCH] Intel iavf: Return in the case of ADD/DEL ETH address

2023-02-08 Thread Vipin P R
From: Zhang, Qi Z Sent: 17 January 2023 07:24 To: Vipin P R ; Wu, Jingjing ; Xing, Beilei Cc: dev@dpdk.org ; sta...@dpdk.org Subject: RE: [PATCH] Intel iavf: Return in the case of ADD/DEL ETH address !! External Email > -Original Message- > From: Vip

Re: net/bnxt: wrong link status when lsc_intr is used

2023-02-08 Thread Edwin Brossette
Hello, Thank you for your quick answer. This was added long back in the driver code by this commit (as you can > see 6+ yrs old :)) , so I believe at the time the intent was to get > this link notification asynchronous > and 'lsc' I believe was for link state change? Please suggest an > alternat

Re: [PATCH] acl: fix trie splitting

2023-02-08 Thread Arthur Leung
Hi Konstantin Thanks for the explanation and examples, I see I've misunderstood "node limit for tree split" to mean "the limit of the total number of nodes in a tree", rather than the intended logic of "the limit of new nodes that can be created in a trie as a result of merging". Sorry for the bo

Re: [PATCH] telemetry: reset data before passing it to callback

2023-02-08 Thread Robin Jarry
Bruce Richardson, Feb 08, 2023 at 10:03: > This is also fixed by patch > http://patches.dpdk.org/project/dpdk/patch/20230120033456.29710-3-fengcheng...@huawei.com/ > > While both work the same way, I think I prefer the fix to set "= {0}" on > init rather than explicit memset. Oh I had missed that

RE: no printf in drivers code

2023-02-08 Thread Hemant Agrawal
Hi Thomas, On 2023-02-03 14:57:06 +0100, Thomas Monjalon wrote: > Hello, > > > > We have too many drivers using printf() instead of rte_log(). > > Please propose a plan to replace or remove the calls to printf(). > > If no plan, I could propose one but you may not like it :) > > > > Affected d

Re: [PATCH v2 00/10] Wangxun fixes and new supports

2023-02-08 Thread Ferruh Yigit
On 2/2/2023 9:21 AM, Jiawen Wu wrote: > Fix some bugs and support to process more interrupt events. > > v2: > - fix buffer size less than 1K > - fix c99 comment syntax ('//') > - remove useless parameter 'ptype' > - expand commit log for packet type > - separate the interrupt disable fix to anothe

RE: [PATCH v2 1/9] ethdev: sharing indirect actions between ports

2023-02-08 Thread Ori Kam
Hi Slava > -Original Message- > From: Slava Ovsiienko > Sent: Tuesday, 7 February 2023 16:02 > > The RTE Flow API implements the concept of shared objects, > known as indirect actions (RTE_FLOW_ACTION_TYPE_INDIRECT). > An application can create the indirect action of desired > type and

Re: [PATCH] bus: fix leak for devices without driver

2023-02-08 Thread Kevin Laatz
Hi Volodymyr, On 07/01/2023 15:12, Volodymyr Fialko wrote: For devices not assigned to any driver, we leak a pci device object since it is never freed from the PCI bus device list, reported by ASAN. Fixes: 1cab1a40ea9b ("bus: cleanup devices on shutdown") Signed-off-by: Volodymyr Fialko ---

RE: [PATCH v2 1/3] examples/power: remove empty poll mode from l3fwd-power

2023-02-08 Thread Pattan, Reshma
> -Original Message- > From: Hunt, David > > Signed-off-by: David Hunt > --- Acked-By: Reshma Pattan

Re: [EXT] Re: [PATCH v9 3/6] ethdev: add trace points for ethdev (part two)

2023-02-08 Thread Ferruh Yigit
On 2/8/2023 11:00 AM, Ferruh Yigit wrote: > On 2/8/2023 10:42 AM, Ankur Dwivedi wrote: +RTE_TRACE_POINT( + rte_ethdev_trace_set_mc_addr_list, + RTE_TRACE_POINT_ARGS(uint16_t port_id, + const struct rte_ether_addr *mc_addr_set, uint32_t >>> nb_mc_addr, +

  1   2   >