On 2023/2/8 22:17, Bruce Richardson wrote: > On Fri, Jan 20, 2023 at 03:34:51AM +0000, Chengwen Feng wrote: >> This patchset contains dmadev/ethdev stats reset, and also support >> hide zero for ethdev xstats and two telemetry related bugs. >> >> Chengwen Feng (5): >> dmadev: support stats reset telemetry command >> telemetry: fix repeat display when callback don't init dict >> ethdev: add newline to telemetry log string >> ethdev: support xstats reset telemetry command >> ethdev: telemetry xstats support hide zero >> > On one level, I can understand how this may be useful, but on the other > side, we also support having multiple different clients connecting to > telemetry simultaneously. Would it not be problematic to have stats > suddenly being reset by one connection without the others being aware of > it?
It's a problem. Anyone who can connect can execute the commands. For this modify case, I suggest adding LOG for later refer. and will fix in V5. Thanks. > > /Bruce > . >
