On Tue, Feb 07, 2023 at 03:22:00PM +0000, Bruce Richardson wrote: > When using "icx" (Intel(R) oneAPI DPC++/C++ Compiler) to build DPDK, > meson reports the toolchain as "intel-llvm"[1]. This value is used > directly to define the RTE_TOOLCHAIN macros, which means that we end up > with the invalid macro name "RTE_TOOLCHAIN_INTEL-LLVM", and getting the > compiler warning: > > ./rte_build_config.h:422:28: warning: ISO C99 requires whitespace after the > macro name [-Wc99-extensions] > > This can be fixed, and the macro generation made more robust generally, > by adding "underscorify()" on the string. This replaces the "-", and > any other invalid characters, with "_" [2]. > > [1] https://mesonbuild.com/Reference-tables.html#compiler-ids > [2] > https://mesonbuild.com/Reference-manual_elementary_str.html#strunderscorify > > Fixes: afd18fa21b5e ("build: set toolchain info during meson configure") > Cc: sta...@dpdk.org > > Reported-by: Keith Wiles <keith.wi...@intel.com> > Signed-off-by: Bruce Richardson <bruce.richard...@intel.com> > ---
Resending Keith's ack, since patchwork doesn't seem to have picked it up from Keith's email. Acked-by: Keith Wiles <keith.wi...@intel.com>
