Re: [PATCH] vhost: enable CONFIG feature

2022-09-15 Thread ho...@yusur.tech
On Tue, Sep 13, 2022 at 17:55 PM Hao Chen wrote: >From: Hao Chen >Date: 2022-09-13 17:55 >To: maxime.coquelin; chenbo.xia >CC: dev; houyl; zy; Hao Chen >Subject: [PATCH] vhost: enable CONFIG feature >Enable this feature, so that libvirt or qemu can call vdpa vendor >driver's op

[PATCH v3 8/8] vhost: improve vDPA blk device readiness condition

2022-09-15 Thread Andy Pei
In the virtio blk vDPA live migration use case, for the target VM, before the live migration process, QEMU will set call fd to all queues of vDPA back-end. QEMU and vDPA back-end stand by until live migration starts. During live migration process, QEMU sets kick fd and new call fd. However, after t

[PATCH v3 7/8] vhost: vDPA blk device gets ready when any queue is ready

2022-09-15 Thread Andy Pei
When boot from virtio blk device, seabios in QEMU only enables one queue. To work in this scenario, vDPA BLK device back-end conf_dev when any queue is ready. Signed-off-by: Andy Pei Signed-off-by: Huang Wei --- lib/vhost/vhost_user.c | 51 -- 1 f

[PATCH v3 6/8] vdpa/ifc: support dynamic enable/disable queue

2022-09-15 Thread Andy Pei
From: Huang Wei Support dynamic enable or disable queue. For front end, like QEMU, user can use ethtool to configurate queue. For example, "ethtool -L eth0 combined 3" to enable 3 queues pairs. Signed-off-by: Huang Wei Signed-off-by: Andy Pei --- drivers/vdpa/ifc/base/ifcvf.c | 99 +++

[PATCH v3 5/8] vdpa/ifc: only configure enabled queue

2022-09-15 Thread Andy Pei
when configure the hardware queue, we only configure queues which have been enabled by vhost. Signed-off-by: Andy Pei Signed-off-by: Huang Wei --- drivers/vdpa/ifc/base/ifcvf.c | 3 +++ drivers/vdpa/ifc/ifcvf_vdpa.c | 16 ++-- 2 files changed, 17 insertions(+), 2 deletions(-) diff

[PATCH v3 4/8] vdpa/ifc: write queue count to MQ register

2022-09-15 Thread Andy Pei
Write queue count to IFCVF_MQ_OFFSET register to enable multi queue feature. Signed-off-by: Andy Pei Signed-off-by: Huang Wei --- drivers/vdpa/ifc/base/ifcvf.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/drivers/vdpa/ifc/base/ifcvf.c b/drivers/vdpa/ifc/ba

[PATCH v3 3/8] vdpa/ifc: set max queues based on virtio spec

2022-09-15 Thread Andy Pei
Set max_queues according to virtio HW spec. For virtio BLK device, set max_queues to the value of "num_queues". "num_queues" is element of struct virtio_blk_config. For virtio NET device, read num_queues from truct ifcvf_pci_common_cfg, calculate "queue_pairs = (num_queues - 1) / 2" and get queue_p

[PATCH v3 2/8] vdpa/ifc: add multi-queue support

2022-09-15 Thread Andy Pei
Enable VHOST_USER_PROTOCOL_F_MQ feature. Expose IFCVF_MQ_OFFSET register to enable multi queue. Signed-off-by: Andy Pei Signed-off-by: Huang Wei --- drivers/vdpa/ifc/base/ifcvf.c | 5 + drivers/vdpa/ifc/base/ifcvf.h | 2 ++ drivers/vdpa/ifc/ifcvf_vdpa.c | 1 + 3 files changed, 8 insertions(

[PATCH v3 1/8] vdpa/ifc: add new device ID for legacy network device

2022-09-15 Thread Andy Pei
From: Huang Wei Add new device id to support IFCVF_NET_TRANSITIONAL_DEVICE_ID (0x1000). Rename macro from "IFCVF_BLK_DEVICE_ID" to "IFCVF_SUBSYS_BLK_DEVICE_ID". Signed-off-by: Huang Wei Signed-off-by: Andy Pei --- drivers/vdpa/ifc/base/ifcvf.h | 6 -- drivers/vdpa/ifc/ifcvf_vdpa.c | 13 +

[PATCH v3 0/8] vdpa/ifc: add multi queue support

2022-09-15 Thread Andy Pei
v3: rename device ID macro name. fix some patch title and commit message. delete some used marco. rework some code logic. v2: fix some coding style issue. support dynamic enable/disable queue at run time. Andy Pei (6): vdpa/ifc: add multi-queue support vdpa/ifc: set max queues based on

RE: [PATCH 1/3] eventdev/eth_tx: add queue start stop API

2022-09-15 Thread Jayatheerthan, Jay
> -Original Message- > From: Jerin Jacob > Sent: Wednesday, September 14, 2022 8:51 PM > To: Naga Harish K, S V > Cc: Jayatheerthan, Jay ; jer...@marvell.com; > dev@dpdk.org > Subject: Re: [PATCH 1/3] eventdev/eth_tx: add queue start stop API > > On Fri, Sep 9, 2022 at 9:12 AM Naga Hari

RE: [PATCH 1/3] eventdev/eth_tx: add queue start stop API

2022-09-15 Thread Naga Harish K, S V
> -Original Message- > From: Jerin Jacob > Sent: Wednesday, September 14, 2022 8:51 PM > To: Naga Harish K, S V > Cc: Jayatheerthan, Jay ; jer...@marvell.com; > dev@dpdk.org > Subject: Re: [PATCH 1/3] eventdev/eth_tx: add queue start stop API > > On Fri, Sep 9, 2022 at 9:12 AM Naga Har

RE: [PATCH v7 2/3] timer: fix function to stop all timers

2022-09-15 Thread Naga Harish K, S V
> -Original Message- > From: Jerin Jacob > Sent: Thursday, September 15, 2022 12:12 PM > To: Naga Harish K, S V ; Thomas Monjalon > > Cc: jer...@marvell.com; dev@dpdk.org; Carrillo, Erik G > ; pbhagavat...@marvell.com; > sthot...@marvell.com; sta...@dpdk.org > Subject: Re: [PATCH v7 2/3

Re: Cannot set affinity - pthread_setaffinity_np - DPDK21

2022-09-15 Thread Kamaraj P
Hi Team, Have sent a message to DPDK alias. Can you please have a look and share your thoughts on this ? Thanks, Kamaraj On Thu, Sep 15, 2022 at 10:27 PM Kamaraj P wrote: > Hi Team, > > There are lot of discussion about below code: > rte_panic("Cannot set affinity %d i %d threadid %d\n", ret,

[PATCH v5 2/2] test/member: add functional and perf tests for sketch

2022-09-15 Thread Leyi Rong
This patch adds functional and performance tests for sketch mode of membership library. Signed-off-by: Yipeng Wang Signed-off-by: Leyi Rong --- app/test/test_member.c | 272 app/test/test_member_perf.c | 153 +++- 2 files changed, 421 in

[PATCH v5 1/2] member: implement NitroSketch mode

2022-09-15 Thread Leyi Rong
Sketching algorithm provide high-fidelity approximate measurements and appears as a promising alternative to traditional approaches such as packet sampling. NitroSketch [1] is a software sketching framework that optimizes performance, provides accuracy guarantees, and supports a variety of sketche

[PATCH v5 0/2] introduce NitroSketch Mode into membership library

2022-09-15 Thread Leyi Rong
This patchset introduce a brand new NitroSketch Mode into membership library. This algorithm provides high-fidelity approximate measurements and appears as a promissing alternative to triditional approches such as packet sampling. --- v5: - meson.build rework. v4: - remove extra avx512 complier f

RE: [PATCH v4 1/2] member: implement NitroSketch mode

2022-09-15 Thread Rong, Leyi
Hi Bruce, The comments will be addressed in v5, thank you! > -Original Message- > From: Richardson, Bruce > Sent: Thursday, September 15, 2022 10:13 PM > To: Rong, Leyi > Cc: ferruh.yi...@xilinx.com; david.march...@redhat.com; > suanmi...@nvidia.com; Wang, Yipeng1 ; > zaoxing...@gmail.c

[PATCH v3 13/13] baseband/acc: simplify meson dependency

2022-09-15 Thread Nic Chautru
Removing some of libraries from the external dependency captured in meson build file. Signed-off-by: Nic Chautru --- drivers/baseband/acc/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/baseband/acc/meson.build b/drivers/baseband/acc/meson.build index 7ae1

[PATCH v3 11/13] baseband/acc200: add PF configure companion function

2022-09-15 Thread Nic Chautru
From: Nicolas Chautru Add configure function notably to configure the device from the PF within DPDK and bbdev-test (without external dependency). Signed-off-by: Nicolas Chautru --- app/test-bbdev/meson.build | 3 + app/test-bbdev/test_bbdev_perf.c | 76 ++ drivers

[PATCH v3 10/13] baseband/acc200: add device status and vf2pf comms

2022-09-15 Thread Nic Chautru
From: Nicolas Chautru Add support to expose the device status seen from the host through v2pf mailbox communication. Signed-off-by: Nicolas Chautru --- drivers/baseband/acc200/rte_acc200_pmd.c | 61 +++- 1 file changed, 44 insertions(+), 17 deletions(-) diff --git

[PATCH v3 09/13] baseband/acc200: support interrupt

2022-09-15 Thread Nic Chautru
From: Nicolas Chautru Adding support for capability and functions for MSI/MSI-X interrupt and underlying information ring. Signed-off-by: Nicolas Chautru --- drivers/baseband/acc200/rte_acc200_pmd.c | 346 ++- 1 file changed, 344 insertions(+), 2 deletions(-) diff

[PATCH v3 08/13] baseband/acc200: add support for FFT operations

2022-09-15 Thread Nic Chautru
From: Nicolas Chautru Add functions and capability for FFT processing Signed-off-by: Nicolas Chautru --- drivers/baseband/acc200/rte_acc200_pmd.c | 251 ++- 1 file changed, 249 insertions(+), 2 deletions(-) diff --git a/drivers/baseband/acc200/rte_acc200_pmd.c b/d

[PATCH v3 07/13] baseband/acc200: add LTE processing functions

2022-09-15 Thread Nic Chautru
From: Nicolas Chautru Add functions and capability for 4G FEC Signed-off-by: Nicolas Chautru --- drivers/baseband/acc200/rte_acc200_pmd.c | 894 ++- 1 file changed, 874 insertions(+), 20 deletions(-) diff --git a/drivers/baseband/acc200/rte_acc200_pmd.c b/drivers/

[PATCH v3 06/13] baseband/acc200: add LDPC processing functions

2022-09-15 Thread Nic Chautru
From: Nicolas Chautru Adding LDPC encode and decode processing functions. Signed-off-by: Nicolas Chautru --- drivers/baseband/acc200/rte_acc200_pmd.c | 1526 +- 1 file changed, 1522 insertions(+), 4 deletions(-) diff --git a/drivers/baseband/acc200/rte_acc200_pmd.c

[PATCH v3 05/13] baseband/acc200: add queue configuration

2022-09-15 Thread Nic Chautru
From: Nicolas Chautru Adding fuinction to create and configure queues for the device. Signed-off-by: Nicolas Chautru --- drivers/baseband/acc200/rte_acc200_pmd.c | 373 ++- 1 file changed, 372 insertions(+), 1 deletion(-) diff --git a/drivers/baseband/acc200/rte_ac

[PATCH v3 04/13] baseband/acc200: add info get function

2022-09-15 Thread Nic Chautru
From: Nicolas Chautru Add support for info_get to allow to query the device. Null capability exposed. Signed-off-by: Nicolas Chautru --- drivers/baseband/acc200/acc200_pmd.h | 1 + drivers/baseband/acc200/rte_acc200_cfg.h | 27 drivers/baseband/acc200/rte_acc200_pmd.c | 239 +++

[PATCH v3 03/13] baseband/acc200: add HW register definitions

2022-09-15 Thread Nic Chautru
From: Nicolas Chautru Add registers list and structure to access the device. Signed-off-by: Nicolas Chautru --- drivers/baseband/acc200/acc200_pf_enum.h | 108 drivers/baseband/acc200/acc200_pmd.h | 163 +++ drivers/baseband/acc200/acc200_vf

[PATCH v3 02/13] baseband/acc200: introduce PMD for ACC200

2022-09-15 Thread Nic Chautru
From: Nicolas Chautru This patch introduce stubs for device driver for the ACC200 integrated VRAN accelerator on SPR-EEC Signed-off-by: Nicolas Chautru --- MAINTAINERS | 3 + doc/guides/bbdevs/acc200.rst | 244 +++ doc/guid

From: Nic Chautru

2022-09-15 Thread Nic Chautru
v3: New commit to combine in same folder the ACC100 and ACC200 PMDS. Also simplifying the meson dependency and fixing typos. v2: Includes now code refactory to have common structures and code reused with the parallel ACC1XX serie PMD which can be shared moving forward. v1: This is targeting 22.11

RE: [PATCH v2 15/37] baseband/acc100: add workaround for deRM corner cases

2022-09-15 Thread Chautru, Nicolas
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Thursday, September 15, 2022 1:15 AM > To: Vargas, Hernan ; dev@dpdk.org; > gak...@marvell.com; t...@redhat.com > Cc: Chautru, Nicolas ; Zhang, Qi Z > > Subject: Re: [PATCH v2 15/37] baseband/acc100: add workaround for deRM

RE: [PATCH v2 06/37] baseband/acc100: add default e value for FCW

2022-09-15 Thread Chautru, Nicolas
Hi Thomas, > -Original Message- > From: Thomas Monjalon > Sent: Thursday, September 15, 2022 4:00 AM > To: Vargas, Hernan > Cc: dev@dpdk.org; gak...@marvell.com; t...@redhat.com; Chautru, Nicolas > ; Zhang, Qi Z ; > maxime.coque...@redhat.com > Subject: Re: [PATCH v2 06/37] baseband/acc

RE: [PATCH v2 34/37] baseband/acc100: update meson file sdk dependency

2022-09-15 Thread Chautru, Nicolas
Hi Thomas, > -Original Message- > From: Thomas Monjalon > Sent: Thursday, September 15, 2022 3:58 AM > To: Vargas, Hernan > Cc: dev@dpdk.org; gak...@marvell.com; t...@redhat.com; Chautru, Nicolas > ; Zhang, Qi Z ; Maxime > Coquelin > Subject: Re: [PATCH v2 34/37] baseband/acc100: updat

RE: [PATCH v2 13/37] baseband/acc10x: limit cases for HARQ pruning

2022-09-15 Thread Chautru, Nicolas
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Thursday, September 15, 2022 12:37 AM > To: Vargas, Hernan ; dev@dpdk.org; > gak...@marvell.com; t...@redhat.com > Cc: Chautru, Nicolas ; Zhang, Qi Z > > Subject: Re: [PATCH v2 13/37] baseband/acc10x: limit cases for HARQ >

DPDK Release Status Meeting 2022-09-15

2022-09-15 Thread Mcnamara, John
Release status meeting minutes 2022-09-15 = Agenda: * Release Dates * Subtrees * Roadmaps * LTS * Defects * Opens Participants: * ARM * Canonical [No] * Debian/Microsoft [No] * Intel * Marvell * Nvidia * Red Hat * Xilinx/AMD [No] Release Dates ---

Cannot set affinity - pthread_setaffinity_np - DPDK21

2022-09-15 Thread Kamaraj P
Hi Team, There are lot of discussion about below code: rte_panic("Cannot set affinity %d i %d threadid %d\n", ret, i, lcore_config[i].thread_id); Is there any guildiness(or patch) from the DPDK community about avoiding these panic messages in our DPDK application ? Even if we remove the panic to

Re: [PATCH] eventdev: add weight and affinity attributes to queue conf

2022-09-15 Thread Jerin Jacob
On Wed, Sep 14, 2022 at 6:04 PM Jerin Jacob wrote: > > On Wed, Aug 10, 2022 at 1:13 PM Shijith Thotton wrote: > > > > Added new fields to represent event queue weight and affinity in > > rte_event_queue_conf structure. Internal op to get queue attribute is > > removed as it is no longer needed. U

[RFC] app/dma-perf: introduce dma-perf application

2022-09-15 Thread Cheng Jiang
There are many high-performance DMA devices supported in DPDK now, and these DMA devices can also be integrated into other modules of DPDK as accelerators, such as Vhost. Before integrating DMA into applications, developers need to know the performance of these DMA devices in various scenarios and

Re: [PATCH v3 0/4] vHost IOTLB cache rework

2022-09-15 Thread Thomas Monjalon
25/07/2022 22:32, David Marchand: > This series aim was initially to solve a scalability issue with the IOTLB > cache code. But along the way, I tried to make the code a bit more robust > by unifying how the device and virtqueue are passed around. Applied directly in main tree to ease backport, th

Re: [PATCH V6 00/17] pipeline: pipeline configuration and build improvements

2022-09-15 Thread Thomas Monjalon
28/07/2022 17:11, Cristian Dumitrescu: > The sequence of steps to build a SWX pipeline object are: > > 1. Create the specification file (pipeline.p4 -> pipeline.spec): This text > file represents the >pipeline program that is typically generated by the P4 compiler or > sometimes manually cre

[PATCH v3 2/2] test/eth_tx: add testcase for queue start stop APIs

2022-09-15 Thread Naga Harish K S V
Added testcase for rte_event_eth_tx_adapter_queue_start() and rte_event_eth_tx_adapter_queue_stop() APIs. Signed-off-by: Naga Harish K S V --- app/test/test_event_eth_tx_adapter.c | 86 1 file changed, 86 insertions(+) diff --git a/app/test/test_event_eth_tx_adapter

[PATCH v3 1/2] eventdev/eth_tx: add queue start stop API

2022-09-15 Thread Naga Harish K S V
Add support to start or stop a particular queue that is associated with the adapter. Start function enables the Tx adapter to start enqueueing packets to the Tx queue. Stop function stops the Tx adapter from transmitting any packets to the Tx queue. The Tx adapter also frees any packets that may

Re: [PATCH v4 1/2] member: implement NitroSketch mode

2022-09-15 Thread Bruce Richardson
On Thu, Sep 15, 2022 at 09:03:41PM +0800, Leyi Rong wrote: > Sketching algorithm provide high-fidelity approximate measurements and > appears as a promising alternative to traditional approaches such as > packet sampling. > > NitroSketch [1] is a software sketching framework that optimizes > perfo

Re: [PATCH V2] net/bonding: add link speeds configuration

2022-09-15 Thread Chas Williams
On 9/15/22 09:14, Huisong Li wrote: This patch adds link speeds configuration. --- -v2: resend due to CI compiling failure. Signed-off-by: Huisong Li --- drivers/net/bonding/rte_eth_bond_pmd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/

RE: [PATCH v2] examples/fips_validation: add parsing for AES CTR

2022-09-15 Thread Ji, Kai
Please fix the checkpath issue reported. Acked-by: Ji, Kai > -Original Message- > From: Dooley, Brian > Sent: Monday, August 22, 2022 1:23 PM > To: Zhang, Roy Fan ; Dooley, Brian > > Cc: dev@dpdk.org; gmuthukri...@marvell.com; gak...@marvell.com; Ji, Kai > > Subject: [PATCH v2] exampl

RE: [PATCH v2] examples/fips_validation: add parsing for AES GMAC

2022-09-15 Thread Ji, Kai
> -Original Message- > From: Dooley, Brian > Sent: Thursday, September 1, 2022 11:35 AM > To: Zhang, Roy Fan ; Dooley, Brian > > Cc: dev@dpdk.org; gmuthukri...@marvell.com; gak...@marvell.com; Ji, Kai > > Subject: [PATCH v2] examples/fips_validation: add parsing for AES GMAC > > Added f

[PATCH v4 2/2] test/member: add functional and perf tests for sketch

2022-09-15 Thread Leyi Rong
This patch adds functional and performance tests for sketch mode of membership library. Signed-off-by: Yipeng Wang Signed-off-by: Leyi Rong --- app/test/test_member.c | 272 app/test/test_member_perf.c | 153 +++- 2 files changed, 421 in

[PATCH v4 1/2] member: implement NitroSketch mode

2022-09-15 Thread Leyi Rong
Sketching algorithm provide high-fidelity approximate measurements and appears as a promising alternative to traditional approaches such as packet sampling. NitroSketch [1] is a software sketching framework that optimizes performance, provides accuracy guarantees, and supports a variety of sketche

[PATCH v4 0/2] introduce NitroSketch Mode into membership library

2022-09-15 Thread Leyi Rong
This patchset introduce a brand new NitroSketch Mode into membership library. This algorithm provides high-fidelity approximate measurements and appears as a promissing alternative to triditional approches such as packet sampling. --- v4: - remove extra avx512 complier flags from the cflags. v3:

RE: [PATCH v3 1/2] member: implement NitroSketch mode

2022-09-15 Thread Rong, Leyi
Hi David, > -Original Message- > From: David Marchand > Sent: Thursday, September 15, 2022 3:47 PM > To: Rong, Leyi > Cc: ferruh.yi...@xilinx.com; suanmi...@nvidia.com; Wang, Yipeng1 > ; zaoxing...@gmail.com; Gobriel, Sameh > ; dev@dpdk.org > Subject: Re: [PATCH v3 1/2] member: implement

RE: [RFC v2] eal/linux: add support for fast virt/iova translation

2022-09-15 Thread Morten Brørup
> From: Don Wallwork [mailto:d...@xsightlabs.com] > Sent: Thursday, 15 September 2022 14.14 > > On 9/15/2022 3:40 AM, Morten Brørup wrote: > >> From: Don Wallwork [mailto:d...@xsightlabs.com] > >> Sent: Wednesday, 14 September 2022 23.12 > >> > >> This patch maps hugepage memory such that address

Re: [RFC v2] eal/linux: add support for fast virt/iova translation

2022-09-15 Thread Don Wallwork
On 9/15/2022 3:40 AM, Morten Brørup wrote: From: Don Wallwork [mailto:d...@xsightlabs.com] Sent: Wednesday, 14 September 2022 23.12 This patch maps hugepage memory such that address translation from virtual to iova or vice versa can be done by simple addition/ subtraction of a constant value wit

Crash in RTE_TIMER

2022-09-15 Thread Nishant Verma
Hi, I am facing one issue in rte_timer. The description is quite generic. *Setup*: I am using DPDK 21.11 OS: Centos 7.9 CPU: Intel(R) Xeon(R) CPU D-1581 @ 1.80GHz NIC: SR-IOV on X552 Process: Single primary process(one core, one instance) only *Earlier Running Application: * We built our app as

RE: [PATCH v2 3/5] crypto/ipsec_mb: add remaining SGL support

2022-09-15 Thread De Lara Guarch, Pablo
Hi Ciara, > -Original Message- > From: Power, Ciara > Sent: Thursday, August 25, 2022 3:29 PM > To: Zhang, Roy Fan ; De Lara Guarch, Pablo > > Cc: dev@dpdk.org; Ji, Kai ; Power, Ciara > > Subject: [PATCH v2 3/5] crypto/ipsec_mb: add remaining SGL support > > The intel-ipsec-mb library

RE: [PATCH v2 2/5] crypto/ipsec_mb: fix sessionless cleanup

2022-09-15 Thread De Lara Guarch, Pablo
Hi Ciara, > -Original Message- > From: Power, Ciara > Sent: Thursday, August 25, 2022 3:29 PM > To: Zhang, Roy Fan ; De Lara Guarch, Pablo > > Cc: dev@dpdk.org; Ji, Kai ; Power, Ciara > ; Mrozowicz, SlawomirX > > Subject: [PATCH v2 2/5] crypto/ipsec_mb: fix sessionless cleanup > > Curr

Re: [PATCH v2 37/37] baseband/acc100: reset pointer after rte_free

2022-09-15 Thread Maxime Coquelin
On 8/20/22 04:31, Hernan Vargas wrote: Set local pointer to NULL after rte_free. This needs to be set explicitly since logic may check for null pointers. Fixes: 060e7672930 ("baseband/acc100: add queue configuration") Cc: sta...@dpdk.org Signed-off-by: Hernan Vargas --- drivers/baseband/a

Re: [PATCH v2 36/37] baseband/acc100: make HARQ layout memory 4GB

2022-09-15 Thread Maxime Coquelin
On 8/20/22 04:31, Hernan Vargas wrote: HARQ layout memory should be 4GB instead of 2GB. Fixes: 4cf90079797 ("baseband/acc100: add HW register definitions") Cc: sta...@dpdk.org Signed-off-by: Hernan Vargas --- drivers/baseband/acc100/acc100_pmd.h | 6 -- 1 file changed, 4 insertions(+

Re: [PATCH v2 35/37] baseband/acc100: add protection for NULL HARQ input

2022-09-15 Thread Maxime Coquelin
On 8/20/22 04:31, Hernan Vargas wrote: It is possible to cause an invalid HW operation in case the user provides the BBDEV API and HARQ operation with input enabled and zero Not sure, but s/and/a/? This is again a fix, and should be tagged appropriately. input. Adding protection for that

[PATCH] net/bnxt: return -EBUSY if port is active during MTU change

2022-09-15 Thread Benjamin Le Berre
When the BNXT PMD was made to disallow MTU changes on active ports, the error code chosen for the case in bnxt_set_mtu_op() was -EPERM. The doc comment for rte_eth_dev_set_mtu() in lib/ethdev/rte_ethdev.h lists -EBUSY as the value to be used if the port must be stopped before applying an MTU chang

Re: [PATCH v1] ethdev: add direction info when creating the transfer table

2022-09-15 Thread Thomas Monjalon
15/09/2022 12:59, Ivan Malov: > Hi Rongwei, > > In this reply, I do not include the previous mail because the amount > of inline commentary has gone haywire over the past couple of days. > Let's re-iterate. > > But before I get to that, I'd like to offer a fresh perspective: > > Perhaps, if we a

Re: [PATCH v2 06/37] baseband/acc100: add default e value for FCW

2022-09-15 Thread Thomas Monjalon
20/08/2022 04:31, Hernan Vargas: > Refactor frame control word LDPC encoder fill function to take a default e > value as a parameter. No functional impact. Excuse my ignorance, what is "e"? Is there a way to describe or name it differently?

RE: [PATCH v1] ethdev: add direction info when creating the transfer table

2022-09-15 Thread Ivan Malov
Hi Rongwei, In this reply, I do not include the previous mail because the amount of inline commentary has gone haywire over the past couple of days. Let's re-iterate. But before I get to that, I'd like to offer a fresh perspective: Perhaps, if we all agree that term "vport" means an endpoint wh

Re: [PATCH v2 34/37] baseband/acc100: update meson file sdk dependency

2022-09-15 Thread Thomas Monjalon
15/09/2022 12:31, Maxime Coquelin: > > On 8/20/22 04:31, Hernan Vargas wrote: > > Update meson files with FlexRAN SDK dependency. There is no reason for this commit. If the reason is that you need these dependencies for some features, it is better to introduce the dependency when you use it. Patc

[PATCH v9 12/12] net/nfp: add flower PF rxtx logic

2022-09-15 Thread Chaoyong He
Implements the flower Rx logic. Fallback packets are multiplexed to the correct representor port based on the prepended metadata. The Rx poll is set to run on the existing service infrastructure. For Tx the existing NFP Tx logic is duplicated to keep the Tx two paths distinct. Flower fallback also

[PATCH v9 11/12] net/nfp: move rxtx function to header file

2022-09-15 Thread Chaoyong He
The flower firmware application makes use of the same Rx and Tx checksum logic as the normal PMD. Expose it so that flower firmware application also can make use of it. Signed-off-by: Chaoyong He Signed-off-by: Heinrich Kuhn Reviewed-by: Niklas Söderlund --- drivers/net/nfp/nfp_common.c|

[PATCH v9 10/12] net/nfp: add flower representor framework

2022-09-15 Thread Chaoyong He
Adds the framework to support flower representors. The number of VF representors are parsed from the command line. For physical port representors the current logic aims to create a representor for each physical port present on the hardware. An eth_dev is created for each physical port and VF, and

[PATCH v9 09/12] net/nfp: add flower ctrl VNIC rxtx logic

2022-09-15 Thread Chaoyong He
Adds the Rx and Tx function for the ctrl VNIC. The logic is mostly identical to the normal Rx and Tx functionality of the NFP PMD. Make use of the ctrl VNIC service logic to service the ctrl vNIC Rx path. Signed-off-by: Chaoyong He Signed-off-by: Heinrich Kuhn Reviewed-by: Niklas Söderlund ---

[PATCH v9 08/12] net/nfp: move common rxtx function for flower use

2022-09-15 Thread Chaoyong He
Move some common Rx and Tx logic to the header file so that they can be re-used by flower Tx and Rx logic. Signed-off-by: Chaoyong He Signed-off-by: Heinrich Kuhn Reviewed-by: Niklas Söderlund --- drivers/net/nfp/nfp_rxtx.c | 32 +--- drivers/net/nfp/nfp_rxtx.h | 31

[PATCH v9 07/12] net/nfp: add flower ctrl VNIC related logics

2022-09-15 Thread Chaoyong He
Adds the setup/start logic for the ctrl vNIC. This vNIC is used by the PMD and flower firmware application as a communication channel between driver and firmware. In the case of OVS it is also used to communicate flow statistics from hardware to the driver. A rte_eth device is not exposed to DPDK

[PATCH v9 06/12] net/nfp: add flower PF related routines

2022-09-15 Thread Chaoyong He
Adds the start/stop/close routine of the flower PF vNIC. And we reuse the configure/link_update routine. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- drivers/net/nfp/flower/nfp_flower.c | 193 +++- 1 file changed, 192 insertions(+), 1 deletion(-)

[PATCH v9 05/12] net/nfp: add flower PF setup logic

2022-09-15 Thread Chaoyong He
Adds the vNIC initialization logic for the flower PF vNIC. The flower firmware application exposes this vNIC for the purposes of fallback traffic in the switchdev use-case. Adds minimal dev_ops for this PF vNIC device. Because the device is being exposed externally to DPDK it needs to implements a

[PATCH v9 04/12] net/nfp: add initial flower firmware support

2022-09-15 Thread Chaoyong He
Adds the basic probing infrastructure to support the flower firmware application. Adds the cpp service, used for some user tools. Signed-off-by: Chaoyong He Signed-off-by: Heinrich Kuhn Reviewed-by: Niklas Söderlund --- doc/guides/nics/nfp.rst| 13 + doc/guides/rel_notes/r

[PATCH v9 03/12] net/nfp: move app specific init logic to own function

2022-09-15 Thread Chaoyong He
The NFP card can load different firmware applications. This commit move the init logic of corenic app of the secondary process into its own function. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- drivers/net/nfp/nfp_ethdev.c | 90 +--- 1 fi

[PATCH v9 02/12] net/nfp: simplify initialization and remove dead code

2022-09-15 Thread Chaoyong He
Calling nfp_net_init() is only done for the corenic firmware flavor and it is guaranteed to always be called from the primary process, so the explicit check for RTE_PROC_PRIMARY can be dropped. The calling graph of nfp_net_init() already guaranteed the free of resources when it fail, so remove the

[PATCH v9 01/12] net/nfp: move app specific attributes to own struct

2022-09-15 Thread Chaoyong He
The NFP card can load different application firmwares. Currently only the CoreNIC application firmware is supported. This commit makes needed infrastructure changes in order to support other application firmwares too. Clearer separation is made between the PF device and any application firmware sp

[PATCH v9 00/12] preparation for the rte_flow offload of nfp PMD

2022-09-15 Thread Chaoyong He
* Changes since v8 - Update the nfp.rst - Fix the 'app_hw' to 'app_fw' - Remove the ovs compatible header file - Remove the use of rte_eth_dev_configure()/rte_eth_rx_burst()/rte_eth_dev_start() API * Changes since v7 - Adjust the logics to make sure not break the pci probe process - Change 'app'

Re: [PATCH v2 34/37] baseband/acc100: update meson file sdk dependency

2022-09-15 Thread Maxime Coquelin
On 8/20/22 04:31, Hernan Vargas wrote: Update meson files with FlexRAN SDK dependency. Signed-off-by: Hernan Vargas --- drivers/baseband/acc100/meson.build | 21 + 1 file changed, 21 insertions(+) diff --git a/drivers/baseband/acc100/meson.build b/drivers/baseband/ac

Re: [PATCH v2 33/37] baseband/acc100: set device min alignment to 1

2022-09-15 Thread Maxime Coquelin
On 8/20/22 04:31, Hernan Vargas wrote: Historical mistakes, there should be no 64B alignment requirement for the buffer being processed. Any 1B alignment is sufficient. Fixes: 9200ffa5cd5 ("baseband/acc100: add info get function") Cc: sta...@dpdk.org Signed-off-by: Hernan Vargas --- drive

Re: [PATCH v2 32/37] baseband/acc100: fix debug print for LDPC FCW

2022-09-15 Thread Maxime Coquelin
On 8/20/22 04:31, Hernan Vargas wrote: Print full size of FCW LDPC structure on debug messages. This is just a cosmetic fix, no need to fix on previous code base. Signed-off-by: Hernan Vargas --- drivers/baseband/acc100/rte_acc100_pmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-

Re: [PATCH v2 31/37] baseband/acc100: fix clearing PF IR outside handler

2022-09-15 Thread Maxime Coquelin
On 8/20/22 04:31, Hernan Vargas wrote: Clearing of PF info ring outside of handler may cause interrupt to be missed. A condition in the ACC100 PMD implementation may cause an interrupt functional handler call to be missed due to related bit being cleared when checking PF info ring status. Fix

Re: [PATCH v2 30/37] baseband/acc100: reduce input length for CRC24B

2022-09-15 Thread Maxime Coquelin
On 8/20/22 04:31, Hernan Vargas wrote: Input length should be reduced only for CRC24B. Signed-off-by: Hernan Vargas --- drivers/baseband/acc100/rte_acc100_pmd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseba

Re: [PATCH v2 29/37] baseband/acc100: update device info

2022-09-15 Thread Maxime Coquelin
On 8/20/22 04:31, Hernan Vargas wrote: Remove unused capabilities, use dummy operation as start count for number of queues. Signed-off-by: Hernan Vargas --- drivers/baseband/acc100/rte_acc100_pmd.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/baseband/a

Re: [PATCH v2 28/37] baseband/acc100: make desc optimization optional

2022-09-15 Thread Maxime Coquelin
On 8/20/22 04:31, Hernan Vargas wrote: Add ACC100_DESC_OPTIMIZATION flag to enable muxing of encode operations with common FCW. Signed-off-by: Hernan Vargas --- drivers/baseband/acc100/rte_acc100_pmd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/baseband/

Re: [PATCH v2 27/37] baseband/acc100: store FCW from first CB descriptor

2022-09-15 Thread Maxime Coquelin
On 8/20/22 04:31, Hernan Vargas wrote: Store the descriptor from the first code block from a transport block. Copy the LDPC FCW from the first descriptor into the rest of the CBs in that TB. Signed-off-by: Hernan Vargas --- drivers/baseband/acc100/rte_acc100_pmd.c | 4 1 file changed

Re: [PATCH v2 26/37] baseband/acc100: allocate ring/queue mem when NULL

2022-09-15 Thread Maxime Coquelin
On 8/20/22 04:31, Hernan Vargas wrote: Allocate info ring, tail pointers and HARQ layout memory for a device only if it hasn't already been allocated. Signed-off-by: Hernan Vargas --- drivers/baseband/acc100/rte_acc100_pmd.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-)

[Bug 1071] Deadlock on memory allocation (rte_memzone_reserve_aligned)

2022-09-15 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1071 Anatoly Burakov (anatoly.bura...@intel.com) changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Re

Re: [PATCH v2 25/37] baseband/acc100: update log messages

2022-09-15 Thread Maxime Coquelin
On 8/20/22 04:31, Hernan Vargas wrote: Add extra values for some log messages. No functional impact. Signed-off-by: Hernan Vargas --- drivers/baseband/acc100/rte_acc100_pmd.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/baseband/acc100/rte_acc

Re: [PATCH v2 24/37] baseband/acc100: rename ldpc encode function arg

2022-09-15 Thread Maxime Coquelin
On 8/20/22 04:31, Hernan Vargas wrote: Rename total_enqueued_cbs to total_enqueued_descs in the enqueue_ldpc_enc_n_op_cb function. No functional impact. Signed-off-by: Hernan Vargas --- drivers/baseband/acc100/rte_acc100_pmd.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(

Re: [PATCH v2 23/37] baseband/acc100: update uplink CB input length

2022-09-15 Thread Maxime Coquelin
On 8/20/22 04:31, Hernan Vargas wrote: Use the FCW E parameter for rate matching as the code block input length. Signed-off-by: Hernan Vargas --- drivers/baseband/acc100/rte_acc100_pmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/baseband/acc100/rte_acc100

Re: [PATCH v2 22/37] baseband/acc100: enforce additional check on FCW

2022-09-15 Thread Maxime Coquelin
On 8/20/22 04:31, Hernan Vargas wrote: Enforce additional check on Frame Control Word validity and add stronger alignment for decompression mode. As on previous patches, it is a fix and so should be marked appropriately and moved at the beginning of the series. Signed-off-by: Hernan Vargas

Re: [PATCH v2 21/37] baseband/acc100: check for unlikely operation vals

2022-09-15 Thread Maxime Coquelin
On 8/20/22 04:31, Hernan Vargas wrote: Add unlikely checks for NULL operation values. Same as for patch 20, this is a fix. Signed-off-by: Hernan Vargas --- drivers/baseband/acc100/rte_acc100_pmd.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/baseband/acc100/r

Re: [PATCH v2 20/37] baseband/acc100: check turbo dec/enc input

2022-09-15 Thread Maxime Coquelin
On 8/20/22 04:31, Hernan Vargas wrote: Add NULL check for the turbo decoder and encoder input length. Looks like a fix, please add Fixes tag and cc stable. Signed-off-by: Hernan Vargas --- drivers/baseband/acc100/rte_acc100_pmd.c | 23 ++- 1 file changed, 18 insert

Re: [PATCH v2 19/37] baseband/acc100: add queue stop operation

2022-09-15 Thread Maxime Coquelin
On 8/20/22 04:31, Hernan Vargas wrote: Implement new feature queue stop operation. Implement new feature to stop queue operation? Signed-off-by: Hernan Vargas --- drivers/baseband/acc100/rte_acc100_pmd.c | 58 1 file changed, 58 insertions(+) diff --git a/dri

[PATCH v2 2/2] test/eth_tx: add testcase for queue start stop APIs

2022-09-15 Thread Naga Harish K S V
Added testcase for rte_event_eth_tx_adapter_queue_start() and rte_event_eth_tx_adapter_queue_stop() APIs. Signed-off-by: Naga Harish K S V --- app/test/test_event_eth_tx_adapter.c | 86 1 file changed, 86 insertions(+) diff --git a/app/test/test_event_eth_tx_adapter

[PATCH v2 1/2] eventdev/eth_tx: add queue start stop API

2022-09-15 Thread Naga Harish K S V
This patch adds support to start or stop a particular queue that is associated with the adapter. Start function enables the Tx Adapter to start enqueueing packets to the Tx queue. Stop function stops the Tx Adapter from transmitting any mbufs to the Tx queue. The Tx Adapter also frees any mbufs t

Re: [PATCH v2 18/37] baseband/acc100: implement configurable queue depth

2022-09-15 Thread Maxime Coquelin
On 8/20/22 04:31, Hernan Vargas wrote: Implement new feature to make queue depth configurable based on decode or encode mode. Signed-off-by: Hernan Vargas --- drivers/baseband/acc100/rte_acc100_pmd.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/

Re: [PATCH v1] ethdev: add direction info when creating the transfer table

2022-09-15 Thread Ivan Malov
Hi Thomas, On Thu, 15 Sep 2022, Thomas Monjalon wrote: 15/09/2022 09:47, Ivan Malov: As I said, match criteria belong in flow pattern. I recognise the importance of the problem that you're looking to solve. It's very good that you care to address it, but what this patch tries to do is to add m

Re: [PATCH v2] usertools: rewrite pmdinfo

2022-09-15 Thread Robin Jarry
Ferruh Yigit, Sep 14, 2022 at 13:46: > I think better to display name, if there is nothing else to display, > comparing to not display anything at all. > Command can be run on the driver object, .so, so user expects to see > some output. > > For above enetfec driver, it is virtual driver and does

Re: [PATCH v2 17/37] baseband/acc100: configure PMON control registers

2022-09-15 Thread Maxime Coquelin
On 8/20/22 04:31, Hernan Vargas wrote: Adding back feature from ACC101. Expose the device status and add protection for corner cases. Enable performance monitor control registers. Signed-off-by: Hernan Vargas --- drivers/baseband/acc100/acc100_pf_enum.h | 52 +--- driv

Re: [PATCH v2 16/37] baseband/acc100: add ring companion address

2022-09-15 Thread Maxime Coquelin
On 8/20/22 04:31, Hernan Vargas wrote: Store the virtual address of companion ring as part of queue information. Use this address to calculate the op address. Signed-off-by: Hernan Vargas --- drivers/baseband/acc100/acc100_pmd.h | 12 ++ drivers/baseband/acc100/rte_acc100_pmd.c | 143

  1   2   >