When the BNXT PMD was made to disallow MTU changes on active ports, the
error code chosen for the case in bnxt_set_mtu_op() was -EPERM.
The doc comment for rte_eth_dev_set_mtu() in lib/ethdev/rte_ethdev.h
lists -EBUSY as the value to be used if the port must be stopped before
applying an MTU change and does not list -EPERM as a possible return
value.
This patch makes bnxt_set_mtu_op() return -EBUSY instead of -EPERM so
that rte_eth_dev_set_mtu() behaves as expected.
Fixes: a42ab1eb33ff ("net/bnxt: disallow MTU change when device is started")
Signed-off-by: Benjamin Le Berre <benjamin.le_be...@6wind.com>
---
Hi,
Should I Cc sta...@dpdk.org?
Thanks,
Benjamin.
drivers/net/bnxt/bnxt_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index e275d3a53fda..c07a41c693da 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -3030,7 +3030,7 @@ int bnxt_mtu_set_op(struct rte_eth_dev *eth_dev, uint16_t
new_mtu)
/* Return if port is active */
if (eth_dev->data->dev_started) {
PMD_DRV_LOG(ERR, "Stop port before changing MTU\n");
- return -EPERM;
+ return -EBUSY;
}
/* Exit if receive queues are not configured yet */
--
2.30.2
