> From: Stephen Hemminger [mailto:step...@networkplumber.org]
> Sent: Wednesday, 20 July 2022 00.34
>
> > > /**
> > > @@ -179,7 +226,7 @@ rte_rwlock_write_lock(rte_rwlock_t *rwl)
> > > static inline void
> > > rte_rwlock_write_unlock(rte_rwlock_t *rwl)
> > > {
> > > - __atomic_store_n(&rwl->cn
Hello,
You can find attached a patch to fix the issue.
Sincerely
Théo
- Mail original -
De: "Thomas Monjalon"
À: "Theo MARGUERET"
Cc: "dev" , "Cristian Dumitrescu"
, "Jasvinder Singh"
Envoyé: Vendredi 15 Juillet 2022 18:27:41
Objet: Re: config files profile.cfg in examples/qos_sched
+C
Add VIRTIO_F_RING_RESET, which indicates that the driver can reset a
queue individually.
VIRTIO_F_RING_RESET feature is added to virtio-spec 1.2. The relevant
information is in
https://github.com/oasis-tcs/virtio-spec/issues/124
https://github.com/oasis-tcs/virtio-spec/issues/139
The impl
[Public]
Acked-by: Chandubabu Namburu
-Original Message-
From: 835703...@qq.com <835703...@qq.com>
Sent: Saturday, July 9, 2022 4:31 PM
To: Namburu, Chandu-babu
Cc: dev@dpdk.org; Shiqi Liu <835703...@qq.com>
Subject: [PATCH] crypto/ccp: Check for the NULL pointer after calling rte_mall
On Tue, Jul 19, 2022 at 11:03 PM Thomas Monjalon wrote:
> > --- a/devtools/libabigail.abignore
> > +++ b/devtools/libabigail.abignore
> > @@ -31,43 +31,8 @@
> > type_kind = enum
> > changed_enumerators = RTE_CRYPTO_ASYM_XFORM_ECPM,
> > RTE_CRYPTO_ASYM_XFORM_TYPE_LIST_END
> >
> >
Hi ZhangQi
Could you please help to review this patch at your convenience, thank you
so much!
Best regards
Zhichao
> -Original Message-
> From: Zeng, ZhichaoX
> Sent: Tuesday, June 14, 2022 9:21 PM
> To: dev@dpdk.org
> Cc: Yang, Qiming ; Zeng, ZhichaoX
> ; Zhang, Qi Z
> Subject:
On 7/18/22 1:16 PM, Thinh Tran wrote:
On 7/14/2022 1:58 AM, Ali Alnubani wrote:
-Original Message-
From: Thinh Tran
Sent: Wednesday, July 13, 2022 10:50 PM
To: Ali Alnubani ; NBU-Contact-Thomas Monjalon
(EXTERNAL)
Cc: dev@dpdk.org; David Christensen
Subject: Re: [PATCH] config: s
> > /**
> > @@ -179,7 +226,7 @@ rte_rwlock_write_lock(rte_rwlock_t *rwl)
> > static inline void
> > rte_rwlock_write_unlock(rte_rwlock_t *rwl)
> > {
> > - __atomic_store_n(&rwl->cnt, 0, __ATOMIC_RELEASE);
> > + __atomic_fetch_sub(&rwl->cnt, RTE_RWLOCK_WRITE,
> > __ATOMIC_RELEASE);
>
>
> From: Stanisław Kardach [mailto:k...@semihalf.com]
> Sent: Tuesday, 19 July 2022 20.51
>
> On Tue, Jul 19, 2022 at 8:41 PM Morten Brørup
> wrote:
> >
> > > From: David Christensen [mailto:d...@linux.vnet.ibm.com]
> > > Assume that fallback to the standard temporal memcpy is an
> acceptable
> >
> From: Stephen Hemminger [mailto:step...@networkplumber.org]
> Sent: Tuesday, 19 July 2022 22.28
>
> Modify reader/writer lock to avoid starvation of writer. The previous
> implementation would cause a writer to get starved if readers kept
> acquiring the lock. The new version uses an additiona
18/07/2022 12:09, David Marchand:
> --- a/devtools/check-abi.sh
> +++ b/devtools/check-abi.sh
> @@ -37,10 +37,6 @@ fi
> error=
> for dump in $(find $refdir -name "*.dump"); do
> name=$(basename $dump)
> - if grep -qE '\ - echo "Skipped removed driver $name."
> -
+Cc ethdev and testpmd maintainers
Any feedback about this need and solution?
04/07/2022 10:24, Eli Britstein:
> Upon creation of a flow, testpmd assigns it a flow ID. Later, the flow
> ID is used for flow operations (query, destroy, dump).
>
> The testpmd application allows to manage flow rule
19/07/2022 16:15, Singh, Jasvinder:
> From: Theo MARGUERET
> >
> > Hello,
> > You can find attached a patch to fix the issue.
> > Sincerely
> > Théo
>
> Hi Theo,
>
> can you follow guidelines at https://core.dpdk.org/contribute/submit for
> patch submission.
I guess you mean https://core.dp
Modify reader/writer lock to avoid starvation of writer. The previous
implementation would cause a writer to get starved if readers kept
acquiring the lock. The new version uses an additional bit to indicate
that a writer is waiting and which keeps readers from starving the
writer.
Signed-off-by
The reader writer lock transactional memory appears to turn the rwlock into
just a spinlock.
When there are multiple readers, it will think that transaction was impacted.
Kind of want to just drop the TM support from reader writer lock, doubt if
anyone uses it.
With 22.07 release, the test requirements seemed to have changed.
Can't run tests unless root now.
And the table test fails if only 1G of hugepages is setup.
This doesn't match the documentation:
https://doc.dpdk.org/guides/prog_guide/meson_ut.html
which shows running tests as non-root.
On Tue, Jul 19, 2022 at 8:41 PM Morten Brørup
wrote:
>
> > From: David Christensen [mailto:d...@linux.vnet.ibm.com]
> > Assume that fallback to the standard temporal memcpy is an acceptable
> > implementation when not supported by the architecture, yes?
>
> Yes, that is exactly what I envisioned.
> From: David Christensen [mailto:d...@linux.vnet.ibm.com]
> Sent: Tuesday, 19 July 2022 20.01
>
> On 7/19/22 8:26 AM, Morten Brørup wrote:
> > This RFC proposes a set of functions optimized for non-temporal
> memory copy.
> >
> > At this stage, I am asking for feedback on the concept.
> >
> > App
> -Original Message-
> From: Hamza Khan
> +#include "rte_tailq.h"
Should include this as #include
Otherwise looks good. If you are sending next version, include my Ack in the
patch.
Reviewed-by: Reshma Pattan
Acked-by: Reshma Pattan
On 7/19/22 8:26 AM, Morten Brørup wrote:
This RFC proposes a set of functions optimized for non-temporal memory copy.
At this stage, I am asking for feedback on the concept.
Applications sometimes data to another memory location, which is only used
much later.
In this case, it is inefficient
On 19/07/22 5:42 pm, Thomas Monjalon wrote:
18/07/2022 20:15, aman.ku...@vvdntech.in:
> On 07/07/22 7:49 pm, Hemant Agrawal wrote:
>>
>> On 7/7/2022 7:45 PM, Thomas Monjalon wrote:
>>> 07/07/2022 15:55, Aman Kumar:
On 07/07/22 12:27 pm, Thomas Monjalon wrote:
> 06/07/2022 09:51, Aman K
This RFC proposes a set of functions optimized for non-temporal memory copy.
At this stage, I am asking for feedback on the concept.
Applications sometimes data to another memory location, which is only used
much later.
In this case, it is inefficient to pollute the data cache with the copied
dat
> -Original Message-
> From: Theo MARGUERET
> Sent: Tuesday, July 19, 2022 8:31 AM
> To: Thomas Monjalon
> Cc: dev ; Dumitrescu, Cristian
> ; Singh, Jasvinder
>
> Subject: Re: config files profile.cfg in examples/qos_sched
>
> Hello,
> You can find attached a patch to fix the issue.
>
18/07/2022 12:59, Morten Brørup:
> I only request that:
> 1. The patch clearly reflects what is does, and
+1
> 2. The instrumentation can be omitted at build time, so it has zero
> performance impact on applications where it is useless.
+1
(+2 then)
18/07/2022 20:15, aman.ku...@vvdntech.in:
> On 07/07/22 7:49 pm, Hemant Agrawal wrote:
> >
> > On 7/7/2022 7:45 PM, Thomas Monjalon wrote:
> > > 07/07/2022 15:55, Aman Kumar:
> > >> On 07/07/22 12:27 pm, Thomas Monjalon wrote:
> > >>> 06/07/2022 09:51, Aman Kumar:
> > This patch series provi
Thanks David,
Owen is taking care of that this morning and will confirm back when it's
disabled on the DPDK main.
Cheers,
Lincoln
On Tue, Jul 19, 2022 at 6:36 AM David Marchand
wrote:
> On Mon, Jul 18, 2022 at 6:21 PM Lincoln Lavoie
> wrote:
> > With the 22.07 release, I think we can now disa
From: Jakub Palider
This change to log checking procedure ensures that certain
tags are in proper order.
The order of tags is as follows:
* Coverity issue
* Bugzilla ID
* Fixes
* Cc
*
* Suggested-by
* Reported-by
+ Signed-off-by
* Acked-by
* Reviewed-by
* Tested-by
where:
* => 0 or m
From: Pavan Nikhilesh
Disable timer resolution estimation, read TIM LF clock registers
to get the current running clock counter as estimating causes
time drift.
Signed-off-by: Pavan Nikhilesh
---
drivers/common/cnxk/hw/tim.h | 6 ++
drivers/event/cnxk/cnxk_tim_evdev.c | 140 +++-
From: Pavan Nikhilesh
Set default GetWork(dequeue) mode to prefetch with wait for
event.
Signed-off-by: Pavan Nikhilesh
---
doc/guides/eventdevs/cnxk.rst | 5 +++--
drivers/event/cnxk/cn10k_eventdev.c | 1 +
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/doc/guides/eventd
From: Pavan Nikhilesh
Avoid reading non-cached registers in fastpath.
PENDSTATE need not be read before tag flush in tx enqueue
context as we have additional checks prior to check for
pending flushes.
Signed-off-by: Pavan Nikhilesh
---
drivers/event/cnxk/cn9k_worker.h | 11 ++-
1 file
From: Pavan Nikhilesh
Add FC check in vector event Tx path, the check needs to be
performed after head wait right before LMTST is issued.
Since, SQB pool fc updates are delayed w.r.t the actual
utilization of pool add sufficient slack to avoid overflow.
Added a new device argument to override th
On Mon, Jul 18, 2022 at 12:10 PM David Marchand
wrote:
> diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore
> index 8c8c648895..ded20032d4 100644
> --- a/devtools/libabigail.abignore
> +++ b/devtools/libabigail.abignore
> @@ -31,43 +31,8 @@
> type_kind = enum
>
On Mon, Jul 18, 2022 at 6:21 PM Lincoln Lavoie wrote:
> With the 22.07 release, I think we can now disable the ABI for the dpdk main,
> until the next LTS release, correct?
Indeed, you can do it now.
Thanks Lincoln.
--
David Marchand
> -Original Message-
> From: Kai Ji
> Sent: Monday, July 11, 2022 6:08 PM
> To: dev@dpdk.org
> Cc: gak...@marvell.com; Ji, Kai
> Subject: [dpdk-dev v1] crypto/openssl: fix of dstlen passed in HMAC
>
> This fix of dstlen passed in OpenSSL 3.0 lib EVP MAC final routine.
>
> Fixes: 75adf1e
> -Original Message-
> From: Kai Ji
> Sent: Monday, July 11, 2022 6:08 PM
> To: dev@dpdk.org
> Cc: gak...@marvell.com; Ji, Kai
> Subject: [dpdk-dev v1] crypto/qat: Enable OpenSSL legacy provider in session
>
> Some cryptographic algorithms such as MD and DES are now considered
> legacy
>
Added test case for rte_event_eth_rx_adapter_instance_get()
Signed-off-by: Ganapati Kundapura
Reviewed-by: Naga Harish K S V
Acked-by: Jay Jayatheerthan
diff --git a/app/test/test_event_eth_rx_adapter.c
b/app/test/test_event_eth_rx_adapter.c
index e358a70..1da7782 100644
--- a/app/test/test_
Added rte_event_eth_rx_adapter_instance_get() to get
adapter instance id for specified ethernet device id and
rx queue index.
Signed-off-by: Ganapati Kundapura
Reviewed-by: Naga Harish K S V
Acked-by: Jay Jayatheerthan
---
v11:
* added instance_get under 22.11 in version.map
v10:
* Add Review
Added telemetry handler for rte_event_eth_rx_adapter_instance_get()
to retrieve adapter instance id for specified ethernet device id
and rx queue index.
Signed-off-by: Ganapati Kundapura
Reviewed-by: Naga Harish K S V
Acked-by: Jay Jayatheerthan
diff --git a/lib/eventdev/rte_event_eth_rx_adap
Added rte_event_eth_tx_adapter_instance_get() details.
Signed-off-by: Ganapati Kundapura
Reviewed-by: Naga Harish K S V
Acked-by: Jay Jayatheerthan
diff --git a/doc/guides/prog_guide/event_ethernet_tx_adapter.rst
b/doc/guides/prog_guide/event_ethernet_tx_adapter.rst
index f80d226..4da9bcd 10
Added rte_event_eth_rx_adapter_instance_get() details
Signed-off-by: Ganapati Kundapura
Reviewed-by: Naga Harish K S V
Acked-by: Jay Jayatheerthan
diff --git a/doc/guides/prog_guide/event_ethernet_rx_adapter.rst
b/doc/guides/prog_guide/event_ethernet_rx_adapter.rst
index 3b4ef50..5b9d0cf 100
Added testcase for rte_event_eth_tx_adapter_instance_get()
Signed-off-by: Ganapati Kundapura
Reviewed-by: Naga Harish K S V
Acked-by: Jay Jayatheerthan
diff --git a/app/test/test_event_eth_tx_adapter.c
b/app/test/test_event_eth_tx_adapter.c
index 2900532..98debfd 100644
--- a/app/test/test_e
Added rte_event_eth_tx_adapter_instance_get() to get the
adapter instance id for specified ethernet device id and
tx queue index.
Signed-off-by: Ganapati Kundapura
Reviewed-by: Naga Harish K S V
Acked-by: Jay Jayatheerthan
diff --git a/lib/eventdev/eventdev_pmd.h b/lib/eventdev/eventdev_pmd.h
Hi Huichao,
I've been busy lately, sorry to reply to you late.
No worries at all.
Instead of implicitly assuming that output mbufs will be allocated
from pkt_in pool, it would be better to have output_pool as explicit
parameter for that function.
In a same way we have it for rte_
43 matches
Mail list logo
