18/07/2022 12:09, David Marchand:
> --- a/devtools/check-abi.sh
> +++ b/devtools/check-abi.sh
> @@ -37,10 +37,6 @@ fi
> error=
> for dump in $(find $refdir -name "*.dump"); do
> name=$(basename $dump)
> - if grep -qE '\<librte_*(.*_octeontx2|raw_dpaa2_qdma)' $dump; then
> - echo "Skipped removed driver $name."
> - continue
> - fi
Yes it needs to be removed.
> --- a/devtools/libabigail.abignore
> +++ b/devtools/libabigail.abignore
> @@ -31,43 +31,8 @@
> type_kind = enum
> changed_enumerators = RTE_CRYPTO_ASYM_XFORM_ECPM,
> RTE_CRYPTO_ASYM_XFORM_TYPE_LIST_END
>
> -;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
> -; Temporary exceptions till next major ABI version ;
> -;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
> +;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
> +; Temporary exceptions till next major ABI version ;
> +; NOTE: there may be some removed libaries or drivers in check-abi.sh ;
> +;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
This note is not clear to me.
>
> -; Ignore ethdev event enum update
> -; because new event cannot be received if not registered
> -[suppress_type]
> - type_kind = enum
> - changed_enumerators = RTE_ETH_EVENT_MAX
> -
> -; Ignore fields inserted in cacheline boundary of rte_eth_rxq_info
> -; because the struct size is unchanged
> -[suppress_type]
> - name = rte_eth_rxq_info
> - has_data_member_inserted_between = {offset_of(rx_buf_size), end}
> -
> -; Ignore fields inserted in place of reserved_opts of
> rte_security_ipsec_sa_options
> -[suppress_type]
> - name = rte_security_ipsec_sa_options
> - has_data_member_inserted_between = {offset_of(reserved_opts), end}
> -
> -; Ignore section attribute fixes in experimental regexdev library
> -[suppress_file]
> - soname_regexp = ^librte_regexdev\.
> -
> -; Ignore changes in common mlx5 driver, should be all internal
> -[suppress_file]
> - soname_regexp = ^librte_common_mlx5\.
> -
> -; Ignore visibility fix of local functions in experimental auxiliary driver
> -[suppress_file]
> - soname_regexp = ^librte_bus_auxiliary\.
> -
> -; Ignore visibility fix of local functions in experimental gpudev library
> -[suppress_file]
> - soname_regexp = ^librte_gpudev\.
> -
> -; Ignore libabigail false-positive in clang builds, after moving code.
> -[suppress_function]
> - name = rte_eal_remote_launch
Yes they can all be removed.
New exceptions will be added cautiously per need.
