RE: [EXT] [PATCH 11/40] cryptodev: remove asym crypto next xform

2022-05-26 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Friday, May 27, 2022 8:40 AM > To: Anoob Joseph ; Akhil Goyal ; > dev@dpdk.org; Kiran Kumar Kokkilagadda > Cc: Zhang, Roy Fan ; Umesh Kartha > ; Ramkumar Balu > Subject: RE: [EXT] [PATCH 11/40] cryptodev: remove asym crypto next

[PATCH] ethtool: remove a redundant call to rte_eth_dev_stop()

2022-05-26 Thread Usman Tanveer
There is a call to rte_eth_dev_stop() in rte_ethtool_net_open() due to which user gets misleading message upon first open/start call. It says that the device is already stopped, which should not be the case. This patch removes rte_eth_dev_stop() from rte_ethtool_net_open(). Signed-off-by: Usman Ta

RE: [EXT] [PATCH 11/40] cryptodev: remove asym crypto next xform

2022-05-26 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Friday, May 27, 2022 8:31 AM > To: Anoob Joseph ; Akhil Goyal ; > dev@dpdk.org; Kiran Kumar Kokkilagadda > Cc: Zhang, Roy Fan ; Umesh Kartha > ; Ramkumar Balu > Subject: RE: [EXT] [PATCH 11/40] cryptodev: remove asym crypto next

RE: [EXT] [PATCH 11/40] cryptodev: remove asym crypto next xform

2022-05-26 Thread Kusztal, ArkadiuszX
Hi Anoob, Sorry, I don't know how I have missed this email! > -Original Message- > From: Anoob Joseph > Sent: Wednesday, May 25, 2022 9:06 AM > To: Kusztal, ArkadiuszX ; Akhil Goyal > ; dev@dpdk.org; Kiran Kumar Kokkilagadda > > Cc: Zhang, Roy Fan ; Umesh Kartha > ; Ramkumar Balu > Sub

[PATCH v1] net/iavf: fix error message in default initialization process

2022-05-26 Thread Wenjun Wu
When kernel driver does not support quanta size configuration, it will return error. We do not expect it to occur in default initialization process. Fixes: b14e8a57b9fe ("net/iavf: support quanta size configuration") Signed-off-by: Wenjun Wu --- drivers/net/iavf/iavf_ethdev.c | 8 +++- 1 fi

[PATCH v5 5/5] raw/afu_mf: add HE-HSSI AFU driver

2022-05-26 Thread Wei Huang
HE-HSSI is one of the host exerciser modules in OFS FPGA, which is used to test HSSI (High Speed Serial Interface). This driver initialize the module and report test result. Signed-off-by: Wei Huang --- drivers/raw/afu_mf/afu_mf_rawdev.c | 3 + drivers/raw/afu_mf/he_hssi.c | 369

[PATCH v5 4/5] raw/afu_mf: add HE-MEM AFU driver

2022-05-26 Thread Wei Huang
HE-MEM is one of the host exerciser modules in OFS FPGA, which is used to test local memory with built-in traffic generator. This driver initialize the module and report test result. Signed-off-by: Wei Huang --- drivers/raw/afu_mf/afu_mf_rawdev.c | 3 + drivers/raw/afu_mf/he_mem.c| 181

[PATCH v5 3/5] raw/afu_mf: add HE-LBK AFU driver

2022-05-26 Thread Wei Huang
HE-LBK and HE-MEM-LBK are host exerciser modules in OFS FPGA, HE-LBK is used to test PCI bus and HE-MEM-LBK is used to test local memory. This driver initialize the modules and report test result. Signed-off-by: Wei Huang --- drivers/raw/afu_mf/afu_mf_rawdev.c | 5 + drivers/raw/afu_mf/he_lbk.

[PATCH v5 2/5] raw/afu_mf: add N3000 AFU driver

2022-05-26 Thread Wei Huang
N3000 AFU includes NLB0 and DMA modules, NLB0 is used to test PCI bus and DMA is used to test local memory. This driver initialize the modules and report test result. Signed-off-by: Wei Huang --- drivers/raw/afu_mf/afu_mf_rawdev.c |4 + drivers/raw/afu_mf/afu_mf_rawdev.h | 18 + drivers/ra

[PATCH v5 1/5] drivers/raw: introduce AFU raw device driver

2022-05-26 Thread Wei Huang
Add multi-function AFU raw device driver to manage various AFU (Acceleration Function Unit) in FPGA. This driver implements common AFU raw device interfaces and exposes them to application as standard raw device APIs. Normal application can operate specified AFU as below, 1. call rte_rawdev_pmd_get

[PATCH v5 0/5] introduce afu_mf raw device driver

2022-05-26 Thread Wei Huang
The first patch implements the framework of the AFU raw device driver. The subsequent patches implement the driver of some AFUs. Wei Huang (5): drivers/raw: introduce AFU raw device driver raw/afu_mf: add N3000 AFU driver raw/afu_mf: add HE-LBK AFU driver raw/afu_mf: add HE-MEM AFU driver

Re: [PATCH] ethtool: correct format strings according to the arguments

2022-05-26 Thread Huzaifa Rahman
Hi, The following tests are failing but my patch is not related to anything related to these. Please re-run the tests. Failed Tests: - mtu_update - scatter Thanks, Huzaifa On Thu, Mar 24, 2022 at 10:31 AM huzaifa.rahman wrote: > The corrected format strings

Re: [PATCH v2] ethtool: added help command to list all available

2022-05-26 Thread Huzaifa Rahman
Hi, The following tests are failing but my patch is not related to anything related to these. Please re-run the tests. Failed Tests: - mtu_update - scatter Thanks, Huzaifa On Tue, Mar 22, 2022 at 2:36 PM huzaifa.rahman wrote: > Help command is not available

RE: [PATCH] net/iavf: increase the reset complete wait count

2022-05-26 Thread Yang, Qiming
sure > -Original Message- > From: Zhang, Qi Z > Sent: 2022年5月27日 12:28 > To: Yang, Qiming ; dev@dpdk.org > Cc: Xing, Beilei ; Yang, Qiming > ; sta...@dpdk.org > Subject: RE: [PATCH] net/iavf: increase the reset complete wait count > > > > > -Original Message- > > From: Qiming Y

RE: [PATCH] net/iavf: increase the reset complete wait count

2022-05-26 Thread Zhang, Qi Z
> -Original Message- > From: Qiming Yang > Sent: Friday, May 27, 2022 10:13 AM > To: dev@dpdk.org > Cc: Xing, Beilei ; Yang, Qiming > ; sta...@dpdk.org > Subject: [PATCH] net/iavf: increase the reset complete wait count > > Kernel iavf driver has sent patch to increase the completion w

RE: [PATCH v3 5/5] guides/rawdevs: add description of ofs in ifpga doc

2022-05-26 Thread Zhang, Tianfei
> -Original Message- > From: Huang, Wei > Sent: Thursday, May 26, 2022 11:33 AM > To: dev@dpdk.org; tho...@monjalon.net; nipun.gu...@nxp.com; > hemant.agra...@nxp.com > Cc: sta...@dpdk.org; Xu, Rosen ; Zhang, Tianfei > ; Zhang, Qi Z ; Huang, Wei > > Subject: [PATCH v3 5/5] guides/rawde

RE: [PATCH v3 4/5] raw/ifpga: support ofs card probe

2022-05-26 Thread Zhang, Tianfei
> -Original Message- > From: Huang, Wei > Sent: Thursday, May 26, 2022 11:33 AM > To: dev@dpdk.org; tho...@monjalon.net; nipun.gu...@nxp.com; > hemant.agra...@nxp.com > Cc: sta...@dpdk.org; Xu, Rosen ; Zhang, Tianfei > ; Zhang, Qi Z ; Huang, Wei > > Subject: [PATCH v3 4/5] raw/ifpga: s

[PATCH] net/iavf: increase the reset complete wait count

2022-05-26 Thread Qiming Yang
Kernel iavf driver has sent patch to increase the completion wait time to reduce the "Reset never finished" case. Follow this action in DPDK iavf driver. Fixes: 22b123a36d07 ("net/avf: initialize PMD") Cc: sta...@dpdk.org Signed-off-by: Qiming Yang --- drivers/net/iavf/iavf.h | 2 +- 1 file cha

RE: [PATCH v3 3/5] raw/ifpga: unregister interrupt in ifpga close function

2022-05-26 Thread Zhang, Tianfei
> -Original Message- > From: Huang, Wei > Sent: Thursday, May 26, 2022 11:33 AM > To: dev@dpdk.org; tho...@monjalon.net; nipun.gu...@nxp.com; > hemant.agra...@nxp.com > Cc: sta...@dpdk.org; Xu, Rosen ; Zhang, Tianfei > ; Zhang, Qi Z ; Huang, Wei > > Subject: [PATCH v3 3/5] raw/ifpga: u

RE: [PATCH v4] sched: enable traffic class oversubscription conditionally

2022-05-26 Thread Danilewicz, MarcinX
Hi all, Going trough all notes on http://patches.dpdk.org/project/dpdk/patch/20220427092357.491720-1-marcinx.danilew...@intel.com/ please find my answers inline here. First of all please take my apologies, for not checking url as above on regular basis. I was awaiting for mails with me on

[PATCH v5] sched: enable traffic class oversubscription conditionally

2022-05-26 Thread Marcin Danilewicz
Added new API to enable or disable TC over subscription for best effort traffic class at subport level. Added changes after review and increased throughput. By default TC OV is disabled. History: - v1 - TC OV disabled by default - v2 - throughput improvements - v3, v4, v5 - changes from comments

RE: [PATCH v3] sched: enable/disable TC OV at runtime

2022-05-26 Thread Danilewicz, MarcinX
Hi Stephen, You are absolutely right, but that was not my intention or something I've configured. My e-mail client wasn't sending this alsoe. Perhaps something like email-server or something else was enabled in between. I sent patch as per usual and to my surprise I found that message. My apolo

Confirm if rte_ipv4_udptcp_cksum_verify should be experimental

2022-05-26 Thread Ben Magistro
This may simply be a docs and signature mismatch (or macro wasn't available at the time, didn't check that aspect) but the function rte_ipv4_udptcp_cksum_verify() is marked as experimental in the signature but not in the associated function comments (doxygen). Should this function be considered ex

[PATCH v2] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 devices

2022-05-26 Thread Jeff Daly
1G Cu SFPs are not officially supported on the X552/X553 family of devices but create an option cu_sfp_as_sx to treat them as 1G SX modules since they usually work. Print a warning though since support isn't validated, similar to what already happens for other unofficially supported SFPs enabled v

[PATCH v5 3/3] rte_pie: fix incorrect floating point math

2022-05-26 Thread Stephen Hemminger
The function rte_pie_drop was attempting to do a random probability drop, but because of incorrect usage of fixed point divide it would always return 1. Change to use new rte_drand() instead. Fixes: 44c730b0e379 ("sched: add PIE based congestion management") Signed-off-by: Stephen Hemminger ---

[PATCH v5 2/3] rte_pie: remove unnecessary floating point

2022-05-26 Thread Stephen Hemminger
The qdelay variable is derived from and compared to 64 bit value so it doesn't have to be floating point. Fixes: 44c730b0e379 ("sched: add PIE based congestion management") Signed-off-by: Stephen Hemminger --- lib/sched/rte_pie.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v5 1/3] random: add rte_drand() function

2022-05-26 Thread Stephen Hemminger
The PIE code and other applications can benefit from having a fast way to get a random floating point value. This new function is equivalent to drand() in the standard library. Signed-off-by: Stephen Hemminger Acked-by: Ray Kinsella --- app/test/test_rand_perf.c | 7 +++ doc/g

[PATCH v5 0/3] introduce random floating point function

2022-05-26 Thread Stephen Hemminger
Introduce a new random number function to get a floating point value. Then use it to fix PIE scheduler. v5 - use divide method (similar to FreeBSD) it takes same number of cycles (after optimization) and works on all platforms. Stephen Hemminger (3): random: add rte_drand() functio

Re: [PATCH v4 1/3] random: add rte_drand() function

2022-05-26 Thread Stephen Hemminger
On Thu, 26 May 2022 15:20:29 +0200 Mattias Rönnblom wrote: > On 2022-05-25 22:31, Stephen Hemminger wrote: > > The PIE code and other applications can benefit from having a > > fast way to get a random floating point value. This new function > > is equivalent to drand() in the standard library. >

Re: [PATCH 1/2] doc: update required kernel version to 4.9

2022-05-26 Thread Stephen Hemminger
On Thu, 17 Feb 2022 08:45:16 -0800 Stephen Hemminger wrote: > The 4.4 kernel has passed its end of life date (after 6 years). > It is no longer supported and therefore DPDK should update > its minimum required kernel version. > > Signed-off-by: Stephen Hemminger > --- > doc/guides/linux_gsg/sy

[Bug 1018] Segfault in debug_autotest on Alpine

2022-05-26 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1018 Bug ID: 1018 Summary: Segfault in debug_autotest on Alpine Product: DPDK Version: unspecified Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal

RE: [PATCH v2 0/2] crypto/qat: add secp384r1 curve support

2022-05-26 Thread Akhil Goyal
> > This patchset adds secp384r1 (P-384) elliptic > > curve to Intel QuickAssist Technology crypto PMD. > > > > v2: > > - added release notes > > > > Arek Kusztal (2): > > crypto/qat: refactor asym algorithm macros and logs > > crypto/qat: add secp384r1 curve > > > > doc/guides/rel_notes/relea

RE: [EXT] [PATCH] cryptodev: add support for 25519 and 448 curves

2022-05-26 Thread Akhil Goyal
> > > This commit adds support for following elliptic curves: > > > 1) Curve25519 > > > 2) Curve448 > > > > > > Signed-off-by: Arek Kusztal > > > --- Acked-by: Akhil Goyal Applied to dpdk-next-crypto

RE: [PATCH] crypto/qat: enable asymmetric crypto on gen4 device

2022-05-26 Thread Akhil Goyal
> Acked-by: Ji, Kai Please be consistent in Acks Corrected this to Acked-by: Kai Ji > > > This commit enables asymmetric crypto in generation four devices (4xxx). > > > > Signed-off-by: Arek Kusztal Applied to dpdk-next-crypto

RE: [dpdk-dev v2] crypto/qat: fix of offset and length assignment

2022-05-26 Thread Akhil Goyal
> > > > This patch fix the cipher & auth offset and length values when convert > > mbuf to vector chain for QAT build op. > > > > Fixes: a815a04cea05 ("crypto/qat: support symmetric build op request") > > > > Signed-off-by: Kai Ji > > --- > Acked-by: Fan Zhang Applied to dpdk-next-crypto Thanks

RE: [EXT] Re: [PATCH 1/1] drivers: define OPENSSL_API_COMPAT

2022-05-26 Thread Akhil Goyal
> On Tue, May 10, 2022 at 5:06 PM Heinrich Schuchardt > wrote: > > > > The API of the OpenSSL library has changed with version 3.0. This results > > in a lot of compiler warnings like > > > > ../dpdk/drivers/crypto/ccp/ccp_crypto.c:182:9: > > warning: ‘SHA256_Transform’ is deprecated: > >

RE: [EXT] [PATCH v2 0/2] add partial SGL support to AESNI_MB

2022-05-26 Thread Akhil Goyal
> This patchset adds SGL support for GCM and CHACHA20-POLY1305 algorithms, > using the IPSec-MB JOB API. > > Supported SGL types: > - INPLACE SGL > - OOP SGL IN, LB OUT > - OOP SGL IN, SGL OUT > > The SGL Feature Flags for AESNI_MB PMD are not added, > as it does not yet support SGL for all ot

Re: [PATCH v4 1/3] random: add rte_drand() function

2022-05-26 Thread Stephen Hemminger
On Thu, 26 May 2022 15:20:29 +0200 Mattias Rönnblom wrote: > > +#else > > + /* Slower method requiring floating point divide > > +* > > Do you know how much slower? I ran rand_perf_test on two of my systems. > >AMD 5900X Pi4 (ARM Cortex-A72) > IEEE754 version

Re: [PATCH v4 1/3] random: add rte_drand() function

2022-05-26 Thread Stephen Hemminger
On Thu, 26 May 2022 15:20:29 +0200 Mattias Rönnblom wrote: > > @@ -55,6 +58,9 @@ test_rand_perf_type(enum rand_type rand_type) > > case rand_type_64: > > sum += rte_rand(); > > break; > > + case rand_type_float: > > +

Re: [PATCH v3 1/2] eal: get/set thread priority per thread identifier

2022-05-26 Thread Stephen Hemminger
On Wed, 25 May 2022 23:29:57 -0700 Tyler Retzlaff wrote: > On Tue, May 24, 2022 at 07:51:05AM -0700, Stephen Hemminger wrote: > > On Tue, 24 May 2022 04:08:36 -0700 > > Tyler Retzlaff wrote: > > > > > +static int > > > +thread_map_priority_to_os_value(enum rte_thread_priority eal_pri, > > > +

RE: [EXT] [PATCH v2 14/14] cryptodev: add asym algorithms capabilities

2022-05-26 Thread Akhil Goyal
> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Thursday, May 26, 2022 7:49 PM > To: Akhil Goyal ; dev@dpdk.org > Cc: Zhang, Roy Fan > Subject: RE: [EXT] [PATCH v2 14/14] cryptodev: add asym algorithms > capabilities > > > > > -Original Message- > > From: Akhil Goy

RE: [PATCH v5 1/4] lib/ethdev: introduce protocol type based buffer split

2022-05-26 Thread Ding, Xuan
Hi, > -Original Message- > From: Ding, Xuan > Sent: Thursday, May 19, 2022 10:40 PM > To: Thomas Monjalon ; Wang, YuanX > ; Wu, WenxuanX > Cc: andrew.rybche...@oktetlabs.ru; Li, Xiaoyun ; > ferruh.yi...@xilinx.com; Singh, Aman Deep ; > dev@dpdk.org; Zhang, Yuying ; Zhang, Qi Z > ; jerinj

[PATCH v2] net/nfp: fix bug of disable VLAN strip

2022-05-26 Thread Peng Zhang
"vlan set strip off 0" can't work, due to the incorrect usage of the mask, it just represent that the status is changed or not, not represent offloaded or not, so that the driver send the error control message to the nic. Now, by first inspect the mask of things that changed, and then change the r

RE: [EXT] [PATCH v2 14/14] cryptodev: add asym algorithms capabilities

2022-05-26 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Akhil Goyal > Sent: Thursday, May 26, 2022 2:54 PM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: Zhang, Roy Fan > Subject: RE: [EXT] [PATCH v2 14/14] cryptodev: add asym algorithms > capabilities > > > - Added asymmetric crypto algorithm specific capabil

RE: [EXT] [PATCH v3 7/7] doc: add missing authentication algorithm

2022-05-26 Thread Akhil Goyal
> Adding the missing SHA256-HMAC authentication algorithm > in ipsec-secgw guide. > > Fixes: b5350285ce6e ("examples/ipsec-secgw: support SHA256 HMAC") > Cc: sta...@dpdk.org > > Signed-off-by: Gagandeep Singh Acked-by: Akhil Goyal

RE: [EXT] [PATCH v3 6/7] test/crypto: add short MAC-I test vector for zuc

2022-05-26 Thread Akhil Goyal
> Add a ZUC based short MAC-I test vector. > > Signed-off-by: Gagandeep Singh > --- Acked-by: Akhil Goyal

RE: [EXT] [PATCH v3 5/7] test/crypto: support raw buffer APIs for PDCP

2022-05-26 Thread Akhil Goyal
> This patch supports raw buffer APIs testing for > PDCP test cases. > > Signed-off-by: Gagandeep Singh > --- Acked-by: Akhil Goyal

RE: [EXT] [PATCH v3 4/7] test/crypto: fix PMD name for dpaa raw buffer crypto driver

2022-05-26 Thread Akhil Goyal
> PMD name for DPAA raw buffer crypto driver test cases is > updated with correct name. > > Fixes: cd8166c28cd1 ("test/crypto: add raw API test for dpaax") > Cc: sta...@dpdk.org > > Signed-off-by: Gagandeep Singh Acked-by: Akhil Goyal

RE: [EXT] [PATCH v3 3/7] examples/l2fwd-crypto: add signal handler for exit

2022-05-26 Thread Akhil Goyal
Hi Stephen, > Handle SIGINT and SIGTERM signals. > > Signed-off-by: Gagandeep Singh > --- Do you have more comments on this? If not, can you please ack? > examples/l2fwd-crypto/main.c | 16 > 1 file changed, 16 insertions(+) > > diff --git a/examples/l2fwd-crypto/main.c b/exa

RE: [EXT] [PATCH v3 2/7] examples/ipsec-secgw: support XCBC-MAC/DES-CBC

2022-05-26 Thread Akhil Goyal
> ipsec-secgw application is updated to support > DES-CBC ciphering and XCBC-MAC authentication > based IPsec functionality. > > Signed-off-by: Gagandeep Singh > --- Acked-by: Akhil Goyal

RE: [EXT] [PATCH v3 1/7] app/test-crypto-perf: support SDAP for PDCP operations

2022-05-26 Thread Akhil Goyal
> Add a command line option "--enable-sdap" to enable > Service Data Adaptation Protocol. > > example command: > ./dpdk-test-crypto-perf -c 0xc --log-level=8 -- > --devtype crypto_dpaa2_sec --optype pdcp --cipher-algo aes-ctr > --cipher-op encrypt --auth-algo zuc-eia3 --auth-op generate > --auth-

RE: [EXT] [dpdk-dev v4] crypto/qat: use intel-ipsec-mb for partial hash & aes

2022-05-26 Thread Akhil Goyal
> > > Since openssl 3.0 now deprecates the low level API QAT required to > > perform partial hash & aes operation when creating the session. This > > patch add in qat_ipsec_mb_lib driver parameter to allow QAT PMD to > > switch APIs between openssl and intel ipsec-mb library. > > > > Signed-off-

RE: [EXT] [dpdk-dev v4] crypto/qat: use intel-ipsec-mb for partial hash & aes

2022-05-26 Thread Akhil Goyal
> Since openssl 3.0 now deprecates the low level API QAT required to > perform partial hash & aes operation when creating the session. This > patch add in qat_ipsec_mb_lib driver parameter to allow QAT PMD to > switch APIs between openssl and intel ipsec-mb library. > > Signed-off-by: Kai Ji > Si

Re: [PATCH v2 0/4] ethdev: separate metering and marking from policing

2022-05-26 Thread Jerin Jacob
On Thu, May 26, 2022 at 6:51 PM Jerin Jacob wrote: > > On Sun, May 22, 2022 at 4:21 PM Alexander Kozyrev wrote: > > > > Extend Metering and Marking support in the Flow API: > > 1. Add METER_COLOR item to match Color Marker set by a Meter. > > 2. Add the ability to set Color Marker via modify_fiel

Re: [PATCH v2 0/4] ethdev: separate metering and marking from policing

2022-05-26 Thread Jerin Jacob
On Sun, May 22, 2022 at 4:21 PM Alexander Kozyrev wrote: > > Extend Metering and Marking support in the Flow API: > 1. Add METER_COLOR item to match Color Marker set by a Meter. > 2. Add the ability to set Color Marker via modify_field Flow API. > 3. Add Meter API to get profile/policy objects. >

Re: [PATCH v4 1/3] random: add rte_drand() function

2022-05-26 Thread Mattias Rönnblom
On 2022-05-25 22:31, Stephen Hemminger wrote: The PIE code and other applications can benefit from having a fast way to get a random floating point value. This new function is equivalent to drand() in the standard library. Signed-off-by: Stephen Hemminger --- app/test/test_rand_perf.c

RE: [EXT] [PATCH v2 14/14] cryptodev: add asym algorithms capabilities

2022-05-26 Thread Akhil Goyal
> - Added asymmetric crypto algorithm specific capability struct. > Included fields like random number capability, padding flags etc. > > Signed-off-by: Arek Kusztal > --- > app/test-crypto-perf/main.c | 12 +- > app/test-eventdev/test_perf_common.c | 2 +- > app/test

RE: [EXT] [PATCH v2 11/14] cryptodev: move RSA padding into separate struct

2022-05-26 Thread Akhil Goyal
> > > > > /** > > > > > + * RSA padding type > > > > > + */ > > > > > +struct rte_crypto_rsa_padding { > > > > > + enum rte_crypto_rsa_padding_type type; > > > > > + /**< RSA padding scheme to be used for transform */ > > > > > + enum rte_crypto_auth_algorithm md; > > > > > + /**

RE: [PATCH v2 0/4] ethdev: separate metering and marking from policing

2022-05-26 Thread Ori Kam
Please add testpmd implenetation for this patch set. It can be part of each patch or just one patch. Best, Ori

RE: [EXT] [PATCH v2 11/14] cryptodev: move RSA padding into separate struct

2022-05-26 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Akhil Goyal > Sent: Thursday, May 26, 2022 2:20 PM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: Zhang, Roy Fan > Subject: RE: [EXT] [PATCH v2 11/14] cryptodev: move RSA padding into separate > struct > > > > > /** > > > > + * RSA padding type > > > > +

RE: [PATCH v2 4/4] ethdev: add meter color mark flow action

2022-05-26 Thread Ori Kam
Hi Alexander, > -Original Message- > From: Alexander Kozyrev > Sent: Sunday, May 22, 2022 1:51 PM > Subject: [PATCH v2 4/4] ethdev: add meter color mark flow action > > Create a new Flow API action: METER_MARK. > It Meters an IP packet stream and marks its packets with colors. > Unlike

RE: [PATCH v2 3/4] ethdev: get meter profile/policy objects

2022-05-26 Thread Ori Kam
Hi Alexander, > -Original Message- > From: Alexander Kozyrev > Sent: Sunday, May 22, 2022 1:51 PM > Subject: [PATCH v2 3/4] ethdev: get meter profile/policy objects > > Introduce a new Meter API to retrieve a Meter profile and policy > objects using the profile/policy ID previously creat

RE: [PATCH v2 2/4] ethdev: allow meter color marker modification

2022-05-26 Thread Ori Kam
Hi Alex, > -Original Message- > From: Alexander Kozyrev > Sent: Sunday, May 22, 2022 1:51 PM > Subject: [PATCH v2 2/4] ethdev: allow meter color marker modification > > Extend modify_field Flow API with support of Meter Color Marker > modifications. It allows setting the packet's metadat

RE: [EXT] [PATCH v2 11/14] cryptodev: move RSA padding into separate struct

2022-05-26 Thread Akhil Goyal
> > > /** > > > + * RSA padding type > > > + */ > > > +struct rte_crypto_rsa_padding { > > > + enum rte_crypto_rsa_padding_type type; > > > + /**< RSA padding scheme to be used for transform */ > > > + enum rte_crypto_auth_algorithm md; > > > + /**< > > > + * RSA padding hash function > > > + *

RE: [PATCH v2 1/4] ethdev: add meter color flow matching item

2022-05-26 Thread Ori Kam
Hi Alexander, > -Original Message- > From: Alexander Kozyrev > Sent: Sunday, May 22, 2022 1:51 PM > Subject: [PATCH v2 1/4] ethdev: add meter color flow matching item > > Provide an ability to use a Color Marker set by a Meter > as a matching item in Flow API. The Color Marker reflects >

RE: [EXT] [PATCH v2 12/14] cryptodev: clarify rsa verify with none padding

2022-05-26 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Akhil Goyal > Sent: Thursday, May 26, 2022 2:07 PM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: Zhang, Roy Fan > Subject: RE: [EXT] [PATCH v2 12/14] cryptodev: clarify rsa verify with none > padding > > > - Clarified where should output be stored of sign

RE: [EXT] [PATCH v2 11/14] cryptodev: move RSA padding into separate struct

2022-05-26 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Akhil Goyal > Sent: Thursday, May 26, 2022 2:05 PM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: Zhang, Roy Fan > Subject: RE: [EXT] [PATCH v2 11/14] cryptodev: move RSA padding into separate > struct > > > /** > > + * RSA padding type > > + */ > > +stru

RE: [EXT] [PATCH v2 13/14] cryptodev: add salt length and optional label

2022-05-26 Thread Akhil Goyal
> - Added salt length and optional label. > Common parameters to PSS and OAEP padding for RSA. > - Fixed hash API in RSA padding. > Now it is specified how hash should be used with > particular RSA padding modes. > > Signed-off-by: Arek Kusztal > --- Acked-by: Akhil Goyal

RE: [EXT] [PATCH v2 12/14] cryptodev: clarify rsa verify with none padding

2022-05-26 Thread Akhil Goyal
> - Clarified where should output be stored of signature > decryption with padding none. > PMD is not able to know what padding algorithm was used, > therefore decrypted signature should be returned to the user. > > Signed-off-by: Arek Kusztal > --- > lib/cryptodev/rte_crypto_asym.h | 7 ++-

RE: [EXT] [PATCH v2 11/14] cryptodev: move RSA padding into separate struct

2022-05-26 Thread Akhil Goyal
> /** > + * RSA padding type > + */ > +struct rte_crypto_rsa_padding { > + enum rte_crypto_rsa_padding_type type; > + /**< RSA padding scheme to be used for transform */ > + enum rte_crypto_auth_algorithm md; > + /**< > + * RSA padding hash function > + * > + * When

RE: [EXT] [PATCH v2 10/14] cryptodev: clarify usage of rsa padding hash

2022-05-26 Thread Akhil Goyal
> - Clarified usage of RSA padding hash. > It was not specified how to use hash for PKCS1_5 > padding. This could lead to incorrect implementation. > > Signed-off-by: Arek Kusztal > --- > lib/cryptodev/rte_crypto_asym.h | 25 + > 1 file changed, 21 insertions(+), 4 deleti

RE: [EXT] [PATCH v2 09/14] cryptodev: add asym op flags

2022-05-26 Thread Akhil Goyal
> - Added flags to rte_crypto_asym_op struct. > It may be shared between different algorithms. > - Added Diffie-Hellman padding flags. > Diffie-Hellman padding is used in certain protocols, > in others, leading zero bytes need to be stripped. > Even same protocol may use a different approach - most

RE: [EXT] [PATCH v2 08/14] cryptodev: add public key verify option

2022-05-26 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Akhil Goyal > Sent: Thursday, May 26, 2022 1:34 PM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: Zhang, Roy Fan > Subject: RE: [EXT] [PATCH v2 08/14] cryptodev: add public key verify option > > > - Added key exchange public key verify option. > > For some

RE: [EXT] [PATCH v2 07/14] cryptodev: add elliptic curve diffie hellman

2022-05-26 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Akhil Goyal > Sent: Thursday, May 26, 2022 1:29 PM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: Zhang, Roy Fan > Subject: RE: [EXT] [PATCH v2 07/14] cryptodev: add elliptic curve diffie > hellman > > > - Added elliptic curve Diffie-Hellman parameters. >

RE: [EXT] [PATCH v2 08/14] cryptodev: add public key verify option

2022-05-26 Thread Akhil Goyal
> - Added key exchange public key verify option. > For some elliptic curves public point in DH exchange > needs to be checked, if it lays on the curve. > Modular exponentiation needs certain checks as well, though > mathematically much easier. > This commit adds verify option to asym_op operations.

RE: [EXT] [PATCH v2 07/14] cryptodev: add elliptic curve diffie hellman

2022-05-26 Thread Akhil Goyal
> - Added elliptic curve Diffie-Hellman parameters. > Point multiplication allows the user to process every phase of > ECDH, but for phase 1, user should not really care about the generator. > The user does not even need to know what the generator looks like, > therefore setting ec xform would make

RE: [EXT] [PATCH v2 06/14] cryptodev: move dh type from xform to dh op

2022-05-26 Thread Akhil Goyal
> - Moved dh operation type to dh operation struct. > Operation type (PUBLIC_KEY_GENERATION, SHARED_SECRET) should > be free to choose for any operation. One xform/session should > be enough to perform both DH operations, if op_type would be xform > member, session would have to be to be created tw

RE: [EXT] [PATCH v2 03/14] cryptodev: separate key exchange operation enum

2022-05-26 Thread Akhil Goyal
> > > /** > > > + * Asymmetric crypto key exchange operation type */ enum > > > +rte_crypto_asym_ke_type { > > > + RTE_CRYPTO_ASYM_KE_PRIVATE_KEY_GENERATE, > > > > Is it better to shorten it to > > RTE_CRYPTO_ASYM_KE_PRIV_KEY_GENERATE > > RTE_CRYPTO_ASYM_KE_PUB_KEY_GENERATE > +1, Actually I am no

RE: [EXT] [PATCH v2 03/14] cryptodev: separate key exchange operation enum

2022-05-26 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Akhil Goyal > Sent: Thursday, May 26, 2022 12:58 PM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: Zhang, Roy Fan > Subject: RE: [EXT] [PATCH v2 03/14] cryptodev: separate key exchange > operation enum > > > /** > > + * Asymmetric crypto key exchange oper

RE: [EXT] [PATCH v2 05/14] cryptodev: clarify usage of private key in dh

2022-05-26 Thread Akhil Goyal
> - Clarified usage of private key in Diffie-Hellman. > CSRNG capable device should generate private key and then > use it for public key generation. > > Signed-off-by: Arek Kusztal > --- > lib/cryptodev/rte_crypto_asym.h | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/lib/cryptod

Re: [PATCH] eal/ppc: undefine AltiVec keyword vector

2022-05-26 Thread Ray Kinsella
Thomas Monjalon writes: > 25/05/2022 20:34, Tyler Retzlaff: >> On Wed, May 25, 2022 at 07:02:52PM +0100, Ray Kinsella wrote: >> > Thomas Monjalon writes: >> > > 25/05/2022 13:48, Ray Kinsella: >> > >> Thomas Monjalon writes: >> > >> >> > >> > The AltiVec header file is defining "vector", exc

RE: [EXT] [PATCH v2 04/14] cryptodev: remove comment about using ephemeral key in dsa

2022-05-26 Thread Akhil Goyal
> -Original Message- > From: Arek Kusztal > Sent: Wednesday, May 25, 2022 9:23 PM > To: dev@dpdk.org > Cc: Akhil Goyal ; roy.fan.zh...@intel.com; Arek Kusztal > > Subject: [EXT] [PATCH v2 04/14] cryptodev: remove comment about using > ephemeral key in dsa > > External Email > > -

RE: [EXT] [PATCH v2 03/14] cryptodev: separate key exchange operation enum

2022-05-26 Thread Akhil Goyal
> /** > + * Asymmetric crypto key exchange operation type > + */ > +enum rte_crypto_asym_ke_type { > + RTE_CRYPTO_ASYM_KE_PRIVATE_KEY_GENERATE, Is it better to shorten it to RTE_CRYPTO_ASYM_KE_PRIV_KEY_GENERATE RTE_CRYPTO_ASYM_KE_PUB_KEY_GENERATE > + /**< Private Key generation operatio

[dpdk-dev v4] crypto/qat: use intel-ipsec-mb for partial hash & aes

2022-05-26 Thread Kai Ji
Since openssl 3.0 now deprecates the low level API QAT required to perform partial hash & aes operation when creating the session. This patch add in qat_ipsec_mb_lib driver parameter to allow QAT PMD to switch APIs between openssl and intel ipsec-mb library. Signed-off-by: Kai Ji Signed-off-by: F

Re: [PATCH] eal/ppc: undefine AltiVec keyword vector

2022-05-26 Thread Thomas Monjalon
25/05/2022 20:34, Tyler Retzlaff: > On Wed, May 25, 2022 at 07:02:52PM +0100, Ray Kinsella wrote: > > Thomas Monjalon writes: > > > 25/05/2022 13:48, Ray Kinsella: > > >> Thomas Monjalon writes: > > >> > > >> > The AltiVec header file is defining "vector", except in C++ build. > > >> > The keywo

Re: [PATCH v3 5/5] ethdev: fix dev state when stop

2022-05-26 Thread Thomas Monjalon
25/05/2022 19:44, Ferruh Yigit: > On 5/3/2022 11:02 AM, Min Hu (Connor) wrote: > > Currently, 'dev_started' is always set to be 0 when dev stop, whether > > it succeeded or failed. This is unreasonable and this patch fixed it. > > > > Fixes: 62024eb82756 ("ethdev: change stop operation callback to

RE: [EXT] [PATCH v2 02/14] cryptodev: reduce number of comments in asym xform

2022-05-26 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Akhil Goyal > Sent: Thursday, May 26, 2022 11:52 AM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: Zhang, Roy Fan > Subject: RE: [EXT] [PATCH v2 02/14] cryptodev: reduce number of comments in > asym xform > > > - Reduced number of comments in asymmetric xf

Re: [PATCH v4 1/3] random: add rte_drand() function

2022-05-26 Thread Ray Kinsella
Stephen Hemminger writes: > The PIE code and other applications can benefit from having a > fast way to get a random floating point value. This new function > is equivalent to drand() in the standard library. > > Signed-off-by: Stephen Hemminger > --- > app/test/test_rand_perf.c

Re: [PATCH 2/3] common/sfc_efx/base: manage VNIC MAC address by MCDI handle

2022-05-26 Thread Ray Kinsella
Ivan Malov writes: > The board admin may need to assign a MAC address to a guest > VNIC identified by its MCDI handle. Provide an API for that. > > In the case when a libefx-based driver is used at the guest, > it will need to check its MAC address using the symmetrical > API if the admin has t

RE: [EXT] [PATCH v2 02/14] cryptodev: reduce number of comments in asym xform

2022-05-26 Thread Akhil Goyal
> - Reduced number of comments in asymmetric xform. > Information describing basic functionality of well known > algorithms are unnecessary. > - Removed NONE asymetric xform. I commented on v1 not to remove this and I do not see comment from your side for removing it. > > Signed-off-by: Arek Kus

RE: [v7, 08/11] examples/fips_validation: add parsing for cmac

2022-05-26 Thread Zhang, Roy Fan
> -Original Message- > From: Gowrishankar Muthukrishnan > Sent: Thursday, May 26, 2022 9:02 AM > To: dev@dpdk.org > Cc: Zhang, Roy Fan ; Dooley, Brian > ; lylav...@iol.unh.edu; Anoob Joseph > ; Archana Muniganti ; > Jerin Jacob ; Brandon Lo ; > Gowrishankar Muthukrishnan > Subject: [v7, 0

RE: [v7, 07/11] examples/fips_validation: implement json cmac test

2022-05-26 Thread Zhang, Roy Fan
> -Original Message- > From: Gowrishankar Muthukrishnan > Sent: Thursday, May 26, 2022 9:02 AM > To: dev@dpdk.org > Cc: Zhang, Roy Fan ; Dooley, Brian > ; lylav...@iol.unh.edu; Anoob Joseph > ; Archana Muniganti ; > Jerin Jacob ; Brandon Lo > Subject: [v7, 07/11] examples/fips_validation:

RE: [v7, 06/11] examples/fips_validation: add json to hmac

2022-05-26 Thread Zhang, Roy Fan
> -Original Message- > From: Gowrishankar Muthukrishnan > Sent: Thursday, May 26, 2022 9:02 AM > To: dev@dpdk.org > Cc: Zhang, Roy Fan ; Dooley, Brian > ; lylav...@iol.unh.edu; Anoob Joseph > ; Archana Muniganti ; > Jerin Jacob ; Brandon Lo > Subject: [v7, 06/11] examples/fips_validation:

RE: [v7, 05/11] examples/fips_validation: add json to gcm test

2022-05-26 Thread Zhang, Roy Fan
> -Original Message- > From: Gowrishankar Muthukrishnan > Sent: Thursday, May 26, 2022 9:02 AM > To: dev@dpdk.org > Cc: Zhang, Roy Fan ; Dooley, Brian > ; lylav...@iol.unh.edu; Anoob Joseph > ; Archana Muniganti ; > Jerin Jacob ; Brandon Lo > Subject: [v7, 05/11] examples/fips_validation:

RE: [v7, 04/11] examples/fips_validation: allow json file as input

2022-05-26 Thread Zhang, Roy Fan
> -Original Message- > From: Gowrishankar Muthukrishnan > Sent: Thursday, May 26, 2022 9:02 AM > To: dev@dpdk.org > Cc: Zhang, Roy Fan ; Dooley, Brian > ; lylav...@iol.unh.edu; Anoob Joseph > ; Archana Muniganti ; > Jerin Jacob ; Brandon Lo ; > Gowrishankar Muthukrishnan > Subject: [v7, 0

RE: [v7, 03/11] examples/fips_validation: add json parsing

2022-05-26 Thread Zhang, Roy Fan
> -Original Message- > From: Gowrishankar Muthukrishnan > Sent: Thursday, May 26, 2022 9:02 AM > To: dev@dpdk.org > Cc: Zhang, Roy Fan ; Dooley, Brian > ; lylav...@iol.unh.edu; Anoob Joseph > ; Archana Muniganti ; > Jerin Jacob ; Brandon Lo > Subject: [v7, 03/11] examples/fips_validation:

RE: [v7, 02/11] examples/fips_validation: add json info to header

2022-05-26 Thread Zhang, Roy Fan
> -Original Message- > From: Gowrishankar Muthukrishnan > Sent: Thursday, May 26, 2022 9:02 AM > To: dev@dpdk.org > Cc: Zhang, Roy Fan ; Dooley, Brian > ; lylav...@iol.unh.edu; Anoob Joseph > ; Archana Muniganti ; > Jerin Jacob ; Brandon Lo ; > Gowrishankar Muthukrishnan > Subject: [v7, 0

RE: [v7, 01/11] examples/fips_validation: add jansson dependency

2022-05-26 Thread Zhang, Roy Fan
> -Original Message- > From: Gowrishankar Muthukrishnan > Sent: Thursday, May 26, 2022 9:02 AM > To: dev@dpdk.org > Cc: Zhang, Roy Fan ; Dooley, Brian > ; lylav...@iol.unh.edu; Anoob Joseph > ; Archana Muniganti ; > Jerin Jacob ; Brandon Lo > Subject: [v7, 01/11] examples/fips_validation:

RE: [EXT] [PATCH v2 01/14] cryptodev: redefine ec group enum

2022-05-26 Thread Akhil Goyal
> - EC enum was renamed to rte_crypto_curve_id. > Elliptic curve enum name was incorrectly associated > with group (it comes from current tls registry name). > - Clarified comments about TLS deprecation. > Some curves included are deprecated with TLS 1.3. > Comments to address it were added. > - Cl

RE: [PATCH] examples/vhost: Fix retry logic on Rx

2022-05-26 Thread Ling, WeiX
> -Original Message- > From: Wang, YuanX > Sent: Thursday, May 19, 2022 12:25 AM > To: maxime.coque...@redhat.com; Xia, Chenbo > Cc: dev@dpdk.org; Hu, Jiayu ; He, Xingguang > ; Ling, WeiX ; Wang, YuanX > ; sta...@dpdk.org > Subject: [PATCH] examples/vhost: Fix retry logic on Rx > > drain

  1   2   >