static link + pkg-config assistance

I've been working through some updates to the build system for TLDK and have been working through the different variants (system vs fallback + shared vs static). I've been able to successfully build and run the unit test app for most of these combinations however, I haven't been able to get the sy

RE: [PATCH v4] doc: update matching versions in i40e guide

> -Original Message- > From: Yang, Qiming > Sent: Friday, May 20, 2022 3:05 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Yang, Qiming > ; sta...@dpdk.org > Subject: [PATCH v4] doc: update matching versions in i40e guide > > Add recommended matching list for i40e PMD in DPDK 21.05, 21.08,

RE: [PATCH v3] net/ice: fix DCF state checking mechanism

> -Original Message- > From: Zhang, Peng1X > Sent: Saturday, May 21, 2022 2:31 AM > To: Yang, Qiming ; Zhang, Qi Z > ; dev@dpdk.org > Cc: Zhang, Peng1X ; sta...@dpdk.org > Subject: [PATCH v3] net/ice: fix DCF state checking mechanism > > From: Peng Zhang > > DCF state previously chec

RE: [PATCH v4 1/4] common/iavf: support raw packet in protocol header

> -Original Message- > From: Guo, Junfeng > Sent: Thursday, April 21, 2022 11:29 AM > To: Zhang, Qi Z ; Wu, Jingjing ; > Xing, Beilei > Cc: dev@dpdk.org; Xu, Ting ; Guo, Junfeng > > Subject: [PATCH v4 1/4] common/iavf: support raw packet in protocol header > > The patch extends exist

RE: [PATCH v3] app/testpmd: support ddp dump command for ice

> -Original Message- > From: Zhang, Qi Z > Sent: Friday, May 20, 2022 11:07 AM > To: David Marchand ; Yang, SteveX > > Cc: dev ; Zhang, Yuying ; Ferruh > Yigit ; Andrew Rybchenko > ; Thomas Monjalon > Subject: RE: [PATCH v3] app/testpmd: support ddp dump command for ice > > > > > ---

Re: [PATCH v3] build: add definitions for use as meson subproject

Currently utilizing this in an upcoming set of changes for TLDK and all seems to be working for fallback dependency support under both shared and static linkage. Reviewed-by: Ben Magistro Tested-by: Ben Magistro On Fri, May 6, 2022 at 10:43 AM Bruce Richardson wrote: > To allow other projects

[PATCH V5 1/2] pipeline: support hash functions

Add support for hash functions that compute a signature for an array of bytes read from a packet header or meta-data. Useful for flow affinity-based load balancing. Signed-off-by: Cristian Dumitrescu --- Depends-on: series-23072 ("[V3,1/3] table: improve learner table timers") Change log: V5: -

[PATCH V5 2/2] examples/pipeline: support hash functions

Add example for hash function operation. Signed-off-by: Cristian Dumitrescu --- Change log: V4: -Removed redundant line in the CLI file. -Added comment on the crc32 hash function in the .spec file. examples/pipeline/examples/hash_func.cli | 34 +++ examples/pipeline/examples/hash_func.sp

[PATCH V3 3/3] examples/pipeline: improve learner table timers

Added the rearm counter to the statistics. Updated the learner table example to the new learner table timer operation. Signed-off-by: Cristian Dumitrescu --- examples/pipeline/cli.c | 2 ++ examples/pipeline/examples/learner.spec | 15 +-- 2 files changed, 15 inserti

[PATCH V3 2/3] pipeline: improve learner table timers

Enable the pipeline to use the improved learner table timer operation through the new "rearm" instruction. Signed-off-by: Cristian Dumitrescu --- lib/pipeline/rte_swx_ctl.h | 50 ++ lib/pipeline/rte_swx_pipeline.c | 217 --- lib/pipeline/rte_swx_pi

[PATCH V3 1/3] table: improve learner table timers

Previously, on lookup hit, the hit key had its timer automatically rearmed with the same timeout in order to prevent its expiration. Now, a broader set of actions is available on lookup hit, which has to be managed explicitly: the key can have its timer rearmed with the same or with a different tim

Re: [PATCH 08/12] net/qede/base: fix build with GCC 12

On Wed, 18 May 2022 12:16:53 +0200 David Marchand wrote: > GCC raises the following warning: > > In function ‘_mm256_storeu_si256’, > inlined from ‘rte_mov32’ at > ../lib/eal/x86/include/rte_memcpy.h:320:2, > inlined from ‘rte_mov128’ at > ../lib/eal/x86/include/rte_memcp

Re: [PATCH 04/12] net/ena: fix build with GCC 12

On Wed, 18 May 2022 12:16:49 +0200 David Marchand wrote: > + for (i = 0; i < RTE_DIM(default_key); ++i) > default_key[i] = rte_rand() & 0xff; We should have rte_random_bytes() functionality if this gets used often. Also, worth considering dropping DPDK random n

Re: [PATCH 02/12] crypto/cnxk: fix build with GCC 12

On Wed, 18 May 2022 12:16:47 +0200 David Marchand wrote: > GCC 12 raises the following warning: > > In file included from ../drivers/crypto/cnxk/cn10k_cryptodev_ops.c:17: > In function ‘fill_sg_comp_from_iov’, > inlined from ‘cpt_kasumi_enc_prep’ at > ../drivers/crypto/cnxk/cnxk_se.h

Re: [PATCH 01/12] common/cpt: fix build with GCC 12

On Wed, 18 May 2022 12:16:46 +0200 David Marchand wrote: > GCC 12 raises the following warning: > > In function ‘fill_sg_comp_from_iov’, > inlined from ‘cpt_kasumi_enc_prep’ at > ../drivers/common/cpt/cpt_ucode.h:2176:8, > inlined from ‘cpt_fc_enc_hmac_prep’ at > ../drive

Re: [PATCH 00/12] Fix compilation with gcc 12

On Wed, 18 May 2022 12:16:45 +0200 David Marchand wrote: > Fedora 36 is out since early may and comes with gcc 12. > This series fixes compilation or waives some checks. > > There might be something fishy with rte_memcpy on x86 but, for now, > the rte_memcpy related fixes are on the caller side.

DPDK Release Status Meeting 2022-19-05

Release status meeting minutes 2022-19-05 = Agenda: * Release Dates * Subtrees * Roadmaps * LTS * Defects * Opens Participants: * ARM * Intel * Debian/Microsoft * Marvell * Nvidia * Red Hat * Xilinx/AMD Release Dates - The following are the c

[PATCH] eal/freebsd: fix use of newer CPU_* macros

From: David Marchand FreeBSD has updated its CPU macros to align more with the definitions used on Linux[1]. Unfortunately, while this makes compatibility better in future, it means we need to have both legacy and newer definition support. Use a meson check to determine which set of macros are us

RE: [PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 devices

> -Original Message- > From: Zhang, Qi Z > Sent: Thursday, May 19, 2022 8:15 PM > To: Thomas Monjalon ; dev@dpdk.org > Cc: Stephen Douthit ; Jeff Daly usa.com>; Yang, Qiming ; Wu, Wenjun1 > > Subject: RE: [PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 > devices > > Caution:

[RFC] examples/fips_validation: add fips 140-3 acvp aes-cbc test

This RFC patch showcases an alternative approach to enable FIPS 140-3 support in the DPDK fips_validation sample application. The approach presented here takes advantage of an existing open source library, libacvp,(https://github.com/cisco/libacvp) to generate the parsed test cases instead of crea

[PATCH v2 2/2] test: use cmdline library to validate args

When passing in test names to run via either the DPDK_TEST environment variable or via extra argv parameters, the checks run on those commands can miss valid commands that are registered with the cmdline library in the initial context used to set it up. This is seen in the fact that the "dump_*" se

[PATCH v2 1/2] cmdline: add function to verify valid commands

The cmdline library cmdline_parse() function parses a command and executes the action automatically too. The cmdline_valid_buffer function also uses this function to validate commands, meaning that there is no function to validate a command as ok without executing it. To fix this omission, we extr

[PATCH v2 0/2] fix uncallable unit tests (Bugzilla 1002)

The dump* unit tests are uncallable from our test framework because the command validation in the unit test binary is incorrect. Rather than trying to fix this directly in the binary, a better approach is to add command validation to the cmdline library - which already has 99% of what we need alrea

[PATCH 2/2] test: use cmdline library to validate args

When passing in test names to run via either the DPDK_TEST environment variable or via extra argv parameters, the checks run on those commands can miss valid commands that are registered with the cmdline library in the initial context used to set it up. This is seen in the fact that the "dump_*" se

[PATCH 1/2] cmdline: add function to verify valid commands

The cmdline library cmdline_parse() function parses a command and executes the action automatically too. The cmdline_valid_buffer function also uses this function to validate commands, meaning that there is no function to validate a command as ok without executing it. To fix this omission, we extr

[PATCH 0/2] fix uncallable unit tests (Bugzilla 1002)

The dump* unit tests are uncallable from our test framework because the command validation in the unit test binary is incorrect. Rather than trying to fix this directly in the binary, a better approach is to add command validation to the cmdline library - which already has 99% of what we need alrea

Re: [PATCH v4 0/9] bugfix for ethdev telemetry

On 5/16/22 11:43, Morten Brørup wrote: From: Chengwen Feng [mailto:fengcheng...@huawei.com] Sent: Friday, 13 May 2022 04.54 This patch set contains nine bugfix for ethdev telemetry. Chengwen Feng (9): ethdev: specify return value of xstats-get API ethdev: optimize xstats-get API's impleme

[PATCH v2 7/7] net/ark: add PMD support for devices as virtual functions

Add capabilities field isvf to dev struct Disable configuration calls as required by vf Signed-off-by: Ed Czeck --- v2: feature Arkville vf support int release notes --- doc/guides/rel_notes/release_22_07.rst | 4 ++ drivers/net/ark/ark_ethdev.c | 83 +++--- drive

[PATCH v2 6/7] net/ark: add new devices to support list

update device list is doc Signed-off-by: Ed Czeck --- doc/guides/nics/ark.rst | 4 +++- drivers/net/ark/ark_ethdev.c | 6 ++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/doc/guides/nics/ark.rst b/doc/guides/nics/ark.rst index 29c0a07d60..f4ffb05b2f 100644 --- a/doc/guid

[PATCH v2 5/7] net/ark: report additional errors from firmware

detect and report completion errors from firmware Signed-off-by: Ed Czeck --- drivers/net/ark/ark_rqp.c | 6 -- drivers/net/ark/ark_rqp.h | 3 ++- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/net/ark/ark_rqp.c b/drivers/net/ark/ark_rqp.c index ef9ccd0706..efb9730fe6

[PATCH v2 4/7] net/ark: update UDM functions for firmware update

new firmware version for UDM (Upstream Data Mover) remove device-level start, stop, and reset operations add queue-based start, stop and reset as required by firmware remove performance structs as they are not in the firmware module Signed-off-by: Ed Czeck --- v2: reword commit message --- driv

[PATCH v2 3/7] net/ark: update DDM functions for firmware update

new firmware version for DDM (Downstream Data Mover) remove device-level start, stop, and reset operations add queue-based start, stop and reset as required by firmware Signed-off-by: Ed Czeck --- v2: reword commit message --- drivers/net/ark/ark_ddm.c | 80 +-

[PATCH v2 2/7] net/ark: update MPU functions for firmware update

new firmware version for MPU (Mbuf Prefetch Unit) remove device-level global operations remove ark_mpu_reset_stats function Signed-off-by: Ed Czeck --- v2: - document version compatibility between firmware and DPDK - reword commit message --- doc/guides/nics/ark.rst | 15 +++

[PATCH v2 1/7] devtools: add Atomic Rules acronyms for commit checks

DDM -> Downstream Data Mover MPU -> Mbuf Prefetch Unit UDM -> Upstream Data Mover Signed-off-by: Ed Czeck --- devtools/words-case.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/devtools/words-case.txt b/devtools/words-case.txt index bc33470532..fa92ab273e 100644 --- a/devtools/words-

RE: [EXT] [PATCH RFC 0/3] Add UADK compression and crypto PMD

Hi Zhangfei, > Hi, Akhil > > On 2022/5/20 下午7:49, Akhil Goyal wrote: > >> Supported hardware platforms: > >> HiSilicon Kunpeng920 and Kunpeng930 > >> > >> The PMD relies on UADK Interface: > > I hope this set is for DPDK 22.11 > Oh, should be based on v22.03? > > The patchset is based on 45f04d8

[Bug 1015] SPDK vm_wait_for_boot: timeout after 300s

https://bugs.dpdk.org/show_bug.cgi?id=1015 Bug ID: 1015 Summary: SPDK vm_wait_for_boot: timeout after 300s Product: DPDK Version: unspecified Hardware: All OS: Linux Status: UNCONFIRMED Severity: normal

Re: [EXT] [PATCH RFC 0/3] Add UADK compression and crypto PMD

Hi, Akhil On 2022/5/20 下午7:49, Akhil Goyal wrote: Supported hardware platforms: HiSilicon Kunpeng920 and Kunpeng930 The PMD relies on UADK Interface: https://github.com/Linaro/uadk I hope this set is for DPDK 22.11 Oh, should be based on v22.03? The patchset is based on 45f04d8 version: 21.

RE: [EXT] [PATCH 37/40] cryptodev: add asym op flags

> - added flags to rte_crypto_asym_op struct. > It may be shared between different algorithms. > - added Diffie-Hellman padding flags. > Diffie-Hellman padding is used in certain protocols, > in others, leading zero bytes need to be stripped. > Even same protocol may use a different approach - most

RE: [EXT] [PATCH RFC 0/3] Add UADK compression and crypto PMD

> Supported hardware platforms: > HiSilicon Kunpeng920 and Kunpeng930 > > The PMD relies on UADK Interface: > https://github.com/Linaro/uadk > I hope this set is for DPDK 22.11 > > Zhangfei Gao (3): > compress: add UADK compression PMD > test/crypto: add cryptodev_uadk_autotest > drivers/

[PATCH RFC 3/3] drivers/crypto: add UADK crypto PMD

Add UADK crypto pmd for HiSilicon Kunpeng920 and Kunpeng930 Test: sudo dpdk-test --vdev=:76:00.0 (--log-level=6) RTE>>cryptodev_uadk_autotest RTE>>quit Signed-off-by: Zhangfei Gao --- doc/guides/cryptodevs/index.rst |1 + doc/guides/cryptodevs/uadk.rst| 80 ++ drivers/cr

[PATCH RFC 1/3] compress: add UADK compression PMD

Add compression & decompression PMD for HiSilicon Hunpeng930 The UADK compression PMD rely on uadk api. Test: sudo dpdk-test --vdev=:75:00.0 RTE>>compressdev_autotest RTE>>quit Signed-off-by: Zhangfei Gao --- doc/guides/compressdevs/index.rst | 1 + doc/guides/compressdevs/uadk.rs

[PATCH RFC 2/3] test/crypto: add cryptodev_uadk_autotest

Example: sudo dpdk-test --vdev=:76:00.0 --log-level=6 RTE>>cryptodev_uadk_autotest RTE>>quit Signed-off-by: Zhangfei Gao --- app/test/test_cryptodev.c | 7 +++ app/test/test_cryptodev.h | 1 + 2 files changed, 8 insertions(+) diff --git a/app/test/test_cryptodev.c b/app/test/test_crypto

[PATCH RFC 0/3] Add UADK compression and crypto PMD

Supported hardware platforms: HiSilicon Kunpeng920 and Kunpeng930 The PMD relies on UADK Interface: https://github.com/Linaro/uadk Zhangfei Gao (3): compress: add UADK compression PMD test/crypto: add cryptodev_uadk_autotest drivers/crypto: add UADK crypto PMD app/test/test_cryptodev.c

[PATCH v3] net/ice: fix DCF state checking mechanism

From: Peng Zhang DCF state previously checking mechanism cannot detect DCF state correctly in given situation,so PMD will report incorrect error code and mislead user. In this patch, DCF state checking mechanism is fixed through create or delete rule successfully or not. Then error code will

[PATCH v2 1/2] test/crypto: remove Windows conditional compilation

build the test/crypto harnesses on windows to allow them to be listed as tests to run. Signed-off-by: Tyler Retzlaff --- app/test/test_cryptodev.c| 3 --- app/test/test_cryptodev_asym.c | 3 --- app/test/test_cryptodev_blockcipher.c| 3 --- app/test/test_cryptodev_s

[PATCH v2 2/2] test: enable most driver tests on Windows

enable most of the driver tests to run on windows, most tests will be skipped since the drivers themselves are not available on windows. tests not removed from conditional run: cryptodev_openssl_asym_autotest test fails because it does not bother checking to see if required driver is availabl

[PATCH v2 0/2] test: enable most driver tests on windows

* remove conditional compilation for windows from crypto tests so they are built and registered to be run with dpdk-test.exe. * remaining driver tests require further investigation and will not be addressed in this series. sorry for the delay in addressing the final feedback. i would recommend

[PATCH v5 4/4] net/iavf: support Protocol Agnostic Flow Offloading VF RSS

From: Ting Xu Enable Protocol Agnostic Flow Offloading for RSS hash in VF. It supports raw pattern flow rule creation in VF based on Parser Library feature. VF parses the spec and mask input of raw pattern, and passes it to kernel driver to create the flow rule. Current rte_flow raw API is utiliz

[PATCH v5 3/4] net/iavf: enable Protocol Agnostic Flow Offloading FDIR

This patch enabled Protocol Agnostic Flow (raw flow) Offloading Flow Director (FDIR) in AVF, based on the Parser Library feature and the existing rte_flow `raw` API. The input spec and mask of raw pattern are first parsed via the Parser Library, and then passed to the kernel driver to create the f

[PATCH v5 2/4] net/iavf: align with proto hdr struct change

Structure virtchnl_proto_headrs is extended with a union struct for proto_hdr table and raw struct. Thus update the proto_hdrs template init to align the virtchnl changes. Signed-off-by: Junfeng Guo --- drivers/net/iavf/iavf_hash.c | 180 ++- 1 file changed, 92 in

[PATCH v5 1/4] common/iavf: support raw packet in protocol header

The patch extends existing virtchnl_proto_hdrs structure to allow VF to pass a pair of buffers as packet data and mask that describe a match pattern of a filter rule. Then the kernel PF driver is requested to parse the pair of buffer and figure out low level hardware metadata (ptype, profile, field

[PATCH v5 0/4] Enable Protocol Agnostic Flow Offloading in AVF

This patch set enabled Protocol Agnostic Flow (raw flow) Offloading for FDIR and RSS in AVF, based on the Parser Library feature and the existing rte_flow `raw` API. [PATCH v4 1/4] common/iavf: support raw packet in protocol header [PATCH v4 2/4] net/iavf: align with proto hdr struct change [PATCH

Re: [PATCH 05/12] net/hns3: fix an unreasonable memset

On 5/20/22 11:37, Min Hu (Connor) wrote: Hi, Andrew , 在 2022/5/20 15:58, Andrew Rybchenko 写道: On 5/19/22 15:29, Min Hu (Connor) wrote: From: Huisong Li This patch fixes an unreasonable memset. Fixes: bba636698316 ("net/hns3: support Rx/Tx and related operations") Cc: sta...@dpdk.org Signed

Re: [PATCH v2 6/7] net/ark: add new devices to support list

On 5/20/22 00:36, Ed Czeck wrote: update device list is doc Signed-off-by: Ed Czeck I think it would be useful to advertise it in release notes.

[PATCH v3] net/iavf: fix race condition for multi-cores

In multi-cores cases for RX timestamp offload, if packets arrive too fast, aq command to get phc time will be pended. This patch adds spinlock to fix this issue. To avoid phc time being frequently overwritten, move related variables to iavf_rx_queue structure, and each queue will handle timestamp

Re: [PATCH 05/12] net/hns3: fix an unreasonable memset

On 5/19/22 15:29, Min Hu (Connor) wrote: From: Huisong Li This patch fixes an unreasonable memset. Fixes: bba636698316 ("net/hns3: support Rx/Tx and related operations") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_rxtx.c | 2 +-

[PATCH v4] doc: update matching versions in i40e guide

Add recommended matching list for i40e PMD in DPDK 21.05, 21.08, 21.11 and 22.03. And add a known issue when FW upgrade to a version higher than 8.4. Cc: sta...@dpdk.org Signed-off-by: Qiming Yang --- v2: * added known issue in FW 8.4+ v3: * updated x722 FW version v4: * minor express change ---

RE: [EXT] [PATCH 13/40] test/crypto: remove asym crypto next xform

> -Original Message- > From: Akhil Goyal > Sent: Friday, May 20, 2022 9:24 AM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: Anoob Joseph ; Zhang, Roy Fan > > Subject: RE: [EXT] [PATCH 13/40] test/crypto: remove asym crypto next xform > > > - removed asymnetric crypto xform next field

RE: [EXT] [PATCH 00/40] cryptodev: rsa, dh, ecdh changes

> -Original Message- > From: Akhil Goyal > Sent: Friday, May 20, 2022 9:30 AM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: Anoob Joseph ; Zhang, Roy Fan > > Subject: RE: [EXT] [PATCH 00/40] cryptodev: rsa, dh, ecdh changes > > > This patchset introduces some of changes discussed on

RE: [EXT] [PATCH 00/40] cryptodev: rsa, dh, ecdh changes

> This patchset introduces some of changes discussed on mailing list > for 22.07 release in cryptodev asym. > > Key changes: > > - It fixes API for RSA (expescially signature paddings) > - Adds Elliptic-Curve Diffie-Hellman > - Removes LIST_END enumerators (ABI issue - supressed asym_xform) > - A

RE: [EXT] [PATCH 15/40] app/test-eventdev: remove asym crypto next xform

> - removed asymmetric crypto xform next field. > This commit reflects changes to the asymmetric crypto API. > > Signed-off-by: Arek Kusztal > --- Squash in main commit. > app/test-eventdev/test_perf_common.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/app/test-eventdev/test_perf_

RE: [EXT] [PATCH 13/40] test/crypto: remove asym crypto next xform

> - removed asymnetric crypto xform next field. > This commit reflects changes to the asymmetric crypto API. > > Signed-off-by: Arek Kusztal > --- > app/test/test_cryptodev_asym.c | 100 > - > app/test/test_cryptodev_dh_test_vectors.h | 1 - > app/test

RE: [EXT] [PATCH 11/40] cryptodev: remove asym crypto next xform

> - removed asymnetric crypto xform next field. > Rationale behind having chaining in symmetric crypto > was a fact that encryption and authentication are usually > done on the same set of data independent of algorithm. > HW usually will be able to handle it in one PCI call. > In asymmetric there i

RE: [EXT] [PATCH 02/40] cryptodev: remove list end enumerators

> - Removed LIST_END enumerators from asymmetric crypto API. > Adding new enum entries would require moving > LIST_END down, therefore changing its assigned number. > This would cause problems to ABI stability, so these > enums were removed. > > Cc: m...@ashroe.eu > > Signed-off-by: Arek Kusztal

RE: [EXT] [PATCH 08/40] test/crypto: separate key exchange operation enum

> - Key exchange is now separate enum. > This commit reflects changes to the asymmetric crypto API > > Signed-off-by: Arek Kusztal > --- Individual patches must compile. There are multiple patches which needs to be combined. 6,7,8 should be a single patch or else compilation will be broken 2,3

RE: [EXT] [PATCH 09/40] cryptodev: remove unnecessary zero assignement

> - removed unnecessary zero assignement in rsa padding enum. > Even it is set correctly it should be made consistent with > other enums in cryptodev. Therefore assignement to zero was > removed. > > Signed-off-by: Arek Kusztal > --- > lib/cryptodev/rte_crypto_asym.h | 7 --- > 1 file change

[PATCH] drivers: fix cnxk event qos devarg processing

Fixed qos parameters getting over written and IAQ/TAQ threshold calculation. Fixes: 910da32c53a9 ("event/cnxk: add device start") Cc: sta...@dpdk.org Signed-off-by: Shijith Thotton --- drivers/common/cnxk/roc_sso.c | 4 ++-- drivers/event/cnxk/cnxk_eventdev.c | 8 2 files changed,

Re: [RFC PATCH v2 0/5] Split driver specific commands out of testpmd

On 5/18/22 22:46, David Marchand wrote: Hello, Following TB decision and recent discussions on the driver specific commands in testpmd, here is a proposal on how the split could be done. For now, this series simply moves the testpmd code in the driver directory. The driver specific testpmd code

[PATCH 40/40] test/crypto: added test for dh priv key generation

- re-added test for dh private gey generation. This time zero length of priv key determines if key is generated. Signed-off-by: Arek Kusztal --- app/test/test_cryptodev_asym.c | 90 ++ 1 file changed, 90 insertions(+) diff --git a/app/test/test_cryptodev_

[PATCH 39/40] crypto/openssl: generate dh private key

- added dh private key generation based on length. PMD will generate private key only if priv_key length is set to 0. Signed-off-by: Arek Kusztal --- drivers/crypto/openssl/rte_openssl_pmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/openssl/rte_openssl_pm

[PATCH 38/40] cryptodev: clarify usage of private key in dh

- clarified usage of private key in Diffie-Hellman. CSRNG capable device should generate private key and then use it for public key generation. Signed-off-by: Arek Kusztal --- lib/cryptodev/rte_crypto_asym.h | 4 1 file changed, 4 insertions(+) diff --git a/lib/cryptodev/rte_crypto_asym.h

[PATCH 37/40] cryptodev: add asym op flags

- added flags to rte_crypto_asym_op struct. It may be shared between different algorithms. - added Diffie-Hellman padding flags. Diffie-Hellman padding is used in certain protocols, in others, leading zero bytes need to be stripped. Even same protocol may use a different approach - most glaring exa

[PATCH 36/40] test/crypto: reduce rsa struct to only necessary fields

- reduced rsa struct to only necessary fields. This commit reflects changes to the asymmetric crypto API. Signed-off-by: Arek Kusztal --- app/test/test_cryptodev_asym.c | 80 +++--- 1 file changed, 43 insertions(+), 37 deletions(-) diff --git a/app/test/test_

[PATCH 35/40] common/cpt: reduce rsa struct to only necessary fields

- reduced rsa struct to only necessary fields. This commit reflects changes to the asymmetric crypto API. Signed-off-by: Arek Kusztal --- drivers/common/cpt/cpt_ucode_asym.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/common/cpt/cpt_ucode_asym.h b/drivers

[PATCH 34/40] crypto/cnxk: reduce rsa struct to only necessary fields

- reduced rsa struct to only necessary fields. This commit reflects changes to the asymmetric crypto API. Signed-off-by: Arek Kusztal --- drivers/crypto/cnxk/cnxk_ae.h | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/drivers/crypto/cnxk/c

[PATCH 33/40] crypto/octeontx: reduce rsa struct to only necessary fields

- reduced rsa struct to only necessary fields. This commit reflects changes to the asymmetric crypto API. Signed-off-by: Arek Kusztal --- drivers/crypto/octeontx/otx_cryptodev_ops.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/crypto/octeon

[PATCH 32/40] crypto/openssl: reduce rsa struct to only necessary fields

- reduced rsa struct to only necessary fields. This commit reflects changes to the asymmetric crypto API. Signed-off-by: Arek Kusztal --- drivers/crypto/openssl/rte_openssl_pmd.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/crypto/o

[PATCH 31/40] crypto/qat: reduce rsa struct to only necessary fields

- reduced rsa struct to only necessary fields. This commit reflects changes to the asymmetric crypto API. Signed-off-by: Arek Kusztal --- drivers/crypto/qat/qat_asym.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/crypto/qat/qat_asym.c b/drivers/cry

[PATCH 30/40] cryptodev: reduce rsa struct to only necessary fields

- reduced rsa struct to only necessary fields. RSA operation is generally used with one input and one output. One exception for this is signature verification, when RSA verify called, both message and signature are inputs, but there is no rsa output except for op status. Signed-off-by: Arek Kuszta

[PATCH 29/40] cryptodev: add salt length and optional label

- added salt length and optional label. Common parameters to PSS and OAEP padding for RSA. - Fixed hash API in RSA padding. Now it is specified how hash should be used with particular RSA padding modes. Signed-off-by: Arek Kusztal --- lib/cryptodev/rte_crypto_asym.h | 44

[PATCH 28/40] test/crypto: move RSA padding into separate struct

- move RSA padding into separate struct. This commit reflects changes to the asymmetric crypto API. Signed-off-by: Arek Kusztal --- app/test/test_cryptodev_asym.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptod

[PATCH 27/40] common/cpt: move RSA padding into separate struct

- move RSA padding into separate struct. This commit reflects changes to the asymmetric crypto API. Signed-off-by: Arek Kusztal --- drivers/common/cpt/cpt_ucode_asym.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/common/cpt/cpt_ucode_asym.h b/drivers/common/cp

[PATCH 26/40] crypto/cnxk: move RSA padding into separate struct

- move RSA padding into separate struct. This commit reflects changes to the asymmetric crypto API. Signed-off-by: Arek Kusztal --- drivers/crypto/cnxk/cnxk_ae.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/cnxk/cnxk_ae.h b/drivers/crypto/cnxk/cnxk_a

[PATCH 25/40] crypto/octeontx: move RSA padding into separate struct

- move RSA padding into separate struct. This commit reflects changes to the asymmetric crypto API. Signed-off-by: Arek Kusztal --- drivers/crypto/octeontx/otx_cryptodev_ops.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/octeontx/otx_cryptodev_ops.c b/d

[PATCH 24/40] crypto/openssl: move RSA padding into separate struct

- move RSA padding into separate struct. This commit reflects changes to the asymmetric crypto API. Signed-off-by: Arek Kusztal --- drivers/crypto/openssl/rte_openssl_pmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/openssl/rte_openssl_pmd.c b/drivers/cry

[PATCH 23/40] crypto/qat: move RSA padding into separate struct

- move RSA padding into separate struct. This commit reflects changes to the asymmetric crypto API. Signed-off-by: Arek Kusztal --- drivers/crypto/qat/qat_asym.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/crypto/qat/qat_asym.c b/drivers/crypto/qat/qa

[PATCH 22/40] cryptodev: move RSA padding into separate struct

- move RSA padding into separate struct. More padding members should be added into padding, therefore having separate struct for padding parameters will make this more readable. Signed-off-by: Arek Kusztal --- lib/cryptodev/rte_crypto_asym.h | 42 +++-- 1 file

[PATCH 21/40] cryptodev: add public key verify option

- Added key exchange public key verify option. For some elliptic curves public point in DH exchange needs to be checked, if it lays on the curve. Modular exponentiation needs certain checks as well, though mathematically much easier. This commit adds verify option to asym_op operations. Signed-off

[PATCH 20/40] cryptodev: add elliptic curve diffie hellman

- added elliptic curve Diffie-Hellman parameters. Point multiplication allows the user to process every phase of ECDH, but for phase 1, user should not really care about the generator. The user does not even need to know what the generator looks like, therefore setting ec xform would make this work

[PATCH 19/40] cryptodev: changed order of dh fields

- changed order of Diffie-Hellman struct fields. Now order of Diffie-Hellman struct members corresponds to order of operation in Diffie-Hellman key exchange. Signed-off-by: Arek Kusztal --- lib/cryptodev/rte_crypto_asym.h | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) di

[PATCH 18/40] test/crypto: move dh type from xform to dh op

- Moved dh operation type to dh operation struct. This commit reflects changes to the asymmetric crypto API. Signed-off-by: Arek Kusztal --- app/test/test_cryptodev_asym.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cry

[PATCH 17/40] crypto/openssl: move dh type from xform to dh op

- Moved dh operation type to dh operation struct. This commit reflects changes to the asymmetric crypto API. Signed-off-by: Arek Kusztal --- drivers/crypto/openssl/rte_openssl_pmd.c | 15 ++- drivers/crypto/openssl/rte_openssl_pmd_ops.c | 1 - 2 files changed, 6 insertions(+), 1

[PATCH 16/40] cryptodev: move dh type from xform to dh op

- Moved dh operation type to dh operation struct. Operation type (PUBLIC_KEY_GENERATION, SHARED_SECRET) should be free to choose for any operation. One xform/session should be enough to perform both DH operations, if op_type would be xform member, session would have to be to be created twice for th

[PATCH 15/40] app/test-eventdev: remove asym crypto next xform

- removed asymmetric crypto xform next field. This commit reflects changes to the asymmetric crypto API. Signed-off-by: Arek Kusztal --- app/test-eventdev/test_perf_common.c | 1 - 1 file changed, 1 deletion(-) diff --git a/app/test-eventdev/test_perf_common.c b/app/test-eventdev/test_perf_com

[PATCH 14/40] app/test-crypto-perf: remove asym crypto next xform

- removed asymnetric crypto xform next field. This commit reflects changes to the asymmetric crypto API. Signed-off-by: Arek Kusztal --- app/test-crypto-perf/cperf_ops.c | 1 - 1 file changed, 1 deletion(-) diff --git a/app/test-crypto-perf/cperf_ops.c b/app/test-crypto-perf/cperf_ops.c index c

[PATCH 13/40] test/crypto: remove asym crypto next xform

- removed asymnetric crypto xform next field. This commit reflects changes to the asymmetric crypto API. Signed-off-by: Arek Kusztal --- app/test/test_cryptodev_asym.c | 100 - app/test/test_cryptodev_dh_test_vectors.h | 1 - app/test/test_cryptodev_dsa

[PATCH 12/40] crypto/openssl: remove asym crypto next xform

- removed asymnetric crypto xform next field. This commit reflects asymmetric crypto API changes Signed-off-by: Arek Kusztal --- drivers/crypto/openssl/rte_openssl_pmd_ops.c | 26 -- 1 file changed, 26 deletions(-) diff --git a/drivers/crypto/openssl/rte_openssl_pmd_ops.

[PATCH 11/40] cryptodev: remove asym crypto next xform

- removed asymnetric crypto xform next field. Rationale behind having chaining in symmetric crypto was a fact that encryption and authentication are usually done on the same set of data independent of algorithm. HW usually will be able to handle it in one PCI call. In asymmetric there is no such re

[PATCH 10/40] cryptodev: remove comment about using ephemeral key in dsa

- removed comment that stated dsa can be used with Diffie Hellman ephemeral key. DH and DSA integration allowed to use ephemeral keys for random integer but not for private keys. Signed-off-by: Arek Kusztal --- lib/cryptodev/rte_crypto_asym.h | 8 +--- 1 file changed, 1 insertion(+), 7 delet

[PATCH 06/40] cryptodev: separate key exchange operation enum

- separated key exchange enum. Key exchange and asymmetric crypto operations like signatures, encryption/decryption should not share same operation enum as its use cases are unrelated and mutually exclusive. Therefore op_type was separate into: 1) operation type 2) key exchange operation type Sign

  1   2   >