> -----Original Message----- > From: Zhang, Qi Z > Sent: Friday, May 20, 2022 11:07 AM > To: David Marchand <david.march...@redhat.com>; Yang, SteveX > <stevex.y...@intel.com> > Cc: dev <dev@dpdk.org>; Zhang, Yuying <yuying.zh...@intel.com>; Ferruh > Yigit <ferruh.yi...@xilinx.com>; Andrew Rybchenko > <andrew.rybche...@oktetlabs.ru>; Thomas Monjalon <tho...@monjalon.net> > Subject: RE: [PATCH v3] app/testpmd: support ddp dump command for ice > > > > > -----Original Message----- > > From: David Marchand <david.march...@redhat.com> > > Sent: Thursday, May 19, 2022 8:13 PM > > To: Yang, SteveX <stevex.y...@intel.com> > > Cc: dev <dev@dpdk.org>; Zhang, Yuying <yuying.zh...@intel.com>; Zhang, > > Qi Z <qi.z.zh...@intel.com>; Ferruh Yigit <ferruh.yi...@xilinx.com>; > > Andrew Rybchenko <andrew.rybche...@oktetlabs.ru>; Thomas Monjalon > > <tho...@monjalon.net> > > Subject: Re: [PATCH v3] app/testpmd: support ddp dump command for ice > > > > On Wed, May 18, 2022 at 9:07 AM Steve Yang <stevex.y...@intel.com> > wrote: > > > > > > Dump DDP runtime configure into a binary(package) file from ice PF port. > > > > > > Add command line: > > > ddp dump <port_id> <config_path> > > > > > > Parameters: > > > <port_id> the PF Port ID > > > <config_path> dumped runtime configure file, if not a absolute path, > > > it will be dumped to testpmd running directory. > > > > > > For example: > > > testpmd> ddp dump 0 current.pkg > > > > > > If you want to dump ice VF DDP runtime configure, you need bind > > > other unused PF port of the NIC first, and then dump the PF's > > > runtime configure as target output. > > > > > > Signed-off-by: Steve Yang <stevex.y...@intel.com> > > > > I proposed a way to move such code in drivers, please have a look > > at/give feedback to: > > https://patchwork.dpdk.org/project/dpdk/list/?series=23000&state=* > > This looks like a good idea, we will review and thanks for the heads-up >
David Are these RFC patches target to DPDK 22.07? If not, is below proposal acceptable? 1. merge this patch in DPDK 22.07. 2. meanwhile we will also contribute the ice refactor patch based on your RFC, so it can be captured in next release. Thanks Qi > > > > > > -- > > David Marchand