Re: [RFC] ethdev: datapath-focused meter actions, continue

2022-05-18 Thread Andrew Rybchenko
On 5/19/22 05:17, Alexander Kozyrev wrote: On Wed, May 18, 2022 12:51 Andrew Rybchenko : I'm sorry, I'm not sure that I can take part in tomorrow meeting, so, I'd like to drop my thoughts on the topic via E-mail. Thank you for taking some time and reviewing this RFC. Existing "meter" object

[PATCH] mem: telemetry support for memseg and element information

2022-05-18 Thread Amit Prakash Shukla
Changes adds telemetry support to display memory occupancy in memseg and the information of the elements allocated from a memseg based on arguments provided by user. This patch adds following endpoints: 1. /eal/active_memseg_list The command displays the memseg list from which the memory has been

[PATCH v2] net/i40e: add outer VLAN processing

2022-05-18 Thread Robin Zhang
Outer VLAN processing is supported after firmware v8.4, kernel driver also changes the default behavior to support this feature. To align with kernel driver, add support for outer VLAN processing in DPDK. But it is forbidden for firmware to change the Inner/Outer VLAN configuration while there are

[PATCH] net/igc: add I226 support

2022-05-18 Thread Qiming Yang
Added I226 Series device ID in igc driver and updated igc guide document for new devices. Signed-off-by: Qiming Yang Signed-off-by: Kevin Liu --- doc/guides/nics/igc.rst| 14 +++--- doc/guides/rel_notes/release_22_03.rst | 5 + drivers/net/igc/base/igc_api.c

[PATCH v2] examples/fips_validation: add parsing for aes_cbc

2022-05-18 Thread Gowrishankar Muthukrishnan
Added function to parse algorithm for AES_CBC test. Signed-off-by: Gowrishankar Muthukrishnan --- Depends-on: series-22738 ("Add JSON vector set support to fips validation") v2: - minor cleanup. --- examples/fips_validation/fips_validation.c| 8 +- examples/fips_validation/fips_validati

[PATCH v2] examples/fips_validation: reset IV generation in every test group

2022-05-18 Thread Gowrishankar Muthukrishnan
Reset IV generation in every test group. Signed-off-by: Gowrishankar Muthukrishnan --- Depends-on: series-22738 ("Add JSON vector set support to fips validation") --- examples/fips_validation/fips_validation_gcm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/examples/fips_validation/fips_

[PATCH] net/igc: add I226 support

2022-05-18 Thread Qiming Yang
Added I226 Series device ID in igc driver and updated igc guide doc for new devices. Signed-off-by: Qiming Yang Signed-off-by: Kevin Liu --- doc/guides/nics/igc.rst| 14 +++--- doc/guides/rel_notes/release_22_03.rst | 5 + drivers/net/igc/base/igc_api.c | 6

[PATCH] examples/fips_validation: cleanup bypass tests in response file

2022-05-18 Thread Gowrishankar Muthukrishnan
Remove garbage entries for bypassed tests in response file. Signed-off-by: Gowrishankar Muthukrishnan --- Depends-on: series-22738 ("Add JSON vector set support to fips validation") --- examples/fips_validation/main.c | 74 - 1 file changed, 35 insertions(+), 39 d

RE: [PATCH v2] net/ice: fix DCF state checking mechanism

2022-05-18 Thread Zhang, Peng1X
This patch is aim to fix the mentioned situation. After having failed to create rule, error code is EINVAL or EAGAIN depends whether DCF is enabled and DCF state is on or not. In this patch conduct DPDK DCF state by create or destroy rule successfully or not. Before patch is applied, the steps of

[PATCH v4] raw/afu_mf: introduce AFU MF device driver

2022-05-18 Thread Wei Huang
Add afu_mf driver to manage various AFU (Acceleration Function Unit) in FPGA. Signed-off-by: Wei Huang Acked-by: Tianfei Zhang --- v2: fix typo --- v3: fix build error in FreeBSD13-64, UB2004-32 and UB2204-32 --- v4: fix coding style issue and build error in FreeBSD13-64 --- drivers/raw/afu_mf/

RE: [PATCH] net/iavf: fix queue start exception handle

2022-05-18 Thread Zhang, Qi Z
> -Original Message- > From: Qiming Yang > Sent: Thursday, May 19, 2022 1:02 PM > To: dev@dpdk.org; Xing, Beilei > Cc: Yang, Qiming ; sta...@dpdk.org > Subject: [PATCH] net/iavf: fix queue start exception handle exception handling > > When queue start fail, started queues should be

RE: [EXT] [PATCH v4 8/8] examples/fips_validation: add parsing for cmac

2022-05-18 Thread Gowrishankar Muthukrishnan
Please find comments inline from CI point of view. > -Original Message- > From: Brandon Lo > Sent: Friday, April 29, 2022 9:46 PM > To: roy.fan.zh...@intel.com; ciara.po...@intel.com > Cc: dev@dpdk.org; Brandon Lo > Subject: [EXT] [PATCH v4 8/8] examples/fips_validation: add parsing for

RE: [EXT] [PATCH v4 4/8] examples/fips_validation: allow json file as input

2022-05-18 Thread Gowrishankar Muthukrishnan
Please find comments inline from CI point of view. > -Original Message- > main(int argc, char *argv[]) > { > int ret; > + char use_json; > > ret = rte_eal_init(argc, argv); > if (ret < 0) { > @@ -424,9 +436,17 @@ main(int argc, char *argv[]) >

RE: [PATCH v4] net/i40e: fix max frame size config at port level

2022-05-18 Thread Zhang, Qi Z
> -Original Message- > From: wenxuanx...@intel.com > Sent: Wednesday, May 18, 2022 12:59 PM > To: Xing, Beilei ; Zhang, Yuying > ; dev@dpdk.org > Cc: Wu, WenxuanX ; Zhou, YidingX > ; sta...@dpdk.org > Subject: [PATCH v4] net/i40e: fix max frame size config at port level > > From: Wenxu

[PATCH] net/iavf: fix queue start exception handle

2022-05-18 Thread Qiming Yang
When queue start fail, started queues should be cleared. Fixes: 69dd4c3d0898 ("net/avf: enable queue and device") Cc: sta...@dpdk.org Signed-off-by: Qiming Yang --- drivers/net/iavf/iavf_ethdev.c | 30 -- 1 file changed, 20 insertions(+), 10 deletions(-) diff --git

Re: [PATCH v1] net/iavf: fix race condition for multi-cores

2022-05-18 Thread Stephen Hemminger
On Thu, 19 May 2022 09:19:59 +0800 Wenjun Wu wrote: > if (dev->data->dev_conf.rxmode.offloads & > - RTE_ETH_RX_OFFLOAD_TIMESTAMP) { > - if (iavf_get_phc_time(adapter)) { > - PMD_DRV_LOG(ERR, "get physical time failed"); > - goto er

[PATCH v3] raw/afu_mf: introduce AFU MF device driver

2022-05-18 Thread Wei Huang
Add afu_mf driver to manage various AFU (Acceleration Function Unit) in FPGA. Signed-off-by: Wei Huang Acked-by: Tianfei Zhang --- v2: fix typo --- v3: fix build error in FreeBSD13-64, UB2004-32 and UB2204-32 --- drivers/raw/afu_mf/afu_mf_rawdev.c | 440 drivers/raw/afu_mf/afu_mf_rawd

RE: [RFC] ethdev: datapath-focused meter actions, continue

2022-05-18 Thread Alexander Kozyrev
On Wed, May 18, 2022 12:51 Andrew Rybchenko : > I'm sorry, I'm not sure that I can take part in tomorrow meeting, so, > I'd like to drop my thoughts on the topic via E-mail. Thank you for taking some time and reviewing this RFC. > Existing "meter" object which pulls profile and policy together al

[Bug 1013] [dpdk-22.07] unit_tests_eal/link_bonding_rssconf: link_bonding_rssconf_autotest test failed

2022-05-18 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1013 Bug ID: 1013 Summary: [dpdk-22.07] unit_tests_eal/link_bonding_rssconf: link_bonding_rssconf_autotest test failed Product: DPDK Version: unspecified Hardware: x86 O

[PATCH v1] net/iavf: fix race condition for multi-cores

2022-05-18 Thread Wenjun Wu
In multi-cores cases for RX timestamp offload, if packets arrive too fast, aq command to get phc time will be pended. This patch adds spinlock to fix this issue. To avoid phc time being frequently overwritten, move related variables to iavf_rx_queue structure, and each queue will handle timestamp

RE: [PATCH v3] net/i40e: fix max frame size config at port level

2022-05-18 Thread Zhang, Yuying
Hi Wenxuan, LGTM. > -Original Message- > From: Wu, WenxuanX > Sent: Wednesday, May 18, 2022 3:32 PM > To: Zhang, Yuying ; Xing, Beilei > ; dev@dpdk.org > Cc: Zhou, YidingX ; sta...@dpdk.org > Subject: RE: [PATCH v3] net/i40e: fix max frame size config at port level > > Hi, Yuying > > >

Re: [RFC PATCH 2/4] net/bonding: move testpmd commands

2022-05-18 Thread Konstantin Ananyev
18/05/2022 18:24, David Marchand пишет: On Fri, May 13, 2022 at 12:10 PM Min Hu (Connor) wrote: I think net/bonding offer 'API' for APP to use the bonding. and use the specific PMD as slave device. The software framwork is like: APP ethdev bonding PMD PMD hardwar

[RFC PATCH v2 5/5] net/ixgbe: move testpmd commands

2022-05-18 Thread David Marchand
Move related specific testpmd commands into this driver directory. While at it, fix checkpatch warnings. The bypass code required some special init code before starting a port. This is removed from testpmd itself and a new (*untested*) command is added. Note: bypass commands were not compiled sin

[RFC PATCH v2 3/5] net/bonding: move testpmd commands

2022-05-18 Thread David Marchand
Move related specific testpmd commands into this driver directory. While at it, fix checkpatch warnings. Signed-off-by: David Marchand --- app/test-pmd/cmdline.c | 1035 --- app/test-pmd/meson.build |3 - drivers/net/bonding/meson.build

[RFC PATCH v2 2/5] app/testpmd: register driver specific commands

2022-05-18 Thread David Marchand
Introduce a testpmd API so that drivers can register specific commands. A driver can list some files to compile with testpmd, by setting them in the testpmd_sources (driver local) meson variable. drivers/meson.build then takes care of appending this to a global meson variable, and adding the drive

[RFC PATCH v2 0/5] Split driver specific commands out of testpmd

2022-05-18 Thread David Marchand
Hello, Following TB decision and recent discussions on the driver specific commands in testpmd, here is a proposal on how the split could be done. For now, this series simply moves the testpmd code in the driver directory. The driver specific testpmd code is still compiled as part of testpmd comp

Re: [RFC PATCH 2/4] net/bonding: move testpmd commands

2022-05-18 Thread David Marchand
On Fri, May 13, 2022 at 12:10 PM Min Hu (Connor) wrote: > > I think net/bonding offer 'API' for APP to use the bonding. > and use the specific PMD as slave device. > The software framwork is like: >APP >ethdev >bonding PMD >PMD >hardware > > so, I think cmdlines for tes

Re: [PATCH v1 1/2] net/memif: add a Rx fast path

2022-05-18 Thread Ferruh Yigit
On 5/17/2022 11:51 AM, Joyce Kong wrote: For memif non-zero-copy mode, there is a branch to compare the mbuf and memif buffer size during memory copying. Add a fast memory copy path by removing this branch with mbuf and memif buffer size defined at compile time. The removal of the branch leads to

Re: [PATCH v1 1/2] net/memif: add a Rx fast path

2022-05-18 Thread Ferruh Yigit
On 5/17/2022 11:51 AM, Joyce Kong wrote: For memif non-zero-copy mode, there is a branch to compare the mbuf and memif buffer size during memory copying. Add a fast memory copy path by removing this branch with mbuf and memif buffer size defined at compile time. The removal of the branch leads to

Re: [RFC] ethdev: datapath-focused meter actions, continue

2022-05-18 Thread Andrew Rybchenko
Hi all, I'm sorry, I'm not sure that I can take part in tomorrow meeting, so, I'd like to drop my thoughts on the topic via E-mail. Existing "meter" object which pulls profile and policy together allows do apply metering in one flow-based lookup for different flows. I.e. we can route absolute

RE: [EXT] [PATCH v4 8/8] examples/fips_validation: add parsing for cmac

2022-05-18 Thread Gowrishankar Muthukrishnan
Verified the functionality changes and looks good to me. Acked-by: Gowrishankar Muthukrishnan Thanks. > -Original Message- > From: Brandon Lo > Sent: Friday, April 29, 2022 9:46 PM > To: roy.fan.zh...@intel.com; ciara.po...@intel.com > Cc: dev@dpdk.org; Brandon Lo > Subject: [EXT] [PA

RE: [EXT] [PATCH v4 7/8] examples/fips_validation: implement json cmac test

2022-05-18 Thread Gowrishankar Muthukrishnan
Verified the functionality changes and looks good to me. Acked-by: Gowrishankar Muthukrishnan Thanks. > -Original Message- > From: Brandon Lo > Sent: Friday, April 29, 2022 9:46 PM > To: roy.fan.zh...@intel.com; ciara.po...@intel.com > Cc: dev@dpdk.org; Brandon Lo > Subject: [EXT] [PA

RE: [EXT] [PATCH v4 6/8] examples/fips_validation: add json to hmac

2022-05-18 Thread Gowrishankar Muthukrishnan
Verified the functionality changes and looks good to me. Acked-by: Gowrishankar Muthukrishnan Thanks. > -Original Message- > From: Brandon Lo > Sent: Friday, April 29, 2022 9:46 PM > To: roy.fan.zh...@intel.com; ciara.po...@intel.com > Cc: dev@dpdk.org; Brandon Lo > Subject: [EXT] [PA

RE: [EXT] [PATCH v4 5/8] examples/fips_validation: add json to gcm test

2022-05-18 Thread Gowrishankar Muthukrishnan
Verified the functionality changes and looks good to me. Acked-by: Gowrishankar Muthukrishnan Thanks. > -Original Message- > From: Brandon Lo > Sent: Friday, April 29, 2022 9:46 PM > To: roy.fan.zh...@intel.com; ciara.po...@intel.com > Cc: dev@dpdk.org; Brandon Lo > Subject: [EXT] [PA

RE: [EXT] [PATCH v4 4/8] examples/fips_validation: allow json file as input

2022-05-18 Thread Gowrishankar Muthukrishnan
Verified the functionality changes and looks good to me. Acked-by: Gowrishankar Muthukrishnan Thanks. > -Original Message- > From: Brandon Lo > Sent: Friday, April 29, 2022 9:46 PM > To: roy.fan.zh...@intel.com; ciara.po...@intel.com > Cc: dev@dpdk.org; Brandon Lo > Subject: [EXT] [PA

RE: [EXT] [PATCH v4 3/8] examples/fips_validation: add json parsing

2022-05-18 Thread Gowrishankar Muthukrishnan
Verified the functionality changes and looks good to me. Acked-by: Gowrishankar Muthukrishnan Thanks. > -Original Message- > From: Brandon Lo > Sent: Friday, April 29, 2022 9:46 PM > To: roy.fan.zh...@intel.com; ciara.po...@intel.com > Cc: dev@dpdk.org; Brandon Lo > Subject: [EXT] [PA

RE: [EXT] [PATCH v4 2/8] examples/fips_validation: add json info to header

2022-05-18 Thread Gowrishankar Muthukrishnan
Verified the functionality changes and looks good to me. Acked-by: Gowrishankar Muthukrishnan Thanks. > -Original Message- > From: Brandon Lo > Sent: Friday, April 29, 2022 9:46 PM > To: roy.fan.zh...@intel.com; ciara.po...@intel.com > Cc: dev@dpdk.org; Brandon Lo > Subject: [EXT] [PA

RE: [EXT] [PATCH v4 1/8] examples/fips_validation: add jansson dependency

2022-05-18 Thread Gowrishankar Muthukrishnan
Verified the functionality changes and looks good to me. Acked-by: Gowrishankar Muthukrishnan Thanks. > -Original Message- > From: Brandon Lo > Sent: Friday, April 29, 2022 9:46 PM > To: roy.fan.zh...@intel.com; ciara.po...@intel.com > Cc: dev@dpdk.org; Brandon Lo > Subject: [EXT] [PA

[PATCH] examples/fips_validation: add parsing for aes_cbc

2022-05-18 Thread Gowrishankar Muthukrishnan
Added function to parse algorithm for AES_CBC test. Signed-off-by: Gowrishankar Muthukrishnan --- examples/fips_validation/fips_validation.c| 14 +- examples/fips_validation/fips_validation.h| 1 + .../fips_validation/fips_validation_aes.c | 218 ++ examples/fips_v

[PATCH v2] examples/fips_validation: reset IV generation in every test group

2022-05-18 Thread Gowrishankar Muthukrishnan
Reset IV generation in every test group. Signed-off-by: Gowrishankar Muthukrishnan --- v2: - rebase on latest main. --- examples/fips_validation/fips_validation_gcm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/examples/fips_validation/fips_validation_gcm.c b/examples/fips_validation

[PATCH] examples/fips_validation: cleanup bypass tests in response file

2022-05-18 Thread Gowrishankar Muthukrishnan
Remove garbage entries for bypassed tests in response file. Signed-off-by: Gowrishankar Muthukrishnan --- examples/fips_validation/main.c | 74 - 1 file changed, 35 insertions(+), 39 deletions(-) diff --git a/examples/fips_validation/main.c b/examples/fips_valida

Re: [RFC v3 01/11] net/idpf/base: introduce base code

2022-05-18 Thread Stephen Hemminger
On Wed, 18 May 2022 16:25:21 +0800 Junfeng Guo wrote: > + /* TODO hardcode a mac addr for now */ > + hw->mac.addr[0] = 0x00; > + hw->mac.addr[1] = 0x00; > + hw->mac.addr[2] = 0x00; > + hw->mac.addr[3] = 0x00; > + hw->mac.addr[4] = 0x03; > + hw->mac.addr[5] = 0x14; DPD

Re: [PATCH v3] app/testpmd: support ddp dump command for ice

2022-05-18 Thread Stephen Hemminger
On Wed, 18 May 2022 06:58:06 + Steve Yang wrote: > +#define ICE_BUFF_SIZE0x000c9000 Having magic size hard coded in testpmd is bad idea. If there is driver specific size it should be exposed by API > + size = ICE_BUFF_SIZE; > + buff = (uint8_t *)malloc(ICE_BUFF_SIZE); Cast o

Re: [PATCH v1 1/2] net/ice: support dump ice ddp package

2022-05-18 Thread Stephen Hemminger
On Wed, 11 May 2022 08:02:46 + Steve Yang wrote: > +#define ICE_PKG_COPY_STRING(dst, src)\ > + do {\ > + char *_dst = (dst); \ > + const char *_src = (src); \ > + memset(_dst, SPACE_CHAR, ICE_PKG_NAME_SIZE); \ > + strncpy(_dst, _src,

[dpdk-dev] [PATCH] doc: update cnxk native compilation steps

2022-05-18 Thread jerinj
From: Jerin Jacob Update cnxk platform documentation to use -Dplatform meson option for native builds. Signed-off-by: Jerin Jacob --- doc/guides/platform/cnxk.rst | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/doc/guides/platform/cnxk.rst b/doc/guides/platfor

RE: [PATCH v4 1/2] config/arm: add SVE ACLE control flag

2022-05-18 Thread Juraj Linkeš
> > > -Original Message- > > > From: Rahul Bhansali > > > Sent: Monday, May 9, 2022 12:20 PM > > > To: dev@dpdk.org; Ruifeng Wang ; Jan Viktorin > > > ; Bruce Richardson > > > > > > Cc: jer...@marvell.com; Rahul Bhansali > > > Subject: [PATCH v4 1/2] config/arm: add SVE ACLE control flag

Re: [PATCH v4] eal: allow worker lcore stacks to be allocated from hugepage memory

2022-05-18 Thread Don Wallwork
On 5/17/2022 11:56 AM, Stephen Hemminger wrote: On Tue, 17 May 2022 11:31:36 -0400 Don Wallwork wrote: Add support for using hugepages for worker lcore stack memory. The intent is to improve performance by reducing stack memory related TLB misses and also by using memory local to the NUMA nod

[PATCH] event/cnxk: fix incorrect return value

2022-05-18 Thread pbhagavatula
From: Pavan Nikhilesh The `rte_event_eth_tx_adapter_enqueue()` function expects driver layer to return the total number of events successfully transmitted. Fix cn10k driver returning the number of packets transmitted in a event vector instead of number of events. Fixes: 761a321acf91 ("event/cnxk

RE: [dpdk-dev v2 1/2] build: add in option for qat use intel ipsec-mb lib

2022-05-18 Thread Ji, Kai
Hi Bruce, We want user to have the ability to choice which lib they want to use, so the original design was to make the build option temporary, and it will get removed after ipsec-mb FIP certified. Will look into the runtime option to avoid top level build option modification. Regards Kai >

[PATCH v8 13/13] vdpa/ifc/base: access correct register for blk device

2022-05-18 Thread Andy Pei
Register address is different between net and blk device. We are re-use most of the code, when register address is different, we have to check net and blk device go through different code. Signed-off-by: Andy Pei --- drivers/vdpa/ifc/base/ifcvf.c | 34 +++--- 1 file c

[PATCH v8 12/13] vdpa/ifc: add interrupt handling for config space

2022-05-18 Thread Andy Pei
Create a thread to poll and relay config space change interrupt. Use VHOST_USER_SLAVE_CONFIG_CHANGE_MSG to inform QEMU. Signed-off-by: Andy Pei --- drivers/vdpa/ifc/ifcvf_vdpa.c | 118 +- 1 file changed, 117 insertions(+), 1 deletion(-) diff --git a/drive

[PATCH v8 11/13] vdpa/ifc: add log for config space of virtio blk

2022-05-18 Thread Andy Pei
Add some log of virtio blk device config space information at VDPA launch before qemu connects. Signed-off-by: Andy Pei --- drivers/vdpa/ifc/ifcvf_vdpa.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf

[PATCH v8 10/13] usertools: add support for virtio blk device

2022-05-18 Thread Andy Pei
Add virtio blk device support to devbind. Signed-off-by: Andy Pei --- usertools/dpdk-devbind.py | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py index ace4627..7231be4 100755 --- a/usertools/dpdk-devbind.py +++ b/userto

[PATCH v8 09/13] examples/vdpa: add add virtio blk support

2022-05-18 Thread Andy Pei
Add virtio blk device support to vDPA example. Signed-off-by: Andy Pei --- examples/vdpa/main.c | 56 ++ examples/vdpa/vdpa_blk_compact.h | 58 2 files changed, 114 insertions(+) create mode 100644 examples

[PATCH v8 08/13] vdpa/ifc: add get device type ops to ifc driver

2022-05-18 Thread Andy Pei
Add get device type ops to ifc driver. Signed-off-by: Andy Pei --- drivers/vdpa/ifc/ifcvf_vdpa.c | 25 + 1 file changed, 25 insertions(+) diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.c index 3e78c7d..0acfa8c 100644 --- a/drivers/vdpa/ifc/ifcvf

[PATCH v8 07/13] vhost: add API to get vDPA device type

2022-05-18 Thread Andy Pei
Vhost backend of different devices have different features. Add a API to get vDPA device type, net device or blk device currently, so users can set different features for different kinds of devices. Signed-off-by: Andy Pei --- doc/guides/prog_guide/vhost_lib.rst| 5 doc/guides/rel_note

[PATCH v8 06/13] vdpa/ifc: add block device SW live-migration

2022-05-18 Thread Andy Pei
Add SW live-migration support to block device. For block device, it is critical that no packet should be dropped. So when virtio blk device is pause, make sure hardware last_avail_idx and last_used_idx are the same. This indicates all requests have recieved acks, and no inflight IO. Signed-off-by:

[PATCH v8 04/13] vdpa/ifc: add blk ops for ifc device

2022-05-18 Thread Andy Pei
For virtio blk device, re-use part of ifc driver ops. Implement ifcvf_blk_get_config for virtio blk device. Support VHOST_USER_PROTOCOL_F_CONFIG feature for virtio blk device. Signed-off-by: Andy Pei --- drivers/vdpa/ifc/base/ifcvf.h | 4 ++ drivers/vdpa/ifc/ifcvf_vdpa.c | 91 ++

[PATCH v8 05/13] vdpa/ifc: add vDPA interrupt relay for blk device

2022-05-18 Thread Andy Pei
For the net device type, only interrupt of rxq needed to be relayed. But for block, since all the queues are used for both read and write requests. Interrupt of all queues needed to be relayed. Signed-off-by: Andy Pei --- drivers/vdpa/ifc/ifcvf_vdpa.c | 9 - 1 file changed, 8 insertions(

[PATCH v8 03/13] vhost: add vhost msg support for get/set config

2022-05-18 Thread Andy Pei
Add support for VHOST_USER_GET_CONFIG and VHOST_USER_SET_CONFIG. VHOST_USER_GET_CONFIG and VHOST_USER_SET_CONFIG message is only supported by virtio blk VDPA device. Signed-off-by: Andy Pei --- lib/vhost/vhost_user.c | 73 ++ lib/vhost/vhost_user.h

[PATCH v8 02/13] vhost: add vDPA ops for blk device

2022-05-18 Thread Andy Pei
Get_config and set_config are necessary ops for blk device. Add get_config and set_config ops to vDPA ops. Signed-off-by: Andy Pei Reviewed-by: Maxime Coquelin --- lib/vhost/vdpa_driver.h | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/lib/vhost/vdpa_driver.h b/lib/v

[PATCH v8 01/13] vdpa/ifc: add support for virtio blk device

2022-05-18 Thread Andy Pei
Re-use the vdpa/ifc code, distinguish blk and net device by pci_device_id. Blk and net device are implemented with proper feature and ops. Signed-off-by: Andy Pei --- drivers/vdpa/ifc/base/ifcvf.h | 16 +++- drivers/vdpa/ifc/ifcvf_vdpa.c | 91 +++ 2 fi

[PATCH v8 00/13] add virtio_blk device support to vdpa/ifc

2022-05-18 Thread Andy Pei
This patch set add virtio_blk device support to vdpa/ifc driver. With a lot of similarities, I re-use part of vdpa/ifc driver. Distinguish the virtio net and blk device by device id, and implement specific features and ops. Add example to vdpa to support virtio_blk device. To support blk device li

Re: [PATCH v1 5/5] net/ark: add PMD support for devices as virtual functions

2022-05-18 Thread Ferruh Yigit
On 5/6/2022 10:27 PM, Ed Czeck wrote: Add capabilities field isvf to dev struct Disable configuration calls as required by vf Signed-off-by: Ed Czeck Hi Ed, Last two patches are removing VF restriction, adding a new VF device and enabling its probing. Can you please document this new featur

Re: [PATCH v1 1/5] net/ark: update mpu code to match current hardware version

2022-05-18 Thread Ferruh Yigit
On 5/6/2022 10:27 PM, Ed Czeck wrote: new version code remove device-level global operations remove ark_mpu_reset_stats function Hi Ed, please find a few comments inline. Also I assume 'mpu' is an abbreviation, can you please document what it stands for in the commit log, like MPU (M.. P.. U

Re: Re: [PATCH] bus: fix code unused

2022-05-18 Thread David Marchand
On Tue, May 17, 2022 at 3:54 AM taoyunxi...@cmss.chinamobile.com wrote: > >> @@ -143,7 +143,7 @@ local_dev_probe(const char *devargs, struct rte_device > >> **new_dev) > >> if (ret) > >> goto err_devarg; > >> > >> - if (da->bus->plug == NULL) { > >> + if (da->b

RE: [PATCH 09/12] vdpa/ifc: fix build with GCC 12

2022-05-18 Thread Wang, Xiao W
Hi, > -Original Message- > From: David Marchand > Sent: Wednesday, May 18, 2022 6:17 PM > To: dev@dpdk.org > Cc: tho...@monjalon.net; ferruh.yi...@xilinx.com; sta...@dpdk.org; > Wang, Xiao W > Subject: [PATCH 09/12] vdpa/ifc: fix build with GCC 12 > > GCC 12 raises the following warning

Re: [dpdk-dev v2 1/2] build: add in option for qat use intel ipsec-mb lib

2022-05-18 Thread Bruce Richardson
On Wed, May 18, 2022 at 11:26:27AM +0100, Ferruh Yigit wrote: > On 5/18/2022 9:04 AM, Bruce Richardson wrote: > > On Tue, May 17, 2022 at 10:16:51PM +0800, Kai Ji wrote: > > > Add in build option for QAT pmd use intel ipsec-mb lib > > > instead openssl for precompute partial hash & aes. > > > > >

Re: [dpdk-dev v2 1/2] build: add in option for qat use intel ipsec-mb lib

2022-05-18 Thread Ferruh Yigit
On 5/18/2022 9:04 AM, Bruce Richardson wrote: On Tue, May 17, 2022 at 10:16:51PM +0800, Kai Ji wrote: Add in build option for QAT pmd use intel ipsec-mb lib instead openssl for precompute partial hash & aes. Signed-off-by: Kai Ji --- drivers/common/qat/meson.build | 12 meson_o

[PATCH 12/12] test/ipsec: fix build with GCC 12

2022-05-18 Thread David Marchand
GCC 12 raises the following warning: In function ‘_mm256_loadu_si256’, inlined from ‘rte_mov32’ at ../lib/eal/x86/include/rte_memcpy.h:319:9, inlined from ‘rte_mov128’ at ../lib/eal/x86/include/rte_memcpy.h:344:2, inlined from ‘rte_memcpy_generic’ at ../lib/eal/

[PATCH 11/12] app/flow-perf: fix build with GCC 12

2022-05-18 Thread David Marchand
GCC 12 raises the following warning: ../app/test-flow-perf/main.c: In function ‘start_forwarding’: ../app/test-flow-perf/main.c:1737:28: error: ‘sprintf’ may write a terminating nul past the end of the destination [-Werror=format-overflow=] 1737 | sprintf(p[i++], "%d", (int)n);

[PATCH 10/12] vhost/crypto: fix build with GCC 12

2022-05-18 Thread David Marchand
GCC 12 raises the following warning: In file included from ../lib/mempool/rte_mempool.h:46, from ../lib/mbuf/rte_mbuf.h:38, from ../lib/vhost/vhost_crypto.c:7: ../lib/vhost/vhost_crypto.c: In function ‘rte_vhost_crypto_fetch_requests’: ../lib/eal/x86/include/rte_m

[PATCH 09/12] vdpa/ifc: fix build with GCC 12

2022-05-18 Thread David Marchand
GCC 12 raises the following warning: ../drivers/vdpa/ifc/ifcvf_vdpa.c: In function ‘vdpa_enable_vfio_intr’: ../drivers/vdpa/ifc/ifcvf_vdpa.c:383:62: error: writing 4 bytes into a region of size 0 [-Werror=stringop-overflow=] 383 | fd_ptr[RTE_INTR_VEC_RXTX_OFFSET + i]

[PATCH 08/12] net/qede/base: fix build with GCC 12

2022-05-18 Thread David Marchand
GCC raises the following warning: In function ‘_mm256_storeu_si256’, inlined from ‘rte_mov32’ at ../lib/eal/x86/include/rte_memcpy.h:320:2, inlined from ‘rte_mov128’ at ../lib/eal/x86/include/rte_memcpy.h:342:2, inlined from ‘rte_memcpy_generic’ at ../lib/eal/x8

[PATCH 07/12] net/ice/base: fix build with GCC 12

2022-05-18 Thread David Marchand
GCC 12 raises the following warning: ../drivers/net/ice/base/ice_switch.c: In function ‘ice_add_sw_recipe’: ../drivers/net/ice/base/ice_switch.c:7219:61: error: writing 1 byte into a region of size 0 [-Werror=stringop-overflow=] 7219 | buf[recps].content.lkup_indx[i + 1] = entry->

[PATCH 06/12] net/ice: fix build with GCC 12

2022-05-18 Thread David Marchand
GCC 12 raises the following warning: In file included from ../lib/mempool/rte_mempool.h:46, from ../lib/mbuf/rte_mbuf.h:38, from ../lib/net/rte_ether.h:22, from ../lib/ethdev/rte_ethdev.h:172, from ../lib/ethdev/ethdev_driver.h:22

[PATCH 05/12] net/enetfec: fix build with GCC 12

2022-05-18 Thread David Marchand
GCC 12 raises the following warning: ../drivers/net/enetfec/enet_ethdev.c: In function ‘enetfec_rx_queue_setup’: ../drivers/net/enetfec/enet_ethdev.c:473:9: error: array subscript 1 is above array bounds of ‘uint32_t[1]’ {aka ‘unsigned int[1]’} [-Werror=array-bounds]

[PATCH 04/12] net/ena: fix build with GCC 12

2022-05-18 Thread David Marchand
GCC 12 raises the following warning: In file included from ../lib/mempool/rte_mempool.h:46, from ../lib/mbuf/rte_mbuf.h:38, from ../lib/net/rte_ether.h:22, from ../drivers/net/ena/ena_ethdev.h:10, from ../drivers/net/ena/ena_rss.c

[PATCH 03/12] crypto/ipsec_mb: fix build with GCC 12

2022-05-18 Thread David Marchand
GCC 12 raises the following warning: In function ‘__rte_ring_enqueue_elems_64’, inlined from ‘__rte_ring_enqueue_elems’ at ../lib/ring/rte_ring_elem_pvt.h:130:3, inlined from ‘__rte_ring_do_hts_enqueue_elem’ at ../lib/ring/rte_ring_hts_elem_pvt.h:196:3, inlined from ‘rt

[PATCH 02/12] crypto/cnxk: fix build with GCC 12

2022-05-18 Thread David Marchand
GCC 12 raises the following warning: In file included from ../drivers/crypto/cnxk/cn10k_cryptodev_ops.c:17: In function ‘fill_sg_comp_from_iov’, inlined from ‘cpt_kasumi_enc_prep’ at ../drivers/crypto/cnxk/cnxk_se.h:1413:8, inlined from ‘cpt_fc_enc_hmac_prep’ at ../drivers/

[PATCH 01/12] common/cpt: fix build with GCC 12

2022-05-18 Thread David Marchand
GCC 12 raises the following warning: In function ‘fill_sg_comp_from_iov’, inlined from ‘cpt_kasumi_enc_prep’ at ../drivers/common/cpt/cpt_ucode.h:2176:8, inlined from ‘cpt_fc_enc_hmac_prep’ at ../drivers/common/cpt/cpt_ucode.h:2475:3, inlined from ‘fill_digest_params’ a

[PATCH 00/12] Fix compilation with gcc 12

2022-05-18 Thread David Marchand
Fedora 36 is out since early may and comes with gcc 12. This series fixes compilation or waives some checks. There might be something fishy with rte_memcpy on x86 but, for now, the rte_memcpy related fixes are on the caller side. Some "base" drivers have issues, I chose the simple solution of wai

[PATCH] net/mlx5: fix Tx recovery

2022-05-18 Thread Raja Zidane
When an error occurs in Tx, and it is moved to ERROR state, it is not recoverable, during recovery it's state cannot be modified to INIT. to modify state from RESET to INIT, the port must be passed in modify attributes, and in case of ERROR to READY modification path, it was not provided. Provide

RE: [PATCH v4 1/2] config/arm: add SVE ACLE control flag

2022-05-18 Thread Rahul Bhansali
> -Original Message- > From: Juraj Linkeš > Sent: Tuesday, May 17, 2022 1:26 PM > To: Rahul Bhansali ; dev@dpdk.org; Ruifeng Wang > ; Jan Viktorin ; Bruce > Richardson > Cc: Jerin Jacob Kollanukkaran > Subject: [EXT] RE: [PATCH v4 1/2] config/arm: add SVE ACLE control flag > > Extern

Re: [PATCH v2 4/4] examples/l3fwd_power: add cli for configurable options

2022-05-18 Thread Burakov, Anatoly
On 19-Apr-22 12:25 PM, Kevin Laatz wrote: Add CLI options to l3fwd_power to utilize the new power APIs introduced in this patchset. These CLI options allow the user to configure the heuritstics made available through the new API via the l3fwd_power application options. Signed-off-by: Kevin Laatz

[PATCH] net/mlx5: fix build with clang 14

2022-05-18 Thread David Marchand
clang 14 raises the following warning: ../drivers/net/mlx5/linux/mlx5_ethdev_os.c:1137:52: error: 'fscanf' may overflow; destination buffer in argument 3 has size 16, but the corresponding specifier may require size 17 [-Werror,-Wfortify-source] ret = fscanf(file, "%" R

Re: [PATCH v2 3/4] lib/power: add get and set API for scaling freq min and max with pstate mode

2022-05-18 Thread Burakov, Anatoly
On 19-Apr-22 12:25 PM, Kevin Laatz wrote: Add new get/set API to allow the user or application to set the minimum and maximum frequencies to use when scaling. Previously, the frequency range was determined by the HW capabilities of the CPU. With this new API, the user or application can constrain

Re: [PATCH v2 2/4] lib/power: add get and set API for pause duration

2022-05-18 Thread Burakov, Anatoly
On 19-Apr-22 12:24 PM, Kevin Laatz wrote: Add new get/set API for configuring 'pause_duration' which used to adjust the pause mode callback duration. Signed-off-by: Kevin Laatz --- @@ -334,11 +336,11 @@ clb_pause(uint16_t port_id __rte_unused, uint16_t qidx __rte_unused, if

[PATCH] examples/vhost: Fix retry logic on Rx

2022-05-18 Thread Yuan Wang
drain_eth_rx() uses rte_vhost_avail_entries() to calculate the available entries to determine if a retry is required. However, this function only works with split rings, and calculating packed rings will return the wrong value and cause unnecessary retries resulting in a significant performance pen

[RFC v3 11/11] net/idpf: add CPF device ID for idpf map table

2022-05-18 Thread Junfeng Guo
This patch adds CPF device ID. CPF data path is supported by idpf PMD now. Signed-off-by: Wenjun Wu Signed-off-by: Beilei Xing Signed-off-by: Junfeng Guo --- drivers/net/idpf/base/iecm_devids.h | 1 + drivers/net/idpf/idpf_ethdev.c | 1 + 2 files changed, 2 insertions(+) diff --git a/dri

[RFC v3 10/11] net/idpf: support MTU configuration

2022-05-18 Thread Junfeng Guo
support ops mtu_set. Signed-off-by: Beilei Xing Signed-off-by: Junfeng Guo --- drivers/net/idpf/idpf_ethdev.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/net/idpf/idpf_ethdev.c b/drivers/net/idpf/idpf_ethdev.c index e46cadf83a..9b0bbca4a5 100644 --- a/drivers/net

[RFC v3 09/11] net/idpf: support RSS

2022-05-18 Thread Junfeng Guo
Add RSS support. Signed-off-by: Beilei Xing Signed-off-by: Junfeng Guo --- drivers/net/idpf/idpf_ethdev.c | 106 + drivers/net/idpf/idpf_ethdev.h | 18 +- drivers/net/idpf/idpf_vchnl.c | 93 + 3 files changed, 216 insertions(+),

[RFC v3 08/11] net/idpf: support basic Rx/Tx

2022-05-18 Thread Junfeng Guo
Add basic RX & TX support in split queue mode and single queue mode. Using split queue mode by default. Signed-off-by: Beilei Xing Signed-off-by: Xiaoyun Li Signed-off-by: Junfeng Guo --- drivers/net/idpf/idpf_ethdev.c | 93 drivers/net/idpf/idpf_rxtx.c | 877 ++

[RFC v3 07/11] net/idpf: support link update

2022-05-18 Thread Junfeng Guo
Add ops link_update. Signed-off-by: Beilei Xing Signed-off-by: Junfeng Guo --- drivers/net/idpf/idpf_ethdev.c | 22 ++ drivers/net/idpf/idpf_ethdev.h | 2 ++ 2 files changed, 24 insertions(+) diff --git a/drivers/net/idpf/idpf_ethdev.c b/drivers/net/idpf/idpf_ethdev.c inde

[RFC v3 06/11] net/idpf: support packet type getting

2022-05-18 Thread Junfeng Guo
Add ops dev_supported_ptypes_get. Signed-off-by: Beilei Xing Signed-off-by: Junfeng Guo --- drivers/net/idpf/idpf_ethdev.c | 3 ++ drivers/net/idpf/idpf_rxtx.c | 51 ++ drivers/net/idpf/idpf_rxtx.h | 3 ++ 3 files changed, 57 insertions(+) diff --git a/dri

[RFC v3 05/11] net/idpf: support getting device information

2022-05-18 Thread Junfeng Guo
Add ops dev_infos_get. Signed-off-by: Beilei Xing Signed-off-by: Junfeng Guo --- drivers/net/idpf/idpf_ethdev.c | 69 ++ 1 file changed, 69 insertions(+) diff --git a/drivers/net/idpf/idpf_ethdev.c b/drivers/net/idpf/idpf_ethdev.c index b48a722b80..02e0760fc4 10

[RFC v3 04/11] net/idpf: support queue ops

2022-05-18 Thread Junfeng Guo
Add queue ops for IDPF PMD: rx_queue_start rx_queue_stop tx_queue_start tx_queue_stop rx_queue_setup rx_queue_release tx_queue_setup tx_queue_release Signed-off-by: Beilei Xing Signed-off-by: Xiaoyun Li Signed-off-by: Junfeng Guo -

[RFC v3 03/11] net/idpf: support device initialization

2022-05-18 Thread Junfeng Guo
Support dev init and add dev ops for IDPF PMD: dev_configure dev_start dev_stop dev_close Signed-off-by: Beilei Xing Signed-off-by: Xiaoyun Li Signed-off-by: Xiao Wang Signed-off-by: Junfeng Guo --- drivers/net/idpf/idpf_ethdev.c | 655 +

[RFC v3 02/11] net/idpf/base: add OS specific implementation

2022-05-18 Thread Junfeng Guo
Add some MACRO definations and small functions which are specific for DPDK. Signed-off-by: Beilei Xing Signed-off-by: Junfeng Guo --- drivers/net/idpf/base/iecm_osdep.h | 365 + 1 file changed, 365 insertions(+) create mode 100644 drivers/net/idpf/base/iecm_osdep.h

[RFC v3 00/11] add support for idpf PMD in DPDK

2022-05-18 Thread Junfeng Guo
This is a draft of idpf (Infrastructure Data Path Function) PMD in DPDK for Intel Device ID of 0x1452 and 0x1453. v3: fix small issues and add support for device id 0x1453. v2: fix code typo in func idpf_set_tx_function. Junfeng Guo (11): net/idpf/base: introduce base code net/idpf/base: add

  1   2   >