Please find comments inline from CI point of view. > -----Original Message----- > From: Brandon Lo <b...@iol.unh.edu> > Sent: Friday, April 29, 2022 9:46 PM > To: roy.fan.zh...@intel.com; ciara.po...@intel.com > Cc: dev@dpdk.org; Brandon Lo <b...@iol.unh.edu> > Subject: [EXT] [PATCH v4 8/8] examples/fips_validation: add parsing for cmac > > External Email > > ---------------------------------------------------------------------- > Added function to parse algorithm for CMAC test. > > Signed-off-by: Brandon Lo <b...@iol.unh.edu> > --- > examples/fips_validation/fips_validation.c | 31 +++++++++++++++++++--- > examples/fips_validation/main.c | 3 +++ > 2 files changed, 31 insertions(+), 3 deletions(-) > > diff --git a/examples/fips_validation/fips_validation.c > b/examples/fips_validation/fips_validation.c > index 04dfb85262..8e0a55c624 100644 > --- a/examples/fips_validation/fips_validation.c > +++ b/examples/fips_validation/fips_validation.c > @@ -460,6 +460,8 @@ fips_test_parse_one_json_vector_set(void) > info.algo = FIPS_TEST_ALGO_AES_GCM; ...... ...... > > +int > +parser_read_cmac_direction_str(__rte_unused const char *key, char *src, > + __rte_unused struct fips_val *val)
Can this function be static in fips_validation_cmac.c which is more appropriate also ?. Thanks, Gowrishankar
