[dpdk-dev] [PATCH 2/2] net/cnxk: support IPv6 fragment flow pattern item

2022-04-26 Thread psatheesh
From: Satheesh Paul Support matching IPv6 fragment extension header with RTE_FLOW_ITEM_TYPE_IPV6_FRAG_EXT flow pattern item. Signed-off-by: Satheesh Paul --- doc/guides/nics/features/cnxk.ini | 1 + doc/guides/nics/features/cnxk_vec.ini | 1 + doc/guides/nics/features/cnxk_vf.ini | 1 + d

[dpdk-dev] [PATCH 1/2] common/cnxk: support IPv6 fragment flow pattern item

2022-04-26 Thread psatheesh
From: Satheesh Paul ROC changes to support RTE_FLOW_ITEM_TYPE_IPV6_FRAG_EXT flow pattern item. Signed-off-by: Satheesh Paul --- drivers/common/cnxk/roc_npc.h | 1 + drivers/common/cnxk/roc_npc_parse.c | 7 +++ 2 files changed, 8 insertions(+) diff --git a/drivers/common/cnxk/roc_npc

[PATCH] security: fix comments

2022-04-26 Thread Anoob Joseph
Fix comments to reflect the field. Fixes: ad7515a39f2a ("security: add SA lifetime configuration") Cc: ano...@marvell.com Reported-by: Thomas Monjalon Signed-off-by: Anoob Joseph --- lib/security/rte_security.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/securit

[Bug 1002] [meson test] Debug-tests/dump_* all meson test time out because commands are not registered to command list

2022-04-26 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1002 Bug ID: 1002 Summary: [meson test] Debug-tests/dump_* all meson test time out because commands are not registered to command list Product: DPDK Version: unspecified

[Bug 1001] [meson test] Debug-tests/dump_* all meson test time out because commands are not registered to command list

2022-04-26 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1001 Bug ID: 1001 Summary: [meson test] Debug-tests/dump_* all meson test time out because commands are not registered to command list Product: DPDK Version: unspecified

RE: [PATCH v6 03/16] vhost: add vhost msg support

2022-04-26 Thread Pei, Andy
Hi Chenbo, Thanks for your reply. My reply is inline. > -Original Message- > From: Xia, Chenbo > Sent: Tuesday, April 26, 2022 5:17 PM > To: Pei, Andy ; dev@dpdk.org > Cc: maxime.coque...@redhat.com; Cao, Gang ; Liu, > Changpeng > Subject: RE: [PATCH v6 03/16] vhost: add vhost msg supp

RE: [PATCH v6 07/16] examples/vdpa: add vDPA blk support in example

2022-04-26 Thread Pei, Andy
Hi Chenbo, Thanks for your reply. My reply is inline. > -Original Message- > From: Xia, Chenbo > Sent: Monday, April 25, 2022 9:39 PM > To: Pei, Andy ; dev@dpdk.org > Cc: maxime.coque...@redhat.com; Cao, Gang ; Liu, > Changpeng > Subject: RE: [PATCH v6 07/16] examples/vdpa: add vDPA blk

RE: [PATCH v7 0/9] Enable ETS-based TX QoS on PF

2022-04-26 Thread Yang, Qiming
Hi, > -Original Message- > From: Wu, Wenjun1 > Sent: 2022年4月22日 8:58 > To: dev@dpdk.org; Yang, Qiming ; Zhang, Qi Z > > Subject: [PATCH v7 0/9] Enable ETS-based TX QoS on PF > > This patch set enables ETS-based TX QoS on PF. It is supported to configure > bandwidth and priority in both

RE: [DPDK v4] net/ixgbe: promote MDIO API

2022-04-26 Thread Zhang, Qi Z
> -Original Message- > From: Ray Kinsella > Sent: Tuesday, April 26, 2022 6:12 PM > To: Zeng, ZhichaoX > Cc: dev@dpdk.org; Yang, Qiming ; Wang, Haiyue > ; David Marchand > Subject: Re: [DPDK v4] net/ixgbe: promote MDIO API > > > Zeng, ZhichaoX writes: > > > Hi, Ray, David: > > > >

RE: [PATCH] doc: update matching versions in ice guide

2022-04-26 Thread Zhang, Qi Z
> -Original Message- > From: Yang, Qiming > Sent: Tuesday, April 26, 2022 1:36 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Yang, Qiming > ; sta...@dpdk.org > Subject: [PATCH] doc: update matching versions in ice guide > > Add recommended matching list for ice PMD in DPDK 22.03. > > Cc:

RE: [RFC] eal: allow worker lcore stacks to be allocated from hugepage memory

2022-04-26 Thread Honnappa Nagarahalli
> > Add support for using hugepages for worker lcore stack memory. The intent is > to improve performance by reducing stack memory related TLB misses and also > by using memory local to the NUMA node of each lcore. This is a good idea. Have you measured any performance differences with this pa

RE: [PATCH v2] net/ice: optimize max queue number calculation

2022-04-26 Thread Zhang, Qi Z
> -Original Message- > From: Wu, Wenjun1 > Sent: Tuesday, April 26, 2022 9:14 PM > To: Zhang, Qi Z ; Yang, Qiming > Cc: dev@dpdk.org > Subject: RE: [PATCH v2] net/ice: optimize max queue number calculation > > > > > -Original Message- > > From: Zhang, Qi Z > > Sent: Friday,

Re: [Patch v2] net/netvsc: report correct stats values

2022-04-26 Thread Stephen Hemminger
On Tue, 26 Apr 2022 22:56:14 +0100 Ferruh Yigit wrote: > > if (i < RTE_ETHDEV_QUEUE_STAT_CNTRS) { > > - stats->q_opackets[i] = txq->stats.packets; > > - stats->q_obytes[i] = txq->stats.bytes; > > + stats->q_opackets[i] += txq->stat

Re: [Patch v2] net/netvsc: fix the calculation of checksums based on mbuf flag

2022-04-26 Thread Ajit Khaparde
On Tue, Apr 26, 2022 at 2:57 PM Ferruh Yigit wrote: > > On 3/24/2022 5:46 PM, lon...@linuxonhyperv.com wrote: > > From: Long Li > > > > The netvsc should use RTE_MBUF_F_TX_L4_MASK and check the masked value to > > decide the correct way to calculate checksums. > > > > Not checking for RTE_MBUF_F_

Re: [Patch v2] net/netvsc: fix the calculation of checksums based on mbuf flag

2022-04-26 Thread Ferruh Yigit
On 3/24/2022 5:46 PM, lon...@linuxonhyperv.com wrote: From: Long Li The netvsc should use RTE_MBUF_F_TX_L4_MASK and check the masked value to decide the correct way to calculate checksums. Not checking for RTE_MBUF_F_TX_L4_MASK results in incorrect RNDIS packets sent to VSP and incorrect check

Re: [Patch v2] net/netvsc: fix the calculation of checksums based on mbuf flag

2022-04-26 Thread Ferruh Yigit
On 3/24/2022 5:46 PM, lon...@linuxonhyperv.com wrote: From: Long Li The netvsc should use RTE_MBUF_F_TX_L4_MASK and check the masked value to decide the correct way to calculate checksums. Not checking for RTE_MBUF_F_TX_L4_MASK results in incorrect RNDIS packets sent to VSP and incorrect check

Re: [Patch v2] net/netvsc: report correct stats values

2022-04-26 Thread Ferruh Yigit
On 3/24/2022 5:45 PM, lon...@linuxonhyperv.com wrote: From: Long Li The netvsc should add to the values from the VF and report the sum. Per port stats already accumulated, like: 'stats->opackets += txq->stats.packets;' Fixes: 4e9c73e96e ("net/netvsc: add Hyper-V network device") Cc: sta...

[PATCH 2/2] event/cnxk: move post-processing to separate function

2022-04-26 Thread Pavan Nikhilesh
Move event post-processing to a separate function. Do complete event post-processing in tear-down functions to prevent incorrect memory free. Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn10k_eventdev.c | 5 +- drivers/event/cnxk/cn10k_worker.h | 190 +--- d

[PATCH 1/2] event/cnxk: add additional checks in OP_RELEASE

2022-04-26 Thread Pavan Nikhilesh
Add additional checks while performing RTE_EVENT_OP_RELEASE to ensure that there are no pending SWTAGs and FLUSHEs in flight. Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn10k_eventdev.c | 4 +--- drivers/event/cnxk/cn10k_worker.c | 8 ++-- drivers/event/cnxk/cn9k_eventdev.c |

Re: [RFC] eal: allow worker lcore stacks to be allocated from hugepage memory

2022-04-26 Thread Don Wallwork
On 4/26/2022 5:21 PM, Stephen Hemminger wrote: On Tue, 26 Apr 2022 17:01:18 -0400 Don Wallwork wrote: On 4/26/2022 10:58 AM, Stephen Hemminger wrote: On Tue, 26 Apr 2022 08:19:59 -0400 Don Wallwork wrote: Add support for using hugepages for worker lcore stack memory. The intent is to

Re: [RFC] eal: allow worker lcore stacks to be allocated from hugepage memory

2022-04-26 Thread Stephen Hemminger
On Tue, 26 Apr 2022 17:01:18 -0400 Don Wallwork wrote: > On 4/26/2022 10:58 AM, Stephen Hemminger wrote: > > On Tue, 26 Apr 2022 08:19:59 -0400 > > Don Wallwork wrote: > > > >> Add support for using hugepages for worker lcore stack memory. The > >> intent is to improve performance by reducing

[PATCH 6/6] examples/ipsec-secgw: cleanup worker state before exit

2022-04-26 Thread Pavan Nikhilesh
Event ports are configured to implicitly release the scheduler contexts currently held in the next call to rte_event_dequeue_burst(). A worker core might still hold a scheduling context during exit as the next call to rte_event_dequeue_burst() is never made. This might lead to deadlock based on the

[PATCH 5/6] examples/l2fwd-event: clean up worker state before exit

2022-04-26 Thread Pavan Nikhilesh
Event ports are configured to implicitly release the scheduler contexts currently held in the next call to rte_event_dequeue_burst(). A worker core might still hold a scheduling context during exit, as the next call to rte_event_dequeue_burst() is never made. This might lead to deadlock based on th

[PATCH 4/6] examples/l3fwd: clean up worker state before exit

2022-04-26 Thread Pavan Nikhilesh
Event ports are configured to implicitly release the scheduler contexts currently held in the next call to rte_event_dequeue_burst(). A worker core might still hold a scheduling context during exit, as the next call to rte_event_dequeue_burst() is never made. This might lead to deadlock based on th

[PATCH 3/6] examples/eventdev: clean up worker state before exit

2022-04-26 Thread Pavan Nikhilesh
Event ports are configured to implicitly release the scheduler contexts currently held in the next call to rte_event_dequeue_burst(). A worker core might still hold a scheduling context during exit, as the next call to rte_event_dequeue_burst() is never made. This might lead to deadlock based on th

[PATCH 2/6] app/eventdev: clean up worker state before exit

2022-04-26 Thread Pavan Nikhilesh
Event ports are configured to implicitly release the scheduler contexts currently held in the next call to rte_event_dequeue_burst(). A worker core might still hold a scheduling context during exit, as the next call to rte_event_dequeue_burst() is never made. This might lead to deadlock based on th

[PATCH 1/6] app/eventdev: simplify signal handling and teardown

2022-04-26 Thread Pavan Nikhilesh
Remove rte_*_dev calls from signal handler callback. Split ethernet device teardown into Rx and Tx sections, wait for workers to finish processing after disabling Rx to allow workers to complete processing currently held packets. Signed-off-by: Pavan Nikhilesh --- app/test-eventdev/evt_main.c

Re: [RFC] eal: allow worker lcore stacks to be allocated from hugepage memory

2022-04-26 Thread Don Wallwork
On 4/26/2022 10:58 AM, Stephen Hemminger wrote: On Tue, 26 Apr 2022 08:19:59 -0400 Don Wallwork wrote: Add support for using hugepages for worker lcore stack memory. The intent is to improve performance by reducing stack memory related TLB misses and also by using memory local to the NUMA

Re: [PATCH V2 2/4] net/bonding: fix non-terminable while loop

2022-04-26 Thread Ferruh Yigit
On 3/24/2022 3:00 AM, Min Hu (Connor) wrote: From: Huisong Li All slaves will be stopped and removed when closing a bonded port. But the while loop can not stop if both rte_eth_dev_stop and rte_eth_bond_slave_remove fail to run. Agree that this is a defect introduced in below commit. Thanks

Re: [PATCH V2 1/4] net/bonding: fix non-active slaves aren't stopped

2022-04-26 Thread Ferruh Yigit
On 3/24/2022 3:00 AM, Min Hu (Connor) wrote: From: Huisong Li When stopping a bonded port, all slaves should be deactivated. But only s/deactivated/stopped/ ? active slaves are stopped. So fix it and do "deactivae_slave()" for active s/deactivae_slave()/deactivate_slave()/ slaves. Hi

Fwd: Does ACL support field size of 8 bytes?

2022-04-26 Thread Konstantin Ananyev
Hi Ido, I've lots of good experience with ACL but can't make it work with u64 values I know it can be split to 2xu32 fields, but it makes it more complex to use and a wastes double number of fields (we hit the RTE_ACL_MAX_FIELDS 64 limit) Wow, that's a lot of fields... According to t

[PATCH 1/2] acl: fix rules with 8 bytes field size are broken

2022-04-26 Thread Konstantin Ananyev
In theory ACL library allows fields with 8B long. Though in practice they usually not used, not tested, and as was revealed by Ido, this functionality is not working properly. There are few places inside ACL build code-path that need to be addressed. Bugzilla ID: 673 Fixes: dc276b5780c2 ("acl: new

[PATCH 2/2] app/acl: support different formats for IPv6 address

2022-04-26 Thread Konstantin Ananyev
Within ACL rule IPv6 address can be represented in different ways: either as 4x4B fields, or as 2x8B fields. Till now, only first format was supported. Extend test-acl to support both formats, mainly for testing and demonstrating purposes. To control desired behavior '--ipv6

[PATCH 0/2] ACL fix 8B field

2022-04-26 Thread Konstantin Ananyev
Fix problem with 8B fields and extend test-acl test coverage. Konstantin Ananyev (2): acl: fix rules with 8 bytes field size are broken app/acl: support different formats for IPv6 address app/test-acl/main.c | 355 ++-- lib/acl/acl_bld.c | 14 +- 2

Re: [PATCH] net/pcap: support MTU set

2022-04-26 Thread Ferruh Yigit
On 3/22/2022 1:02 PM, Ido Goshen wrote: This test https://doc.dpdk.org/dts/test_plans/jumboframes_test_plan.html#test-case-jumbo-frames-with-no-jumbo-frame-support fails for pcap pmd Jumbo packet is unexpectedly received and transmitted Hi Ido, Yes, pcap ignores MTU, but I don't see why it

Re: [PATCH 2/3] mem: fix ASan shadow for remapped memory segments

2022-04-26 Thread Burakov, Anatoly
On 26-Apr-22 3:15 PM, David Marchand wrote: On Tue, Apr 26, 2022 at 2:54 PM Burakov, Anatoly wrote: @@ -1040,9 +1040,25 @@ malloc_heap_free(struct malloc_elem *elem) rte_mcfg_mem_write_unlock(); free_unlock: - /* Poison memory range if belonging to some still mapped pages. *

Re: [PATCH 2/2] ci: add mingw cross compilation in GHA

2022-04-26 Thread Aaron Conole
David Marchand writes: > Add mingw cross compilation in our public CI so that users with their > own github repository have a first level of checks for Windows compilation > before submitting to the mailing list. > This does not replace our better checks in other entities of the CI. > > Only the

Re: [PATCH 1/2] ci: switch to Ubuntu 20.04

2022-04-26 Thread Aaron Conole
David Marchand writes: > Ubuntu 18.04 is now rather old. > Besides, other entities in our CI are also testing this distribution. > > Switch to a newer Ubuntu release and benefit from more recent > tool(chain)s: for example, net/cnxk now builds fine and can be > re-enabled. > > Signed-off-by: Davi

Re: [PATCH] ci: do not dump error logs in GHA containers

2022-04-26 Thread Aaron Conole
David Marchand writes: > On Tue, Apr 26, 2022 at 9:09 AM David Marchand > wrote: >> >> On error, the build logs are displayed in GHA console and logs unless >> the GITHUB_WORKFLOW env variable is set. >> However, containers in GHA do not automatically inherit this variable. >> We could pass this

Re: [RFC] eal: allow worker lcore stacks to be allocated from hugepage memory

2022-04-26 Thread Stephen Hemminger
On Tue, 26 Apr 2022 08:19:59 -0400 Don Wallwork wrote: > Add support for using hugepages for worker lcore stack memory. The > intent is to improve performance by reducing stack memory related TLB > misses and also by using memory local to the NUMA node of each lcore. > > Platforms desiring to m

Re: Reuse Of lcore after returning from its worker thread

2022-04-26 Thread Stephen Hemminger
On Wed, 20 Apr 2022 17:52:20 +0530 Ansar Kannankattil wrote: > Hi, > As per my understanding "*rte_eal_wait_lcore" *is a blocking call in case > of lcore state running. > 1. Is there any direct way to reuse the lcore which we returned from a > worker thread? > 2. Technically is there any issue in

Re: [EXT] Re: [PATCH v3 0/5] Add JSON vector set support to fips validation

2022-04-26 Thread Brandon Lo
Hi Gowrishankar, I apologize for the late response. I have not worked on the AES-CBC implementation, so you are free to go ahead. Please let me know if you run into any issues that I can help with. Thanks, Brandon On Thu, Apr 21, 2022 at 4:02 AM Gowrishankar Muthukrishnan wrote: > > Hi Brandon,

Re: [PATCH] rib: fix traversal with /32 route

2022-04-26 Thread Medvedkin, Vladimir
Fixes: 5a5793a5ffa2 ("rib: add RIB library") On 26/04/2022 15:28, Medvedkin, Vladimir wrote: +Cc:sta...@dpdk.org On 14/04/2022 21:01, Stephen Hemminger wrote: If a /32 route is entered in the RIB the code to traverse will not see that a a end of the tree. This is due to trying to do a negative

Re: [PATCH] rib: fix traversal with /32 route

2022-04-26 Thread Medvedkin, Vladimir
+Cc:sta...@dpdk.org On 14/04/2022 21:01, Stephen Hemminger wrote: If a /32 route is entered in the RIB the code to traverse will not see that a a end of the tree. This is due to trying to do a negative shift which is an undefined in C. Fix by checking for max depth as is already done in rib6.

Re: [PATCH 2/2] rib6: mark error tests with unlikely

2022-04-26 Thread Medvedkin, Vladimir
On 13/04/2022 03:09, Stephen Hemminger wrote: Also mark some conditional functions as const. Signed-off-by: Stephen Hemminger --- lib/rib/rte_rib6.c | 25 - 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/lib/rib/rte_rib6.c b/lib/rib/rte_rib6.c inde

Re: [PATCH 1/2] rib: mark error checks with unlikely

2022-04-26 Thread Medvedkin, Vladimir
On 13/04/2022 03:09, Stephen Hemminger wrote: Also mark some conditional functions as const. Signed-off-by: Stephen Hemminger --- lib/rib/rte_rib.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/lib/rib/rte_rib.c b/lib/rib/rte_rib.c index

Re: [PATCH 2/3] mem: fix ASan shadow for remapped memory segments

2022-04-26 Thread David Marchand
On Tue, Apr 26, 2022 at 2:54 PM Burakov, Anatoly wrote: > >> @@ -1040,9 +1040,25 @@ malloc_heap_free(struct malloc_elem *elem) > >> > >> rte_mcfg_mem_write_unlock(); > >> free_unlock: > >> - /* Poison memory range if belonging to some still mapped > >> pages. */ > >> - if (!

RE: [PATCH] app/test: fix buffer overflow in table unit tests

2022-04-26 Thread Dumitrescu, Cristian
> -Original Message- > From: Medvedkin, Vladimir > Sent: Thursday, April 21, 2022 6:35 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian ; sta...@dpdk.org > Subject: [PATCH] app/test: fix buffer overflow in table unit tests > > This patch fixes stack buffer overflow reported by ASAN. >

DPDK 21.11.1 released

2022-04-26 Thread Kevin Traynor
Hi all, Here is a new stable release: https://fast.dpdk.org/rel/dpdk-21.11.1.tar.xz The git tree is at: https://dpdk.org/browse/dpdk-stable/?h=21.11 This is the first stable release of 21.11 LTS and contains ~400 fixes. See the release notes for details: http://doc.dpdk.

RE: [RFC] ethdev: datapath-focused meter actions

2022-04-26 Thread Dumitrescu, Cristian
I forgot to mention: besides the my statement at the top of my reply, there are many comments inline below :) > -Original Message- > From: Dumitrescu, Cristian > Sent: Tuesday, April 26, 2022 2:44 PM > To: Jerin Jacob ; Alexander Kozyrev > > Cc: dpdk-dev ; Ori Kam ; Thomas > Monjalon ; I

RE: [RFC] ethdev: datapath-focused meter actions

2022-04-26 Thread Dumitrescu, Cristian
Hi Alexander, After reviewing this RFC, I have to say that your proposal is very unclear to me. I don't understand what is the problem you're trying to solve and what exactly is that you cannot do with the current meter and flow APIs. I suggest we get together for a community call with all the

RE: [PATCH v2] net/ice: optimize max queue number calculation

2022-04-26 Thread Wu, Wenjun1
> -Original Message- > From: Zhang, Qi Z > Sent: Friday, April 8, 2022 7:24 PM > To: Yang, Qiming ; Wu, Wenjun1 > > Cc: dev@dpdk.org; Zhang, Qi Z > Subject: [PATCH v2] net/ice: optimize max queue number calculation > > Remove the limitation that max queue pair number must be 2^n. > W

Re: [PATCH 2/3] mem: fix ASan shadow for remapped memory segments

2022-04-26 Thread Burakov, Anatoly
On 21-Apr-22 2:18 PM, Burakov, Anatoly wrote: On 21-Apr-22 10:37 AM, David Marchand wrote: On Wed, Apr 20, 2022 at 4:47 PM Burakov, Anatoly wrote: On 15-Apr-22 6:31 PM, David Marchand wrote: When releasing some memory, the allocator can choose to return some pages to the OS. At the same time

[RFC] eal: allow worker lcore stacks to be allocated from hugepage memory

2022-04-26 Thread Don Wallwork
Add support for using hugepages for worker lcore stack memory. The intent is to improve performance by reducing stack memory related TLB misses and also by using memory local to the NUMA node of each lcore. Platforms desiring to make use of this capability must enable the associated option flag a

[PATCH] net/ivaf: make reset wait time longer

2022-04-26 Thread wenxuanx . wu
From: Wenxuan Wu In 810 CA series, reset time would be longer to wait the kernel return value. this patch enable reset wait time longer to finish kernel reset operation. Signed-off-by: Wenxuan Wu --- drivers/net/iavf/iavf.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dr

RE: [dpdk-dev] [PATCH v4] ethdev: mtr: support protocol based input color selection

2022-04-26 Thread Dumitrescu, Cristian
Hi Jerin, Thank you for implementing according to our agreement, I am happy to see that we are converging. Here are some comments below: > diff --git a/lib/ethdev/rte_mtr.h b/lib/ethdev/rte_mtr.h > index 40df0888c8..76ffbcf724 100644 > --- a/lib/ethdev/rte_mtr.h > +++ b/lib/ethdev/rte_mtr.h >

[PATCH v5 3/4] net/ice: support proto based buf split in Rx path

2022-04-26 Thread wenxuanx . wu
From: Wenxuan Wu This patch adds support for proto based buffer split in normal Rx data paths. When the Rx queue is configured with specific protocol type, packets received will be directly splitted into protocol header and payload parts. And the two parts will be put into different mempools. Cu

[PATCH v5 2/4] app/testpmd: add proto based buffer split config

2022-04-26 Thread wenxuanx . wu
From: Wenxuan Wu This patch adds protocol based buffer split configuration in testpmd. The protocol split feature is off by default. To enable protocol split, you need: 1. Start testpmd with two mempools. e.g. --mbuf-size=2048,2048 2. Configure Rx queue with rx_offload buffer split on. 3. Set the

[PATCH v5 1/4] lib/ethdev: introduce protocol type based buffer split

2022-04-26 Thread wenxuanx . wu
From: Wenxuan Wu Protocol based buffer split consists of splitting a received packet into two separate regions based on its content. The split happens after the packet protocol header and before the packet payload. Splitting is usually between the packet protocol header that can be posted to a de

[PATCH v5 0/3] ethdev: introduce protocol based buffer split

2022-04-26 Thread wenxuanx . wu
From: Wenxuan Wu Protocol based buffer split consists of splitting a received packet into two separate regions based on the packet content. It is useful in some scenarios, such as GPU acceleration. The splitting will help to enable true zero copy and hence improve the performance significantly.

Re: [PATCH] doc: fix support table for ETH and VLAN flow items

2022-04-26 Thread Ferruh Yigit
On 4/26/2022 9:55 AM, Asaf Penso wrote: -Original Message- From: Ferruh Yigit Sent: Wednesday, April 20, 2022 8:52 PM To: Ilya Maximets ; dev@dpdk.org; Asaf Penso Cc: Ajit Khaparde ; Rahul Lakkireddy ; Hemant Agrawal ; Haiyue Wang ; John Daley ; Guoyang Zhou ; Min Hu (Connor) ; Beilei X

Re: [dpdk-dev] [PATCH v4] ethdev: mtr: support protocol based input color selection

2022-04-26 Thread Ray Kinsella
jer...@marvell.com writes: > From: Jerin Jacob > > Currently, meter object supports only DSCP based on input color table, > The patch enhance that to support VLAN based input color table, > color table based on inner field for the tunnel use case, and > support for fallback color per meter if p

Re: [dpdk-dev][PATCH 3/3] net/cnxk: adding cnxk support to configure custom sa index

2022-04-26 Thread Ray Kinsella
kirankum...@marvell.com writes: > From: Kiran Kumar K > > Adding cnxk device driver support to configure custom sa index. > Custom sa index can be configured as part of the session create > as SPI, and later original SPI can be updated using session update. > > Signed-off-by: Kiran Kumar K > -

Re: [PATCH v2 04/28] common/cnxk: support to configure the ts pkind in CPT

2022-04-26 Thread Ray Kinsella
Nithin Dabilpuram writes: > From: Vidya Sagar Velumuri > > Add new API to configure the SA table entries with new CPT PKIND > when timestamp is enabled. > > Signed-off-by: Vidya Sagar Velumuri > --- > drivers/common/cnxk/roc_nix_inl.c | 59 > ++ > driver

Re: [DPDK v4] net/ixgbe: promote MDIO API

2022-04-26 Thread Ray Kinsella
Zeng, ZhichaoX writes: > Hi, Ray, David: > > What is your opinion on this patch? > > Regards, > Zhichao > > -Original Message- > From: Zeng, ZhichaoX > Sent: Tuesday, April 19, 2022 7:06 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; Wang, Haiyue > ; m...@ashroe.eu; Zeng, ZhichaoX > >

RE: [PATCH v6 06/16] vdpa/ifc: add block device SW live-migration

2022-04-26 Thread Pei, Andy
Hi Chenbo, Thanks for your reply. My reply is inline. > -Original Message- > From: Xia, Chenbo > Sent: Monday, April 25, 2022 9:10 PM > To: Pei, Andy ; dev@dpdk.org > Cc: maxime.coque...@redhat.com; Cao, Gang ; Liu, > Changpeng > Subject: RE: [PATCH v6 06/16] vdpa/ifc: add block device

RE: [PATCH v6 05/16] vdpa/ifc: add vDPA interrupt for blk device

2022-04-26 Thread Pei, Andy
Hi Chenbo, Thanks for your reply. My reply is inline. > -Original Message- > From: Xia, Chenbo > Sent: Monday, April 25, 2022 8:58 PM > To: Pei, Andy ; dev@dpdk.org > Cc: maxime.coque...@redhat.com; Cao, Gang ; Liu, > Changpeng > Subject: RE: [PATCH v6 05/16] vdpa/ifc: add vDPA interrup

RE: [PATCH] net/mlx5: fix rxq/txq stats memory access sync

2022-04-26 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Raja Zidane > Sent: Wednesday, April 20, 2022 6:32 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Slava Ovsiienko > ; sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix rxq/txq stats memory access sync > > Queue statistics are being continuously updated in Rx/Tx

RE: [PATCH v6 03/16] vhost: add vhost msg support

2022-04-26 Thread Xia, Chenbo
> -Original Message- > From: Pei, Andy > Sent: Tuesday, April 26, 2022 4:56 PM > To: Xia, Chenbo ; dev@dpdk.org > Cc: maxime.coque...@redhat.com; Cao, Gang ; Liu, > Changpeng > Subject: RE: [PATCH v6 03/16] vhost: add vhost msg support > > HI Chenbo, > > Thanks for your reply. > My repl

RE: [PATCH 1/2] ci: switch to Ubuntu 20.04

2022-04-26 Thread Ruifeng Wang
> -Original Message- > From: David Marchand > Sent: Tuesday, April 26, 2022 3:18 PM > To: dev@dpdk.org > Cc: Aaron Conole ; Michael Santana > ; Ruifeng Wang ; > Jan Viktorin ; Bruce Richardson > ; David Christensen > Subject: [PATCH 1/2] ci: switch to Ubuntu 20.04 > > Ubuntu 18.04 is now

RE: [PATCH] doc: fix support table for ETH and VLAN flow items

2022-04-26 Thread Asaf Penso
>-Original Message- >From: Ferruh Yigit >Sent: Wednesday, April 20, 2022 8:52 PM >To: Ilya Maximets ; dev@dpdk.org; Asaf Penso > >Cc: Ajit Khaparde ; Rahul Lakkireddy >; Hemant Agrawal >; Haiyue Wang ; John >Daley ; Guoyang Zhou ; >Min Hu (Connor) ; Beilei Xing >; Jingjing Wu ; Qi Zhang >;

RE: [PATCH v6 03/16] vhost: add vhost msg support

2022-04-26 Thread Pei, Andy
HI Chenbo, Thanks for your reply. My reply is inline. > -Original Message- > From: Xia, Chenbo > Sent: Monday, April 25, 2022 8:42 PM > To: Pei, Andy ; dev@dpdk.org > Cc: maxime.coque...@redhat.com; Cao, Gang ; Liu, > Changpeng > Subject: RE: [PATCH v6 03/16] vhost: add vhost msg suppo

librte_bpf: roadmap or any specific plans for this library

2022-04-26 Thread Björn Svensson A
Hi all, I hope this is the correct maillist for this topic. DPDK provides the nice library `librte_bpf` to load and execute eBPF bytecode and we would like to broaden our usage of this library. Today there are hints that this library might have been purpose built to enable inspection or modifica

Re: [dpdk-dev] [PATCH v3 6/7] app/proc-info: provide way to request info on owned ports

2022-04-26 Thread Subendu Santra
Hi Stephen, We were going through the patch set: https://inbox.dpdk.org/dev/20200715212228.28010-7-step...@networkplumber.org/ and hoping to get clarification on the behaviour if post mask is not specified in the input to `dpdk-proc-info` tool. Specifically, In PATCH v3 6/7, we see this: +

[PATCH v5 14/14] bus/vmbus: update MAINTAINERS and docs

2022-04-26 Thread Srikanth Kaka
updated MAINTAINERS and doc files for FreeBSD support Signed-off-by: Srikanth Kaka Signed-off-by: Vag Singh Signed-off-by: Anand Thulasiram --- MAINTAINERS| 2 ++ doc/guides/nics/netvsc.rst | 11 +++ 2 files changed, 13 insertions(+) diff --git a/MAINTAINERS b/MAINTAI

[PATCH v5 13/14] bus/vmbus: add meson support for FreeBSD

2022-04-26 Thread Srikanth Kaka
add meson support for FreeBSD OS Signed-off-by: Srikanth Kaka Signed-off-by: Vag Singh Signed-off-by: Anand Thulasiram --- drivers/bus/vmbus/meson.build | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/bus/vmbus/meson.build b/drivers/bus/vmbus/meson.build index

[PATCH v5 12/14] net/netvsc: moving hotplug retry to OS dir

2022-04-26 Thread Srikanth Kaka
Moved netvsc_hotplug_retry to respective OS dir as it contains OS dependent code. For Linux, it is copied as is and for FreeBSD it is not supported yet. Signed-off-by: Srikanth Kaka Signed-off-by: Vag Singh Signed-off-by: Anand Thulasiram --- drivers/net/netvsc/freebsd/hn_os.c | 5 +++ driver

[PATCH v5 11/14] bus/vmbus: get subchannel info

2022-04-26 Thread Srikanth Kaka
Using sysctl, all the subchannel's attributes are fetched Signed-off-by: Srikanth Kaka Signed-off-by: Vag Singh Signed-off-by: Anand Thulasiram --- drivers/bus/vmbus/freebsd/vmbus_uio.c | 73 +++ 1 file changed, 73 insertions(+) diff --git a/drivers/bus/vmbus/f

[PATCH v5 10/14] net/netvsc: make IOCTL call to open subchannels

2022-04-26 Thread Srikanth Kaka
make IOCTL call to open subchannels Signed-off-by: Srikanth Kaka Signed-off-by: Vag Singh Signed-off-by: Anand Thulasiram --- drivers/net/netvsc/hn_ethdev.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c index 8b1e07b..10

[PATCH v5 09/14] bus/vmbus: open subchannels

2022-04-26 Thread Srikanth Kaka
In FreeBSD, unlike Linux there is no sub-channel open callback that could be called by HV_UIO driver upon their grant by the hypervisor. Thus the PMD makes an IOCTL to the HV_UIO to open the sub-channels On Linux, the vmbus_uio_subchan_open() will always return success as the Linux HV_UIO opens th

[PATCH v5 08/14] bus/vmbus: add sub-channel mapping support

2022-04-26 Thread Srikanth Kaka
To map the subchannels, an mmap request is directly made after determining the subchan memory offset Signed-off-by: Srikanth Kaka Signed-off-by: Vag Singh Signed-off-by: Anand Thulasiram --- drivers/bus/vmbus/freebsd/vmbus_uio.c | 48 +++ 1 file changed, 48 inse

[PATCH v5 07/14] net/netvsc: make event monitor OS dependent

2022-04-26 Thread Srikanth Kaka
- Event monitoring is not yet supported on FreeBSD, hence moving it to the OS specific files - Add meson support to OS environment Signed-off-by: Srikanth Kaka Signed-off-by: Vag Singh Signed-off-by: Anand Thulasiram --- drivers/net/netvsc/freebsd/hn_os.c | 16 drivers/net

[PATCH v5 06/14] bus/vmbus: get device resource values using sysctl

2022-04-26 Thread Srikanth Kaka
The UIO device's attribute (relid, monitor id, etc) values are retrieved using following sysctl variables: $ sysctl dev.hv_uio.0 dev.hv_uio.0.send_buf.gpadl: 925241 dev.hv_uio.0.send_buf.size: 16777216 dev.hv_uio.0.recv_buf.gpadl: 925240 dev.hv_uio.0.recv_buf.size: 32505856 dev.hv_uio.0.monitor_pag

[PATCH v5 05/14] bus/vmbus: handle mapping of device resources

2022-04-26 Thread Srikanth Kaka
All resource values are published by HV_UIO driver as sysctl key value pairs and they are read at a later point of the code flow Signed-off-by: Srikanth Kaka Signed-off-by: Vag Singh Signed-off-by: Anand Thulasiram --- drivers/bus/vmbus/freebsd/vmbus_bus.c | 18 ++ 1 file chang

[PATCH v5 04/14] bus/vmbus: scan and get the network device on FreeBSD

2022-04-26 Thread Srikanth Kaka
Using sysctl, all the devices on the VMBUS are identified by the PMD. On finding the Network device's device id, it is added to VMBUS dev list. Signed-off-by: Srikanth Kaka Signed-off-by: Vag Singh Signed-off-by: Anand Thulasiram --- drivers/bus/vmbus/freebsd/vmbus_bus.c | 268

[PATCH v5 03/14] bus/vmbus: move OS independent UIO functions

2022-04-26 Thread Srikanth Kaka
Moved all Linux independent UIO functions to unix dir. Split the vmbus_uio_map_subchan() by keeping OS dependent code in vmbus_uio_map_subchan_os() function Signed-off-by: Srikanth Kaka Signed-off-by: Vag Singh Signed-off-by: Anand Thulasiram --- drivers/bus/vmbus/linux/vmbus_uio.c | 292 +

[PATCH v5 02/14] bus/vmbus: move independent bus functions

2022-04-26 Thread Srikanth Kaka
move independent Linux bus functions to OS independent file Signed-off-by: Srikanth Kaka Signed-off-by: Vag Singh Signed-off-by: Anand Thulasiram --- drivers/bus/vmbus/linux/vmbus_bus.c | 15 --- drivers/bus/vmbus/unix/vmbus_unix_bus.c | 17 + 2 files changed, 1

[PATCH v5 01/14] bus/vmbus: move independent code from Linux

2022-04-26 Thread Srikanth Kaka
Move the OS independent code from Linux dir in-order to be used by FreeBSD Signed-off-by: Srikanth Kaka Signed-off-by: Vag Singh Signed-off-by: Anand Thulasiram --- drivers/bus/vmbus/linux/vmbus_bus.c | 13 + drivers/bus/vmbus/meson.build | 5 + drivers/bus/vmbus

[PATCH v5 00/14] add FreeBSD support to VMBUS & NetVSC PMDs

2022-04-26 Thread Srikanth Kaka
This patchset requires FreeBSD VMBus kernel changes and HV_UIO driver. Both are currently under review at https://reviews.freebsd.org/D32184 Changelog: v5: - renamed dir osi to unix - marked a newly added API as experimental - removed camel case variables v4: - moved OS independent code ou

Re: [PATCH] net/nfp: remove unneeded header inclusion

2022-04-26 Thread Niklas Soderlund
Hi David, Thanks for your work. On 2022-04-08 11:41:16 +0200, David Marchand wrote: > Looking at this driver history, there was never a need for including > execinfo.h. > > Signed-off-by: David Marchand Reviewed-by: Niklas Söderlund > --- > drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c | 3 ---

Reuse Of lcore after returning from its worker thread

2022-04-26 Thread Ansar Kannankattil
Hi, As per my understanding "*rte_eal_wait_lcore" *is a blocking call in case of lcore state running. 1. Is there any direct way to reuse the lcore which we returned from a worker thread? 2. Technically is there any issue in reusing the lcore by some means?

Re: [PATCH v4 01/14] bus/vmbus: move independent code from Linux

2022-04-26 Thread Srikanth K
Sure Stephen. I will change it to unix. On Tue, 19 Apr 2022, 8:19 pm Stephen Hemminger, wrote: > On Mon, 18 Apr 2022 09:59:02 +0530 > Srikanth Kaka wrote: > > > Move the OS independent code from Linux dir in-order to be used > > by FreeBSD > > > > Signed-off-by: Srikanth Kaka > > Signed-off-by

RE: [PATCH v6 03/16] vhost: add vhost msg support

2022-04-26 Thread Pei, Andy
HI David, Thanks for your reply. I will send out a version to address that. > -Original Message- > From: David Marchand > Sent: Monday, April 25, 2022 9:05 PM > To: Pei, Andy > Cc: dev ; Xia, Chenbo ; Maxime > Coquelin ; Cao, Gang > ; Liu, Changpeng > Subject: Re: [PATCH v6 03/16] vhos

[PATCH v4 3/3] test/threads: add unit test for thread API

2022-04-26 Thread Tyler Retzlaff
Establish unit test for testing thread api. Initial unit tests for rte_thread_{get,set}_affinity_by_id(). Signed-off-by: Narcisa Vasile Signed-off-by: Tyler Retzlaff --- app/test/meson.build| 2 ++ app/test/test_threads.c | 89 + 2 files chan

[PATCH v4 2/3] eal: implement functions for get/set thread affinity

2022-04-26 Thread Tyler Retzlaff
Implement functions for getting/setting thread affinity. Threads can be pinned to specific cores by setting their affinity attribute. Windows error codes are translated to errno-style error codes. The possible return values are chosen so that we have as much semantic compatibility between platform

[PATCH v4 1/3] eal: add basic thread ID and current thread identifier API

2022-04-26 Thread Tyler Retzlaff
Provide a portable type-safe thread identifier. Provide rte_thread_self for obtaining current thread identifier. Signed-off-by: Narcisa Vasile Signed-off-by: Tyler Retzlaff --- lib/eal/include/rte_thread.h | 22 ++ lib/eal/unix/rte_thread.c| 11 +++ lib/eal/versi

[PATCH v4 0/3] add eal functions for thread affinity and self

2022-04-26 Thread Tyler Retzlaff
this series provides basic dependencies for additional eal thread api additions. series includes * basic platform error number conversion. * function to get current thread identifier. * functions to get and set affinity with platform agnostic thread identifier. * minimal unit test of get and set

Re: [PATCH v2] test/bpf: skip test if libpcap is unavailable

2022-04-26 Thread Tyler Retzlaff
On Tue, Apr 26, 2022 at 09:41:08AM +0200, David Marchand wrote: > On Tue, Mar 22, 2022 at 8:12 AM Tyler Retzlaff > wrote: > > > > test_bpf_convert is being conditionally registered depending on the > > presence of RTE_HAS_LIBPCAP except the UT unconditionally lists it as a > > test to run. > > > >

Re: [PATCH v2] test/bpf: skip test if libpcap is unavailable

2022-04-26 Thread David Marchand
On Tue, Mar 22, 2022 at 8:12 AM Tyler Retzlaff wrote: > > test_bpf_convert is being conditionally registered depending on the > presence of RTE_HAS_LIBPCAP except the UT unconditionally lists it as a > test to run. > > when the UT runs test_bpf_convert test-dpdk can't find the registration > and a

[PATCH 1/2] ci: switch to Ubuntu 20.04

2022-04-26 Thread David Marchand
Ubuntu 18.04 is now rather old. Besides, other entities in our CI are also testing this distribution. Switch to a newer Ubuntu release and benefit from more recent tool(chain)s: for example, net/cnxk now builds fine and can be re-enabled. Signed-off-by: David Marchand --- .ci/linux-build.sh

  1   2   >