RE: [PATCH v4 1/1] vhost: integrate dmadev in asynchronous data-path

> -Original Message- > From: Jiayu Hu > Sent: Wednesday, February 9, 2022 8:52 PM > To: dev@dpdk.org > Cc: maxime.coque...@redhat.com; i.maxim...@ovn.org; Xia, Chenbo > ; Ding, Xuan ; Jiang, Cheng1 > ; lian...@liangbit.com; Hu, Jiayu > ; Pai G, Sunil > Subject: [PATCH v4 1/1] vhost: in

Re: [PATCH] eal: remove unnecessary argv[0] handling

09/02/2022 20:29, Stephen Hemminger: > On Wed, 09 Feb 2022 19:51:15 +0100 > Thomas Monjalon wrote: > > > 09/02/2022 16:45, Stephen Hemminger: > > > On Wed, 09 Feb 2022 15:58:26 +0100 > > > Thomas Monjalon wrote: > > > > > > > 02/02/2022 20:47, Stephen Hemminger: > > > > > The rte_eal_init f

RE: [PATCH] ethdev: introduce generic dummy packet burst function

> Subject: [PATCH] ethdev: introduce generic dummy packet burst function > > Multiple PMDs have dummy/noop Rx/Tx packet burst functions. > > These dummy functions are very simple, introduce a common function in > the ethdev and update drivers to use it instead of each driver having > its own func

RE: [PATCH] raw/ntb: add check for DB intr handler registering

> -Original Message- > From: Wu, Jingjing > Sent: Thursday, February 10, 2022 15:05 > To: Guo, Junfeng > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: RE: [PATCH] raw/ntb: add check for DB intr handler registering > > > > > -Original Message- > > From: Guo, Junfeng > > Sent:

[PATCH] net/failsafe: Fix crash due to global devargs syntax parsing from secondary process

From: Madhuker Mythri Failsafe pmd started crashing with global devargs syntax as devargs is not memset to zero. Access it to in rte_devargs_parse resulted in a crash when called from secondary process. Bugzilla Id: 933 Signed-off-by: Madhuker Mythri --- drivers/net/failsafe/failsafe.c | 1 +

RE: [PATCH v4] raw/ntb: clear all valid DB bits when DB init

> -Original Message- > From: Guo, Junfeng > Sent: Thursday, February 10, 2022 3:07 PM > To: Wu, Jingjing > Cc: dev@dpdk.org; sta...@dpdk.org; Guo, Junfeng > Subject: [PATCH v4] raw/ntb: clear all valid DB bits when DB init > > Before registering the doorbell interrupt handler callbac

RE: [PATCH v3] raw/ntb: clear all valid DB bits when DB init

> -Original Message- > From: Wu, Jingjing > Sent: Thursday, February 10, 2022 14:51 > To: Guo, Junfeng > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: RE: [PATCH v3] raw/ntb: clear all valid DB bits when DB init > > > > > -Original Message- > > From: Guo, Junfeng > > Sent: W

[PATCH v4] raw/ntb: clear all valid DB bits when DB init

Before registering the doorbell interrupt handler callback function, all the valid doorbell bits within the NTB private data struct should be cleared to avoid the confusion of the handshake timing sequence diagram when setting up the NTB connection in back-to-back mode. Fixes: 62012a76811e ("raw/n

RE: [PATCH] raw/ntb: add check for DB intr handler registering

> -Original Message- > From: Guo, Junfeng > Sent: Thursday, February 10, 2022 2:29 PM > To: Wu, Jingjing > Cc: dev@dpdk.org; sta...@dpdk.org; Guo, Junfeng > Subject: [PATCH] raw/ntb: add check for DB intr handler registering > > The callback registering of doorbell interrupt handler

RE: [EXT] [PATCH v3 0/7] NXP crypto drivers changes

> v3-change-log > * fix checkpatch issues > * use devargs for strict ordering > * fix AES_CMAC capabilities > * remove GMAC patch from this series. I will send > it as separate patch. > > v2-change-log > * using dev args for both DPAA1 and DPAA2 drivers to > dump debug prints on sec error. > > F

[PATCH 2/2] net/cnxk: add telemetry for inline IPsec for cn10k

Adds telemetry function to get information about inline outbound and inline inbound sa's. The function takes port id as input. Some fields in the structures roc_ot_ipsec_outb_sa and roc_ot_ipsec_inb_sa are returned as output. Signed-off-by: Ankur Dwivedi Reviewed-by: Jerin Jacob Kollanukkaran --

[PATCH 1/2] net/cnxk: add telemetry for inline IPsec for cn9k

Adds telemetry function to get information about inline outbound and inline inbound sa's. The function takes port id as input. Some fields in the structures roc_onf_ipsec_outb_sa and roc_onf_ipsec_inb_sa are returned as output. Signed-off-by: Ankur Dwivedi Reviewed-by: Jerin Jacob Kollanukkaran

[PATCH 0/2] add telemetry for inline IPsec

Adds telemetry function for inline ipsec in net CNXK driver. This series depends on the following patch series: Series: Adding new features and improvements in cnxk crypto PMD http://patches.dpdk.org/project/dpdk/list/?series=21433 Ankur Dwivedi (2): net/cnxk: add telemetry for inline IPsec fo

RE: [PATCH v3] raw/ntb: clear all valid DB bits when DB init

> -Original Message- > From: Guo, Junfeng > Sent: Wednesday, February 9, 2022 12:47 PM > To: Wu, Jingjing > Cc: dev@dpdk.org; sta...@dpdk.org; Guo, Junfeng > Subject: [PATCH v3] raw/ntb: clear all valid DB bits when DB init > > Before registering the doorbell interrupt handler callba

Re: [PATCH] net/iavf: initialize large VF setting at startup

I agree with you. Will submit a new revision. Thanks On Thu, Feb 10, 2022 at 3:43 AM Xu, Ting wrote: > > > -Original Message- > > From: Ghalem Boudour > > Sent: Thursday, February 10, 2022 3:27 AM > > To: Xu, Ting > > Cc: Wu, Jingjing ; Xing, Beilei > > ; > > dev@dpdk.org; Thibaut Col

[PATCH] raw/ntb: add check for DB intr handler registering

The callback registering of doorbell interrupt handler should be finished before enabling the interrupt event fd. Thus add the return value check for this callback registering. Fixes: 62012a76811e ("raw/ntb: add handshake process") Cc: sta...@dpdk.org Signed-off-by: Junfeng Guo --- drivers/raw/

RE: [PATCH] net/mlx5: fix risk in Rx descriptor read in NEON vector path

Ping. Please could you help to review this patch? Thanks. Ruifeng > -Original Message- > From: Ruifeng Wang > Sent: Tuesday, January 4, 2022 11:01 AM > To: ma...@nvidia.com; viachesl...@nvidia.com > Cc: dev@dpdk.org; Honnappa Nagarahalli > ; sta...@dpdk.org; nd ; > Ruifeng Wang > Subjec

RE: Questions on i40e TX path

Thank you for your input. Please see few comments inline. > > Subject: Questions on i40e TX path > > > > Hi Beilei, > > I want to make sure my understanding of the TX path is correct. > > Following is my understanding. > > > > 1) The RS bit must be set in the TX descriptors to ask the NIC to

[PATCH v3 7/7] crypto/dpaa_sec: add debug framework

Adding useful debug prints in DPAA driver for easy debugging. Signed-off-by: Gagandeep Singh --- doc/guides/cryptodevs/dpaa_sec.rst | 10 ++ drivers/bus/dpaa/dpaa_bus.c| 16 ++- drivers/crypto/dpaa_sec/dpaa_sec.c | 192 - 3 files changed, 213 insertions(+),

[PATCH v3 6/7] crypto/dpaa2_sec: ordered queue support

From: Nipun Gupta This patch supports ordered queue for DPAA2 platform. Signed-off-by: Nipun Gupta Signed-off-by: Gagandeep Singh --- doc/guides/cryptodevs/dpaa2_sec.rst | 7 + drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 285 ++-- drivers/crypto/dpaa2_sec/dpaa2_sec

[PATCH v3 5/7] crypto/dpaa2: fix to check next type for auth or cipher

From: Hemant Agrawal This patch add more checks on next type for PDCP cases. Fixes: 45e019608f31 ("crypto/dpaa2_sec: support integrity only PDCP") Fixes: a1173d55598c ("crypto/dpaa_sec: support PDCP offload") Cc: sta...@dpdk.org Signed-off-by: Hemant Agrawal --- drivers/crypto/dpaa2_sec/dpaa2

[PATCH v3 4/7] crypto/dpaa2_sec: add useful debug prints in sec dequeue

Few useful debug prints added in dequeue function. Signed-off-by: Gagandeep Singh --- doc/guides/cryptodevs/dpaa2_sec.rst | 10 ++ drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 136 +++- 2 files changed, 144 insertions(+), 2 deletions(-) diff --git a/doc/guides/cryptode

[PATCH v3 3/7] crypto/dpaa2_sec: change capabilities for AES_CMAC

From: Hemant Agrawal Add IV size and change the digest size to supported value by the HW engine. Signed-off-by: Hemant Agrawal Signed-off-by: Gagandeep Singh --- drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/d

[PATCH v3 2/7] common/dpaax: change job processing mode for PDCP SDAP

For PDCP SDAP test cases, HW sec engine process the jobs in WAIT mode. Signed-off-by: Gagandeep Singh --- drivers/common/dpaax/caamflib/desc/sdap.h | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/common/dpaax/caamflib/desc/sdap.h b/drivers/comm

[PATCH v3 1/7] common/dpaax: caamflib: Remove code related to SEC ERA 1 to 7

From: Franck LENORMAND DPAA1 and DPAA2 platforms use SEC ERA 8 and 10 only. This patch removes code in SDAP and PDCP header related to these ERA to simplify the codebase: - Simplify logic using RTA_SEC_ERA_<> macro - Remove era_2_sw_hfn_ovrd dedicated to RTA_SEC_ERA_2 Signed-off-by: Franck LE

[PATCH v3 0/7] NXP crypto drivers changes

v3-change-log * fix checkpatch issues * use devargs for strict ordering * fix AES_CMAC capabilities * remove GMAC patch from this series. I will send it as separate patch. v2-change-log * using dev args for both DPAA1 and DPAA2 drivers to dump debug prints on sec error. Franck LENORMAND (1): c

RE: [PATCH] net/ice: fix gcc error with -DRTE_LIBRTE_ICE_16BYTE_RX_DESC

> -Original Message- > From: Zhou, YidingX > Sent: Tuesday, February 8, 2022 1:35 PM > To: Richardson, Bruce ; Wang, Haiyue > > Cc: Yang, Qiming ; Zhang, Qi Z > ; dev@dpdk.org > Subject: RE: [PATCH] net/ice: fix gcc error with - > DRTE_LIBRTE_ICE_16BYTE_RX_DESC > > > > > -Original

RE: [PATCH v3 32/36] raw/*: remove unnecessary NULL checks

Hi, > -Original Message- > From: Stephen Hemminger > Sent: Thursday, February 10, 2022 3:18 > To: dev@dpdk.org > Cc: Stephen Hemminger ; Hemant Agrawal > ; Jakub Palider ; > Tomasz Duszynski ; Nipun Gupta > ; Xu, Rosen ; Zhang, Tianfei > > Subject: [PATCH v3 32/36] raw/*: remove unnecess

RE: [PATCH v3 09/36] bus/*: remove unnecessary NULL checks

Hi, > -Original Message- > From: Stephen Hemminger > Sent: Thursday, February 10, 2022 3:17 > To: dev@dpdk.org > Cc: Stephen Hemminger ; Hemant Agrawal > ; Sachin Saxena ; > Xu, Rosen > Subject: [PATCH v3 09/36] bus/*: remove unnecessary NULL checks > > Remove redundant NULL pointer che

RE: [PATCH] net/iavf: initialize large VF setting at startup

> -Original Message- > From: Ghalem Boudour > Sent: Thursday, February 10, 2022 3:27 AM > To: Xu, Ting > Cc: Wu, Jingjing ; Xing, Beilei > ; > dev@dpdk.org; Thibaut Collet ; Olivier Matz > > Subject: Re: [PATCH] net/iavf: initialize large VF setting at startup > > Hi Ting, > > The pur

RE: [PATCH v2] net/ice: fix gcc error with -DRTE_LIBRTE_ICE_16BYTE_RX_DESC

> -Original Message- > From: Yiding Zhou > Sent: Tuesday, February 8, 2022 11:42 PM > To: Yang, Qiming ; Zhang, Qi Z > > Cc: Zhou, YidingX ; dev@dpdk.org > Subject: [PATCH v2] net/ice: fix gcc error with - Tested-by: Wei Ling

RE: [PATCH v5 0/6] support L2TPv2 for AVF RSS hash and FDIR

> -Original Message- > From: Yigit, Ferruh > Sent: Thursday, February 10, 2022 4:45 AM > To: Wang, Jie1X ; dev@dpdk.org > Cc: Yang, SteveX ; or...@nvidia.com; Singh, Aman > Deep ; tho...@monjalon.net; > andrew.rybche...@oktetlabs.ru; Wu, Jingjing ; Xing, > Beilei ; Zhang, Qi Z ; > olivie

Re: Can I use rte_pktmbuf_chain to chain multiple mbuffs for calling only single tx_eth_burst API

On Wed, 9 Feb 2022 22:18:24 + Ferruh Yigit wrote: > On 2/9/2022 6:03 PM, Ansar Kannankattil wrote: > > Hi > > My intention is to decrease the number of rte_tx_eth_burst calls, I know > > that mentioning nb_pkts will result in sending multiple packets in a single > > call. > > But providing

Re: Can I use rte_pktmbuf_chain to chain multiple mbuffs for calling only single tx_eth_burst API

On 2/9/2022 6:03 PM, Ansar Kannankattil wrote: Hi My intention is to decrease the number of rte_tx_eth_burst calls, I know that mentioning nb_pkts will result in sending multiple packets in a single call. But providing nb_pkts=1 and posting a head mbuff having number of mbuffs linked with it wi

RE: [PATCH v4 07/10] app/testpmd: implement rte flow queue flow operations

Hi Alexander, > -Original Message- > From: Alexander Kozyrev > Sent: Wednesday, February 9, 2022 11:38 PM > Subject: [PATCH v4 07/10] app/testpmd: implement rte flow queue flow > operations > > Add testpmd support for the rte_flow_q_create/rte_flow_q_destroy API. > Provide the command

[PATCH v4 10/10] app/testpmd: implement rte flow queue indirect actions

Add testpmd support for the rte_flow_q_action_handle API. Provide the command line interface for operations dequeue. Usage example: flow queue 0 indirect_action 0 create action_id 9 ingress postpone yes action rss / end flow queue 0 indirect_action 0 update action_id 9 action queue inde

[PATCH v4 09/10] app/testpmd: implement rte flow pull operations

Add testpmd support for the rte_flow_q_pull API. Provide the command line interface for pulling operations results. Usage example: flow pull 0 queue 0 Signed-off-by: Alexander Kozyrev Acked-by: Ori Kam --- app/test-pmd/cmdline_flow.c | 56 +++- app/test-pmd/config.c

[PATCH v4 08/10] app/testpmd: implement rte flow push operations

Add testpmd support for the rte_flow_q_push API. Provide the command line interface for pushing operations. Usage example: flow queue 0 push 0 Signed-off-by: Alexander Kozyrev Acked-by: Ori Kam --- app/test-pmd/cmdline_flow.c | 56 - app/test-pmd/config.c

[PATCH v4 06/10] app/testpmd: implement rte flow table management

Add testpmd support for the rte_flow_table API. Provide the command line interface for the flow table creation/destruction. Usage example: testpmd> flow template_table 0 create table_id 6 group 9 priority 4 ingress mode 1 rules_number 64 pattern_template 2 actions_template 4 testpmd> fl

[PATCH v4 07/10] app/testpmd: implement rte flow queue flow operations

Add testpmd support for the rte_flow_q_create/rte_flow_q_destroy API. Provide the command line interface for enqueueing flow creation/destruction operations. Usage example: testpmd> flow queue 0 create 0 postpone no template_table 6 pattern_template 0 actions_template 0 patt

[PATCH v4 05/10] app/testpmd: implement rte flow template management

Add testpmd support for the rte_flow_pattern_template and rte_flow_actions_template APIs. Provide the command line interface for the template creation/destruction. Usage example: testpmd> flow pattern_template 0 create pattern_template_id 2 template eth dst is 00:16:3e:31:15:c3 / end

[PATCH v4 04/10] app/testpmd: implement rte flow configuration

Add testpmd support for the rte_flow_configure API. Provide the command line interface for the Flow management. Usage example: flow configure 0 queues_number 8 queues_size 256 Implement rte_flow_info_get API to get available resources: Usage example: flow info 0 Signed-off-by: Alexander Kozyrev

[PATCH v4 03/10] ethdev: bring in async queue-based flow rules operations

A new, faster, queue-based flow rules management mechanism is needed for applications offloading rules inside the datapath. This asynchronous and lockless mechanism frees the CPU for further packet processing and reduces the performance impact of the flow rules creation/destruction on the datapath.

[PATCH v4 02/10] ethdev: add flow item/action templates

Treating every single flow rule as a completely independent and separate entity negatively impacts the flow rules insertion rate. Oftentimes in an application, many flow rules share a common structure (the same item mask and/or action list) so they can be grouped and classified together. This knowl

[PATCH v4 01/10] ethdev: introduce flow pre-configuration hints

The flow rules creation/destruction at a large scale incurs a performance penalty and may negatively impact the packet processing when used as part of the datapath logic. This is mainly because software/hardware resources are allocated and prepared during the flow rule creation. In order to optimi

[PATCH v4 00/10] ethdev: datapath-focused flow rules management

Three major changes to a generic RTE Flow API were implemented in order to speed up flow rule insertion/destruction and adapt the API to the needs of a datapath-focused flow rules management applications: 1. Pre-configuration hints. Application may give us some hints on what type of resources are

Re: Can I use rte_pktmbuf_chain to chain multiple mbuffs for calling only single tx_eth_burst API

On Wed, 9 Feb 2022 23:33:13 +0530 Ansar Kannankattil wrote: > Hi > My intention is to decrease the number of rte_tx_eth_burst calls, I know > that mentioning nb_pkts will result in sending multiple packets in a single > call. > But providing nb_pkts=1 and posting a head mbuff having number of > m

Can I use rte_pktmbuf_chain to chain multiple mbuffs for calling only single tx_eth_burst API

Hi My intention is to decrease the number of rte_tx_eth_burst calls, I know that mentioning nb_pkts will result in sending multiple packets in a single call. But providing nb_pkts=1 and posting a head mbuff having number of mbuffs linked with it will results sending multiple packets If not, what is

Re: [PATCH v5 0/6] support L2TPv2 for AVF RSS hash and FDIR

On 2/9/2022 9:38 AM, Jie Wang wrote: Support IAVF L2TPv2(include PPP over L2tpv2) RSS hash and flow director. Required to distribute packets based on outer MAC src address and L2TPv2 session ID. Support IAVF PPPoL2TPv2oUDP flow director. Required to distribute packets based on inner IP src+dest

Re: [PATCH v5 1/6] ethdev: add L2TPv2 RSS offload type

On 2/9/2022 9:38 AM, Jie Wang wrote: This patch defines new RSS offload type for L2TPv2, which is required when users want to distribute packets based on the L2TPv2 session ID field. Signed-off-by: Jie Wang Reviewed-by: Ferruh Yigit

[PATCH v3] eal: simplify argv[0] handling

The rte_eal_init function looks at argv[0] to determine the program name to pass to the log init function. But in corner cases argv[0] maybe NULL leading to a SEGV. The code here is just using argv[0] to generate logid which does not have to be in a static string, openlog() will handle a const cha

RE: [EXT] [PATCH v4 5/5] crypto: modify return value for asym session create

> Rather than the asym session create function returning a session on > success, and a NULL value on error, it is modified to now return int > values - 0 on success or -EINVAL/-ENOTSUP/-ENOMEM on failure. > The session to be used is passed as input. > > This adds clarity on the failure of the crea

RE: [EXT] [PATCH v4 4/5] crypto: add asym session user data API

> diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asym.c > index fff5c0d59a..f9691fe281 100644 > --- a/app/test/test_cryptodev_asym.c > +++ b/app/test/test_cryptodev_asym.c > @@ -894,7 +894,7 @@ testsuite_setup(void) > } > > ts_params->session_mpool = > rte_crypto

RE: [EXT] [PATCH v4 2/5] crypto: use single buffer for asymmetric session

Hi Ciara, Few minor comments. > - /* setup asym session pool */ > - unsigned int session_size = RTE_MAX( > - rte_cryptodev_asym_get_private_session_size(dev_id), > - rte_cryptodev_asym_get_header_session_size()); > - /* > - * Create mempool with TEST_NUM_SE

Re: [PATCH] eal: remove unnecessary argv[0] handling

On Wed, 09 Feb 2022 19:51:15 +0100 Thomas Monjalon wrote: > 09/02/2022 16:45, Stephen Hemminger: > > On Wed, 09 Feb 2022 15:58:26 +0100 > > Thomas Monjalon wrote: > > > > > 02/02/2022 20:47, Stephen Hemminger: > > > > The rte_eal_init function looks at argv[0] to determine > > > > the progr

Re: [PATCH] net/iavf: initialize large VF setting at startup

Hi Ting, The purpose of the correction is to ensure that the rss configuration is aligned with the number of queues allocated on the current boot and not impacted by a previous configuration done in a previous boot. The rss configuration is only available if VIRTCHNL_VF_OFFLOAD_RSS_PF is present a

[PATCH v3 36/36] other: remove unnecessary NULL checks

Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger Acked-by: David Hunt --- lib/graph/graph_stats.c | 3 +-- lib/ipsec/ipsec_sad.c| 3 +-- lib/port/rte_port_source_sink.c | 21 +++-- lib/pow

[PATCH v3 35/36] compressdev: remove unnecessary NULL checks

Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger Acked-by: Fan Zhang --- lib/compressdev/rte_compressdev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/compressdev/rte_compressdev.c b/lib/compressde

[PATCH v3 34/36] vdpa/*: remove unnecessary NULL checks

Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger Reviewed-by: Chenbo Xia --- drivers/vdpa/ifc/ifcvf_vdpa.c | 9 +++-- drivers/vdpa/mlx5/mlx5_vdpa_mem.c | 3 +-- drivers/vdpa/mlx5/mlx5_vdpa_virtq.c | 3 +-- 3 files ch

[PATCH v3 33/36] regex/*: remove unnecessary NULL checks

Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger Reviewed-by: Liron Himi --- drivers/regex/cn9k/cn9k_regexdev.c | 6 ++ drivers/regex/cn9k/cn9k_regexdev_compiler.c | 3 +-- drivers/regex/mlx5/mlx5_regex.c

[PATCH v3 32/36] raw/*: remove unnecessary NULL checks

Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger Acked-by: Hemant Agrawal --- drivers/raw/cnxk_bphy/cnxk_bphy_cgx.c | 3 +-- drivers/raw/dpaa2_qdma/dpaa2_qdma.c | 15 +-- drivers/raw/ifpga/ifpga_rawdev

[PATCH v3 31/36] net/other: remove unnecessary NULL checks

Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger Acked-by: Min Hu (Connor) --- drivers/net/bonding/rte_eth_bond_pmd.c | 3 +-- drivers/net/memif/rte_eth_memif.c | 6 ++ drivers/net/null/rte_eth_null.

[PATCH v3 30/36] net/virtio: remove unnecessary NULL checks

Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/virtio/virtio_user_ethdev.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/net/virtio/virtio_user_ethdev.c b/drivers/net/

[PATCH v3 29/36] net/vdev_netvsc: remove unnecessary NULL checks

Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/vdev_netvsc/vdev_netvsc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/vdev_netvsc/vdev_netvsc.c b/drivers/net/vdev_netvsc/vde

[PATCH v3 28/36] net/txgbe: remove unnecessary NULL checks

Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/txgbe/txgbe_ethdev.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_eth

[PATCH v3 27/36] net/qede: remove unnecessary NULL checks

Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger Acked-by: Devendra Singh Rawat --- drivers/net/qede/qede_main.c | 3 +-- drivers/net/qede/qede_rxtx.c | 6 ++ 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/dr

[PATCH v3 26/36] net/octeontx: remove unnecessary NULL checks

Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/octeontx/octeontx_ethdev.c | 3 +-- drivers/net/octeontx/octeontx_ethdev_ops.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/n

[PATCH v3 25/36] net/netvsc: remove unnecessary NULL checks

Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger Acked-by: Long Li --- drivers/net/netvsc/hn_rxtx.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/netvsc/hn_rxtx.c b/drivers/net/netvsc/hn_r

[PATCH v3 24/36] net/mvpp2: remove unnecessary NULL checks

Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger Reviewed-by: Liron Himi --- drivers/net/mvpp2/mrvl_qos.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/mvpp2/mrvl_qos.c b/drivers/net/mvpp2/mrv

[PATCH v3 23/36] net/mlx*: remove unnecessary NULL checks

Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/mlx4/mlx4_mr.c | 3 +-- drivers/net/mlx5/mlx5_flow.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/mlx4/mlx4_mr.c b/drivers/

[PATCH v3 22/36] net/i*: remove unnecessary NULL checks

Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger Acked-by: Haiyue Wang --- drivers/net/i40e/i40e_ethdev.c| 27 +-- drivers/net/i40e/i40e_rxtx.c | 3 +-- drivers/net/iavf/iavf_rxtx.c | 3 +-

[PATCH v3 21/36] net/hns3: remove unnecessary NULL checks

Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger Acked-by: Min Hu (Connor) --- drivers/net/hns3/hns3_rxtx.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/net/hns3/hns3_rxtx.c b/drivers/net/

[PATCH v3 20/36] net/hinic: remove unnecessary NULL checks

Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/hinic/hinic_pmd_ethdev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/hinic/hinic_pmd_ethdev.c b/drivers/net/hinic/hinic_pmd_e

[PATCH v3 19/36] net/ena: remove unnecessary NULL checks

Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/ena/ena_ethdev.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c

[PATCH v3 18/36] net/dpaa*: remove unnecessary NULL checks

Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger Acked-by: Hemant Agrawal --- drivers/net/dpaa/dpaa_ethdev.c | 3 +-- drivers/net/dpaa/fmlib/fm_lib.c | 3 +-- drivers/net/dpaa2/dpaa2_ethdev.c | 3 +-- drivers/net/dpaa2/dpaa2_

[PATCH v3 17/36] net/cxgbe: remove unnecessary NULL checks

Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/cxgbe/cxgbe_main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/cxgbe/cxgbe_main.c b/drivers/net/cxgbe/cxgbe_main.c index f1ac3

[PATCH v3 16/36] net/cnxk: remove unnecessary NULL checks

Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/cnxk/cnxk_ethdev.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/cnxk/cnxk_ethdev.c b/drivers/net/cnxk/cnxk_ethdev.c index 5

[PATCH v3 15/36] net/bnx*: remove unnecessary NULL checks

Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/bnx2x/bnx2x_rxtx.c | 6 ++ drivers/net/bnxt/bnxt_ethdev.c | 3 +-- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/net/bnx2x/bnx2x_rxtx.c

[PATCH v3 14/36] net/axgbe: remove unnecessary NULL checks

Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/net/axgbe/axgbe_rxtx.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/axgbe/axgbe_rxtx.c b/drivers/net/axgbe/axgbe_rxtx.c index 6

[PATCH v3 13/36] event/sw: remove unnecessary NULL checks

Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/event/sw/sw_evdev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/event/sw/sw_evdev.c b/drivers/event/sw/sw_evdev.c index 6ae613e0f2e7..

[PATCH v3 12/36] crypto: remove unnecessary NULL checks

Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger Acked-by: Ruifeng Wang Acked-by: Fan Zhang --- drivers/crypto/armv8/rte_armv8_pmd_ops.c | 3 +-- drivers/crypto/ccp/ccp_dev.c | 3 +-- drivers/crypto/ccp/ccp_

[PATCH v3 11/36] compress/*: remove unnecessary NULL checks

Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/compress/mlx5/mlx5_compress.c | 3 +-- drivers/compress/octeontx/otx_zip_pmd.c | 9 +++-- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/c

[PATCH v3 10/36] common/*: remove unnecessary NULL checks

Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- drivers/common/cpt/cpt_ucode_asym.h | 6 ++ drivers/common/dpaax/compat.h | 11 ++- drivers/common/mlx5/mlx5_common_mr.c | 3 +-- drivers/common/mlx5/m

[PATCH v3 09/36] bus/*: remove unnecessary NULL checks

Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger Acked-by: Hemant Agrawal --- drivers/bus/fslmc/fslmc_bus.c| 6 ++ drivers/bus/fslmc/portal/dpaa2_hw_dpio.c | 6 ++ drivers/bus/ifpga/ifpga_bus.c|

[PATCH v3 08/36] baseband/*: remove unnecessary NULL checks

Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger Acked-by: Hemant Agrawal --- drivers/baseband/acc100/rte_acc100_pmd.c | 3 +-- drivers/baseband/la12xx/bbdev_la12xx.c | 3 +-- drivers/baseband/null/bbdev_null.c

[PATCH v3 07/36] app: remove unnecessary NULL checks

Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- app/pdump/main.c | 9 ++-- app/test-crypto-perf/cperf_test_latency.c | 3 +- .../cperf_test_pmd_cyclecount.c | 9 ++-- app/tes

[PATCH v3 06/36] vhost: remove unnecessary NULL checks

Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger Reviewed-by: Chenbo Xia --- lib/vhost/iotlb.c| 3 +-- lib/vhost/vhost_crypto.c | 6 ++ lib/vhost/vhost_user.c | 9 +++-- 3 files changed, 6 insertions(+), 12 del

[PATCH v3 05/36] examples: remove unnecessary NULL checks

Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- examples/fips_validation/fips_dev_self_test.c | 18 -- examples/fips_validation/fips_validation.c| 3 +- examples/fips_validation/main.c | 36 +++

[PATCH v3 04/36] ethdev: remove unnecessary NULL checks

Remove redundant NULL pointer checks before free functions found by nullfree.cocci Signed-off-by: Stephen Hemminger --- lib/ethdev/rte_ethdev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c index 29e21ad58003..cab7b7947eb7

[PATCH v3 02/36] devtools/cocci: add script to fix unnecessary null checks

This script is based on the idea of the nullfree script in the Linux kernel. It finds cases where a check for null pointer is done, but is unnecessary because the function already handles NULL pointer. Basic example: if (x->buf) rte_free(x->buf); can be reduced to: rte_fre

[PATCH v3 03/36] eal: remove unnecessary NULL checks

Functions like free, rte_free, and rte_mempool_free already handle NULL pointer so the checks here are not necessary. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_devargs.c | 6 ++ lib/eal/common/eal_common_memzone.c | 3 +-- lib/eal/common/eal_common_options.c | 9

[PATCH v3 01/36] lib: update documentation of XXX_free() functions

These functions all behave like libc free() and do nothing if handed a NULL pointer. The code is already doing this, this patch just documents the behavior. Signed-off-by: Stephen Hemminger --- lib/hash/rte_hash.h | 4 +++- lib/mempool/rte_mempool.h | 1 + lib/ring/rte_ring.h | 3 ++-

[PATCH v3 00/36] remove unnecessary null checks

While working on a new driver, noticed that some drivers always call free routines (correct) and others conditionally call free routines if not null (redundant check). The extra if(e != NULL) type check is unneeded and adds extra code. Better to have all the code consistent. The Linux kernel has

Re: [PATCH v2 10/12] net/txgbe: fix debug log

On 2/9/2022 10:42 AM, Jiawen Wu wrote: Remove 'DEBUGFUNC' due to too many invalid debug log prints. And fix that double line was added by using 'DEBUGOUT'. Fixes: 7dc117068a7c ("net/txgbe: support probe and remove") Cc: sta...@dpdk.org Signed-off-by: Jiawen Wu Comments to ngbe patch (8/12) a

Re: [PATCH v2 03/12] net/ngbe: fix Tx pending

On 2/9/2022 10:42 AM, Jiawen Wu wrote: Add commands requesting firmware to enable or disable PCIe bus master. Disable PCIe master access to clear BME when stop hardware, and verify there are no pending requests. Move disabling Tx queue after disabling PCIe bus master, to ensure that there are no

Re: [PATCH v2 08/12] net/ngbe: fix debug log

On 2/9/2022 10:42 AM, Jiawen Wu wrote: Remove 'DEBUGFUNC' due to too many invalid debug log prints. And fix that double line was added by using 'DEBUGOUT'. Fixes: cc934df178ab ("net/ngbe: add log and error types") Cc: sta...@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/ngbe/ngbe_logs.h

Re: [PATCH v2 07/12] net/ngbe: add LED OEM support

On 2/9/2022 10:42 AM, Jiawen Wu wrote: Support to get OEM customized LED configuration information from firmware. And driver needs to adjust the process of PHY setup link, based on this LED configuration. Signed-off-by: Jiawen Wu <...> @@ -338,3 +338,52 @@ s32 ngbe_hic_check_cap(struct ngbe

Re: [PATCH v2 00/12] Wangxun fixes and supports

On 2/9/2022 10:42 AM, Jiawen Wu wrote: Fixed some bugs for txgbe and ngbe, and support more custom functions. v2: - Add more detail describe in commit logs and release notes. - Fix build error. - Fix debug logs. Hi Jiawen, Can you please send new versions as reply to previous version (git se

Re: [PATCH] eal: remove unnecessary argv[0] handling

09/02/2022 16:45, Stephen Hemminger: > On Wed, 09 Feb 2022 15:58:26 +0100 > Thomas Monjalon wrote: > > > 02/02/2022 20:47, Stephen Hemminger: > > > The rte_eal_init function looks at argv[0] to determine > > > the program name to pass to the log init function. > > > This is both unnecessary and i

rxq_cq_process_v high cpu

I moved from dpdk 19 to dpdk 21 I read with multiqueue from Mellanox 100G card with dpdk function rte_eth_rx_burst I can see in perf top very high cpu on function rxq_cq_process_v How can i fix it? This function wasn't in my perf top with dpdk 19 version 53.12% libdpdkutils.so [.]

  1   2   3   >