RE: [PATCH v3 09/36] bus/*: remove unnecessary NULL checks

[Xu, Rosen]

Hi,

> -----Original Message-----
> From: Stephen Hemminger <step...@networkplumber.org>
> Sent: Thursday, February 10, 2022 3:17
> To: dev@dpdk.org
> Cc: Stephen Hemminger <step...@networkplumber.org>; Hemant Agrawal
> <hemant.agra...@nxp.com>; Sachin Saxena <sachin.sax...@oss.nxp.com>;
> Xu, Rosen <rosen...@intel.com>
> Subject: [PATCH v3 09/36] bus/*: remove unnecessary NULL checks
> 
> Remove redundant NULL pointer checks before free functions found by
> nullfree.cocci
> 
> Signed-off-by: Stephen Hemminger <step...@networkplumber.org>
> Acked-by: Hemant Agrawal <hemant.agra...@nxp.com>
> ---
>  drivers/bus/fslmc/fslmc_bus.c            |  6 ++----
>  drivers/bus/fslmc/portal/dpaa2_hw_dpio.c |  6 ++----
>  drivers/bus/ifpga/ifpga_bus.c            | 12 ++++--------
>  drivers/bus/pci/pci_params.c             |  3 +--
>  drivers/bus/pci/windows/pci.c            |  3 +--
>  drivers/bus/pci/windows/pci_netuio.c     |  3 +--
>  6 files changed, 11 insertions(+), 22 deletions(-)
> 
> diff --git a/drivers/bus/ifpga/ifpga_bus.c b/drivers/bus/ifpga/ifpga_bus.c
> index c5c8bbd57219..e005f2cb70b3 100644
> --- a/drivers/bus/ifpga/ifpga_bus.c
> +++ b/drivers/bus/ifpga/ifpga_bus.c
> @@ -191,10 +191,8 @@ ifpga_scan_one(struct rte_rawdev *rawdev,
>       return afu_dev;
> 
>  end:
> -     if (kvlist)
> -             rte_kvargs_free(kvlist);
> -     if (path)
> -             free(path);
> +     rte_kvargs_free(kvlist);
> +     free(path);
>       if (afu_dev) {
>               rte_intr_instance_free(afu_dev->intr_handle);
>               free(afu_dev);
> @@ -254,10 +252,8 @@ ifpga_scan(void)
>       }
> 
>  end:
> -     if (kvlist)
> -             rte_kvargs_free(kvlist);
> -     if (name)
> -             free(name);
> +     rte_kvargs_free(kvlist);
> +     free(name);
> 
>       return 0;
>  }
Reviewed-by Rosen Xu <rosen...@intel.com>