[PATCH v3 6/6] net/iavf: support L2TPv2 for AVF FDIR

2022-01-28 Thread Jie Wang
Add support for L2TPv2(include PPP over L2TPv2) protocols FDIR based on outer MAC src address and L2TPv2 session ID. Add support for PPPoL2TPv2oUDP protocols FDIR based on inner IP src/dst address and UDP/TCP src/dst port. Patterns are listed below: eth/ipv4(6)/udp/l2tpv2 eth/ipv4(6)/udp/l2tpv2/p

[PATCH v3 5/6] net/iavf: support L2TPv2 for AVF HASH

2022-01-28 Thread Jie Wang
Add support for PPP over L2TPv2 over UDP protocol and L2TPv2 protocol RSS hash based on outer MAC src address and L2TPv2 session ID. Patterns are listed below: eth/ipv4/udp/l2tpv2 eth/ipv4/udp/l2tpv2/ppp eth/ipv6/udp/l2tpv2 eth/ipv6/udp/l2tpv2/ppp Signed-off-by: Jie Wang --- doc/guides/rel_note

[PATCH v3 4/6] common/iavf: add session ID fields for L2TPv2

2022-01-28 Thread Jie Wang
Add virtchnl fields session ID of L2TPv2 for AVF HASH. Signed-off-by: Jie Wang --- drivers/common/iavf/virtchnl.h | 4 1 file changed, 4 insertions(+) diff --git a/drivers/common/iavf/virtchnl.h b/drivers/common/iavf/virtchnl.h index 80e754a1b2..3e44eca7d8 100644 --- a/drivers/common/iavf/

[PATCH v3 3/6] app/testpmd: add 6 types of L2TPv2 message

2022-01-28 Thread Jie Wang
This patch adds L2TPv2 control message and 5 types of data message support for testpmd. The added L2TPv2 message types are listed below: 1. L2TPv2 control 2. L2TPv2 3. L2TPv2 + length option 4. L2TPv2 + sequence option 5. L2TPv2 + offset option 6. L2TPv2 + length option + sequence option Signed-o

[PATCH v3 2/6] net: fix L2TPv2 common header

2022-01-28 Thread Jie Wang
The fields of L2TPv2 common header were reversed in big endian and little endian. This patch fixes this error to ensure L2TPv2 can be parsed correctly. Fixes: 3a929df1f286 ("ethdev: support L2TPv2 and PPP procotol") Cc: sta...@dpdk.org Signed-off-by: Jie Wang --- lib/net/rte_l2tpv2.h | 20

[PATCH v3 1/6] ethdev: add L2TPv2 RSS offload type

2022-01-28 Thread Jie Wang
This patch defines new RSS offload type for L2TPv2, which is required when users want to distribute packets based on the L2TPv2 session ID field. Signed-off-by: Jie Wang --- app/test-pmd/cmdline.c | 10 ++ app/test-pmd/config.c | 3 ++- doc/guides/rel_no

[PATCH v3 0/6] support L2TPv2 for AVF RSS hash and FDIR

2022-01-28 Thread Jie Wang
Support IAVF L2TPv2(include PPP over L2tpv2) RSS hash and flow director. Required to distribute packets based on outer MAC src address and L2TPv2 session ID. Support IAVF PPPoL2TPv2oUDP flow director. Required to distribute packets based on inner IP src+dest address and TCP/UDP src+dest port. ---

RE: [PATCH v2 2/6] net: fix L2TPv2 common header

2022-01-28 Thread Wang, Jie1X
> -Original Message- > From: Yigit, Ferruh > Sent: Saturday, January 29, 2022 12:12 AM > To: 20220124065613.2197436-1-jie1x.w...@intel.com; dev@dpdk.org; Olivier > Matz > Cc: Yang, SteveX ; or...@nvidia.com; Singh, Aman > Deep ; tho...@monjalon.net; > andrew.rybche...@oktetlabs.ru; Wu,

RE: [PATCH v2 1/6] ethdev: add L2TPv2 RSS offload type

2022-01-28 Thread Wang, Jie1X
> -Original Message- > From: Yigit, Ferruh > Sent: Saturday, January 29, 2022 12:12 AM > To: 20220124065613.2197436-1-jie1x.w...@intel.com; dev@dpdk.org > Cc: Yang, SteveX ; or...@nvidia.com; Singh, Aman > Deep ; tho...@monjalon.net; > andrew.rybche...@oktetlabs.ru; Wu, Jingjing ; Xing,

RE: [PATCH v2 15/15] vhost: make sure each queue callfd is configured

2022-01-28 Thread Pei, Andy
Hi Chenbo, Thanks for your reply. I will send out a V3 patch set to address that. -Original Message- From: Xia, Chenbo Sent: Thursday, January 27, 2022 3:13 PM To: Pei, Andy ; dev@dpdk.org Cc: maxime.coque...@redhat.com; Cao, Gang ; Liu, Changpeng Subject: RE: [PATCH v2 15/15] vhost:

[PATCH v3 15/15] vhost: make sure each queue callfd is configured

2022-01-28 Thread Andy Pei
During the vhost data path building process, qemu will create a call fd at first, and create another call fd in the end. The final call fd will be used to relay notify. In the original code, after kick fd is set, dev_conf will set the first call fd. Even though the actual call fd will set, the data

[PATCH v3 14/15] vdpa/ifc: make sure hardware last_avail_idx and last_used_idx are the same when blk device pause

2022-01-28 Thread Andy Pei
When virtio blk device is pause, make sure hardware last_avail_idx and last_used_idx are the same. Signed-off-by: Andy Pei --- drivers/vdpa/ifc/base/ifcvf.c | 2 +- drivers/vdpa/ifc/base/ifcvf.h | 3 +++ drivers/vdpa/ifc/ifcvf_vdpa.c | 32 +++- 3 files changed, 27 i

[PATCH v3 13/15] vdpa/ifc/base: for blk device, live migration register is different from net device

2022-01-28 Thread Andy Pei
1.last_avail_idx is lower 16 bit of the register. 2.address of ring_state register is different between net and blk device. Signed-off-by: Andy Pei --- drivers/vdpa/ifc/base/ifcvf.c | 36 +--- drivers/vdpa/ifc/base/ifcvf.h | 1 + 2 files changed, 30 insertions(+)

[PATCH v3 12/15] vdpa/ifc: add is_blk flag to ifcvf_hw, and init is_blk during probe

2022-01-28 Thread Andy Pei
Add is_blk flag to ifcvf_hw, and init is_blk during probe. Signed-off-by: Andy Pei --- drivers/vdpa/ifc/base/ifcvf.h | 1 + drivers/vdpa/ifc/ifcvf_vdpa.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/drivers/vdpa/ifc/base/ifcvf.h b/drivers/vdpa/ifc/base/ifcvf.h index 6dd7925..8e602af 10

[PATCH v3 11/15] vdpa: add config space change interrupt register and handle for virtio_blk

2022-01-28 Thread Andy Pei
Create a thread to poll and relay config space change interrupt. Use VHOST_USER_SLAVE_CONFIG_CHANGE_MSG to info qemu. Signed-off-by: Andy Pei --- drivers/vdpa/ifc/ifcvf_vdpa.c | 111 ++ 1 file changed, 111 insertions(+) diff --git a/drivers/vdpa/ifc/ifcvf

[PATCH v3 10/15] vdpa/ifc: read virtio max_queues from hardware

2022-01-28 Thread Andy Pei
Original code max_queues is set to IFCVF_MAX_QUEUES. New code max_queues is the min of IFCVF_MAX_QUEUES and hardware num_queues. Signed-off-by: Andy Pei --- drivers/vdpa/ifc/ifcvf_vdpa.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcv

[PATCH v3 09/15] vdpa/ifc: add some log at VDPA launch before qemu connect

2022-01-28 Thread Andy Pei
Add some log of virtio blk device config space information at VDPA launch before qemu connects. Signed-off-by: Andy Pei --- drivers/vdpa/ifc/ifcvf_vdpa.c | 28 1 file changed, 28 insertions(+) diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.

[PATCH v3 08/15] vdpa/ifc: set_vring_state op is mandatory, add set_vring_state for blk device

2022-01-28 Thread Andy Pei
Set_vring_state op is mandatory, add set_vring_state for blk device. Currently set_vring_state for blk device is not implemented. Signed-off-by: Andy Pei --- drivers/vdpa/ifc/ifcvf_vdpa.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/vdpa/ifc/ifcvf_vdpa

[PATCH v3 07/15] usertools: add support for virtio blk device

2022-01-28 Thread Andy Pei
Add virtio blk device support to devbind. Signed-off-by: Andy Pei --- usertools/dpdk-devbind.py | 8 1 file changed, 8 insertions(+) diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py index ace4627..cbe336f 100755 --- a/usertools/dpdk-devbind.py +++ b/usertools/dpdk-dev

[PATCH v3 06/15] example/vdpa:add vdpa blk support in example

2022-01-28 Thread Andy Pei
Add virtio blk device support to vdpa example. Signed-off-by: Andy Pei --- examples/vdpa/Makefile | 2 +- examples/vdpa/main.c | 8 ++ examples/vdpa/meson.build| 1 + examples/vdpa/vdpa_blk_compact.c | 150 +++ examples/vdpa/vdpa_bl

[PATCH v3 05/15] vdpa/ifc: add blk dev sw live migration

2022-01-28 Thread Andy Pei
Enable virtio blk sw live migration relay callfd and log the dirty page. In this version we ignore the write cmd and still mark it dirty. Signed-off-by: Andy Pei --- drivers/vdpa/ifc/base/ifcvf.c | 4 +- drivers/vdpa/ifc/base/ifcvf.h | 6 ++ drivers/vdpa/ifc/ifcvf_vdpa.c | 128 ++

[PATCH v3 04/15] vdpa/ifc: add vdpa interrupt for blk device

2022-01-28 Thread Andy Pei
For the blk we need to relay all the cmd of each queue. Signed-off-by: Andy Pei --- drivers/vdpa/ifc/ifcvf_vdpa.c | 46 --- 1 file changed, 35 insertions(+), 11 deletions(-) diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.c index

[PATCH v3 03/15] vdpa/ifc: add blk ops for ifc device

2022-01-28 Thread Andy Pei
For virtio blk device, re-use part of ifc driver ops. Implement ifcvf_blk_get_config for virtio blk device. Support VHOST_USER_PROTOCOL_F_CONFIG feature for virtio blk device. Signed-off-by: Andy Pei --- drivers/vdpa/ifc/base/ifcvf.h | 4 ++ drivers/vdpa/ifc/ifcvf_vdpa.c | 85 ++

[PATCH v3 02/15] vhost: add vdpa ops for blk device

2022-01-28 Thread Andy Pei
Get_config and set_config are necessary ops for blk device. Add get_config and set_config ops to vdpa ops. Signed-off-by: Andy Pei --- lib/vhost/vdpa_driver.h | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/lib/vhost/vdpa_driver.h b/lib/vhost/vdpa_driver.h index fc2d6

[PATCH v3 01/15] vdpa/ifc: add support for virtio blk device

2022-01-28 Thread Andy Pei
Re-use the vdpa/ifc code, distinguish blk and net device by pci_device_id. Blk and net device are implemented with proper feature and ops. Signed-off-by: Andy Pei --- drivers/vdpa/ifc/base/ifcvf.h | 16 +++- drivers/vdpa/ifc/ifcvf_vdpa.c | 92 +++ 2 fi

[PATCH v3 00/15] add virtio_blk device support to vdpa/ifc

2022-01-28 Thread Andy Pei
This patch set add virtio_blk device support to vdpa/ifc driver. With a lot of similarities, I re-use part of vdpa/ifc driver. Distinguish the virtio net and blk device by device id, and implement specific features and ops. Add example to vdpa to support virtio_blk device. To support blk device li

[RFC] eal_debug: do not use malloc in rte_dump_stack

2022-01-28 Thread Stephen Hemminger
The glibc backtrace_symbols() calls malloc which makes it dangerous to use rte_dump_stack() in a signal handler that is handling errors that maybe due to memory corruption. Instead, use dladdr() to lookup up symbols incrementally. The format of the messages is based on what X org server has been

Re: [PATCH v2 01/83] lib: update documentation of XXX_free() functions

2022-01-28 Thread Stephen Hemminger
On Fri, 28 Jan 2022 22:47:15 +0100 Thomas Monjalon wrote: > 24/01/2022 18:45, Stephen Hemminger: > > These functions all behave like libc free() and do > > nothing if handed a NULL pointer. The code is already doing > > this, this patch just documents the behavior. > > > > Signed-off-by: Stephen

Re: [PATCH v2 00/83] remove unnecessary null checks

2022-01-28 Thread Stephen Hemminger
On Fri, 28 Jan 2022 22:49:31 +0100 Thomas Monjalon wrote: > 24/01/2022 18:45, Stephen Hemminger: > > Stephen Hemminger (83): > > lib: update documentation of XXX_free() functions > > devtools/cocci: add script to fix unnecessary null checks > > I think it is good to have the first 2 patche

Re: [PATCH v2 00/83] remove unnecessary null checks

2022-01-28 Thread Thomas Monjalon
24/01/2022 18:45, Stephen Hemminger: > Stephen Hemminger (83): > lib: update documentation of XXX_free() functions > devtools/cocci: add script to fix unnecessary null checks I think it is good to have the first 2 patches separate, but the rest could go in a single third patch.

Re: [PATCH v2 02/83] devtools/cocci: add script to fix unnecessary null checks

2022-01-28 Thread Thomas Monjalon
24/01/2022 18:45, Stephen Hemminger: > This script is based on the idea of the nullfree script > in the Linux kernel. It finds cases where a check for null > pointer is done, but is unnecessary because the function > already handles NULL pointer. > > Basic example: >if (x->buf) >

Re: [PATCH v2 01/83] lib: update documentation of XXX_free() functions

2022-01-28 Thread Thomas Monjalon
24/01/2022 18:45, Stephen Hemminger: > These functions all behave like libc free() and do > nothing if handed a NULL pointer. The code is already doing > this, this patch just documents the behavior. > > Signed-off-by: Stephen Hemminger > --- > /** > * De-allocate all memory used by hash table

[dpdk-dev v5 10/10] crypto/qat: support out of place SG list

2022-01-28 Thread Kai Ji
This patch adds the SGL out of place support to QAT PMD Signed-off-by: Kai Ji --- drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c | 28 -- drivers/crypto/qat/dev/qat_crypto_pmd_gen4.c | 14 - drivers/crypto/qat/dev/qat_sym_pmd_gen1.c| 55 +--- 3 files changed, 83 ins

[dpdk-dev v5 09/10] crypto/qat: raw dp api integration

2022-01-28 Thread Kai Ji
This patch "unifies" QAT's raw dp api implementations to share the same enqueue/dequeue methods as the crypto operation enqueue/dequeue methods. In addition, different QAT generation specific implementations are done respectively. The qat_sym_hw_dp.c is removed as no longer required. Signed-off-by

[dpdk-dev v5 08/10] crypto/qat: op burst data path rework

2022-01-28 Thread Kai Ji
This patch enable op_build_request function in qat_enqueue_op_burst, and qat_dequeue_process_response function in qat_dequeue_op_burst. The op_build_request invoked in crypto build request op is based on crypto operations setup during session init. Signed-off-by: Kai Ji --- drivers/common/qat/qa

[dpdk-dev v5 06/10] crypto/qat: unify qat sym pmd apis

2022-01-28 Thread Kai Ji
This patch removes qat_sym_pmd.c and integrates all the apis into qat_sym.c. The unified/integrated qat sym crypto pmd apis should make them easier to maintain. Signed-off-by: Kai Ji --- drivers/common/qat/meson.build | 4 +- drivers/common/qat/qat_device.c | 4 +- drivers/common/

[dpdk-dev v5 07/10] crypto/qat: unify qat asym pmd apis

2022-01-28 Thread Kai Ji
This patch removes qat_asym_pmd.c and integrates all the functions into qat_asym.c. The unified/integrated asym crypto pmd apis should make them easier to maintain. Signed-off-by: Kai Ji --- drivers/common/qat/meson.build| 2 +- drivers/crypto/qat/qat_asym.c | 180 +

[dpdk-dev v5 05/10] crypto/qat: rework asymmetric crypto build operation

2022-01-28 Thread Kai Ji
This patch reworks the asymmetric crypto data path implementation to QAT driver. The change includes separation of different QAT generations' asymmetric crypto data path implementations and shrink the device capabilities declaration code size. Signed-off-by: Kai Ji --- drivers/common/qat/qat_qp.

[dpdk-dev v5 04/10] crypto/qat: rework session APIs

2022-01-28 Thread Kai Ji
This patch introduces the set_session methods for different generations of QAT. In addition, the patch replaces 'min_qat_dev_gen_id' with 'qat_dev_gen'. Thus, the session no longer allow to be created by one generation of QAT used by another generation. Signed-off-by: Kai Ji --- drivers/crypto/q

[dpdk-dev v5 03/10] crypto/qat: qat generation specific enqueue

2022-01-28 Thread Kai Ji
This patch add in specific aead & auth build op enqueue functions for QAT Gen3 & Gen4 Signed-off-by: Kai Ji --- drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c | 117 ++- drivers/crypto/qat/dev/qat_crypto_pmd_gen4.c | 34 +- 2 files changed, 149 insertions(+), 2 deletions(-) d

[dpdk-dev v5 02/10] crypto/qat: sym build op request specific implementation

2022-01-28 Thread Kai Ji
This patch adds common inline functions for QAT symmetric crypto driver to process crypto op and the build op request function pointer implementation for QAT generation 1. Signed-off-by: Kai Ji --- drivers/crypto/qat/dev/qat_crypto_pmd_gens.h | 832 ++- drivers/crypto/qat/dev/qat

[dpdk-dev v5 01/10] common/qat: define build op request and dequeue op

2022-01-28 Thread Kai Ji
This patch introduce build request op and dequeue op function pointers to qat queue pair implementation. Those two functions are used to be assigned during qat session generation based on crypto operation Signed-off-by: Kai Ji --- drivers/common/qat/qat_qp.c | 10 -- drivers/common/

[dpdk-dev v5 00/10] drivers/qat: QAT symmetric crypto datapatch rework

2022-01-28 Thread Kai Ji
This patch reworks QAT symmetric crypto datapatch implementation where each generation request building separated and the crypto operation under the raw datapath api implementation are unified. In addtion this patchset also enables QAT OOP support in raw datapath api implementation. v5: - rebase

[PATCH v4 3/3] net/enic: support max descriptors allowed by adapter

2022-01-28 Thread John Daley
Newer VIC adapters have the max number of supported RX and TX descriptors in their configuration. Use these values as the maximums. Signed-off-by: John Daley Reviewed-by: Hyong Youb Kim --- drivers/net/enic/base/cq_enet_desc.h | 6 - drivers/net/enic/enic_res.c | 20 --

[PATCH v4 2/3] net/enic: update VIC firmware API

2022-01-28 Thread John Daley
Update the configuration structure used between the adapter and driver. The structure is compatible with all Cisco VIC adapters. Signed-off-by: John Daley Reviewed-by: Hyong Youb Kim --- drivers/net/enic/base/vnic_enet.h | 22 ++ 1 file changed, 22 insertions(+) diff --git

[PATCH v4 1/3] net/enic: add support for eCPRI matching

2022-01-28 Thread John Daley
eCPRI message can be over Ethernet layer (.1Q supported also) or over UDP layer. Message header formats are the same in these two variants. Only up though the first packet header in the PDU can be matched. RSS on the eCPRI payload is not supported. Signed-off-by: John Daley Reviewed-by: Hyong Yo

Re: [PATCH v3] app/test-fib: fix possible division by zero

2022-01-28 Thread Kevin Traynor
On 27/01/2022 18:08, Vladimir Medvedkin wrote: This patch fixes the division by 0, which occurs if the number of routes is less than 10. Can be triggered by passing -n argument with value < 10: ./dpdk-test-fib -- -n 9 ... Floating point exception (core dumped) Fixes: 103809d032cd ("app/test-fib

Re: [dpdk-dev] [PATCH v3 3/6] eal: support libunwind based backtrace

2022-01-28 Thread Stephen Hemminger
On Fri, 28 Jan 2022 19:57:40 +0530 Jerin Jacob wrote: > On Fri, Jan 28, 2022 at 2:11 PM Thomas Monjalon wrote: > > > > 28/01/2022 05:33, Jerin Jacob: > > > On Fri, Jan 28, 2022 at 2:18 AM Stephen Hemminger > > > wrote: > > > > > > > > On Mon, 6 Sep 2021 09:47:29 +0530 > > > > wrote: > > >

Re: [PATCH v2 2/6] net: fix L2TPv2 common header

2022-01-28 Thread Ferruh Yigit
On 1/26/2022 6:30 AM, Jie Wang wrote: The fields of L2TPv2 common header were reversed in big endian and little endian. This patch fixes this error to ensure L2TPv2 can be parsed correctly. Just for reference, checked from RFC: https://datatracker.ietf.org/doc/html/rfc2661#section-3.1 Change

Re: [PATCH v2 3/6] app/testpmd: add 6 types of L2TPv2 message

2022-01-28 Thread Ferruh Yigit
On 1/26/2022 6:30 AM, Jie Wang wrote: This patch adds L2TPv2 control message and 5 types of data message support for testpmd. The added L2TPv2 message types are listed below: 1. L2TPv2 control 2. L2TPv2 3. L2TPv2 + length option 4. L2TPv2 + sequence option 5. L2TPv2 + offset option 6. L2TPv2 + l

Re: [PATCH v2 1/6] ethdev: add L2TPv2 RSS offload type

2022-01-28 Thread Ferruh Yigit
On 1/26/2022 6:30 AM, Jie Wang wrote: This patch defines new RSS offload type for L2TPv2, which is required when users want to distribute packets based on the L2TPv2 session ID field. Signed-off-by: Jie Wang <...> diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h index 147cc1ce

Re: [PATCH] net/dpaa2: fix null pointer dereference

2022-01-28 Thread Ferruh Yigit
On 1/25/2022 2:23 PM, Weiguo Li wrote: Check for memory allocation failure is added to avoid null pointer dereference. Fixes: 4690a6114ff6 ("net/dpaa2: enable error queues optionally") Signed-off-by: Weiguo Li Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.

Re: [PATCH] net/enic: adjust memory check and use in proper order

2022-01-28 Thread Ferruh Yigit
On 1/26/2022 10:00 PM, John Daley (johndale) wrote: <...> Thanks, John -Original Message- From: Weiguo Li Sent: Tuesday, January 25, 2022 4:01 AM To: John Daley (johndale) Cc: dev@dpdk.org Subject: [PATCH] net/enic: adjust memory check and use in proper order Fixes: bb66d562aefc ("n

Re: [dpdk-dev] [PATCH v3 3/6] eal: support libunwind based backtrace

2022-01-28 Thread Jerin Jacob
On Fri, Jan 28, 2022 at 2:11 PM Thomas Monjalon wrote: > > 28/01/2022 05:33, Jerin Jacob: > > On Fri, Jan 28, 2022 at 2:18 AM Stephen Hemminger > > wrote: > > > > > > On Mon, 6 Sep 2021 09:47:29 +0530 > > > wrote: > > > > > > > From: Jerin Jacob > > > > > > > > adding optional libwind library d

[PATCH v6 1/2] common/cnxk: support priority flow ctrl config API

2022-01-28 Thread skori
From: Sunil Kumar Kori CNXK platforms support priority flow control(802.1qbb) to pause respective traffic per class on that link. Patch adds RoC interface to configure priority flow control on MAC block i.e. CGX on cn9k and RPM on cn10k. Signed-off-by: Sunil Kumar Kori --- v1..v2: - fix RoC A

[PATCH v6 2/2] net/cnxk: support priority flow control

2022-01-28 Thread skori
From: Sunil Kumar Kori Patch implements priority flow control support for CNXK platforms. Signed-off-by: Sunil Kumar Kori --- v1..v2: - fix application restart issue. v2..v3: - fix pause quanta configuration for cn10k. - fix review comments. v3..v4: - fix PFC configuration with other ty

Re: [PATCH v3] net/enic: support max descriptors allowed by adapter

2022-01-28 Thread Ferruh Yigit
On 1/27/2022 7:10 PM, John Daley wrote: Newer VIC adapters have the max number of supported RX and TX descriptors in their configuration. Use these values as the maximums. Signed-off-by: John Daley Reviewed-by: Hyong Youb Kim --- v3: add line just below so 0-day bot applies dependency Depends-

Re: [PATCH v2] net/tap: fix to populate fds in secondary process

2022-01-28 Thread Ferruh Yigit
On 1/28/2022 9:55 AM, kumaraparameshwaran rathinavel wrote: > +static int > +tap_mp_req_start_rxtx(const struct rte_mp_msg *request, __rte_unused const void *peer) > +{ I asked last time but I don't remember the response, what should be in the 'peer' variable? The peer variable is currently

[dpdk-dev] [PATCH v7 4/4] doc: update release notes

2022-01-28 Thread Kalesh A P
From: Kalesh AP Updated release notes with new error recovery event support. Signed-off-by: Kalesh AP --- doc/guides/rel_notes/release_22_03.rst | 15 +++ 1 file changed, 15 insertions(+) diff --git a/doc/guides/rel_notes/release_22_03.rst b/doc/guides/rel_notes/release_22_03.rst

[dpdk-dev] [PATCH v7 3/4] net/bnxt: notify applications about device reset/recovery

2022-01-28 Thread Kalesh A P
From: Kalesh AP When the driver receives RESET_NOTIFY async event from FW or detects an error condition, it should update the application that FW is going to reset. Once the driver recovers from the reset, update the reset recovery status to application as well. Signed-off-by: Kalesh AP Signed-

[dpdk-dev] [PATCH v7 2/4] app/testpmd: handle device recovery event

2022-01-28 Thread Kalesh A P
From: Kalesh AP Added code to handle error recovery events in testpmd. This is an indication from the PMD that it is undergoing an error recovery and recovered from the error condition. Signed-off-by: Kalesh AP Signed-off-by: Somnath Kotur Reviewed-by: Ajit Khaparde --- app/test-pmd/paramete

[dpdk-dev] [PATCH v7 1/4] ethdev: support device reset and recovery events

2022-01-28 Thread Kalesh A P
From: Kalesh AP Adding support for the device reset and recovery events in the rte_eth_event framework. FW error and FW reset conditions would be managed internally by the PMD without needing application intervention. In such cases, PMD would need reset/recovery events to notify application that

[dpdk-dev] [PATCH v7 0/4] ethdev: error recovery support

2022-01-28 Thread Kalesh A P
From: Kalesh AP The error recovery solution is a protocol implemented between firmware and bnxt PMD to recover from the fatal errors without a system reboot. There is an alarm thread which constantly monitors the health of the firmware and initiates a recovery when needed. There are two scenario

RE: [RFC PATCH v1 0/4] Direct re-arming of buffers on receive side

2022-01-28 Thread Morten Brørup
> From: Morten Brørup > Sent: Thursday, 27 January 2022 18.14 > > > From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] > > Sent: Thursday, 27 January 2022 05.07 > > > > Thanks Morten, appreciate your comments. Few responses inline. > > > > > -Original Message- > > > From: Mor

Re: [dpdk-dev] [PATCH 21.02 v2] mem: don't warn about base addr if not requested

2022-01-28 Thread Thomas Monjalon
22/01/2021 18:21, Burakov, Anatoly: > On 09-Nov-20 3:47 PM, Anatoly Burakov wrote: > > Any EAL memory allocation often goes through eal_get_virtual_area() > > function, which will print a warning whenever the resulting allocation > > didn't match the specified address requirements. This is useful f

RE: [PATCH v1] doc: update FIPS docs

2022-01-28 Thread Zhang, Roy Fan
> -Original Message- > From: Jakub Poczatek > Sent: Friday, January 28, 2022 11:08 AM > To: Kovacevic, Marko > Cc: dev@dpdk.org; Poczatek, Jakub > Subject: [PATCH v1] doc: update FIPS docs > > Added missing step for converting SHA request files to correct > format. Replaced AES_GCM with

[PATCH v1] doc: update FIPS docs

2022-01-28 Thread Jakub Poczatek
Added missing step for converting SHA request files to correct format. Replaced AES_GCM with GCM to follow the correct naming format. Signed-off-by: Jakub Poczatek --- doc/guides/sample_app_ug/fips_validation.rst | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/doc/guides/sa

RE: [PATCH] mempool: fix get objects from mempool with cache

2022-01-28 Thread Morten Brørup
Olivier, thank you for the detailed feedback on my mempool RFC and patches. We might disagree on some points, but that is the point of having a discussion. :-) > From: Olivier Matz [mailto:olivier.m...@6wind.com] > Sent: Monday, 24 January 2022 16.39 > > Hi Morten, > > Few comments below. > >

Re: [PATCH v2] net/tap: fix to populate fds in secondary process

2022-01-28 Thread kumaraparameshwaran rathinavel
Hi Ferruh, Please find the consolidated comments for the review. I had missed answering a few of them in my previous email. On Mon, Jan 24, 2022 at 6:05 PM Ferruh Yigit wrote: > On 1/24/2022 12:12 PM, Kumara Parameshwaran wrote: > > From: Kumara Parameshwaran > > > > When a tap device is hotpl

[PATCH v3] net/af_xdp: use libxdp if available

2022-01-28 Thread Ciara Loftus
AF_XDP support is deprecated in libbpf since v0.7.0 [1]. The libxdp library now provides the functionality which once was in libbpf and which the AF_XDP PMD relies on. This commit updates the AF_XDP meson build to use the libxdp library if a version >= v1.2.2 is available. If it is not available, o

[PATCH v2] net/iavf: fix null pointer dereference

2022-01-28 Thread Weiguo Li
Check for memory allocation failure is added to avoid null pointer dereference. Fixes: 6bc987ecb860 ("net/iavf: support IPsec inline crypto") Signed-off-by: Weiguo Li Acked-by: Radu Nicolau --- v2: * Update to keep coding style consistent --- drivers/net/iavf/iavf_ipsec_crypto.c | 2 ++ 1 file

RE: [PATCH v3] mempool: fix put objects to mempool with cache

2022-01-28 Thread Morten Brørup
> From: Olivier Matz [mailto:olivier.m...@6wind.com] > Sent: Monday, 24 January 2022 16.39 > > Hi Morten, > > On Wed, Jan 19, 2022 at 04:03:01PM +0100, Morten Brørup wrote: > > mempool: fix put objects to mempool with cache > > > > This patch optimizes the rte_mempool_do_generic_put() caching > a

RE: [PATCH v2] doc: update matching versions in ice guide

2022-01-28 Thread Zhang, Qi Z
> -Original Message- > From: Guo, Junfeng > Sent: Thursday, January 27, 2022 4:09 PM > To: Zhang, Qi Z ; Yang, Qiming > > Cc: dev@dpdk.org; david.march...@redhat.com; sta...@dpdk.org > Subject: RE: [PATCH v2] doc: update matching versions in ice guide > > > > > -Original Message

RE: [RFC] mempool: modify flush threshold

2022-01-28 Thread Morten Brørup
+Jerin, you had feedback regarding the mempool. > From: Morten Brørup > Sent: Friday, 28 January 2022 09.41 > > +Honnappa, you have shown a keen interest in this topic. > > > From: Olivier Matz [mailto:olivier.m...@6wind.com] > > Sent: Monday, 24 January 2022 16.57 > > > > On Mon, Jan 10, 2022 a

RE: [PATCH] net/iavf: fix null pointer dereference

2022-01-28 Thread Zhang, Qi Z
> -Original Message- > From: Weiguo Li > Sent: Tuesday, January 25, 2022 10:23 PM > To: Wu, Jingjing > Cc: Nicolau, Radu ; dev@dpdk.org > Subject: [PATCH] net/iavf: fix null pointer dereference > > Check for memory allocation failure is added to avoid null pointer > dereference. > >

DPDK Release Status Meeting 2022-01-27

2022-01-28 Thread Mcnamara, John
Release status meeting minutes 2022-01-27 = Agenda: * Release Dates * Subtrees * Roadmaps * LTS * Defects * Opens Participants: * Debian * Intel * Marvell * Nvidia * Red Hat Release Dates - The following are the proposed dates for 22.03: * 2

Re: [dpdk-dev] [PATCH v3 3/6] eal: support libunwind based backtrace

2022-01-28 Thread Thomas Monjalon
28/01/2022 05:33, Jerin Jacob: > On Fri, Jan 28, 2022 at 2:18 AM Stephen Hemminger > wrote: > > > > On Mon, 6 Sep 2021 09:47:29 +0530 > > wrote: > > > > > From: Jerin Jacob > > > > > > adding optional libwind library dependency to DPDK for > > > enhanced backtrace based on ucontext. > > > > > >

RE: [RFC] mempool: modify flush threshold

2022-01-28 Thread Morten Brørup
+Honnappa, you have shown a keen interest in this topic. > From: Olivier Matz [mailto:olivier.m...@6wind.com] > Sent: Monday, 24 January 2022 16.57 > > On Mon, Jan 10, 2022 at 09:40:48AM +, Bruce Richardson wrote: > > On Sat, Jan 08, 2022 at 12:00:17PM +0100, Morten Brørup wrote: > > > > From