> -----Original Message-----
> From: Yigit, Ferruh <ferruh.yi...@intel.com>
> Sent: Saturday, January 29, 2022 12:12 AM
> To: 20220124065613.2197436-1-jie1x.w...@intel.com; dev@dpdk.org
> Cc: Yang, SteveX <stevex.y...@intel.com>; or...@nvidia.com; Singh, Aman
> Deep <aman.deep.si...@intel.com>; tho...@monjalon.net;
> andrew.rybche...@oktetlabs.ru; Wu, Jingjing <jingjing...@intel.com>; Xing,
> Beilei <beilei.x...@intel.com>; Zhang, Qi Z <qi.z.zh...@intel.com>; Wang,
> Jie1X <jie1x.w...@intel.com>
> Subject: Re: [PATCH v2 1/6] ethdev: add L2TPv2 RSS offload type
>
> On 1/26/2022 6:30 AM, Jie Wang wrote:
> > This patch defines new RSS offload type for L2TPv2, which is required
> > when users want to distribute packets based on the L2TPv2 session ID
> > field.
> >
> > Signed-off-by: Jie Wang <jie1x.w...@intel.com>
>
> <...>
>
> > diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h index
> > 147cc1ced3..1e493a1e33 100644
> > --- a/lib/ethdev/rte_ethdev.h
> > +++ b/lib/ethdev/rte_ethdev.h
> > @@ -651,6 +651,13 @@ struct rte_eth_rss_conf {
> > #define RTE_ETH_RSS_L4_CHKSUM RTE_BIT64(35)
> > #define ETH_RSS_L4_CHKSUM RTE_DEPRECATED(ETH_RSS_L4_CHKSUM)
> > RTE_ETH_RSS_L4_CHKSUM
> >
> > +/*
> > + * Below macro is defined for RSS offload type, it can be used to
> > + * fill rte_eth_rss_conf.rss_hf or rte_flow_action_rss.types.
> > + */
> > +#define RTE_ETH_RSS_L2TPV2 RTE_BIT64(36)
> > +#define ETH_RSS_L2TPV2 RTE_DEPRECATED(ETH_RSS_L2TPV2)
> > +RTE_ETH_RSS_L2TPV2
>
> The RTE_DEPRECATED is for old and deprecated macros, please don't use it for
> new macros.
>
OK, I'll update it in v3.
> > +
> > /*
> > * We use the following macros to combine with above RTE_ETH_RSS_* for
> > * more specific input set selection. These bits are defined
> > starting
