Re: [dpdk-dev] [PATCH v3 6/8] cryptodev: rework session framework

2021-10-20 Thread Akhil Goyal
> > As per current design, rte_cryptodev_sym_session_create() and > > rte_cryptodev_sym_session_init() use separate mempool objects > > for a single session. > > And structure rte_cryptodev_sym_session is not directly used > > by the application, it may cause ABI breakage if the structure > > is

Re: [dpdk-dev] [PATCH v1 00/12] use compiler atomic builtins for app

2021-10-20 Thread Joyce Kong
Hi all, Would you please help review the patch series? Thanks! Best Regards, Joyce > -Original Message- > From: dev On Behalf Of Joyce Kong > Sent: Monday, August 2, 2021 6:19 PM > To: tho...@monjalon.net; david.march...@redhat.com; Honnappa > Nagarahalli ; Ruifeng Wang > ; konstantin.a

[dpdk-dev] [PATCH v4 6/6] net/mlx5: preserve indirect actions on restart

2021-10-20 Thread Dmitry Kozlyuk
MLX5 PMD uses reference counting to manage RX queue resources. After port stop shared RSS actions kept references to RX queues, preventing resource release. As a result, internal PMD mempool for such queues had been exhausted after a number of port restarts. Diagnostic message from rte_eth_dev_star

[dpdk-dev] [PATCH v4 5/6] net/mlx5: create drop queue using DevX

2021-10-20 Thread Dmitry Kozlyuk
Drop queue creation and destruction were not implemented for DevX flow engine and Verbs engine methods were used as a workaround. Implement these methods for DevX so that there is a valid queue ID that can be used regardless of queue configuration via API. Cc: sta...@dpdk.org Signed-off-by: Dmitr

[dpdk-dev] [PATCH v4 4/6] net/mlx5: discover max flow priority using DevX

2021-10-20 Thread Dmitry Kozlyuk
Maximum available flow priority was discovered using Verbs API regardless of the selected flow engine. This required some Verbs objects to be initialized in order to use DevX engine. Make priority discovery an engine method and implement it for DevX using its API. Cc: sta...@dpdk.org Signed-off-b

[dpdk-dev] [PATCH v4 3/6] net: advertise no support for keeping flow rules

2021-10-20 Thread Dmitry Kozlyuk
When RTE_ETH_DEV_CAPA_FLOW_RULE_KEEP capability bit is zero, the specified behavior is the same as it had been before this bit was introduced. Explicitly reset it in all PMDs supporting rte_flow API in order to attract the attention of maintainers, who should eventually choose to advertise the new

[dpdk-dev] [PATCH v4 2/6] ethdev: add capability to keep shared objects on restart

2021-10-20 Thread Dmitry Kozlyuk
rte_flow_action_handle_create() did not mention what happens with an indirect action when a device is stopped and started again. It is natural for some indirect actions, like counter, to be persistent. Keeping others at least saves application time and complexity. However, not all PMDs can support

[dpdk-dev] [PATCH v4 1/6] ethdev: add capability to keep flow rules on restart

2021-10-20 Thread Dmitry Kozlyuk
Previously, it was not specified what happens to the flow rules when the device is stopped, possibly reconfigured, then started. If flow rules were kept, it could be convenient for application developers, because they wouldn't need to save and restore them. However, due to the number of flows and p

[dpdk-dev] [PATCH v4 0/6] Flow entites behavior on port restart

2021-10-20 Thread Dmitry Kozlyuk
It is unspecified whether flow rules and indirect actions are kept when a port is stopped, possibly reconfigured, and started again. Vendors approach the topic differently, e.g. mlx5 and i40e PMD disagree in whether flow rules can be kept, and mlx5 PMD would keep indirect actions. In the end, appli

Re: [dpdk-dev] [PATCH v12 6/7] app/testpmd: force shared Rx queue polled on same core

2021-10-20 Thread Li, Xiaoyun
> -Original Message- > From: Xueming Li > Sent: Thursday, October 21, 2021 13:09 > To: dev@dpdk.org; Zhang, Yuying ; Li, Xiaoyun > > Cc: xuemi...@nvidia.com; Jerin Jacob ; Yigit, Ferruh > ; Andrew Rybchenko > ; Viacheslav Ovsiienko > ; Thomas Monjalon ; Lior > Margalit ; Ananyev, Konstant

Re: [dpdk-dev] [PATCH v12 7/7] app/testpmd: add forwarding engine for shared Rx queue

2021-10-20 Thread Li, Xiaoyun
> -Original Message- > From: Xueming Li > Sent: Thursday, October 21, 2021 13:09 > To: dev@dpdk.org; Zhang, Yuying ; Li, Xiaoyun > > Cc: xuemi...@nvidia.com; Jerin Jacob ; Yigit, Ferruh > ; Andrew Rybchenko > ; Viacheslav Ovsiienko > ; Thomas Monjalon ; Lior > Margalit ; Ananyev, Konstant

[dpdk-dev] [PATCH v7 3/3] app/testpmd: support L2TPv2 and PPP protocol pattern

2021-10-20 Thread Jie Wang
Add support for test-pmd to parse protocol pattern L2TPv2 and PPP. Signed-off-by: Wenjun Wu Signed-off-by: Jie Wang --- app/test-pmd/cmdline_flow.c | 251 doc/guides/testpmd_app_ug/testpmd_funcs.rst | 28 +++ 2 files changed, 279 insertions(+) diff --git a

[dpdk-dev] [PATCH v7 2/3] net/iavf: support PPPoL2TPv2oUDP RSS Hash

2021-10-20 Thread Jie Wang
Add support for PPP over L2TPv2 over UDP protocol RSS Hash based on inner IP src/dst address and TCP/UDP src/dst port. Patterns are listed below: eth/ipv4(6)/udp/l2tpv2/ppp/ipv4(6) eth/ipv4(6)/udp/l2tpv2/ppp/ipv4(6)/udp eth/ipv4(6)/udp/l2tpv2/ppp/ipv4(6)/tcp Acked-by: Beilei Xing Signed-off-by:

[dpdk-dev] [PATCH v7 1/3] ethdev: support L2TPv2 and PPP procotol

2021-10-20 Thread Jie Wang
Added flow pattern items and header formats of L2TPv2 and PPP. Signed-off-by: Wenjun Wu Signed-off-by: Jie Wang --- doc/api/doxy-api-index.md | 2 + doc/guides/nics/features/default.ini | 2 + doc/guides/nics/features/iavf.ini | 2 + doc/guides/prog_guide/rte_flow.rst

[dpdk-dev] [PATCH v7 0/3] support PPPoL2TPv2oUDP RSS Hash

2021-10-20 Thread Jie Wang
Support IAVF PPPoL2TPv2oUDP RSS Hash. Required to distribute packets based on inner IP src+dest address and TCP/UDP src+dest port. --- V7: * update ini file. * modify irregular spelling. v6: * update release notes. * update lib/net/meson.build. * update testpmd_funcs.rst. * update doxygen co

Re: [dpdk-dev] [PATCH] kni: remove non-C11 path from FIFO sync

2021-10-20 Thread Joyce Kong
Hi, I'm seeing the CI failure with Arm-gigabyte due to automic_autotest and malloc_autotest failures. While this patch is not related to these unit tests since it only modified kni part, this may be a common CI issue. Also, would you please have a review about this patch? Thanks, Joyce > ---

[dpdk-dev] [PATCH v2] net/ice: fix TM hierarchy commit flag not reset correctly

2021-10-20 Thread Ting Xu
After DCF commits TM hierarchy configuration, the commit flag is set to avoid duplicated commit. But the flag is not reset after device stop, which prevents the update of hierarchy configuration unless close the device. It is not reasonable. This patch fix to reset the commit flag after device stop

[dpdk-dev] [PATCH] net/virtio: fix incorrect avail desc id

2021-10-20 Thread xuan . ding
From: Xuan Ding Vhost will update desc’s Buffer ID advance to next used descriptor when VIRTIO_F_IN_ORDER feature negotiated. When virtio reuses the descriptor, the Buffer ID should be restored even VIRTQ_DESC_F_INDIRECT feature negotiated. Fixes: b473061b0e1d ("net/virtio: fix indirect descript

Re: [dpdk-dev] [PATCH v6 1/5] net/enetfec: introduce NXP ENETFEC driver

2021-10-20 Thread Hemant Agrawal
Series- Acked-by: Hemant Agrawal > -Original Message- > From: Apeksha Gupta > Sent: Thursday, October 21, 2021 10:17 AM > To: david.march...@redhat.com; andrew.rybche...@oktetlabs.ru; > ferruh.yi...@intel.com > Cc: dev@dpdk.org; Sachin Saxena ; Hemant > Agrawal ; Apeksha Gupta > > Subj

Re: [dpdk-dev] [PATCH v11 4/7] app/testpmd: new parameter to enable shared Rx queue

2021-10-20 Thread Li, Xiaoyun
> -Original Message- > From: Xueming(Steven) Li > Sent: Thursday, October 21, 2021 11:59 > To: Li, Xiaoyun ; Zhang, Yuying > ; dev@dpdk.org > Cc: Ananyev, Konstantin ; > jerinjac...@gmail.com; NBU-Contact-Thomas Monjalon > ; Slava Ovsiienko ; > ajit.khapa...@broadcom.com; Yigit, Ferruh ; >

[dpdk-dev] [PATCH v2 2/2] net/cnxk: support rte flow action type port ID

2021-10-20 Thread psatheesh
From: Satheesh Paul This patch adds support for rte flow action type port_id to enable directing packets from an input port PF to an output port which is a VF of the input port PF. Signed-off-by: Satheesh Paul --- doc/guides/nics/cnxk.rst | 5 + doc/guides/nics/features/cnxk.ini

[dpdk-dev] [PATCH v2 1/2] common/cnxk: add support for rte flow port ID action type

2021-10-20 Thread psatheesh
From: Satheesh Paul This patch adds ROC API to support rte flow port ID action type. Signed-off-by: Satheesh Paul --- drivers/common/cnxk/roc_npc.c | 35 + drivers/common/cnxk/roc_npc.h | 9 + drivers/common/cnxk/version.map | 1 + 3 files changed,

[dpdk-dev] [PATCH v6 5/5] net/enetfec: add features

2021-10-20 Thread Apeksha Gupta
This patch adds checksum and VLAN offloads in enetfec network poll mode driver. Signed-off-by: Sachin Saxena Signed-off-by: Apeksha Gupta --- doc/guides/nics/enetfec.rst | 2 ++ doc/guides/nics/features/enetfec.ini | 3 ++ drivers/net/enetfec/enet_ethdev.c| 17 - drivers/

[dpdk-dev] [PATCH v6 4/5] net/enetfec: add enqueue and dequeue support

2021-10-20 Thread Apeksha Gupta
This patch adds burst enqueue and dequeue operations to the enetfec PMD. Loopback mode is also added, compile time flag 'ENETFEC_LOOPBACK' is used to enable this feature. By default loopback mode is disabled. Basic features added like promiscuous enable, basic stats. Signed-off-by: Sachin Saxena

[dpdk-dev] [PATCH v6 3/5] net/enetfec: support queue configuration

2021-10-20 Thread Apeksha Gupta
This patch adds Rx/Tx queue configuration setup operations. On packet reception the respective BD Ring status bit is set which is then used for packet processing. Signed-off-by: Sachin Saxena Signed-off-by: Apeksha Gupta --- drivers/net/enetfec/enet_ethdev.c | 230 +-

[dpdk-dev] [PATCH v6 2/5] net/enetfec: add UIO support

2021-10-20 Thread Apeksha Gupta
Implemented the fec-uio driver in kernel. enetfec PMD uses UIO interface to interact with "fec-uio" driver implemented in kernel for PHY initialisation and for mapping the allocated memory of register & BD from kernel to DPDK which gives access to non-cacheable memory for BD. Signed-off-by: Sachin

[dpdk-dev] [PATCH v6 1/5] net/enetfec: introduce NXP ENETFEC driver

2021-10-20 Thread Apeksha Gupta
ENETFEC (Fast Ethernet Controller) is a network poll mode driver for NXP SoC i.MX 8M Mini. This patch adds skeleton for enetfec driver with probe function. Signed-off-by: Sachin Saxena Signed-off-by: Apeksha Gupta --- v6: - Fix document build errors --- --- MAINTAINERS

[dpdk-dev] [PATCH v6 0/5] drivers/net: add NXP ENETFEC driver

2021-10-20 Thread Apeksha Gupta
This patch series introduce the enetfec driver, ENETFEC (Fast Ethernet Controller) is a network poll mode driver for the inbuilt NIC found in the NXP i.MX 8M Mini SoC. An overview of the enetfec driver with probe and remove are in patch 1. Patch 2 design UIO interface so that user space directly c

Re: [dpdk-dev] [PATCH v11 7/7] app/testpmd: add forwarding engine for shared Rx queue

2021-10-20 Thread Xueming(Steven) Li
On Wed, 2021-10-20 at 21:20 +0200, Thomas Monjalon wrote: > 20/10/2021 09:53, Xueming Li: > > To support shared Rx queue, this patch introduces dedicate forwarding > > engine. The engine groups received packets by mbuf->port into sub-group, > > updates stream statistics and simply frees packets. >

Re: [dpdk-dev] [PATCH v11 4/7] app/testpmd: new parameter to enable shared Rx queue

2021-10-20 Thread Xueming(Steven) Li
On Wed, 2021-10-20 at 21:14 +0200, Thomas Monjalon wrote: > 20/10/2021 19:29, Ajit Khaparde: > > On Wed, Oct 20, 2021 at 12:54 AM Xueming Li wrote: > > > > > > Adds "--rxq-share=X" parameter to enable shared RxQ, > > You should end the sentence here. > > > > share if device > > > supports, othe

[dpdk-dev] [PATCH] net/ice: fix function pointer in multi-process

2021-10-20 Thread dapengx . yu
From: Dapeng Yu The sharing of function pointer may cause crash of secondary process. This patch fixes it. Fixes: 7a340b0b4e03 ("net/ice: refactor Rx FlexiMD handling") Cc: sta...@dpdk.org Signed-off-by: Dapeng Yu --- drivers/net/ice/ice_rxtx.c | 35 +++ driver

Re: [dpdk-dev] [PATCH v11 7/7] app/testpmd: add forwarding engine for shared Rx queue

2021-10-20 Thread Li, Xiaoyun
> -Original Message- > From: Thomas Monjalon > Sent: Thursday, October 21, 2021 03:20 > To: Xueming Li > Cc: dev@dpdk.org; Zhang, Yuying ; Jerin Jacob > ; Yigit, Ferruh ; Andrew > Rybchenko ; Viacheslav Ovsiienko > ; Lior Margalit ; Ananyev, > Konstantin ; Ajit Khaparde > ; Li, Xiaoyun >

Re: [dpdk-dev] [PATCH v11 6/7] app/testpmd: force shared Rx queue polled on same core

2021-10-20 Thread Li, Xiaoyun
Hi > -Original Message- > From: Xueming Li > Sent: Wednesday, October 20, 2021 15:53 > To: dev@dpdk.org; Zhang, Yuying > Cc: xuemi...@nvidia.com; Jerin Jacob ; Yigit, Ferruh > ; Andrew Rybchenko > ; Viacheslav Ovsiienko > ; Thomas Monjalon ; Lior > Margalit ; Ananyev, Konstantin > ; Ajit

Re: [dpdk-dev] [PATCH v11 5/7] app/testpmd: dump port info for shared Rx queue

2021-10-20 Thread Li, Xiaoyun
> -Original Message- > From: Xueming Li > Sent: Wednesday, October 20, 2021 15:53 > To: dev@dpdk.org; Zhang, Yuying > Cc: xuemi...@nvidia.com; Jerin Jacob ; Yigit, Ferruh > ; Andrew Rybchenko > ; Viacheslav Ovsiienko > ; Thomas Monjalon ; Lior > Margalit ; Ananyev, Konstantin > ; Ajit Kha

Re: [dpdk-dev] [PATCH v11 4/7] app/testpmd: new parameter to enable shared Rx queue

2021-10-20 Thread Li, Xiaoyun
Hi > -Original Message- > From: Xueming Li > Sent: Wednesday, October 20, 2021 15:53 > To: dev@dpdk.org; Zhang, Yuying > Cc: xuemi...@nvidia.com; Jerin Jacob ; Yigit, Ferruh > ; Andrew Rybchenko > ; Viacheslav Ovsiienko > ; Thomas Monjalon ; Lior > Margalit ; Ananyev, Konstantin > ; Ajit

Re: [dpdk-dev] [PATCH v11 3/7] app/testpmd: dump device capability and Rx domain info

2021-10-20 Thread Li, Xiaoyun
> -Original Message- > From: Xueming Li > Sent: Wednesday, October 20, 2021 15:53 > To: dev@dpdk.org; Zhang, Yuying > Cc: xuemi...@nvidia.com; Jerin Jacob ; Yigit, Ferruh > ; Andrew Rybchenko > ; Viacheslav Ovsiienko > ; Thomas Monjalon ; Lior > Margalit ; Ananyev, Konstantin > ; Ajit Kha

Re: [dpdk-dev] [PATCH v4] net/e1000: build on Windows

2021-10-20 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of William Tu > Sent: Wednesday, October 20, 2021 11:48 AM > To: dev@dpdk.org > Cc: Wang, Haiyue ; Kadam, Pallavi > ; Dmitry Kozlyuk > Subject: [dpdk-dev] [PATCH v4] net/e1000: build on Windows > > This patch enables building the e1000 driver

Re: [dpdk-dev] [PATCH v2] net/ixgbe: initialize port even if mtu config fails

2021-10-20 Thread Zhang, Qi Z
> -Original Message- > From: Wang, Haiyue > Sent: Thursday, October 21, 2021 9:14 AM > To: Tudor Cornea ; Zhang, Qi Z > > Cc: Zhang, AlvinX ; Yigit, Ferruh > ; dev@dpdk.org > Subject: RE: [PATCH v2] net/ixgbe: initialize port even if mtu config fails > > > -Original Message- >

Re: [dpdk-dev] [PATCH V3] ethdev: fix eth device released repeatedly

2021-10-20 Thread lihuisong (C)
在 2021/10/19 21:09, Ferruh Yigit 写道: On 10/15/2021 4:44 AM, Huisong Li wrote: In secondary process, rte_eth_dev_close() doesn't clear eth_dev->data. If calling rte_dev_remove() after rte_eth_dev_close(), in rte_eth_dev_pci_generic_remove() function, the released eth device still can be found

[dpdk-dev] [PATCH V4] ethdev: fix eth device released repeatedly

2021-10-20 Thread Huisong Li
In secondary process, rte_eth_dev_close() doesn't clear eth_dev->data. If calling rte_dev_remove() after rte_eth_dev_close(), in rte_eth_dev_pci_generic_remove() function, the released eth device still can be found by its name in shared memory. As a result, the eth device will be released repeatedl

Re: [dpdk-dev] [PATCH] net/hns3: add runtime config to set MBX limit time

2021-10-20 Thread Min Hu (Connor)
Hi, Ferruh, 在 2021/9/9 21:20, Ferruh Yigit 写道: On 8/30/2021 4:48 AM, Min Hu (Connor) wrote: From: Chengchang Tang Current, the max waiting time for MBX response is 500ms, but in some scenarios, it is not enough. Since it depends on the response of the kernel mode driver, and its response time

[dpdk-dev] [PATCH v2] net/hns3: add runtime config to set MBX limit time

2021-10-20 Thread Min Hu (Connor)
From: Chengchang Tang Current, the max waiting time for MBX response is 500ms, but in some scenarios, it is not enough. Since it depends on the response of the kernel mode driver, and its response time is related to the scheduling of the system. In this special scenario, most of the cores are iso

Re: [dpdk-dev] [PATCH v6 2/3] net/iavf: support PPPoL2TPv2oUDP RSS Hash

2021-10-20 Thread Xing, Beilei
> -Original Message- > From: Wang, Jie1X > Sent: Wednesday, October 20, 2021 5:32 PM > To: dev@dpdk.org > Cc: or...@nvidia.com; Yigit, Ferruh ; > tho...@monjalon.net; andrew.rybche...@oktetlabs.ru; Li, Xiaoyun > ; Yang, SteveX ; Wu, Jingjing > ; Xing, Beilei ; Wu, Wenjun1 > ; Zhang, Qi

Re: [dpdk-dev] [PATCH v2] ethdev: fix one MAC address occupies two index in mac addrs

2021-10-20 Thread lihuisong (C)
在 2021/10/21 0:32, Ferruh Yigit 写道: On 10/20/2021 11:15 AM, Kevin Traynor wrote: On 20/10/2021 08:41, Ferruh Yigit wrote: On 10/20/2021 7:49 AM, lihuisong (C) wrote: Hi Ferruh 在 2021/10/20 1:45, Ferruh Yigit 写道: On 10/11/2021 10:28 AM, Min Hu (Connor) wrote: From: Huisong Li The dev->da

Re: [dpdk-dev] [PATCH v2] net/ixgbe: initialize port even if mtu config fails

2021-10-20 Thread Wang, Haiyue
> -Original Message- > From: Tudor Cornea > Sent: Thursday, October 21, 2021 02:14 > To: Zhang, Qi Z > Cc: Wang, Haiyue ; Zhang, AlvinX > ; Yigit, Ferruh > ; dev@dpdk.org; Tudor Cornea > Subject: [PATCH v2] net/ixgbe: initialize port even if mtu config fails > > On a VMware ESXi 6.0 se

Re: [dpdk-dev] [PATCH v7 4/6] ethdev: remove jumbo offload flag

2021-10-20 Thread Thomas Monjalon
18/10/2021 15:48, Ferruh Yigit: > Removing 'DEV_RX_OFFLOAD_JUMBO_FRAME' offload flag. [...] > --- a/doc/guides/nics/features.rst > +++ b/doc/guides/nics/features.rst > @@ -165,8 +165,7 @@ Jumbo frame > > Supports Rx jumbo frames. > > -* **[uses]rte_eth_rxconf,rte_eth_rxmode**: > ``offload

Re: [dpdk-dev] [PATCH] net/mlx5: fix RxQ resource cleanup

2021-10-20 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Dmitry Kozlyuk > Sent: Monday, October 18, 2021 8:25 PM > To: dev@dpdk.org > Cc: Michael Baum ; sta...@dpdk.org; Matan > Azrad ; Viacheslav Ovsiienko > > Subject: [dpdk-dev] [PATCH] net/mlx5: fix RxQ resource cleanup > > mlx5_rxq_start()

Re: [dpdk-dev] [PATCH] net/mlx5: fix the RSS consistency check of meter policy

2021-10-20 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Bing Zhao > Sent: Monday, October 18, 2021 4:16 PM > To: Slava Ovsiienko ; Matan Azrad > > Cc: dev@dpdk.org; Raslan Darawsheh ; > sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix the RSS consistency check of meter policy > > After yellow color actions in

Re: [dpdk-dev] [PATCH] net/mlx5: fix meter yellow policy with RSS action

2021-10-20 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Bing Zhao > Sent: Monday, October 18, 2021 4:19 PM > To: Slava Ovsiienko ; Matan Azrad > > Cc: dev@dpdk.org; Raslan Darawsheh ; > sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix meter yellow policy with RSS action > > The RSS configuration in a policy a

Re: [dpdk-dev] [PATCH] ring: fix size of name array in ring structure

2021-10-20 Thread Ananyev, Konstantin
> > Use correct define for the name array size. The change breaks ABI and > hence cannot be backported to stable branches. > > Fixes: 38c9817ee1d8 ("mempool: adjust name size in related data types") > Cc: zoltan.k...@schaman.hu > > Signed-off-by: Honnappa Nagarahalli > --- > lib/ring/rte_rin

Re: [dpdk-dev] [PATCH v3 3/6] net: advertise no support for keeping flow rules

2021-10-20 Thread Dmitry Kozlyuk
> > diff --git a/drivers/net/bnxt/bnxt_ethdev.c > b/drivers/net/bnxt/bnxt_ethdev.c > > index aa7e7fdc85..1a6e0128ff 100644 > > --- a/drivers/net/bnxt/bnxt_ethdev.c > > +++ b/drivers/net/bnxt/bnxt_ethdev.c > > @@ -1009,6 +1009,7 @@ static int bnxt_dev_info_get_op(struct rte_eth_dev > *eth_dev, > >

[dpdk-dev] [PATCH v15 12/12] MAINTAINERS: add entry for new packet capture features

2021-10-20 Thread Stephen Hemminger
Since the packet capture is just extension of existing pdump; add myself as maintainer of that. Signed-off-by: Stephen Hemminger --- MAINTAINERS | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 629ec107cfed..5d8c9641103b 100644 --- a

[dpdk-dev] [PATCH v15 11/12] doc: changes for new pcapng and dumpcap utility

2021-10-20 Thread Stephen Hemminger
Describe the new packet capture library and utility. Fix the title line on the pdump documentation. Signed-off-by: Stephen Hemminger Acked-by: Reshma Pattan --- doc/api/doxy-api-index.md | 1 + doc/api/doxy-api.conf.in | 1 + .../howto/img/packet_captu

[dpdk-dev] [PATCH v15 10/12] test: enable bpf autotest

2021-10-20 Thread Stephen Hemminger
The BPF autotest is defined but not run automatically. Since it is short, it should be added to the autotest suite. Signed-off-by: Stephen Hemminger Acked-by: Konstantin Ananyev --- app/test/meson.build | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/test/meson.build b/app/test/meson.

[dpdk-dev] [PATCH v15 09/12] test: add a test for pcapng library

2021-10-20 Thread Stephen Hemminger
Simple unit test that created pcapng file using API. To run this test you need to have at least one device. For example: DPDK_TEST=pcapng_autotest ./build/app/test/dpdk-test -l 0-15 \ --no-huge -m 2048 --vdev=net_tap,iface=dummy Signed-off-by: Stephen Hemminger --- app/test/meson.build |

[dpdk-dev] [PATCH v15 08/12] test: add test for bpf_convert

2021-10-20 Thread Stephen Hemminger
Add some functional tests for the Classic BPF to DPDK BPF converter. Signed-off-by: Stephen Hemminger --- app/test/test_bpf.c | 200 1 file changed, 200 insertions(+) diff --git a/app/test/test_bpf.c b/app/test/test_bpf.c index 7fcf92e716fe..ef861d05

[dpdk-dev] [PATCH v15 07/12] app/dumpcap: add new packet capture application

2021-10-20 Thread Stephen Hemminger
This is a new packet capture application to replace existing pdump. The new application works like Wireshark dumpcap program and supports the pdump API features. It is not complete yet some features such as filtering are not implemented. Signed-off-by: Stephen Hemminger --- app/dumpcap/main.c

[dpdk-dev] [PATCH v15 06/12] pdump: support pcapng and filtering

2021-10-20 Thread Stephen Hemminger
This enhances the DPDK pdump library to support new pcapng format and filtering via BPF. The internal client/server protocol is changed to support two versions: the original pdump basic version and a new pcapng version. The internal version number (not part of exposed API or ABI) is intentionally

[dpdk-dev] [PATCH v15 05/12] bpf: add function to dump eBPF instructions

2021-10-20 Thread Stephen Hemminger
When debugging converted (and other) programs it is useful to see disassembled eBPF output. Signed-off-by: Stephen Hemminger Acked-by: Konstantin Ananyev --- lib/bpf/bpf_dump.c | 139 lib/bpf/meson.build | 1 + lib/bpf/rte_bpf.h | 14 + lib

[dpdk-dev] [PATCH v15 04/12] bpf: add function to convert classic BPF to DPDK BPF

2021-10-20 Thread Stephen Hemminger
The pcap library emits classic BPF (32 bit) and is useful for creating filter programs. The DPDK BPF library only implements extended BPF (eBPF). Add an function to convert from old to new. The rte_bpf_convert function uses rte_malloc to put the resulting program in hugepage shared memory so it

[dpdk-dev] [PATCH v15 03/12] bpf: allow self-xor operation

2021-10-20 Thread Stephen Hemminger
Some BPF programs may use XOR of a register with itself as a way to zero register in one instruction. The BPF filter converter generates this in the prolog to the generated code. The BPF validator would not allow this because the value of register was undefined. But after this operation it always

[dpdk-dev] [PATCH v15 02/12] librte_pcapng: add new library for writing pcapng files

2021-10-20 Thread Stephen Hemminger
This is utility library for writing pcapng format files used by Wireshark family of utilities. Older tcpdump also knows how to read (but not write) this format. See https://github.com/pcapng/pcapng/ Signed-off-by: Stephen Hemminger Acked-by: Reshma Pattan --- lib/meson.build | 1

[dpdk-dev] [PATCH v15 01/12] lib: pdump is not supported on Windows

2021-10-20 Thread Stephen Hemminger
The current version of the pdump library was building on Windows, but it was useless since the pdump utility was not being built and Windows does not have multi-process support. The new version of pdump with filtering now has dependency on bpf. But bpf library is not available on Windows. Signed-

[dpdk-dev] [PATCH v15 00/12] Packet capture framework update

2021-10-20 Thread Stephen Hemminger
This patch set is a more complete version of the the enhanced packet capture support described last year. The new capture library and utility are: - faster avoids lots of extra I/O, does bursting, etc. - gives more information (multiple ports, queues, etc) - has a better user interface (same

Re: [dpdk-dev] [PATCH v11 4/7] app/testpmd: new parameter to enable shared Rx queue

2021-10-20 Thread Ajit Khaparde
On Wed, Oct 20, 2021 at 12:54 AM Xueming Li wrote: > > Adds "--rxq-share=X" parameter to enable shared RxQ, share if device > supports, otherwise fallback to standard RxQ. > > Share group number grows per X ports. X defaults to MAX, implies all > ports join share group 1. Queue ID is mapped equall

Re: [dpdk-dev] [PATCH v11 2/7] ethdev: new API to resolve device capability name

2021-10-20 Thread Ajit Khaparde
On Wed, Oct 20, 2021 at 3:52 AM Andrew Rybchenko wrote: > > On 10/20/21 10:53 AM, Xueming Li wrote: > > This patch adds API to return name of device capability. > > > > Signed-off-by: Xueming Li > > Reviewed-by: Andrew Rybchenko Acked-by: Ajit Khaparde >

Re: [dpdk-dev] [PATCH v11 1/7] ethdev: introduce shared Rx queue

2021-10-20 Thread Ajit Khaparde
On Wed, Oct 20, 2021 at 12:54 AM Xueming Li wrote: > > In current DPDK framework, each Rx queue is pre-loaded with mbufs to > save incoming packets. For some PMDs, when number of representors scale > out in a switch domain, the memory consumption became significant. > Polling all ports also leads

Re: [dpdk-dev] [dpdk-stable] [PATCH] test/bpf: fix auto-test with clang fails

2021-10-20 Thread Stephen Hemminger
On Wed, 20 Oct 2021 20:46:31 +0200 David Marchand wrote: > On Mon, Oct 18, 2021 at 5:59 PM Stephen Hemminger > wrote: > > Konstantin Ananyev wrote: > > > test_shift1_check() function fails with clang build. > > > The reason for that is that clang uses 64-bit shift instruction for > > > what e

Re: [dpdk-dev] [PATCH v3] test/hash: fix buffer overflow

2021-10-20 Thread Wang, Yipeng1
> -Original Message- > From: David Marchand > Sent: Wednesday, October 20, 2021 12:54 PM > To: Wang, Yipeng1 ; Gobriel, Sameh > ; Richardson, Bruce > > Cc: dev ; dpdk stable ; Medvedkin, > Vladimir > Subject: Re: [PATCH v3] test/hash: fix buffer overflow > > On Tue, Oct 19, 2021 at 5:58

Re: [dpdk-dev] [PATCH v2] hash: promote APIs to stable

2021-10-20 Thread Wang, Yipeng1
> -Original Message- > From: Honnappa Nagarahalli > Sent: Wednesday, October 20, 2021 12:45 PM > To: David Marchand ; Wang, Yipeng1 > ; Medvedkin, Vladimir > > Cc: dev ; Ray Kinsella ; Stephen > Hemminger ; Dharmik Thakkar > ; nd ; Gobriel, Sameh > ; Richardson, Bruce > ; nd > Subject: R

Re: [dpdk-dev] [PATCH v3 00/10] ethdev: cosmetic fixes

2021-10-20 Thread Ferruh Yigit
On 10/20/2021 1:47 PM, Andrew Rybchenko wrote: Sicne rte_eth_dev and rte_eth_dev_data structures are just moved right now is a good chance to make a cleanup. Moreover ethdev is or will be shuffled a lot in the release, so do cleanup in all files. Maybe at least some fixes from below could be acc

Re: [dpdk-dev] [PATCH v5 11/14] eventdev: move timer adapters memory to hugepage

2021-10-20 Thread Carrillo, Erik G
Hi Pavan and Jerin, > -Original Message- > From: pbhagavat...@marvell.com > Sent: Monday, October 18, 2021 6:36 PM > To: jer...@marvell.com; Carrillo, Erik G > Cc: dev@dpdk.org; Pavan Nikhilesh > Subject: [dpdk-dev] [PATCH v5 11/14] eventdev: move timer adapters > memory to hugepage >

[dpdk-dev] [PATCH] eventdev: fix free of adapters storage

2021-10-20 Thread Erik Gabriel Carrillo
Fix a typo that can cause the hugepage memory that backs the adapters array to be freed unexpectedly. Fixes: e9caa6a09a "eventdev: move timer adapters memory to hugepage") Signed-off-by: Erik Gabriel Carrillo --- lib/eventdev/rte_event_timer_adapter.c | 2 +- 1 file changed, 1 insertion(+), 1 d

Re: [dpdk-dev] [PATCH] lpm: fix buffer overflow

2021-10-20 Thread David Marchand
Hello Vladimir, On Fri, Oct 8, 2021 at 11:29 PM Vladimir Medvedkin wrote: > > This patch fixes buffer overflow reported by ASAN, > please reference https://bugs.dpdk.org/show_bug.cgi?id=819 > > The rte_lpm6 keeps routing information for control plane purpose > inside the rte_hash table which uses

Re: [dpdk-dev] [PATCH v3] test/hash: fix buffer overflow

2021-10-20 Thread David Marchand
On Tue, Oct 19, 2021 at 5:58 PM Medvedkin, Vladimir wrote: > > I am not against the fix, but it seems to test something different > > than what an application using the hash library would do. > > Or if an application directly calls this hash function, maybe the unit > > test should not test it via

[dpdk-dev] [PATCH v5 1/3] devargs: support path value for global device arguments

2021-10-20 Thread Xueming Li
Slash is used to split global device arguments. To support path value which contains slash, this patch parses devargs by locating both slash and layer name key: bus=a,name=/some/path/class=b,k1=v1/driver=c,k2=v2 "/class=" and "/driver" are valid start of a layer. Signed-off-by: Xueming Li Revi

[dpdk-dev] [PATCH v5 3/3] test/devargs: add devargs test cases

2021-10-20 Thread Xueming Li
Initial version to test global devargs syntax. Signed-off-by: Xueming Li --- app/test/meson.build| 2 + app/test/test_devargs.c | 214 2 files changed, 216 insertions(+) create mode 100644 app/test/test_devargs.c diff --git a/app/test/meson.build

[dpdk-dev] [PATCH v5 2/3] devargs: make bus key parsing optional

2021-10-20 Thread Xueming Li
Global devargs syntax is used as device iteration filter like "class=vdpa", a devargs without bus args is valid from parsing perspective. This patch makes bus args optional. Fixes: d2a66ad79480 ("bus: add device arguments name parsing") Signed-off-by: Xueming Li Reviewed-by: Gaetan Rivet ---

[dpdk-dev] [PATCH v5 0/3] devargs: support path in global syntax

2021-10-20 Thread Xueming Li
- Support path in global syntax. - Fix bus name resolving - Add devargs test cases v1: initial version v2: - add test cases to test suite - add more test cases, verify device name, bus name and class name v3: - remove autotest_data.py v4: - make devargs test depends on virtio driver v5: - use

Re: [dpdk-dev] [PATCH v2] hash: promote APIs to stable

2021-10-20 Thread Honnappa Nagarahalli
> > On Fri, Oct 15, 2021 at 4:27 AM Honnappa Nagarahalli > wrote: > > > > Promote APIs to stable. > > > > Signed-off-by: Honnappa Nagarahalli > > Reviewed-by: Dharmik Thakkar > > --- > > v2: > > 1) Removed EXPERIMENTAL warning in comments > > 2) Promoted all the APIs except rte_thash_*** APIs

Re: [dpdk-dev] [PATCH] usertools/pmdinfo: fix plugin auto scan

2021-10-20 Thread Robin Jarry
Hello, 2021-10-19, David Marchand: > Migration to argparse was incomplete. > > $ dpdk-pmdinfo.py -p $(which dpdk-testpmd) > Traceback (most recent call last): > File "/usr/bin/dpdk-pmdinfo.py", line 626, in > main() > File "/usr/bin/dpdk-pmdinfo.py", line 596, in main > exit(scan_for

Re: [dpdk-dev] [PATCH v3 6/8] cryptodev: rework session framework

2021-10-20 Thread Ananyev, Konstantin
Hi Akhil, > As per current design, rte_cryptodev_sym_session_create() and > rte_cryptodev_sym_session_init() use separate mempool objects > for a single session. > And structure rte_cryptodev_sym_session is not directly used > by the application, it may cause ABI breakage if the structure > is

Re: [dpdk-dev] [PATCH v2] hash: promote APIs to stable

2021-10-20 Thread David Marchand
On Fri, Oct 15, 2021 at 4:27 AM Honnappa Nagarahalli wrote: > > Promote APIs to stable. > > Signed-off-by: Honnappa Nagarahalli > Reviewed-by: Dharmik Thakkar > --- > v2: > 1) Removed EXPERIMENTAL warning in comments > 2) Promoted all the APIs except rte_thash_*** APIs Yipeng, Vladimir, Are we

Re: [dpdk-dev] [PATCH v11 7/7] app/testpmd: add forwarding engine for shared Rx queue

2021-10-20 Thread Thomas Monjalon
20/10/2021 09:53, Xueming Li: > To support shared Rx queue, this patch introduces dedicate forwarding > engine. The engine groups received packets by mbuf->port into sub-group, > updates stream statistics and simply frees packets. Given this engine is mentioned in previous commits, shouldn't it be

[dpdk-dev] [PATCH v8 3/4] app/testpmd: add dedicated flow command parsing routine

2021-10-20 Thread Viacheslav Ovsiienko
From: Gregory Etelson testpmd flow creation is constructed from these procedures: 1. receive string with flow rule description; 2. parse input string and build flow parameters: port_id value, flow attributes, items array, actions array; 3. create a flow rule from flow rule parameters.

[dpdk-dev] [PATCH v8 2/4] ethdev: introduce configurable flexible item

2021-10-20 Thread Viacheslav Ovsiienko
1. Introduction and Retrospective Nowadays the networks are evolving fast and wide, the network structures are getting more and more complicated, the new application areas are emerging. To address these challenges the new network protocols are continuously being developed, considered by technical

[dpdk-dev] [PATCH v8 4/4] app/testpmd: add flex item CLI commands

2021-10-20 Thread Viacheslav Ovsiienko
From: Gregory Etelson Network port hardware is shipped with fixed number of supported network protocols. If application must work with a protocol that is not included in the port hardware by default, it can try to add the new protocol to port hardware. Flex item or flex parser is port infrastruc

[dpdk-dev] [PATCH v8 1/4] ethdev: support flow elements with variable length

2021-10-20 Thread Viacheslav Ovsiienko
From: Gregory Etelson Flow API provides RAW item type for packet patterns of variable length. The RAW item structure has fixed size members that describe the variable pattern length and methods to process it. There is the new Flow items with variable lengths coming - flex item. In order to handl

[dpdk-dev] [PATCH v8 0/4] ethdev: introduce configurable flexible item

2021-10-20 Thread Viacheslav Ovsiienko
1. Introduction and Retrospective Nowadays the networks are evolving fast and wide, the network structures are getting more and more complicated, the new application areas are emerging. To address these challenges the new network protocols are continuously being developed, considered by technical

Re: [dpdk-dev] [PATCH v11 4/7] app/testpmd: new parameter to enable shared Rx queue

2021-10-20 Thread Thomas Monjalon
20/10/2021 19:29, Ajit Khaparde: > On Wed, Oct 20, 2021 at 12:54 AM Xueming Li wrote: > > > > Adds "--rxq-share=X" parameter to enable shared RxQ, You should end the sentence here. > > share if device > > supports, otherwise fallback to standard RxQ. > > > > Share group number grows per X ports.

[dpdk-dev] [PATCH v7 4/4] app/testpmd: add flex item CLI commands

2021-10-20 Thread Viacheslav Ovsiienko
From: Gregory Etelson Network port hardware is shipped with fixed number of supported network protocols. If application must work with a protocol that is not included in the port hardware by default, it can try to add the new protocol to port hardware. Flex item or flex parser is port infrastruc

[dpdk-dev] [PATCH v7 2/4] ethdev: introduce configurable flexible item

2021-10-20 Thread Viacheslav Ovsiienko
1. Introduction and Retrospective Nowadays the networks are evolving fast and wide, the network structures are getting more and more complicated, the new application areas are emerging. To address these challenges the new network protocols are continuously being developed, considered by technical

[dpdk-dev] [PATCH v7 3/4] app/testpmd: add dedicated flow command parsing routine

2021-10-20 Thread Viacheslav Ovsiienko
From: Gregory Etelson testpmd flow creation is constructed from these procedures: 1. receive string with flow rule description; 2. parse input string and build flow parameters: port_id value, flow attributes, items array, actions array; 3. create a flow rule from flow rule parameters.

[dpdk-dev] [PATCH v7 0/4] ethdev: introduce configurable flexible item

2021-10-20 Thread Viacheslav Ovsiienko
1. Introduction and Retrospective Nowadays the networks are evolving fast and wide, the network structures are getting more and more complicated, the new application areas are emerging. To address these challenges the new network protocols are continuously being developed, considered by technical

[dpdk-dev] [PATCH v7 1/4] ethdev: support flow elements with variable length

2021-10-20 Thread Viacheslav Ovsiienko
Flow API provides RAW item type for packet patterns of variable length. The RAW item structure has fixed size members that describe the variable pattern length and methods to process it. There is the new Flow items with variable lengths coming - flex item. In order to handle this item (and potenti

[dpdk-dev] [Bug 831] Investigate unreferenced unit tests

2021-10-20 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=831 Bug ID: 831 Summary: Investigate unreferenced unit tests Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Pr

Re: [dpdk-dev] [dpdk-stable] [PATCH] test/bpf: fix auto-test with clang fails

2021-10-20 Thread David Marchand
On Mon, Oct 18, 2021 at 5:59 PM Stephen Hemminger wrote: > Konstantin Ananyev wrote: > > test_shift1_check() function fails with clang build. > > The reason for that is that clang uses 64-bit shift instruction for > > what expected to be 32-bit operation. > > To be more specific, this C code: > >

Re: [dpdk-dev] [PATCH v11 2/7] ethdev: new API to resolve device capability name

2021-10-20 Thread Thomas Monjalon
20/10/2021 09:53, Xueming Li: > This patch adds API to return name of device capability. > > Signed-off-by: Xueming Li The title of this patch should be: "ethdev: get device capability name as string" Acked-by: Thomas Monjalon

Re: [dpdk-dev] [PATCH 1/2] common/cnxk: add support for rte flow port ID action type

2021-10-20 Thread Jerin Jacob
On Tue, Oct 5, 2021 at 9:00 AM wrote: > > From: Satheesh Paul > > This patch adds ROC API to support rte flow port ID action type. > > Signed-off-by: Satheesh Paul Could you rebase this series to next-net-mrvl > --- > drivers/common/cnxk/roc_npc.c | 35 + >

[dpdk-dev] [pull-request] dpdk-next-eventdev - v21.11 - RC1

2021-10-20 Thread Jerin Jacob Kollanukkaran
The following changes since commit ed77b8d1ef78c8cb28438ae67d1d15a01746d228:   app/crypto-perf: support lookaside IPsec (2021-10-20 11:15:29 +0200) are available in the Git repository at:   http://dpdk.org/git/next/dpdk-next-eventdev for you to fetch changes up to c8a515c247a097f2ec6e7a2945970a

  1   2   3   4   >