20/10/2021 19:29, Ajit Khaparde:
> On Wed, Oct 20, 2021 at 12:54 AM Xueming Li <xuemi...@nvidia.com> wrote:
> >
> > Adds "--rxq-share=X" parameter to enable shared RxQ,
You should end the sentence here.
> > share if device
> > supports, otherwise fallback to standard RxQ.
> >
> > Share group number grows per X ports.
Do you mean "Shared queues are grouped per X ports." ?
> > X defaults to MAX, implies all
> > ports join share group 1. Queue ID is mapped equally with shared Rx
> > queue ID.
> >
> > Forwarding engine "shared-rxq" should be used which Rx only and update
> > stream statistics correctly.
I suggest this wording:
"
A new forwarding engine "shared-rxq" should be used for shared Rx queues.
This engine does Rx only and update stream statistics accordingly.
"
> > Signed-off-by: Xueming Li <xuemi...@nvidia.com>
[...]
> + printf(" --rxq-share: number of ports per shared rxq groups, defaults
> to MAX(1 group)\n");
rxq -> Rx queue
Is MAX a special value? or should it be "all queues"?
Note: space is missing before the parenthesis.
[...]
> > +* ``--rxq-share=[X]``
> > +
> > + Create queues in shared Rx queue mode if device supports.
> > + Group number grows per X ports.
Again I suggest "Shared queues are grouped per X ports."
> > + X defaults to MAX, implies all ports
> > + join share group 1. Forwarding engine "shared-rxq" should be used
> > + which Rx only and update stream statistics correctly.
>
> Did you mean "with Rx only"?
> Something like this?
> "shared-rxq" should be used in Rx only mode.
>
> If you say - "the Forwarding engine should update stream statistics
> correctly",
> I think that is expected anyway? So there is no need to mention that
> in the guide.
I suggested a wording above.
