> -----Original Message-----
> From: Thomas Monjalon <tho...@monjalon.net>
> Sent: Thursday, October 21, 2021 03:20
> To: Xueming Li <xuemi...@nvidia.com>
> Cc: dev@dpdk.org; Zhang, Yuying <yuying.zh...@intel.com>; Jerin Jacob
> <jerinjac...@gmail.com>; Yigit, Ferruh <ferruh.yi...@intel.com>; Andrew
> Rybchenko <andrew.rybche...@oktetlabs.ru>; Viacheslav Ovsiienko
> <viachesl...@nvidia.com>; Lior Margalit <lmarga...@nvidia.com>; Ananyev,
> Konstantin <konstantin.anan...@intel.com>; Ajit Khaparde
> <ajit.khapa...@broadcom.com>; Li, Xiaoyun <xiaoyun...@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v11 7/7] app/testpmd: add forwarding engine
> for shared Rx queue
>
> 20/10/2021 09:53, Xueming Li:
> > To support shared Rx queue, this patch introduces dedicate forwarding
> > engine. The engine groups received packets by mbuf->port into
> > sub-group, updates stream statistics and simply frees packets.
>
> Given this engine is mentioned in previous commits, shouldn't it be placed
> earlier
> in the series?
>
> > +#include <stdarg.h>
> > +#include <string.h>
> > +#include <stdio.h>
> > +#include <errno.h>
> > +#include <stdint.h>
> > +#include <unistd.h>
> > +#include <inttypes.h>
> > +
> > +#include <sys/queue.h>
> > +#include <sys/stat.h>
> > +
> > +#include <rte_common.h>
> > +#include <rte_byteorder.h>
> > +#include <rte_log.h>
> > +#include <rte_debug.h>
> > +#include <rte_cycles.h>
> > +#include <rte_memory.h>
> > +#include <rte_memcpy.h>
> > +#include <rte_launch.h>
> > +#include <rte_eal.h>
> > +#include <rte_per_lcore.h>
> > +#include <rte_lcore.h>
> > +#include <rte_atomic.h>
> > +#include <rte_branch_prediction.h>
> > +#include <rte_mempool.h>
> > +#include <rte_mbuf.h>
> > +#include <rte_pci.h>
> > +#include <rte_ether.h>
> > +#include <rte_ethdev.h>
> > +#include <rte_string_fns.h>
> > +#include <rte_ip.h>
> > +#include <rte_udp.h>
> > +#include <rte_net.h>
> > +#include <rte_flow.h>
>
> Please do not include useless files.
+1
