Re: [dpdk-dev] [PATCH v2 7/8] net/cnxk: tm capabilities and queue rate limit handlers

2021-09-20 Thread Jerin Jacob
On Sat, Sep 18, 2021 at 8:03 PM wrote: > > From: Satha Rao > > Initial version of TM implementation added basic infrastructure, > tm node_get, capabilities operations and rate limit queue operation. > > Signed-off-by: Satha Rao tm-> TM in subject. # Could you rebase on top dpdk-next-net-mrvl.

Re: [dpdk-dev] [PATCH v2 5/8] common/cnxk: handler to get rte tm error type

2021-09-20 Thread Jerin Jacob
On Sat, Sep 18, 2021 at 8:02 PM wrote: > > From: Satha Rao > > Different TM handlers returns various platform specific errors, > this patch introduces new API to convert these internal error > types to RTE_TM* error types. > Also updated error message API with missed TM error types. Subject chan

Re: [dpdk-dev] [PATCH v2 2/8] common/cnxk: flush smq

2021-09-20 Thread Jerin Jacob
On Sat, Sep 18, 2021 at 8:02 PM wrote: > > From: Satha Rao > > Added new API to flush all SMQs related nix interface nix-> NIX Add more details in the commit log for meaning flush. Change the subject to : common/cnxk: support SMQ flush > > Signed-off-by: Satha Rao > --- > drivers/common/cnx

Re: [dpdk-dev] [PATCH v2 1/8] common/cnxk: use different macros for sdp and lbk max frames

2021-09-20 Thread Jerin Jacob
On Sat, Sep 18, 2021 at 8:02 PM wrote: > > From: Satha Rao > > For SDP interface all platforms supports up to 65535 frame size. > Updated api with new check for SDP interface. Please change the subject to common/cnxk: set appropriate max frame size for SDP and LBK or so > > Signed-off-by: Sat

Re: [dpdk-dev] [PATCH v2 0/6] mlx5: some independent fixes

2021-09-20 Thread Thomas Monjalon
12/09/2021 12:36, Michael Baum: > Some independent fixes in mlx5 net and common driver. > > v2: improve commit logs. > > Michael Baum (6): > net/mlx5: fix memory leak in the SH creation > net/mlx5: fix memory leak in PCI probe > net/mlx5: fix allow duplicate pattern devarg default > commo

Re: [dpdk-dev] I40e-dpdk_18.11-Bonding issue

2021-09-20 Thread Nishant Verma
Thanks for the reply. Actually till this time the test has not even started. I have a INTEL processor with 2 onboard nic. b5:00.0 Ethernet controller: Intel Corporation Ethernet Connection X722 for 10GbE backplane (rev 04) b5:00.1 Ethernet controller: Intel Corporation Ethernet Connection X722 for

Re: [dpdk-dev] [PATCH v9] eal: remove sys/queue.h from public headers

2021-09-20 Thread Narcisa Ana Maria Vasile
On Tue, Aug 24, 2021 at 04:21:03PM +, William Tu wrote: > Currently there are some public headers that include 'sys/queue.h', which > is not POSIX, but usually provided by the Linux/BSD system library. > (Not in POSIX.1, POSIX.1-2001, or POSIX.1-2008. Present on the BSDs.) > The file is missing

Re: [dpdk-dev] [PATCH] Enable AddressSanitizer feature on DPDK

2021-09-20 Thread David Christensen
On 9/18/21 12:21 AM, Peng, ZhihongX wrote: -Original Message- From: David Christensen Sent: Saturday, September 18, 2021 4:51 AM To: Peng, ZhihongX ; Burakov, Anatoly ; Ananyev, Konstantin ; step...@networkplumber.org Cc: dev@dpdk.org; Lin, Xueqin Subject: Re: [dpdk-dev] [PATCH] Enab

Re: [dpdk-dev] [PATCH v3] efd: change data type of parameter

2021-09-20 Thread David Christensen
On 9/17/21 5:56 AM, Pablo de Lara wrote: rte_efd_create() function was using uint8_t for a socket bitmask, for one of its parameters. This limits the maximum of NUMA sockets to be 8. Changing to uint64_t increases it to 64, which should be more future-proof. Coverity issue: 366390 Fixes: 56b6

Re: [dpdk-dev] [PATCH v2 02/15] crypto: add total raw buffer length

2021-09-20 Thread Akhil Goyal
> > > From: Gagandeep Singh > > > > The current crypto raw data vectors is extended to support > > rte_security usecases, where we need total data length to know > > how much additional memory space is available in buffer other > > than data length so that driver/HW can write expanded size > > da

Re: [dpdk-dev] [PATCH v2] net/af_packet: remove timestamp from packet status

2021-09-20 Thread Ferruh Yigit
On 9/13/2021 6:23 PM, Tudor Cornea wrote: > We should eliminate the timestamp status from the packet > status. This should only matter if timestamping is enabled > on the socket, but we might hit a kernel bug, which is fixed > in newer releases. > > For interfaces of type 'veth', the sent skb is f

Re: [dpdk-dev] [PATCH v2] net/af_packet: fix ignoring full ring on tx

2021-09-20 Thread Ferruh Yigit
On 9/13/2021 2:45 PM, Tudor Cornea wrote: > The poll call can return POLLERR which is ignored, or it can return > POLLOUT, even if there are no free frames in the mmap-ed area. > > We can account for both of these cases by re-checking if the next > frame is empty before writing into it. > > Signe

Re: [dpdk-dev] [PATCH] net/af_packet: fix ignoring full ring on tx

2021-09-20 Thread Ferruh Yigit
On 9/6/2021 11:23 AM, Tudor Cornea wrote: > Hi Ferruh, > > Would you mind separate timestamp status fix to its own patch? I think >> better to >> fix 'ignoring full Tx ring' first, to not make it dependent to timestamp >> patch. > > > Agreed. There are two issues solved by this patch. We will br

Re: [dpdk-dev] [PATCH 1/2] app/testpmd: add tunnel types

2021-09-20 Thread Ferruh Yigit
On 9/13/2021 3:25 PM, Eli Britstein wrote: > Current testpmd implementation supports VXLAN only for tunnel offload. > Add GRE, NVGRE and GENEVE for tunnel offload flow matches. > Hi Eli, I assume tunnel types are added, but forgot to add the flow tunnel support for them, so this patch is fixing

Re: [dpdk-dev] [PATCH] eal: add telemetry callbacks for memory info

2021-09-20 Thread Bruce Richardson
On Wed, Sep 15, 2021 at 03:23:36PM +0530, Harman Kalra wrote: > Registering new telemetry callbacks to dump named (memzones) > and unnamed (malloc) memory information to a file provided as > an argument. > > Example: > Connecting to /var/run/dpdk/rte/dpdk_telemetry.v2 > {"version": "DPDK 21.08.0",

Re: [dpdk-dev] [PATCH v2] net/af_packet: reinsert the stripped vlan tag

2021-09-20 Thread Ferruh Yigit
On 9/8/2021 9:59 AM, Tudor Cornea wrote: > The af_packet pmd driver binds to a raw socket and allows > sending and receiving of packets through the kernel. > > Since commit [1], the kernel strips the vlan tags early in > __netif_receive_skb_core(), so we receive untagged packets while > running wi

Re: [dpdk-dev] [PATCH V3 01/24] pipeline: move data structures to internal header file

2021-09-20 Thread Dumitrescu, Cristian
> Depends-on: series-18297 ("[V4,1/4] table: add support learner tables") Just sent an updated version for the learner table series, which does not result in any code changes for this patch set. Therefore, the updated dependency list of this patch set is: Depends-on: series-19048 ("[V5,1/4] t

Re: [dpdk-dev] [PATCH] net/memif: fix chained mbuf determination

2021-09-20 Thread Ferruh Yigit
On 9/9/2021 3:42 PM, Junxiao Shi wrote: > Previously, TX functions call rte_pktmbuf_is_contiguous to determine > whether an mbuf is chained. However, rte_pktmbuf_is_contiguous is > designed to work on the first mbuf of a packet only. In case a packet > contains three or more segment mbufs in a chai

Re: [dpdk-dev] [PATCH] net/af_xdp: fix support of secondary process

2021-09-20 Thread Loftus, Ciara
> > On Mon, 20 Sep 2021 13:23:57 + > "Loftus, Ciara" wrote: > > > > -Original Message- > > > From: dev On Behalf Of Stephen Hemminger > > > Sent: Friday 3 September 2021 17:15 > > > To: dev@dpdk.org > > > Cc: Stephen Hemminger ; > > > sta...@dpdk.org; xiaolong...@intel.com > > > Sub

[dpdk-dev] [PATCH V5 4/4] examples/pipeline: add learner table example

2021-09-20 Thread Cristian Dumitrescu
Added the files to illustrate the learner table usage. Signed-off-by: Cristian Dumitrescu --- V2: Added description to the .spec file. examples/pipeline/examples/learner.cli | 37 +++ examples/pipeline/examples/learner.spec | 127 2 files changed, 164 insertions(

[dpdk-dev] [PATCH V5 2/4] pipeline: add support for learner tables

2021-09-20 Thread Cristian Dumitrescu
Add pipeline level support for learner tables. Signed-off-by: Cristian Dumitrescu --- V2: Added more configuration consistency checks. V3: Fixed one coding style indentation error. V4: Fixed a pointer dereferencing issue in function rte_swx_ctl_pipeline_learner_stats_read(). V5: Added function

[dpdk-dev] [PATCH V5 3/4] examples/pipeline: add support for learner tables

2021-09-20 Thread Cristian Dumitrescu
Add application-level support for learner tables. Signed-off-by: Cristian Dumitrescu --- examples/pipeline/cli.c | 174 1 file changed, 174 insertions(+) diff --git a/examples/pipeline/cli.c b/examples/pipeline/cli.c index 1e2dd9d704..39b1e7a41b 100644 -

[dpdk-dev] [PATCH V5 1/4] table: add support learner tables

2021-09-20 Thread Cristian Dumitrescu
A learner table is typically used for learning or connection tracking, where it allows for the implementation of the "add on miss" scenario: whenever the lookup key is not found in the table (lookup miss), the data plane can decide to add this key to the table with a given action with no control pl

[dpdk-dev] [PATCH] net/octeontx: fix invalid access to indirect buffers

2021-09-20 Thread Harman Kalra
Issue has been observed where fields of indirect buffers are accessed after being set free by the diver. Also fixing freeing of direct buffers to correct aura. Fixes: 5cbe184802aa ("net/octeontx: support fast mbuf free") Cc: sta...@dpdk.org Signed-off-by: David George Signed-off-by: Harman Kalra

Re: [dpdk-dev] [PATCH] net/af_xdp: fix support of secondary process

2021-09-20 Thread Stephen Hemminger
On Mon, 20 Sep 2021 13:23:57 + "Loftus, Ciara" wrote: > > -Original Message- > > From: dev On Behalf Of Stephen Hemminger > > Sent: Friday 3 September 2021 17:15 > > To: dev@dpdk.org > > Cc: Stephen Hemminger ; > > sta...@dpdk.org; xiaolong...@intel.com > > Subject: [dpdk-dev] [PATCH

Re: [dpdk-dev] [RFC V2] ethdev: fix issue that dev close in PMD calls twice

2021-09-20 Thread Ferruh Yigit
On 8/25/2021 10:53 AM, Huisong Li wrote: > > 在 2021/8/24 22:42, Ferruh Yigit 写道: >> On 8/19/2021 4:45 AM, Huisong Li wrote: >>> 在 2021/8/18 19:24, Ferruh Yigit 写道: On 8/13/2021 9:16 AM, Huisong Li wrote: > 在 2021/8/13 14:12, Thomas Monjalon 写道: >> 13/08/2021 04:11, Huisong Li: >>>

[dpdk-dev] [PATCH v3 6/6] net/iavf: add watchdog for VFLR

2021-09-20 Thread Radu Nicolau
Add watchdog to iAVF PMD which support monitoring the VFLR register. If the device is not already in reset then if a VF reset in progress is detected then notfiy user through callback and set into reset state. If the device is already in reset then poll for completion of reset. Signed-off-by: Decl

[dpdk-dev] [PATCH v3 5/6] net/iavf: add xstats support for inline IPsec crypto

2021-09-20 Thread Radu Nicolau
Add per queue counters for maintaining statistics for inline IPsec crypto offload, which can be retrieved through the rte_security_session_stats_get() with more detailed errors through the rte_ethdev xstats. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau --- drivers/net/iavf/iavf.h

[dpdk-dev] [PATCH v3 4/6] net/iavf: add iAVF IPsec inline crypto support

2021-09-20 Thread Radu Nicolau
Add support for inline crypto for IPsec, for ESP transport and tunnel over IPv4 and IPv6, as well as supporting the offload for ESP over UDP, and inconjunction with TSO for UDP and TCP flows. Implement support for rte_security packet metadata Add definition for IPsec descriptors, extend support fo

[dpdk-dev] [PATCH v3 3/6] net/iavf: add support for asynchronous virt channel messages

2021-09-20 Thread Radu Nicolau
Add support for asynchronous virtual channel messages, specifically for inline IPsec messages. Signed-off-by: Declan Doherty Signed-off-by: Abhijit Sinha Signed-off-by: Radu Nicolau --- drivers/net/iavf/iavf.h | 16 drivers/net/iavf/iavf_vchnl.c | 137 +-

[dpdk-dev] [PATCH v3 2/6] net/iavf: rework tx path

2021-09-20 Thread Radu Nicolau
Rework the TX path and TX descriptor usage in order to allow for better use of oflload flags and to facilitate enabling of inline crypto offload feature. Signed-off-by: Declan Doherty Signed-off-by: Abhijit Sinha Signed-off-by: Radu Nicolau --- drivers/net/iavf/iavf_rxtx.c | 536 ++

[dpdk-dev] [PATCH v3 1/6] common/iavf: add iAVF IPsec inline crypto support

2021-09-20 Thread Radu Nicolau
Add support for inline crypto for IPsec. Signed-off-by: Declan Doherty Signed-off-by: Abhijit Sinha Signed-off-by: Radu Nicolau --- drivers/common/iavf/iavf_type.h | 215 +++- drivers/common/iavf/virtchnl.h | 17 +- drivers/common/iavf/virtchnl_inline_ipsec.h | 55

[dpdk-dev] [PATCH v3 0/6] iavf: add iAVF IPsec inline crypto support

2021-09-20 Thread Radu Nicolau
Add support for inline crypto for IPsec, for ESP transport and tunnel over IPv4 and IPv6, as well as supporting the offload for ESP over UDP, and inconjunction with TSO for UDP and TCP flows. Radu Nicolau (6): common/iavf: add iAVF IPsec inline crypto support net/iavf: rework tx path net/iav

Re: [dpdk-dev] [PATCH v4 11/11] devbind: move ioat device ID for ICX to dmadev category

2021-09-20 Thread Bruce Richardson
On Fri, Sep 17, 2021 at 03:42:27PM +, Conor Walsh wrote: > Move Intel IOAT devices on Ice Lake systems from Misc to DMA devices. > > Signed-off-by: Conor Walsh > Reviewed-by: Kevin Laatz > --- > usertools/dpdk-devbind.py | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff

Re: [dpdk-dev] [PATCH v4 10/11] dma/ioat: add burst capacity function

2021-09-20 Thread Bruce Richardson
On Fri, Sep 17, 2021 at 03:42:26PM +, Conor Walsh wrote: > Adds the ability to find the remaining space in the IOAT ring. > > Signed-off-by: Conor Walsh > Signed-off-by: Kevin Laatz > --- Acked-by: Bruce Richardson

Re: [dpdk-dev] [PATCH v4 09/11] dma/ioat: add support for vchan status function

2021-09-20 Thread Bruce Richardson
On Fri, Sep 17, 2021 at 03:42:25PM +, Conor Walsh wrote: > Add support for the rte_dmadev_vchan_status API call. > > Signed-off-by: Conor Walsh > Reviewed-by: Kevin Laatz > --- Acked-by: Bruce Richardson

Re: [dpdk-dev] [PATCH v4 08/11] dma/ioat: add statistics

2021-09-20 Thread Bruce Richardson
On Fri, Sep 17, 2021 at 03:42:24PM +, Conor Walsh wrote: > Add statistic tracking for operations in IOAT. > > Signed-off-by: Conor Walsh > Reviewed-by: Kevin Laatz > --- > doc/guides/dmadevs/ioat.rst| 23 ++ > drivers/dma/ioat/ioat_dmadev.c | 43 +

Re: [dpdk-dev] [PATCH v2 2/4] net/iavf: add iAVF IPsec inline crypto support

2021-09-20 Thread Nicolau, Radu
Hi Jingjing, thanks for reviewing! On 9/18/2021 6:28 AM, Wu, Jingjing wrote: In general, the patch is too big to review. Patch split would help a lot! I will do my best to split in in the next revision. [...] +static const struct rte_cryptodev_symmetric_capability * +get_capability(struct i

Re: [dpdk-dev] [PATCH v4 07/11] dma/ioat: add data path completion functions

2021-09-20 Thread Bruce Richardson
On Fri, Sep 17, 2021 at 03:42:23PM +, Conor Walsh wrote: > Add the data path functions for gathering completed operations > from IOAT devices. > > Signed-off-by: Conor Walsh > Signed-off-by: Kevin Laatz > --- For the code part: Acked-by: Bruce Richardson However, the docs need to be made

Re: [dpdk-dev] [PATCH v4 06/11] dma/ioat: add data path job submission functions

2021-09-20 Thread Bruce Richardson
On Fri, Sep 17, 2021 at 03:42:22PM +, Conor Walsh wrote: > Add data path functions for enqueuing and submitting operations to > IOAT devices. > > Signed-off-by: Conor Walsh > Reviewed-by: Kevin Laatz > --- > doc/guides/dmadevs/ioat.rst| 54 > drivers/dma/ioat/ioat_d

Re: [dpdk-dev] [PATCH v4 02/11] dma/ioat: create dmadev instances on PCI probe

2021-09-20 Thread Bruce Richardson
On Fri, Sep 17, 2021 at 03:42:18PM +, Conor Walsh wrote: > When a suitable device is found during the PCI probe, create a dmadev > instance for each channel. Internal structures and HW definitions required > for device creation are also included. > > Signed-off-by: Conor Walsh > Reviewed-by:

Re: [dpdk-dev] [PATCH] net/af_xdp: fix support of secondary process

2021-09-20 Thread Loftus, Ciara
> -Original Message- > From: dev On Behalf Of Stephen Hemminger > Sent: Friday 3 September 2021 17:15 > To: dev@dpdk.org > Cc: Stephen Hemminger ; > sta...@dpdk.org; xiaolong...@intel.com > Subject: [dpdk-dev] [PATCH] net/af_xdp: fix support of secondary process > > Doing basic operati

Re: [dpdk-dev] [PATCH] test/compress: fix buffer overflow bug

2021-09-20 Thread Zhang, Roy Fan
> -Original Message- > From: Troy, Rebecca > Sent: Friday, September 17, 2021 4:12 PM > To: dev@dpdk.org > Cc: Zhang, Roy Fan ; Troy, Rebecca > ; Trahe, Fiona ; Trybula, > ArturX ; sta...@dpdk.org; Ashish Gupta > > Subject: [PATCH] test/compress: fix buffer overflow bug > > Fixes stack b

[dpdk-dev] [PATCH v4 3/3] app/test: add allocator performance autotest

2021-09-20 Thread dkozlyuk
From: Dmitry Kozlyuk Memory allocator performance is crucial to applications that deal with large amount of memory or allocate frequently. DPDK allocator performance is affected by EAL options, API used and, at least, allocation size. New autotest is intended to be run with different EAL options.

[dpdk-dev] [PATCH v4 2/3] eal: add memory pre-allocation from existing files

2021-09-20 Thread dkozlyuk
From: Viacheslav Ovsiienko The primary DPDK process launch might take a long time if initially allocated memory is large. From practice allocation of 1 TB of memory over 1 GB hugepages on Linux takes tens of seconds. Fast restart is highly desired for some applications and launch delay presents a

[dpdk-dev] [PATCH v4 1/3] eal/linux: make hugetlbfs analysis reusable

2021-09-20 Thread dkozlyuk
From: Dmitry Kozlyuk get_hugepage_dir() searched for a hugetlbfs mount with a given page size using handcraft parsing of /proc/mounts and mixing traversal logic with selecting the needed entry. Separate code to enumerate hugetlbfs mounts to eal_hugepage_mount_walk() taking a callback that can ins

[dpdk-dev] [PATCH v4 0/3] eal: add memory pre-allocation from existing files

2021-09-20 Thread dkozlyuk
From: Dmitry Kozlyuk Hugepage allocation from the system takes time, resulting in slow startup or sporadic delays later. Most of the time spent in kernel is zero-filling memory for security reasons, which may be irrelevant in a controlled environment. The bottleneck is memory access speed, so for

[dpdk-dev] [PATCH v4 12/13] net/bnxt: add SRAM manager shared session

2021-09-20 Thread Venkat Duvvuru
From: Farah Smith Fix shared session support issues due to SRAM manager additions. Shared session does not support slices within RM blocks. Calculate resources required without slices and determine base addresses using old methods for the shared session. Signed-off-by: Farah Smith Reviewed-by:

[dpdk-dev] [PATCH v4 10/13] net/bnxt: change log level to debug

2021-09-20 Thread Venkat Duvvuru
From: Farah Smith Adjust info message to debug level to prevent excessive logging. Signed-off-by: Farah Smith Reviewed-by: Mike Baucom Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_core/tf_tbl_sram.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnxt/tf

[dpdk-dev] [PATCH v4 11/13] net/bnxt: dynamically allocate space for EM defrag function

2021-09-20 Thread Venkat Duvvuru
From: Randy Schacher The dynamic pool allocation defrag function currently uses stack allocation. To improve use of stack space, dynamically allocate and deallocate memory for use to defragment the dynamic pool of EM resources. Signed-off-by: Randy Schacher Reviewed-by: Peter Spreadborough Rev

[dpdk-dev] [PATCH v4 05/13] net/bnxt: add flow template support for Thor

2021-09-20 Thread Venkat Duvvuru
From: Kishore Padmanabha Template adds non-VFR based support for testpmd with: matches to include - DMAC, SIP, DIP, Proto, Sport, Dport - SIP, DIP, Proto, Sport, Dport actions: - count, drop Signed-off-by: Kishore Padmanabha Signed-off-by: Venkat Duvvuru Reviewed-by: Mike Baucom Acked-by: Aji

[dpdk-dev] [PATCH v4 03/13] net/bnxt: add flow meter drop counter support

2021-09-20 Thread Venkat Duvvuru
From: Jay Ding This patch adds flow meter drop counter support for Thor. Signed-off-by: Jay Ding Reviewed-by: Farah Smith Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_core/cfa_resource_types.h | 5 +- drivers/net/bnxt/tf_core/tf_core.h| 8 +- drivers/net/bnxt/tf_core/tf_d

[dpdk-dev] [PATCH v4 08/13] net/bnxt: add wild card TCAM byte order for Thor

2021-09-20 Thread Venkat Duvvuru
From: Kishore Padmanabha The wild card TCAM for Thor platform is different from the profile TCAM byte order. Signed-off-by: Kishore Padmanabha Signed-off-by: Venkat Duvvuru Reviewed-by: Shuanglin Wang Reviewed-by: Mike Baucom Reviewed-by: Ajit Khaparde --- .../generic_templates/ulp_templat

[dpdk-dev] [PATCH v4 04/13] net/bnxt: add SRAM manager model

2021-09-20 Thread Venkat Duvvuru
From: Farah Smith The SRAM manager supports allocation and free of variable sized records within SRAM memory. These record sizes are 8, 16, 32, or 64B. The SRAM manager algorithm will not fragment memory during run time. Previous implementation only included fixed size 64B records regardless of

[dpdk-dev] [PATCH v4 01/13] net/bnxt: updates to TF core index table

2021-09-20 Thread Venkat Duvvuru
From: Farah Smith Update the TRUFLOW core index table and remove unused shadow table functionality. Signed-off-by: Farah Smith Reviewed-by: Peter Spreadborough Acked-by: Ajit Khaparde --- drivers/net/bnxt/tf_core/tf_core.c | 65 -- drivers/net/bnxt/tf_core/tf_core.h

[dpdk-dev] [PATCH v4 00/13] enhancements to host based flow table management

2021-09-20 Thread Venkat Duvvuru
This patch set adds support for new offload features/enhancments for Thor adapters like VF representor support, new flow matches/actions & dynamic SRAM manager support. Farah Smith (4): net/bnxt: updates to TF core index table net/bnxt: add SRAM manager model net/bnxt: change log level to de

[dpdk-dev] [PATCH v4 02/13] net/bnxt: enable dpool allocator

2021-09-20 Thread Venkat Duvvuru
From: Peter Spreadborough Enable dynamic entry allocator for Exact Match SRAM entries. Deprecate static entry allocator code. Signed-off-by: Peter Spreadborough Reviewed-by: Randy Schacher Acked-by: Ajit Khaparde --- drivers/net/bnxt/tf_core/tf_device_p58.c | 4 - drivers/net/bnxt/tf_

Re: [dpdk-dev] [PATCH v2 6/6] examples/ioat: rename application to dmafwd

2021-09-20 Thread Conor Walsh
Since the APIs have been updated from rawdev to dmadev, the application should also be renamed to match. This patch also includes the documentation updates for the renaming. Signed-off-by: Kevin Laatz --- -The initialization of hardware device is done by ``rte_rawdev_configure()`` -funct

Re: [dpdk-dev] [PATCH v2 5/6] examples/ioat: update naming to match change to dmadev

2021-09-20 Thread Conor Walsh
Existing functions, structures, defines etc need to be updated to reflect the change to using the dmadev APIs. Signed-off-by: Kevin Laatz --- Reviewed-by: Conor Walsh

Re: [dpdk-dev] [PATCH v2 4/6] examples/ioat: port application to dmadev APIs

2021-09-20 Thread Conor Walsh
The dmadev library abstraction allows applications to use the same APIs for all DMA device drivers in DPDK. This patch updates the ioatfwd application to make use of the new dmadev APIs, in turn making it a generic application which can be used with any of the DMA device drivers. Signed-off-by

Re: [dpdk-dev] [PATCH v2 3/6] examples/ioat: add cmd line option to control max frame size

2021-09-20 Thread Conor Walsh
From: Konstantin Ananyev Add command line option for setting the max frame size. Signed-off-by: Konstantin Ananyev --- Reviewed-by: Conor Walsh

Re: [dpdk-dev] [PATCH v2 2/6] examples/ioat: add cmd-line option to control DMA batch size

2021-09-20 Thread Conor Walsh
From: Konstantin Ananyev Add a commandline options to control the HW copy batch size in the application. Signed-off-by: Konstantin Ananyev --- Reviewed-by: Conor Walsh

Re: [dpdk-dev] [PATCH v2 1/6] examples/ioat: always use same lcore for both DMA requests enqueue and dequeue

2021-09-20 Thread Conor Walsh
From: Konstantin Ananyev Few changes in ioat sample behaviour: - Always do SW copy for packet metadata (mbuf fields) - Always use same lcore for both DMA requests enqueue and dequeue Main reasons for that: a) it is safer, as idxd PMD doesn't support MT safe enqueue/dequeue (yet). b) sort of

Re: [dpdk-dev] [PATCH] cmdline: reduce ABI

2021-09-20 Thread Olivier Matz
Hi Dmitry, On Mon, Sep 20, 2021 at 01:11:23PM +0200, David Marchand wrote: > On Sat, Sep 11, 2021 at 1:17 AM Dmitry Kozlyuk > wrote: > > > > Remove the definition of `struct cmdline` from public header. > > Deprecation notice: > > https://mails.dpdk.org/archives/dev/2020-September/183310.html >

Re: [dpdk-dev] [PATCH v4 01/11] dma/ioat: add device probe and removal functions

2021-09-20 Thread Bruce Richardson
On Fri, Sep 17, 2021 at 03:42:17PM +, Conor Walsh wrote: > Add the basic device probe/remove skeleton code and initial documentation > for new IOAT DMA driver. Maintainers update is also included in this > patch. > > Signed-off-by: Conor Walsh > Reviewed-by: Kevin Laatz > --- > MAINTAINERS

Re: [dpdk-dev] [PATCH] cmdline: reduce ABI

2021-09-20 Thread David Marchand
On Sat, Sep 11, 2021 at 1:17 AM Dmitry Kozlyuk wrote: > > Remove the definition of `struct cmdline` from public header. > Deprecation notice: > https://mails.dpdk.org/archives/dev/2020-September/183310.html > > Signed-off-by: Dmitry Kozlyuk This patch lgtm. Acked-by: David Marchand > --- > I

Re: [dpdk-dev] [PATCH v5 16/16] devbind: move idxd device ID to dmadev class

2021-09-20 Thread Bruce Richardson
On Fri, Sep 17, 2021 at 03:24:37PM +, Kevin Laatz wrote: > The dmadev library is the preferred abstraction for using IDXD devices and > will replace the rawdev implementation in future. This patch moves the IDXD > device ID to the dmadev class. > > Signed-off-by: Kevin Laatz > Reviewed-by: Co

Re: [dpdk-dev] [PATCH v5 15/16] devbind: add dma device class

2021-09-20 Thread Bruce Richardson
On Fri, Sep 17, 2021 at 03:24:36PM +, Kevin Laatz wrote: > Add a new class for DMA devices. Devices listed under the DMA class are to > be used with the dmadev library. > > Signed-off-by: Kevin Laatz > Reviewed-by: Conor Walsh > --- One small comment below to be fixed. Reviewed-by: Bruce R

Re: [dpdk-dev] [PATCH v5 14/16] dma/idxd: move dpdk_idxd_cfg.py from raw to dma

2021-09-20 Thread Bruce Richardson
On Fri, Sep 17, 2021 at 03:24:35PM +, Kevin Laatz wrote: > From: Conor Walsh > > Move the example script for configuring IDXD devices bound to the IDXD > kernel driver from raw to dma, and create a symlink to still allow use from > raw. > > Signed-off-by: Conor Walsh > Signed-off-by: Kevin

Re: [dpdk-dev] [PATCH v5 13/16] dma/idxd: add burst capacity API

2021-09-20 Thread Bruce Richardson
On Fri, Sep 17, 2021 at 03:24:34PM +, Kevin Laatz wrote: > Add support for the burst capacity API. This API will provide the calling > application with the remaining capacity of the current burst (limited by > max HW batch size). > > Signed-off-by: Kevin Laatz > Reviewed-by: Conor Walsh > --

Re: [dpdk-dev] [PATCH v5 10/16] dma/idxd: add data-path job completion functions

2021-09-20 Thread Bruce Richardson
On Fri, Sep 17, 2021 at 03:24:31PM +, Kevin Laatz wrote: > Add the data path functions for gathering completed operations. > > Signed-off-by: Bruce Richardson > Signed-off-by: Kevin Laatz > Reviewed-by: Conor Walsh > > --- > v2: >- fixed typo in docs >- add completion status for in

Re: [dpdk-dev] [PATCH v3] devtools: add acronyms in dictionary for commit checks

2021-09-20 Thread Ferruh Yigit
On 9/20/2021 10:10 AM, Jerin Jacob wrote: > On Mon, Sep 20, 2021 at 2:37 PM Ferruh Yigit wrote: >> >> On 9/17/2021 11:58 AM, Ashwin Sekhar T K wrote: >>> Update word list with Marvell specific acronyms. >>> >>> CPT -> Cryptographic Accelerator Unit >>> CQ -> Completion Queue >>> LBK -> Loopbac

Re: [dpdk-dev] [EXT] Re: [PATCH v3] devtools: add acronyms in dictionary for commit checks

2021-09-20 Thread Ferruh Yigit
On 9/20/2021 10:19 AM, Ashwin Sekhar Thalakalath Kottilveetil wrote: >>> Oh yes, I missed it, sorry. >>> > One more question: why is useful to add? Some people forget >> uppercases? Upper case is desired but not really mandatory. This was a suggestion put forth to me In one of th

Re: [dpdk-dev] [PATCH v5 09/16] dma/idxd: add data-path job submission functions

2021-09-20 Thread Bruce Richardson
On Fri, Sep 17, 2021 at 03:24:30PM +, Kevin Laatz wrote: > Add data path functions for enqueuing and submitting operations to DSA > devices. > > Signed-off-by: Bruce Richardson > Signed-off-by: Kevin Laatz > Reviewed-by: Conor Walsh > --- > doc/guides/dmadevs/idxd.rst | 64 ++

Re: [dpdk-dev] [PATCH v5 07/16] dma/idxd: add configure and info_get functions

2021-09-20 Thread Bruce Richardson
On Fri, Sep 17, 2021 at 03:24:28PM +, Kevin Laatz wrote: > Add functions for device configuration. The info_get function is included > here since it can be useful for checking successful configuration. > Since this patch makes a change in the test code to enable use in the docs, that should be

Re: [dpdk-dev] [PATCH v5 02/16] dma/idxd: add skeleton for VFIO based DSA device

2021-09-20 Thread Bruce Richardson
On Fri, Sep 17, 2021 at 03:24:23PM +, Kevin Laatz wrote: > Add the basic device probe/remove skeleton code for DSA device bound to > the vfio pci driver. Relevant documentation and MAINTAINERS update also > included. > > Signed-off-by: Bruce Richardson > Signed-off-by: Kevin Laatz > Reviewed

Re: [dpdk-dev] [PATCH v5 01/16] raw/ioat: only build if dmadev not present

2021-09-20 Thread Bruce Richardson
On Fri, Sep 17, 2021 at 03:24:22PM +, Kevin Laatz wrote: > From: Bruce Richardson > > Only build the rawdev IDXD/IOAT drivers if the dmadev drivers are not > present. > > A not is also added to the documentation to inform users of this change. typo: "note" It would also be worthwhile menti

Re: [dpdk-dev] [PATCH v3] Enable AddressSanitizer feature on DPDK

2021-09-20 Thread David Marchand
On Sat, Sep 18, 2021 at 9:51 AM wrote: > > From: Zhihong Peng - The title is too vague. I am not sure what the best title is, but my current idea is: mem: instrument allocator with ASan - This is a nice feature that must be announced in the release notes. - How should we spell it? Asan ? ASA

Re: [dpdk-dev] [PATCH v8 2/2] app/testpmd: fix testpmd doesn't show RSS hash offload

2021-09-20 Thread Ferruh Yigit
On 8/27/2021 9:17 AM, Jie Wang wrote: > The driver may change offloads info into dev->data->dev_conf > in dev_configure which may cause port->dev_conf and port->rx_conf > contain outdated values. > > This patch updates the offloads info if it changes to fix this issue. > > Fixes: ce8d561418d4 ("a

Re: [dpdk-dev] [PATCH v8 2/2] app/testpmd: fix testpmd doesn't show RSS hash offload

2021-09-20 Thread Ferruh Yigit
On 9/18/2021 3:18 AM, Li, Xiaoyun wrote: > Hi > >> -Original Message- >> From: Yigit, Ferruh >> Sent: Friday, September 17, 2021 18:20 >> To: Li, Xiaoyun ; Wang, Jie1X ; >> dev@dpdk.org >> Cc: andrew.rybche...@oktetlabs.ru; tho...@monjalon.net; >> jer...@marvell.com; Ananyev, Konstantin

Re: [dpdk-dev] [PATCH v2] eal: add additional info if lcore exceeds max cores

2021-09-20 Thread David Hunt
Hi David, On 16/9/2021 1:34 PM, David Marchand wrote: On Wed, Sep 15, 2021 at 2:11 PM David Hunt wrote: If the user requests to use an lcore above 128 using -l or -c, the eal will exit with "EAL: invalid core list syntax" and very little other useful information. This patch adds some extra in

Re: [dpdk-dev] [PATCH v4] net/mlx5: fix mutex unlock in txpp cleanup

2021-09-20 Thread Slava Ovsiienko
Hi, Chengfeng Good catch, thank you. Could we polish the commit message a bit? "The lock sh->txpp.mutex was not correctly released on all pathes of cleanup function return, potentially causing the deadlock." With best regards, Slava > in these two branches, which may led to deadlock if the func

Re: [dpdk-dev] [EXT] Re: [PATCH v3] devtools: add acronyms in dictionary for commit checks

2021-09-20 Thread Ashwin Sekhar Thalakalath Kottilveetil
> On 9/17/2021 11:58 AM, Ashwin Sekhar T K wrote: > > Update word list with Marvell specific acronyms. > > > > CPT -> Cryptographic Accelerator Unit > > CQ -> Completion Queue > > LBK -> Loopback Interface Unit > > LMT -> Large Atomic Store Unit > > MCAM -> Match Content Addressable Memory NIX

Re: [dpdk-dev] [EXT] Re: [PATCH v3] devtools: add acronyms in dictionary for commit checks

2021-09-20 Thread Ashwin Sekhar Thalakalath Kottilveetil
> > Oh yes, I missed it, sorry. > > > >>> One more question: why is useful to add? Some people forget > uppercases? > >> > >> Upper case is desired but not really mandatory. This was a suggestion > >> put forth to me In one of the reviews. > >> https://urldefense.proofpoint.com/v2/url?u=https- > 3A

Re: [dpdk-dev] [PATCH v5 1/2] eventdev: add rx queue conf get api

2021-09-20 Thread Kundapura, Ganapati
Hi Jerin, > -Original Message- > From: Jerin Jacob > Sent: 20 September 2021 12:00 > To: Kundapura, Ganapati > Cc: Jayatheerthan, Jay ; dpdk-dev > ; Yigit, Ferruh > Subject: Re: [PATCH v5 1/2] eventdev: add rx queue conf get api > > On Thu, Sep 16, 2021 at 6:21 PM Ganapati Kundapura >

Re: [dpdk-dev] [PATCH v3] devtools: add acronyms in dictionary for commit checks

2021-09-20 Thread Jerin Jacob
On Mon, Sep 20, 2021 at 2:37 PM Ferruh Yigit wrote: > > On 9/17/2021 11:58 AM, Ashwin Sekhar T K wrote: > > Update word list with Marvell specific acronyms. > > > > CPT -> Cryptographic Accelerator Unit > > CQ -> Completion Queue > > LBK -> Loopback Interface Unit > > LMT -> Large Atomic Stor

Re: [dpdk-dev] [PATCH v3] devtools: add acronyms in dictionary for commit checks

2021-09-20 Thread Ferruh Yigit
On 9/17/2021 11:58 AM, Ashwin Sekhar T K wrote: > Update word list with Marvell specific acronyms. > > CPT -> Cryptographic Accelerator Unit > CQ -> Completion Queue > LBK -> Loopback Interface Unit > LMT -> Large Atomic Store Unit > MCAM -> Match Content Addressable Memory > NIX -> Network

Re: [dpdk-dev] [EXT] Re: [PATCH v3] devtools: add acronyms in dictionary for commit checks

2021-09-20 Thread Ferruh Yigit
On 9/17/2021 5:15 PM, Thomas Monjalon wrote: > 17/09/2021 16:53, Ashwin Sekhar Thalakalath Kottilveetil: >> From: Thomas Monjalon >>> 17/09/2021 15:54, Ashwin Sekhar Thalakalath Kottilveetil: From: Thomas Monjalon > 17/09/2021 12:58, Ashwin Sekhar T K: >> Update word list with Marvel

Re: [dpdk-dev] [PATCH v2 0/8] Add TM Support for CN9K and CN10K

2021-09-20 Thread nithind1988
Acked-by: Nithin Dabilpuram On 9/18/21 8:01 PM, skotesh...@marvell.com wrote: From: Satha Rao Initial implementation of traffic management for CN9K and CN10K platforms. Nithin Dabilpuram (1): common/cnxk: increase sched weight and shaper burst limit Satha Rao (7): common/cnxk: use dif

Re: [dpdk-dev] [PATCH v2 1/2] common/cnxk: update roc models

2021-09-20 Thread Jerin Jacob
On Fri, Sep 17, 2021 at 3:06 PM Ashwin Sekhar T K wrote: > > Make following updates to roc models. > - Use consistent upper/lower case in macros defining different >ROC models. > - Add api to detect cn96 Cx stepping. > - Make all current cn10k models as A0 stepping. > > Signed-off-by: Ashwi

Re: [dpdk-dev] [PATCH 2/3] test/latencystats: fix incorrect loop boundary

2021-09-20 Thread Pattan, Reshma
> -Original Message- > From: David Marchand > Caught running ASAN. > > Signed-off-by: David Marchand Acked-by: Reshma Pattan

Re: [dpdk-dev] [PATCH v4] build: add meson options of max_memseg_lists and atomic_mbuf_ref_counts

2021-09-20 Thread Bruce Richardson
On Mon, Sep 20, 2021 at 03:51:06PM +0800, kefu chai wrote: > hello Bruce, > > do you have any further concerns? is there anything i can do to move > this forward? > > cheers, > +Anatoly, for his input for the memory segments change. I still would prefer not to have these as config options, but

Re: [dpdk-dev] [PATCH v2 0/2] mlx5: support global device syntax

2021-09-20 Thread Thomas Monjalon
18/01/2021 16:26, Xueming Li: > Xueming Li (2): > common/mlx5: support device global syntax > net/mlx5: support new global device syntax > > drivers/common/mlx5/mlx5_common_pci.c | 6 +- > drivers/net/mlx5/mlx5.c | 6 +- > 2 files changed, 10 insertions(+), 2 deletions(-

Re: [dpdk-dev] [PATCH v4] build: add meson options of max_memseg_lists and atomic_mbuf_ref_counts

2021-09-20 Thread kefu chai
hello Bruce, do you have any further concerns? is there anything i can do to move this forward? cheers, On Thu, Sep 9, 2021 at 12:51 AM Kefu Chai wrote: > > RTE_MAX_MEMSEG_LISTS = 128 is not enough for high-memory machines, in our > case, we need to increase it to 8192. so add an option so user

Re: [dpdk-dev] [PATCH v2 0/4] delete HW rings when releasing queues for some drivers

2021-09-20 Thread David Marchand
On Sat, Sep 18, 2021 at 10:34 AM Yunjian Wang wrote: > > This series for deleting HW rings when releasing queues for > igb, ixgbe, i40e, ice & em drivers. > > --- > v2: >* Update commit log > > Yunjian Wang (4): > net/e1000: delete HW rings when releasing queues > net/ice: delete HW rings