Hi Dmitry, On Mon, Sep 20, 2021 at 01:11:23PM +0200, David Marchand wrote: > On Sat, Sep 11, 2021 at 1:17 AM Dmitry Kozlyuk <dmitry.kozl...@gmail.com> > wrote: > > > > Remove the definition of `struct cmdline` from public header. > > Deprecation notice: > > https://mails.dpdk.org/archives/dev/2020-September/183310.html > > > > Signed-off-by: Dmitry Kozlyuk <dmitry.kozl...@gmail.com> > > This patch lgtm. > Acked-by: David Marchand <david.march...@redhat.com>
Acked-by: Olivier Matz <olivier.m...@6wind.com> Many thanks Dmitry for taking care of this. > > --- > > I would also hide struct rdline to be able to alter buffer size, > > but we don't have a deprecation notice for it. > > Fyi, I found one project looking into a rdline pointer to get the back > reference to cmdline stored in opaque. > https://github.com/Gandi/packet-journey/blob/master/app/cmdline.c#L1398 > > This cmdline pointer is then dereferenced to get s_out. > Given that we announced cmdline becoming opaque, they would have to > handle the first API change in any case. > I don't think another API change would really make a big difference to them. > > Plus, this project seems stuck to 18.08 support. I agree with you and David, it would make sense to also hide the rdline struct at the same time. Olivier
