Re: [dpdk-dev] [RFC 07/15] eventdev: make drivers to use new API

2021-09-07 Thread Hemant Agrawal
For dpaa and dpaa2 changes Acked-by: Hemant Agrawal

Re: [dpdk-dev] [PATCH v4 1/4] test/crypto: remove illegal header include

2021-09-07 Thread Hemant Agrawal
On 9/8/2021 12:52 AM, Akhil Goyal wrote: rte_cryptodev_pmd.h is an interface between driver and library and it is mentioned in the file that application cannot use it directly. Hence, removing the include. Signed-off-by: Akhil Goyal Acked-by: Matan Azrad Series- Acked-by: Hemant Agrawal

Re: [dpdk-dev] [PATCH] RFC: ethdev: add reassembly offload

2021-09-07 Thread Xu, Rosen
Cc myself > -Original Message- > From: dev On Behalf Of Xu, Rosen > Sent: Wednesday, September 08, 2021 14:34 > To: Akhil Goyal ; dev@dpdk.org > Cc: ano...@marvell.com; Nicolau, Radu ; Doherty, > Declan ; hemant.agra...@nxp.com; > ma...@nvidia.com; Ananyev, Konstantin ; > tho...@monjalon

Re: [dpdk-dev] [PATCH] RFC: ethdev: add reassembly offload

2021-09-07 Thread Xu, Rosen
Hi, > -Original Message- > From: dev On Behalf Of Akhil Goyal > Sent: Monday, August 23, 2021 18:03 > To: dev@dpdk.org > Cc: ano...@marvell.com; Nicolau, Radu ; Doherty, > Declan ; hemant.agra...@nxp.com; > ma...@nvidia.com; Ananyev, Konstantin ; > tho...@monjalon.net; adwiv...@marvell.co

Re: [dpdk-dev] [PATCH v1] net/ice: revert removing IPID from default hash field

2021-09-07 Thread Zhang, Qi Z
> -Original Message- > From: Wu, Wenjun1 > Sent: Tuesday, September 7, 2021 3:28 PM > To: David Marchand ; Yigit, Ferruh > > Cc: dev@dpdk.org; Zhang, Qi Z ; Yang, Qiming > > Subject: RE: [dpdk-dev] [PATCH v1] net/ice: revert removing IPID from default > hash field > > Default RSS for

[dpdk-dev] [PATCH v3] net/ice: refine flow priority support in PF

2021-09-07 Thread Yuying Zhang
The usage of priority is converse in pipeline mode and non-pipeline mode. Refine attribute priority support of flow filter in PF driver. When priority is 0, rules are created in switch filter first and FDIR is used as backup. When priority is 1, rules are all created in switch filter. Other filters

Re: [dpdk-dev] [PATCH] net: promote make rarp packet API as stable

2021-09-07 Thread Xia, Chenbo
> -Original Message- > From: dev On Behalf Of Xiao Wang > Sent: Wednesday, September 8, 2021 6:59 PM > To: olivier.m...@6wind.com > Cc: dev@dpdk.org; Wang, Xiao W > Subject: [dpdk-dev] [PATCH] net: promote make rarp packet API as stable > > rte_net_make_rarp_packet was introduced in vers

Re: [dpdk-dev] [PATCH] net: promote make rarp packet API as stable

2021-09-07 Thread Stephen Hemminger
On Wed, 8 Sep 2021 18:59:15 +0800 Xiao Wang wrote: > rte_net_make_rarp_packet was introduced in version v18.02, there was no > change in this public API since then, and it's still being used by vhost > lib and virtio driver, so promote it as stable ABI. > > Signed-off-by: Xiao Wang Acked-by:

[dpdk-dev] [PATCH v3 8/8] MAINTAINERS: add entry for new pcapng and dumper

2021-09-07 Thread Stephen Hemminger
Claim responsibility for the new code. Signed-off-by: Stephen Hemminger --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 266f5ac1dae8..06384ac2702d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1429,6 +1429,12 @@ F: app/test/test_pdump.*

[dpdk-dev] [PATCH v3 7/8] doc: changes for new pcapng and dumpcap

2021-09-07 Thread Stephen Hemminger
Describe the new packet capture library and utilities Signed-off-by: Stephen Hemminger --- doc/api/doxy-api-index.md | 1 + doc/api/doxy-api.conf.in | 1 + .../howto/img/packet_capture_framework.svg| 96 +-- doc/guides/howto/packet_c

[dpdk-dev] [PATCH v3 6/8] app/dumpcap: add new packet capture application

2021-09-07 Thread Stephen Hemminger
This is a new packet capture application to replace existing pdump. The new application works like Wireshark dumpcap program and supports the pdump API features. It is not complete yet some features such as filtering are not implemented. Signed-off-by: Stephen Hemminger --- app/dumpcap/main.c

[dpdk-dev] [PATCH v3 5/8] pdump: support pcapng and filtering

2021-09-07 Thread Stephen Hemminger
This enhances the DPDK pdump library to support new pcapng format and filtering via BPF. The internal client/server protocol is changed to support two versions: the original pdump basic version and a new pcapng version. The internal version number (not part of exposed API or ABI) is intentionally

[dpdk-dev] [PATCH v3 4/8] bpf: add function to dump eBPF instructions

2021-09-07 Thread Stephen Hemminger
When debugging converted (and other) programs it is useful to see disassembled eBPF output. Signed-off-by: Stephen Hemminger --- lib/bpf/bpf_dump.c | 118 lib/bpf/meson.build | 1 + lib/bpf/rte_bpf.h | 14 ++ lib/bpf/version.map | 1 + 4 f

[dpdk-dev] [PATCH v3 3/8] bpf: add function to convert classic BPF to DPDK BPF

2021-09-07 Thread Stephen Hemminger
The pcap library emits classic BPF (32 bit) and is useful for creating filter programs. The DPDK BPF library only implements extended BPF (eBPF). Add an function to convert from old to new. The rte_bpf_convert function uses rte_malloc to put the resulting program in hugepage shared memory so it

[dpdk-dev] [PATCH v3 2/8] bpf: allow self-xor operation

2021-09-07 Thread Stephen Hemminger
When doing BPF filter program conversion, a common way to zero a register in single instruction is: xor r7,r7 The BPF validator would not allow this because the value of r7 was undefined. But after this operation it always zero so allow it as a special case. Cc: Konstantin Ananyev Signed-of

[dpdk-dev] [PATCH v3 1/8] librte_pcapng: add new library for writing pcapng files

2021-09-07 Thread Stephen Hemminger
This is utility library for writing pcapng format files used by Wireshark family of utilities. Older tcpdump also knows how to read (but not write) this format. See draft RFC https://www.ietf.org/id/draft-tuexen-opsawg-pcapng-03.html and https://github.com/pcapng/pcapng/ Signed-off-by: Stephe

[dpdk-dev] [PATCH v3 0/8] Packet capture framework enhancements

2021-09-07 Thread Stephen Hemminger
This patch set is a more complete version of the the enhanced packet capture support described last year. The new capture library and utility are: - faster avoids lots of extra I/O, does bursting, etc. - gives more information (multiple ports, queues, etc) - has a better user interface (same

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix probability of obtaining mailbox lock failure

2021-09-07 Thread Wang, Haiyue
> -Original Message- > From: Qiming Chen > Sent: Monday, September 6, 2021 10:22 > To: dev@dpdk.org > Cc: Wang, Haiyue ; Qiming Chen > ; sta...@dpdk.org > Subject: [PATCH v2] net/ixgbe: fix probability of obtaining mailbox lock > failure > > Ifconfig pf port up/down, after several times

[dpdk-dev] [PATCH] net: promote make rarp packet API as stable

2021-09-07 Thread Xiao Wang
rte_net_make_rarp_packet was introduced in version v18.02, there was no change in this public API since then, and it's still being used by vhost lib and virtio driver, so promote it as stable ABI. Signed-off-by: Xiao Wang --- lib/net/rte_arp.h | 4 lib/net/version.map | 2 +- 2 files chan

Re: [dpdk-dev] [RFC V1] examples/l3fwd-power: fix memory leak for rte_pci_device

2021-09-07 Thread Huisong Li
Hi, Thomas 在 2021/9/7 16:53, Thomas Monjalon 写道: 07/09/2021 05:41, Huisong Li: Calling rte_eth_dev_close() will release resources of eth device and close it. But rte_pci_device struct isn't released when app exit, which will lead to memory leak. That's a PMD issue. When the last port of a PCI

[dpdk-dev] [PATCH v1] baseband/acc100: fix 4GUL outbound size when CRC is dropped

2021-09-07 Thread Nicolas Chautru
This patch fixes the issue by adjusting the outbound size after turbodecoding when the appended CRC is meant to be dropped. Fixes: f404dfe35cc3 ("baseband/acc100: support 4G processing") Cc: sta...@dpdk.org Signed-off-by: Nicolas Chautru --- drivers/baseband/acc100/rte_acc100_pmd.c | 3 ++- 1 f

[dpdk-dev] [PATCH v3 6/6] bbdev: reduce warning level for one scenario

2021-09-07 Thread Nicolas Chautru
Queue setup may genuinely fail when adding incremental queues for a given priority level. In that case application would attempt to configure a queue at a different priority level. Not an actual error. Signed-off-by: Nicolas Chautru --- lib/bbdev/rte_bbdev.c | 7 --- 1 file changed, 4 insert

[dpdk-dev] [PATCH v3 4/6] baseband/acc100: add support for 4G CRC drop

2021-09-07 Thread Nicolas Chautru
This implements in PMD the option to drop the CB CRC after 4G decoding to help transport block concatenation. Signed-off-by: Nicolas Chautru --- doc/guides/bbdevs/acc100.rst | 1 + doc/guides/rel_notes/release_21_11.rst | 4 drivers/baseband/acc100/rte_acc100_pmd.c | 12

[dpdk-dev] [PATCH v3 5/6] doc: clarification of usage of HARQ in bbdev doc

2021-09-07 Thread Nicolas Chautru
New paragraph detailing typical VRAN usecase and mapping to bbdev API usage. Signed-off-by: Nicolas Chautru --- doc/guides/prog_guide/bbdev.rst | 23 +++ 1 file changed, 23 insertions(+) diff --git a/doc/guides/prog_guide/bbdev.rst b/doc/guides/prog_guide/bbdev.rst index 8bd

[dpdk-dev] [PATCH v3 2/6] baseband/turbo_sw: add support for CRC16

2021-09-07 Thread Nicolas Chautru
This is to support the case for operation where CRC16 is to be appended or checked. Signed-off-by: Nicolas Chautru --- doc/guides/rel_notes/release_21_11.rst | 3 +++ drivers/baseband/turbo_sw/bbdev_turbo_software.c | 16 2 files changed, 19 insertions(+) diff --git

[dpdk-dev] [PATCH v3 3/6] bbdev: add capability for 4G CB CRC DROP

2021-09-07 Thread Nicolas Chautru
Adding option to drop CRC24B to align with existing feature for 5G Signed-off-by: Nicolas Chautru --- app/test-bbdev/test_bbdev_vector.c | 2 ++ lib/bbdev/rte_bbdev_op.h | 5 - 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/app/test-bbdev/test_bbdev_vector.c b/app/t

[dpdk-dev] [PATCH v3 0/6] bbdev update related to CRC usage

2021-09-07 Thread Nicolas Chautru
v3: 2 updates based on review comment by tom rix, thanks v2: typo missed in documentation. Capturing in this serie minor change to bbdev to support a more comprehensive set of options for CRC used for 4G and 5G (exposed as optional capabilities). This also includes clarifications in documention

[dpdk-dev] [PATCH v3 1/6] bbdev: add capability for CRC16 check

2021-09-07 Thread Nicolas Chautru
Adding a missing operation when CRC16 is being used for TB CRC check. Signed-off-by: Nicolas Chautru --- app/test-bbdev/test_bbdev_vector.c | 2 ++ doc/guides/prog_guide/bbdev.rst| 3 +++ doc/guides/rel_notes/release_21_11.rst | 1 + lib/bbdev/rte_bbdev_op.h | 34 +++

Re: [dpdk-dev] [PATCH v2 6/6] bbdev: reduce warning level for one scenario

2021-09-07 Thread Chautru, Nicolas
> -Original Message- > From: Tom Rix > Sent: Wednesday, September 1, 2021 7:30 AM > To: Chautru, Nicolas ; dev@dpdk.org; > gak...@marvell.com > Cc: tho...@monjalon.net; hemant.agra...@nxp.com; Zhang, Mingshan > ; Joshi, Arun > Subject: Re: [PATCH v2 6/6] bbdev: reduce warning level for

Re: [dpdk-dev] [PATCH v2 4/6] baseband/acc100: add support for 4G CRC drop

2021-09-07 Thread Chautru, Nicolas
> -Original Message- > From: Tom Rix > Sent: Wednesday, September 1, 2021 7:20 AM > To: Chautru, Nicolas ; dev@dpdk.org; > gak...@marvell.com > Cc: tho...@monjalon.net; hemant.agra...@nxp.com; Zhang, Mingshan > ; Joshi, Arun > Subject: Re: [PATCH v2 4/6] baseband/acc100: add support for

Re: [dpdk-dev] [PATCH v2 2/6] baseband/turbo_sw: add support for CRC16

2021-09-07 Thread Chautru, Nicolas
> -Original Message- > From: Tom Rix > Sent: Wednesday, September 1, 2021 7:01 AM > To: Chautru, Nicolas ; dev@dpdk.org; > gak...@marvell.com > Cc: tho...@monjalon.net; hemant.agra...@nxp.com; Zhang, Mingshan > ; Joshi, Arun > Subject: Re: [PATCH v2 2/6] baseband/turbo_sw: add support f

Re: [dpdk-dev] [PATCH v17] app/testpmd: support multi-process

2021-09-07 Thread Min Hu (Connor)
在 2021/9/7 21:23, Ferruh Yigit 写道: On 8/25/2021 3:06 AM, Min Hu (Connor) wrote: This patch adds multi-process support for testpmd. For example the following commands run two testpmd processes: * the primary process: ./dpdk-testpmd --proc-type=auto -l 0-1 -- -i \ --rxq=4 --txq=4 --num-

Re: [dpdk-dev] [RFC 11/15] eventdev: reserve fields in timer object

2021-09-07 Thread Stephen Hemminger
On Tue, 24 Aug 2021 01:10:15 +0530 wrote: > + uint64_t rsvd[2]; > + /**< Reserved fields for future use. */ Did you check that these are 0 in current code? No. then they can't be safely used in the future.

Re: [dpdk-dev] [EXT] Re: [RFC 11/15] eventdev: reserve fields in timer object

2021-09-07 Thread Carrillo, Erik G
> -Original Message- > From: Pavan Nikhilesh Bhagavatula > Sent: Wednesday, September 1, 2021 1:48 AM > To: Stephen Hemminger ; Carrillo, Erik G > > Cc: Jerin Jacob Kollanukkaran ; Ananyev, Konstantin > ; dev@dpdk.org > Subject: RE: [EXT] Re: [dpdk-dev] [RFC 11/15] eventdev: reserve fi

[dpdk-dev] [PATCH v4 4/4] cryptodev: expose driver interface as internal

2021-09-07 Thread Akhil Goyal
The rte_cryptodev_pmd.* files are for drivers only and should be private to DPDK, and not installed for app use. Signed-off-by: Akhil Goyal Acked-by: Matan Azrad Acked-by: Fan Zhang --- doc/guides/rel_notes/deprecation.rst | 3 --- doc/guides/rel_notes/release_21_11.rst| 4 +

[dpdk-dev] [PATCH v4 3/4] examples/fips_validation: remove illegal usage of APIs

2021-09-07 Thread Akhil Goyal
Some of the cryptodev APIs are not allowed to be used by application directly. Hence removing the usage of 1. queue_pair_release: it is not required, as configure of queue pair release the previous queue pairs and the dev is not directly exposed to application, hence cannot use its ops fro

[dpdk-dev] [PATCH v4 2/4] cryptodev: change valid dev API

2021-09-07 Thread Akhil Goyal
The API rte_cryptodev_pmd_is_valid_dev, can be used by the application as well as PMD to check whether the device is valid or not. Hence, _pmd is removed from the API. The applications and drivers which use this API are also updated. Signed-off-by: Akhil Goyal --- doc/guides/rel_notes/release_21

[dpdk-dev] [PATCH v4 1/4] test/crypto: remove illegal header include

2021-09-07 Thread Akhil Goyal
rte_cryptodev_pmd.h is an interface between driver and library and it is mentioned in the file that application cannot use it directly. Hence, removing the include. Signed-off-by: Akhil Goyal Acked-by: Matan Azrad --- app/test/test_cryptodev.c | 1 - app/test/test_cryptodev_asym.c

[dpdk-dev] [PATCH v4 0/4] cryptodev: expose driver interface as internal

2021-09-07 Thread Akhil Goyal
rte_cryptodev_pmd.* files are meant to be used for DPDK internal usage only, but it was used illegally by applications. There is one API which can be used by applications to check if the dev_id has a valid device or not. This API is exposed and modified as rte_cryptodev_is_valid_dev() from rte_cryp

Re: [dpdk-dev] [EXT] [PATCH] crypto/dpaa_sec: update release notes

2021-09-07 Thread Akhil Goyal
> Update the release notes in DPAAx for the changes in recent patches. > > Signed-off-by: Hemant Agrawal > --- > doc/guides/rel_notes/release_21_11.rst | 4 > 1 file changed, 4 insertions(+) > > diff --git a/doc/guides/rel_notes/release_21_11.rst > b/doc/guides/rel_notes/release_21_11.rst

Re: [dpdk-dev] [RFC PATCH v5 1/5] sched: add PIE based congestion management

2021-09-07 Thread Stephen Hemminger
On Tue, 7 Sep 2021 07:33:24 + "Liguzinski, WojciechX" wrote: > +/** > + * @brief make a decision to drop or enqueue a packet based on probability > + *criteria > + * > + * @param pie_cfg [in] config pointer to a PIE configuration parameter > structure > + * @param pie [in, out] data

[dpdk-dev] [PATCH v3 4/4] cryptodev: expose driver interface as internal

2021-09-07 Thread Akhil Goyal
The rte_cryptodev_pmd.* files are for drivers only and should be private to DPDK, and not installed for app use. Signed-off-by: Akhil Goyal Acked-by: Matan Azrad Acked-by: Fan Zhang --- doc/guides/rel_notes/release_21_11.rst| 4 +++ drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 2 +

[dpdk-dev] [PATCH v3 3/4] examples/fips_validation: remove illegal usage of APIs

2021-09-07 Thread Akhil Goyal
Some of the cryptodev APIs are not allowed to be used by application directly. Hence removing the usage of 1. queue_pair_release: it is not required, as configure of queue pair release the previous queue pairs and the dev is not directly exposed to application, hence cannot use its ops fro

[dpdk-dev] [PATCH v3 2/4] cryptodev: change valid dev API

2021-09-07 Thread Akhil Goyal
The API rte_cryptodev_pmd_is_valid_dev, can be used by the application as well as PMD to check whether the device is valid or not. Hence, _pmd is removed from the API. The applications and drivers which use this API are also updated. Signed-off-by: Akhil Goyal --- doc/guides/rel_notes/release_21

[dpdk-dev] [PATCH v3 1/4] test/crypto: remove illegal header include

2021-09-07 Thread Akhil Goyal
rte_cryptodev_pmd.h is an interface between driver and library and it is mentioned in the file that application cannot use it directly. Hence, removing the include. Signed-off-by: Akhil Goyal Acked-by: Matan Azrad --- app/test/test_cryptodev.c | 1 - app/test/test_cryptodev_asym.c

[dpdk-dev] [PATCH v3 0/4] cryptodev: expose driver interface as internal

2021-09-07 Thread Akhil Goyal
rte_cryptodev_pmd.* files are meant to be used for DPDK internal usage only, but it was used illegally by applications. There is one API which can be used by applications to check if the dev_id has a valid device or not. This API is exposed and modified as rte_cryptodev_is_valid_dev() from rte_cryp

Re: [dpdk-dev] [PATCH v2 0/6] add cn9k lookaside IPsec support

2021-09-07 Thread Akhil Goyal
> This series adds lookaside IPsec support in cnxk crypto PMD > for Marvell CN9K SOC. > > Changes in v2: > - Fixed release notes > - Squashed patches and reduced no of patches from 8 to 6 > > Archana Muniganti (6): > crypto/cnxk: add cn9k security ctx > common/cnxk: add cn9k IPsec microcode d

Re: [dpdk-dev] [PATCH v3] eventdev: update crypto adapter metadata structures

2021-09-07 Thread Gujjar, Abhinandan S
Hi Shijith, > -Original Message- > From: Shijith Thotton > Sent: Tuesday, September 7, 2021 4:07 PM > To: Gujjar, Abhinandan S ; dev@dpdk.org > Cc: Jerin Jacob Kollanukkaran ; Anoob Joseph > ; Pavan Nikhilesh Bhagavatula > ; Akhil Goyal ; Ray > Kinsella ; Ankur Dwivedi > Subject: RE: [PA

Re: [dpdk-dev] [PATCH] docs: fix bond driver name

2021-09-07 Thread Ferruh Yigit
On 8/27/2021 1:32 AM, Min Hu (Connor) wrote: > 在 2021/8/27 7:10, Ben Magistro 写道: >> The documentation for the bond driver lists the name as `net/bond` >> however the driver should be `net/bonding`. >> >> Signed-off-by: Ben Magistro > > Acked-by: Min Hu (Connor) > Fixes: 89c67ae2cba7 ("doc

Re: [dpdk-dev] [PATCH v7 0/2] Use macro to print MAC address

2021-09-07 Thread Ferruh Yigit
On 8/25/2021 6:27 PM, Aman Singh wrote: > Added macros to simplyfy print of MAC address. > The six bytes of mac address is extracted using > a macro to improve code readability. > > V2: Fix build issue in examples code > V3: Fix Windows compilation issue > V5: Print format aligned with rte_ether_f

[dpdk-dev] [PATCH v3 6/8] app/test: test dmadev instance failure handling

2021-09-07 Thread Bruce Richardson
Add a series of tests to inject bad copy operations into a dmadev to test the error handling and reporting capabilities. Various combinations of errors in various positions in a burst are tested, as are errors in bursts with fence flag set, and multiple errors in a single burst. Signed-off-by: Bru

[dpdk-dev] [PATCH v3 5/8] app/test: add more comprehensive dmadev copy tests

2021-09-07 Thread Bruce Richardson
Add unit tests for various combinations of use for dmadev, copying bursts of packets in various formats, e.g. 1. enqueuing two smaller bursts and completing them as one burst 2. enqueuing one burst and gathering completions in smaller bursts 3. using completed_status() function to gather completio

[dpdk-dev] [PATCH v3 4/8] app/test: add basic dmadev copy tests

2021-09-07 Thread Bruce Richardson
For each dmadev instance, perform some basic copy tests to validate that functionality. Signed-off-by: Bruce Richardson Reviewed-by: Kevin Laatz Reviewed-by: Conor Walsh --- app/test/test_dmadev.c | 175 + 1 file changed, 175 insertions(+) diff --git a/

[dpdk-dev] [PATCH v3 3/8] app/test: add basic dmadev instance tests

2021-09-07 Thread Bruce Richardson
Run basic sanity tests for configuring, starting and stopping a dmadev instance to help validate drivers. This also provides the framework for future tests for data-path operation. Signed-off-by: Bruce Richardson Reviewed-by: Conor Walsh --- app/test/test_dmadev.c | 72 +

[dpdk-dev] [PATCH v3 2/8] dmadev: add burst capacity API

2021-09-07 Thread Bruce Richardson
From: Kevin Laatz Add a burst capacity check API to the dmadev library. This API is useful to applications which need to how many descriptors can be enqueued in the current batch. For example, it could be used to determine whether all segments of a multi-segment packet can be enqueued in the same

[dpdk-dev] [PATCH v3 1/8] dmadev: add channel status check for testing use

2021-09-07 Thread Bruce Richardson
Add in a function to check if a device or vchan has completed all jobs assigned to it, without gathering in the results. This is primarily for use in testing, to allow the hardware to be in a known-state prior to gathering completions. Signed-off-by: Bruce Richardson --- lib/dmadev/rte_dmadev.c

[dpdk-dev] [PATCH v3 0/8] add test suite for DMA drivers

2021-09-07 Thread Bruce Richardson
This patchset adds a fairly comprehensive set of tests for basic dmadev functionality. Tests are added to verify basic copy operation in each device, using both submit function and submit flag, and verifying completion gathering using both "completed()" and "completed_status()" functions. Beyond th

[dpdk-dev] [PATCH v3 8/8] app/test: add dmadev burst capacity API test

2021-09-07 Thread Bruce Richardson
From: Kevin Laatz Add a test case to validate the functionality of drivers' burst capacity API implementations. Signed-off-by: Kevin Laatz Signed-off-by: Bruce Richardson --- app/test/test_dmadev.c | 68 ++ 1 file changed, 68 insertions(+) diff --git a

[dpdk-dev] [PATCH v3 7/8] app/test: add dmadev fill tests

2021-09-07 Thread Bruce Richardson
From: Kevin Laatz For dma devices which support the fill operation, run unit tests to verify fill behaviour is correct. Signed-off-by: Kevin Laatz Signed-off-by: Bruce Richardson Reviewed-by: Conor Walsh --- app/test/test_dmadev.c | 49 ++ 1 file chang

[dpdk-dev] [PATCH v2 6/6] examples/ipsec-secgw: clear soft expiry configuration

2021-09-07 Thread Anoob Joseph
Soft expiry is not a mandatory IPsec feature. It is verified separately with IPsec unit tests. So configuration of the same is not required. Also, soft expiry tracking can cause perf degradation with some PMDs. Since a separate UT is available and the same setting in ipsec-secgw is not verifying th

[dpdk-dev] [PATCH v2 5/6] test/crypto: add packets hard expiry tests

2021-09-07 Thread Anoob Joseph
Add tests to validate packets hard expiry handling. Signed-off-by: Anoob Joseph --- app/test/test_cryptodev.c| 19 ++- app/test/test_cryptodev_security_ipsec.c | 22 +++--- app/test/test_cryptodev_security_ipsec.h | 1 + 3 files changed, 38 insert

[dpdk-dev] [PATCH v2 4/6] test/crypto: add packets soft expiry tests

2021-09-07 Thread Anoob Joseph
Add tests to validate packets soft expiry handling. Signed-off-by: Anoob Joseph --- app/test/test_cryptodev.c| 21 +++-- app/test/test_cryptodev_security_ipsec.c | 18 -- app/test/test_cryptodev_security_ipsec.h | 4 +++- 3 files changed, 38 inser

[dpdk-dev] [PATCH v2 3/6] crypto/octeontx2: add checks for life configuration

2021-09-07 Thread Anoob Joseph
Lifetime tracking is not supported by hardware and is not implemented in software either. Return failure when lifetime is configured. Signed-off-by: Anoob Joseph --- drivers/crypto/octeontx2/otx2_ipsec_po.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/crypto/octeontx2/otx2_i

[dpdk-dev] [PATCH v2 2/6] common/cnxk: support lifetime configuration

2021-09-07 Thread Anoob Joseph
Add support for SA lifetime configuration. Expiry can be either in units of octets or packets. Also, updated cryptodev dequeue path to update crypto op result to indicate soft expiry. Signed-off-by: Anoob Joseph --- drivers/common/cnxk/cnxk_security.c | 70 +++

[dpdk-dev] [PATCH v2 1/6] security: add SA lifetime configuration

2021-09-07 Thread Anoob Joseph
Add SA lifetime configuration to register soft and hard expiry limits. Expiry can be in units of number of packets or bytes. Crypto op status is also updated to include new field, aux_flags, which can be used to indicate cases such as soft expiry in case of lookaside protocol operations. In case o

[dpdk-dev] [PATCH v2 0/6] Add SA lifetime in security

2021-09-07 Thread Anoob Joseph
Add SA lifetime configuration in security. SA lifetime tracking can be offloaded on supported PMDs. SA lifetime would cover soft & hard expiry in units of number of packets and bytes. When SA soft expiry happens, the packet is successfuly processed but with additional expiry notification. Crypto o

[dpdk-dev] [PATCH v3 3/3] test/crypto: add outbound known vector tests

2021-09-07 Thread Anoob Joseph
Add outbound known vector tests. The tests would be skipped on PMDs which do not support IV provided by application. Signed-off-by: Anoob Joseph Acked-by: Akhil Goyal --- app/test/test_cryptodev.c| 44 app/test/test_cryptodev_security_ipsec.c | 1

[dpdk-dev] [PATCH v3 2/3] crypto/cnxk: add IV in SA in lookaside IPsec debug mode

2021-09-07 Thread Anoob Joseph
From: Tejasree Kondoj Adding IV in SA in lookaside IPsec debug mode. It helps to verify lookaside PMD using known outbound vectors in lookaside autotest. Signed-off-by: Anoob Joseph Signed-off-by: Tejasree Kondoj Acked-by: Akhil Goyal --- drivers/crypto/cnxk/cn10k_ipsec.c | 1

[dpdk-dev] [PATCH v3 1/3] security: support user specified IV

2021-09-07 Thread Anoob Joseph
Enable user to provide IV to be used per security operation. This would be used with lookaside protocol offload for comparing against known vectors. By default, PMD would generate IV internally and would be random. Signed-off-by: Anoob Joseph Acked-by: Akhil Goyal --- doc/guides/rel_notes/rele

[dpdk-dev] [PATCH v3 0/3] Add user specified IV with lookaside IPsec

2021-09-07 Thread Anoob Joseph
Add support for using user provided IV with lookaside protocol (IPsec). Using this option, application can provide IV to be used per operation. This option can be used for knownn vector tests (which is otherwise impossible due to random nature of IV) as well as if application wishes to use its own

Re: [dpdk-dev] [PATCH] doc: announce change in vfio dma mapping

2021-09-07 Thread Ferruh Yigit
On 9/7/2021 4:21 PM, Burakov, Anatoly wrote: > On 06-Sep-21 2:43 PM, Ferruh Yigit wrote: >> On 9/6/2021 9:51 AM, Ding, Xuan wrote: >>> Hi, >>> -Original Message- From: Kinsella, Ray Sent: Friday, September 3, 2021 12:13 AM To: Yigit, Ferruh ; Burakov, Anatoly ; Din

Re: [dpdk-dev] [PATCH v2 0/6] add cn9k lookaside IPsec support

2021-09-07 Thread Anoob Joseph
> > This series adds lookaside IPsec support in cnxk crypto PMD for Marvell CN9K > SOC. > > Changes in v2: > - Fixed release notes > - Squashed patches and reduced no of patches from 8 to 6 > > Archana Muniganti (6): > crypto/cnxk: add cn9k security ctx > common/cnxk: add cn9k IPsec microcod

Re: [dpdk-dev] [PATCH v2] net/af_xdp: fix zero copy Tx queue drain

2021-09-07 Thread Ferruh Yigit
On 8/25/2021 11:48 AM, Loftus, Ciara wrote: >> >> Call xsk_ring_prod__submit() before kick_tx() so that the kernel >> consumer sees the updated state of Tx ring. Otherwise, Tx packets are >> stuck in the ring until the next call to af_xdp_tx_zc(). >> >> Fixes: d8a210774e1d ("net/af_xdp: support una

Re: [dpdk-dev] [PATCH] doc: announce change in vfio dma mapping

2021-09-07 Thread Burakov, Anatoly
On 06-Sep-21 2:43 PM, Ferruh Yigit wrote: On 9/6/2021 9:51 AM, Ding, Xuan wrote: Hi, -Original Message- From: Kinsella, Ray Sent: Friday, September 3, 2021 12:13 AM To: Yigit, Ferruh ; Burakov, Anatoly ; Ding, Xuan ; dev@dpdk.org Cc: maxime.coque...@redhat.com; Xia, Chenbo ; Hu, Jiayu

[dpdk-dev] [PATCH v2 6/6] crypto/cnxk: update feature flag for cn9k lookaside IPsec

2021-09-07 Thread Archana Muniganti
Update device feature flag to support lookaside IPsec for cn9k. Signed-off-by: Ankur Dwivedi Signed-off-by: Archana Muniganti Signed-off-by: Tejasree Kondoj Signed-off-by: Vamsi Attunuru --- doc/guides/cryptodevs/cnxk.rst | 14 -- doc/guides/cryptodevs/features/cn9k.ini |

[dpdk-dev] [PATCH v2 5/6] crypto/cnxk: update tailroom requirement

2021-09-07 Thread Archana Muniganti
Update min tailroom to reflect IPsec additions. PMD crypto_cn9k & crypto_cn10k would have packet grow into tailroom post IPsec processing. Signed-off-by: Archana Muniganti --- drivers/crypto/cnxk/cnxk_cryptodev_ops.c | 2 +- drivers/crypto/cnxk/cnxk_cryptodev_ops.h | 1 + 2 files changed, 2 inse

[dpdk-dev] [PATCH v2 4/6] crypto/cnxk: add cn9k lookaside IPsec datapath

2021-09-07 Thread Archana Muniganti
Adds support for cn9k lookaside enqueue and dequeue operations. Signed-off-by: Archana Muniganti Signed-off-by: Tejasree Kondoj Signed-off-by: Vamsi Attunuru --- drivers/crypto/cnxk/cn9k_cryptodev_ops.c | 78 +++- drivers/crypto/cnxk/cn9k_ipsec_la_ops.h | 90 ++

[dpdk-dev] [PATCH v2 3/6] crypto/cnxk: add cn9k security session ops

2021-09-07 Thread Archana Muniganti
Add security session ops. Signed-off-by: Ankur Dwivedi Signed-off-by: Archana Muniganti Signed-off-by: Tejasree Kondoj Signed-off-by: Vamsi Attunuru --- drivers/crypto/cnxk/cn9k_cryptodev.c | 2 + drivers/crypto/cnxk/cn9k_ipsec.c | 610 +++ drivers/crypto/cnxk/cn

[dpdk-dev] [PATCH v2 2/6] common/cnxk: add cn9k IPsec microcode defines

2021-09-07 Thread Archana Muniganti
Microcode IE opcodes support IPsec operations. Add defines and structs defined by microcode. Signed-off-by: Ankur Dwivedi Signed-off-by: Archana Muniganti Signed-off-by: Tejasree Kondoj Signed-off-by: Vamsi Attunuru --- drivers/common/cnxk/roc_cpt.h | 1 + drivers/common/cnxk/roc_ie_on.h

[dpdk-dev] [PATCH v2 1/6] crypto/cnxk: add cn9k security ctx

2021-09-07 Thread Archana Muniganti
Add security ctx in cn9k crypto PMD. Signed-off-by: Archana Muniganti Signed-off-by: Vamsi Attunuru Signed-off-by: Tejasree Kondoj --- drivers/crypto/cnxk/cn9k_cryptodev.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/crypto/cnxk/cn9k_cryptodev.c b/drivers/crypto/cnxk/c

[dpdk-dev] [PATCH v2 0/6] add cn9k lookaside IPsec support

2021-09-07 Thread Archana Muniganti
This series adds lookaside IPsec support in cnxk crypto PMD for Marvell CN9K SOC. Changes in v2: - Fixed release notes - Squashed patches and reduced no of patches from 8 to 6 Archana Muniganti (6): crypto/cnxk: add cn9k security ctx common/cnxk: add cn9k IPsec microcode defines crypto/cnxk

[dpdk-dev] [RFC PATCH v6 1/5] sched: add PIE based congestion management

2021-09-07 Thread Liguzinski, WojciechX
Implement PIE based congestion management based on rfc8033 Signed-off-by: Liguzinski, WojciechX --- drivers/net/softnic/rte_eth_softnic_tm.c | 6 +- lib/sched/meson.build| 10 +- lib/sched/rte_pie.c | 82 + lib/sched/rte_pie.h

[dpdk-dev] [RFC PATCH v6 3/5] example/ip_pipeline: add PIE support

2021-09-07 Thread Liguzinski, WojciechX
Adding the PIE support for IP Pipeline Signed-off-by: Liguzinski, WojciechX --- examples/ip_pipeline/tmgr.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/examples/ip_pipeline/tmgr.c b/examples/ip_pipeline/tmgr.c index e4e364cbc0..73da2da870 100644 --- a/examples/ip_pi

[dpdk-dev] [RFC PATCH v6 2/5] example/qos_sched: add PIE support

2021-09-07 Thread Liguzinski, WojciechX
patch add support enable PIE or RED by parsing config file. Signed-off-by: Liguzinski, WojciechX --- config/rte_config.h | 1 - examples/qos_sched/app_thread.c | 1 - examples/qos_sched/cfg_file.c | 82 ++--- examples/qos_sched/init.c | 7 +- examples/qos_sched

[dpdk-dev] [RFC PATCH v6 0/5] Add PIE support for HQoS library

2021-09-07 Thread Liguzinski, WojciechX
DPDK sched library is equipped with mechanism that secures it from the bufferbloat problem which is a situation when excess buffers in the network cause high latency and latency variation. Currently, it supports RED for active queue management (which is designed to control the queue length but

[dpdk-dev] [RFC PATCH v6 5/5] app/test: add tests for PIE

2021-09-07 Thread Liguzinski, WojciechX
Tests for PIE code added to test application. Signed-off-by: Liguzinski, WojciechX --- app/test/autotest_data.py | 18 + app/test/meson.build |4 + app/test/test_pie.c | 1065 + lib/sched/rte_pie.c |6 +- lib/sched/rte_pie.h |

[dpdk-dev] [RFC PATCH v6 4/5] doc/guides/prog_guide: added PIE

2021-09-07 Thread Liguzinski, WojciechX
Added PIE related information to documentation. Signed-off-by: Liguzinski, WojciechX --- doc/guides/prog_guide/glossary.rst | 3 + doc/guides/prog_guide/qos_framework.rst | 60 +--- doc/guides/prog_guide/traffic_management.rst | 13 - 3 files changed, 66 inser

Re: [dpdk-dev] [PATCH v3 13/13] app/test: enable subset of unit tests on Windows

2021-09-07 Thread Aaron Conole
Jie Zhou writes: > Enable a subset of unit tests on Windows. Currently not all the > dependencies (e.g. libraries and some functionalities) of all unit > tests are supported on Windows yet. > > Signed-off-by: Jie Zhou > --- Hi Jie, How is it expected that a developer will add unit tests here?

[dpdk-dev] [PATCH] crypto/dpaa_sec: update release notes

2021-09-07 Thread Hemant Agrawal
Update the release notes in DPAAx for the changes in recent patches. Signed-off-by: Hemant Agrawal --- doc/guides/rel_notes/release_21_11.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/guides/rel_notes/release_21_11.rst b/doc/guides/rel_notes/release_21_11.rst index 0afd21812f.

Re: [dpdk-dev] [PATCH v17] app/testpmd: support multi-process

2021-09-07 Thread Ferruh Yigit
On 8/25/2021 3:06 AM, Min Hu (Connor) wrote: > This patch adds multi-process support for testpmd. > For example the following commands run two testpmd > processes: > > * the primary process: > > ./dpdk-testpmd --proc-type=auto -l 0-1 -- -i \ >--rxq=4 --txq=4 --num-procs=2 --proc-id=0 > > *

Re: [dpdk-dev] [PATCH v20 2/7] dmadev: introduce DMA device library internal header

2021-09-07 Thread fengchengwen
Already fix in V21, thanks On 2021/9/6 21:35, Bruce Richardson wrote: > On Sat, Sep 04, 2021 at 06:10:22PM +0800, Chengwen Feng wrote: >> This patch introduce DMA device library internal header, which contains >> internal data types that are used by the DMA devices in order to expose >> their ops

[dpdk-dev] [PATCH v21 5/7] doc: add DMA device library guide

2021-09-07 Thread Chengwen Feng
This patch adds dmadev library guide. Signed-off-by: Chengwen Feng Acked-by: Conor Walsh Reviewed-by: Kevin Laatz --- MAINTAINERS | 1 + doc/guides/prog_guide/dmadev.rst | 125 doc/guides/prog_guide/img/dmadev.svg | 283 +++ d

[dpdk-dev] [PATCH v21 2/7] dmadev: introduce DMA device library internal header

2021-09-07 Thread Chengwen Feng
This patch introduce DMA device library internal header, which contains internal data types that are used by the DMA devices in order to expose their ops to the class. Signed-off-by: Chengwen Feng Acked-by: Bruce Richardson Acked-by: Morten Brørup Reviewed-by: Kevin Laatz Reviewed-by: Conor Wa

[dpdk-dev] [PATCH v21 6/7] dma/skeleton: introduce skeleton dmadev driver

2021-09-07 Thread Chengwen Feng
Skeleton dmadevice driver, on the lines of rawdev skeleton, is for showcasing of the dmadev library. Design of skeleton involves a virtual device which is plugged into VDEV bus on initialization. Also, enable compilation of dmadev skeleton drivers. Signed-off-by: Chengwen Feng Reviewed-by: Kevi

[dpdk-dev] [PATCH v21 0/7] support dmadev

2021-09-07 Thread Chengwen Feng
This patch set contains seven patch for new add dmadev. Chengwen Feng (7): dmadev: introduce DMA device library public APIs dmadev: introduce DMA device library internal header dmadev: introduce DMA device library PMD header dmadev: introduce DMA device library implementation doc: add DM

[dpdk-dev] [PATCH v21 7/7] app/test: add dmadev API test

2021-09-07 Thread Chengwen Feng
This patch add dmadev API test which based on 'dma_skeleton' vdev. The test cases could be executed using 'dmadev_autotest' command in test framework. Signed-off-by: Chengwen Feng Signed-off-by: Bruce Richardson Reviewed-by: Kevin Laatz Reviewed-by: Conor Walsh --- MAINTAINERS

[dpdk-dev] [PATCH v21 3/7] dmadev: introduce DMA device library PMD header

2021-09-07 Thread Chengwen Feng
This patch introduce DMA device library PMD header which was driver facing APIs for a DMA device. Signed-off-by: Chengwen Feng Acked-by: Bruce Richardson Acked-by: Morten Brørup Reviewed-by: Kevin Laatz Reviewed-by: Conor Walsh --- lib/dmadev/meson.build | 1 + lib/dmadev/rte_dmadev.h

[dpdk-dev] [PATCH v21 4/7] dmadev: introduce DMA device library implementation

2021-09-07 Thread Chengwen Feng
This patch introduce DMA device library implementation which includes configuration and I/O with the DMA devices. Signed-off-by: Chengwen Feng Acked-by: Bruce Richardson Acked-by: Morten Brørup Reviewed-by: Kevin Laatz Reviewed-by: Conor Walsh --- config/rte_config.h | 3 + lib/dm

[dpdk-dev] [PATCH v21 1/7] dmadev: introduce DMA device library public APIs

2021-09-07 Thread Chengwen Feng
The 'dmadevice' is a generic type of DMA device. This patch introduce the 'dmadevice' public APIs which expose generic operations that can enable configuration and I/O with the DMA devices. Maintainers update is also included in this patch. Signed-off-by: Chengwen Feng Acked-by: Bruce Richardso

Re: [dpdk-dev] [RFC PATCH v2 0/7] heterogeneous computing library

2021-09-07 Thread Elena Agostini
> -Original Message- > From: Wang, Haiyue > Sent: Monday, September 6, 2021 7:15 PM > To: Elena Agostini ; Jerin Jacob > > Cc: NBU-Contact-Thomas Monjalon ; Jerin Jacob > ; dpdk-dev ; Stephen Hemminger > ; David Marchand > ; Andrew Rybchenko > ; Honnappa Nagarahalli > ; Yigit, Ferruh ;

  1   2   >