Jie Zhou <j...@linux.microsoft.com> writes:

> Enable a subset of unit tests on Windows. Currently not all the
> dependencies (e.g. libraries and some functionalities) of all unit
> tests are supported on Windows yet.
>
> Signed-off-by: Jie Zhou <j...@linux.microsoft.com>
> ---

Hi Jie,

How is it expected that a developer will add unit tests here?  For
example, let's pretend I develop some new test.  Do I insert it into the
non-windows section or the 'all' section?  Will it ever be moved common
(for example, do windows development team aim to provide some additional
test / review cycles for new tests added)?  This have some implication
on how developers need to add tests - maybe there can be a documented
process for getting code more common (between windows / linux /
freebsd)?

-Aaron

PS: I would suggest a possible route is to update to the doc proposed in
http://patches.dpdk.org/project/dpdk/patch/20210714164047.511561-1-acon...@redhat.com/
but it still isn't merged.

Reply via email to