> -----Original Message-----
> From: Qiming Chen <chenqiming_hua...@163.com>
> Sent: Monday, September 6, 2021 10:22
> To: dev@dpdk.org
> Cc: Wang, Haiyue <haiyue.w...@intel.com>; Qiming Chen
> <chenqiming_hua...@163.com>; sta...@dpdk.org
> Subject: [PATCH v2] net/ixgbe: fix probability of obtaining mailbox lock
> failure
>
> Ifconfig pf port up/down, after several times, the dpdk vf driver may fail
> to obtain the mailbox lock, resulting in configuration failure and
> functional failure. In order to increase the reliability of mailbox
> communication, the patch uses a trial strategy.
What's your log message like after " --log-level=pmd.net.ixgbe.init:8
--log-level=pmd.net.ixgbe.driver:8" ?
What I got is just a little messages, no more function call. "ifconfig PF
down/up".
testpmd> ixgbevf_intr_disable(): >>
ixgbe_read_mbx(): ixgbe_read_mbx
ixgbe_read_mbx_vf(): ixgbe_read_mbx_vf
ixgbe_obtain_mbx_lock_vf(): ixgbe_obtain_mbx_lock_vf
Port 0: reset event
ixgbevf_intr_enable(): >>
>
> Fixes: af75078fece3 ("first public release")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Qiming Chen <chenqiming_hua...@163.com>
> ---
> v2:
> Modify fixes commit
> ---
> drivers/net/ixgbe/base/ixgbe_mbx.c | 18 +++++++++++++-----
> 1 file changed, 13 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/ixgbe/base/ixgbe_mbx.c
> b/drivers/net/ixgbe/base/ixgbe_mbx.c
> index 4dddff2c58..5a14fcc7b4 100644
> --- a/drivers/net/ixgbe/base/ixgbe_mbx.c
> +++ b/drivers/net/ixgbe/base/ixgbe_mbx.c
> @@ -370,15 +370,23 @@ STATIC s32 ixgbe_check_for_rst_vf(struct ixgbe_hw *hw,
> u16 mbx_id)
> STATIC s32 ixgbe_obtain_mbx_lock_vf(struct ixgbe_hw *hw)
> {
> s32 ret_val = IXGBE_ERR_MBX;
> + s32 timeout = hw->mbx.timeout;
> + s32 usec = hw->mbx.usec_delay;
>
> DEBUGFUNC("ixgbe_obtain_mbx_lock_vf");
>
> - /* Take ownership of the buffer */
> - IXGBE_WRITE_REG(hw, IXGBE_VFMAILBOX, IXGBE_VFMAILBOX_VFU);
> + do {
> + /* Take ownership of the buffer */
> + IXGBE_WRITE_REG(hw, IXGBE_VFMAILBOX, IXGBE_VFMAILBOX_VFU);
>
> - /* reserve mailbox for vf use */
> - if (ixgbe_read_v2p_mailbox(hw) & IXGBE_VFMAILBOX_VFU)
> - ret_val = IXGBE_SUCCESS;
> + /* reserve mailbox for vf use */
> + if (ixgbe_read_v2p_mailbox(hw) & IXGBE_VFMAILBOX_VFU) {
> + ret_val = IXGBE_SUCCESS;
> + break;
> + }
> +
> + usec_delay(usec);
> + } while (timeout--);
>
> return ret_val;
> }
> --
> 2.30.1.windows.1
