Re: [dpdk-dev] [PATCH] doc: announce crypto op struct changes

2021-08-02 Thread Hemant Agrawal
Acked-by: Hemant Agrawal

[dpdk-dev] [PATCH] doc: announce IPsec xform struct changes

2021-08-02 Thread Anoob Joseph
IPsec xform struct would be updated to include IPsec SA lifetime configuration. The existing member 'esn_soft_limit' would only track ESN. And as sequence number control is getting introduced, 'esn_soft_limit' may not indicate the number of packets processed. Replace that with a new structure to co

Re: [dpdk-dev] [PATCH v2] doc: announce changes to eventdev library

2021-08-02 Thread Hemant Agrawal
Acked-by: Hemant Agrawal

Re: [dpdk-dev] [PATCH] doc: abstract the behaviour of rte_ctrl_thread_create

2021-08-02 Thread Ruifeng Wang
> -Original Message- > From: Honnappa Nagarahalli > Sent: Saturday, July 31, 2021 5:45 AM > To: dev@dpdk.org; Honnappa Nagarahalli > ; olivier.m...@6wind.com; > lucp.at.w...@gmail.com; david.march...@redhat.com; > tho...@monjalon.net > Cc: Ruifeng Wang ; nd > Subject: [PATCH] doc: abstrac

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix IPv4 checksum

2021-08-02 Thread Ajit Khaparde
On Mon, Aug 2, 2021 at 11:13 AM Gregory Etelson wrote: > > UDP protocol reserves 0 checksum value for special purposes. > Other protocols, like IPv4, TCP and SCTP must calculate checksum value > in software or offload checksum calculation to hardware. > > If IPv4 TX checksum offload was off and he

Re: [dpdk-dev] [RFC v2 1/3] eventdev: allow for event devices requiring maintenance

2021-08-02 Thread Jerin Jacob
On Mon, Aug 2, 2021 at 9:45 PM Mattias Rönnblom wrote: > > Extend Eventdev API to allow for event devices which require various > forms of internal processing to happen, even when events are not > enqueued to or dequeued from a port. > > RFC v2: > - Change rte_event_maintain() return type to be

Re: [dpdk-dev] [PATCH v2] doc: announce changes to eventdev library

2021-08-02 Thread Jerin Jacob
On Tue, Aug 3, 2021 at 2:46 AM wrote: > > From: Pavan Nikhilesh > > Make driver layer as internal, remove unnecessary rte_ prefix for > structures and functions that are not a part of public API. > Promote experimental trace and vector APIs to stable. > Add reserved field to `rte_event_timer` str

Re: [dpdk-dev] [PATCH] doc: announce: make rte intr handle internal

2021-08-02 Thread Jerin Jacob
On Tue, Aug 3, 2021 at 8:07 AM Xia, Chenbo wrote: > > > -Original Message- > > From: dev On Behalf Of Harman Kalra > > Sent: Tuesday, August 3, 2021 12:04 AM > > To: jer...@marvell.com; david.march...@redhat.com; tho...@monjalon.net; Ray > > Kinsella > > Cc: dev@dpdk.org; Harman Kalra >

Re: [dpdk-dev] [PATCH] doc: announce: make rte intr handle internal

2021-08-02 Thread Xia, Chenbo
> -Original Message- > From: dev On Behalf Of Harman Kalra > Sent: Tuesday, August 3, 2021 12:04 AM > To: jer...@marvell.com; david.march...@redhat.com; tho...@monjalon.net; Ray > Kinsella > Cc: dev@dpdk.org; Harman Kalra > Subject: [dpdk-dev] [PATCH] doc: announce: make rte intr handle

[dpdk-dev] [RFC V2] ethdev: fix issue that dev close in PMD calls twice

2021-08-02 Thread Huisong Li
Ethernet devices in DPDK can be released by rte_eth_dev_close() and rte_dev_remove(). These APIs both call xxx_dev_close() in PMD layer to uninstall hardware. However, the two APIs do not have explicit invocation restrictions. In other words, at the ethdev layer, it is possible to call rte_eth_dev_

Re: [dpdk-dev] [PATCH] doc: announce security API changes for Inline IPsec

2021-08-02 Thread Nithin Dabilpuram
On Sat, Jul 31, 2021 at 12:16:12AM +0200, Thomas Monjalon wrote: > 27/07/2021 19:36, Nithin Dabilpuram: > > Announce changes to make rte_security_set_pkt_metadata() and > > rte_security_get_userdata() inline instead of C functions and > > also addition of another field in structure rte_security_ctx

Re: [dpdk-dev] [PATCH] doc: announce removal of ABIs in PCI bus driver

2021-08-02 Thread Xia, Chenbo
Hi Thomas, > -Original Message- > From: Thomas Monjalon > Sent: Sunday, August 1, 2021 4:44 AM > To: Xia, Chenbo > Cc: dev@dpdk.org; Yigit, Ferruh ; dev@dpdk.org; > m...@ashroe.eu; david.march...@redhat.com; Richardson, Bruce > ; andrew.rybche...@oktetlabs.ru; Ananyev, > Konstantin > Su

Re: [dpdk-dev] [PATCH] doc: announce renaming of mbuf offload flags

2021-08-02 Thread Ajit Khaparde
On Sat, Jul 31, 2021 at 5:15 AM Andrew Rybchenko wrote: > > On 7/30/21 6:57 PM, Olivier Matz wrote: > > The mbuf offload flags do not match the DPDK namespace (they are > > not prefixed by RTE_). Announce their rename in 21.11, and the > > removal of the old names in 22.11. > > > > A draft coccine

Re: [dpdk-dev] [PATCH v3 1/2] ethdev: announce flow API action PORT_ID changes

2021-08-02 Thread Ajit Khaparde
On Mon, Aug 2, 2021 at 12:57 PM Andrew Rybchenko wrote: > > By its very name, action PORT_ID means that packets hit an ethdev with the > given DPDK port ID. At least the current comments don't state the opposite. > > However some drivers implement it in a different way and direct traffic to > the

Re: [dpdk-dev] [PATCH v3 2/2] ethdev: announce clarification of implicit filter by port

2021-08-02 Thread Ajit Khaparde
On Mon, Aug 2, 2021 at 12:57 PM Andrew Rybchenko wrote: > > Transfer flow rules may be applied to traffic entering switch from > many sources. There are flow API pattern items which allow to specify > ingress port match criteria explicitly, but it is not documented > if ethdev port used to create

Re: [dpdk-dev] [PATCH v5] build: optional NUMA and cpu counts detection

2021-08-02 Thread David Christensen
On 8/2/21 5:44 AM, Juraj Linkeš wrote: +if os.name == 'posix': +if os.path.isdir('/sys/devices/system/node'): +numa_nodes = glob.glob('/sys/devices/system/node/node*') +numa_nodes.sort() +print(int(os.path.basename(numa_nodes[-1])[4:]) + 1) +else: +subpr

Re: [dpdk-dev] 5/6] eal/arm64: support register dump for oops

2021-08-02 Thread David Christensen
On 7/30/21 1:49 AM, jer...@marvell.com wrote: From: Jerin Jacob Dump the arm64 arch state register in oops handling routine. Signed-off-by: Jerin Jacob --- lib/eal/unix/eal_oops.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/lib/eal/unix/eal_oops.c b/lib/eal/

Re: [dpdk-dev] [PATCH] doc: announce transition to vDPA port close function

2021-08-02 Thread Thomas Monjalon
18/05/2021 09:34, Thomas Monjalon: > There is a layer violation in the vDPA API which encourages to destroy > a full device with rte_dev_remove() instead of just closing the port. > The plan is to introduce a new function in 21.08, promote in 21.11, > and deprecate rte_vdpa_get_rte_device() in 21.1

Re: [dpdk-dev] 2/6] eal: oops handling API implementation

2021-08-02 Thread David Christensen
On 7/30/21 1:49 AM, jer...@marvell.com wrote: From: Jerin Jacob Implement the base oops handling APIs. Signed-off-by: Jerin Jacob Building on POWER generates the following error: ninja: Entering directory `build' [1/244] Compiling C object 'lib/76b5a35@@rte_eal@sta/eal_unix_eal_oops.c.o

[dpdk-dev] [PATCH v2] devtools: test different build types

2021-08-02 Thread Thomas Monjalon
All builds were of type debugoptimized. It is kept only for builds having an ABI check. Others will have the default build type (release), except if specified differently as in the x86 generic build which will be a test of the non-optimized debug build type. Some static builds will test the minsize

[dpdk-dev] [PATCH v2] app/testpmd: fix IPv4 checksum

2021-08-02 Thread Gregory Etelson
UDP protocol reserves 0 checksum value for special purposes. Other protocols, like IPv4, TCP and SCTP must calculate checksum value in software or offload checksum calculation to hardware. If IPv4 TX checksum offload was off and header checksum was set to 0, testpmd csum engine did not calculate c

Re: [dpdk-dev] [PATCH] app/testpmd: fix IPv4 checksum

2021-08-02 Thread Ajit Khaparde
On Mon, Aug 2, 2021 at 11:00 AM Gregory Etelson wrote: > > UDP protocol reserves 0 checksum value for special purposes. > Other protocols, like IPv4, TCP and SCTP must calculate checksum value > in software or offload checksum calculation to hardware. > > If IPv4 TX checksum offload was off and he

[dpdk-dev] [PATCH] app/testpmd: fix IPv4 checksum

2021-08-02 Thread Gregory Etelson
UDP protocol reserves 0 checksum value for special purposes. Other protocols, like IPv4, TCP and SCTP must calculate checksum value in software or offload checksum calculation to hardware. If IPv4 TX checksum offload was off and header checksum was set to 0, testpmd csum engine did not calculate c

Re: [dpdk-dev] [PATCH v12 01/10] eal: add basic threading functions

2021-08-02 Thread Dmitry Kozlyuk
+ c...@dpdk.org 2021-08-02 14:08 (UTC-0700), Narcisa Ana Maria Vasile: > On Mon, Aug 02, 2021 at 10:32:17AM -0700, Narcisa Ana Maria Vasile wrote: > > From: Narcisa Vasile > > > > Use a portable, type-safe representation for the thread identifier. > > Add functions for comparing thread ids and o

Re: [dpdk-dev] [PATCH] doc: announce crypto op struct changes

2021-08-02 Thread Ananyev, Konstantin
> One reserved byte in rte_crypto_op struct would be used to indicate > warnings and other information from the crypto/security operation. This > field will be used to communicate events such as soft expiry with IPsec > in lookaside mode. > > Signed-off-by: Anoob Joseph > --- > doc/guides/rel_

[dpdk-dev] [PATCH v2] doc: announce changes to eventdev library

2021-08-02 Thread pbhagavatula
From: Pavan Nikhilesh Make driver layer as internal, remove unnecessary rte_ prefix for structures and functions that are not a part of public API. Promote experimental trace and vector APIs to stable. Add reserved field to `rte_event_timer` structure. Signed-off-by: Pavan Nikhilesh --- v2 Cha

Re: [dpdk-dev] [PATCH v12 01/10] eal: add basic threading functions

2021-08-02 Thread Narcisa Ana Maria Vasile
On Mon, Aug 02, 2021 at 10:32:17AM -0700, Narcisa Ana Maria Vasile wrote: > From: Narcisa Vasile > > Use a portable, type-safe representation for the thread identifier. > Add functions for comparing thread ids and obtaining the thread id > for the current thread. > > Signed-off-by: Narcisa Vasil

[dpdk-dev] [RFC v2 3/3] eventdev: have adapters support device maintenance

2021-08-02 Thread Mattias Rönnblom
Introduce support for event devices requiring calls to rte_event_maintain() in the Ethernet RX, Timer and Crypto Eventdev adapters. RFC v2: - For simplicity, the timer adapter now unconditionally calls rte_event_maintain(). - The RX adapter now only calls rte_event_maintain() when it has n

[dpdk-dev] [RFC v2 1/3] eventdev: allow for event devices requiring maintenance

2021-08-02 Thread Mattias Rönnblom
Extend Eventdev API to allow for event devices which require various forms of internal processing to happen, even when events are not enqueued to or dequeued from a port. RFC v2: - Change rte_event_maintain() return type to be consistent with the documentation. - Remove unused typedef from

[dpdk-dev] [RFC v2 2/3] event/dsw: make use of eventdev maintenance facility

2021-08-02 Thread Mattias Rönnblom
Set the RTE_EVENT_DEV_CAP_REQUIRES_MAINT flag, and perform DSW background tasks on rte_event_maintain() calls. RFC v2: Have dsw_event_maintain() occasionally flush the port output buffers. Signed-off-by: Mattias Rönnblom Tested-by: Richard Eklycke Tested-by: Liron Himi --- drivers/eve

[dpdk-dev] [PATCH v3 2/2] ethdev: announce clarification of implicit filter by port

2021-08-02 Thread Andrew Rybchenko
Transfer flow rules may be applied to traffic entering switch from many sources. There are flow API pattern items which allow to specify ingress port match criteria explicitly, but it is not documented if ethdev port used to create flow rule adds any implicit match criteria and how it coexists with

[dpdk-dev] [PATCH v3 1/2] ethdev: announce flow API action PORT_ID changes

2021-08-02 Thread Andrew Rybchenko
By its very name, action PORT_ID means that packets hit an ethdev with the given DPDK port ID. At least the current comments don't state the opposite. However some drivers implement it in a different way and direct traffic to the opposite end of the "wire" plugged to the given ethdev. For example

[dpdk-dev] [PATCH v2 2/2] ethdev: announce clarification of implicit filter by port

2021-08-02 Thread Andrew Rybchenko
Transfer flow rules may be applied to traffic entering switch from many sources. There are flow API pattern items which allow to specify ingress port match criteria explicitly, but it is not documented if ethdev port used to create flow rule adds any implicit match criteria and how it coexists with

[dpdk-dev] [PATCH v2 1/2] ethdev: announce flow API action PORT_ID changes

2021-08-02 Thread Andrew Rybchenko
By its very name, action PORT_ID means that packets hit an ethdev with the given DPDK port ID. At least the current comments don't state the opposite. However some drivers implement it in a different way and direct traffic to the opposite end of the "wire" plugged to the given ethdev. For example

Re: [dpdk-dev] [PATCH] doc: announce: make rte intr handle internal

2021-08-02 Thread Andrew Rybchenko
On 8/2/21 7:03 PM, Harman Kalra wrote: Moving struct rte_intr_handle as an internal structure to avoid any ABI breakages in future. Since this structure defines some static arrays and changing respective macros breaks the ABI. Eg: Currently RTE_MAX_RXTX_INTR_VEC_ID imposes a limit of maximum 512

Re: [dpdk-dev] [PATCH 1/2] ethdev: announce flow API action PORT_ID changes

2021-08-02 Thread Andrew Rybchenko
On 8/2/21 6:49 PM, Ilya Maximets wrote: On 8/1/21 12:22 PM, Andrew Rybchenko wrote: By its very name, action PORT_ID means that packets hit an ethdev with the given DPDK port ID. At least the current comments don't state the opposite. That said, since port representors had been adopted, applicat

Re: [dpdk-dev] [EXT] Re: [PATCH v4] doc: announce API changes for Windows compatibility

2021-08-02 Thread Tal Shnaiderman
> Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v4] doc: announce API changes for > Windows compatibility > > External email: Use caution opening links or attachments > > > > 2021-08-02 12:45 (UTC+), Akhil Goyal: > > > > 21/07/2021 21:55, Dmitry Kozlyuk: > > > > > Windows headers define `s_addr`,

[dpdk-dev] [PATCH] net/mlx5: fix port domain_id initialization

2021-08-02 Thread Gregory Etelson
All active ports that belong to the same E-switch share domain_id value. Port initialization procedure searches through a database for existing port with matching properties. New domain_id allocated if match was not located. Otherwise, new port inherits existing domain_id. Port initialization did

[dpdk-dev] [PATCH] net/mlx5: workaround not supported drop action on the root table

2021-08-02 Thread Suanming Mou
Currently, there are two types of drop action implementation in the PMD. One is the DR(Direct Rules) dummy placeholder drop action and another is the dedicated dummy queue drop action. When creates flow on the root table with DR drop action, the action will be converted to MLX5_IB_ATTR_CREATE_FLOW_

[dpdk-dev] [PATCH 2/2] ethdev: announce moving to general modify function

2021-08-02 Thread Matan Azrad
From: Ori Kam Currently there is a dedicated modify function for each field that the application wants to change. For example: rte_flow_action_type_set_tp_port to modify destination port of UDP/TCP. rte_flow_action_type_set_ipv4_dst to modify destination of IPv4. A new function rte_flow_action_m

[dpdk-dev] [PATCH 1/2] ethdev: announce change to action modify data

2021-08-02 Thread Matan Azrad
From: Ori Kam In the current implementation, the action rte_flow_action_modify_field is not well defined for fields larger than 64 bits (for example IPv6 source) In addtion, the byte order is also not well defined. Both of those issue should be fixed. Signed-off-by: Ori Kam Acked-by: Matan Azr

Re: [dpdk-dev] [EXT] Re: [PATCH v4] doc: announce API changes for Windows compatibility

2021-08-02 Thread Thomas Monjalon
02/08/2021 15:48, Akhil Goyal: > > 2021-08-02 12:45 (UTC+), Akhil Goyal: > > > > 21/07/2021 21:55, Dmitry Kozlyuk: > > > > > Windows headers define `s_addr`, `min`, and `max` as macros. > > > > > If DPDK headers are included after Windows ones, DPDK structure > > > > > definitions containing fi

[dpdk-dev] [PATCH] doc: announce changes to eventdev library

2021-08-02 Thread pbhagavatula
From: Pavan Nikhilesh Make driver layer as internal, remove unnecessary rte_ prefix for structures and functions that are not a part of public API. Promote experimental trace and vector APIs to stable. Add reserved field to `rte_event_timer` structure. Signed-off-by: Pavan Nikhilesh --- doc/gu

[dpdk-dev] [PATCH v12 10/10] Add unit tests for thread API

2021-08-02 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile As a new API for threading is introduced, a set of unit tests have been added to test the new interface. Signed-off-by: Narcisa Vasile --- app/test/meson.build| 2 + app/test/test_threads.c | 419 2 files changed, 421 insertio

[dpdk-dev] [PATCH v12 07/10] eal: implement functions for mutex management

2021-08-02 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Add functions for mutex init, destroy, lock, unlock. Add RTE_STATIC_MUTEX macro to replace static initialization of mutexes. Windows does not have a static initializer. Initialization is only done through InitializeCriticalSection(). The RTE_STATIC_MUTEX calls into the rte_

[dpdk-dev] [PATCH v12 09/10] eal: add EAL argument for setting thread priority

2021-08-02 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Allow the user to choose the thread priority through an EAL command line argument. The user can choose thread priority through an EAL parameter, when starting an application. If EAL parameter is not used, the per-platform default value for thread priority is used. Otherwise

[dpdk-dev] [PATCH v12 06/10] eal: add thread lifetime management

2021-08-02 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Add functions for thread creation, joining, detaching. The *rte_thread_create()* function can optionally receive an rte_thread_attr_t object that will cause the thread to be created with the affinity and priority described by the attributes object. If no rte_thread_attr_t is

[dpdk-dev] [PATCH v12 08/10] eal: implement functions for thread barrier management

2021-08-02 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Add functions for barrier init, destroy, wait. A portable type is used to represent a barrier identifier. The rte_thread_barrier_wait() function returns the same value on all platforms. Signed-off-by: Narcisa Vasile --- lib/eal/common/rte_thread.c | 61 ++

[dpdk-dev] [PATCH v12 05/10] eal: implement thread priority management functions

2021-08-02 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Add function for setting the priority for a thread. Priorities on multiple platforms are similarly determined by a priority value and a priority class/policy. On Linux, the following mapping is created: RTE_THREAD_PRIORITY_NORMAL corresponds to * policy SCHED_OTHER * priorit

[dpdk-dev] [PATCH v12 04/10] eal: implement functions for thread affinity management

2021-08-02 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Implement functions for getting/setting thread affinity. Threads can be pinned to specific cores by setting their affinity attribute. Signed-off-by: Narcisa Vasile Signed-off-by: Dmitry Malloy --- lib/eal/common/rte_thread.c | 16 lib/eal/include/rte_thread.h |

[dpdk-dev] [PATCH v12 03/10] eal/windows: translate Windows errors to errno-style errors

2021-08-02 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Add function to translate Windows error codes to errno-style error codes. The possible return values are chosen so that we have as much semantical compatibility between platforms as possible. Signed-off-by: Narcisa Vasile --- lib/eal/common/rte_thread.c | 6 +-- lib/eal/

[dpdk-dev] [PATCH v12 02/10] eal: add thread attributes

2021-08-02 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Implement thread attributes for: * thread affinity * thread priority Implement functions for managing thread attributes. Priority is represented through an enum that allows for two levels: - RTE_THREAD_PRIORITY_NORMAL - RTE_THREAD_PRIORITY_REALTIME_CRITICAL

[dpdk-dev] [PATCH v12 01/10] eal: add basic threading functions

2021-08-02 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Use a portable, type-safe representation for the thread identifier. Add functions for comparing thread ids and obtaining the thread id for the current thread. Signed-off-by: Narcisa Vasile --- lib/eal/common/meson.build| 1 + lib/eal/{unix => common}/rte_threa

[dpdk-dev] [PATCH v12 00/10] eal: Add EAL API for threading

2021-08-02 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile EAL thread API **Problem Statement** DPDK currently uses the pthread interface to create and manage threads. Windows does not support the POSIX thread programming model, so it currently relies on a header file that hides the Windows calls under pthread matched interfaces. Gi

Re: [dpdk-dev] [PATCH v2] doc: update atomic operation deprecation

2021-08-02 Thread Thomas Monjalon
02/08/2021 19:22, Honnappa Nagarahalli: > From: Thomas Monjalon > > 23/07/2021 11:49, Joyce Kong: > > Considering all the questions regarding usage of atomics, I still think we > > need a > > documentation about their correct use. > > I think few things to document are: > 1) Use of __atomic_add_

Re: [dpdk-dev] [PATCH v2] doc: update atomic operation deprecation

2021-08-02 Thread Honnappa Nagarahalli
> -Original Message- > From: Thomas Monjalon > Sent: Saturday, July 31, 2021 3:27 PM > To: Honnappa Nagarahalli ; Ruifeng Wang > ; Joyce Kong > Cc: step...@networkplumber.org; m...@ashroe.eu; dev@dpdk.org; nd > ; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] doc: update atomic o

[dpdk-dev] [PATCH 2/2] doc: announce eth new offload flag and group field

2021-08-02 Thread Xueming Li
To support shared Rx queue, this patch announces new offload flag RTE_ETH_RX_OFFLOAD_SHARED_RXQ and new shared_group field to struct rte_eth_rxconf in DPDK v21.11. [1] mail list discussion: https://mails.dpdk.org/archives/dev/2021-July/215575.html Signed-off-by: Xueming Li --- doc/guides/rel_no

[dpdk-dev] [PATCH 1/2] doc: announce eth queue release callback parameter change

2021-08-02 Thread Xueming Li
This patch announces the parameter change of eth_queue_release_t callback API to eth_dev_ops in DPDK v21.11. [1] mail list discussion: https://mails.dpdk.org/archives/dev/2021-July/215654.html Signed-off-by: Xueming Li --- doc/guides/rel_notes/deprecation.rst | 3 +++ 1 file changed, 3 insertio

[dpdk-dev] [RFC] app/testpmd: update to support shared Rx queue

2021-08-02 Thread Xueming(Steven) Li
To support shared Rx queue[1], plan to update testpmd with following changes: - Add ``--rxq-share`` to enable shared Rx queue if device supports. - In verbose mode, dump mbuf->port for each received packet. - Check forwarding configuration to make sure queue streams of same share group scheduled

[dpdk-dev] [PATCH v2] net/mlx5: fix vni matching with non-std port at ConnectX-5

2021-08-02 Thread Rongwei Liu
In the recent update, the misc5 matcher was introduced to match VxLAN header extra fields. However, ConnectX-5 doesn't support misc5 for the UDP ports different from VXLAN's standard one (4789). Need to fall back to the previous approach and use legacy misc matcher if non-standard UDP port is reco

Re: [dpdk-dev] [PATCH] net: announce changes in IPv4 header

2021-08-02 Thread Slava Ovsiienko
> -Original Message- > From: dev On Behalf Of Gregory Etelson > Sent: Monday, August 2, 2021 13:39 > To: dev@dpdk.org > Cc: Gregory Etelson ; Matan Azrad > ; Raslan Darawsheh ; Ori Kam > ; Ray Kinsella > Subject: [dpdk-dev] [PATCH] net: announce changes in IPv4 header > > Announce change

Re: [dpdk-dev] [PATCH] net: announce changes in TCP header

2021-08-02 Thread Slava Ovsiienko
> -Original Message- > From: dev On Behalf Of Gregory Etelson > Sent: Monday, August 2, 2021 13:42 > To: dev@dpdk.org > Cc: Gregory Etelson ; Matan Azrad > ; Raslan Darawsheh ; Ori Kam > ; Ray Kinsella > Subject: [dpdk-dev] [PATCH] net: announce changes in TCP header > > Announce change

[dpdk-dev] [PATCH] doc: announce: make rte intr handle internal

2021-08-02 Thread Harman Kalra
Moving struct rte_intr_handle as an internal structure to avoid any ABI breakages in future. Since this structure defines some static arrays and changing respective macros breaks the ABI. Eg: Currently RTE_MAX_RXTX_INTR_VEC_ID imposes a limit of maximum 512 MSI-X interrupts that can be defined for

Re: [dpdk-dev] [PATCH 1/2] ethdev: announce flow API action PORT_ID changes

2021-08-02 Thread Ilya Maximets
On 8/1/21 12:22 PM, Andrew Rybchenko wrote: > By its very name, action PORT_ID means that packets hit an ethdev with the > given DPDK port ID. At least the current comments don't state the opposite. > That said, since port representors had been adopted, applications like OvS > have been misusing th

Re: [dpdk-dev] [PATCH] doc: announce extension of crypto data-unit length

2021-08-02 Thread Matan Azrad
From: Thomas Monjalon > The struct member dataunit_len is introduced in DPDK 21.05. > It is limited to 16 bits to fit a padding hole in 32-bit build. > This means the maximum data-unit length is 64 KB. > Some use cases may benefit of a bigger size as the proposed 32 bits. > > Signed-off-by: Tho

Re: [dpdk-dev] L3fwd mode in testpmd

2021-08-02 Thread Dharmik Thakkar
Hi, Kathleen has submitted an RFC patch [1] in this regard. We’d appreciate your comments. [1] https://patches.dpdk.org/project/dpdk/patch/20210430213747.41530-2-kathleen.cape...@arm.com/ Thank you! > On Apr 30, 2021, at 4:28 AM, Ananyev, Konstantin > wrote: > >> >> >> On Thu, Apr 29, 2021

[dpdk-dev] [PATCH] net: announce changes in TCP header

2021-08-02 Thread Gregory Etelson
Announce change to add a union that will provide byte and bitfield access to TCP flags. Signed-off-by: Gregory Etelson --- doc/guides/rel_notes/deprecation.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst inde

[dpdk-dev] [PATCH] net: announce changes in IPv4 header

2021-08-02 Thread Gregory Etelson
Announce changes to add 2 unions. The first union will provide integral and bits access to version and IHL. The second union will provide integral and bits access to fragment flags and offset. Signed-off-by: Gregory Etelson --- doc/guides/rel_notes/deprecation.rst | 5 + 1 file changed, 5 in

Re: [dpdk-dev] [PATCH 2/2] ethdev: announce clarification of implicit filter by port

2021-08-02 Thread Ori Kam
Hi Andrew, Acked-by: Ori Kam Best, Ori > -Original Message- > From: Andrew Rybchenko > Sent: Sunday, August 1, 2021 1:22 PM

[dpdk-dev] [PATCH] net/mlx5: fix vni matching with non-std port

2021-08-02 Thread Rongwei Liu
In the recent update, the misc5 matcher was introduced to match VxLAN header extra fields. However, ConnectX-5 doesn't support misc5 for the UDP ports different from VXLAN's standard one (4789). Need to fall back to the previous approach and use legacy misc matcher if non-standard UDP port is reco

[dpdk-dev] [PATCH 1/1] drivers/net/e1000: igbvf_vlan_offload_config and igbvf_vlan_offload_set implementation

2021-08-02 Thread Renata Saiakhova
igbvf_vlan_offload_config and igbvf_vlan_offload_set primal implementation, setting vlan filter mask at igbvf_dev_start time. Without the above a vlan filter for igbvf is not functional. Signed-off-by: Renata Saiakhova --- drivers/net/e1000/igb_ethdev.c | 28 1 file

[dpdk-dev] [PATCH 0/1] drivers/net/e1000: igbvf_vlan_offload_config and igbvf_vlan_offload_set implementation

2021-08-02 Thread Renata Saiakhova
igbvf_vlan_offload_config and igbvf_vlan_offload_set primal implementation, setting vlan filter mask at igbvf_dev_start time. Without setting ETH_VLAN_FILTER_OFFLOAD for offload mask by using the functions above it is not possible to configure and use a vlan filter for igbvf. Consider rte_eth_dev_v

[dpdk-dev] [Bug 767] Why do the Outlook rules not work in my account?

2021-08-02 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=767 Ajit Khaparde (ajit.khapa...@broadcom.com) changed: What|Removed |Added CC||ajit.khapa...@broadcom

[dpdk-dev] [Bug 766] Best sites to download free antivirus

2021-08-02 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=766 Ajit Khaparde (ajit.khapa...@broadcom.com) changed: What|Removed |Added CC||ajit.khapa...@broadcom

Re: [dpdk-dev] [EXT] Re: [PATCH v4] doc: announce API changes for Windows compatibility

2021-08-02 Thread Akhil Goyal
> 2021-08-02 12:45 (UTC+), Akhil Goyal: > > > 21/07/2021 21:55, Dmitry Kozlyuk: > > > > Windows headers define `s_addr`, `min`, and `max` as macros. > > > > If DPDK headers are included after Windows ones, DPDK structure > > > > definitions containing fields with these names get broken (example

[dpdk-dev] [PATCH] [v2] pipeline: fix table stats

2021-08-02 Thread Churchill Khangar
This patch fixes the memcpy function call which was incorrect and led to memory corruption for tables with more that just a few actions. Fixes: 742b0a57f50e4 ("pipeline: add table statistics to SWX") Cc: sta...@dpdk.org Signed-off-by: Churchill Khangar Acked-by: Cristian Dumitrescu --- lib/pip

Re: [dpdk-dev] [PATCH] doc: announce renaming of mbuf offload flags

2021-08-02 Thread Jerin Jacob
On Sat, Jul 31, 2021 at 5:45 PM Andrew Rybchenko wrote: > > On 7/30/21 6:57 PM, Olivier Matz wrote: > > The mbuf offload flags do not match the DPDK namespace (they are > > not prefixed by RTE_). Announce their rename in 21.11, and the > > removal of the old names in 22.11. > > > > A draft coccine

Re: [dpdk-dev] [EXT] Re: [PATCH v4] doc: announce API changes for Windows compatibility

2021-08-02 Thread Dmitry Kozlyuk
2021-08-02 12:45 (UTC+), Akhil Goyal: > > 21/07/2021 21:55, Dmitry Kozlyuk: > > > Windows headers define `s_addr`, `min`, and `max` as macros. > > > If DPDK headers are included after Windows ones, DPDK structure > > > definitions containing fields with these names get broken (example 1), > >

Re: [dpdk-dev] [PATCH 1/2] ethdev: announce flow API action PORT_ID changes

2021-08-02 Thread Ori Kam
Acked-by: Ori Kam Thanks, Ori

[dpdk-dev] [RFC V1] ethdev: fix the issue that dev uninit may be called twice

2021-08-02 Thread Huisong Li
Ethernet devices in DPDK can be released by rte_eth_dev_close() and rte_dev_remove(). However, these two APIs do not have explicit invocation restrictions. In other words, at the ethdev layer, calling rte_eth_dev_close() and then rte_dev_remove() or rte_eal_hotplug_remove() is allowed. In such a ba

Re: [dpdk-dev] [EXT] Re: [PATCH v4] doc: announce API changes for Windows compatibility

2021-08-02 Thread Akhil Goyal
> 21/07/2021 21:55, Dmitry Kozlyuk: > > Windows headers define `s_addr`, `min`, and `max` as macros. > > If DPDK headers are included after Windows ones, DPDK structure > > definitions containing fields with these names get broken (example 1), > > as well as any usage of such fields (example 2). If

Re: [dpdk-dev] [PATCH v5] build: optional NUMA and cpu counts detection

2021-08-02 Thread Juraj Linkeš
> +if os.name == 'posix': > +if os.path.isdir('/sys/devices/system/node'): > +numa_nodes = glob.glob('/sys/devices/system/node/node*') > +numa_nodes.sort() > +print(int(os.path.basename(numa_nodes[-1])[4:]) + 1) > +else: > +subprocess.run(['sysctl', '-n', 'vm

Re: [dpdk-dev] [PATCH] doc: announce SA config option struct changes

2021-08-02 Thread Akhil Goyal
> Hi Akhil, > > There are 2 more items that I would like to add. > - IV gen (in ``rte_security_ipsec_sa_options``) > - SA lifetime configuration (in ``rte_security_ipsec_xform``) > > http://patches.dpdk.org/project/dpdk/patch/1626759974-334-2-git-send- > email-ano...@marvell.com/ > http://patches

Re: [dpdk-dev] [PATCH] net: announce changes in IPv4 header

2021-08-02 Thread Akhil Goyal
> > -Original Message- > > From: dev On Behalf Of Gregory Etelson > > Sent: Monday, August 2, 2021 13:39 > > To: dev@dpdk.org > > Cc: Gregory Etelson ; Matan Azrad > > ; Raslan Darawsheh ; Ori Kam > > ; Ray Kinsella > > Subject: [dpdk-dev] [PATCH] net: announce changes in IPv4 header > >

Re: [dpdk-dev] [PATCH] doc: announce crypto op struct changes

2021-08-02 Thread Akhil Goyal
> One reserved byte in rte_crypto_op struct would be used to indicate > warnings and other information from the crypto/security operation. This > field will be used to communicate events such as soft expiry with IPsec > in lookaside mode. > > Signed-off-by: Anoob Joseph > --- Acked-by: Akhil Goya

[dpdk-dev] [dpdk-announce] URGENT: review of deprecation notices before closing 21.08

2021-08-02 Thread Thomas Monjalon
The next release 21.11 will allow API/ABI breaking changes. The process is to announce such changes in the previous release notes. We are closing the release 21.08 this week so it becomes very urgent to review all these notices and vote (ack) or reject them now. For convenience, I am adding those

Re: [dpdk-dev] [PATCH v4] doc: announce API changes for Windows compatibility

2021-08-02 Thread Thomas Monjalon
21/07/2021 21:55, Dmitry Kozlyuk: > Windows headers define `s_addr`, `min`, and `max` as macros. > If DPDK headers are included after Windows ones, DPDK structure > definitions containing fields with these names get broken (example 1), > as well as any usage of such fields (example 2). If DPDK head

[dpdk-dev] [PATCH] pipeline: fix table stats

2021-08-02 Thread Churchill Khangar
This patch fixes syntax of memcpy function to copy arrays which was wrong typically leading to memory corruption for more than a few actions involved. Fixes: 742b0a57f50e4 ("pipeline: add table statistics to SWX") Signed-off-by: Churchill Khangar Acked-by: Cristian Dumitrescu --- lib/pipeline/

Re: [dpdk-dev] [PATCH] doc: announce extension of crypto data-unit length

2021-08-02 Thread Thomas Monjalon
14/04/2021 22:15, Thomas Monjalon: > The struct member dataunit_len is introduced in DPDK 21.05. > It is limited to 16 bits to fit a padding hole in 32-bit build. > This means the maximum data-unit length is 64 KB. > Some use cases may benefit of a bigger size as the proposed 32 bits. > > Signed-o

Re: [dpdk-dev] [PATCH 1/2] ethdev: announce flow API action PORT_ID changes

2021-08-02 Thread Ori Kam
> -Original Message- > From: Andrew Rybchenko > > On 8/1/21 7:13 PM, Ori Kam wrote: > > Hi Andrew, > > > >> -Original Message- > >> From: Andrew Rybchenko > >> Sent: Sunday, August 1, 2021 4:24 PM > >> Subject: Re: [PATCH 1/2] ethdev: announce flow API action PORT_ID > >> chan

Re: [dpdk-dev] [PATCH] app/test: quieten noise while forking

2021-08-02 Thread Thomas Monjalon
01/08/2021 19:53, John Levon: > When closing file descriptors post-fork, ignore "." and ".." directory > entries, so the test log doesn't have distracting errors like: > > Error converting name fd 0 .: > Error converting name fd 0 ..: > > Signed-off-by: John Levon Applied, thanks. For info, wh

Re: [dpdk-dev] [PATCH v4] app/testpmd: fix TX checksum calculation for tunnel

2021-08-02 Thread Jiang, YuX
> -Original Message- > From: dev On Behalf Of Thomas Monjalon > Sent: Friday, July 30, 2021 8:04 PM > To: Gregory Etelson > Cc: dev@dpdk.org; Ajit Khaparde ; Andrew > Rybchenko ; Yigit, Ferruh > ; sta...@dpdk.org; Li, Xiaoyun > ; Tomasz Kulasek ; > Ananyev, Konstantin ; Olivier Matz > >

[dpdk-dev] [PATCH] doc: announce crypto op struct changes

2021-08-02 Thread Anoob Joseph
One reserved byte in rte_crypto_op struct would be used to indicate warnings and other information from the crypto/security operation. This field will be used to communicate events such as soft expiry with IPsec in lookaside mode. Signed-off-by: Anoob Joseph --- doc/guides/rel_notes/deprecation.

Re: [dpdk-dev] [PATCH] net/mlx5: fix vni matching with non-std port

2021-08-02 Thread Thomas Monjalon
02/08/2021 12:26, Rongwei Liu: > In the recent update, the misc5 matcher was introduced to > match VxLAN header extra fields. However, ConnectX-5 > doesn't support misc5 for the UDP ports different from > VXLAN's standard one (4789). > > Need to fall back to the previous approach and use legacy >

[dpdk-dev] [Bug 768] [dpdk-21.08] received pkts with bad ip-checksum when send ip-checksum=0 pkts

2021-08-02 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=768 Bug ID: 768 Summary: [dpdk-21.08] received pkts with bad ip-checksum when send ip-checksum=0 pkts Product: DPDK Version: 21.08 Hardware: x86 OS: Linux St

Re: [dpdk-dev] [PATCH] net: announce changes in IPv4 header

2021-08-02 Thread Andrew Rybchenko
On 8/2/21 1:38 PM, Gregory Etelson wrote: Announce changes to add 2 unions. The first union will provide integral and bits access to version and IHL. The second union will provide integral and bits access to fragment flags and offset. Signed-off-by: Gregory Etelson Acked-by: Andrew Rybchenko

[dpdk-dev] [PATCH v1 12/12] app: remove unnecessary include of atomic

2021-08-02 Thread Joyce Kong
Remove the unnecessary rte_atomic.h included in app module. Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang --- app/proc-info/main.c | 1 - app/test-pipeline/config.c | 1 - app/test-pipeline/init.c | 1 - app/test-pipeline/main.c | 1 - app/test-pipeline/runtime.c | 1 -

[dpdk-dev] [PATCH v1 11/12] app/bbdev: use compiler atomics for thread sync

2021-08-02 Thread Joyce Kong
Convert rte_atomic usages to compiler atomic built-ins for thread params sync in bbdev cases. Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang --- app/test-bbdev/test_bbdev_perf.c | 135 ++- 1 file changed, 59 insertions(+), 76 deletions(-) diff --git a/app/test-

[dpdk-dev] [PATCH v1 10/12] app/testpmd: use compiler atomic builtins for port sync

2021-08-02 Thread Joyce Kong
Replace rte_atomic16_cmpset operation with compiler atomic CAS operation for port status sync in testpmd case. Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang --- app/test-pmd/testpmd.c | 75 +++--- 1 file changed, 48 insertions(+), 27 deletions(-) diff

[dpdk-dev] [PATCH v1 09/12] app/compress: use compiler atomic builtins for display sync

2021-08-02 Thread Joyce Kong
Convert rte_atomic_test_and_set usage to compiler atomic CAS operation for display sync. Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang --- app/test-compress-perf/comp_perf_test_common.h | 2 +- app/test-compress-perf/comp_perf_test_cyclecount.c | 10 +++--- app/test-compress-perf

  1   2   >