> -----Original Message-----
> From: dev <dev-boun...@dpdk.org> On Behalf Of Thomas Monjalon
> Sent: Friday, July 30, 2021 8:04 PM
> To: Gregory Etelson <getel...@nvidia.com>
> Cc: dev@dpdk.org; Ajit Khaparde <ajit.khapa...@broadcom.com>; Andrew
> Rybchenko <andrew.rybche...@oktetlabs.ru>; Yigit, Ferruh
> <ferruh.yi...@intel.com>; sta...@dpdk.org; Li, Xiaoyun
> <xiaoyun...@intel.com>; Tomasz Kulasek <tomaszx.kula...@intel.com>;
> Ananyev, Konstantin <konstantin.anan...@intel.com>; Olivier Matz
> <olivier.m...@6wind.com>
> Subject: Re: [dpdk-dev] [PATCH v4] app/testpmd: fix TX checksum
> calculation for tunnel
>
> 30/07/2021 10:39, Olivier Matz:
> > On Thu, Jul 29, 2021 at 08:01:41PM +0300, Gregory Etelson wrote:
> > > csumonly engine calculates TX checksum of a tunnelled packet for
> > > outer headers only or separately for outer and inner headers. The
> > > calculation method is determined by checksum configuration options.
> > > If TX checksum calculation is separated, the inner headers are
> > > processed before outer headers.
> > >
> > > Inner headers processing sets checksum values to 0 unconditionally.
> > > If TX configuration offloads inner checksums only, outer checksum
> > > calculation in software will read 0 instead of real values and
> > > produce wrong result.
> > >
> > > The patch zeroes inner checksums only before software calculation.
> > >
> > > Fixes: 6b520d54ebfe ("app/testpmd: use Tx preparation in checksum
> > > engine")
> > > Cc: sta...@dpdk.org
> > >
> > > Signed-off-by: Gregory Etelson <getel...@nvidia.com>
> >
> > Acked-by: Olivier Matz <olivier.m...@6wind.com>
> >
>
> The previous acks were forgotten (it should be added manually in the patch):
>
> Acked-by: Ori Kam <or...@nvidia.com>
> Acked-by: Ajit Khaparde <ajit.khapa...@broadcom.com>
> Acked-by: Xiaoyun Li <xiaoyun...@intel.com>
>
> Applied, thanks.
>
Hi Gregory and All,
When we test checksum_offload related test cases based on dpdk21.08-rc3, we
find that received pkts with bad ip-checksum when send ip-checksum=0 pkts.
We find this patch is the first bad commit id. Could you pls have a quick look?
More detailed refer to https://bugs.dpdk.org/show_bug.cgi?id=768
