[dpdk-dev] [PATCH] net/virtio: fix memory leak in dev close

2021-07-24 Thread Gaoxiang Liu
Free the "intr_handle" memory in virtio_user_dev_uninit() to avoid memory leak. when virtio user dev closes, the "intr_handle" memory is not freeed that is alloced in virtio_user_fill_intr_handle(). Fixes: 7f468b2ebfad ("net/virtio: release port upon close") Signed-off-by: Gaoxiang Liu --- driv

Re: [dpdk-dev] [PATCH v3] eal: fix argument to rte_bsf32_safe

2021-07-24 Thread Stephen Hemminger
On Sat, 24 Jul 2021 09:58:44 +0200 Thomas Monjalon wrote: > 23/07/2021 17:45, Stephen Hemminger: > > The first argument to rte_bsf32_safe was incorrectly declared as > > a 64 bit value. The code only works on 32 bit values and the underlying > > function rte_bsf32 only accepts 32 bit values. This

[dpdk-dev] [PATCH] net/mlx5: fix queue leaking in hairpin auto bind checking

2021-07-24 Thread Bing Zhao
During the start up stage, the hairpin auto bind was executed for each port. All the Tx and Rx queues configured for this port should be checked to confirm if the auto bind of hairpin is needed. 1. The queue is hairpin queue. 2. The peer port is the same one and the peer queue should also be wit

Re: [dpdk-dev] [PATCH] app/testpmd: fix TX checksum calculation for tunnel

2021-07-24 Thread Gregory Etelson
> Please we need more reviews for this patch. > I'll update the patch and post a v2. > 19/07/2021 10:33, Gregory Etelson: > > TX checksum of a tunnelled packet can be calculated for outer headers > > only or for both outer and inner parts. The calculation method is > > determined by application.

[dpdk-dev] [PATCH v2] eventdev: fix event port setup in tx adapter

2021-07-24 Thread Naga Harish K, S V
The event port config set by application in rte_event_eth_tx_adapter_create API is modified in default configuration callback function. This patch removes this hardcode to use application provided event port config value. Fixes: ("eventdev: fix event port config override in tx adapter") Signed-of

[dpdk-dev] [PATCH v2] eventdev: fix event port setup in tx adapter

2021-07-24 Thread Naga Harish K, S V
The event port config set by application in rte_event_eth_tx_adapter_create API is modified in default configuration callback function. This patch removes this hardcode to use application provided event port config value. Fixes: ("eventdev: fix event port config override in tx adapter") Signed-of

[dpdk-dev] [dpdk-announce] release candidate 21.08-rc2

2021-07-24 Thread Thomas Monjalon
A new DPDK release candidate is ready for testing: https://git.dpdk.org/dpdk/tag/?id=v21.08-rc2 There are 287 new patches in this snapshot, most of them adding or fixing features in drivers. Release notes: https://doc.dpdk.org/guides/rel_notes/release_21_08.html Highlights of 21.

Re: [dpdk-dev] [PATCH] app/acl: add script for automate testing

2021-07-24 Thread Thomas Monjalon
18/05/2021 13:26, Konstantin Ananyev: > The purpose of this script is to help automate ACL library functional > testing using test-acl app. > Sample input files are also provided. > > Signed-off-by: Konstantin Ananyev The input files make the script devtools/check-spdx-tag.sh failing.

Re: [dpdk-dev] [PATCH v3] app/testpmd: send failure logs to stderr

2021-07-24 Thread Thomas Monjalon
> > Running with stdout suppressed or redirected for further processing > > is very confusing in the case of errors. Fix it by logging errors and > > warnings to stderr. > > > > Since lines with log messages are touched anyway concatenate split > > format strings to make it easier to search using

Re: [dpdk-dev] [PATCH] app/testpmd: remove most uses of rte_eth_devices

2021-07-24 Thread Thomas Monjalon
15/07/2021 16:52, Ferruh Yigit: > On 7/15/2021 3:20 PM, Paulis Gributs wrote: > > This patch removes most uses of the global variable rte_eth_devices > > from testpmd. This was done to avoid using the object directly which > > applications should not do. > > > > Most uses have been replaced with s

[dpdk-dev] [PATCH v4 2/2] ethdev: fix docs of drivers callbacks getting xstats by IDs

2021-07-24 Thread Andrew Rybchenko
From: Ivan Ilchenko Update xstats by IDs callbacks documentation in accordance with ethdev usage of these callbacks. Document valid combinations of input arguments to make driver implementation simpler. Fixes: 79c913a42f0 ("ethdev: retrieve xstats by ID") Cc: sta...@dpdk.org Signed-off-by: Ivan

[dpdk-dev] [PATCH v4 1/2] ethdev: fix docs of functions getting xstats by IDs

2021-07-24 Thread Andrew Rybchenko
From: Ivan Ilchenko Document valid combinations of input arguments in accordance with current implementation in ethdev. Fixes: 79c913a42f0 ("ethdev: retrieve xstats by ID") Cc: sta...@dpdk.org Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- lib/eth

Re: [dpdk-dev] [PATCH v3 03/11] ethdev: fix docs of functions getting xstats by IDs

2021-07-24 Thread Andrew Rybchenko
On 7/23/21 5:42 PM, Ferruh Yigit wrote: On 7/23/2021 2:15 PM, Andrew Rybchenko wrote: From: Ivan Ilchenko Document valid combinations of input arguments in accordance with current implementation in ethdev. Fixes: 79c913a42f0 ("ethdev: retrieve xstats by ID") Cc: sta...@dpdk.org Signed-off-by

Re: [dpdk-dev] [PATCH 03/11] ethdev: fix docs of functions getting xstats by IDs

2021-07-24 Thread Andrew Rybchenko
On 7/23/21 5:19 PM, Ferruh Yigit wrote: On 7/22/2021 10:12 AM, Andrew Rybchenko wrote: On 7/20/21 7:25 PM, Ferruh Yigit wrote: On 6/4/2021 3:42 PM, Andrew Rybchenko wrote: From: Ivan Ilchenko Document valid combinations of input arguments in accordance with current implementation in ethdev.

Re: [dpdk-dev] [PATCH v16] app/testpmd: support multi-process

2021-07-24 Thread Thomas Monjalon
10/07/2021 05:50, Min Hu (Connor): > This patch adds multi-process support for testpmd. > For example the following commands run two testpmd > processes: > > * the primary process: > > ./dpdk-testpmd --proc-type=auto -l 0-1 -- -i \ >--rxq=4 --txq=4 --num-procs=2 --proc-id=0 > > * the secon

Re: [dpdk-dev] [PATCH] app/testpmd: fix TX checksum calculation for tunnel

2021-07-24 Thread Thomas Monjalon
Please we need more reviews for this patch. 19/07/2021 10:33, Gregory Etelson: > TX checksum of a tunnelled packet can be calculated for outer headers > only or for both outer and inner parts. The calculation method is > determined by application. > If TX checksum calculation can be offloaded, har

Re: [dpdk-dev] [PATCH v1] app/testpmd: fix port MAC address after resetting port

2021-07-24 Thread Thomas Monjalon
> > MAC address of each port in global variable ports hasn't been updated after > > resetting. It was the initial one after resetting VF MAC address. > > This patch gets correct port MAC address when starting port. > > > > Fixes: a5279d25616d ("app/testpmd: check status of getting MAC address") >

Re: [dpdk-dev] [PATCH] app/testpmd: fix help string for port reset

2021-07-24 Thread Thomas Monjalon
23/07/2021 21:36, Andrew Rybchenko: > On 7/23/21 3:24 PM, Ferruh Yigit wrote: > > Command help string is missing 'reset' keyword, although description has > > it. Adding it. > > > > Fixes: 97f1e196799f ("app/testpmd: add port reset command") > > Cc: sta...@dpdk.org > > > > Signed-off-by: Ferruh Y

Re: [dpdk-dev] [EXT] Re: [PATCH] config/arm: add ability to express arch extensions

2021-07-24 Thread Thomas Monjalon
18/05/2021 15:20, Honnappa Nagarahalli: > Are we concluding there is no solution? Should I mark this patch as rejected?

Re: [dpdk-dev] [PATCH v1 0/8] gro: support TCP/IPv6 and UDP/IPv6 for VLAN and VXLAN

2021-07-24 Thread Thomas Monjalon
24/03/2021 22:22, Thomas Monjalon: > 21/12/2020 04:50, yang_y...@163.com: > > Yi Yang (8): > > gro: support TCP/IPv6 > > gro: support IPv4 VXLAN TCP/IPv6 > > gro: support IPv6 VXLAN TCP/IPv4 > > gro: support IPv6 VXLAN TCP/IPv6 > > gro: support UDP/IPv6 > > gro: support IPv4 VXLAN UDP/I

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] mbuf: fix reset on mbuf free

2021-07-24 Thread Thomas Monjalon
What's the follow-up for this patch? 19/01/2021 15:04, Slava Ovsiienko: > Hi, All > > Could we postpose this patch at least to rc2? We would like to conduct more > investigations? > > With best regards, Slava > > From: Olivier Matz > > On Mon, Jan 18, 2021 at 05:52:32PM +, Ali Alnubani wr

Re: [dpdk-dev] [PATCH 0/2] bugfix for sched

2021-07-24 Thread Thomas Monjalon
23/04/2021 13:01, Min Hu (Connor): > This patch set contains two bugfixes for sched. > > Huisong Li (2): > lib/sched: fix return value judgment > lib/sched: optimize exception handling code Acked-by: Cristian Dumitrescu Applied, thanks.

Re: [dpdk-dev] [dpdk-stable] [PATCH v3 1/1] power: check freq count before filling the freqs array

2021-07-24 Thread Thomas Monjalon
23/07/2021 10:37, David Hunt: > Hi Richael, > > On 23/7/2021 3:22 AM, Richael Zhuang wrote: > > The freqs array size is RTE_MAX_LCORE_FREQS. Before filling the > > array with num_freqs elements, restrict the total num to > > RTE_MAX_LCORE_FREQS. This fix aims to fix the coverity scan issue > > lik

Re: [dpdk-dev] [PATCH v3] eal: fix argument to rte_bsf32_safe

2021-07-24 Thread Thomas Monjalon
23/07/2021 17:45, Stephen Hemminger: > The first argument to rte_bsf32_safe was incorrectly declared as > a 64 bit value. The code only works on 32 bit values and the underlying > function rte_bsf32 only accepts 32 bit values. This was a mistake > introduced when the safe version was added and prob