15/07/2021 16:52, Ferruh Yigit: > On 7/15/2021 3:20 PM, Paulis Gributs wrote: > > This patch removes most uses of the global variable rte_eth_devices > > from testpmd. This was done to avoid using the object directly which > > applications should not do. > > > > Most uses have been replaced with standard function calls, however > > the use of it in the show_macs function could not be replaced as no > > function call exists to get all mac addresses of a given port. > > > > Signed-off-by: Paulis Gributs <paulis.grib...@intel.com> > > Reviewed-by: Ferruh Yigit <ferruh.yi...@intel.com> > > +1 to eliminate 'rte_eth_devices' access from application
Acked-by: Xiaoyun Li <xiaoyun...@intel.com> Applied, thanks that's a good step. However, I think we should not expose the rte_device pointer at all as it is done in rte_eth_dev_info.
