Re: [dpdk-dev] [PATCH v2] net/bnxt: fix rxq interrupt setting

2021-07-02 Thread Ajit Khaparde
On Thu, Jul 1, 2021 at 6:24 PM Ajit Khaparde wrote: > Don't set rxq interrupt config > Applications can set the rxq interrupt config to 1 or 0 as needed. > If an application is not interested in handling Rx interrupts and > prefers to poll Rx rings, there is no need for the PMD to set this > conf

Re: [dpdk-dev] [PATCH] ethdev: keep count of allocated and used representor ranges

2021-07-02 Thread Xueming(Steven) Li
Hi > -Original Message- > From: Andrew Rybchenko > Sent: Friday, July 2, 2021 10:23 PM > To: Matan Azrad ; Shahaf Shuler ; Slava > Ovsiienko ; NBU- > Contact-Thomas Monjalon ; Ferruh Yigit > ; Xueming(Steven) Li > > Cc: dev@dpdk.org; Viacheslav Galaktionov > ; sta...@dpdk.org > Subjec

Re: [dpdk-dev] dmadev discussion summary

2021-07-02 Thread fengchengwen
On 2021/7/2 22:57, Morten Brørup wrote: >> In the DPDK framework, many data-plane API names contain queues. e.g. >> eventdev/crypto.. >> The concept of virt queues has continuity. > > I was also wondering about the name "virtual queue". > > Usually, something "virtual" would be an abstraction of

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] table: fix typo

2021-07-02 Thread Dumitrescu, Cristian
> > > > > > > Hi Thierry, > > > > > > > > > > > > > > I think Thomas is asking for you to send a new version of this > > > > > > > patch > > with > > > > > the title updated. Is this OK with you? > > > > > > > > > > No need to send a v3. > > > > > > > > OK, so you're going to fix the title while

Re: [dpdk-dev] [PATCH] test: fix crypto_op length for sessionless case

2021-07-02 Thread Ferruh Yigit
On 7/2/2021 7:08 PM, Gujjar, Abhinandan S wrote: > Hi Aaron/dpdklab, > > This patch's CI seems to have lot of false positive! > Ferruh triggered the re-test sometime back. Now, it is reporting less. > Could you please check from your end? Thanks! > Only a malloc related unit test is still failin

[dpdk-dev] [PATCH V3 5/5] examples/pipeline: add selector example

2021-07-02 Thread Cristian Dumitrescu
Added the files to illustrate the selector table usage. Signed-off-by: Cristian Dumitrescu --- examples/pipeline/examples/selector.cli | 31 examples/pipeline/examples/selector.spec | 95 examples/pipeline/examples/selector.txt | 4 + 3 files changed, 130 ins

[dpdk-dev] [PATCH V3 4/5] examples/pipeline: add support for selector tables

2021-07-02 Thread Cristian Dumitrescu
Add application-evel support for selector tables. Signed-off-by: Churchill Khangar Signed-off-by: Cristian Dumitrescu --- examples/pipeline/cli.c | 563 1 file changed, 563 insertions(+) diff --git a/examples/pipeline/cli.c b/examples/pipeline/cli.c ind

[dpdk-dev] [PATCH V3 3/5] pipeline: add support for selector tables

2021-07-02 Thread Cristian Dumitrescu
Add pipeline-level support for selector tables, Signed-off-by: Cristian Dumitrescu --- lib/pipeline/rte_swx_ctl.c | 700 - lib/pipeline/rte_swx_ctl.h | 253 + lib/pipeline/rte_swx_pipeline.c | 748 --- lib/pipeline/

[dpdk-dev] [PATCH V3 2/5] table: add support for selector tables

2021-07-02 Thread Cristian Dumitrescu
A selector table is made up of groups of weighted members, with a given member potentially part of several groups. The select operation returns a member ID by first selecting a group based on an input group ID and then selecting a member within that group based on hashing one or several input heade

[dpdk-dev] [PATCH V3 1/5] examples/pipeline: improve table update CLI commands

2021-07-02 Thread Cristian Dumitrescu
From: Churchill Khangar For more felxibility, the single monolithic table update command is split into table entry add, table entry delete, table default entry add, pipeline commit and pipeline abort. Signed-off-by: Churchill Khangar Signed-off-by: Cristian Dumitrescu --- examples/pipeline/cl

[dpdk-dev] [PATCH V2 5/5] examples/pipeline: add selector example

2021-07-02 Thread Cristian Dumitrescu
Added the files to illustrate the selector table usage. Signed-off-by: Cristian Dumitrescu --- examples/pipeline/examples/selector.cli | 31 examples/pipeline/examples/selector.spec | 95 examples/pipeline/examples/selector.txt | 4 + 3 files changed, 130 ins

[dpdk-dev] [PATCH V2 4/5] examples/pipeline: add support for selector tables

2021-07-02 Thread Cristian Dumitrescu
Add application-evel support for selector tables. Signed-off-by: Churchill Khangar Signed-off-by: Cristian Dumitrescu --- examples/pipeline/cli.c | 563 1 file changed, 563 insertions(+) diff --git a/examples/pipeline/cli.c b/examples/pipeline/cli.c ind

[dpdk-dev] [PATCH V2 3/5] pipeline: add support for selector tables

2021-07-02 Thread Cristian Dumitrescu
Add pipeline-level support for selector tables, Signed-off-by: Cristian Dumitrescu --- lib/pipeline/rte_swx_ctl.c | 700 - lib/pipeline/rte_swx_ctl.h | 253 + lib/pipeline/rte_swx_pipeline.c | 748 --- lib/pipeline/

[dpdk-dev] [PATCH V2 2/5] table: add support for selector tables

2021-07-02 Thread Cristian Dumitrescu
A selector table is made up of groups of weighted members, with a given member potentially part of several groups. The select operation returns a member ID by first selecting a group based on an input group ID and then selecting a member within that group based on hashing one or several input heade

[dpdk-dev] [PATCH V2 1/5] examples/pipeline: improve table update CLI commands

2021-07-02 Thread Cristian Dumitrescu
From: Churchill Khangar For more felxibility, the single monolithic table update command is split into table entry add, table entry delete, table default entry add, pipeline commit and pipeline abort. Signed-off-by: Churchill Khangar Signed-off-by: Cristian Dumitrescu --- examples/pipeline/cl

Re: [dpdk-dev] [PATCH] net/mlx5: remove unwanted barrier

2021-07-02 Thread Honnappa Nagarahalli
Hi Slava, Thanks for taking the pain to explain this (this is similar to DD bits in Intel i40e PMD). Agree, that for ensuring the ordering of the loads between op_own and the rest of the fields we need a barrier. For Arm architecture, we can use the barrier for inner sharable domain (rte

[dpdk-dev] [PATCH v6 7/7] event/cnxk: add Tx event vector fastpath

2021-07-02 Thread pbhagavatula
From: Pavan Nikhilesh Add Tx event vector fastpath, integrate event vector Tx routine into Tx burst. Signed-off-by: Pavan Nikhilesh --- doc/guides/eventdevs/cnxk.rst | 1 + doc/guides/rel_notes/release_21_08.rst | 2 +- drivers/common/cnxk/roc_sso.h | 23 ++ drivers/

[dpdk-dev] [PATCH v6 6/7] event/cnxk: add Rx event vector fastpath

2021-07-02 Thread pbhagavatula
From: Pavan Nikhilesh Add Rx event vector fastpath to convert HW defined metadata into rte_mbuf and rte_event_vector. Signed-off-by: Pavan Nikhilesh --- doc/guides/rel_notes/release_21_08.rst | 1 + drivers/event/cnxk/cn10k_worker.h | 56 +++ drivers/net/cnxk/cn10k_rx.h

[dpdk-dev] [PATCH v6 5/7] event/cnxk: add Rx adapter vector support

2021-07-02 Thread pbhagavatula
From: Pavan Nikhilesh Add event vector support for cnxk event Rx adapter, add control path APIs to get vector limits and ability to configure event vectorization on a given Rx queue. Signed-off-by: Pavan Nikhilesh --- doc/guides/eventdevs/cnxk.rst| 2 + drivers/event/cnxk/cn10k_e

[dpdk-dev] [PATCH v6 4/7] event/cnxk: add Tx adapter fastpath ops

2021-07-02 Thread pbhagavatula
From: Pavan Nikhilesh Add support for event eth Tx adapter fastpath operations. Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn10k_eventdev.c | 38 drivers/event/cnxk/cn10k_worker.h | 67 + drivers/event/cnxk/cn10k_worker_tx_enq.c | 23 +

[dpdk-dev] [PATCH v6 3/7] event/cnxk: add Tx adapter support

2021-07-02 Thread pbhagavatula
From: Pavan Nikhilesh Add support for event eth Tx adapter. Signed-off-by: Pavan Nikhilesh --- doc/guides/eventdevs/cnxk.rst| 4 +- doc/guides/rel_notes/release_21_08.rst | 6 +- drivers/common/cnxk/roc_nix.h| 1 + drivers/common/cnxk/roc_nix_queue.c | 7

[dpdk-dev] [PATCH v6 2/7] event/cnxk: add Rx adapter fastpath ops

2021-07-02 Thread pbhagavatula
From: Pavan Nikhilesh Add support for event eth Rx adapter fastpath operations. Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn10k_eventdev.c | 136 +++- drivers/event/cnxk/cn10k_worker.c | 54 drivers/event/cnxk/cn10k_worker.h | 97 +-

[dpdk-dev] [PATCH v6 1/7] event/cnxk: add Rx adapter support

2021-07-02 Thread pbhagavatula
From: Pavan Nikhilesh Add support for event eth Rx adapter. Resize cn10k workslot fastpath structure to fit in 64B cacheline size. Signed-off-by: Pavan Nikhilesh --- v6 Changes: - More code cleanup. - Fix incorrect SQB configuration and missing fc check. v5 Changes: - Use cnxk_eth_rxq_to_s

[dpdk-dev] [PATCH 5/5] examples/pipeline: add selector CLI and spec files

2021-07-02 Thread Cristian Dumitrescu
Signed-off-by: Cristian Dumitrescu --- examples/pipeline/examples/selector.cli | 31 +++ examples/pipeline/examples/selector.spec | 70 examples/pipeline/examples/selector.txt | 4 ++ 3 files changed, 105 insertions(+) create mode 100644 examples/pipeline/exam

[dpdk-dev] [PATCH 4/5] examples/pipeline: add support for selector tables

2021-07-02 Thread Cristian Dumitrescu
Add application-evel support for selector tables. Signed-off-by: Churchill Khangar Signed-off-by: Cristian Dumitrescu --- examples/pipeline/cli.c | 568 1 file changed, 568 insertions(+) diff --git a/examples/pipeline/cli.c b/examples/pipeline/cli.c ind

[dpdk-dev] [PATCH 3/5] pipeline: add support for selector tables

2021-07-02 Thread Cristian Dumitrescu
Add pipeline-level support for selector tables, Signed-off-by: Cristian Dumitrescu --- lib/pipeline/rte_swx_ctl.c | 700 - lib/pipeline/rte_swx_ctl.h | 253 + lib/pipeline/rte_swx_pipeline.c | 748 --- lib/pipeline/

[dpdk-dev] [PATCH 2/5] table: add support for selector tables

2021-07-02 Thread Cristian Dumitrescu
A selector table is made up of groups of weighted members, with a given member potentially part of several groups. The select operation returns a member ID by first selecting a group based on an input group ID and then selecting a member within that group based on hashing one or several input heade

[dpdk-dev] [PATCH 1/5] examples/pipeline: improve table update CLI commands

2021-07-02 Thread Cristian Dumitrescu
From: Churchill Khangar For more felxibility, the single monolithic table update command is split into table entry add, table entry delete, table default entry add, pipeline commit and pipeline abort. Signed-off-by: Churchill Khangar Signed-off-by: Cristian Dumitrescu --- examples/pipeline/cl

Re: [dpdk-dev] [PATCH] test: fix crypto_op length for sessionless case

2021-07-02 Thread Gujjar, Abhinandan S
Hi Aaron/dpdklab, This patch's CI seems to have lot of false positive! Ferruh triggered the re-test sometime back. Now, it is reporting less. Could you please check from your end? Thanks! Regards Abhinandan > -Original Message- > From: Gujjar, Abhinandan S > Sent: Wednesday, June 30, 2

Re: [dpdk-dev] [PATCH v6 17/19] net/ngbe: add Tx queue start and stop

2021-07-02 Thread Andrew Rybchenko
On 6/17/21 2:00 PM, Jiawen Wu wrote: > Initializes transmit unit, support to start and stop transmit unit for > specified queues. > > Signed-off-by: Jiawen Wu [snip] > diff --git a/drivers/net/ngbe/ngbe_rxtx.c b/drivers/net/ngbe/ngbe_rxtx.c > index d4680afaae..b05cb0ec34 100644 > --- a/drivers/

Re: [dpdk-dev] [PATCH v6 16/19] net/ngbe: add device start and stop operations

2021-07-02 Thread Andrew Rybchenko
On 6/17/21 2:00 PM, Jiawen Wu wrote: > Setup MSI-X interrupt, complete PHY configuration and set device link > speed to start device. Disable interrupt, stop hardware and clear queues > to stop device. > > Signed-off-by: Jiawen Wu [snip] > diff --git a/drivers/net/ngbe/ngbe_ethdev.c b/drivers/n

Re: [dpdk-dev] [PATCH v6 15/19] net/ngbe: add simple Tx flow

2021-07-02 Thread Andrew Rybchenko
On 6/17/21 2:00 PM, Jiawen Wu wrote: > Initialize device with the simplest transmit functions. > > Signed-off-by: Jiawen Wu The patch cannot be tested before device start up. So, it should go after corresponding patches. [snip] > +uint16_t > +ngbe_xmit_pkts_simple(void *tx_queue, struct rte_mb

Re: [dpdk-dev] [PATCH v6 14/19] net/ngbe: add simple Rx flow

2021-07-02 Thread Andrew Rybchenko
On 6/17/21 2:00 PM, Jiawen Wu wrote: > Initialize device with the simplest receive function. > > Signed-off-by: Jiawen Wu The patch cannot be tested before device start up. So, it should go after the patch which implements device and Rx queues start up. [snip] > diff --git a/drivers/net/ngbe/n

Re: [dpdk-dev] [PATCH v6 13/19] net/ngbe: add Tx queue setup and release

2021-07-02 Thread Andrew Rybchenko
On 6/17/21 1:59 PM, Jiawen Wu wrote: > Setup device Tx queue and release Tx queue. > > Signed-off-by: Jiawen Wu [snip] > +int __rte_cold > +ngbe_dev_tx_queue_setup(struct rte_eth_dev *dev, > + uint16_t queue_idx, > + uint16_t nb_desc, > +

Re: [dpdk-dev] [PATCH v6 12/19] net/ngbe: add Rx queue setup and release

2021-07-02 Thread Andrew Rybchenko
On 6/17/21 1:59 PM, Jiawen Wu wrote: > Setup device Rx queue and release Rx queue. > > Signed-off-by: Jiawen Wu > --- > drivers/net/ngbe/meson.build | 1 + > drivers/net/ngbe/ngbe_ethdev.c | 37 +++- > drivers/net/ngbe/ngbe_ethdev.h | 16 ++ > drivers/net/ngbe/ngbe_rxtx.c | 308 +

Re: [dpdk-dev] [PATCH v6 10/19] net/ngbe: support link update

2021-07-02 Thread Andrew Rybchenko
On 6/17/21 1:59 PM, Jiawen Wu wrote: > Register to handle device interrupt. > > Signed-off-by: Jiawen Wu [snip] > diff --git a/doc/guides/nics/ngbe.rst b/doc/guides/nics/ngbe.rst > index 54d0665db9..0918cc2918 100644 > --- a/doc/guides/nics/ngbe.rst > +++ b/doc/guides/nics/ngbe.rst > @@ -8,6 +8

Re: [dpdk-dev] [PATCH v6 09/19] net/ngbe: store MAC address

2021-07-02 Thread Andrew Rybchenko
On 6/17/21 1:59 PM, Jiawen Wu wrote: > Store MAC addresses and init receive address filters. > > Signed-off-by: Jiawen Wu [snip] > diff --git a/drivers/net/ngbe/ngbe_ethdev.c b/drivers/net/ngbe/ngbe_ethdev.c > index 31d4dda976..deca64137d 100644 > --- a/drivers/net/ngbe/ngbe_ethdev.c > +++ b/dr

Re: [dpdk-dev] [PATCH v6 07/19] net/ngbe: add HW initialization

2021-07-02 Thread Andrew Rybchenko
On 6/17/21 1:59 PM, Jiawen Wu wrote: > Initialize the hardware by resetting the hardware in base code. > > Signed-off-by: Jiawen Wu [snip] > diff --git a/drivers/net/ngbe/ngbe_ethdev.c b/drivers/net/ngbe/ngbe_ethdev.c > index c779c46dd5..31d4dda976 100644 > --- a/drivers/net/ngbe/ngbe_ethdev.c

Re: [dpdk-dev] [PATCH v6 05/19] net/ngbe: set MAC type and LAN ID with device initialization

2021-07-02 Thread Andrew Rybchenko
On 6/17/21 1:59 PM, Jiawen Wu wrote: > Add basic init and uninit function. > Map device IDs and subsystem IDs to single ID for easy operation. > Then initialize the shared code. > > Signed-off-by: Jiawen Wu [snip] > diff --git a/drivers/net/ngbe/ngbe_ethdev.c b/drivers/net/ngbe/ngbe_ethdev.c >

[dpdk-dev] [PATCH 21.11] telemetry: remove experimental tags from APIs

2021-07-02 Thread Bruce Richardson
The telemetry APIs have been present and unchanged for >1 year now, so remove experimental tag from them. Signed-off-by: Bruce Richardson --- lib/telemetry/rte_telemetry.h | 18 -- lib/telemetry/version.map | 2 +- 2 files changed, 1 insertion(+), 19 deletions(-) diff --git

[dpdk-dev] [PATCH v1] net/ice: support QoS BW config after VF reset in DCF

2021-07-02 Thread Ting Xu
When VF reset happens, the QoS bandwidth configuration will be lost. If the reset is not caused by DCB change, it is supposed to replay the bandwidth configuration to VF by DCF. In this patch, when a vsi update PF event is received from PF after VF reset, and it is confirmed that DCB is not changed

Re: [dpdk-dev] dmadev discussion summary

2021-07-02 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of fengchengwen > Sent: Friday, 2 July 2021 15.45 > > On 2021/7/1 23:01, Jerin Jacob wrote: > >> [key point]: > >> ------ > >> | channel || channel | > >> ------ > >> \

[dpdk-dev] [PATCH] ethdev: keep count of allocated and used representor ranges

2021-07-02 Thread Andrew Rybchenko
From: Viacheslav Galaktionov In its current state, the API can overflow the user-passed buffer if a new representor range appears between function calls. In order to solve this problem, augment the representor info structure with the numbers of allocated and initialized ranges. This way the user

Re: [dpdk-dev] [PATCH v2 2/2] telemetry: add extra log message on socket bind failure

2021-07-02 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson > Sent: Friday, 2 July 2021 14.56 > > If the library fails to create the needed socket, add an additional > check to report if the error is due to a missing DPDK runtime dir. > > Signed-off-by: Bruce Richardson > --- > lib/

Re: [dpdk-dev] [PATCH v2 1/2] eal: create runtime dir even when shared data is not used

2021-07-02 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson > Sent: Friday, 2 July 2021 14.56 > To: dev@dpdk.org > > When multi-process is not wanted and DPDK is run with the "no-shconf" > flag, the telemetry library still needs a runtime directory to place > the > unix socket for tele

Re: [dpdk-dev] [PATCH 0/2] bugfix for SVE compile

2021-07-02 Thread fengchengwen
Hi, Thomas Please review this patch set, thanks. PS: this patch set already reviewed by ARM guys, and the CI has some errors, but it seem not related to this patch set. On 2021/6/28 10:57, Chengwen Feng wrote: > This patch set contains two bugfixes for SVE compile. > Note: > 1) Because 2/2 patc

Re: [dpdk-dev] dmadev discussion summary

2021-07-02 Thread fengchengwen
On 2021/7/2 15:07, Liang Ma wrote: >> 8) One example: >> vq_id = rte_dmadev_queue_setup(dev, config.{HW-queue-index=x, opaque}); >> if (vq_id < 0) { >> // create virt-queue failed >> return; >> } >> // submit memcpy task >> cookit = rte_dmadev_memcpy(dev,

Re: [dpdk-dev] [PATCH] dmadev: introduce DMA device library

2021-07-02 Thread Bruce Richardson
On Fri, Jul 02, 2021 at 09:18:11PM +0800, Chengwen Feng wrote: > This patch introduces 'dmadevice' which is a generic type of DMA > device. > > The APIs of dmadev library exposes some generic operations which can > enable configuration and I/O with the DMA devices. > > Signed-off-by: Chengwen Fen

Re: [dpdk-dev] [PATCH 1/4] drivers/net/enetfec: Introduce NXP ENETFEC driver

2021-07-02 Thread David Marchand
On Tue, Jun 8, 2021 at 3:10 PM Andrew Rybchenko wrote: > > +RTE_PMD_REGISTER_VDEV(ENETFEC_NAME_PMD, pmd_enetfec_drv); > > +RTE_PMD_REGISTER_PARAM_STRING(ENETFEC_NAME_PMD, ENET_VDEV_GEM_ID_ARG > > "="); > > + > > +RTE_INIT(enetfec_pmd_init_log) > > +{ > > + enetfec_logtype_pmd = rte_log_regist

Re: [dpdk-dev] dmadev discussion summary

2021-07-02 Thread fengchengwen
On 2021/7/1 23:01, Jerin Jacob wrote: >> [key point]: >> ------ >> | channel || channel | >> ------ >> \ / >> \ / >>\ / >> >> | H

Re: [dpdk-dev] [PATCH v3 19/20] net/sfc: support flow action COUNT in transfer rules

2021-07-02 Thread Andrew Rybchenko
On 7/2/21 4:37 PM, David Marchand wrote: > On Fri, Jul 2, 2021 at 10:43 AM Andrew Rybchenko > wrote: >> I've send v4 with the problem fixed. However, I'm afraid >> build test systems should be updated to have libatomic >> correctly installed. Otherwise, they do not really check >> net/sfc build. >

Re: [dpdk-dev] [PATCH v3 19/20] net/sfc: support flow action COUNT in transfer rules

2021-07-02 Thread David Marchand
On Fri, Jul 2, 2021 at 10:43 AM Andrew Rybchenko wrote: > I've send v4 with the problem fixed. However, I'm afraid > build test systems should be updated to have libatomic > correctly installed. Otherwise, they do not really check > net/sfc build. CI systems must be updated if they check ABI. And

Re: [dpdk-dev] [PATCH 0/2] net/tap: remove useless offload setup

2021-07-02 Thread Andrew Rybchenko
On 7/2/21 4:26 PM, Wiles, Keith wrote: > > >> On Jun 15, 2021, at 11:15 PM, Stephen Hemminger >> wrote: >> >> This looks like some infrastructure that was set for some future >> change that never happened. Remove it. >> >> Stephen Hemminger (2): >> tap: remove useless offload capa functions >>

Re: [dpdk-dev] dmadev discussion summary

2021-07-02 Thread fengchengwen
On 2021/6/28 18:00, Bruce Richardson wrote: >> 4) The driver's ops design (here we only list key points): >> [dev_info_get]: mainly return the number of HW-queues >> [dev_configure]: nothing important >> [queue_setup]: create one virt-queue, has following main parameters: >>

Re: [dpdk-dev] [PATCH 0/2] net/tap: remove useless offload setup

2021-07-02 Thread Wiles, Keith
> On Jun 15, 2021, at 11:15 PM, Stephen Hemminger > wrote: > > This looks like some infrastructure that was set for some future > change that never happened. Remove it. > > Stephen Hemminger (2): > tap: remove useless offload capa functions > tap: replace offload_capa function with define

Re: [dpdk-dev] [RFC] lib/ethdev: add dev configured flag

2021-07-02 Thread Ananyev, Konstantin
> > On 7/2/2021 12:08 PM, Andrew Rybchenko wrote: > > @Thomas, @Ferruh, I tend to accept it (with minor style fixes), > > but I need your opinion on it before doing it. > > > > I guess we were relying on the user/application to have correct order up until > now, it can be good to add this into

Re: [dpdk-dev] [PATCH v6 02/19] net/ngbe: support probe and remove

2021-07-02 Thread Andrew Rybchenko
On 6/17/21 1:59 PM, Jiawen Wu wrote: > Add device IDs for Wangxun 1Gb NICs, map device IDs to register ngbe > PMD. Add basic PCIe ethdev probe and remove. > > Signed-off-by: Jiawen Wu > --- > doc/guides/nics/features/ngbe.ini | 1 + > drivers/net/ngbe/base/meson.build | 18 +++ > driver

Re: [dpdk-dev] [PATCH v6 03/19] net/ngbe: add log type and error type

2021-07-02 Thread Andrew Rybchenko
On 6/17/21 1:59 PM, Jiawen Wu wrote: > Add log type and error type to trace functions. > > Signed-off-by: Jiawen Wu > --- > doc/guides/nics/ngbe.rst| 21 + > drivers/net/ngbe/base/ngbe_status.h | 73 + > drivers/net/ngbe/ngbe_ethdev.c | 14 +++

[dpdk-dev] [PATCH] dmadev: introduce DMA device library

2021-07-02 Thread Chengwen Feng
This patch introduces 'dmadevice' which is a generic type of DMA device. The APIs of dmadev library exposes some generic operations which can enable configuration and I/O with the DMA devices. Signed-off-by: Chengwen Feng --- MAINTAINERS | 4 + config/rte_config.h |

Re: [dpdk-dev] [PATCH v6 01/19] net/ngbe: add build and doc infrastructure

2021-07-02 Thread Andrew Rybchenko
On 6/17/21 1:59 PM, Jiawen Wu wrote: > Adding bare minimum PMD library and doc build infrastructure > and claim the maintainership for ngbe PMD. > > Signed-off-by: Jiawen Wu Just one nit below. [snip] > diff --git a/drivers/net/ngbe/ngbe_ethdev.c b/drivers/net/ngbe/ngbe_ethdev.c > new file mod

Re: [dpdk-dev] [PATCH v2] doc: add link status event pre-conditions

2021-07-02 Thread Andrew Rybchenko
On 7/2/21 3:35 PM, Thomas Monjalon wrote: > 02/07/2021 10:55, Andrew Rybchenko: >> On 6/30/21 4:56 AM, Min Hu (Connor) wrote: >>> From: Chengwen Feng >>> +Firmware 1.8.0.0 and later versions support reporting link changes to the >>> PF. >>> +Therefore, to use the LSC for the PF driver, ensure tha

[dpdk-dev] [PATCH v2 2/2] telemetry: add extra log message on socket bind failure

2021-07-02 Thread Bruce Richardson
If the library fails to create the needed socket, add an additional check to report if the error is due to a missing DPDK runtime dir. Signed-off-by: Bruce Richardson --- lib/telemetry/telemetry.c | 5 + 1 file changed, 5 insertions(+) diff --git a/lib/telemetry/telemetry.c b/lib/telemetry/

[dpdk-dev] [PATCH v2 1/2] eal: create runtime dir even when shared data is not used

2021-07-02 Thread Bruce Richardson
When multi-process is not wanted and DPDK is run with the "no-shconf" flag, the telemetry library still needs a runtime directory to place the unix socket for telemetry connections. Therefore, rather than not creating the directory when this flag is set, we can change the code to attempt the creati

Re: [dpdk-dev] [PATCH v3 19/20] net/sfc: support flow action COUNT in transfer rules

2021-07-02 Thread Andrew Rybchenko
On 7/2/21 3:30 PM, Thomas Monjalon wrote: > 02/07/2021 10:43, Andrew Rybchenko: >> On 7/1/21 4:05 PM, Andrew Rybchenko wrote: >>> On 7/1/21 3:34 PM, David Marchand wrote: On Thu, Jul 1, 2021 at 11:22 AM Andrew Rybchenko wrote: > The build works fine for me on FC34, but it has > l

Re: [dpdk-dev] [PATCH v15] app/testpmd: support multi-process

2021-07-02 Thread Andrew Rybchenko
On 7/2/21 3:09 PM, Andrew Rybchenko wrote: > From: "Min Hu (Connor)" > > For example the following commands run two testpmd processes: > > * the primary process: > > ./dpdk-testpmd --proc-type=auto -l 0-1 -- -i \ >--rxq=4 --txq=4 --num-procs=2 --proc-id=0 > > * the secondary process: >

Re: [dpdk-dev] [PATCH v2] doc: add link status event pre-conditions

2021-07-02 Thread Thomas Monjalon
02/07/2021 10:55, Andrew Rybchenko: > On 6/30/21 4:56 AM, Min Hu (Connor) wrote: > > From: Chengwen Feng > > +Firmware 1.8.0.0 and later versions support reporting link changes to the > > PF. > > +Therefore, to use the LSC for the PF driver, ensure that the firmware > > version > > +also support

Re: [dpdk-dev] [PATCH v3 19/20] net/sfc: support flow action COUNT in transfer rules

2021-07-02 Thread Thomas Monjalon
02/07/2021 10:43, Andrew Rybchenko: > On 7/1/21 4:05 PM, Andrew Rybchenko wrote: > > On 7/1/21 3:34 PM, David Marchand wrote: > >> On Thu, Jul 1, 2021 at 11:22 AM Andrew Rybchenko > >> wrote: > >>> The build works fine for me on FC34, but it has > >>> libatomic-11.1.1-3.fc34.x86_64 installed. > >>

Re: [dpdk-dev] [dpdk-techboard] ABI/API stability towards drivers

2021-07-02 Thread Thomas Monjalon
02/07/2021 10:00, Morten Brørup: > Regarding the ongoing ABI stability project, it is suggested to export driver > interfaces as internal. > > What are we targeting regarding ABI and API stability towards drivers? No stability for driver interface. It is recommended to make drivers internal. If

[dpdk-dev] [PATCH v15] app/testpmd: support multi-process

2021-07-02 Thread Andrew Rybchenko
From: "Min Hu (Connor)" For example the following commands run two testpmd processes: * the primary process: ./dpdk-testpmd --proc-type=auto -l 0-1 -- -i \ --rxq=4 --txq=4 --num-procs=2 --proc-id=0 * the secondary process: ./dpdk-testpmd --proc-type=auto -l 2-3 -- -i \ --rxq=4 --txq=4

Re: [dpdk-dev] [RFC] lib/ethdev: add dev configured flag

2021-07-02 Thread Ferruh Yigit
On 7/2/2021 12:08 PM, Andrew Rybchenko wrote: > @Thomas, @Ferruh, I tend to accept it (with minor style fixes), > but I need your opinion on it before doing it. > I guess we were relying on the user/application to have correct order up until now, it can be good to add this into the API. OK to add

Re: [dpdk-dev] [RFC v2] porting AddressSanitizer feature to DPDK

2021-07-02 Thread Lin, Xueqin
> -Original Message- > From: David Marchand > Sent: Thursday, July 1, 2021 3:41 PM > To: Lin, Xueqin ; Burakov, Anatoly > > Cc: Jerin Jacob ; Peng, ZhihongX > ; Ananyev, Konstantin > ; Stephen Hemminger > ; dpdk-dev > Subject: Re: [dpdk-dev] [RFC v2] porting AddressSanitizer feature to D

Re: [dpdk-dev] basicfwd

2021-07-02 Thread Ferruh Yigit
On 7/1/2021 11:16 AM, 王万臣 wrote: > Hello, I tried to run a sample program (Skeleton) after installing DPDK > according to the Getting Started Guide for Linux document, but failed, > "Detected shared linkage of DPDK" is missing in the output of EAL > initialization, compared with the correct outp

Re: [dpdk-dev] [PATCH] test/crypto: fix typo in AES testcase description

2021-07-02 Thread Power, Ciara
Hi Rebecca, >-Original Message- >From: Troy, Rebecca >Sent: Thursday 1 July 2021 10:23 >To: dev@dpdk.org >Cc: Power, Ciara ; Troy, Rebecca >; tomaszx.kula...@intel.com; sta...@dpdk.org; >Doherty, Declan >Subject: [PATCH] test/crypto: fix typo in AES testcase description > >Fixed typo in

[dpdk-dev] [PATCH 2/2] crypto/octeontx2: clear session priv mem upon destroy

2021-07-02 Thread Anoob Joseph
During session destroy, clear session private memory. Signed-off-by: Anoob Joseph --- drivers/crypto/octeontx2/otx2_cryptodev_sec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/crypto/octeontx2/otx2_cryptodev_sec.c b/drivers/crypto/octeontx2/otx2_cryptodev_sec.c index 3c5686a..

[dpdk-dev] [PATCH 1/2] crypto/octeontx2: reset feature flags during config

2021-07-02 Thread Anoob Joseph
Feature flags in dev would be updated during config. On reconfigure, the field need to be set again to original value. Signed-off-by: Anoob Joseph --- drivers/crypto/octeontx2/otx2_cryptodev.c | 30 --- drivers/crypto/octeontx2/otx2_cryptodev.h | 1 + drivers/cry

Re: [dpdk-dev] [PATCH 1/2] net/mlx5: remove redundant operations

2021-07-02 Thread Ruifeng Wang
> -Original Message- > From: Slava Ovsiienko > Sent: Friday, July 2, 2021 4:13 PM > To: Ruifeng Wang ; Raslan Darawsheh > ; Matan Azrad ; Shahaf Shuler > > Cc: dev@dpdk.org; jer...@marvell.com; nd ; Honnappa > Nagarahalli ; sta...@dpdk.org > Subject: RE: [PATCH 1/2] net/mlx5: remove redun

Re: [dpdk-dev] [RFC PATCH] ethdev: add support for testpmd-compliant flow rule dumping

2021-07-02 Thread Andrew Rybchenko
Hi Aman, On 6/14/21 3:42 PM, Singh, Aman Deep wrote: > Hi Ivan, > > As a suggestion, can we add a check for debug log_level in > "rte_flow_snprint" itself. I see the reason, but I think it a bad idea to put the check inside the function. If calling function cares, it should do the check. > So w

Re: [dpdk-dev] [RFC 0/1] app/testpmd: add l3fwd mode to testpmd

2021-07-02 Thread Andrew Rybchenko
@Xiaoyun could you share your thoughts on it? As far as I remember there is no agreement on the topic. Adding more people in Cc. On 5/1/21 12:37 AM, Kathleen Capella wrote: > Performance of the LPM mode in L3fwd example application is used as an > industry > standard to compare between various p

Re: [dpdk-dev] [RFC] lib/ethdev: add dev configured flag

2021-07-02 Thread Andrew Rybchenko
@Thomas, @Ferruh, I tend to accept it (with minor style fixes), but I need your opinion on it before doing it. Thanks, Andrew. On 6/29/21 5:27 AM, Huisong Li wrote: > > 在 2021/6/14 23:37, Andrew Rybchenko 写道: >> Summary should start from "ethdev: " >> >> Don't forget to include all maintainers i

Re: [dpdk-dev] dmadev discussion summary

2021-07-02 Thread Bruce Richardson
On Fri, Jul 02, 2021 at 09:39:10AM +0200, Morten Brørup wrote: > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] Sent: > > Thursday, 1 July 2021 18.34 > > > > On Thu, Jul 01, 2021 at 08:31:00PM +0530, Jerin Jacob wrote: > > > On Sat, Jun 26, 2021 at 9:29 AM fengchengwen > > wrote: >

Re: [dpdk-dev] [PATCH v2 0/2] fixes for link speed

2021-07-02 Thread Andrew Rybchenko
On 6/29/21 10:31 AM, Min Hu (Connor) wrote: > Hi, Singh > > 在 2021/6/29 14:24, Singh, Aman Deep 写道: >> Hi Min Hu, >> >> On 6/28/2021 8:55 AM, Min Hu (Connor) wrote: >>> Hi, all, >>> any comments? >> >> As part of this series- >> [PATCH v2 1/2]:  As per Huisong Li "So let's keep it the way it w

Re: [dpdk-dev] [PATCH v2 2/2] app/testpmd: fix link speed for a specified port

2021-07-02 Thread Andrew Rybchenko
On 4/29/21 11:42 AM, Li, Xiaoyun wrote: >> -Original Message- >> From: Min Hu (Connor) >> Sent: Wednesday, April 28, 2021 16:37 >> To: dev@dpdk.org >> Cc: Yigit, Ferruh ; Li, Xiaoyun >> >> Subject: [PATCH v2 2/2] app/testpmd: fix link speed for a specified port >> >> From: Huisong Li >>

Re: [dpdk-dev] [dpdk-techboard] ABI/API stability towards drivers

2021-07-02 Thread Ferruh Yigit
On 7/2/2021 10:00 AM, Morten Brørup wrote: > Regarding the ongoing ABI stability project, it is suggested to export driver > interfaces as internal. > > What are we targeting regarding ABI and API stability towards drivers? > Hi Morten, It is about some device abstraction libraries, like crypt

Re: [dpdk-dev] [PATCH v2 0/2] net/cxgbe: add support for xstats API

2021-07-02 Thread Andrew Rybchenko
On 7/1/21 7:56 PM, Rahul Lakkireddy wrote: > This series of patches add support to fetch port and queue stats via > xstats API. > > Patch 1 adds support to fetch port and queue stats via xstats API. Fixed mulit-line comments to following DPDK coding style. Just made it single-line. > Patch 2 rem

[dpdk-dev] [PATCH v1 4/4] net/mlx5: fix meter policy flow match item

2021-07-02 Thread Shun Hao
Currently when creating meter policy, a src port_id match item will always be added in switch domain. So if one meter is used by another port, it will not work correctly. This issue is solved: 1. If policy fate action is port_id, add the src port_id match item, and the meter cannot be shared by an

[dpdk-dev] [PATCH v1 3/4] net/mlx5: fix meter flow direction check

2021-07-02 Thread Shun Hao
When preparing prefix flow using ASO meter, if it's tx flow, need to make meter action the first one. Currently the check of flow direction in switch domain is incorrect that it checks the flow dev port only. This adds the fix for the check that if there's port_id match item in flow, use that por

[dpdk-dev] [PATCH v1 2/4] net/mlx5: fix meter policy ID table container

2021-07-02 Thread Shun Hao
The meter policy handlers are managed by user IDs and the driver used l3 table in order to map the user ID to the internal driver handler of the policy. The l3 table was wrongly saved in the shared device structure which manages all the switch domain ports what made the user IDs shared between dif

[dpdk-dev] [PATCH v1 1/4] net/mlx5: use meter profile lookup table

2021-07-02 Thread Shun Hao
Currently a list is used to save all meter profile ids, which is not efficient when looking up profile from huge mount of profiles. This changes to use a l3 table instead to save meter profile ids, so as to improve the lookup performance. Signed-off-by: Shun Hao Acked-by: Matan Azrad --- drive

[dpdk-dev] [PATCH v1 0/4] ASO meter sharing support

2021-07-02 Thread Shun Hao
This adds several fixes in ASO meter. With these fixes, meter created on one port can be shared by other ports. Shun Hao (4): net/mlx5: use meter profile lookup table net/mlx5: fix meter policy ID table container net/mlx5: fix meter flow direction check net/mlx5: fix meter policy flow matc

Re: [dpdk-dev] [PATCH v2] doc: add link status event pre-conditions

2021-07-02 Thread Andrew Rybchenko
On 6/30/21 4:56 AM, Min Hu (Connor) wrote: > From: Chengwen Feng > > This patch adds link status event pre-conditions. > > Signed-off-by: Chengwen Feng > Signed-off-by: Min Hu (Connor) > --- > v2: > * not modified, only waiting for 5.13 kernel released. > --- > doc/guides/nics/hns3.rst | 10 +

[dpdk-dev] [Bug 749] mlx5: ConnectX-6 not all missed packets accounted for when using large maximum packet size

2021-07-02 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=749 Bug ID: 749 Summary: mlx5: ConnectX-6 not all missed packets accounted for when using large maximum packet size Product: DPDK Version: unspecified Hardware: x86 OS:

Re: [dpdk-dev] [PATCH v3 19/20] net/sfc: support flow action COUNT in transfer rules

2021-07-02 Thread Andrew Rybchenko
Hi David, On 7/1/21 4:05 PM, Andrew Rybchenko wrote: > @Bruce, see below. > > On 7/1/21 3:34 PM, David Marchand wrote: >> On Thu, Jul 1, 2021 at 11:22 AM Andrew Rybchenko >> wrote: >>> The build works fine for me on FC34, but it has >>> libatomic-11.1.1-3.fc34.x86_64 installed. >> >> I first pro

[dpdk-dev] [PATCH v4 19/20] net/sfc: support flow action COUNT in transfer rules

2021-07-02 Thread Andrew Rybchenko
From: Igor Romanov For now, a rule may have only one dedicated counter, shared counters are not supported. HW delivers (or "streams") counter readings using special packets. The driver creates a dedicated Rx queue to receive such packets and requests that HW start "streaming" the readings to it.

[dpdk-dev] [PATCH v4 20/20] net/sfc: support flow API query for count actions

2021-07-02 Thread Andrew Rybchenko
From: Igor Romanov The query reports the number of hits for a counter associated with a flow rule. Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton Reviewed-by: Ivan Malov --- drivers/net/sfc/sfc_flow.c| 48 ++- drivers/net/sf

[dpdk-dev] [PATCH v4 18/20] common/sfc_efx/base: add packetiser packet format definition

2021-07-02 Thread Andrew Rybchenko
Packetiser composes packets with MAE counters update. Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- .../base/efx_regs_counters_pkt_format.h | 87 +++ 1 file changed, 87 insertions(+) create mode 100644 drivers/common/sfc_efx/base/efx_regs_counters_pkt_form

[dpdk-dev] [PATCH v4 17/20] common/sfc_efx/base: add max MAE counters to limits

2021-07-02 Thread Andrew Rybchenko
From: Igor Romanov The information about the maximum number of MAE counters is crucial to the counter support in the driver. Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton Reviewed-by: Ivan Malov --- drivers/common/sfc_efx/base/efx.h | 1 + drivers

[dpdk-dev] [PATCH v4 15/20] common/sfc_efx/base: support counter in action set

2021-07-02 Thread Andrew Rybchenko
From: Igor Romanov User will be able to associate counter with MAE action set to collect counter packets and bytes for a specific action set. Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton Reviewed-by: Ivan Malov --- drivers/common/sfc_efx/base/efx.h

[dpdk-dev] [PATCH v4 16/20] net/sfc: add Rx datapath method to get pushed buffers count

2021-07-02 Thread Andrew Rybchenko
From: Igor Romanov The information about the number of pushed Rx buffers is required for counter Rx queue to know when to give credits to counter stream. Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton Reviewed-by: Ivan Malov --- drivers/net/sfc/sfc_dp_

[dpdk-dev] [PATCH v4 14/20] common/sfc_efx/base: add counter stream MCDI wrappers

2021-07-02 Thread Andrew Rybchenko
From: Igor Romanov The MCDIs will be used to control counter Rx queue packet flow. Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton Reviewed-by: Ivan Malov --- drivers/common/sfc_efx/base/efx.h | 32 ++ drivers/common/sfc_efx/base/efx_mae.c | 13

[dpdk-dev] [PATCH v4 13/20] common/sfc_efx/base: add counter creation MCDI wrappers

2021-07-02 Thread Andrew Rybchenko
From: Igor Romanov User will be able to create and free MAE counters. Support for associating counters with action set will be added in upcoming patches. Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton Reviewed-by: Ivan Malov --- drivers/common/sfc_efx/

  1   2   >