Re: [dpdk-dev] [PATCH] examples/l3fwd-power: fix assignment errors

2021-05-18 Thread Thomas Monjalon
13/05/2021 11:47, David Hunt: > On 13/5/2021 10:09 AM, Pattan, Reshma wrote: > >> 21/04/2021 05:53, Min Hu (Connor): > >>> From: HongBo Zheng > >>> > >>> + ep_hgh_edpi = EMPTY_POLL_HGH_THRESHOLD; > > > >>> + if (hgh_edpi > 0) > >>> ep_hgh_edpi = hgh_edpi; > >>> >

[dpdk-dev] [PATCH] eal/hotplug: suppress one error log on primary process

2021-05-18 Thread Changpeng Liu
This is a normal case that the primary process already owned one PCI device while the secondary process try to attach it, so suppress the error log here to exclude this case. Signed-off-by: Changpeng Liu --- lib/eal/common/hotplug_mp.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)

[dpdk-dev] DTS Workgroup: MoM 05/12/2021

2021-05-18 Thread Honnappa Nagarahalli
Attendees: Aaron Conole Daniel Martin Buckley Honnappa Nagarahalli Thomas Monjalon Lijuan Tu Juraj Linkes Lincoln Lavoie Owen Hilyard The meeting announcements are sent to dev@dpdk.org. Minutes: 1) Action items from the meeting held on 4/28 a) Juraj Linkes - Understand and discuss the pa

Re: [dpdk-dev] [dpdk-announce] release candidate 21.05-rc3

2021-05-18 Thread Thinh Tran
DPDK 21.05 RC3 on IBM Power result * DPDK: v21.05-rc3-0-g7989b7e7d * OS: RHEL 8.3 kernel level: 4.18.0-240.el8.ppc64le * GCC: version 8.3.1 20191121 (Red Hat 8.3.1-5) * Basic PF on Mellanox: No new issues or regressions were seen. * Performance: not tested. System tested: - IBM Power9 Model 8

[dpdk-dev] [PATCH v1] net/i40e: fix flow director does not work

2021-05-18 Thread Steve Yang
When user configured the flow rule with raw packet via command "flow_director_filter", it would reset all previous fdir input set flags with "i40e_flow_set_fdir_inset()". Ignore to configure the flow input set with raw packet rule used. Fixes: ff04964ea6d5 ("net/i40e: fix flow director for common

[dpdk-dev] 回复: 回复: [PATCH] app/eventdev: remove unnecessary barrier for order test

2021-05-18 Thread Feifei Wang
> -邮件原件- > 发件人: Jerin Jacob > 发送时间: 2021年5月18日 22:05 > 收件人: Feifei Wang > 抄送: jer...@marvell.com; Ruifeng Wang ; > Honnappa Nagarahalli ; dev@dpdk.org; > nd > 主题: Re: [dpdk-dev] 回复: [PATCH] app/eventdev: remove unnecessary > barrier for order test > > On Tue, May 18, 2021 at 2:57 PM F

[dpdk-dev] 回复: [PATCH v3 2/2] net/mlx5: remove unnecessary wmb for Memory Region cache

2021-05-18 Thread Feifei Wang
Also thanks for your patient communication and explanation. A wonderful discussion~ Best Regards Feifei > -邮件原件- > 发件人: Slava Ovsiienko > 发送时间: 2021年5月18日 18:18 > 收件人: Feifei Wang ; Matan Azrad > ; Shahaf Shuler > 抄送: dev@dpdk.org; nd ; Ruifeng Wang > > 主题: RE: [PATCH v3 2/2] net/mlx5:

Re: [dpdk-dev] [PATCH v5 2/2] net/hns3: refactor SVE code compile method

2021-05-18 Thread fengchengwen
Thanks a lot, Ferruh & Honnappa. On 2021/5/19 0:27, Ferruh Yigit wrote: > On 5/14/2021 3:12 PM, Honnappa Nagarahalli wrote: >> >> >>> >>> Currently, the SVE code is compiled only when -march supports SVE (e.g. '- >>> march=armv8.2a+sve'), there maybe some problem[1] with this approach. >>> >>> Th

Re: [dpdk-dev] [PATCH v5 2/2] net/hns3: refactor SVE code compile method

2021-05-18 Thread fengchengwen
On 2021/5/19 0:37, Ferruh Yigit wrote: > On 5/18/2021 5:12 PM, Honnappa Nagarahalli wrote: > > On 5/14/2021 10:53 AM, Chengwen Feng wrote: >> Currently, the SVE code is compiled only when -march supports SVE >> (e.g. '-march=armv8.2a+sve'), there maybe some problem[1] with

Re: [dpdk-dev] [PATCH v6] doc: add release milestones definition

2021-05-18 Thread Ajit Khaparde
> > > >> I already mentioned above, but this can cause misunderstanding. We want > all > >> driver implementation to be ready for proposal deadline, same as other > patches. > >> But because of its reduced scope (they don't affect all project but only > >> specific vendor), we are flexible to get d

Re: [dpdk-dev] [PATCH] ppc64le: fix build without glibc and using Clang

2021-05-18 Thread David Christensen
On 5/16/21 5:46 PM, Piotr Kubaj wrote: __ppc_get_timebase() is only present when glibc is used. Signed-off-by: Piotr Kubaj --- lib/eal/ppc/include/rte_altivec.h | 3 +++ lib/eal/ppc/include/rte_cycles.h | 12 lib/eal/ppc/rte_cycles.c | 16 3 file

Re: [dpdk-dev] [PATCH] dpdk-kmods/windows: Add Intel 100GbE Ethernet adapter device IDs to netuio INF

2021-05-18 Thread Narcisa Ana Maria Vasile
On Wed, Apr 21, 2021 at 05:05:03PM -0700, Pallavi Kadam wrote: > Add Intel 100GbE Ethernet adapter device IDs to netuio inf file > in order to enable them on Windows. > > Signed-off-by: Pallavi Kadam > Reviewed-by: Ranjit Menon > --- > windows/netuio/netuio.inf | 12 > 1 file chang

Re: [dpdk-dev] [PATCH] net/memif: fix missing Tx-bps stats for zero-copy

2021-05-18 Thread Jakub Grajciar -X (jgrajcia - PANTHEON TECH SRO at Cisco)
Hi, Sorry for the inconvenience, the thread got filtered so I only found it in spam after Damjan notified me. The patch looks good. Thanks for the fix! Reviewd-By: Jakub Grajciar > -Original Message- > From: Ferruh Yigit > Sent: Tuesday, May 18, 2021 2:09 PM > To: Tianyu Li ; Jakub G

Re: [dpdk-dev] [PATCH v6 0/3] rte_flow doc matrix

2021-05-18 Thread Thomas Monjalon
18/05/2021 15:28, Thomas Monjalon: > This is an improvement of the rte_flow documentation: > it makes possible to quickly read which items and actions > may be accepted by the drivers in a DPDK release. > > A script is provided for CI to make sure the matrix is updated, > while allowing some manua

[dpdk-dev] [PATCH v7] doc: add release milestones definition

2021-05-18 Thread Thomas Monjalon
From: Asaf Penso Adding more information about the release milestones. This includes the scope of change, expectations, etc. Signed-off-by: Asaf Penso Signed-off-by: Thomas Monjalon Acked-by: John McNamara Acked-by: Ajit Khaparde --- v2: fix styling format and add content in the commit messa

Re: [dpdk-dev] [PATCH 1/2] common/sfc_efx/base: limit reported MCDI response length

2021-05-18 Thread Ferruh Yigit
On 5/18/2021 4:10 PM, Ivan Malov wrote: > From: Andy Moreton > > MCDI helper routines in libefx include length checks for response > messages, to ensure that short replies and optional fields are > handled correctly. > > If the MCDI response message from the firmware is larger than the > caller'

Re: [dpdk-dev] [PATCH v5 2/2] net/hns3: refactor SVE code compile method

2021-05-18 Thread Ferruh Yigit
On 5/18/2021 5:12 PM, Honnappa Nagarahalli wrote: >>> On 5/14/2021 10:53 AM, Chengwen Feng wrote: > Currently, the SVE code is compiled only when -march supports SVE > (e.g. '-march=armv8.2a+sve'), there maybe some problem[1] with this > approach. > > The solution: >>

Re: [dpdk-dev] [PATCH v5 2/2] net/hns3: refactor SVE code compile method

2021-05-18 Thread Ferruh Yigit
On 5/14/2021 3:12 PM, Honnappa Nagarahalli wrote: > > >> >> Currently, the SVE code is compiled only when -march supports SVE (e.g. '- >> march=armv8.2a+sve'), there maybe some problem[1] with this approach. >> >> The solution: >> a. If the minimum instruction set support SVE then compiles it. >>

Re: [dpdk-dev] [PATCH v5 2/2] net/hns3: refactor SVE code compile method

2021-05-18 Thread Honnappa Nagarahalli
> > > >> > >> On 5/14/2021 10:53 AM, Chengwen Feng wrote: > >>> Currently, the SVE code is compiled only when -march supports SVE > >>> (e.g. '-march=armv8.2a+sve'), there maybe some problem[1] with this > >>> approach. > >>> > >>> The solution: > >>> a. If the minimum instruction set support SVE

Re: [dpdk-dev] [PATCH v5 2/2] net/hns3: refactor SVE code compile method

2021-05-18 Thread Ferruh Yigit
On 5/18/2021 4:15 PM, Bruce Richardson wrote: > On Tue, May 18, 2021 at 03:40:18PM +0100, Ferruh Yigit wrote: >> On 5/14/2021 10:53 AM, Chengwen Feng wrote: >>> Currently, the SVE code is compiled only when -march supports SVE >>> (e.g. '-march=armv8.2a+sve'), there maybe some problem[1] with this

Re: [dpdk-dev] [PATCH v5 2/2] net/hns3: refactor SVE code compile method

2021-05-18 Thread Ferruh Yigit
On 5/18/2021 4:48 PM, Honnappa Nagarahalli wrote: > >> >> On 5/14/2021 10:53 AM, Chengwen Feng wrote: >>> Currently, the SVE code is compiled only when -march supports SVE >>> (e.g. '-march=armv8.2a+sve'), there maybe some problem[1] with this >>> approach. >>> >>> The solution: >>> a. If the mini

Re: [dpdk-dev] [PATCH v5 2/2] net/hns3: refactor SVE code compile method

2021-05-18 Thread Honnappa Nagarahalli
> > On 5/14/2021 10:53 AM, Chengwen Feng wrote: > > Currently, the SVE code is compiled only when -march supports SVE > > (e.g. '-march=armv8.2a+sve'), there maybe some problem[1] with this > > approach. > > > > The solution: > > a. If the minimum instruction set support SVE then compiles it. > >

Re: [dpdk-dev] [PATCH v5 2/2] net/hns3: refactor SVE code compile method

2021-05-18 Thread Bruce Richardson
On Tue, May 18, 2021 at 03:40:18PM +0100, Ferruh Yigit wrote: > On 5/14/2021 10:53 AM, Chengwen Feng wrote: > > Currently, the SVE code is compiled only when -march supports SVE > > (e.g. '-march=armv8.2a+sve'), there maybe some problem[1] with this > > approach. > > > > The solution: > > a. If th

[dpdk-dev] [PATCH 2/2] common/sfc_efx/base: add missing MCDI response length checks

2021-05-18 Thread Ivan Malov
From: Andy Moreton Fixes: 6f619653b9b1 ("net/sfc/base: import MCDI implementation") Fixes: e7cd430c864f ("net/sfc/base: import SFN7xxx family support") Fixes: 94190e3543bf ("net/sfc/base: import SFN8xxx family support") Fixes: 34285fd0891d ("common/sfc_efx/base: add match spec validate API") Fixe

[dpdk-dev] [PATCH 1/2] common/sfc_efx/base: limit reported MCDI response length

2021-05-18 Thread Ivan Malov
From: Andy Moreton MCDI helper routines in libefx include length checks for response messages, to ensure that short replies and optional fields are handled correctly. If the MCDI response message from the firmware is larger than the caller's buffer then the response length reported to the caller

Re: [dpdk-dev] [PATCH 1/1] event/dlb2: fix vector based dequeue

2021-05-18 Thread Jerin Jacob
On Wed, May 12, 2021 at 11:55 PM McDaniel, Timothy wrote: > > From: Timothy McDaniel > > This commit fixes the following bugs in the vector based > dequeue path: > - extract hw sched type > - update xstats > > The default mode of operation was also changed from vector > optimized mode to scalar m

Re: [dpdk-dev] [PATCH v5 2/2] net/hns3: refactor SVE code compile method

2021-05-18 Thread Ferruh Yigit
On 5/14/2021 10:53 AM, Chengwen Feng wrote: > Currently, the SVE code is compiled only when -march supports SVE > (e.g. '-march=armv8.2a+sve'), there maybe some problem[1] with this > approach. > > The solution: > a. If the minimum instruction set support SVE then compiles it. > b. Else if the com

Re: [dpdk-dev] [PATCH] test/crypto: fix test status when PMD isn't loaded

2021-05-18 Thread Zhang, Roy Fan
> -Original Message- > From: Power, Ciara > Sent: Tuesday, May 18, 2021 3:20 PM > To: dev@dpdk.org > Cc: Zhang, Roy Fan ; Doherty, Declan > ; acon...@redhat.com; gak...@marvell.com; > Power, Ciara > Subject: [PATCH] test/crypto: fix test status when PMD isn't loaded > > The return value

[dpdk-dev] Meson configuration for pkg-config for drivers' shared objects

2021-05-18 Thread Jakub Palider
Hi, I experience a problem while building out-of-tree application against drivers' shared libraries from dpdk that are _not_ accessed by means of lib/ interface. This looks a bit like a lack of a link between the framework and what certain drivers deliver (rte_pmd API). Employing pkg-config in

Re: [dpdk-dev] [PATCH] doc/guides: add details for new test structure

2021-05-18 Thread Power, Ciara
Hi Aaron, >-Original Message- >From: Aaron Conole >Sent: Monday 17 May 2021 19:02 >To: Power, Ciara >Cc: dev@dpdk.org; Zhang, Roy Fan ; Doherty, >Declan >Subject: Re: [PATCH] doc/guides: add details for new test structure > >Ciara Power writes: > >> The testing guide is now updated to

[dpdk-dev] [PATCH] test/crypto: fix test status when PMD isn't loaded

2021-05-18 Thread Ciara Power
The return value for a test when the required PMD is not loaded should be TEST_SKIPPED, rather than TEST_FAILED. Fixes: 8bfdd8a7f0f1 ("test/crypto: refactor to use sub test suites") Signed-off-by: Ciara Power --- app/test/test_cryptodev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) d

Re: [dpdk-dev] 回复: [PATCH] app/eventdev: remove unnecessary barrier for order test

2021-05-18 Thread Jerin Jacob
On Tue, May 18, 2021 at 2:57 PM Feifei Wang wrote: > > Hi, Jerin > > Sorry to disturb you. Would you please help me review this patch, thanks very > much. In slowpath, I thought of having this barrier. But I agree that it can be removed. Since this is not bug. We will merge this patch in next re

Re: [dpdk-dev] [PATCH] doc: add new feature for connection tracking

2021-05-18 Thread Bing Zhao
Thanks a lot to you all. > -Original Message- > From: Thomas Monjalon > Sent: Tuesday, May 18, 2021 9:19 PM > To: Bing Zhao ; Ferruh Yigit > > Cc: Ori Kam ; Slava Ovsiienko > ; Matan Azrad ; > dev@dpdk.org; Raslan Darawsheh ; > andrew.rybche...@oktetlabs.ru > Subject: Re: [PATCH] doc: ad

Re: [dpdk-dev] [PATCH v4 1/2] config/arm: select most suitable -march for kunpeng soc

2021-05-18 Thread Jerin Jacob
On Tue, May 18, 2021 at 6:55 PM Honnappa Nagarahalli wrote: > > > > > >> > > >> On Thu, May 13, 2021 at 6:41 PM Chengwen Feng > > >> wrote: > > >>> > > >>> Currently, the soc_kunpeng930 declares > > >>> '-march=armv8.2-a+crypto+sve', but some compiler doesn't recognize > > >>> the march because

Re: [dpdk-dev] [PATCH] doc: add new feature for connection tracking

2021-05-18 Thread Thomas Monjalon
18/05/2021 15:33, Bing Zhao: > From: Ferruh Yigit > > On 5/18/2021 1:52 PM, Bing Zhao wrote: > > > The feature support of connection tracking is added in the feature > > > table of networking drivers. The feature overview part is also > > > updated. > > > > > > Signed-off-by: Bing Zhao > > > > H

Re: [dpdk-dev] [PATCH] doc: add new feature for connection tracking

2021-05-18 Thread Bing Zhao
Hi Ferruh, > -Original Message- > From: Ferruh Yigit > Sent: Tuesday, May 18, 2021 9:16 PM > To: Bing Zhao ; Ori Kam ; Slava > Ovsiienko ; Matan Azrad ; > NBU-Contact-Thomas Monjalon > Cc: dev@dpdk.org; Raslan Darawsheh ; > andrew.rybche...@oktetlabs.ru > Subject: Re: [PATCH] doc: add ne

[dpdk-dev] [PATCH v6 3/3] devtools: check flow API doc tables

2021-05-18 Thread Thomas Monjalon
The script check-doc-vs-code.sh may be used to add some automatic checks of the doc. If run without any argument, a complete check is done. The optional argument is a git history reference point to check faster only what has changed since this commit. In this commit, the only check is for rte_flo

[dpdk-dev] [PATCH v6 2/3] doc: add flow API features tables

2021-05-18 Thread Thomas Monjalon
The NICs overview table lists all supported features per driver. There was a single row for "Flow API", although rte_flow is composed of many items and actions. The row "Flow API" is replaced with two new tables for items and actions. Also, since rte_flow is not implemented in all drivers, it wou

[dpdk-dev] [PATCH v6 1/3] doc: rename sfc features file

2021-05-18 Thread Thomas Monjalon
The driver directory is drivers/net/sfc but the features file was doc/guides/nics/features/sfc_efx.ini. sfc_efx.ini is renamed sfc.ini to match the driver directory name. It will help automatic checks of this file. Signed-off-by: Thomas Monjalon --- doc/guides/nics/features/{sfc_efx.ini => sfc.

[dpdk-dev] [PATCH v6 0/3] rte_flow doc matrix

2021-05-18 Thread Thomas Monjalon
This is an improvement of the rte_flow documentation: it makes possible to quickly read which items and actions may be accepted by the drivers in a DPDK release. A script is provided for CI to make sure the matrix is updated, while allowing some manual tuning. Thomas Monjalon (3): doc: rename s

Re: [dpdk-dev] [PATCH v4 1/2] config/arm: select most suitable -march for kunpeng soc

2021-05-18 Thread Honnappa Nagarahalli
> >> > >> On Thu, May 13, 2021 at 6:41 PM Chengwen Feng > >> wrote: > >>> > >>> Currently, the soc_kunpeng930 declares > >>> '-march=armv8.2-a+crypto+sve', but some compiler doesn't recognize > >>> the march because it doesn't support sve. > >>> > >>> To solve this bug we use the following schem

Re: [dpdk-dev] [PATCH v5 2/2] net/hns3: refactor SVE code compile method

2021-05-18 Thread Ferruh Yigit
On 5/18/2021 1:41 PM, fengchengwen wrote: > Hi, Thomas, Ferruh > > This patch is part of the hns3 SVE compilation solution and can work > independently. Could you review it ? > Hi Chengwen, This patch has been missed as being part of the config file set. As far as I understand you want this ch

Re: [dpdk-dev] [EXT] Re: [PATCH] config/arm: add ability to express arch extensions

2021-05-18 Thread Honnappa Nagarahalli
> > > > > > > >> > > > >> >> >> > > > >> >> >> > > > > >> >> >> > The patch still holds true for CRC though as it is listed > > > >> >> >> > separately below > > > >> >> >> > https://urldefense.proofpoint.com/v2/url?u=https- > > > >> >> >3A__developer.arm.com_architectures_cpu-2Darchitecture_a- >

Re: [dpdk-dev] [PATCH] doc: add new feature for connection tracking

2021-05-18 Thread Thomas Monjalon
18/05/2021 15:16, Ferruh Yigit: > On 5/18/2021 1:52 PM, Bing Zhao wrote: > > The feature support of connection tracking is added in the feature > > table of networking drivers. The feature overview part is also > > updated. > > > > Signed-off-by: Bing Zhao > > Hi Bing, > > Thomas is suggestion

Re: [dpdk-dev] [PATCH] doc: add new feature for connection tracking

2021-05-18 Thread Ferruh Yigit
On 5/18/2021 1:52 PM, Bing Zhao wrote: > The feature support of connection tracking is added in the feature > table of networking drivers. The feature overview part is also > updated. > > Signed-off-by: Bing Zhao Hi Bing, Thomas is suggestion another table to list flow API item/actions in separ

Re: [dpdk-dev] [PATCH v5 2/2] net/hns3: refactor SVE code compile method

2021-05-18 Thread Honnappa Nagarahalli
> > > > > Hi, Thomas, Ferruh > > > > This patch is part of the hns3 SVE compilation solution and can work > > independently. Could you review it ? > I believe this patch is targeted for 20.08 release (as 20.05 is already close > to > completion), is my understanding correct? > If it is targeted f

Re: [dpdk-dev] [PATCH v6] doc: add release milestones definition

2021-05-18 Thread Ferruh Yigit
On 5/18/2021 1:25 PM, Thomas Monjalon wrote: > 18/05/2021 13:57, Ferruh Yigit: >> On 3/28/2021 8:00 PM, Thomas Monjalon wrote: >>> From: Asaf Penso >>> >>> Adding more information about the release milestones. >>> This includes the scope of change, expectations, etc. > [...] >>> +rc1 >>> +~~~ >>>

Re: [dpdk-dev] [PATCH v5 2/2] net/hns3: refactor SVE code compile method

2021-05-18 Thread Honnappa Nagarahalli
> > Hi, Thomas, Ferruh > > This patch is part of the hns3 SVE compilation solution and can work > independently. Could you review it ? I believe this patch is targeted for 20.08 release (as 20.05 is already close to completion), is my understanding correct? If it is targeted for 20.08, it will

Re: [dpdk-dev] [PATCH v7 17/17] doc: update mlx5 support for conntrack

2021-05-18 Thread Bing Zhao
Hi Ferruh & Thomas, > -Original Message- > From: Ferruh Yigit > Sent: Thursday, May 6, 2021 2:21 AM > To: Bing Zhao ; Slava Ovsiienko > ; Matan Azrad ; NBU- > Contact-Thomas Monjalon > Cc: dev@dpdk.org; Ori Kam ; Raslan Darawsheh > > Subject: Re: [dpdk-dev] [PATCH v7 17/17] doc: update

[dpdk-dev] [PATCH] doc: add new feature for connection tracking

2021-05-18 Thread Bing Zhao
The feature support of connection tracking is added in the feature table of networking drivers. The feature overview part is also updated. Signed-off-by: Bing Zhao --- doc/guides/nics/features.rst | 12 doc/guides/nics/features/default.ini | 1 + doc/guides/nics/features/ml

Re: [dpdk-dev] [PATCH v5 3/3] devtools: check flow API doc tables

2021-05-18 Thread Thomas Monjalon
13/05/2021 20:40, Ferruh Yigit: > On 4/7/2021 11:33 PM, Thomas Monjalon wrote: > > +changed_files() > > +{ > > + [ -n "$files" ] || > > + files=$(git diff-tree --name-only -r $trusted_commit..) > > + echo "$files" > > +} > > + > > +has_code_change() # > > +{ > > + test -n "$(git lo

Re: [dpdk-dev] [PATCH] net/mlx5: check meta register width for modify field

2021-05-18 Thread Slava Ovsiienko
Yes, It is palliative, it is not perfect, and, IMO, it is crucial - with always applying 32-bit wide values we can destroy the kernel part of reg_c0 in some extended metadata modes and this would lead to steering malfunction. With best regards, Slava From: Asaf Penso Sent: Tuesday, May 18, 2021

Re: [dpdk-dev] [PATCH v5 2/2] net/hns3: refactor SVE code compile method

2021-05-18 Thread fengchengwen
Hi, Thomas, Ferruh This patch is part of the hns3 SVE compilation solution and can work independently. Could you review it ? Best regards On 2021/5/14 22:12, Honnappa Nagarahalli wrote: > > >> >> Currently, the SVE code is compiled only when -march supports SVE (e.g. '- >> march=armv8.2a+sve'

Re: [dpdk-dev] [PATCH v6] doc: add release milestones definition

2021-05-18 Thread Thomas Monjalon
18/05/2021 13:57, Ferruh Yigit: > On 3/28/2021 8:00 PM, Thomas Monjalon wrote: > > From: Asaf Penso > > > > Adding more information about the release milestones. > > This includes the scope of change, expectations, etc. [...] > > +rc1 > > +~~~ > > + > > +* Priority: new or updated API. > > Can w

Re: [dpdk-dev] [PATCH v3 1/2] net/mlx4: remove unnecessary wmb for Memory Region cache

2021-05-18 Thread Slava Ovsiienko
> -Original Message- > From: dev On Behalf Of Feifei Wang > Sent: Tuesday, May 18, 2021 11:51 > To: Matan Azrad ; Shahaf Shuler > > Cc: dev@dpdk.org; n...@arm.com; Feifei Wang ; > Ruifeng Wang > Subject: [dpdk-dev] [PATCH v3 1/2] net/mlx4: remove unnecessary wmb for > Memory Region cache

Re: [dpdk-dev] [PATCH] net/memif: fix missing Tx-bps stats for zero-copy

2021-05-18 Thread Ferruh Yigit
On 4/27/2021 7:30 AM, Tianyu Li wrote: > Hi Jakub, > > Any comments about the patch? > +Damjan. Hi Damjan, Is Jakub still maintaining the net/memif? > -Original Message- > From: Ferruh Yigit > Sent: Wednesday, April 14, 2021 4:13 PM > To: Tianyu Li ; Jakub Grajciar > Cc: dev@dpdk.o

Re: [dpdk-dev] [PATCH v6] doc: add release milestones definition

2021-05-18 Thread Ferruh Yigit
On 3/28/2021 8:00 PM, Thomas Monjalon wrote: > From: Asaf Penso > > Adding more information about the release milestones. > This includes the scope of change, expectations, etc. > > Signed-off-by: Asaf Penso > Signed-off-by: Thomas Monjalon > Acked-by: John McNamara > --- > v2: fix styling fo

Re: [dpdk-dev] [PATCH] net/mlx5: check meta register width for modify field

2021-05-18 Thread Asaf Penso
I didn't plan to have it in this release since it's not critical and I'm afraid of such changes... I didn't mention this in the status mail today. @Raslan Darawsheh can we check tomorrow regression result? If not good we'll need to revert it. Regards, Asaf Penso __

[dpdk-dev] [PATCH] app/acl: add script for automate testing

2021-05-18 Thread Konstantin Ananyev
The purpose of this script is to help automate ACL library functional testing using test-acl app. Sample input files are also provided. Signed-off-by: Konstantin Ananyev --- app/test-acl/input/acl1v4_5_rule | 5 ++ app/test-acl/input/acl1v4_5_trace | 5 ++ app/test-acl/input/acl1v6_1_rule |

[dpdk-dev] [Bug 713] Cannot init ENA port in skeleton example

2021-05-18 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=713 kalyan (kapraka...@gmail.com) changed: What|Removed |Added Resolution|--- |WORKSFORME Status|UNCO

Re: [dpdk-dev] [PATCH 0/6] bugfix for hns3 PMD

2021-05-18 Thread Ferruh Yigit
On 5/15/2021 1:52 AM, Min Hu (Connor) wrote: > This patch set contains six bugfixes for hns3 PMD. > > Huisong Li (6): > net/hns3: fix check of Rx/Tx queue numbers > net/hns3: fix requested FC mode roolback > net/hns3: remove meaningless packet buffer rollback > net/hns3: fix DCB configurat

[dpdk-dev] [PATCH] net/nfp: remove compile time log

2021-05-18 Thread Ferruh Yigit
Logging should be converted to dynamic log. Signed-off-by: Ferruh Yigit --- drivers/net/nfp/nfp_net_logs.h | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/net/nfp/nfp_net_logs.h b/drivers/net/nfp/nfp_net_logs.h index 27dd87611b94..76cc94cb6565 100644 --- a/drivers/net/nfp/nfp_n

Re: [dpdk-dev] [PATCH v5 3/3] devtools: check flow API doc tables

2021-05-18 Thread Thomas Monjalon
14/05/2021 12:51, Ferruh Yigit: > On 4/7/2021 11:33 PM, Thomas Monjalon wrote: > > The script check-doc-vs-code.sh may be used to add > > some automatic checks of the doc. > > > > If run without any argument, a complete check is done. > > The optional argument is a git history reference point > >

Re: [dpdk-dev] [PATCH v3 2/2] net/mlx5: remove unnecessary wmb for Memory Region cache

2021-05-18 Thread Slava Ovsiienko
> -Original Message- > From: Feifei Wang > Sent: Tuesday, May 18, 2021 11:51 > To: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko > Cc: dev@dpdk.org; n...@arm.com; Feifei Wang ; > Ruifeng Wang > Subject: [PATCH v3 2/2] net/mlx5: remove unnecessary wmb for Memory > Region cache > > 'dev

[dpdk-dev] [Bug 713] Failure in latest DPDK build: Cannot init any port in AWS ENA

2021-05-18 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=713 Bug ID: 713 Summary: Failure in latest DPDK build: Cannot init any port in AWS ENA Product: DPDK Version: 20.11 Hardware: All OS: All Status: UNCONFIRMED

Re: [dpdk-dev] [PATCH] net/mlx5: check meta register width for modify field

2021-05-18 Thread Thomas Monjalon
> > The modify_field Flow API assumes that the META item is 32 bits wide. > > But the C Register that is used for Meta item can be 16 or 32 bits wide > > depending on kernel and firmware configurations. > > Take this into consideration and use the appropriate META width. > > > > Fixes: 641dbe4fb0

Re: [dpdk-dev] [PATCH] net/mlx5: check meta register width for modify field

2021-05-18 Thread Slava Ovsiienko
> -Original Message- > From: Alexander Kozyrev > Sent: Thursday, May 13, 2021 22:55 > To: dev@dpdk.org > Cc: sta...@dpdk.org; Raslan Darawsheh ; Slava > Ovsiienko ; Matan Azrad > Subject: [PATCH] net/mlx5: check meta register width for modify field > > The modify_field Flow API assumes t

Re: [dpdk-dev] [PATCH] test/table: fix build with GCC 11

2021-05-18 Thread Kevin Traynor
On 18/05/2021 09:55, Thomas Monjalon wrote: > 17/05/2021 17:57, Ferruh Yigit: >> Build error: >> ../app/test/test_table_tables.c: In function ‘test_table_stub’: >> ../app/test/test_table_tables.c:31:9: >> warning: ‘memset’ offset [0, 31] is out of the bounds [0, 0] >> [-Warray-bounds] >>

[dpdk-dev] 回复: [PATCH] app/eventdev: remove unnecessary barrier for order test

2021-05-18 Thread Feifei Wang
Hi, Jerin Sorry to disturb you. Would you please help me review this patch, thanks very much. Best Regards Feifei > -Original Message- > From: Feifei Wang > Sent: Monday, May 10, 2021 2:12 PM > To: jer...@marvell.com > Cc: dev@dpdk.org; nd ; Feifei Wang > ; Ruifeng Wang ; > Honnappa N

Re: [dpdk-dev] [PATCH] doc: update QAT compression PMD in 21.05 rel notes

2021-05-18 Thread Dybkowski, AdamX
Thanks, Akhil. Adam > -Original Message- > From: Akhil Goyal > Sent: Monday, 17 May, 2021 21:39 > To: Dybkowski, AdamX ; Thomas Monjalon > > Cc: dev@dpdk.org; Zhang, Roy Fan ; Mcnamara, > John ; Yigit, Ferruh > Subject: RE: [dpdk-dev] [PATCH] doc: update QAT compression PMD in > 21.05

Re: [dpdk-dev] [PATCH] test/table: fix build with GCC 11

2021-05-18 Thread Thomas Monjalon
17/05/2021 17:57, Ferruh Yigit: > Build error: > ../app/test/test_table_tables.c: In function ‘test_table_stub’: > ../app/test/test_table_tables.c:31:9: > warning: ‘memset’ offset [0, 31] is out of the bounds [0, 0] > [-Warray-bounds] > memset((uint8_t *)mbuf + sizeof(struct rt

[dpdk-dev] 回复: [PATCH v2 2/2] net/mlx5: remove unnecessary wmb for Memory Region cache

2021-05-18 Thread Feifei Wang
Hi, Slava > -邮件原件- > 发件人: Slava Ovsiienko > 发送时间: 2021年5月17日 22:15 > 收件人: Feifei Wang ; Matan Azrad > ; Shahaf Shuler > 抄送: dev@dpdk.org; nd ; Ruifeng Wang > > 主题: RE: [PATCH v2 2/2] net/mlx5: remove unnecessary wmb for Memory > Region cache > > Hi, Feifei > > Thanks you for the patch

[dpdk-dev] [PATCH v3 2/2] net/mlx5: remove unnecessary wmb for Memory Region cache

2021-05-18 Thread Feifei Wang
'dev_gen' is a variable to trigger all cores to flush their local caches once the global MR cache has been rebuilt. This is due to MR cache's R/W lock can maintain synchronization between threads: 1. dev_gen and global cache updating ordering inside the lock protected section does not matter. Bec

[dpdk-dev] [PATCH v3 1/2] net/mlx4: remove unnecessary wmb for Memory Region cache

2021-05-18 Thread Feifei Wang
'dev_gen' is a variable to trigger all cores to flush their local caches once the global MR cache has been rebuilt. This is due to MR cache's R/W lock can maintain synchronization between threads: 1. dev_gen and global cache updating ordering inside the lock protected section does not matter. Bec

[dpdk-dev] [PATCH v3 0/2] remove wmb for net/mlx

2021-05-18 Thread Feifei Wang
For net/mlx4 and net/mlx5, remove unnecessary wmb for Memory Region cache. v2: 1. keep the order of dev_gen and global cache (Slava Ovsiienko) 2. remove the wmb at last instead of moving it forward 3. remove atomic_thread_fence patches v3: 1. commit message rewording (Slava Ovsiienko) Feifei Wan

Re: [dpdk-dev] [PATCH v3] net/mlx5: fix loopback for DV queue

2021-05-18 Thread Bing Zhao
Thanks a lot, Thomas. > -Original Message- > From: Thomas Monjalon > Sent: Tuesday, May 18, 2021 4:33 PM > To: Bing Zhao > Cc: Slava Ovsiienko ; Matan Azrad > ; dev@dpdk.org; Ori Kam ; Raslan > Darawsheh ; sta...@dpdk.org; Tal Shnaiderman > > Subject: Re: [dpdk-dev] [PATCH v3] net/mlx5:

Re: [dpdk-dev] [PATCH v3] net/mlx5: fix loopback for DV queue

2021-05-18 Thread Thomas Monjalon
17/05/2021 17:18, Bing Zhao: > In the past, all the queues and other hardware objects were created > through Verbs interface. Currently, most of the objects creation are > migrated to Devx interface by default, including queues. Only when > the DV is disabled by device arg or eswitch is enabled, al

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] vdpa/mlx5: fix device unplug

2021-05-18 Thread Xia, Chenbo
> -Original Message- > From: stable On Behalf Of Matan Azrad > Sent: Friday, May 14, 2021 2:40 AM > To: dev@dpdk.org > Cc: maxime.coque...@redhat.com; sta...@dpdk.org; Eli Britstein > ; Xueming Li > Subject: [dpdk-stable] [PATCH v2] vdpa/mlx5: fix device unplug > > The vDPA PCI device un

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] vdpa/mlx5: fix device unplug

2021-05-18 Thread Xia, Chenbo
> -Original Message- > From: stable On Behalf Of Matan Azrad > Sent: Friday, May 14, 2021 2:40 AM > To: dev@dpdk.org > Cc: maxime.coque...@redhat.com; sta...@dpdk.org; Eli Britstein > ; Xueming Li > Subject: [dpdk-stable] [PATCH v2] vdpa/mlx5: fix device unplug > > The vDPA PCI device un

Re: [dpdk-dev] [PATCH] net/vhost: restore pseudo TSO support

2021-05-18 Thread Xia, Chenbo
> -Original Message- > From: David Marchand > Sent: Tuesday, May 18, 2021 3:07 PM > To: dev@dpdk.org > Cc: tho...@monjalon.net; Yigit, Ferruh ; Maxime > Coquelin ; Xia, Chenbo > Subject: [PATCH] net/vhost: restore pseudo TSO support > > The net/vhost pmd does not comply with the ethdev o

Re: [dpdk-dev] [PATCH] vhost: restore IOTLB mempool allocation

2021-05-18 Thread Xia, Chenbo
> -Original Message- > From: David Marchand > Sent: Monday, May 17, 2021 5:00 PM > To: dev@dpdk.org > Cc: tho...@monjalon.net; Yigit, Ferruh ; Maxime > Coquelin ; Xia, Chenbo ; > Zhihong Wang ; Junjie Wan > > Subject: [PATCH] vhost: restore IOTLB mempool allocation > > As explained by Ch

Re: [dpdk-dev] [PATCH] vhost: fix invalid use of stored last used index

2021-05-18 Thread Xia, Chenbo
> -Original Message- > From: dev On Behalf Of Balazs Nemeth > Sent: Saturday, May 15, 2021 12:02 AM > To: bnem...@redhat.com; dev@dpdk.org; Ling, WeiX > Subject: [dpdk-dev] [PATCH] vhost: fix invalid use of stored last used index > > The optimization introduced by commit d18db8049c7c ("v

Re: [dpdk-dev] [PATCH] doc: announce transition to vDPA port close function

2021-05-18 Thread Andrew Rybchenko
On 5/18/21 10:34 AM, Thomas Monjalon wrote: > There is a layer violation in the vDPA API which encourages to destroy > a full device with rte_dev_remove() instead of just closing the port. > The plan is to introduce a new function in 21.08, promote in 21.11, > and deprecate rte_vdpa_get_rte_device(

[dpdk-dev] [PATCH] doc: announce transition to vDPA port close function

2021-05-18 Thread Thomas Monjalon
There is a layer violation in the vDPA API which encourages to destroy a full device with rte_dev_remove() instead of just closing the port. The plan is to introduce a new function in 21.08, promote in 21.11, and deprecate rte_vdpa_get_rte_device() in 21.11. Signed-off-by: Thomas Monjalon --- do

Re: [dpdk-dev] [dpdk-announce] release candidate 21.05-rc3

2021-05-18 Thread Jiang, YuX
All, Update the test status for Intel part. Till now dpdk21.05-rc3 test is almost finished and no critical issue blocked the test. # Basic Intel(R) NIC testing * Build or compile: *Build: cover the build test combination with latest GCC/Clang/ICC version and the popular

Re: [dpdk-dev] [PATCH] net/vhost: restore pseudo TSO support

2021-05-18 Thread Maxime Coquelin
Hi David, On 5/18/21 9:07 AM, David Marchand wrote: > The net/vhost pmd does not comply with the ethdev offload API as it does > not report rx/tx offload capabilities wrt TSO and checksum offloading. > On the other hand, the net/vhost pmd lets guest negotiates TSO and > checksum offloading. > > C

[dpdk-dev] [PATCH] net/vhost: restore pseudo TSO support

2021-05-18 Thread David Marchand
The net/vhost pmd does not comply with the ethdev offload API as it does not report rx/tx offload capabilities wrt TSO and checksum offloading. On the other hand, the net/vhost pmd lets guest negotiates TSO and checksum offloading. Changing the behavior for rx/tx offload flags handling won't impro