Yes, It is palliative, it is not perfect, and, IMO, it is crucial - with always applying 32-bit wide values we can destroy the kernel part of reg_c0 in some extended metadata modes and this would lead to steering malfunction.
With best regards, Slava From: Asaf Penso <as...@nvidia.com> Sent: Tuesday, May 18, 2021 14:33 To: NBU-Contact-Thomas Monjalon <tho...@monjalon.net>; Alexander Kozyrev <akozy...@nvidia.com>; Raslan Darawsheh <rasl...@nvidia.com> Cc: dev@dpdk.org; sta...@dpdk.org; Raslan Darawsheh <rasl...@nvidia.com>; Matan Azrad <ma...@nvidia.com>; Slava Ovsiienko <viachesl...@nvidia.com> Subject: Re: [dpdk-dev] [PATCH] net/mlx5: check meta register width for modify field I didn't plan to have it in this release since it's not critical and I'm afraid of such changes... I didn't mention this in the status mail today. @Raslan Darawsheh<mailto:rasl...@nvidia.com> can we check tomorrow regression result? If not good we'll need to revert it. Regards, Asaf Penso ________________________________ From: Thomas Monjalon <tho...@monjalon.net<mailto:tho...@monjalon.net>> Sent: Tuesday, May 18, 2021 12:43:34 PM To: Alexander Kozyrev <akozy...@nvidia.com<mailto:akozy...@nvidia.com>> Cc: dev@dpdk.org<mailto:dev@dpdk.org> <dev@dpdk.org<mailto:dev@dpdk.org>>; sta...@dpdk.org<mailto:sta...@dpdk.org> <sta...@dpdk.org<mailto:sta...@dpdk.org>>; Raslan Darawsheh <rasl...@nvidia.com<mailto:rasl...@nvidia.com>>; Matan Azrad <ma...@nvidia.com<mailto:ma...@nvidia.com>>; Slava Ovsiienko <viachesl...@nvidia.com<mailto:viachesl...@nvidia.com>>; Asaf Penso <as...@nvidia.com<mailto:as...@nvidia.com>> Subject: Re: [dpdk-dev] [PATCH] net/mlx5: check meta register width for modify field > > The modify_field Flow API assumes that the META item is 32 bits wide. > > But the C Register that is used for Meta item can be 16 or 32 bits wide > > depending on kernel and firmware configurations. > > Take this into consideration and use the appropriate META width. > > > > Fixes: 641dbe4fb0 ("net/mlx5: support modify field flow action") > > Cc: sta...@dpdk.org<mailto:sta...@dpdk.org> > > > > Signed-off-by: Alexander Kozyrev > > <akozy...@nvidia.com<mailto:akozy...@nvidia.com>> > Acked-by: Viacheslav Ovsiienko > <viachesl...@nvidia.com<mailto:viachesl...@nvidia.com>> Applied in next-net-mlx, thanks.
