[dpdk-dev] [PATCH 4/4] common/iavf: use BIT() macro for offload/cap bits

2021-04-23 Thread Qi Zhang
Currently raw hex values are used to define specific bits for each offload/capability in virtchnl.h. The can and has led to duplicate defined bits. Fix this by using the BIT() macro so it's immediately obvious which bits are used/available. Signed-off-by: Brett Creeley Signed-off-by: Qi Zhang --

[dpdk-dev] [PATCH 3/4] common/iavf: refine comment in virtchnl

2021-04-23 Thread Qi Zhang
General clean up for comment in virtchnl. Signed-off-by: Sridhar Samudrala Signed-off-by: Joshua Hay Signed-off-by: Qi Zhang --- drivers/common/iavf/virtchnl.h | 69 -- 1 file changed, 49 insertions(+), 20 deletions(-) diff --git a/drivers/common/iavf/virtchnl.

[dpdk-dev] [PATCH 2/4] common/iavf: add enumeration for the rxdid format

2021-04-23 Thread Qi Zhang
Support for allowing VFs to negotiate the descriptor format was added previously. This support requires that the VF specify which descriptor format to use when requesting Rx queues. The VF is supposed to request the set of supported formats via the new VIRTCHNL_OP_GET_SUPPORTED_RXDIDS, and then se

[dpdk-dev] [PATCH 1/4] common/iavf: fix duplicate defined offload bit

2021-04-23 Thread Qi Zhang
The value of offload VIRTCHNL_VF_OFFLOAD_CRC bit already existed as VIRTCHNL_VF_CAP_ADV_LINK_SPEED. Fix this now by changing the value of VIRTCHNL_VF_OFFLOAD_CRC to a currently unused value. Also, move the define for VIRTCHNL_VF_CAP_ADV_LINK_SPEED in the correct place to line up with the other bit

[dpdk-dev] [PATCH 0/4] common/iavf: update virtchnl

2021-04-23 Thread Qi Zhang
Couple code refine and bug fix Qi Zhang (4): common/iavf: fix duplicate defined offload bit common/iavf: add enumeration for the rxdid format common/iavf: refine comment in virtchnl common/iavf: use BIT() macro for offload/cap bits drivers/common/iavf/virtchnl.h | 183 +++

Re: [dpdk-dev] [PATCH v1 1/2] common/iavf: add header types for PPPoL2TPv2oUDP

2021-04-23 Thread Zhang, Qi Z
> -Original Message- > From: Xu, Ting > Sent: Friday, April 23, 2021 4:07 PM > To: dev@dpdk.org > Cc: Xing, Beilei ; Wu, Jingjing > ; > Zhang, Qi Z ; Xu, Ting > Subject: [PATCH v1 1/2] common/iavf: add header types for PPPoL2TPv2oUDP > > Added two virtchnl protocol header types for L

Re: [dpdk-dev] [PATCH v2] build: fix symlink of drivers for Windows

2021-04-23 Thread Narcisa Ana Maria Vasile
On Sat, Apr 10, 2021 at 09:01:43AM +0100, Nick Connolly wrote: > The symlink-drivers-solibs.sh script was disabled as part of 'install' > for Windows because there is no support for shell scripts. However, > this means that driver related DLLs are not present in the installed > 'libdir' directory.

Re: [dpdk-dev] L3fwd mode in testpmd

2021-04-23 Thread Honnappa Nagarahalli
> > > > > > > > On Thu, Mar 11, 2021 at 12:01 AM Honnappa Nagarahalli > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > Hello, > > > > > > > > > Performance of L3fwd example application is one > > > > > > > > > of the key > > > > > > > > benchmarks in DPDK. However, the applicat

[dpdk-dev] [PATCH] net/bnxt: use bnxt_ prefix on global function

2021-04-23 Thread Stephen Hemminger
When statically linked the function prandom_bytes is exposed and might conflict with something in application. All driver functions should use same prefix. Fixes: 9738793f28ec ("net/bnxt: add VNIC functions and structs") Signed-off-by: Stephen Hemminger --- drivers/net/bnxt/bnxt_flow.c | 4 ++--

Re: [dpdk-dev] [PATCH v4 2/2] lib/mempool: distinguish debug counters from cache and pool

2021-04-23 Thread Dharmik Thakkar
+Honnappa > On Apr 22, 2021, at 8:29 PM, Dharmik Thakkar wrote: > > From: Joyce Kong > > If cache is enabled, objects will be retrieved/put from/to cache, > subsequently from/to the common pool. Now the debug stats calculate > the objects retrieved/put from/to cache and pool together, it is >

Re: [dpdk-dev] [PATCH] app/bbdev: fix wrong variable

2021-04-23 Thread Chautru, Nicolas
> -Original Message- > From: Min Hu (Connor) > Sent: Friday, April 23, 2021 12:43 AM > > This patch corrected misused variable. > > Fixes: d819c08327f3 ("app/bbdev: update for 5GNR") > Cc: sta...@dpdk.org > > Signed-off-by: Min Hu (Connor) Thanks Acked-by: Nicolas Chautru > --- >

Re: [dpdk-dev] [PATCH v3 2/7] test: introduce parent testsuite format

2021-04-23 Thread Aaron Conole
Ciara Power writes: > The current structure for unit testing only allows for running a > test suite with nested test cases. This means all test cases for an > autotest must be in one suite, which is not ideal. > For example, in some cases we may want to run multiple lists of test > cases that eac

[dpdk-dev] [PATCH v2] doc: fix formatting in testpmd user guide

2021-04-23 Thread Ferruh Yigit
From: Ajit Khaparde Fix formatting in testpmd user guide for hairpin operation. Fixes: 01817b10d27c ("app/testpmd: change hairpin queues setup") Cc:sta...@dpdk.org Signed-off-by: Ajit Khaparde --- Cc: Bing Zhao Cc: Ori Kam v2: * Fix only list formatting --- doc/guides/testpmd_app_ug/run_ap

[dpdk-dev] [PATCH v3 7/7] test/crypto: dynamically build blockcipher suite

2021-04-23 Thread Ciara Power
In the existing implementation, the blockcipher test cases are being run and reported as one test case per type, even though multiple test cases are hidden in each. For example, "test_AES_chain_all" runs 46 test cases. Each blockcipher type should have a testsuite instead. The blockcipher testsuit

[dpdk-dev] [PATCH v3 6/7] test/crypto: fix return value on test skipped

2021-04-23 Thread Ciara Power
The blockcipher testcase return value TEST_SUCCESS was incorrect for one conditional check, it should have been TEST_SKIPPED similar to the other condition checks in this function when the testcase is skipped. Fixes: 4868f6591c6f ("test/crypto: add cases for raw datapath API") Cc: roy.fan.zh...@in

[dpdk-dev] [PATCH v3 4/7] test/crypto: replace unsupported with skipped

2021-04-23 Thread Ciara Power
Testcases were previously using -ENOTSUP and TEST_SKIPPED return statuses interchangeably. Both resulted in the testcase not being run. These return statuses are now standardised to TEST_SKIPPED. Signed-off-by: Ciara Power --- app/test/test_cryptodev.c | 464 ---

[dpdk-dev] [PATCH v3 5/7] test/crypto: move testsuite params to header file

2021-04-23 Thread Ciara Power
The testsuite params struct and ut functions are now in the cryptodev test header file. This will allow them be used outside of the cryptodev_test.c file. They will be used in a subsequent patch by the blockcipher test. As a result of this change, slight renaming changes were necessary for ipsec a

[dpdk-dev] [PATCH v3 3/7] test/crypto: refactor to use sub-testsuites

2021-04-23 Thread Ciara Power
The existing implementation runs a giant cryptodev testsuite for most autotests, which in turns runs one setup function regardless of device. This is now broken down into multiple testsuites, that are used as sub-testsuites. Each autotest runs a general crypto parent test suite, to which the sub-t

[dpdk-dev] [PATCH v3 2/7] test: introduce parent testsuite format

2021-04-23 Thread Ciara Power
The current structure for unit testing only allows for running a test suite with nested test cases. This means all test cases for an autotest must be in one suite, which is not ideal. For example, in some cases we may want to run multiple lists of test cases that each require different setup, so sh

[dpdk-dev] [PATCH v3 1/7] app/test: refactor of unit test suite runner

2021-04-23 Thread Ciara Power
Some small changes were made to the unit test suite runner for readability and to enable reuse of some of the function in a later patch. On test suite setup skip/fail, the loop to count testcases as skipped/failed has been moved to another function. This will allow for recursion in a later patch w

[dpdk-dev] [PATCH v3 0/7] test: refactor crypto unit test framework

2021-04-23 Thread Ciara Power
The current crypto unit test framework is not granular enough to accurately track unit test results. This is caused by one testcase in a suite actually running multiple testcases, but only returning one result. The approach taken in this patchset allows a test suite have a list of sub-testsuites,

Re: [dpdk-dev] [dpdk-stable] [PATCH] doc: fix nfp multiport syntax

2021-04-23 Thread Ferruh Yigit
On 3/1/2021 1:45 PM, Ferruh Yigit wrote: On 2/25/2021 11:46 AM, Heinrich Kuhn wrote: From: "Chaoyong.He" 1. Fixup the suffix of the PCI ID to be consistent with the code. 2. Add specification of using MAC address to identify port. Fixes: 979f2bae0 ("doc: improve multiport PF in nfp guide") Cc

[dpdk-dev] [PATCH v2] app/testpmd: fix segment number check

2021-04-23 Thread Ferruh Yigit
From: Viacheslav Ovsiienko The --txpkts command line parameter was silently ignored due to application was unable to check the Tx queue ring sizes for non configured ports [1]. The "set txpkts " was also rejected if there was some stopped or /unconfigured port. This provides the following: -

Re: [dpdk-dev] [PATCH V5] ethdev: add queue state when retrieve queue information

2021-04-23 Thread Kinsella, Ray
On 23/04/2021 12:26, Ananyev, Konstantin wrote: > > >> -Original Message- >> From: dev On Behalf Of Kinsella, Ray >> Sent: Friday, April 23, 2021 12:17 PM >> To: Lijun Ou ; tho...@monjalon.net; Yigit, Ferruh >> >> Cc: dev@dpdk.org; linux...@openeuler.org >> Subject: Re: [dpdk-dev] [

Re: [dpdk-dev] [PATCH] net/virtio: fix kernel set memory table for multi-queue devices

2021-04-23 Thread Maxime Coquelin
On 4/23/21 2:25 PM, Thierry Herbelot wrote: > Restore the original code, where VHOST_SET_MEM_TABLE is applied to > all vhostfds of the device. > > Fixes: 539d910c9c768 ("net/virtio: add virtio-user memory tables ops") > Cc: sta...@dpdk.org > > Signed-off-by: Thierry Herbelot > --- > drivers/

[dpdk-dev] [PATCH] acl: fix build with gcc 11

2021-04-23 Thread Konstantin Ananyev
gcc 11 with '-O2' complains about some variables being used without being initialized: In file included from ../lib/librte_acl/acl_run_avx512x8.h:201, from ../lib/librte_acl/acl_run_avx512.c:110: In function ‘start_flow_avx512x8’, inlined from ‘search_trie_avx512x8.constprop’

Re: [dpdk-dev] [dpdk-stable] [PATCH v5 3/3] kni: fix kernel deadlock when using mlx devices

2021-04-23 Thread Igor Ryzhov
Sorry I remembered the problem with the deadlock. We can't just make the shutdown command synchronous, because we can't release the rtnl_lock anyway. So regardless of the process mode (sync/async), we have to preserve the lock when processing the shutdown. It looks like two different settings...

Re: [dpdk-dev] [dpdk-stable] [PATCH v5 3/3] kni: fix kernel deadlock when using mlx devices

2021-04-23 Thread Igor Ryzhov
Hi Ferruh, Thanks. I think it would be great to make this configurable, and maybe even make shutdown synchronous by default to preserve the old behavior. I would be grateful if you could spend time on the work and I am ready to review it. Igor On Fri, Apr 23, 2021 at 11:59 AM Ferruh Yigit wrot

Re: [dpdk-dev] [PATCH v5 0/5] eal: enable global device syntax by default

2021-04-23 Thread Kinsella, Ray
On 23/04/2021 12:39, Gaëtan Rivet wrote: > On Fri, Apr 23, 2021, at 13:06, Kinsella, Ray wrote: >> >> >> On 14/04/2021 20:49, Thomas Monjalon wrote: >>> 13/04/2021 05:14, Xueming Li: Xueming Li (5): devargs: unify scratch buffer storage devargs: fix memory leak on parsing erro

Re: [dpdk-dev] [PATCH v3 1/3] bus/pci: enable PCI master in command register

2021-04-23 Thread Kinsella, Ray
On 23/04/2021 12:39, Haiyue Wang wrote: > This adds the support to set 'Bus Master Enable' bit in the PCI command > register. > > Signed-off-by: Haiyue Wang > Tested-by: Qi Zhang > --- > drivers/bus/pci/pci_common.c | 20 > drivers/bus/pci/rte_bus_pci.h | 12 +++

Re: [dpdk-dev] [PATCH v5] net/iavf: fix hash configuration on i40e VF

2021-04-23 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Alvin Zhang > Sent: Thursday, April 22, 2021 1:08 PM > To: Wu, Jingjing ; Xing, Beilei > Cc: dev@dpdk.org; Zhang, AlvinX ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH v5] net/iavf: fix hash configuration on i40e VF > > In i40evf PMD, the

[dpdk-dev] [PATCH] net/virtio: fix kernel set memory table for multi-queue devices

2021-04-23 Thread Thierry Herbelot
Restore the original code, where VHOST_SET_MEM_TABLE is applied to all vhostfds of the device. Fixes: 539d910c9c768 ("net/virtio: add virtio-user memory tables ops") Cc: sta...@dpdk.org Signed-off-by: Thierry Herbelot --- drivers/net/virtio/virtio_user/vhost_kernel.c | 12 +--- 1 file c

Re: [dpdk-dev] [PATCH v2 1/3] bus/pci: enable PCI master in command register

2021-04-23 Thread Wang, Haiyue
> -Original Message- > From: Kinsella, Ray > Sent: Friday, April 23, 2021 18:44 > To: Wang, Haiyue ; dev@dpdk.org > Cc: Zhang, Qi Z ; Wang, Liang-min > ; Neil Horman > ; Gaetan Rivet > Subject: Re: [PATCH v2 1/3] bus/pci: enable PCI master in command register > > > > On 22/04/2021 02:

[dpdk-dev] [PATCH v3 1/3] bus/pci: enable PCI master in command register

2021-04-23 Thread Haiyue Wang
This adds the support to set 'Bus Master Enable' bit in the PCI command register. Signed-off-by: Haiyue Wang Tested-by: Qi Zhang --- drivers/bus/pci/pci_common.c | 20 drivers/bus/pci/rte_bus_pci.h | 12 drivers/bus/pci/version.map | 3 +++ lib/pci/rte_pci.

[dpdk-dev] [PATCH v3 2/3] net/iavf: enable PCI bus master after reset

2021-04-23 Thread Haiyue Wang
The VF reset can be triggerred by the PF reset event, in this case, the PCI bus master will be cleared, then the VF is not allowed to issue any Memory or I/O Requests. So after the reset event is detected, always enable the PCI bus master. Signed-off-by: Haiyue Wang Tested-by: Qi Zhang --- dri

[dpdk-dev] [PATCH v3 3/3] net/i40e: enable PCI bus master after reset

2021-04-23 Thread Haiyue Wang
The VF reset can be triggerred by the PF reset event, in this case, the PCI bus master will be cleared, then the VF is not allowed to issue any Memory or I/O Requests. So after the reset event is detected, always enable the PCI bus master. And align the VF reset event handling in device close mod

[dpdk-dev] [PATCH v3 0/3] fix PF reset causes VF memory request failure

2021-04-23 Thread Haiyue Wang
By triggerring the VF reset from PF reset, echo 1 > /sys/bus/pci/devices/PF-BDF/reset the PCI bus master bit will cleared on VF, so the VF needs to enable this bit before restart. This patch set adds the API to enable PCI bus master. v3: added the missed annotate symbol add time v2: reb

Re: [dpdk-dev] [RFC] net/ionic: update MTU calculations

2021-04-23 Thread Ferruh Yigit
On 12/15/2020 12:26 PM, Ferruh Yigit wrote: On 12/10/2020 2:46 AM, Andrew Boyer wrote: This RFC is in response to the threads about testpmd mtu settings and the deprecation of max-rx-pkt-len. It took us a while to figure out what we were supposed to be doing in this part of the API. It is not c

Re: [dpdk-dev] [PATCH v5 0/5] eal: enable global device syntax by default

2021-04-23 Thread Gaëtan Rivet
On Fri, Apr 23, 2021, at 13:06, Kinsella, Ray wrote: > > > On 14/04/2021 20:49, Thomas Monjalon wrote: > > 13/04/2021 05:14, Xueming Li: > >> Xueming Li (5): > >> devargs: unify scratch buffer storage > >> devargs: fix memory leak on parsing error > >> kvargs: add get by key function > >>

Re: [dpdk-dev] [PATCH v1 1/1] power: add support for cppc cpufreq

2021-04-23 Thread Burakov, Anatoly
On 22-Apr-21 11:02 AM, Richael Zhuang wrote: -Original Message- From: Burakov, Anatoly Sent: Thursday, April 22, 2021 6:00 PM To: Richael Zhuang ; dev@dpdk.org Cc: nd ; David Hunt Subject: Re: [dpdk-dev] [PATCH v1 1/1] power: add support for cppc cpufreq On 22-Apr-21 10:29 AM, Richa

Re: [dpdk-dev] [PATCH V5] ethdev: add queue state when retrieve queue information

2021-04-23 Thread Ananyev, Konstantin
> -Original Message- > From: dev On Behalf Of Kinsella, Ray > Sent: Friday, April 23, 2021 12:17 PM > To: Lijun Ou ; tho...@monjalon.net; Yigit, Ferruh > > Cc: dev@dpdk.org; linux...@openeuler.org > Subject: Re: [dpdk-dev] [PATCH V5] ethdev: add queue state when retrieve > queue infor

Re: [dpdk-dev] [PATCH V5] ethdev: add queue state when retrieve queue information

2021-04-23 Thread Kinsella, Ray
On 17/04/2021 04:09, Lijun Ou wrote: > Currently, upper-layer application could get queue state only > through pointers such as dev->data->tx_queue_state[queue_id], > this is not the recommended way to access it. So this patch > add get queue state when call rte_eth_rx_queue_info_get and > rte_e

Re: [dpdk-dev] [PATCH V4] ethdev: add queue state when retrieve queue information

2021-04-23 Thread Kinsella, Ray
On 16/04/2021 10:57, Thomas Monjalon wrote: > 16/04/2021 11:41, Ferruh Yigit: >> On 4/16/2021 9:58 AM, Thomas Monjalon wrote: >>> 16/04/2021 10:46, Lijun Ou: Currently, upper-layer application could get queue state only through pointers such as dev->data->tx_queue_state[queue_id],

Re: [dpdk-dev] [PATCH v5 0/5] eal: enable global device syntax by default

2021-04-23 Thread Kinsella, Ray
On 14/04/2021 20:49, Thomas Monjalon wrote: > 13/04/2021 05:14, Xueming Li: >> Xueming Li (5): >> devargs: unify scratch buffer storage >> devargs: fix memory leak on parsing error >> kvargs: add get by key function >> bus: add device arguments name parsing API >> devargs: parse global

[dpdk-dev] [21.08 PATCH v4 2/2] power: refactor pstate and acpi code

2021-04-23 Thread Anatoly Burakov
Currently, ACPI and PSTATE modes have lots of code duplication, confusing logic, and a bunch of other issues that can, and have, led to various bugs and resource leaks. This commit factors out the common parts of sysfs reading/writing for ACPI and PSTATE drivers. Signed-off-by: Anatoly Burakov -

[dpdk-dev] [21.08 PATCH v4 1/2] power: don't use rte prefix in internal code

2021-04-23 Thread Anatoly Burakov
Currently, ACPI code uses rte_power_info as the struct name, which gives the appearance that this is an externally visible API. Fix to use internal namespace. Signed-off-by: Anatoly Burakov --- lib/power/power_acpi_cpufreq.c | 34 +- 1 file changed, 17 insertions(

[dpdk-dev] [PATCH v1 1/1] power: do not skip saving original acpi governor

2021-04-23 Thread Anatoly Burakov
Currently, when we set the acpi governor to "userspace", we check if it is already set to this value, and if it is, we skip setting it. However, we never save this value anywhere, so that next time we come back and request the governor to be set to its original value, the original value is empty.

[dpdk-dev] [PATCH 0/2] bugfix for sched

2021-04-23 Thread Min Hu (Connor)
This patch set contains two bugfixes for sched. Huisong Li (2): lib/sched: fix return value judgment lib/sched: optimize exception handling code lib/sched/rte_sched.c | 60 +++ 1 file changed, 32 insertions(+), 28 deletions(-) -- 2.7.4

[dpdk-dev] [PATCH 2/2] lib/sched: optimize exception handling code

2021-04-23 Thread Min Hu (Connor)
From: Huisong Li Currently, rte_sched_free_memory() is called multiple times by the exception handling code in rte_sched_subport_config() and rte_sched_pipe_config(). This patch optimizes them into a unified outlet to free memory. Fixes: ac6fcb841b0f ("sched: update subport rate dynamically") F

[dpdk-dev] [PATCH 1/2] lib/sched: fix return value judgment

2021-04-23 Thread Min Hu (Connor)
From: Huisong Li This patch fixes return value judgment when allocate memory to store the subport profile, and releases memory of 'rte_sched_port' if code fails to apply for this memory. Fixes: 0ea4c6afcaf1 ("sched: add subport profile table") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Sign

Re: [dpdk-dev] [PATCH] doc: announce modification in eventdev structure

2021-04-23 Thread Kinsella, Ray
On 15/04/2021 10:08, gak...@marvell.com wrote: > From: Akhil Goyal > > A new field ``ca_enqueue`` is added in ``rte_eventdev`` > in the end to maintain ABI. It needs to be moved above > in the structure to align with other enqueue callbacks. > > Signed-off-by: Akhil Goyal > --- > doc/guides

Re: [dpdk-dev] [PATCH v2 1/3] bus/pci: enable PCI master in command register

2021-04-23 Thread Kinsella, Ray
On 22/04/2021 02:18, Haiyue Wang wrote: > This adds the support to set 'Bus Master Enable' bit in the PCI command > register. > > Signed-off-by: Haiyue Wang > Tested-by: Qi Zhang > --- > drivers/bus/pci/pci_common.c | 20 > drivers/bus/pci/rte_bus_pci.h | 12 +++

Re: [dpdk-dev] [PATCH v3 2/2] lib/mempool: distinguish debug counters from cache and pool

2021-04-23 Thread Kinsella, Ray
On 21/04/2021 17:29, Olivier Matz wrote: > Hi Dharmik, > > Please see some comments below. > > On Mon, Apr 19, 2021 at 07:08:00PM -0500, Dharmik Thakkar wrote: >> From: Joyce Kong >> >> If cache is enabled, objects will be retrieved/put from/to cache, >> subsequently from/to the common pool.

Re: [dpdk-dev] [PATCH] net/kni: check rte kni init result

2021-04-23 Thread Ferruh Yigit
On 4/21/2021 3:14 AM, Min Hu (Connor) wrote: From: Chengwen Feng This patch adds checking for rte_kni_init() result. Fixes: 75e2bc54c018 ("net/kni: add KNI PMD") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) Acked-by: Ferruh Yigit

[dpdk-dev] [PATCH] net/hns3: disable the MAC status report interrupt

2021-04-23 Thread Min Hu (Connor)
From: HongBo Zheng Disable the MAC status report interrupt which hns3 driver not concern currently. Fixes: 5f8845f4ba8f ("net/hns3: process MAC interrupt") Cc: sta...@dpdk.org Signed-off-by: HongBo Zheng Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_ethdev.c | 2 -- 1 file changed

[dpdk-dev] [PATCH 0/2] add Tx prepare support for bonding device

2021-04-23 Thread Chengchang Tang
This patch set add Tx prepare for bonding device. Currently, the bonding driver has not implemented the callback of rte_eth_tx_prepare function. Therefore, the TX prepare function of the slave devices will never be invoked. When hardware offloading such as CKSUM and TSO are enabled for some driver

[dpdk-dev] [PATCH 1/2] net/bonding: support Tx prepare for bonding

2021-04-23 Thread Chengchang Tang
To use the HW offloads capability (e.g. checksum and TSO) in the Tx direction, the upper-layer users need to call rte_eth_dev_prepare to do some adjustment to the packets before sending them (e.g. processing pseudo headers when Tx checksum offoad enabled). But, the tx_prepare callback of the bond d

[dpdk-dev] [PATCH 2/2] net/bonding: support configuring Tx offloading for bonding

2021-04-23 Thread Chengchang Tang
Currently, the TX offloading of the bonding device will not take effect by using dev_configure. Because the related configuration will not be delivered to the slave devices in this way. The Tx offloading capability of the bonding device is the intersection of the capability of all slave devices. B

Re: [dpdk-dev] [PATCH 2/2] net/tap: fix tap interrupt vector array size

2021-04-23 Thread Min Hu (Connor)
在 2021/4/22 23:20, Stephen Hemminger 写道: On Thu, 22 Apr 2021 19:27:14 +0800 "Min Hu (Connor)" wrote: diff --git a/drivers/net/tap/tap_intr.c b/drivers/net/tap/tap_intr.c index 5cf4f17..1cacc15 100644 --- a/drivers/net/tap/tap_intr.c +++ b/drivers/net/tap/tap_intr.c @@ -59,7 +59,7 @@ tap_rx_

[dpdk-dev] [PATCH 0/2] bugfix for hns3 PMD

2021-04-23 Thread Min Hu (Connor)
This patch set contains two bugfixes for hns3 PMD. Min Hu (Connor) (2): net/hns3: fix wrong word of comments doc: fix runtime config options doc/guides/nics/hns3.rst | 9 + drivers/net/hns3/hns3_ethdev.c | 10 +- 2 files changed, 14 insertions(+), 5 deletions(-) -- 2

[dpdk-dev] [PATCH 1/2] net/hns3: fix wrong word of comments

2021-04-23 Thread Min Hu (Connor)
This patch fixed wrong word in comments. Fixes: f53a793bb7c2 ("net/hns3: add more hardware error types") Fixes: d51867db65c1 ("net/hns3: add initialization") Fixes: 411d23b9eafb ("net/hns3: support VLAN") Fixes: 5f8845f4ba8f ("net/hns3: process MAC interrupt") Cc: sta...@dpdk.org Signed-off-by: M

[dpdk-dev] [PATCH 2/2] doc: fix runtime config options

2021-04-23 Thread Min Hu (Connor)
This patch added examples for runtime config options, to help user how to use this. Fixes: a124f9e9591b ("net/hns3: add runtime config to select IO burst function") Fixes: 70791213242e ("net/hns3: support masking device capability") Signed-off-by: Min Hu (Connor) --- doc/guides/nics/hns3.rst |

Re: [dpdk-dev] [EXT] [PATCH] app/testeventdev: fix buffer overflow

2021-04-23 Thread Pavan Nikhilesh Bhagavatula
>Tainted and unvalidated integer 'idx' used as an index, which may >lead to buffer overflow. > >This patch fixed it. > >Fixes: 89e5eb118017 ("app/testeventdev: add string parsing helpers") >Cc: sta...@dpdk.org > >Signed-off-by: Min Hu (Connor) Acked-by: Pavan Nikhilesh >--- > app/test-eventdev/

Re: [dpdk-dev] [PATCH 2/2] graph: fix dereferencing null pointer

2021-04-23 Thread Jerin Jacob
On Thu, Apr 22, 2021 at 5:22 PM Min Hu (Connor) wrote: > > From: HongBo Zheng > > In function 'stats_mem_init', pointer 'stats' should > be confirmed not null before memset it. > > Fixes: af1ae8b6a32c ("graph: implement stats") > Cc: sta...@dpdk.org > > Signed-off-by: HongBo Zheng > Signed-off-b

Re: [dpdk-dev] [dpdk-stable] [PATCH v5 3/3] kni: fix kernel deadlock when using mlx devices

2021-04-23 Thread Ferruh Yigit
On 4/23/2021 9:41 AM, Igor Ryzhov wrote: This patch changes the behavior for KNI interface shutdown. Previously we would receive a real response from the driver, now we always receive success. I think this should be reflected in the docs/release notes. Hi Igor, Make sense, I can add it. Me

Re: [dpdk-dev] [PATCH] examples/vm_power_manager: remove vm channel number check

2021-04-23 Thread David Hunt
On 21/4/2021 11:45 AM, Reshma Pattan wrote: VM channel number should not be validated against the host vm_power_manager coremask core indexes, as VM cores need not to be same as host cores. So remove this check, to allow all the vm channels to be added successfully. Fixes: b49c677a0d24 ("examp

Re: [dpdk-dev] [PATCH v5] net/iavf: fix hash configuration on i40e VF

2021-04-23 Thread Chen, LingliX
> -Original Message- > From: dev On Behalf Of Alvin Zhang > Sent: Thursday, April 22, 2021 1:08 PM > To: Wu, Jingjing ; Xing, Beilei > Cc: dev@dpdk.org; Zhang, AlvinX ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH v5] net/iavf: fix hash configuration on i40e VF > Tested-by: Yan Xia

Re: [dpdk-dev] [dpdk-stable] [PATCH 2/2] app/testpmd: fix tunnel offload private items location

2021-04-23 Thread Ferruh Yigit
On 4/19/2021 2:02 PM, Gregory Etelson wrote: Flow rules used in tunnel offload model require application to query PMD for private flow elements and explicitly add these elements to flow rule. Hi Gregory, What is "private flow element"? And can you please detail what is fixed with this patch,

Re: [dpdk-dev] [dpdk-stable] [PATCH v5 3/3] kni: fix kernel deadlock when using mlx devices

2021-04-23 Thread Igor Ryzhov
This patch changes the behavior for KNI interface shutdown. Previously we would receive a real response from the driver, now we always receive success. I think this should be reflected in the docs/release notes. Igor On Wed, Apr 21, 2021 at 2:07 AM Thomas Monjalon wrote: > 12/04/2021 16:35, Ela

[dpdk-dev] [PATCH] kni: check code of allmulticast mode switch

2021-04-23 Thread Min Hu (Connor)
From: Chengwen Feng Some drivers may return errcode when switch allmulticast mode, so it's necessary to check the return code. Fixes: b34801d1aa2e ("kni: support allmulticast mode set") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) --- lib/kni/rte_kni.c | 13

[dpdk-dev] [PATCH] mbuf: check mbuf dyn shared memory validity

2021-04-23 Thread Min Hu (Connor)
From: Chengwen Feng Because mbuf dyn shared memory was allocated runtime, so it's necessary to check validity when dump mbuf dyn info. Also this patch adds an error logging when init shared memory fail. Fixes: 4958ca3a443a ("mbuf: support dynamic fields and flags") Cc: sta...@dpdk.org Signed-o

[dpdk-dev] [PATCH v1 2/2] common/iavf: fix wrong order of protocol header types

2021-04-23 Thread Ting Xu
The new virtchnl protocol header types for IPv4 and IPv6 fragment are not added in order, which will break ABI. Move them to the end of the list. Signed-off-by: Ting Xu Fixes: e6a42fd9158b ("common/iavf: add protocol header for IP fragment") Cc: sta...@dpdk.org --- drivers/common/iavf/virtchnl.h

[dpdk-dev] [PATCH v1 1/2] common/iavf: add header types for PPPoL2TPv2oUDP

2021-04-23 Thread Ting Xu
Added two virtchnl protocol header types for L2TPv2 and PPP to support the RSS hash for PPPoL2TPv2oUDP. Signed-off-by: Ting Xu --- drivers/common/iavf/virtchnl.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/common/iavf/virtchnl.h b/drivers/common/iavf/virtchnl.h index e3eb767d66

[dpdk-dev] [PATCH v2 2/2] net/ice: clean redundant macro definition of filters

2021-04-23 Thread Yuying Zhang
The input set has been divided into two parts to distinguish inner and outer field. ICE_INSET_TUN_* is the same as non tunnel macro definition. Clean redundant ICE_INSET_TUN_* codes. Signed-off-by: Yuying Zhang --- drivers/net/ice/ice_fdir_filter.c | 22 +-- drivers/net/ice/ice_generic

[dpdk-dev] [PATCH v2 1/2] net/ice: refactor input set fields for switch filter

2021-04-23 Thread Yuying Zhang
Input set has been divided into inner and outer part to distinguish different fields. However, the parse method of switch filter doesn't match this update. Refactor switch filter to distingush inner and outer input set in the same way as other filters. Signed-off-by: Yuying Zhang --- drivers/net

[dpdk-dev] [PATCH] app/bbdev: fix wrong variable

2021-04-23 Thread Min Hu (Connor)
This patch corrected misused variable. Fixes: d819c08327f3 ("app/bbdev: update for 5GNR") Cc: sta...@dpdk.org Signed-off-by: Min Hu (Connor) --- app/test-bbdev/test_bbdev_perf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-b

[dpdk-dev] [PATCH] app/crypto-perf: fix dereference of null return

2021-04-23 Thread Min Hu (Connor)
Return value of a function 'rte_zmalloc' is dereferenced without checking, and it may call segmentation fault. This patch fixed it. Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application") Cc: sta...@dpdk.org Signed-off-by: Min Hu (Connor) --- app/test-crypto-perf/cperf_

[dpdk-dev] [PATCH] app/testeventdev: fix buffer overflow

2021-04-23 Thread Min Hu (Connor)
Tainted and unvalidated integer 'idx' used as an index, which may lead to buffer overflow. This patch fixed it. Fixes: 89e5eb118017 ("app/testeventdev: add string parsing helpers") Cc: sta...@dpdk.org Signed-off-by: Min Hu (Connor) --- app/test-eventdev/evt_options.c | 4 ++-- app/test-eventde

[dpdk-dev] [PATCH] test: fix division by zero

2021-04-23 Thread Min Hu (Connor)
Variable i is used as a denominator which may be zero, and this may result in segmentation fault. This patch fixed it. Fixes: 948bc3d6d095 ("test: add reciprocal based division") Cc: sta...@dpdk.org Signed-off-by: Min Hu (Connor) --- app/test/test_reciprocal_division_perf.c | 5 +++-- 1 file c