Sorry I remembered the problem with the deadlock. We can't just make the shutdown command synchronous, because we can't release the rtnl_lock anyway. So regardless of the process mode (sync/async), we have to preserve the lock when processing the shutdown. It looks like two different settings...
On Fri, Apr 23, 2021 at 3:43 PM Igor Ryzhov <iryz...@nfware.com> wrote: > Hi Ferruh, > > Thanks. I think it would be great to make this configurable, and maybe even > make shutdown synchronous by default to preserve the old behavior. > > I would be grateful if you could spend time on the work and I am ready to > review it. > > Igor > > On Fri, Apr 23, 2021 at 11:59 AM Ferruh Yigit <ferruh.yi...@intel.com> > wrote: > >> On 4/23/2021 9:41 AM, Igor Ryzhov wrote: >> > This patch changes the behavior for KNI interface shutdown. >> > Previously we would receive a real response from the driver, now we >> > always receive success. >> > I think this should be reflected in the docs/release notes. >> > >> >> Hi Igor, >> >> Make sense, I can add it. >> >> Meanwhile do you think has a benefit to make shutdown behavior >> configurable? >> Async/Sync shutdown based on module param? >> >> > Igor >> > >> > On Wed, Apr 21, 2021 at 2:07 AM Thomas Monjalon <tho...@monjalon.net >> > <mailto:tho...@monjalon.net>> wrote: >> > >> > 12/04/2021 16:35, Elad Nachman: >> > > Hi, >> > > >> > > The new patch is fine by me. >> > > >> > > Tested several dozens restarts of our proprietary application >> without >> > > apparent problem. >> > >> > Series applied, thanks. >> > >> > >> >>
