Re: [dpdk-dev] [PATCH v5 1/8] eventdev: introduce event vector capability

2021-03-23 Thread Jayatheerthan, Jay
> -Original Message- > From: pbhagavat...@marvell.com > Sent: Wednesday, March 24, 2021 10:35 AM > To: jer...@marvell.com; Jayatheerthan, Jay ; > Carrillo, Erik G ; Gujjar, > Abhinandan S ; McDaniel, Timothy > ; hemant.agra...@nxp.com; Van > Haaren, Harry ; mattias.ronnblom > ; Ma, Lian

Re: [dpdk-dev] [PATCH v5 0/8] Introduce event vectorization

2021-03-23 Thread Pavan Nikhilesh Bhagavatula
>> From: pbhagavat...@marvell.com >> Sent: Wednesday, March 24, 2021 10:35 AM >> To: jer...@marvell.com; Jayatheerthan, Jay >; Carrillo, Erik G >; Gujjar, Abhinandan >> S ; McDaniel, Timothy >; hemant.agra...@nxp.com; Van >Haaren, Harry >> ; mattias.ronnblom >; Ma, Liang J > >> Cc: dev@dpdk.org; P

Re: [dpdk-dev] [PATCH v2 2/3] meson: use threads dependency as provided by meson

2021-03-23 Thread Gabriel Ganne
Hi Nick, Dmitry, Thanks for the reviews. I wrote this patch following the link issue I had with libpcap thinking it was "more of the same" ... which clearly it wasn't. I had a closer look to what dependency('threads') generates and I agree that it's not that well documented. From what I understa

Re: [dpdk-dev] [PATCH v5 0/8] Introduce event vectorization

2021-03-23 Thread Jayatheerthan, Jay
> -Original Message- > From: pbhagavat...@marvell.com > Sent: Wednesday, March 24, 2021 10:35 AM > To: jer...@marvell.com; Jayatheerthan, Jay ; > Carrillo, Erik G ; Gujjar, Abhinandan > S ; McDaniel, Timothy > ; hemant.agra...@nxp.com; Van Haaren, Harry > ; mattias.ronnblom > ; Ma, Lian

[dpdk-dev] [dpdk-dev v21.11] [PATCH v5 8/8] eventdev: simplify Rx adapter event vector config

2021-03-23 Thread pbhagavatula
From: Pavan Nikhilesh Include vector configuration into the structure ``rte_event_eth_rx_adapter_queue_conf`` used when configuring rest of the Rx adapter ethernet device Rx queue parameters. This simplifies event vector configuration as it avoids splitting configuration per Rx queue. Signed-off

[dpdk-dev] [PATCH v5 6/8] app/eventdev: add event vector mode in pipeline test

2021-03-23 Thread pbhagavatula
From: Pavan Nikhilesh Add event vector support in pipeline tests. By default this mode is disabled, it can be enabled by using the option --enable_vector. example: dpdk-test-eventdev -l 7-23 -s 0xff00 -- --prod_type_ethdev --nb_pkts=0 --verbose 2 --test=pipeline_atq --stlist=a

[dpdk-dev] [PATCH v5 7/8] doc: announce event Rx adapter config changes

2021-03-23 Thread pbhagavatula
From: Pavan Nikhilesh The Rx adapter event vector configuration will be merged into Rx adapter queue configuration to simplify enabling event vectorization. Signed-off-by: Pavan Nikhilesh --- doc/guides/rel_notes/deprecation.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/doc/

[dpdk-dev] [PATCH v5 4/8] eventdev: add Rx adapter event vector support

2021-03-23 Thread pbhagavatula
From: Pavan Nikhilesh Add event vector support for event eth Rx adapter, the implementation creates vector flows based on port and queue identifier of the received mbufs. Signed-off-by: Pavan Nikhilesh --- lib/librte_eventdev/eventdev_pmd.h| 7 +- .../rte_event_eth_rx_adapter.c

[dpdk-dev] [PATCH v5 5/8] eventdev: add Tx adapter event vector support

2021-03-23 Thread pbhagavatula
From: Pavan Nikhilesh Add event vector support for event eth Tx adapter, the implementation receives events from the single linked queue and based on rte_event_vector::union_valid transmits the vector of mbufs to a given port, queue pair. Signed-off-by: Pavan Nikhilesh --- .../rte_event_eth_tx

[dpdk-dev] [PATCH v5 3/8] eventdev: introduce event vector Tx capability

2021-03-23 Thread pbhagavatula
From: Pavan Nikhilesh Introduce event vector transmit capability for event eth tx adapter. The capability indicates that the Tx adapter is capable of transmitting event vectors. When rte_event_vector::union_valid is set, the Tx adapter should transmit all the packets to the rte_event_vector::por

[dpdk-dev] [PATCH v5 2/8] eventdev: introduce event vector Rx capability

2021-03-23 Thread pbhagavatula
From: Pavan Nikhilesh Introduce event ethernet Rx adapter event vector capability. If an event eth Rx adapter has the capability of RTE_EVENT_ETH_RX_ADAPTER_CAP_EVENT_VECTOR then a given Rx queue can be configured to enable event vectorization by passing the flag RTE_EVENT_ETH_RX_ADAPTER_QUEUE_E

[dpdk-dev] [PATCH v5 1/8] eventdev: introduce event vector capability

2021-03-23 Thread pbhagavatula
From: Pavan Nikhilesh Introduce rte_event_vector datastructure which is capable of holding multiple uintptr_t of the same flow thereby allowing applications to vectorize their pipeline and reducing the complexity of pipelining the events across multiple stages. This approach also reduces the sche

[dpdk-dev] [PATCH v5 0/8] Introduce event vectorization

2021-03-23 Thread pbhagavatula
From: Pavan Nikhilesh In traditional event programming model, events are identified by a flow-id and a uintptr_t. The flow-id uniquely identifies a given event and determines the order of scheduling based on schedule type, the uintptr_t holds a single object. Event devices also support burst mod

Re: [dpdk-dev] [PATCH v2] ethdev: introduce enable_driver_sdk to install driver headers

2021-03-23 Thread Tyler Retzlaff
On Tue, Mar 23, 2021 at 05:04:08PM +, Ferruh Yigit wrote: > >diff --git a/lib/librte_ethdev/meson.build b/lib/librte_ethdev/meson.build > >index c37b2e377..4353fa6b7 100644 > >--- a/lib/librte_ethdev/meson.build > >+++ b/lib/librte_ethdev/meson.build > >@@ -20,8 +20,14 @@ headers = files('rte_e

[dpdk-dev] [PATCH] eal: standard c++ forbids defining the keyword asm as a macro

2021-03-23 Thread Tyler Retzlaff
From: Tyler Retzlaff Signed-off-by: Tyler Retzlaff --- lib/librte_eal/include/rte_common.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/librte_eal/include/rte_common.h b/lib/librte_eal/include/rte_common.h index 1b630baf1..d5a32c66a 100644 --- a/lib/librte_eal/include/rte_common.h

Re: [dpdk-dev] [RFC] ethdev: introduce conntrack flow action and item

2021-03-23 Thread Ajit Khaparde
On Thu, Mar 18, 2021 at 12:30 AM Bing Zhao wrote: > > This commit introduced the conntrack action and item. > > Usually the HW offloading is stateless. For some stateful offloading > like a TCP connection, HW module will help provide the ability of a > full offloading w/o SW participation after th

[dpdk-dev] [PATCH] doc: update release notes for txgbe

2021-03-23 Thread Jiawen Wu
Declare updates related to device args for backplane NICs. Signed-off-by: Jiawen Wu --- doc/guides/rel_notes/release_21_05.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/guides/rel_notes/release_21_05.rst b/doc/guides/rel_notes/release_21_05.rst index 8e686cc62..732d9743c 100644 --

Re: [dpdk-dev] DEV Ask For Help about patch sumbit

2021-03-23 Thread caowenbo
Hi Ferruh Thanks for you kindly respond, it's mush helpful. I will follow the document to do the next. ๐Ÿ˜Š Regards wenbo. -Original Message- From: Ferruh Yigit Sent: 2021ๅนด3ๆœˆ22ๆ—ฅ 18:26 To: caowe...@mucse.com Cc: dev@dpdk.org; Andrew Rybchenko ; David Marchand ; Thomas Monjalon Subject: Re

Re: [dpdk-dev] [PATCH 1/3] app/testpmd: fix forwarding configuration when DCB test

2021-03-23 Thread Li, Xiaoyun
> -Original Message- > From: oulijun > Sent: Tuesday, March 23, 2021 22:19 > To: Li, Xiaoyun ; Yigit, Ferruh > Cc: dev@dpdk.org; linux...@openeuler.org > Subject: Re: [PATCH 1/3] app/testpmd: fix forwarding configuration when DCB > test > > >> @@ -2707,14 +2707,16 @@ stop_port(portid

Re: [dpdk-dev] [PATCH v2 0/7] txgbe backplane AN training

2021-03-23 Thread Jiawen Wu
On March 24, 2021 1:33 AM, Ferruh Yigit wrote: > On 3/16/2021 10:51 AM, Jiawen Wu wrote: > > This series update link process for backplane NICs. > > And support to control AN training. > > > > v2: > > - Convert compile time flags to runtime options > > - Move firmware version get operation to base

Re: [dpdk-dev] [PATCH 1/3] app/testpmd: fix forwarding configuration when DCB test

2021-03-23 Thread Li, Xiaoyun
> -Original Message- > From: oulijun > Sent: Tuesday, March 23, 2021 22:18 > To: Li, Xiaoyun ; Yigit, Ferruh > Cc: dev@dpdk.org; linux...@openeuler.org > Subject: Re: [PATCH 1/3] app/testpmd: fix forwarding configuration when DCB > test > > > > ๅœจ 2021/3/23 16:55, Li, Xiaoyun ๅ†™้“: > >

Re: [dpdk-dev] [PATCH 2/3] app/testpmd: remove forwarding config from parsing Rx and Tx

2021-03-23 Thread Li, Xiaoyun
> -Original Message- > From: oulijun > Sent: Wednesday, March 24, 2021 09:01 > To: Li, Xiaoyun ; Yigit, Ferruh > Cc: dev@dpdk.org; linux...@openeuler.org > Subject: Re: [PATCH 2/3] app/testpmd: remove forwarding config from parsing > Rx and Tx > > > > ๅœจ 2021/3/23 15:50, Li, Xiaoyun

Re: [dpdk-dev] [PATCH 2/3] app/testpmd: remove forwarding config from parsing Rx and Tx

2021-03-23 Thread oulijun
ๅœจ 2021/3/23 15:50, Li, Xiaoyun ๅ†™้“: Hi -Original Message- From: Lijun Ou Sent: Friday, March 5, 2021 18:22 To: Yigit, Ferruh Cc: Li, Xiaoyun ; dev@dpdk.org; linux...@openeuler.org Subject: [PATCH 2/3] app/testpmd: remove forwarding config from parsing Rx and Tx From: Huisong Li

[dpdk-dev] [PATCH v3 3/3] net/pcap: build on Windows

2021-03-23 Thread Dmitry Kozlyuk
Implement OS-dependent functions and enable build for Windows. Account for different library name in Windows libpcap distributions. Signed-off-by: Dmitry Kozlyuk --- config/meson.build | 3 +- doc/guides/rel_notes/release_21_05.rst | 4 + drivers/net/pcap/meson.build

[dpdk-dev] [PATCH v3 2/3] net/pcap: move OS-dependent code to separate files

2021-03-23 Thread Dmitry Kozlyuk
PCAP PMD queries interface information differently for Linux and FreeBSD, OS-specific code is guarded by #ifdef. This PMD also depends on POSIX bits, namely gettimeofday() and NAME_MAX. Move OS-dependent code to separate files. Replace POSIX bits with DPDK equivalents. Rename rte_eth_pcap.c to pca

[dpdk-dev] [PATCH v3 1/3] eal/windows: add timespec_get shim for MinGW

2021-03-23 Thread Dmitry Kozlyuk
MinGW-w64 does not currently implement C11 timespec_get. Add an internal shim until this is fixed on MinGW side. Signed-off-by: Dmitry Kozlyuk --- .../windows/include/rte_os_internal.h | 32 +++ 1 file changed, 32 insertions(+) diff --git a/lib/librte_eal/windows/include

[dpdk-dev] [PATCH v3 0/3] net/pcap: build on Windows

2021-03-23 Thread Dmitry Kozlyuk
NOTE: dependency patches are requirements, CI may fail. Most modern and actively maintained distribution of libpcap for Windows is Npcap [1]. It currently doesn't provide a pkg-config file [2]. By default it is installed to C:\Program Files\Npcap and can be located using standard environment varia

Re: [dpdk-dev] How about add rte flow get capablity APIs

2021-03-23 Thread fengchengwen
On 2021/3/23 18:27, Ferruh Yigit wrote: > On 3/23/2021 12:52 AM, Fengchengwen wrote: >> Hi, Ori and Ferruh >> >> ย ย  Currently, the rte flow APIs lack of get capability APIs, >> upper-application >> >> could not get the device capability unless look doc or code or even test it. >> >> ย ย  Maybe it

Re: [dpdk-dev] [PATCH] doc: update ice matching list

2021-03-23 Thread Zhang, Qi Z
> -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, March 24, 2021 12:55 AM > To: Zhang, Qi Z ; Yang, Qiming > > Cc: dev@dpdk.org; sta...@dpdk.org; Luca Boccassi ; > Christian Ehrhardt > Subject: Re: [PATCH] doc: update ice matching list > > On 3/8/2021 4:34 AM, Qi Zhang wro

Re: [dpdk-dev] [PATCH 2/3] drivers: fix log level after loading

2021-03-23 Thread Ajit Khaparde
On Wed, Mar 10, 2021 at 6:01 AM Thomas Monjalon wrote: > > When compiled as a shared object, and loaded at runtime as a plugin, > the drivers should get the log level set earlier at EAL init > by the user through --log-level option. > > The function for applying the log level setting is > rte_log_

Re: [dpdk-dev] [PATCH v2 2/3] meson: use threads dependency as provided by meson

2021-03-23 Thread Nick Connolly
Agreed. In my tests it's "-pthread", not "-lpthread", but still. Agreed - I must have been distracted by the array of -l: arguments :-) It's more like, in lib/librte_telemetry/meson.build: if not is_windows ext_deps += threads_dep endif It's not a big deal, b

Re: [dpdk-dev] [PATCH] ppc64le: fix build with Clang and without glibc

2021-03-23 Thread Piotr Kubaj
Thank you for your input. I did not have Linux installed on my box previously and assumed __GLIBC__ is always defined when glibc i used. I just tested that this patch works on both Linux (Fedora 33) and FreeBSD (13.0-RC3 powerpc64le). On 21-03-15 12:48:19, David Christensen wrote: > > > On 3/1

Re: [dpdk-dev] [PATCH] ppc64le: fix build with Clang and without glibc

2021-03-23 Thread Piotr Kubaj
Looks like I forgot to commit the change that includes headers for sysctlbyname(). Patch attached. On 21-03-15 12:48:19, David Christensen wrote: > > > On 3/11/21 8:11 AM, Piotr Kubaj wrote: > > There are couple of issues when building with Clang: > > 1. vector is a keyword and should not be u

[dpdk-dev] Moving some of the DPDK.org resources

2021-03-23 Thread Ali Alnubani
Hi, This is to inform you that on Sunday, March 28th, we will be moving some of the DPDK.org resources to a new server. This includes the git repositories, and the following sites: - archive.dpdk.org - browse.dpdk.org - git.dpdk.org - cgit.dpdk.org - core.dpdk.org - doc.dpdk.org - old.dpdk.org -

Re: [dpdk-dev] [PATCH 2/2] [RFC]: ethdev: manage meter API object handles by the drivers

2021-03-23 Thread Dumitrescu, Cristian
Hi Li and Matan, > -Original Message- > From: Li Zhang > Sent: Thursday, March 18, 2021 8:58 AM > To: dek...@nvidia.com; or...@nvidia.com; viachesl...@nvidia.com; > ma...@nvidia.com; shah...@nvidia.com; lir...@marvell.com; Singh, > Jasvinder ; Thomas Monjalon > ; Yigit, Ferruh ; Andrew >

Re: [dpdk-dev] [PATCH v2 2/3] meson: use threads dependency as provided by meson

2021-03-23 Thread Dmitry Kozlyuk
2021-03-23 13:35 (UTC+), Nick Connolly: [...] > 2. Adding -lpthread to libdpdk.pc is more problematic. The application > is almost > certain to be using a threads library. If this is a 3rd party > library, then the link > command will potentially include two libraries defining

Re: [dpdk-dev] [PATCH v5 1/8] ether: refine debug build option

2021-03-23 Thread Thomas Monjalon
23/03/2021 12:07, Qi Zhang: > PMDs use RTE_LIBRTE__DEBUG_RX|TX as build option to wrap > data path debug code. As .config has been removed since the meson build, > It is not friendly for new DPDK users to notice those debug options. > > The patch introduces below build options for data path debug,

Re: [dpdk-dev] [PATCH 1/2] [RFC]: ethdev: add pre-defined meter policy API

2021-03-23 Thread Dumitrescu, Cristian
Hi Li and Matan, Thank you for your proposal, some comments below. I am also adding Jerin and Hemant to this thread, as they also participated in the definition of the rte_mtr API in 2017. Also Ajit expressed some interest in a previous email. > -Original Message- > From: Li Zhang > S

Re: [dpdk-dev] [RFC 0/4] SocketPair Broker support for vhost and virtio-user.

2021-03-23 Thread Billy McFall
On Tue, Mar 23, 2021 at 3:52 PM Ilya Maximets wrote: > On 3/23/21 6:57 PM, Adrian Moreno wrote: > > > > > > On 3/19/21 6:21 PM, Stefan Hajnoczi wrote: > >> On Fri, Mar 19, 2021 at 04:29:21PM +0100, Ilya Maximets wrote: > >>> On 3/19/21 3:05 PM, Stefan Hajnoczi wrote: > On Thu, Mar 18, 2021 a

Re: [dpdk-dev] [PATCH] port: add file descriptor SWX port

2021-03-23 Thread Thomas Monjalon
23/03/2021 19:56, Dumitrescu, Cristian: > From: Thomas Monjalon > > 23/03/2021 19:07, P, Venkata Suresh Kumar: > > > Thanks a lot for reviewing the code and providing your comments. > > > > > > I have addressed below comments in V2 patch. > > > > OK thanks. > > > > What about the question about

Re: [dpdk-dev] [PATCH] crypto/octeontx2: remove redundant code

2021-03-23 Thread Akhil Goyal
> Subject: [PATCH] crypto/octeontx2: remove redundant code > > Removing redundant field in a union. > > Signed-off-by: Tejasree Kondoj > --- Applied to dpdk-next-crypto Thanks.

Re: [dpdk-dev] [PATCH 2/2] test/crypto: support block cipher DIGEST_ENCRYPTED mode

2021-03-23 Thread Akhil Goyal
> @@ -2565,6 +3052,108 @@ static const struct blockcipher_test_case > aes_chain_test_cases[] = { > .op_mask = BLOCKCIPHER_TEST_OP_AUTH_VERIFY_DEC, > .feature_mask = BLOCKCIPHER_TEST_FEATURE_SESSIONLESS, > }, > + { > + .test_descr = "AES-128-CBC HMAC

Re: [dpdk-dev] [PATCH v2 1/2] test/crypto: close PMD after tests

2021-03-23 Thread Akhil Goyal
> This patch adds closing of the PMD after running the tests. > > Signed-off-by: Adam Dybkowski > --- > app/test/test_cryptodev.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c > index f91debc16..ea965a64a 1006

Re: [dpdk-dev] [PATCH] doc: fix dpdk-graph-crypto-perf dependencies

2021-03-23 Thread Akhil Goyal
> The script dependencies list was incomplete, > this patch adds missing modules and removes an unnecessary entry. > The installation command was also added. > > Fixes: f400e0b82bf1 ("app/crypto-perf: add script to graph perf results") > > Signed-off-by: Ciara Power Cc: sta...@dpdk.org Acked-b

Re: [dpdk-dev] [PATCH v3] port: add file descriptor SWX port

2021-03-23 Thread P, Venkata Suresh Kumar
Self NACK, as V2" was just applied. No significant changes. Thanks & Regards, Suresh. -Original Message- From: P, Venkata Suresh Kumar Sent: Wednesday, March 24, 2021 12:34 AM To: dev@dpdk.org Cc: Dumitrescu, Cristian ; P, Venkata Suresh Kumar ; Khangar, Churchill ; Jangra, Yogesh Su

Re: [dpdk-dev] [PATCH] crypto/octeontx: fix session-less mode

2021-03-23 Thread Akhil Goyal
> Subject: [PATCH] crypto/octeontx: fix session-less mode > > A temporary session is created for sessionless crypto operations. > rte_cryptodev_sym_session_create() should be used for creating the > temporary session as it initializes the session structure in the > correct way. > > Fixes: caeba50

[dpdk-dev] [PATCH v3] port: add file descriptor SWX port

2021-03-23 Thread Venkata Suresh Kumar P
Add the file descriptor input/output port type for the SWX pipeline. File descriptor port type provides interface with the kernel network stack. Example file descriptor port is TAP device. Signed-off-by: Venkata Suresh Kumar P Signed-off-by: Churchill Khangar Acked-by: Cristian Dumitrescu ---

Re: [dpdk-dev] [PATCH] port: add file descriptor SWX port

2021-03-23 Thread Dumitrescu, Cristian
> -Original Message- > From: Thomas Monjalon > Sent: Tuesday, March 23, 2021 6:39 PM > To: P, Venkata Suresh Kumar ; > Dumitrescu, Cristian > Cc: dev@dpdk.org; Khangar, Churchill ; Jangra, > Yogesh > Subject: Re: [dpdk-dev] [PATCH] port: add file descriptor SWX port > > 23/03/2021 19

Re: [dpdk-dev] [PATCH v2] port: add file descriptor SWX port

2021-03-23 Thread Thomas Monjalon
23/03/2021 19:05, Venkata Suresh Kumar P: > Add the file descriptor input/output port type for the SWX pipeline. > File descriptor port type provides interface with the kernel network > stack. Example file descriptor port is TAP device. > > Signed-off-by: Venkata Suresh Kumar P > Signed-off-by: C

[dpdk-dev] [PATCH 4/5] net/mlx5: allow group 0 modify field action

2021-03-23 Thread Alexander Kozyrev
There is a limitation about copying one header field to another for the Flow group 0. Such copy action is not allowed there. But setting a header field with an immediate value is perfrectly fine. Allow the MODIFY_FIELD RTE action on group 0 in case the source field is an immediate value or a pointe

[dpdk-dev] [PATCH 2/5] net/mlx5: adjust modify field action endianess

2021-03-23 Thread Alexander Kozyrev
Masks that used to modify a packet field must be in a big endian format. Convert then to BE to ensure proper modification. Fixes: 641dbe4fb0 ("net/mlx5: support modify field flow action") Cc: sta...@dpdk.org Signed-off-by: Alexander Kozyrev --- drivers/net/mlx5/mlx5_flow_dv.c | 241

[dpdk-dev] [PATCH 0/5] modify field action enhancements

2021-03-23 Thread Alexander Kozyrev
Various fixes/improvements for RTE MODIFY_FIELD Flow Action. Alexander Kozyrev (5): net/mlx5: check for a field size in modify field action net/mlx5: adjust modify field action endianess net/mlx5: check extended metadata for mark modififcation net/mlx5: allow group 0 modify field action

[dpdk-dev] [PATCH 3/5] net/mlx5: check extended metadata for mark modififcation

2021-03-23 Thread Alexander Kozyrev
The MODIFY_FIELD RTE action requires the extended metadata support in order to manipulate on MARK register. Check if it is supported and reject the MODIFY_FIELD action if it is not. Fixes: 641dbe4fb0 ("net/mlx5: support modify field flow action") Cc: sta...@dpdk.org Signed-off-by: Alexander Kozyr

[dpdk-dev] [PATCH 1/5] net/mlx5: check for a field size in modify field action

2021-03-23 Thread Alexander Kozyrev
Add a validation check to make sure that the specified width for MODIFY_FIELD RTE action is not bigger than a field size. Fixes: 641dbe4fb0 ("net/mlx5: support modify field flow action") Cc: sta...@dpdk.org Signed-off-by: Alexander Kozyrev --- drivers/net/mlx5/mlx5_flow_dv.c | 19 ++

[dpdk-dev] [PATCH 5/5] doc: add list of supported Field IDs to modify

2021-03-23 Thread Alexander Kozyrev
Include the rte_flow_field_id enumeration into the documentation to provide the full list of all supported Field IDs availabe for the MODIFY_FIELD RTE action. Signed-off-by: Alexander Kozyrev --- doc/guides/prog_guide/rte_flow.rst | 45 -- 1 file changed, 43 insertion

Re: [dpdk-dev] 19.11.4 patches review and test

2021-03-23 Thread Ilya Maximets
On 3/23/21 7:17 PM, Thomas Monjalon wrote: > 22/03/2021 15:27, Christian Ehrhardt: >> On Mon, Mar 22, 2021 at 1:25 PM Thomas Monjalon wrote: >>> 22/03/2021 12:59, Luca Boccassi: On Mon, 2021-03-22 at 11:41 +, Bruce Richardson wrote: > On Mon, Mar 22, 2021 at 10:49:54AM +0100, Christia

Re: [dpdk-dev] [PATCH v1] bbdev: adding explicit enum for code block mode

2021-03-23 Thread Akhil Goyal
Hi Nicolas, > Hi Akhil, > Any chance to review this one to be applied? > Thanks > Applied to dpdk-next-crypto Thanks Please note that my email Id has changed.

Re: [dpdk-dev] [PATCH v3 5/5] table: add wildcard match table type

2021-03-23 Thread Thomas Monjalon
16/02/2021 21:46, Cristian Dumitrescu: > Add the widlcard match/ACL table type for the SWX pipeline, which is > used under the hood by the table instruction. > > Signed-off-by: Cristian Dumitrescu > Signed-off-by: Churchill Khangar Series applied, thanks.

Re: [dpdk-dev] [PATCH v4 0/8] Introduce event vectorization

2021-03-23 Thread Jerin Jacob
On Sat, Mar 20, 2021 at 2:27 AM wrote: > > From: Pavan Nikhilesh > > In traditional event programming model, events are identified by a > flow-id and a uintptr_t. The flow-id uniquely identifies a given event > and determines the order of scheduling based on schedule type, the > uintptr_t holds a

Re: [dpdk-dev] [PATCH 1/3] log: choose EAL log type on registration failure

2021-03-23 Thread Thomas Monjalon
23/03/2021 19:22, David Marchand: > On Wed, Mar 10, 2021 at 3:01 PM Thomas Monjalon wrote: > > > > In the unlikely case where something goes wrong > > while registering a log type, > > the fallback is to use the log type 0, assigned to EAL. > > > > Signed-off-by: Thomas Monjalon [...] > > {

Re: [dpdk-dev] [PATCH v4 07/11] eal: add log level help

2021-03-23 Thread Thomas Monjalon
23/03/2021 19:18, David Marchand: > On Tue, Mar 23, 2021 at 4:10 PM Thomas Monjalon wrote: > > 23/03/2021 14:37, David Marchand: > > > On Sun, Mar 21, 2021 at 11:32 PM Thomas Monjalon > > > wrote: > > > > > > > > The option --log-level was not completely described in the usage text, > > > > and

Re: [dpdk-dev] [PATCH v4 6/8] app/eventdev: add event vector mode in pipeline test

2021-03-23 Thread Jerin Jacob
On Sat, Mar 20, 2021 at 2:28 AM wrote: > > From: Pavan Nikhilesh > > Add event vector support in pipeline tests. By default this mode > is disabled, it can be enabled by using the option --enable_vector. > example: > dpdk-test-eventdev -l 7-23 -s 0xff00 -- --prod_type_ethdev > --n

Re: [dpdk-dev] [PATCH] port: add file descriptor SWX port

2021-03-23 Thread Thomas Monjalon
23/03/2021 19:07, P, Venkata Suresh Kumar: > Thanks a lot for reviewing the code and providing your comments. > > I have addressed below comments in V2 patch. OK thanks. What about the question about rte_trace? Opinions? > From: Thomas Monjalon > 19/03/2021 13:02, Venkata Suresh Kumar P: >

Re: [dpdk-dev] [PATCH v4 4/8] eventdev: add Rx adapter event vector support

2021-03-23 Thread Jerin Jacob
On Sat, Mar 20, 2021 at 2:28 AM wrote: > > From: Pavan Nikhilesh > > Add event vector support for event eth Rx adapter, the implementation > creates vector flows based on port and queue identifier of the received > mbufs. > > Signed-off-by: Pavan Nikhilesh > --- @jayatheethan, Let me know if y

Re: [dpdk-dev] [PATCH] port: add file descriptor SWX port

2021-03-23 Thread Stephen Hemminger
On Fri, 19 Mar 2021 08:02:06 -0400 Venkata Suresh Kumar P wrote: > +/* > + * FD Reader > + */ > +struct reader { > + struct { > + int fd; > + uint32_t mtu; > + uint32_t burst_size; > + struct rte_mempool *mempool; > + } params; > + > + s

Re: [dpdk-dev] [RFC 0/4] SocketPair Broker support for vhost and virtio-user.

2021-03-23 Thread Ilya Maximets
On 3/23/21 6:57 PM, Adrian Moreno wrote: > > > On 3/19/21 6:21 PM, Stefan Hajnoczi wrote: >> On Fri, Mar 19, 2021 at 04:29:21PM +0100, Ilya Maximets wrote: >>> On 3/19/21 3:05 PM, Stefan Hajnoczi wrote: On Thu, Mar 18, 2021 at 08:47:12PM +0100, Ilya Maximets wrote: > On 3/18/21 6:52 PM,

Re: [dpdk-dev] [dpdk-stable] [PATCH 2/3] drivers: fix log level after loading

2021-03-23 Thread David Marchand
On Wed, Mar 10, 2021 at 3:01 PM Thomas Monjalon wrote: > > When compiled as a shared object, and loaded at runtime as a plugin, > the drivers should get the log level set earlier at EAL init > by the user through --log-level option. > > The function for applying the log level setting is > rte_log_

Re: [dpdk-dev] [PATCH] port: add file descriptor SWX port

2021-03-23 Thread Stephen Hemminger
On Fri, 19 Mar 2021 08:02:06 -0400 Venkata Suresh Kumar P wrote: > +static void > +__writer_flush(struct writer *p) > +{ > + struct rte_mbuf *pkt; > + void *pkt_data; > + size_t n_bytes; > + ssize_t ret; > + uint32_t i; > + > + for (i = 0; i < p->n_pkts; i++) { > +

Re: [dpdk-dev] [PATCH] port: add file descriptor SWX port

2021-03-23 Thread Stephen Hemminger
On Fri, 19 Mar 2021 08:02:06 -0400 Venkata Suresh Kumar P wrote: > +static void > +reader_stats_read(void *port, struct rte_swx_port_in_stats *stats) > +{ > + struct reader *p = port; > + > + memcpy(stats, &p->stats, sizeof(p->stats)); > +} Why not use structure assignment (which is type

Re: [dpdk-dev] [PATCH 1/3] log: choose EAL log type on registration failure

2021-03-23 Thread David Marchand
On Wed, Mar 10, 2021 at 3:01 PM Thomas Monjalon wrote: > > In the unlikely case where something goes wrong > while registering a log type, > the fallback is to use the log type 0, assigned to EAL. > > Signed-off-by: Thomas Monjalon > --- > lib/librte_eal/include/rte_log.h | 1 + > 1 file changed

Re: [dpdk-dev] [PATCH v4 07/11] eal: add log level help

2021-03-23 Thread David Marchand
On Tue, Mar 23, 2021 at 4:10 PM Thomas Monjalon wrote: > > 23/03/2021 14:37, David Marchand: > > On Sun, Mar 21, 2021 at 11:32 PM Thomas Monjalon > > wrote: > > > > > > The option --log-level was not completely described in the usage text, > > > and it was difficult to guess the names of the log

Re: [dpdk-dev] 19.11.4 patches review and test

2021-03-23 Thread Thomas Monjalon
22/03/2021 15:27, Christian Ehrhardt: > On Mon, Mar 22, 2021 at 1:25 PM Thomas Monjalon wrote: > > 22/03/2021 12:59, Luca Boccassi: > > > On Mon, 2021-03-22 at 11:41 +, Bruce Richardson wrote: > > > > On Mon, Mar 22, 2021 at 10:49:54AM +0100, Christian Ehrhardt wrote: > > > > > On Thu, Mar 18,

Re: [dpdk-dev] [PATCH] port: add file descriptor SWX port

2021-03-23 Thread P, Venkata Suresh Kumar
Thanks a lot for reviewing the code and providing your comments. I have addressed below comments in V2 patch. Thanks & Regards, Suresh. -Original Message- From: Thomas Monjalon Sent: Tuesday, March 23, 2021 9:52 PM To: P, Venkata Suresh Kumar Cc: dev@dpdk.org; Dumitrescu, Cristian ;

[dpdk-dev] [PATCH v2] port: add file descriptor SWX port

2021-03-23 Thread Venkata Suresh Kumar P
Add the file descriptor input/output port type for the SWX pipeline. File descriptor port type provides interface with the kernel network stack. Example file descriptor port is TAP device. Signed-off-by: Venkata Suresh Kumar P Signed-off-by: Churchill Khangar Acked-by: Cristian Dumitrescu ---

Re: [dpdk-dev] [RFC 0/4] SocketPair Broker support for vhost and virtio-user.

2021-03-23 Thread Adrian Moreno
On 3/19/21 6:21 PM, Stefan Hajnoczi wrote: > On Fri, Mar 19, 2021 at 04:29:21PM +0100, Ilya Maximets wrote: >> On 3/19/21 3:05 PM, Stefan Hajnoczi wrote: >>> On Thu, Mar 18, 2021 at 08:47:12PM +0100, Ilya Maximets wrote: On 3/18/21 6:52 PM, Stefan Hajnoczi wrote: > On Wed, Mar 17, 2021

Re: [dpdk-dev] [PATCH 2/3] examples/ipsec-secgw: add UDP encapsulation support

2021-03-23 Thread Akhil Goyal
> > > Hi Konstantin, > > > > > > Hi Akhil, > > > > > > Adding lookaside IPsec UDP encapsulation support > > > > > > for NAT traversal. > > > > > > Added --udp-encap option for application to specify > > > > > > if UDP encapsulation need to be enabled. > > > > > > Example secgw command with UDP enc

[dpdk-dev] Issue/Question with multi-process and CryptoDev using AESNI_MB

2021-03-23 Thread Luse, Paul E
Hi All, I'm having an issue with the following scenario with SPDK-based applications built w/DPDK using CryptoDev in a primary/secondary process setup. Primary Process: An application that does crypto and properly initializes aesni_mb Secondary Process: An application that does not use crypto s

Re: [dpdk-dev] [PATCH v3] table: fix actions with different data size

2021-03-23 Thread Thomas Monjalon
17/03/2021 12:42, Cristian Dumitrescu: > The table layer provisions an action_id and action_data_size data > bytes for each table key. This action_data_size is a maximal amount, > as some actions (depending on action_id) can require zero or less data > bytes than the maximal action_data_size. This

Re: [dpdk-dev] [PATCH v2 0/7] txgbe backplane AN training

2021-03-23 Thread Ferruh Yigit
On 3/16/2021 10:51 AM, Jiawen Wu wrote: This series update link process for backplane NICs. And support to control AN training. v2: - Convert compile time flags to runtime options - Move firmware version get operation to base code - Fix minor bugs Jiawen Wu (7): net/txgbe: update device ID

Re: [dpdk-dev] [PATCH] net/vmxnet3: build on Windows

2021-03-23 Thread Yong Wang
-Original Message- From: Ferruh Yigit Date: Tuesday, March 23, 2021 at 9:11 AM To: Dmitry Kozlyuk , "dev@dpdk.org" , Yong Wang Cc: Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam Subject: Re: [dpdk-dev] [PATCH] net/vmxnet3: build on Windows On 2/21/2021 12:55 AM, Dmitry K

Re: [dpdk-dev] [PATCH v2] ethdev: introduce enable_driver_sdk to install driver headers

2021-03-23 Thread Ferruh Yigit
On 3/12/2021 10:20 PM, Tyler Retzlaff wrote: Introduce a meson option enable_driver_sdk when true installs internal driver headers for ethdev. this allows drivers that do not depend on stable api/abi to be built external to the dpdk source tree. Signed-off-by: Tyler Retzlaff --- lib/librte_et

Re: [dpdk-dev] [PATCH v4 2/8] eventdev: introduce event vector Rx capability

2021-03-23 Thread Jerin Jacob
On Sat, Mar 20, 2021 at 2:27 AM wrote: > > From: Pavan Nikhilesh > > Introduce event ethernet Rx adapter event vector capability. > > If an event eth Rx adapter has the capability of > RTE_EVENT_ETH_RX_ADAPTER_CAP_EVENT_VECTOR then a given Rx queue > can be configured to enable event vectorizatio

Re: [dpdk-dev] [PATCH] doc: update ice matching list

2021-03-23 Thread Ferruh Yigit
On 3/8/2021 4:34 AM, Qi Zhang wrote: Updated ice recommended matching list for DPDK 21.02. and also fixed matching kernel driver version for DPDK 20.11. Fixes: e89aebf3b597 ("doc: update ice user guide") Cc: sta...@dpdk.org Signed-off-by: Qi Zhang --- doc/guides/nics/ice.rst | 12 +++

Re: [dpdk-dev] [PATCH] net/mlx5: add Rx checksum offload flag return bad

2021-03-23 Thread Slava Ovsiienko
Hi, Jiawei > -Original Message- > From: Jiawei Zhu <17826875...@163.com> > Sent: Monday, March 22, 2021 17:46 > To: dev@dpdk.org > Cc: zhujiawe...@huawei.com; Matan Azrad ; Shahaf > Shuler ; Slava Ovsiienko > Subject: [PATCH] net/mlx5: add Rx checksum offload flag return bad > > From: Ji

Re: [dpdk-dev] [PATCH] port: add file descriptor SWX port

2021-03-23 Thread Thomas Monjalon
19/03/2021 13:02, Venkata Suresh Kumar P: > Add the file descriptor input/output port type for the SWX pipeline. I think it deserves a bit more explanation about what is FD I/O port. > /* > + * tap > + */ > +#define TAP_DEV"/dev/net/tun" Spaces are fr

Re: [dpdk-dev] [PATCH] net/vmxnet3: build on Windows

2021-03-23 Thread Ferruh Yigit
On 2/21/2021 12:55 AM, Dmitry Kozlyuk wrote: Remove OS restriction and update release notes. Signed-off-by: Dmitry Kozlyuk Build looks good, but I wonder if anyone tested the driver on Windows. Yong, Do you have any plan to test the driver on Windows, should we wait your ack?

Re: [dpdk-dev] [PATCH] port: add ring SWX port

2021-03-23 Thread Thomas Monjalon
28/01/2021 19:55, Cristian Dumitrescu: > --- a/lib/librte_port/version.map > +++ b/lib/librte_port/version.map > @@ -44,4 +44,8 @@ EXPERIMENTAL { > + #added in 21.02 21.05 now > + rte_swx_port_ring_reader_ops; > + rte_swx_port_ring_writer_ops; Applied, thanks.

Re: [dpdk-dev] [PATCH v2] sched : Initialize tc ov watermark.

2021-03-23 Thread Thomas Monjalon
09/03/2021 17:10, Savinay Dharmappa: > tc ov watermark is initialized with computed value of > max tc ov watermark. Sorry I don't understand what the change is doing. Was there an issue? In the title, please avoid "tc ov" which is meaningless for most of readers I guess. > --- a/lib/librte_sched

Re: [dpdk-dev] [dpdk-stable] [PATCH 3/3] eal: fix evaluation of log level option

2021-03-23 Thread Thomas Monjalon
23/03/2021 11:19, David Marchand: > --log-level option is handled early, no need to reevaluate it later in > EAL init. > > Before: > $ echo quit | ./build/app/test/dpdk-test --no-huge -m 512 \ > --log-level=lib.eal:debug \ > --log-level=lib.ethdev:debug --log-level=lib.ethdev:info \ > |& gre

Re: [dpdk-dev] [PATCH v2 01/10] eal: add thread id and simple thread functions

2021-03-23 Thread Tyler Retzlaff
On Mon, Mar 22, 2021 at 07:54:19PM -0700, Stephen Hemminger wrote: > On Mon, 22 Mar 2021 17:20:26 -0700 > Narcisa Ana Maria Vasile wrote: > > > @@ -59,7 +92,7 @@ void rte_thread_get_affinity(rte_cpuset_t *cpusetp); > > * > > * @return > > * On success, zero. > > - * On failure, a negati

Re: [dpdk-dev] [PATCH 2/3] examples/ipsec-secgw: add UDP encapsulation support

2021-03-23 Thread Ananyev, Konstantin
> Hi Konstantin, > > > > Hi Akhil, > > > > > Adding lookaside IPsec UDP encapsulation support > > > > > for NAT traversal. > > > > > Added --udp-encap option for application to specify > > > > > if UDP encapsulation need to be enabled. > > > > > Example secgw command with UDP encapsultation enabl

Re: [dpdk-dev] [PATCH V2 1/4] config/arm: add Hisilicon kunpeng920 implementer

2021-03-23 Thread Ruifeng Wang
> -Original Message- > From: oulijun > Sent: Tuesday, March 23, 2021 9:52 PM > To: Ruifeng Wang ; tho...@monjalon.net; > ferruh.yi...@intel.com > Cc: dev@dpdk.org; linux...@openeuler.org; nd > Subject: Re: [dpdk-dev] [PATCH V2 1/4] config/arm: add Hisilicon > kunpeng920 implementer > >

Re: [dpdk-dev] [PATCH v4 07/11] eal: add log level help

2021-03-23 Thread Thomas Monjalon
23/03/2021 14:37, David Marchand: > On Sun, Mar 21, 2021 at 11:32 PM Thomas Monjalon wrote: > > > > The option --log-level was not completely described in the usage text, > > and it was difficult to guess the names of the log types and levels. > > > > A new value "help" is accepted after --log-lev

Re: [dpdk-dev] [PATCH 2/3] examples/ipsec-secgw: add UDP encapsulation support

2021-03-23 Thread Akhil Goyal
Hi Konstantin, > > Hi Akhil, > > > > Adding lookaside IPsec UDP encapsulation support > > > > for NAT traversal. > > > > Added --udp-encap option for application to specify > > > > if UDP encapsulation need to be enabled. > > > > Example secgw command with UDP encapsultation enabled: > > > > -c 0

Re: [dpdk-dev] [PATCH v5 0/8] ether: refine debug build option

2021-03-23 Thread Ferruh Yigit
On 3/23/2021 11:07 AM, Qi Zhang wrote: PMDs use RTE_LIBRTE__DEBUG_RX|TX as build option to wrap data path debug code. As .config has been removed since the meson build, It is not friendly for new DPDK users to notice those debug options. Patch 1/8: introduces new compile options for data path de

Re: [dpdk-dev] [PATCH v5 2/8] net/fm10k: refine debug build option

2021-03-23 Thread Ferruh Yigit
On 3/23/2021 11:07 AM, Qi Zhang wrote: 1. replace RTE_LIBRTE_FM10K_DEBUG_RX with RTE_ETHDEV_DEBUG_RX. 2. replace RTE_LIBRTE_FM10K_DEBUG_TX whth RTE_ETHDEV_DEBUG_TX. s/whth/with can fix while merging 3. merge RTE_LIBRTE_FM10K_DEBUG_TX_FREE and RTE_LIBRTE_ETHDEV_DEBUG into RTE_ETHDEV_DEBUG

Re: [dpdk-dev] [PATCH v5 1/8] ether: refine debug build option

2021-03-23 Thread Ferruh Yigit
On 3/23/2021 11:07 AM, Qi Zhang wrote: PMDs use RTE_LIBRTE__DEBUG_RX|TX as build option to wrap data path debug code. As .config has been removed since the meson build, It is not friendly for new DPDK users to notice those debug options. The patch introduces below build options for data path deb

Re: [dpdk-dev] [PATCH 2/3] examples/ipsec-secgw: add UDP encapsulation support

2021-03-23 Thread Ananyev, Konstantin
Hi Akhil, > Hi Konstantin, > > Hi, > > > Adding lookaside IPsec UDP encapsulation support > > > for NAT traversal. > > > Added --udp-encap option for application to specify > > > if UDP encapsulation need to be enabled. > > > Example secgw command with UDP encapsultation enabled: > > > -c 0x1

Re: [dpdk-dev] [PATCH 1/3] app/testpmd: fix forwarding configuration when DCB test

2021-03-23 Thread oulijun
ๅœจ 2021/3/23 16:55, Li, Xiaoyun ๅ†™้“: Hi -Original Message- From: Lijun Ou Sent: Friday, March 5, 2021 18:22 To: Yigit, Ferruh Cc: Li, Xiaoyun ; dev@dpdk.org; linux...@openeuler.org Subject: [PATCH 1/3] app/testpmd: fix forwarding configuration when DCB test From: Huisong Li The c

Re: [dpdk-dev] [PATCH 1/3] app/testpmd: fix forwarding configuration when DCB test

2021-03-23 Thread oulijun
ๅœจ 2021/3/23 16:55, Li, Xiaoyun ๅ†™้“: Hi -Original Message- From: Lijun Ou Sent: Friday, March 5, 2021 18:22 To: Yigit, Ferruh Cc: Li, Xiaoyun ; dev@dpdk.org; linux...@openeuler.org Subject: [PATCH 1/3] app/testpmd: fix forwarding configuration when DCB test From: Huisong Li The c

  1   2   >