Hi Nick, Dmitry,
Thanks for the reviews.
I wrote this patch following the link issue I had with libpcap thinking it
was
"more of the same" ... which clearly it wasn't.
I had a closer look to what dependency('threads') generates and I agree
that it's not that well documented. From what I understand, it will always
the '-pthread' arg in the command line arguments, and then convert the
argument to the targeted environment (which might remove it if unsupported).
For librte_metrics, I am mistaken and the added dep should be removed.
I think that you are right to suggest keeping the "if not is_windows" test.
I will set up more test environments before submitting a new patch.
Best regards,
On Tue, Mar 23, 2021 at 11:17 PM Nick Connolly <nick.conno...@mayadata.io>
wrote:
>
> > Agreed. In my tests it's "-pthread", not "-lpthread", but still.
> Agreed - I must have been distracted by the array of -l: arguments :-)
> > It's more like, in lib/librte_telemetry/meson.build:
> >
> > if not is_windows
> > ext_deps += threads_dep
> > endif
> It's not a big deal, but my thinking was that the library has a genuine
> threads dependency, but in the Windows case this is satisfied by EAL
> and so threads_dep can perhaps legitimately be empty. It also means
> there's only one place where the decision is made regardless of the
> number of dependencies.
>
> Regards,
> Nick
>
--
Gabriel Ganne
