[dpdk-dev] [PATCH v7 0/2] generic modify rte flow action support

2021-01-15 Thread Alexander Kozyrev
Implement a generic modify rte flow API as described in RFC: http://patches.dpdk.org/patch/85384/ This API allows modifying a destination header field with data from a source header field. Number of bits to use from the source is specified. Tag, Mark or Metadata can also be used as a source/destin

[dpdk-dev] [PATCH v7 2/2] app/testpmd: add support for modify field flow action

2021-01-15 Thread Alexander Kozyrev
Add support for the RTE_FLOW_ACTION_MODIFY_FIELD to the testpmd. Implement CLI to create the modify_field action and supply all the needed parameters to modify an arbitrary packet field (as well as mark, tag or metadata) with data from another field or immediate value. Example of the flow is the f

[dpdk-dev] [PATCH v7 1/2] ethdev: introduce generic modify rte flow action

2021-01-15 Thread Alexander Kozyrev
Implement the generic modify flow API to allow manipulations on an arbitrary header field (as well as mark, metadata or tag) using data from another field or a user-specified value. This generic modify mechanism removes the necessity to implement a separate RTE Flow action every time we need to mod

[dpdk-dev] [PATCH v6 0/2] generic modify rte flow action support

2021-01-15 Thread Alexander Kozyrev
Implement a generic modify rte flow API as described in RFC: http://patches.dpdk.org/patch/85384/ This API allows modifying a destination header field with data from a source header field. Number of bits to use from the source is specified. Tag, Mark or Metadata can also be used as a source/destin

[dpdk-dev] [PATCH v6 1/2] ethdev: introduce generic modify rte flow action

2021-01-15 Thread Alexander Kozyrev
Implement the generic modify flow API to allow manipulations on an arbitrary header field (as well as mark, metadata or tag) using data from another field or a user-specified value. This generic modify mechanism removes the necessity to implement a separate RTE Flow action every time we need to mod

[dpdk-dev] [PATCH v6 2/2] app/testpmd: add support for modify field flow action

2021-01-15 Thread Alexander Kozyrev
Add support for the RTE_FLOW_ACTION_MODIFY_FIELD to the testpmd. Implement CLI to create the modify_field action and supply all the needed parameters to modify an arbitrary packet field (as well as mark, tag or metadata) with data from another field or immediate value. Example of the flow is the f

Re: [dpdk-dev] [PATCH V16 1/3] ethdev: introduce FEC API

2021-01-15 Thread Min Hu (Connor)
OK, I will add the info soon. 在 2021/1/15 22:07, Ferruh Yigit 写道: On 10/8/2020 11:02 AM, Min Hu (Connor) wrote: This patch adds Forward error correction(FEC) support for ethdev. Introduce APIs which support query and config FEC information in hardware. Signed-off-by: Min Hu (Connor) Reviewed-

Re: [dpdk-dev] [PATCH] ethdev: rename FEC API parameters

2021-01-15 Thread Min Hu (Connor)
Hi, Ferruh, this change origin from the opinions by Andrew Rybchenko . snippets like this: > +__rte_experimental > +int rte_eth_fec_get(uint16_t port_id, uint32_t *mode); > + > +/** > + * @warning > + * @b EXPERIMENTAL: this API may change, or be removed, without prior notice > + * > +

Re: [dpdk-dev] [PATCH] ethdev: rename FEC API parameters

2021-01-15 Thread Ajit Khaparde
On Fri, Jan 15, 2021 at 7:52 AM Ferruh Yigit wrote: > > The FEC APIs to get/set FEC mode has parameter name as 'fec_capa', > renamed them as 'fec_mode' to be more accurate with API. > > No functional change. > > Signed-off-by: Ferruh Yigit Acked-by: Ajit Khaparde > --- > Cc: Min Hu (Connor) >

[dpdk-dev] [PATCH v2] eal/windows: explicitly cast void * to type *

2021-01-15 Thread Tyler Retzlaff
Explicitly cast void * to type * so that eal headers may be compiled as C or C++. Fixes: e8428a9d89f1 ("eal/windows: add some basic functions and macros") Cc: sta...@dpdk.org Signed-off-by: Tyler Retzlaff --- lib/librte_eal/windows/include/rte_os.h | 2 +- 1 file changed, 1 insertion(+), 1 dele

Re: [dpdk-dev] [PATCH] eal/headers: explicitly cast void * to type *

2021-01-15 Thread Tyler Retzlaff
On Thu, Jan 14, 2021 at 10:55:54AM +, Bruce Richardson wrote: > > > > This is a private header, it's never exposed---why the change is > > > > needed (not that I have a strong opinion, though)? > > > > > > interesting, i'll look into why/how it is being included and confirm. i > > > suppose

Re: [dpdk-dev] [PATCH v1 2/2] net/vmxnet3: Provided API to reset vmxnet device

2021-01-15 Thread Ferruh Yigit
On 1/4/2021 7:43 PM, Dheemanth Mallikarjun wrote: The vmxnet3 driver didn't have the dev_reset function pointer set. Hence, provided the necessary function pointer so that DPDK developers can use the rte_eth_dev_reset API to reset the vmxnet3 device data. Signed-off-by: Dheemanth Mallikarjun --

Re: [dpdk-dev] meson: wrong dependency in cross compilation on ARM

2021-01-15 Thread Ferruh Yigit
On 12/21/2020 2:04 PM, Bruce Richardson wrote: On Mon, Dec 21, 2020 at 12:19:17PM +, Hemant Agrawal wrote: Hi, I am trying to cross compile DPDK for arm64 on a ubuntu machine, which has a zlib pre-installed for native env. I am encountering following build error in net_bnx

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] mbuf: fix reset on mbuf free

2021-01-15 Thread Ali Alnubani
Hi, Adding Ferruh and Zhaoyan, > Ali, > > You reported some performance regression, did you confirm it? > If I get no reply by monday, I'll proceed with this patch. Sure I'll confirm by Monday. Doesn't the regression also reproduce on the Lab's Intel servers? Even though the check iol-intel-Per

Re: [dpdk-dev] [PATCH v5 2/2] app/testpmd: add support for modify field flow action

2021-01-15 Thread Ori Kam
> -Original Message- > From: Alexander Kozyrev > Sent: Friday, January 15, 2021 5:43 PM > Subject: [PATCH v5 2/2] app/testpmd: add support for modify field flow action > > Add support for the RTE_FLOW_ACTION_MODIFY_FIELD to the testpmd. > Implement CLI to create the modify_field action

Re: [dpdk-dev] [PATCH v5 1/2] ethdev: introduce generic modify rte flow action

2021-01-15 Thread Ori Kam
Hi Alexander, Small inline, but I leave it to you if you want to change it. > -Original Message- > From: Alexander Kozyrev > Sent: Friday, January 15, 2021 5:43 PM > Subject: [PATCH v5 1/2] ethdev: introduce generic modify rte flow action > > Implement the generic modify flow API to all

[dpdk-dev] [PATCH 2/2] net/cxgbe: avoid link FEC retraining during probe

2021-01-15 Thread Rahul Lakkireddy
If link FEC has already been saved by firmware during link training in probe, then use the saved FEC value, instead of retraining the link. If link training is still not complete in probe, then firmware will send the actual FEC later in link config change reply after training is complete. Also, th

[dpdk-dev] [PATCH 1/2] net/cxgbe: do not link down for every link config change

2021-01-15 Thread Rahul Lakkireddy
Some commands like turning local Tx/Rx pause on/off do not need link to go down. If there are issues with link config params, then the firmware will explicitly indicate link down in reply. So, don't always link down for every link config param change request. Instead, rely on actual link status com

[dpdk-dev] [PATCH 0/2] net/cxgbe: minor fixes for link related changes

2021-01-15 Thread Rahul Lakkireddy
Patch 1 fixes issue with link status always getting set to down by driver for every link config change request. This is not required for some link config changes, like Tx/Rx pause on/off. Instead, driver should rely on actual link status returned by firmware in link config change reply. Patch 2 fi

Re: [dpdk-dev] [dpdk-stable] [PATCH] common/sfc_efx/base: fix MPORT-related byte order handling

2021-01-15 Thread Ferruh Yigit
On 12/28/2020 3:00 AM, Ivan Malov wrote: MPORT values derived by helper functions are little-endian. At the same time, MCDIs which consume these values perform one more host-order to little-endian conversion internally. Fix the helper functions to return host-order MPORT values. Fixes: 370ed675

Re: [dpdk-dev] [PATCH 37/40] net/virtio: introduce backend data

2021-01-15 Thread Maxime Coquelin
On 1/13/21 6:18 PM, Adrian Moreno wrote: > > > On 12/20/20 10:14 PM, Maxime Coquelin wrote: >> The goal of this patch is to introduce backend-specific >> data in order to better isolate what is backend-specific >> from what is generic to Virtio-user. >> >> For now, only Vhost-user protocol fea

Re: [dpdk-dev] [PATCH 0/2] crypto/octeontx2: add support for cipher combinations

2021-01-15 Thread Akhil Goyal
> This series adds support for aes-cbc sha1-hmac and aes-cbc sha256-128-hmac > cipher combinations in lookaside protocol offload mode. The functionality > has been verified with ipsec-secgw application running in lookaside > protocol offload mode. > > This series should be applied after the follow

Re: [dpdk-dev] [PATCH 0/2] add lookaside IPsec ESN and anti-replay support

2021-01-15 Thread Akhil Goyal
> > > > This series adds lookaside IPsec ESN and anti-replay support to OCTEON TX2 > > crypto PMD. > > The functionality has been tested with ipsec-secgw application running in > > lookaside protocol offload mode. > > > > Tejasree Kondoj (2): > > crypto/octeontx2: make anti-replay routine generic

Re: [dpdk-dev] [PATCH v2 1/1] devtools: avoid installing static binaries

2021-01-15 Thread Thomas Monjalon
15/01/2021 16:24, David Marchand: > On Wed, Jan 13, 2021 at 11:01 PM Thomas Monjalon wrote: > > 13/01/2021 20:05, Thomas Monjalon: > > > When testing compilation and checking ABI compatibility, > > > there is no real need of static binaries eating disks. > > > > > > The static linkage of applicati

Re: [dpdk-dev] [PATCH v3] crypto/octeontx2: add CN98xx support

2021-01-15 Thread Akhil Goyal
> > CN98xx SoC comes up with two CPT blocks wrt CN96xx, CN93xx, to achieve > > higher performance. > > > > Adding support to allocate all LFs of VF with even BDF from CPT0 and all > > LFs of > > VF with odd BDF from CPT1. > > If LFs are not available in one block then they will be allocated from

Re: [dpdk-dev] [PATCH v7 1/2] cryptodev: support enqueue and dequeue callback functions

2021-01-15 Thread Akhil Goyal
> This patch adds APIs to add/remove callback functions on crypto > enqueue/dequeue burst. The callback function will be called for > each burst of crypto ops received/sent on a given crypto device > queue pair. > > Signed-off-by: Abhinandan Gujjar > Acked-by: Konstantin Ananyev > --- Series app

Re: [dpdk-dev] [PATCH] crypto/qat: fix possible access to an uninitialized variable

2021-01-15 Thread Akhil Goyal
> > > -Original Message- > > From: Medvedkin, Vladimir > > Sent: wtorek, 15 grudnia 2020 19:24 > > To: dev@dpdk.org > > Cc: Kusztal, ArkadiuszX ; Griffin, John > > ; Trahe, Fiona ; Jain, Deepak > K > > ; sta...@dpdk.org > > Subject: [PATCH] crypto/qat: fix possible access to an uninitiali

Re: [dpdk-dev] [PATCH v3] crypto/ccp: enable IOMMU for CCP

2021-01-15 Thread Akhil Goyal
> Subject: [PATCH v3] crypto/ccp: enable IOMMU for CCP > > From: Amaranath Somalapuram > > CCP use vdev framework, and vdev framework don’t support IOMMU. > Adding custom IOMMU support for AMD CCP driver. > > Signed-off-by: Amaranath Somalapuram > --- Applied to dpdk-next-crypto Thanks.

Re: [dpdk-dev] [PATCH v2 1/5] crypto/dpaa2_sec: support AES-XCBC-MAC

2021-01-15 Thread Akhil Goyal
> From: Akhil Goyal > > This patch add support for AES-XCBC-MAC for following cases > - AES-XCBC-MAC auth only > - AES-CBC/CTR + AES-XCBC-MAC (non-proto) > - AES-CBC/CTR + AES-XCBC-MAC (protocol offload) > - DES-CBC + AES-XCBC-MAC (non-proto) > - 3DES-CBC + AES-XCBC-MAC (non-proto) > > Signed-

Re: [dpdk-dev] [PATCH v1] eal/arm: fix gcc build for 128-bit atomic compare exchange

2021-01-15 Thread David Marchand
On Fri, Jan 15, 2021 at 10:58 AM Joyce Kong wrote: > > Compiling with "meson build -Dbuildtype=debug --cross-file > config/arm/arm64_thunderx2_linux_gcc" shows the warnings > "function returns an aggregate [-Waggregate-return]": > ../../dpdk/lib/librte_eal/arm/include/rte_atomic_64.h: In > functio

Re: [dpdk-dev] [PATCH v2 0/4] add crypto perf test graphing script

2021-01-15 Thread Akhil Goyal
> On 14/01/2021 10:41 AM, Ciara Power wrote: > > This patchset introduces a python script to run various crypto performance > > test cases, and graph the results in a consumable manner. The test suites > > are configured via JSON file. Some config files are provided, > > or the user may create one.

[dpdk-dev] [PATCH] ethdev: rename FEC API parameters

2021-01-15 Thread Ferruh Yigit
The FEC APIs to get/set FEC mode has parameter name as 'fec_capa', renamed them as 'fec_mode' to be more accurate with API. No functional change. Signed-off-by: Ferruh Yigit --- Cc: Min Hu (Connor) Cc: Wei Hu (Xavier) Cc: Chengwen Feng Cc: Chengchang Tang Cc: Andrew Rybchenko Cc: Ajit Khapa

Re: [dpdk-dev] [PATCH] ethdev: refine API description

2021-01-15 Thread Thomas Monjalon
Hi, It seems we need to clarify how the API for UDP tunnel works with rte_flow. Thanks for starting this patch. I ask some questions below for writing a clear and exact API definition. 12/01/2021 12:47, Qi Zhang: > Refine the description for rte_eth_dev_udp_tunnel_port_add. > Claim this is an API

[dpdk-dev] [PATCH v5 2/2] app/testpmd: add support for modify field flow action

2021-01-15 Thread Alexander Kozyrev
Add support for the RTE_FLOW_ACTION_MODIFY_FIELD to the testpmd. Implement CLI to create the modify_field action and supply all the needed parameters to modify an arbitrary packet field (as well as mark, tag or metadata) with data from another field or immediate value. Example of the flow is the f

[dpdk-dev] [PATCH v5 1/2] ethdev: introduce generic modify rte flow action

2021-01-15 Thread Alexander Kozyrev
Implement the generic modify flow API to allow manipulations on an arbitrary header field (as well as mark, metadata or tag) using data from another field or a user-specified value. This generic modify mechanism removes the necessity to implement a separate RTE Flow action every time we need to mo

[dpdk-dev] [PATCH v5 0/2] generic modify rte flow action support

2021-01-15 Thread Alexander Kozyrev
Implement a generic modify rte flow API as described in RFC: http://patches.dpdk.org/patch/85384/ This API allows modifying a destination header field with data from a source header field. Number of bits to use from source is specified. Tag, mark or metadata can also be used as a source/destinatio

Re: [dpdk-dev] [PATCH v2 05/19] mbuf: fix missing header include

2021-01-15 Thread Andrew Rybchenko
On 1/15/21 2:10 PM, Bruce Richardson wrote: The rte_mbuf_dyn.h header file uses a number of types and macros without including the required header files to get the definitions of those macros/types. Similarly, the rte_mbuf_core.h file was missing an include for rte_byteorder.h header. Fixes: 49

Re: [dpdk-dev] [PATCH v2 03/19] ethdev: fix missing header include

2021-01-15 Thread Andrew Rybchenko
On 1/15/21 2:10 PM, Bruce Richardson wrote: The define for RTE_ETH_FLOW_MAX is defined in rte_ethdev.h, so that header should be included in rte_eth_ctrl.h to allow it to be compiled independently. Fixes: 7fa96d696f2c ("ethdev: unification of flow types") Cc: sta...@dpdk.org Signed-off-by: Bruc

Re: [dpdk-dev] [PATCH v4 2/2] app/testpmd: add support for generic copy rte flow action

2021-01-15 Thread Alexander Kozyrev
> From: Ori Kam on Thursday, January 14, 2021 10:19 > Subject: RE: [PATCH v4 2/2] app/testpmd: add support for generic copy rte > flow action > > Hi > > > -Original Message- > > From: Alexander Kozyrev > > Sent: Wednesday, January 13, 2021 7:08 PM > > Subject: [PATCH v4 2/2] app/testpmd

Re: [dpdk-dev] [PATCH 3/3] net/fm10k: remove vector config

2021-01-15 Thread Ferruh Yigit
On 1/15/2021 1:40 PM, David Marchand wrote: This config item is not exposed anymore now that we removed make support. Signed-off-by: David Marchand Reviewed-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH 2/3] net/i40e: remove vector config

2021-01-15 Thread Ferruh Yigit
On 1/15/2021 1:40 PM, David Marchand wrote: This config item is not exposed anymore now that we removed make support. Note: all architectures provide vectorised functions. Signed-off-by: David Marchand Reviewed-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH] ethdev: introduce generic copy rte flow action

2021-01-15 Thread Alexander Kozyrev
> From: Jerin Jacob on Friday, January 15, 2021 9:01 > Subject: Re: [dpdk-dev] [PATCH] ethdev: introduce generic copy rte flow > action > > On Thu, Jan 14, 2021 at 8:32 PM Ori Kam wrote: > > > > Hi Jerin, > > > > > -Original Message- > > > From: Jerin Jacob > > > Sent: Thursday, Januar

Re: [dpdk-dev] [PATCH] test/mcslock: remove unneeded per-lcore copy

2021-01-15 Thread David Marchand
On Wed, Nov 4, 2020 at 6:05 PM Olivier Matz wrote: > > Each core already comes with its local storage for mcslock (in its > stack), therefore there is no need to define an additional per-lcore > mcslock. > > Fixes: 32dcb9fd2a22 ("test/mcslock: add MCS queued lock unit test") > > Signed-off-by: Oli

Re: [dpdk-dev] [PATCH v3] app/testpmd: increase array for fetching supported FEC caps

2021-01-15 Thread Ferruh Yigit
On 12/25/2020 1:06 AM, Min Hu (Connor) wrote: 在 2020/12/24 19:18, Rahul Lakkireddy 写道: From: Karra Satwik Request the driver for number of entries in the FEC caps array and then dynamically allocate the array. Signed-off-by: Karra Satwik Signed-off-by: Rahul Lakkireddy Acked-by: Xiaoyun Li

Re: [dpdk-dev] [PATCH v2 1/1] devtools: avoid installing static binaries

2021-01-15 Thread David Marchand
On Wed, Jan 13, 2021 at 11:01 PM Thomas Monjalon wrote: > > 13/01/2021 20:05, Thomas Monjalon: > > When testing compilation and checking ABI compatibility, > > there is no real need of static binaries eating disks. > > > > The static linkage of applications was already well tested, > > though the

Re: [dpdk-dev] [dpdk-dev v2 1/2] ethdev: add new tunnel type for ecpri

2021-01-15 Thread Thomas Monjalon
12/01/2021 03:14, Zhang, Qi Z: > From: Thomas Monjalon > > 11/01/2021 15:02, Zhang, Qi Z: > > > From: Thomas Monjalon > > > > 11/01/2021 12:26, Zhang, Qi Z: > > > > > From: Thomas Monjalon > > > > > > 10/01/2021 11:46, Ori Kam: > > > > > > > From: Zhang, Qi Z > > > > > > > > From: Thomas Monjal

Re: [dpdk-dev] [PATCH 0/3] net/cxgbe: rework link config and add FEC support

2021-01-15 Thread Ferruh Yigit
On 12/20/2020 10:47 PM, Rahul Lakkireddy wrote: This series of patches rework link handling and add support to configure Forward Error Correction (FEC) capability. Patch 1 removes legacy 16-bit link capabilities infrastructure and always enables 32-bit link capabilities in firmware. Patch 2 sim

Re: [dpdk-dev] [PATCH v2 16/19] app/chkincs: add chkincs app to verify headers

2021-01-15 Thread Bruce Richardson
On Fri, Jan 15, 2021 at 02:55:41PM +, Bruce Richardson wrote: > On Fri, Jan 15, 2021 at 03:09:25PM +0100, Thomas Monjalon wrote: > > 15/01/2021 12:59, Bruce Richardson: > > > On Fri, Jan 15, 2021 at 11:51:49AM +, Ferruh Yigit wrote: > > > > On 1/15/2021 11:10 AM, Bruce Richardson wrote: > >

Re: [dpdk-dev] [PATCH v2 16/19] app/chkincs: add chkincs app to verify headers

2021-01-15 Thread Bruce Richardson
On Fri, Jan 15, 2021 at 03:09:25PM +0100, Thomas Monjalon wrote: > 15/01/2021 12:59, Bruce Richardson: > > On Fri, Jan 15, 2021 at 11:51:49AM +, Ferruh Yigit wrote: > > > On 1/15/2021 11:10 AM, Bruce Richardson wrote: > > > > To verify that all DPDK headers are ok for inclusion directly in a C

Re: [dpdk-dev] [PATCH 25/40] net/virtio: add Virtio-user features ops

2021-01-15 Thread Maxime Coquelin
On 1/13/21 2:57 PM, Adrian Moreno wrote: > > > On 12/20/20 10:13 PM, Maxime Coquelin wrote: >> This patch introduce new callbacks for getting >> and setting Virtio features, and implements them >> for the different backend types. >> >> Signed-off-by: Maxime Coquelin >> --- >> drivers/net/vir

[dpdk-dev] Minutes of Technical Board Meeting, 2021-01-13

2021-01-15 Thread Thomas Monjalon
Members Attending: 9/11 - Bruce Richardson - Ferruh Yigit - Hemant Agrawal - Jerin Jacob - Kevin Traynor - Konstantin Ananyev - Maxime Coquelin - Olivier Matz - Thomas Monjalon (Chair) NOTE: The Technical Board meetings take place every second Wednesday on https://meet.jit.si/DPD

Re: [dpdk-dev] [PATCH 25/40] net/virtio: add Virtio-user features ops

2021-01-15 Thread Maxime Coquelin
On 1/13/21 2:43 PM, Adrian Moreno wrote: > Hi Chenbo > > On 1/6/21 12:54 PM, Xia, Chenbo wrote: >> Hi Maxime, >> >>> -Original Message- >>> From: Maxime Coquelin >>> Sent: Monday, December 21, 2020 5:14 AM >>> To: dev@dpdk.org; Xia, Chenbo ; >>> olivier.m...@6wind.com; >>> amore...@re

Re: [dpdk-dev] [PATCH v2 16/19] app/chkincs: add chkincs app to verify headers

2021-01-15 Thread Thomas Monjalon
15/01/2021 12:59, Bruce Richardson: > On Fri, Jan 15, 2021 at 11:51:49AM +, Ferruh Yigit wrote: > > On 1/15/2021 11:10 AM, Bruce Richardson wrote: > > > To verify that all DPDK headers are ok for inclusion directly in a C > > > file, and are not missing any other pre-requisite headers, we can >

Re: [dpdk-dev] [PATCH V16 1/3] ethdev: introduce FEC API

2021-01-15 Thread Ferruh Yigit
On 10/8/2020 11:02 AM, Min Hu (Connor) wrote: This patch adds Forward error correction(FEC) support for ethdev. Introduce APIs which support query and config FEC information in hardware. Signed-off-by: Min Hu (Connor) Reviewed-by: Wei Hu (Xavier) Reviewed-by: Chengwen Feng Reviewed-by: Chengc

Re: [dpdk-dev] [PATCH] ethdev: introduce generic copy rte flow action

2021-01-15 Thread Jerin Jacob
On Thu, Jan 14, 2021 at 8:32 PM Ori Kam wrote: > > Hi Jerin, > > > -Original Message- > > From: Jerin Jacob > > Sent: Thursday, January 14, 2021 4:00 PM > > Subject: Re: [dpdk-dev] [PATCH] ethdev: introduce generic copy rte flow > > action > > > > On Fri, Jan 8, 2021 at 12:02 PM Alexande

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] mbuf: fix reset on mbuf free

2021-01-15 Thread David Marchand
On Wed, Jan 13, 2021 at 2:28 PM Olivier Matz wrote: > > m->nb_seg must be reset on mbuf free whatever the value of m->next, > because it can happen that m->nb_seg is != 1. For instance in this > case: > > m1 = rte_pktmbuf_alloc(mp); > rte_pktmbuf_append(m1, 500); > m2 = rte_pktmbuf_alloc(mp)

Re: [dpdk-dev] [PATCH v2] eal/windows: build rte_reciprocal functions

2021-01-15 Thread Thomas Monjalon
12/01/2021 00:49, Dmitry Kozlyuk: > On Mon, 11 Jan 2021 15:16:36 -0800, Tyler Retzlaff wrote: > > From: Tyler Retzlaff > > > > build rte_reciprocal.c and export the following functions on windows > > * rte_reciprocal_value > > * rte_reciprocal_value_u64 > > > > Signed-off-by: Tyler Retzlaff

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix start index for showing FEC array

2021-01-15 Thread Ferruh Yigit
On 12/23/2020 6:07 AM, Li, Xiaoyun wrote: -Original Message- From: stable On Behalf Of Rahul Lakkireddy Sent: Monday, December 21, 2020 06:47 To: dev@dpdk.org Cc: kaara.sat...@chelsio.com; sta...@dpdk.org Subject: [dpdk-stable] [PATCH] app/testpmd: fix start index for showing FEC array

Re: [dpdk-dev] [PATCH v3] pci/windows: fix build with SDK >= 10.0.20253

2021-01-15 Thread Thomas Monjalon
14/01/2021 23:06, Dmitry Kozlyuk: > On Thu, 14 Jan 2021 13:22:35 -0800, Tyler Retzlaff wrote: > > NetUIO device class and interface GUIDs are defined in system > > headers starting from platform SDK v10.0.20253. Inspect SDK > > version to avoid redefinition. > > > > Pre-release SDKs do not promise

[dpdk-dev] [PATCH 3/3] net/fm10k: remove vector config

2021-01-15 Thread David Marchand
This config item is not exposed anymore now that we removed make support. Signed-off-by: David Marchand --- drivers/net/fm10k/meson.build | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/fm10k/meson.build b/drivers/net/fm10k/meson.build index fa264f489f..299b9ffb58 100644 --- a/dri

[dpdk-dev] [PATCH 1/3] net/hinic: restore vectorised code

2021-01-15 Thread David Marchand
Following make support removal, the vectorised code is not built anymore, fix the build flag check. Fixes: 3cc6ecfdfe85 ("build: remove makefiles") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- drivers/net/hinic/hinic_pmd_rx.c | 6 +++--- drivers/net/hinic/hinic_pmd_tx.c | 10 +

[dpdk-dev] [PATCH 2/3] net/i40e: remove vector config

2021-01-15 Thread David Marchand
This config item is not exposed anymore now that we removed make support. Note: all architectures provide vectorised functions. Signed-off-by: David Marchand --- drivers/net/i40e/i40e_rxtx.c | 52 drivers/net/i40e/meson.build | 3 --- 2 files changed, 55 del

[dpdk-dev] [PATCH 0/3] net build fixes

2021-01-15 Thread David Marchand
Some fixes following make support removal. The first patch is a real fix. The other two are cleanups so I did not mark them for backport. -- David Marchand David Marchand (3): net/hinic: restore vectorised code net/i40e: remove vector config net/fm10k: remove vector config drivers/net/fm

Re: [dpdk-dev] [PATCH v3 1/3] net/i40e: remove devarg use-latest-supported-vec

2021-01-15 Thread Ferruh Yigit
On 1/14/2021 6:39 AM, Leyi Rong wrote: As eal parameter --force-max-simd-bitwidth is already introduced, to make it more clear when setting rx/tx function, remove devarg use-latest-supported-vec support. Signed-off-by: Leyi Rong Acked-by: Wenzhuo Lu <...> -static eth_rx_burst_t -i40e_get_r

[dpdk-dev] [PATCH v15 10/12] build: disable libnuma in cross builds

2021-01-15 Thread Juraj Linkeš
Some Arm SoCs are not NUMA systems. Add the capability to disable NUMA for cross build and disable NUMA in Arm cross files. Signed-off-by: Juraj Linkeš Reviewed-by: Honnappa Nagarahalli --- config/arm/arm64_armada_linux_gcc | 1 + config/arm/arm64_bluefield_linux_gcc | 1

[dpdk-dev] [PATCH v15 12/12] config: fix Arm implementer and its SoCs

2021-01-15 Thread Juraj Linkeš
Fix the implementer and part number of DPAA and ARMADA SoCs. The current values of 16 cores and 1 NUMA node don't cover all SoCs from the Arm implementer, e.g. Taishan 2280 has 64 cores and 4 NUMA nodes. Increase these to 64 and 4 to widen the coverage. Add configuration to SoC options where smalle

[dpdk-dev] [PATCH v15 11/12] build: add Arm SoC meson option

2021-01-15 Thread Juraj Linkeš
Add Arm SoC configuration to Arm meson.build and add a meson option to enable those options for native builds. This is preferable to specifying a cross file when doing aarch64 -> aarch64 builds, since the cross file specifies the toolchain as well. Signed-off-by: Juraj Linkeš Reviewed-by: Honnapp

[dpdk-dev] [PATCH v15 09/12] build: disable drivers in Arm builds

2021-01-15 Thread Juraj Linkeš
A few options that disabled drivers in the old makefiles were improperly ported to the meson build system. Fix this by adding a to the list of disabled drivers, similarly how the command line option works and remove unneeded driver options ported from the old makefile system, since they don't work

[dpdk-dev] [PATCH v15 08/12] build: add core and NUMA counts to cross files

2021-01-15 Thread Juraj Linkeš
Add support for setting core count and numa nodes in cross files. The values specified in cross files will override the default values. Also add missing default values to Arm config. Signed-off-by: Juraj Linkeš Reviewed-by: Honnappa Nagarahalli --- config/arm/arm64_armada_linux_gcc

[dpdk-dev] [PATCH v15 07/12] build: use native machine args in Arm native build

2021-01-15 Thread Juraj Linkeš
Letting the compiler decide is going to yield the best results for native builds, so use native machine args usable for both GCC and Clang. Signed-off-by: Juraj Linkeš Reviewed-by: Ruifeng Wang --- config/arm/meson.build | 54 ++ 1 file changed, 28 insert

[dpdk-dev] [PATCH v15 05/12] build: organize Arm config into dict

2021-01-15 Thread Juraj Linkeš
Use dictionary lookup instead of checking for existing variables, iterating over all elements in the list or checking lists for optional configuration. Move variable contents into the dictionary for variables that would be referenced only once. Fallback to generic part number if the discovered part

[dpdk-dev] [PATCH v15 06/12] build: isolate configuration for Arm generic build

2021-01-15 Thread Juraj Linkeš
Use generic configuration for the only build where it makes sense - the generic build. For other builds, if we don't know either of implementer ID or part number, the build is not supported. Add part numbers to cross files where fallback to generic configuration is assumed. Signed-off-by: Juraj Li

[dpdk-dev] [PATCH v15 04/12] build: simplify how Arm flags are processed

2021-01-15 Thread Juraj Linkeš
Set flags in one loop. Append flags to a list and use the list in the loop. Signed-off-by: Juraj Linkeš Reviewed-by: Honnappa Nagarahalli --- config/arm/meson.build | 37 + 1 file changed, 17 insertions(+), 20 deletions(-) diff --git a/config/arm/meson.build

[dpdk-dev] [PATCH v15 03/12] build: reformat and move Arm config and comments

2021-01-15 Thread Juraj Linkeš
Change formatting so that it's more consistent and readable, add/modify comments/stdout messages, move configuration options to more appropriate places and make the order consistent according to these rules: 1. First list generic configuration options, then list options that may be overwritten.

[dpdk-dev] [PATCH v15 02/12] build: remove unused or superfluous variables

2021-01-15 Thread Juraj Linkeš
Remove variables that were either not used, referenced just once or not needed. Signed-off-by: Juraj Linkeš Reviewed-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli --- config/arm/meson.build | 28 +++- 1 file changed, 7 insertions(+), 21 deletions(-) diff --git a/c

[dpdk-dev] [PATCH v15 01/12] build: rename Arm build variables

2021-01-15 Thread Juraj Linkeš
Rename Arm build variables and values so that they better conform to Arm specifications. Also rename generically sounding variable to names that better capture what the variables hold. Rename machine_args_generic to part_number_config_arm since the variable contains more than just the generic mach

[dpdk-dev] [PATCH v15 00/12] Arm build options rework

2021-01-15 Thread Juraj Linkeš
The current way of specifying Arm configuration options is insufficient since we can't identify the SoC we're building for from the MIDR information. For example, we can't distinguish between N1SDP, Graviton2 or Ampere Altra. Add a way to specify the cpu count and numa node count for cross builds

Re: [dpdk-dev] [PATCH v2 17/19] eal: add missing include to mcslock

2021-01-15 Thread Honnappa Nagarahalli
> > Include 'rte_branch_prediction.h' to get the likely/unlikely macro > definitions. > > Fixes: 2173fb61 ("mcslock: add MCS queued lock implementation") > Cc: sta...@dpdk.org > > Signed-off-by: Bruce Richardson Reviewed-by: Honnappa Nagarahalli > --- > lib/librte_eal/include/generic

[dpdk-dev] [PATCH v1] power: vm power manager should respect core mask

2021-01-15 Thread David Hunt
when vm_power_manager is started, it takes over power management on all cores. This should be limited to cores defined in the core mask. When initialising, if a core is not on the coremask, skip it. Applies to both initialisation and exit. Signed-off-by: David Hunt --- examples/vm_power_manager

Re: [dpdk-dev] [dpdk-dev v5 0/2] add new UDP tunnel port configure for eCPRI

2021-01-15 Thread Ferruh Yigit
On 1/15/2021 5:15 AM, Jeff Guo wrote: Add new UDP tunnel port configure for eCPRI protocol features v5: fix a coding style issue. v4: add doc in release note for all related eCPRI features. v3: seperate the patch set and add some document Jeff Guo (2): ethdev: add new tunnel type for eCPRI

Re: [dpdk-dev] [dpdk-dev v5 2/2] app/testpmd: add new UDP tunnel port for eCPRI

2021-01-15 Thread Ferruh Yigit
On 1/15/2021 5:15 AM, Jeff Guo wrote: Add new UDP tunnel port params for eCPRI configuration, the command as below: testpmd> port config 0 udp_tunnel_port add ecpri 6789 testpmd> port config 0 udp_tunnel_port rm ecpri 6789 Signed-off-by: Jeff Guo Reviewed-by: Ferruh Yigit

Re: [dpdk-dev] [dpdk-dev v5 1/2] ethdev: add new tunnel type for eCPRI

2021-01-15 Thread Ferruh Yigit
On 1/15/2021 5:15 AM, Jeff Guo wrote: Add type of RTE_TUNNEL_TYPE_ECPRI into the enum of ethdev tunnel type. Signed-off-by: Jeff Guo Reviewed-by: Qi Zhang Reviewed-by: Ferruh Yigit --- doc/guides/rel_notes/release_21_02.rst | 15 ++- lib/librte_ethdev/rte_ethdev.h | 1

Re: [dpdk-dev] [PATCH v14 05/12] build: organize Arm config into dict

2021-01-15 Thread Juraj Linkeš
> -Original Message- > From: Ruifeng Wang > Sent: Friday, January 15, 2021 9:38 AM > To: Juraj Linkeš ; bruce.richard...@intel.com; > Honnappa Nagarahalli ; Phil Yang > ; vcchu...@amazon.com; Dharmik Thakkar > ; jerinjac...@gmail.com; > hemant.agra...@nxp.com; Ajit Khaparde (ajit.khapa..

[dpdk-dev] [PATCH] mem: improve parameter checking on memory hotplug

2021-01-15 Thread Anatoly Burakov
Currently, we don't check anything that comes in through memory hotplug subsystem using the IPC, because we always assume the data is correct. This is okay as anyone having access to the IPC socket would also have rights to crash the DPDK process through other means, but it's still a good practice

Re: [dpdk-dev] [PATCH 40/40] net/virtio: move Vhost-vDPA data to its backend

2021-01-15 Thread Maxime Coquelin
On 1/7/21 7:50 AM, Xia, Chenbo wrote: > Hi Maxime, > >> -Original Message- >> From: Maxime Coquelin >> Sent: Monday, December 21, 2020 5:14 AM >> To: dev@dpdk.org; Xia, Chenbo ; olivier.m...@6wind.com; >> amore...@redhat.com; david.march...@redhat.com >> Cc: Maxime Coquelin >> Subject

Re: [dpdk-dev] [PATCH 38/40] net/virtio: move Vhost-user specifics to its backend

2021-01-15 Thread Maxime Coquelin
On 1/7/21 7:32 AM, Xia, Chenbo wrote: > Hi Maxime, > >> -Original Message- >> From: Maxime Coquelin >> Sent: Monday, December 21, 2020 5:14 AM >> To: dev@dpdk.org; Xia, Chenbo ; olivier.m...@6wind.com; >> amore...@redhat.com; david.march...@redhat.com >> Cc: Maxime Coquelin >> Subject

Re: [dpdk-dev] [PATCH v2 16/19] app/chkincs: add chkincs app to verify headers

2021-01-15 Thread Bruce Richardson
On Fri, Jan 15, 2021 at 11:51:49AM +, Ferruh Yigit wrote: > On 1/15/2021 11:10 AM, Bruce Richardson wrote: > > To verify that all DPDK headers are ok for inclusion directly in a C > > file, and are not missing any other pre-requisite headers, we can > > auto-generate for each header an empty C

Re: [dpdk-dev] [PATCH 39/40] net/virtio: move Vhost-kernel data to its backend

2021-01-15 Thread Maxime Coquelin
On 1/11/21 9:02 AM, Xia, Chenbo wrote: > Hi Maxime, > >> -Original Message- >> From: Maxime Coquelin >> Sent: Monday, December 21, 2020 5:14 AM >> To: dev@dpdk.org; Xia, Chenbo ; olivier.m...@6wind.com; >> amore...@redhat.com; david.march...@redhat.com >> Cc: Maxime Coquelin >> Subjec

Re: [dpdk-dev] [PATCH v2 16/19] app/chkincs: add chkincs app to verify headers

2021-01-15 Thread Ferruh Yigit
On 1/15/2021 11:10 AM, Bruce Richardson wrote: To verify that all DPDK headers are ok for inclusion directly in a C file, and are not missing any other pre-requisite headers, we can auto-generate for each header an empty C file that includes that header. Compiling these files will throw errors if

Re: [dpdk-dev] [PATCH v2 09/19] ipsec: fix missing header include

2021-01-15 Thread Bruce Richardson
On Fri, Jan 15, 2021 at 11:45:11AM +, Medvedkin, Vladimir wrote: > Hi Bruce, > > Just a one nit, please put before rte_ includes. > Good point, I'll fix if I do a V3. > On 15/01/2021 11:37, Medvedkin, Vladimir wrote: > > > > > > On 15/01/2021 11:10, Bruce Richardson wrote: > > > The rte_

Re: [dpdk-dev] [PATCH v2 09/19] ipsec: fix missing header include

2021-01-15 Thread Medvedkin, Vladimir
Hi Bruce, Just a one nit, please put before rte_ includes. On 15/01/2021 11:37, Medvedkin, Vladimir wrote: On 15/01/2021 11:10, Bruce Richardson wrote: The rte_ipsec_sad.h header used the standard uintXX_t types, but did not include stdint.h header for them. Fixes: 401633d9c112 ("ipsec: ad

Re: [dpdk-dev] [PATCH v2 10/19] fib: fix missing header includes

2021-01-15 Thread Medvedkin, Vladimir
On 15/01/2021 11:10, Bruce Richardson wrote: Add stdint.h to get definitions of standard integer types Fixes: 39e927248416 ("fib: add FIB library") Fixes: 40d41a8a7b34 ("fib: support IPv6") Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson --- lib/librte_fib/rte_fib.h | 1 + lib/librt

Re: [dpdk-dev] [PATCH v2 09/19] ipsec: fix missing header include

2021-01-15 Thread Medvedkin, Vladimir
On 15/01/2021 11:10, Bruce Richardson wrote: The rte_ipsec_sad.h header used the standard uintXX_t types, but did not include stdint.h header for them. Fixes: 401633d9c112 ("ipsec: add inbound SAD API") Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson --- lib/librte_ipsec/rte_ipsec_sad

Re: [dpdk-dev] [PATCH v2 07/19] rib: fix missing header includes

2021-01-15 Thread Medvedkin, Vladimir
On 15/01/2021 11:10, Bruce Richardson wrote: The standard integer types, and the size_t types are missing their required header includes in the rib header file. Fixes: 5a5793a5ffa2 ("rib: add RIB library") Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson --- lib/librte_rib/rte_rib.h |

Re: [dpdk-dev] [PATCH v2 09/19] ipsec: fix missing header include

2021-01-15 Thread Ananyev, Konstantin
> -Original Message- > From: Richardson, Bruce > Sent: Friday, January 15, 2021 11:11 AM > To: dev@dpdk.org > Cc: david.march...@redhat.com; Richardson, Bruce > ; sta...@dpdk.org; Ananyev, Konstantin > ; Iremonger, Bernard > ; Medvedkin, Vladimir > ; Akhil Goyal > Subject: [PATCH v2

Re: [dpdk-dev] [PATCH v2 1/1] doc: fix figure numbering in graph guide

2021-01-15 Thread Thomas Monjalon
14/01/2021 14:42, Jerin Jacob: > On Wed, Jan 13, 2021 at 2:49 PM Thomas Monjalon wrote: > > > > Some figures had a title inside the picture but not in RST file. > > As a consequence, some versions of Sphinx are emitting a warning. > > > > Warning, treated as error: > > doc/guides/p

Re: [dpdk-dev] [PATCH] app/proc-info: fix security context info

2021-01-15 Thread Thomas Monjalon
24/12/2020 08:51, Hemant Agrawal: > static void > -show_security_context(uint16_t portid) > +show_security_context(uint16_t portid, uint8_t inline_offload) > { > - void *p_ctx = rte_eth_dev_get_sec_ctx(portid); > + void *p_ctx; > const struct rte_security_capability *s_cap; > > +

Re: [dpdk-dev] [PATCH v2] bus/dpaa: optimize device name parsing

2021-01-15 Thread Thomas Monjalon
09/11/2020 14:37, Gaetan Rivet: > Device name parsing is done on all buses during device iterations at > either EAL or ethdev levels. > > When a bus implements device name parsing slowly, all iterations are > impacted. Efficient implementation is important. > > The DPAA bus device name parsing ha

Re: [dpdk-dev] [PATCH 35/40] net/virtio: make server mode blocking

2021-01-15 Thread Maxime Coquelin
On 1/7/21 4:20 AM, Xia, Chenbo wrote: > Hi Maxime, > >> -Original Message- >> From: Maxime Coquelin >> Sent: Monday, December 21, 2020 5:14 AM >> To: dev@dpdk.org; Xia, Chenbo ; olivier.m...@6wind.com; >> amore...@redhat.com; david.march...@redhat.com >> Cc: Maxime Coquelin >> Subject

[dpdk-dev] [PATCH v2 19/19] test-meson-builds: add includes check to default x86 build

2021-01-15 Thread Bruce Richardson
Since the includes check is disabled by default, we need to explicitly enable it to have it run. To minimise any extra build time when running the test-meson-builds script, we just add it to the default x86 build. Signed-off-by: Bruce Richardson --- devtools/test-meson-builds.sh | 2 +- 1 file c

  1   2   >