On Thu, Jan 14, 2021 at 10:55:54AM +0000, Bruce Richardson wrote: > > > > This is a private header, it's never exposed---why the change is > > > > needed (not that I have a strong opinion, though)? > > > > > > interesting, i'll look into why/how it is being included and confirm. i > > > suppose the question in the back of my mind is if it is private then > > > why is the header being installed at all?
okay, i now understand how we ended up compiling this header directly. long story short we just had it #include directly somewhere. as you have noted it is a private header. a quick examination of the other installed headers shows that it is not included by any of them. i will update the patch to remove the cast from rte_ethdev_pci.h since it is not necessary. would you also like a patch submitted that stops installing the header. the change will be breaking if any other consumers have made the same mistake as we did. i'm not sure what dpdk's stance is on pulling headers back out of public space. thanks
