[dpdk-dev] [PATCH v1] lib/hash: support non sse42 cpu architecture

2021-01-11 Thread kumar amber
add _SSE42_ flag to enable compilation of sse42 specific instructions only on supported architecture Signed-off-by: kumar amber --- lib/librte_hash/rte_hash_crc.h | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/lib/librte_hash/rte_hash_crc.h b/lib/librte_hash

Re: [dpdk-dev] [PATCH] net/iavf: fix vector id assignment

2021-01-11 Thread Yu, DapengX
Hi Jingjing, I double checked that the max_vectors assignment statement is already ahead of RTE_MIN. And this patch do the same thing as http://patchwork.dpdk.org/patch/86118/. Since patch 86118 is ahead of this one, I guess merging 86118 is preferred. -Original Message- From: Wu, Jing

Re: [dpdk-dev] [PATCH v13 10/12] build: disable libnuma in cross builds

2021-01-11 Thread Juraj Linkeš
> -Original Message- > From: Andrew Boyer > Sent: Monday, January 11, 2021 9:23 PM > To: Juraj Linkeš > Cc: Bruce Richardson ; Ruifeng Wang > ; honnappa.nagaraha...@arm.com; > phil.y...@arm.com; vcchu...@amazon.com; dharmik.thak...@arm.com; > jerinjac...@gmail.com; hemant.agra...@nxp.co

Re: [dpdk-dev] [PATCH] security: allow application to specify UDP ports to PMD

2021-01-11 Thread Tejasree Kondoj
Hi Akhil, Please see inline. Thanks Tejasree > -Original Message- > From: Akhil Goyal > Sent: Tuesday, January 12, 2021 12:50 AM > To: Tejasree Kondoj ; Radu Nicolau > > Cc: Narayana Prasad Raju Athreya ; Anoob Joseph > ; dev@dpdk.org > Subject: [EXT] RE: [PATCH] security: allow applic

Re: [dpdk-dev] [PATCH] net/iavf: fix vector id assignment

2021-01-11 Thread Yu, DapengX
Hi Ting, The following test case is for i40e. if you want to test the case on ice, just ignore step 1. Step1: switch i40evf to iavf # sed -i '/{ RTE_PCI_DEVICE(IAVF_INTEL_VENDOR_ID, IAVF_DEV_ID_ADAPTIVE_VF) },/a { RTE_PCI_DEVICE(IAVF_INTEL_VENDOR_ID, IAVF_DEV_ID_VF) },' drivers/net/ia

Re: [dpdk-dev] [PATCH v3 5/5] net/iavf: fix vector mapping with queue

2021-01-11 Thread Wu, Jingjing
> -Original Message- > From: Xing, Beilei > Sent: Tuesday, January 12, 2021 2:11 PM > To: Wu, Jingjing ; dev@dpdk.org > Cc: Xia, Chenbo ; Lu, Xiuchun > > Subject: RE: [PATCH v3 5/5] net/iavf: fix vector mapping with queue > > Seems the patch is conflict with patch > https://patches.dpdk.

Re: [dpdk-dev] [PATCH] metrics/windows: build rte_metrics library

2021-01-11 Thread Tal Shnaiderman
> Subject: Re: [dpdk-dev] [PATCH] metrics/windows: build rte_metrics library > > On Tue, Jan 12, 2021 at 04:15:34AM +0300, Dmitry Kozlyuk wrote: > > + Pallavi, Khoa > > > > What's the future plan? Once we talked about a script that would > > inspect objects and filter missing functions from the li

Re: [dpdk-dev] [PATCH] net/iavf: fix vector id assignment

2021-01-11 Thread Wu, Jingjing
> -Original Message- > From: Xu, Ting > Sent: Tuesday, January 12, 2021 2:27 PM > To: Yu, DapengX ; Zhang, Qi Z > ; Wu, Jingjing ; Xing, Beilei > > Cc: dev@dpdk.org; Yu, DapengX ; sta...@dpdk.org > Subject: RE: [PATCH] net/iavf: fix vector id assignment > > > -Original Message

[dpdk-dev] [PATCH v2] net/mlx5: enlarge maximal flow priority value

2021-01-11 Thread Dong Zhou
Currently, the maximal flow priority in non-root table to user is 4, it's not enough for user to do some flow match by priority, such as LPM, for one IPV4 address, we need 32 priorities for each bit of 32 mask length. PMD will manage 3 sub-priorities per user priority according to L2, L3 and L4. T

Re: [dpdk-dev] [PATCH v2 0/3] iavf base code update

2021-01-11 Thread Zhang, Qi Z
> -Original Message- > From: Xing, Beilei > Sent: Tuesday, January 12, 2021 2:32 PM > To: Zhang, Qi Z > Cc: Wu, Jingjing ; dev@dpdk.org; Wang, Haiyue > > Subject: RE: [PATCH v2 0/3] iavf base code update > > > > > -Original Message- > > From: Zhang, Qi Z > > Sent: Tuesday,

Re: [dpdk-dev] [PATCH v2 0/3] iavf base code update

2021-01-11 Thread Xing, Beilei
> -Original Message- > From: Zhang, Qi Z > Sent: Tuesday, January 12, 2021 2:10 PM > To: Xing, Beilei > Cc: Wu, Jingjing ; dev@dpdk.org; Wang, Haiyue > ; Zhang, Qi Z > Subject: [PATCH v2 0/3] iavf base code update > > v2: > - fix couple bugs > > Qi Zhang (3): > common/iavf: add su

Re: [dpdk-dev] [PATCH] net/iavf: fix vector id assignment

2021-01-11 Thread Xu, Ting
> -Original Message- > From: dapengx...@intel.com > Sent: Friday, January 8, 2021 6:21 PM > To: Zhang, Qi Z ; Wu, Jingjing ; > Xing, Beilei ; Xu, Ting > Cc: dev@dpdk.org; Yu, DapengX ; sta...@dpdk.org > Subject: [PATCH] net/iavf: fix vector id assignment > > From: YU DAPENG > > The num

Re: [dpdk-dev] [PATCH v3 5/5] net/iavf: fix vector mapping with queue

2021-01-11 Thread Xing, Beilei
Seems the patch is conflict with patch https://patches.dpdk.org/patch/86202/, please help to review. > -Original Message- > From: Wu, Jingjing > Sent: Thursday, January 7, 2021 4:27 PM > To: dev@dpdk.org > Cc: Wu, Jingjing ; Xing, Beilei > ; > Xia, Chenbo ; Lu, Xiuchun > Subject: [PATC

[dpdk-dev] [PATCH v2 3/3] common/iavf: update Copyright date

2021-01-11 Thread Qi Zhang
Updated the Copyright for 2021. Updated FreeBSD IAVF driver of version. Signed-off-by: Qi Zhang --- drivers/common/iavf/README| 4 ++-- drivers/common/iavf/iavf_adminq.c | 2 +- drivers/common/iavf/iavf_adminq.h | 2 +- drivers/common/iavf/iavf_adminq_cmd.h | 2 +- drivers/co

[dpdk-dev] [PATCH v2 2/3] common/iavf: add opcode to set VLAN offload by DCF

2021-01-11 Thread Qi Zhang
Add new opcode VIRTCHNL_OP_DCF_VLAN_OFFLOAD to set VLAN offload by DCF, the virtchnl message includes: 1. A valid target VF 2. Type of VLAN to be supported: outer or inner 3. Ethertype of the VLAN (either 0x8100 or 0x88A8 or 0x9100) 4. VLAN insert settings a). No insert offload, VLAN ID in the p

[dpdk-dev] [PATCH v2 1/3] common/iavf: add support for new VLAN capabilities

2021-01-11 Thread Qi Zhang
Currently VIRTCHNL only allows for VLAN filtering and offloads to happen on a single 802.1Q VLAN. Add support to filter and offload on inner, outer, and/or inner + outer VLANs. This is done by introducing the new capability VIRTCHNL_VF_OFFLOAD_VLAN_V2. The flow to negotiate this new capability is

[dpdk-dev] [PATCH v2 0/3] iavf base code update

2021-01-11 Thread Qi Zhang
v2: - fix couple bugs Qi Zhang (3): common/iavf: add support for new VLAN capabilities common/iavf: add opcode to set VLAN offload by DCF common/iavf: update Copyright date drivers/common/iavf/README| 4 +- drivers/common/iavf/iavf_adminq.c | 2 +- drivers/common/iavf/i

[dpdk-dev] [PATCH v2 3/3] common/iavf: update Copyright date

2021-01-11 Thread Qi Zhang
Updated the Copyright for 2021. Updated FreeBSD IAVF driver of version. Signed-off-by: Qi Zhang --- drivers/common/iavf/README| 4 ++-- drivers/common/iavf/iavf_adminq.c | 2 +- drivers/common/iavf/iavf_adminq.h | 2 +- drivers/common/iavf/iavf_adminq_cmd.h | 2 +- drivers/co

[dpdk-dev] [PATCH v2 2/3] common/iavf: add opcode to set VLAN offload by DCF

2021-01-11 Thread Qi Zhang
Add new opcode VIRTCHNL_OP_DCF_VLAN_OFFLOAD to set VLAN offload by DCF, the virtchnl message includes: 1. A valid target VF 2. Type of VLAN to be supported: outer or inner 3. Ethertype of the VLAN (either 0x8100 or 0x88A8 or 0x9100) 4. VLAN insert settings a). No insert offload, VLAN ID in the p

[dpdk-dev] [PATCH v2 1/3] common/iavf: add support for new VLAN capabilities

2021-01-11 Thread Qi Zhang
Currently VIRTCHNL only allows for VLAN filtering and offloads to happen on a single 802.1Q VLAN. Add support to filter and offload on inner, outer, and/or inner + outer VLANs. This is done by introducing the new capability VIRTCHNL_VF_OFFLOAD_VLAN_V2. The flow to negotiate this new capability is

[dpdk-dev] [PATCH v2 0/3] iavf base code update

2021-01-11 Thread Qi Zhang
v2: - fix couple bugs Qi Zhang (3): common/iavf: add support for new VLAN capabilities common/iavf: add opcode to set VLAN offload by DCF common/iavf: update Copyright date drivers/common/iavf/README| 4 +- drivers/common/iavf/iavf_adminq.c | 2 +- drivers/common/iavf/i

[dpdk-dev] [RFC] eal: add fair reader writer lock

2021-01-11 Thread Stephen Hemminger
Implement fair reader/writer lock based on current DPDK ticket lock. These lock type acts like rte_rwlock() but like ticket lock they are fair for multiple writers. Writers have full priority over readers, a stream of readers will not starve incoming writers which is a serious bug in existing rte_

Re: [dpdk-dev] [EXT] Re: [PATCH v2] net/qede: fix regression introduced by b10231aed1ed

2021-01-11 Thread Rasesh Mody
> From: Jerin Jacob > Sent: Tuesday, January 12, 2021 10:21 AM > > On Mon, Jan 4, 2021 at 7:47 PM Rasesh Mody wrote: > > > > > From: dev On Behalf Of Igor Russkikh > > > Sent: Monday, January 4, 2021 6:15 PM > > > > > > > When calling rte_eth_promiscuous_enable(port_id) followed by > > > > rte_

[dpdk-dev] [PATCH v5] net/axgbe: support sfp module EEPROM

2021-01-11 Thread asomalap
From: Amaranath Somalapuram Adding API for get_module_eeprom and get_module_info. Signed-off-by: Amaranath Somalapuram --- doc/guides/nics/features/axgbe.ini | 1 + drivers/net/axgbe/axgbe_ethdev.c | 2 + drivers/net/axgbe/axgbe_phy.h | 4 + drivers/net/axgbe/axgbe_phy_impl.c | 11

[dpdk-dev] [PATCH v9 4/4] examples/ifpga: add example for opae ifpga API

2021-01-11 Thread Wei Huang
An example application shows how to use opae ifpga APIs. You can test each API by running corresponding command. A guide is also added to show how to run the example. Signed-off-by: Wei Huang --- v2: fix coding style issue in commands.c --- v3: add guide for running example --- v4: fix compilatio

[dpdk-dev] [PATCH v9 3/4] raw/ifpga: add opae API for Cyborg

2021-01-11 Thread Wei Huang
Cyborg is part of OpenStack, it needs some OPAE type APIs to manage PACs (Programmable Acceleration Card) with Intel FPGA. Below major functions are added to meets Cyborg requirements. 1. opae_init_eal() set up EAL environment. 2. opae_cleanup_eal() clean up EAL environment. 3. opae_enumerate() sea

[dpdk-dev] [PATCH v9 2/4] raw/ifpga: add fpga property get function

2021-01-11 Thread Wei Huang
There are three types of property can be got from FPGA, they are implemented in below functions: 1. ifpga_rawdev_get_fme_property() get property of FME (FPGA Management Engine). 2. ifpga_rawdev_get_port_property() get property of FPGA port. 3. ifpga_rawdev_get_bmc_property() get property of BMC

[dpdk-dev] [PATCH v9 1/4] raw/ifpga: add fpga rsu function

2021-01-11 Thread Wei Huang
RSU (Remote System Update) depends on secure manager which may be different on various implementations, so a new secure manager device is implemented for adapting such difference. There are three major functions added: 1. ifpga_rawdev_update_flash() updates flash with specific image file. 2. ifpga_

[dpdk-dev] [PATCH v9 0/4] raw/ifpga: add extra OPAE APIs

2021-01-11 Thread Wei Huang
Cyborg is part of OpenStack, it needs some OPAE APIs to manage devices with Intel FPGA. The first three patches implement extra APIs to meet Cyborg requirement. The last patch add an example to show how to use these APIs. Main changes from v8: - Fix compilation issue of ifpga.rst Wei Huang (4):

Re: [dpdk-dev] [PATCH] net/ice: enlarge ice RXQ rearm thresh to 64

2021-01-11 Thread Zhang, Qi Z
> -Original Message- > From: Rong, Leyi > Sent: Wednesday, January 6, 2021 1:36 PM > To: Zhang, Qi Z ; Lu, Wenzhuo > Cc: dev@dpdk.org; Rong, Leyi > Subject: [PATCH] net/ice: enlarge ice RXQ rearm thresh to 64 > > We observe performance drop on ice AVX512 data path after stop and star

[dpdk-dev] [PATCH v2 0/2] generic copy rte flow action support

2021-01-11 Thread Alexander Kozyrev
Implement a generic copy rte flow API as described in RFC: http://patches.dpdk.org/patch/85384/ This API allows copying a specified number of bits from a source header field to a destination header field. Tag, mark or metadata can also be used as a source/destination to allow saving/overwriting an

[dpdk-dev] [PATCH v2 1/2] ethdev: introduce generic copy rte flow action

2021-01-11 Thread Alexander Kozyrev
Implement a generic copy flow API to allow copying of an arbitrary header field (as well as mark, metadata or tag) to another item. This generic copy mechanism removes the necessity to implement a separate RTE Flow action every time we need to modify a new packet field in the future. A user-provid

[dpdk-dev] [PATCH v2 2/2] app/testpmd: add support for generic copy rte flow action

2021-01-11 Thread Alexander Kozyrev
Add support for the RTE_FLOW_ACTION_COPY_ITEM to the testpmd. Implement CLI to create the copy_item action and supply all the needed parameters to copy an arbitrary packet field (as well as mark, tag or metadata) into another item. Example of the flow is the following: flow create 0 egress group 1

Re: [dpdk-dev] [PATCH] net/ice: fix initialization of RSS look-up table

2021-01-11 Thread Zhang, Qi Z
> -Original Message- > From: Xie, WeiX > Sent: Tuesday, January 12, 2021 10:25 AM > To: Zhang, AlvinX ; Zhang, Qi Z > > Cc: dev@dpdk.org; Zhang, AlvinX ; sta...@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] net/ice: fix initialization of RSS look-up > table > > Tested-by: Xie,WeiX < we

Re: [dpdk-dev] [PATCH] test/event_crypto_adapter: set cipher operation in transform

2021-01-11 Thread Jerin Jacob
On Fri, Jan 8, 2021 at 2:11 PM Ankur Dwivedi wrote: > > The cipher operation in the transform should be set to encrypt. > > Fixes: 74449375237f ("test/event_crypto_adapter: fix configuration") > > Signed-off-by: Ankur Dwivedi @Gujjar, Abhinandan S Please review this. > --- > app/test/test_ev

Re: [dpdk-dev] [PATCH v2] net/qede: change driver's default load parameter

2021-01-11 Thread Jerin Jacob
On Wed, Jan 6, 2021 at 8:47 PM Devendra Singh Rawat wrote: > > > > > -Original Message- > > From: Devendra Singh Rawat > > Sent: Wednesday, January 6, 2021 6:50 PM > > To: dev@dpdk.org; Jerin Jacob Kollanukkaran ; > > ferruh.yi...@intel.com > > Cc: GR-Everest-DPDK-Dev ; Igor > > Russkikh

Re: [dpdk-dev] [PATCH v8] net/iavf: fix invalid RSS combinations rule can be created

2021-01-11 Thread Zhang, Qi Z
> -Original Message- > From: Guo, Jia > Sent: Thursday, January 7, 2021 5:33 PM > To: Yang, MurphyX ; dev@dpdk.org > Cc: Yang, Qiming ; Zhang, Qi Z > ; Yang, SteveX ; Wu, Jingjing > ; Xing, Beilei ; Yang, MurphyX > > Subject: RE: [PATCH v8] net/iavf: fix invalid RSS combinations rule c

Re: [dpdk-dev] [PATCH v8 2/2] examples/vhost: refactor vhost data path

2021-01-11 Thread Jiang, Cheng1
Hi, > -Original Message- > From: Maxime Coquelin > Sent: Monday, January 11, 2021 10:25 PM > To: Jiang, Cheng1 ; Xia, Chenbo > > Cc: dev@dpdk.org; Hu, Jiayu ; Yang, YvonneX > ; Wang, Yinan > Subject: Re: [PATCH v8 2/2] examples/vhost: refactor vhost data path > > > > On 1/11/21 6:52

Re: [dpdk-dev] [EXT] Re: [PATCH v2] net/qede: fix regression introduced by b10231aed1ed

2021-01-11 Thread Jerin Jacob
On Mon, Jan 4, 2021 at 7:47 PM Rasesh Mody wrote: > > > From: dev On Behalf Of Igor Russkikh > > Sent: Monday, January 4, 2021 6:15 PM > > > > > When calling rte_eth_promiscuous_enable(port_id) followed by > > > rte_eth_allmulticast_enable(port_id), the port is not in promisc mode > > > anymore.

[dpdk-dev] [PATCH v9 2/2] examples/vhost: refactor vhost data path

2021-01-11 Thread Cheng Jiang
Change the vm2vm data path to batch enqueue for better performance. Support latest async vhost API, refactor vhost async data path, replace rte_atomicNN_xxx to __atomic_XXX and clean some codes. Signed-off-by: Cheng Jiang Reviewed-by: Jiayu Hu --- examples/vhost/ioat.h | 2 +- examples/vhost/

[dpdk-dev] [PATCH v9 1/2] examples/vhost: add ioat ring space count and check

2021-01-11 Thread Cheng Jiang
Add ioat ring space count and check, if ioat ring space is not enough for the next async vhost packet enqueue, then just return to prevent enqueue failure. Add rte_ioat_completed_ops() fail handler. Signed-off-by: Cheng Jiang Reviewed-by: Jiayu Hu Reviewed-by: Maxime Coquelin --- examples/vhos

[dpdk-dev] [PATCH v9 0/2] examples/vhost: sample code refactor

2021-01-11 Thread Cheng Jiang
Refactor the vhost sample code. Add ioat ring space count and check in ioat callback, optimize vhost data path for batch enqueue, replace rte_atomicNN_xxx to __atomic_XXX and refactor vhost async data path. --- v9: * migrated atomic_XXX to __atomic_XXX and updated git log v8: * rebased codes v7

Re: [dpdk-dev] [PATCH v3 5/5] config: add Arm Neoverse N2

2021-01-11 Thread Jerin Jacob
On Tue, Jan 12, 2021 at 8:28 AM Ruifeng Wang wrote: > > Add Arm Neoverse N2 cpu support. > > Signed-off-by: Ruifeng Wang Acked-by: Jerin Jacob > --- > v3: > Changed arch extension from sve to sve2 as N2 supports sve2. (Honnappa) > > config/arm/arm64_n2_linux_gcc | 17 + > co

Re: [dpdk-dev] [PATCH v3 3/5] net/octeontx: fix build with sve enabled

2021-01-11 Thread Jerin Jacob
On Tue, Jan 12, 2021 at 8:28 AM Ruifeng Wang wrote: > > Building with gcc 10.2 with SVE extension enabled got error: > > {standard input}: Assembler messages: > {standard input}:91: Error: selected processor does not support `addvl > x4,x8,#-1' > {standard input}:95: Error: selected processor doe

Re: [dpdk-dev] [PATCH v3 4/5] common/octeontx2: fix build with sve enabled

2021-01-11 Thread Jerin Jacob
On Tue, Jan 12, 2021 at 8:28 AM Ruifeng Wang wrote: > > Building with gcc 10.2 with SVE extension enabled got error: > > {standard input}: Assembler messages: > {standard input}:4002: Error: selected processor does not support `mov > z3.b,#0' > {standard input}:4003: Error: selected processor doe

Re: [dpdk-dev] [PATCH v2 0/3] bnxt patches

2021-01-11 Thread Ajit Khaparde
On Thu, Dec 24, 2020 at 1:46 AM Somnath Kotur wrote: > > A couple of bnxt PMD fixes and an enhancement > > Somnath Kotur (3): > net/bnxt: fix to init/destroy locks only once > net/bnxt: fix error path handling of dev start op > net/bnxt: check for chip reset in dev stop/close ops Patchset ap

Re: [dpdk-dev] [PATCH v4 0/6] net/bnxt: add support for Stingray2

2021-01-11 Thread Ajit Khaparde
On Mon, Jan 11, 2021 at 9:44 AM Ajit Khaparde wrote: > > Add support for 58818/Stingray2 chip. > The new chip Stingray 2 belongs to the P5 generation. > Some changes in the PMD are required to support this new chip. > This patchset adds the necessary changes. > Please apply. > > v1->v2: rebased to

[dpdk-dev] [PATCH v3 5/5] config: add Arm Neoverse N2

2021-01-11 Thread Ruifeng Wang
Add Arm Neoverse N2 cpu support. Signed-off-by: Ruifeng Wang --- v3: Changed arch extension from sve to sve2 as N2 supports sve2. (Honnappa) config/arm/arm64_n2_linux_gcc | 17 + config/arm/meson.build| 11 ++- 2 files changed, 27 insertions(+), 1 deletion(-) cr

[dpdk-dev] [PATCH v3 4/5] common/octeontx2: fix build with sve enabled

2021-01-11 Thread Ruifeng Wang
Building with gcc 10.2 with SVE extension enabled got error: {standard input}: Assembler messages: {standard input}:4002: Error: selected processor does not support `mov z3.b,#0' {standard input}:4003: Error: selected processor does not support `whilelo p1.b,xzr,x7' {standard input}:4005: Error:

[dpdk-dev] [PATCH v3 3/5] net/octeontx: fix build with sve enabled

2021-01-11 Thread Ruifeng Wang
Building with gcc 10.2 with SVE extension enabled got error: {standard input}: Assembler messages: {standard input}:91: Error: selected processor does not support `addvl x4,x8,#-1' {standard input}:95: Error: selected processor does not support `ptrue p1.d,all' {standard input}:135: Error: select

[dpdk-dev] [PATCH v3 2/5] net/hns3: fix build with sve enabled

2021-01-11 Thread Ruifeng Wang
Building with SVE extension enabled stopped with error: error: ACLE function ‘svwhilelt_b64_s32’ requires ISA extension ‘sve’ 18 | #define PG64_256BIT svwhilelt_b64(0, 4) This is caused by unintentional cflags reset. Fixed the issue by not touching cflags, and using flags defined by compiler

[dpdk-dev] [PATCH v3 1/5] lpm: add sve support for lookup on Arm platform

2021-01-11 Thread Ruifeng Wang
Added new path to do lpm4 lookup by using scalable vector extension. The SVE path will be selected if compiler has flag SVE set. Signed-off-by: Ruifeng Wang --- v2: Fixed tbl8 group index calculation. (Vladimir) lib/librte_eal/arm/include/rte_vect.h | 3 + lib/librte_lpm/meson.build

[dpdk-dev] [PATCH v3 0/5] lpm lookup with sve support

2021-01-11 Thread Ruifeng Wang
Added lpm4 lookupx4 implementation by using Arm SVE extension. The SVE is Scalable Vector Extension which is exposed to the user with a vector length agnostic interface. Refer to [1] for more information about SVE. Configuration was added for Neoverse N2 CPU which has SVE support. Some bugs were

Re: [dpdk-dev] [PATCH] net/ice: fix initialization of RSS look-up table

2021-01-11 Thread Xie, WeiX
Tested-by: Xie,WeiX < weix@intel.com> Regards, Xie Wei > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhang,Alvin > Sent: Friday, January 8, 2021 3:29 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Zhang, AlvinX ; > sta...@dpdk.org > Subject: [dpdk-dev] [PATC

Re: [dpdk-dev] [dpdk-dev v2 1/2] ethdev: add new tunnel type for ecpri

2021-01-11 Thread Zhang, Qi Z
> -Original Message- > From: Thomas Monjalon > Sent: Monday, January 11, 2021 10:54 PM > To: Yigit, Ferruh ; Guo, Jia ; > Zhang, > Qi Z > Cc: Andrew Rybchenko ; Ori Kam > ; Wu, Jingjing ; Yang, Qiming > ; Wang, Haiyue ; > dev@dpdk.org; Gregory Etelson ; > maxime.coque...@redhat.com; j

Re: [dpdk-dev] [PATCH] metrics/windows: build rte_metrics library

2021-01-11 Thread Tyler Retzlaff
On Tue, Jan 12, 2021 at 04:15:34AM +0300, Dmitry Kozlyuk wrote: > + Pallavi, Khoa > > What's the future plan? Once we talked about a script that would inspect > objects and filter missing functions from the list in .map to build .def. Is > MSFT working on it? Or do we choose another way? MSFT has

[dpdk-dev] [PATCH v2] metrics/windows: build rte_metrics library

2021-01-11 Thread Tyler Retzlaff
From: Tyler Retzlaff declare reduced set of exports for rte_metrics on windows and include it in the set of libraries to build and install. rte_metrics_tel* exports depend on conditionally available component. this change minimally allows enabling the building of rte_metrics on windows. Signed-

[dpdk-dev] [PATCH] eal/headers: explicitly cast void * to type *

2021-01-11 Thread Tyler Retzlaff
Explicitly cast void * to type * so that eal headers may be compiled as C or C++. Signed-off-by: Tyler Retzlaff --- lib/librte_eal/windows/include/rte_os.h | 2 +- lib/librte_ethdev/rte_ethdev_pci.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/librte_eal/window

Re: [dpdk-dev] [PATCH] metrics/windows: build rte_metrics library

2021-01-11 Thread Dmitry Kozlyuk
+ Pallavi, Khoa On Mon, 11 Jan 2021 15:37:26 -0800, Tyler Retzlaff wrote: > From: Tyler Retzlaff > > declare reduced set of exports for rte_metrics on windows and include > it in the set of libraries to build and install. > > rte_metrics_tel* exports depend on conditionally available component.

[dpdk-dev] [PATCH v3] maintainers: update maintainers for windows support

2021-01-11 Thread Tyler Retzlaff
Add roret...@linux.microsoft.com as a maintainer for windows support Signed-off-by: Tyler Retzlaff Acked-by: Narcisa Ana Maria Vasile Acked-by: Dmitry Malloy --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index f45c8c1b1..3bbc40ddc 100644 --- a/MA

[dpdk-dev] [PATCH] eal/rwlock: add note about writer starvation

2021-01-11 Thread Stephen Hemminger
The implementation of reader/writer locks in DPDK (from first release) is simple and fast. But it can lead to writer starvation issues. It is not easy to fix this without changing ABI and potentially breaking customer applications that are expect the unfair behavior. Therfore this patch just chang

[dpdk-dev] [PATCH v2] maintainers: update maintainers for windows support

2021-01-11 Thread Tyler Retzlaff
From: Tyler Retzlaff Add roret...@linux.microsoft.com as a maintainer for windows support Signed-off-by: Tyler Retzlaff Acked-by: Narcisa Ana Maria Vasile Acked-by: Dmitry Malloy --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index f45c8c1b1..3b

[dpdk-dev] [PATCH] maintainers: update maintainers for windows support

2021-01-11 Thread Tyler Retzlaff
From: Tyler Retzlaff Add roret...@linux.microsoft.com as a maintainer for windows support Signed-off-by: Tyler Retzlaff Acked-by: Narcisa Ana Maria Vasile --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index f45c8c1b1..3bbc40ddc 100644 --- a/MAIN

[dpdk-dev] [PATCH] build: fix using ELF-only linker flags with COFF

2021-01-11 Thread Dmitry Kozlyuk
The --export-dynamic linker option is only applicable to ELF. On Windows, where COFF is used, it causes warnings: x86_64-w64-mingw32-ld: warning: --export-dynamic is not supported for PE+ targets, did you mean --export-all-symbols? (MinGW) LINK : warning LNK4044: unrecognized option '

Re: [dpdk-dev] [EXTERNAL] [PATCH v3] mlx5: split multi-threaded flows per OS

2021-01-11 Thread Khoa To
> -Original Message- > From: dev On Behalf Of Tal Shnaiderman > Sent: Thursday, January 7, 2021 5:08 AM > To: dev@dpdk.org > Cc: thomas ; ma...@nvidia.com; > rasl...@nvidia.com; ophi...@nvidia.com > Subject: [EXTERNAL] [dpdk-dev] [PATCH v3] mlx5: split multi-threaded flows > per OS > >

Re: [dpdk-dev] [PATCH v2] eal/windows: build rte_reciprocal functions

2021-01-11 Thread Dmitry Kozlyuk
On Mon, 11 Jan 2021 15:16:36 -0800, Tyler Retzlaff wrote: > From: Tyler Retzlaff > > build rte_reciprocal.c and export the following functions on windows > * rte_reciprocal_value > * rte_reciprocal_value_u64 > > Signed-off-by: Tyler Retzlaff > --- FYI, this is the place you could put descr

[dpdk-dev] [PATCH] metrics/windows: build rte_metrics library

2021-01-11 Thread Tyler Retzlaff
From: Tyler Retzlaff declare reduced set of exports for rte_metrics on windows and include it in the set of libraries to build and install. rte_metrics_tel* exports depend on conditionally available component. this change minimally allows enabling the building of rte_metrics on windows. Signed-

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix flow check hairpin split

2021-01-11 Thread Thomas Monjalon
10/01/2021 18:37, Dekel Peled: > Previously, the identification of hairpin queue was done using > mlx5_rxq_get_type() function. > Recent patch replaced it with use of mlx5_rxq_get_hairpin_conf(), > and check of the return value conf != NULL. > The case of return value is NULL (queue is not hairpin)

[dpdk-dev] [PATCH v2] eal/windows: build rte_reciprocal functions

2021-01-11 Thread Tyler Retzlaff
From: Tyler Retzlaff build rte_reciprocal.c and export the following functions on windows * rte_reciprocal_value * rte_reciprocal_value_u64 Signed-off-by: Tyler Retzlaff --- lib/librte_eal/common/meson.build | 1 + lib/librte_eal/rte_eal_exports.def | 2 ++ 2 files changed, 3 insertions(+

[dpdk-dev] [PATCH v2] eal/windows: build rte_reciprocal functions

2021-01-11 Thread Tyler Retzlaff
v2 of the patch corrects the following feedback. * reduce subject line length, take that recommended by Dmitry Kozlyuk * mirror export function order in .def to that of .map * add export of rte_reciprocal_value thanks

Re: [dpdk-dev] [PATCH v3] mlx5: split multi-threaded flows per OS

2021-01-11 Thread Thomas Monjalon
07/01/2021 14:08, Tal Shnaiderman: > multi-threaded flows feature uses pthread function pthread_key_create > but for Windows the destruction option in the function is unimplemented. > > to resolve it Windows will implement destruction mechanism to cleanup > mlx5_flow_workspace object for each term

Re: [dpdk-dev] [PATCH v9 0/2] support generic threading functions

2021-01-11 Thread Thomas Monjalon
06/01/2021 21:35, Tal Shnaiderman: > Tal Shnaiderman (2): > eal: move thread affinity functions to new file > eal: add generic thread-local-storage functions Acked and applied with required minor changes, thanks.

Re: [dpdk-dev] [PATCH 4/4] test/lpm: improve coverage on tbl8

2021-01-11 Thread David Christensen
On 1/8/21 12:21 AM, Ruifeng Wang wrote: Existing test cases create 256 tbl8 groups for testing. The number covers only 8 bit next_hop/group field. Since the next_hop/group field had been extended to 24-bits, creating more than 256 groups in tests can improve the coverage. Coverage was not exp

Re: [dpdk-dev] [PATCH 3/4] lpm: fix vector lookup for ppc64

2021-01-11 Thread David Christensen
On 1/8/21 12:21 AM, Ruifeng Wang wrote: rte_lpm_lookupx4 could return wrong next hop when more than 256 tbl8 groups are created. This is caused by incorrect type casting of tbl8 group index that been stored in tbl24 entry. The casting caused group index truncation and hence wrong tbl8 group be

[dpdk-dev] [dpdk-announce] DPDK Summit APAC: CFP closes Jan. 22

2021-01-11 Thread Jill Lovato
Hello DPDK Community, Heads-up that the deadline to submit CPFs for DPDK Summit APAC (March 22-23, virtual) has been extended. The new deadline is JANUARY 22. APPLY & REGISTER HERE: https://events.linuxfoundation.org/dpdk-summit-apac/program/cfp/#dates-to-remember We encourage anyone interested

Re: [dpdk-dev] [PATCH v3] drivers/common: enable Windows common mlx5 compilation

2021-01-11 Thread Thomas Monjalon
03/01/2021 09:00, Tal Shnaiderman: > From: Ophir Munk > > Prior to this commit meson did not progress beyond directory > drivers/common for Windows compilations. This commit enables drivers > compilation under this directory. > > Signed-off-by: Ophir Munk > Signed-off-by: Tal Shnaiderman > Ac

Re: [dpdk-dev] [PATCH] build rte_reciprocal.c on windows and export rte_reciprocal_value_u64

2021-01-11 Thread Dmitry Kozlyuk
Subject line is too long and doesn't follow the guidelines: https://doc.dpdk.org/guides/contributing/patches.html#commit-messages-subject-line It could be: "eal/windows: build rte_reciprocal functions" or better. > diff --git a/lib/librte_eal/rte_eal_exports.def > b/lib/librte_eal/rte_eal_expor

Re: [dpdk-dev] [PATCH v14 03/12] build: reformat and move Arm config and comments

2021-01-11 Thread Andrew Boyer
> On Dec 23, 2020, at 6:47 AM, Juraj Linkeš wrote: > > Change formatting so that it's more consistent and readable, add/modify > comments/stdout messages, move configuration options to more appropriate > places and make the order consistent according to these rules: > 1. First list generic con

Re: [dpdk-dev] [PATCH v13 10/12] build: disable libnuma in cross builds

2021-01-11 Thread Andrew Boyer
> On Nov 20, 2020, at 7:08 AM, Juraj Linkeš wrote: > > Some Arm SoCs are not NUMA systems. Add the capability to disable NUMA > for cross build and disable NUMA in Arm cross files. > > Signed-off-by: Juraj Linkeš > Reviewed-by: Honnappa Nagarahalli > --- > config/arm/arm64_armada_linux_gcc

Re: [dpdk-dev] [PATCH v3] BBDEV: add LDPC op parameters and flags to support CBGT

2021-01-11 Thread Akhil Goyal
Hi Aidan, > > Hi Aidan, > > Some general comments first as I see that this is a first DPDK contribution. > I suggest to add cover-later to provide more context for the serie > and incremental changes between patch versions (see > https://doc.dpdk.org/guides/contributing/patches.html. > When do yo

Re: [dpdk-dev] [PATCH] security: allow application to specify UDP ports to PMD

2021-01-11 Thread Akhil Goyal
Hi Tejasree, > > > > > > > > I think we should add some usage of these newly added params > > > > - either in app/test or in examples/ipsec-secgw > > > > > > [Tejasree] You mean adding test case in either of the above apps or > > > addition of PMD implementation also? Also is the proposal sounds f

Re: [dpdk-dev] [PATCH v7 1/2] cryptodev: support enqueue and dequeue callback functions

2021-01-11 Thread Akhil Goyal
> Subject: [PATCH v7 1/2] cryptodev: support enqueue and dequeue callback > functions > > This patch adds APIs to add/remove callback functions on crypto > enqueue/dequeue burst. The callback function will be called for > each burst of crypto ops received/sent on a given crypto device > queue pair

Re: [dpdk-dev] [PATCH v2 5/6] app/regex: support performance measurements per QP

2021-01-11 Thread David Christensen
-Original Message- From: Thomas Monjalon Sent: Friday, January 8, 2021 11:09 AM To: Ophir Munk Cc: dev@dpdk.org; Ori Kam Subject: Re: [dpdk-dev] [PATCH v2 5/6] app/regex: support performance measurements per QP 20/12/2020 11:41, Ophir Munk: Up to this commit measuring the parsing elap

[dpdk-dev] [PATCH 6/6] net/ionic: correctly set link speed and autonegotiation

2021-01-11 Thread Andrew Boyer
Don't assume autoneg in link_update(). Always call ionic_dev_cmd_port_autoneg() in start(). This allows the client to specify the link settings. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_ethdev.c | 28 ++-- 1 file changed, 22 insertions(+), 6 deletions(-)

[dpdk-dev] [PATCH 5/6] net/ionic: clear up confusion around FC autoneg

2021-01-11 Thread Andrew Boyer
IONIC does not support Flow-Control autonegotiation. Always wait for completion after each dev cmd. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_ethdev.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/net/ionic/ionic_ethdev.c b/drivers

[dpdk-dev] [PATCH 4/6] net/ionic: don't add station MAC filter on init

2021-01-11 Thread Andrew Boyer
The address is not needed in the firmware. This reduces the startup time a bit. Signed-off-by: Andrew Boyer Signed-off-by: Neel Patel --- drivers/net/ionic/ionic_lif.c | 16 1 file changed, 16 deletions(-) diff --git a/drivers/net/ionic/ionic_lif.c b/drivers/net/ionic/ionic_li

[dpdk-dev] [PATCH 3/6] net/ionic: set port admin state to up in port init

2021-01-11 Thread Andrew Boyer
This reduces the startup time a bit. Signed-off-by: Andrew Boyer Signed-off-by: Neel Patel --- drivers/net/ionic/ionic_main.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/drivers/net/ionic/ionic_main.c b/drivers/net/ionic/ionic_main.c index ce5d11311..4676

[dpdk-dev] [PATCH 2/6] net/ionic: combine queue init and enable commands

2021-01-11 Thread Andrew Boyer
Adding F_ENA to the q_init command has the same effect as q_enable. This reduces the startup time a bit. Signed-off-by: Andrew Boyer Signed-off-by: Neel Patel --- drivers/net/ionic/ionic_lif.c | 4 ++-- drivers/net/ionic/ionic_rxtx.c | 8 2 files changed, 6 insertions(+), 6 deletions(

[dpdk-dev] [PATCH 1/6] net/ionic: revise configuration flag handling

2021-01-11 Thread Andrew Boyer
Configuration flags come to the driver in dev_configure(). From there, the driver calls ionic_lif_configure() to update the lif->feature bitfield, and then programs the port. Features like VLAN_RX_FILTER and RX_HASH cannot be disabled in the device, so do nothing in response to requests to disable

[dpdk-dev] [PATCH 0/6] net/ionic: fix device configuration and init

2021-01-11 Thread Andrew Boyer
This patch series fixes up configuration flag handling, fixes up link autonegotiation, and reduces the init time. DTS was used to identify the issues and verify the fixes. Andrew Boyer (6): net/ionic: revise configuration flag handling net/ionic: combine queue init and enable commands net/i

[dpdk-dev] [PATCH] build rte_reciprocal.c on windows and export rte_reciprocal_value_u64

2021-01-11 Thread Tyler Retzlaff
From: Tyler Retzlaff Signed-off-by: Tyler Retzlaff --- lib/librte_eal/common/meson.build | 1 + lib/librte_eal/rte_eal_exports.def | 1 + 2 files changed, 2 insertions(+) diff --git a/lib/librte_eal/common/meson.build b/lib/librte_eal/common/meson.build index 39abf7a0a..9c6f18eb8 100644 ---

[dpdk-dev] [PATCH] build rte_reciprocal.c on windows and export rte_reciprocal_value_u64

2021-01-11 Thread Tyler Retzlaff
From: Tyler Retzlaff --- lib/librte_eal/common/meson.build | 1 + lib/librte_eal/rte_eal_exports.def | 1 + 2 files changed, 2 insertions(+) diff --git a/lib/librte_eal/common/meson.build b/lib/librte_eal/common/meson.build index 39abf7a0a..9c6f18eb8 100644 --- a/lib/librte_eal/common/meson.b

[dpdk-dev] [PATCH v2 6/6] doc: update GTP extension header support

2021-01-11 Thread Shiri Kuzin
added GTP extension header support to mlx5 PMD. The limitations and support were updated in documentation. Signed-off-by: Shiri Kuzin Acked-by: Viacheslav Ovsiienko --- doc/guides/nics/mlx5.rst | 10 ++ doc/guides/rel_notes/release_21_02.rst | 5 + 2 files changed, 1

[dpdk-dev] [PATCH v2 5/6] net/mlx5: add GTP PSC item translation

2021-01-11 Thread Shiri Kuzin
This patch adds the translation function which sets the qfi, PDU type. The next extension header which indicates the following extension header type is set to 0x85 - a PDU session container. Signed-off-by: Shiri Kuzin Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_flow.h| 3 ++

[dpdk-dev] [PATCH v2 4/6] net/mlx5: add GTP PSC flow validation

2021-01-11 Thread Shiri Kuzin
In this patch we add validation routine for GTP PSC extension header. The GTP PSC extension header must follow the GTP item. Signed-off-by: Shiri Kuzin Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_flow.h| 8 drivers/net/mlx5/mlx5_flow_dv.c | 76 +++

[dpdk-dev] [PATCH v2 3/6] common/mlx5: add matcher fields for GTP extensions

2021-01-11 Thread Shiri Kuzin
This is a preparation step to support GTP extension header. In this patch we add the matcher fields that will be used to match on the GTP extension header. Signed-off-by: Shiri Kuzin Acked-by: Viacheslav Ovsiienko --- drivers/common/mlx5/mlx5_prm.h | 7 ++- 1 file changed, 6 insertions(+),

[dpdk-dev] [PATCH v2 2/6] app/testpmd: add GTP PSC option support in raw sets

2021-01-11 Thread Shiri Kuzin
From: Viacheslav Ovsiienko This patch add support for generating GTP PDU container session option for the raw encap and raw decap sets. The generated options is single 32-bit word with minimal length specified as 4, no extra fields in the option are supported. The option item must be preceded wit

[dpdk-dev] [PATCH v2 1/6] ethdev: update GTP headers

2021-01-11 Thread Shiri Kuzin
From: Viacheslav Ovsiienko This patch introduces the GTP header individual flag bit fields and the header optional word with N-PDU number, Sequence Number and Next Extension Header type. Signed-off-by: Viacheslav Ovsiienko Acked-by: Ori Kam --- lib/librte_net/rte_gtp.h | 33 ++

[dpdk-dev] [PATCH v2 0/6] add GTP PSC extension header support

2021-01-11 Thread Shiri Kuzin
In this patch we add the support for GTP PSC in net/mlx5. This will enable matching on "rte_flow_item_gtp_psc" item. The support in testpmd is extended to support raw encap\decap of GTP PSC. v2: - update documentation. - fix PDU type shift. Shiri Kuzin (4): common/mlx5: add matcher fields for

Re: [dpdk-dev] [EXT] Re: [PATCH v3] meson: update meson build for armada drivers

2021-01-11 Thread Luca Boccassi
On Mon, 2021-01-11 at 17:07 +, Bruce Richardson wrote: > On Mon, Jan 11, 2021 at 05:17:01PM +0100, Thomas Monjalon wrote: > > 11/01/2021 17:08, Liron Himi: > > > From: Thomas Monjalon > > > Sent: Monday, 11 January 2021 18:05 > > > To: Liron Himi > > > Cc: ferruh.yi...@intel.com; dev@dpdk.or

  1   2   3   >