Hi Tejasree, > > > > > > > > I think we should add some usage of these newly added params > > > > - either in app/test or in examples/ipsec-secgw > > > > > > [Tejasree] You mean adding test case in either of the above apps or > > > addition of PMD implementation also? Also is the proposal sounds fine? > > > > > I would say both, so that the newly added parameters are tested. > > I am ok with the proposal with a minor comment, > > > > We can have udp_src_port and udp_dst_port directly into > > rte_security_ipsec_xform Instead of adding a new struct > > rte_security_ipsec_udp_encapsulation. > > [Tejasree] Okay. We'll defer the patch for now. > Will add usage of the params and address the comment later. > Any updates on this patch.
Regards, Akhil
